From patchwork Wed Apr 21 02:25:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yejune Deng X-Patchwork-Id: 12215287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980DAC433ED for ; Wed, 21 Apr 2021 02:25:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C4A261413 for ; Wed, 21 Apr 2021 02:25:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C4A261413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 806DD6B006C; Tue, 20 Apr 2021 22:25:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B8036B006E; Tue, 20 Apr 2021 22:25:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657FF6B0070; Tue, 20 Apr 2021 22:25:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 462426B006C for ; Tue, 20 Apr 2021 22:25:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ECE6E45AB for ; Wed, 21 Apr 2021 02:25:27 +0000 (UTC) X-FDA: 78054782694.09.BB5C31C Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf21.hostedemail.com (Postfix) with ESMTP id 139B5E00010E for ; Wed, 21 Apr 2021 02:25:24 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id m11so27230538pfc.11 for ; Tue, 20 Apr 2021 19:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4dCJhI1fJvUae+RK1az1zv2HWWPb9fK682R4tcWUrdw=; b=WB5zZwfCqIVs7HgZ87AobyF4tz7HDBk0ZqdY/tjhYPQSkYqJGnyKTdC23bGM7v4wSn hRE6tncwr0sZMLV1ayrJ9udYmY6RvBpcoX22IQJkhmt5in8lbRAst9jRsFXT3VNj9BM6 k8/hRYeo/XKxO4bptdslAwJu0UosAoCex7RzQtKh65pqcTI40OZZ8TKTlgygkkz9j1DI HJhI8/bBHizyryLAs6ODGTwMBiBbGb5TNNZDcAsaKHNykW7qmH+vFIqxNJR6TyT5GJDg 8CVc0ZPK3KdcgDn46pWTIg3u9YIO53bpwrtBzrSeatwP8Nvban02UM7BEZfczcQSp7Ru /Ufg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4dCJhI1fJvUae+RK1az1zv2HWWPb9fK682R4tcWUrdw=; b=V+ZVtMFPSMNZo0tY43EHfaTedmpWwr0CPek+Bf2US+Noz5ZAXAEfqPX2sQnm1ORGd2 cZ2WSOM+KSKWPO21paSckr2znSobMzY+oozXn3VjLxC0ZdFQnp3FRJOTMhQS1cLaeAPy DkGMQ+SFllgp0e60oTGgZ/h1wBZH4LQOg7dT/ZoSW6ZTAEjym0gvdgDI/31IPh8iO6F5 /gtBkg4EKtfgtumBQ5TtLEA1Uo53o20ySVUvw1NrjWCOGQUDjj6EoLeDrCnyyAvLMuLb qizUQ+PG4uBlwHNsKPgE5kFaRnmiMcSLZzs/AjpB2QGtqKoKwdaEU+PqCCNAFNv5o0Bq 6H9A== X-Gm-Message-State: AOAM531Gnaixcbok6gQSkmKU4AtIUV2wIbR0gOLIEUHXA1xl7qda7CU+ 2iKaIoBScYorVHmTfxsBr+I= X-Google-Smtp-Source: ABdhPJx2BVmJvDjs+S+GjL1n4IfWIXRiYNYSrxk9wJ6LVMcArDvbYJ2vtVLbCbtb8HcIUrJFpY/39w== X-Received: by 2002:a17:90a:e54c:: with SMTP id ei12mr8185477pjb.164.1618971926628; Tue, 20 Apr 2021 19:25:26 -0700 (PDT) Received: from localhost.localdomain ([122.10.161.207]) by smtp.gmail.com with ESMTPSA id x18sm279583pfp.57.2021.04.20.19.25.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Apr 2021 19:25:26 -0700 (PDT) From: Yejune Deng To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yejune Deng Subject: [PATCH] mm/slab.c: use 'ac' from the caller Date: Wed, 21 Apr 2021 10:25:17 +0800 Message-Id: <20210421022518.67451-1-yejune.deng@gmail.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 139B5E00010E X-Stat-Signature: ok1o3pgsxxk75grpc7srcpyofpmcgp4d Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-pf1-f178.google.com; client-ip=209.85.210.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618971924-970674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It can use 'ac' from ____cache_alloc() in cache_alloc_refill(). This saves call cpu_cache_get() twice. Signed-off-by: Yejune Deng --- mm/slab.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index d0f725637663..4b2dc8f8cc37 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2896,11 +2896,11 @@ static __always_inline int alloc_block(struct kmem_cache *cachep, return batchcount; } -static void *cache_alloc_refill(struct kmem_cache *cachep, gfp_t flags) +static void *cache_alloc_refill(struct kmem_cache *cachep, struct array_cache *ac, gfp_t flags) { int batchcount; struct kmem_cache_node *n; - struct array_cache *ac, *shared; + struct array_cache *shared; int node; void *list = NULL; struct page *page; @@ -2908,7 +2908,6 @@ static void *cache_alloc_refill(struct kmem_cache *cachep, gfp_t flags) check_irq_off(); node = numa_mem_id(); - ac = cpu_cache_get(cachep); batchcount = ac->batchcount; if (!ac->touched && batchcount > BATCHREFILL_LIMIT) { /* @@ -3045,12 +3044,7 @@ static inline void *____cache_alloc(struct kmem_cache *cachep, gfp_t flags) } STATS_INC_ALLOCMISS(cachep); - objp = cache_alloc_refill(cachep, flags); - /* - * the 'ac' may be updated by cache_alloc_refill(), - * and kmemleak_erase() requires its correct value. - */ - ac = cpu_cache_get(cachep); + objp = cache_alloc_refill(cachep, ac, flags); out: /*