From patchwork Wed Apr 21 12:05:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 12216059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10727C433B4 for ; Wed, 21 Apr 2021 12:08:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DA4661448 for ; Wed, 21 Apr 2021 12:08:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DA4661448 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB3F91697; Wed, 21 Apr 2021 14:07:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB3F91697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619006902; bh=hw/RmRvvXPsdKCq3Xbnq8bfzeZ5PtXx0kGKUopsA0Y8=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FYrPiZTW0w5jDGIDDV6MNro+nGktiUbE1zBxkBtoBePN15jXvo4/r4MLsrxSxHTwF bHOADeYPpYDdrxWqMAWdly8ifff0iFECO4sAlVptF8MkVqqU9Qc7Q5Ctc+e+46bPv3 EVe4YT45CwApvfn/H5t7c9U6ocqKTXGp2j0RVwMI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E9742F80475; Wed, 21 Apr 2021 14:06:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A9A70F8042F; Wed, 21 Apr 2021 14:06:01 +0200 (CEST) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09AC5F8028B for ; Wed, 21 Apr 2021 14:05:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09AC5F8028B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="bZvUjjNL" Received: by mail-ej1-x634.google.com with SMTP id n2so63112219ejy.7 for ; Wed, 21 Apr 2021 05:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ikxfjDLYuq4kmVi2M+ovf7fio+tFDbJkofoad8Wbu0g=; b=bZvUjjNLNycuXvipWLEzb+IRDabF3NqVkumB+urNNTl1cXvQ2tbDoeaNQ+PV5jhBNb GOvF3LjcGgB2+6qQxDUg0dNiPQE2ty6uqGkRF8xa0G4M9wpqV/H2yG5fCngolCGOo0WJ rd00FfT39Ifgw26+2uofxT58NA9nGLilcFP+CL0jDI5LmCEmi+bTsQ2cvZfkZlAe+3ZN hjJZLJtXl7mU0cH4gGwf43urBY68qMCCK///rYWYaqeOIJCUhD17TEunZVjX9MWDhdc5 3CpvuPAMLadNQ87jHpKdxLDhWKilWpHc6QiKBEe9Lg4CEhPvwBic+zkAgU6aCm//X8RO gazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ikxfjDLYuq4kmVi2M+ovf7fio+tFDbJkofoad8Wbu0g=; b=dps8QU3RaEhEwC73oU0vx8UuiHbbM3m6acBTBP+2hveN+Hm+T+MkKhrxljRursK7wB XWKJ/6lc4PtJf9FBC7/48rZTRLI3Zx1zDl7fJ/5QMIC9uWiP3i5mO6gLigl3hKu6vm9Y gdp3XmEPBMVDdqBciaNwj+haMSIHj1mwuWO2mxnzbbl8AgbDKvGsWlhVC2VuusvgA7l8 rHe2jnOLcPLfIWVUs5jDhCrLdxMIsqtegUcIOWURkLg19qrfEAhPoaf+ccc2zFhSUCEm KBnjIJd5P36iVWCG6zfHTJYHNhqLu0vl3d2PJkYmpbHTJErNGCDiO4tnaTpcO7+/QRwO S4WQ== X-Gm-Message-State: AOAM5308OveMe6tFBJFzDh98NDd/2ZitWcdj5q+zmGdHUsd7e+f+wG7G KGV5C7cY0Z4JLCPhBjmjYczMCA== X-Google-Smtp-Source: ABdhPJy+yR5RdrEp9RuiwBCe5WB4EkVI5Wk0TTahYh4a4mJGaGvyiF6KNG2gJb5W7XsSeHzL/Eoyzw== X-Received: by 2002:a17:907:d06:: with SMTP id gn6mr30014894ejc.449.1619006737773; Wed, 21 Apr 2021 05:05:37 -0700 (PDT) Received: from localhost.localdomain (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id n2sm3151431edi.32.2021.04.21.05.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 05:05:37 -0700 (PDT) From: Jerome Brunet To: Mark Brown Subject: [PATCH v2 1/5] ASoC: stm32: properly get clk from the provider Date: Wed, 21 Apr 2021 14:05:08 +0200 Message-Id: <20210421120512.413057-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421120512.413057-1-jbrunet@baylibre.com> References: <20210421120512.413057-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Reviewed-by: Stephen Boyd Signed-off-by: Jerome Brunet --- sound/soc/stm/stm32_sai_sub.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 3aa1cf262402..c1561237ee24 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -484,7 +484,10 @@ static int stm32_sai_add_mclk_provider(struct stm32_sai_sub_data *sai) dev_err(dev, "mclk register returned %d\n", ret); return ret; } - sai->sai_mclk = hw->clk; + + sai->sai_mclk = devm_clk_hw_get_clk(dev, hw, NULL); + if (IS_ERR(sai->sai_mclk)) + return PTR_ERR(sai->sai_mclk); /* register mclk provider */ return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); From patchwork Wed Apr 21 12:05:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 12216061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B463C43461 for ; Wed, 21 Apr 2021 12:09:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F176C6144D for ; Wed, 21 Apr 2021 12:09:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F176C6144D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 68FA21693; Wed, 21 Apr 2021 14:08:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 68FA21693 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619006942; bh=00HEu767C/qnCs+HO53u4HT6t0ElgPAPFT66hdkr7Po=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=l2z8BvOVBVo+fBgQmYSG5VZfUdfVQu1sq89j2Od0t31E6SBjukwy1yGXN9Z+4j/rR 1Y6Wchnv+t6OQWO4YFRyCDf8MyfkCCyEn151Gpz2B64V03vYtAesL6fOeUUGrGgUDB D2W/aHQyxXcXJgHFm/pPsy4s+cQG3deWfNX/nf5M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 27617F8019B; Wed, 21 Apr 2021 14:07:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8E615F80256; Wed, 21 Apr 2021 14:07:20 +0200 (CEST) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EB77AF8019B for ; Wed, 21 Apr 2021 14:05:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EB77AF8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="GlEpzyx3" Received: by mail-ej1-x62d.google.com with SMTP id l4so63098085ejc.10 for ; Wed, 21 Apr 2021 05:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q07ykK1ULP/ibg/9n8NoWYiD7j6jQhiXQ7i84QPtE0Y=; b=GlEpzyx33lz2gU7/Cbybd7BmusmOb3nqZ5HKZrMSLaEymWqWB8Dlyn46d1wKW+COtJ vmDAxQloBKobz/H9kB+oX3FztRh0L4taHYosZPSEl5uncPiXP+fCNkVfOnQFDcoDmnDB uk53AfRTecstSOupxjGt9ch0kylNgcscHh2k38A5Th6h4udN78wHeToJzLvB0JEDltdU rnJyo39H9Vo0H6j3rSCorI1JUUh1DPwO3u2Lj3vILFK/XvL0Zn6nBap2CItrNcxKHCjt vVh13F0llFljsu3UPRCX8oICbcRecrAo7l+ekw+bANViX4OGjobvCTN7FhUxJMijGfXN 2iMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q07ykK1ULP/ibg/9n8NoWYiD7j6jQhiXQ7i84QPtE0Y=; b=uTlmelqQYAV+1/7En+r2Nzad2al7hW43/prZ280arGp6tHHOMZb+1TIBxR6MW0S1E+ QU+2WPOn9U8dJNZrgZZrSufVY3WBZtGQx13NJZk5nosBdJaGM3e7hhv5xQvI7y2cfG2i dS5izo54dIhQMldTfzSzTGU4H8AJxmLvwaayw9B873vecMWjHiyLH+tVRT8O74qo6eHV iFjuX0hNvAgLcXhtXVmG5N1qxtbloeUR2+PsZ/m5s5ETvwoZKbqHO6OzRovvS8rke1bY l8t+aNix5R+pE+h0GDHD5EUlpGLyJc187Q4e1H5hNAbYS/mJE8Y0IXE3EgNLauIZOrBY /hBg== X-Gm-Message-State: AOAM5308ZhFOsmZD0V3RsT9Hcu8RUC2lQm/ScDGkv01h+I2WbDN89fkh SDPNbOPDe7VxzteFMBu2oibuaQ== X-Google-Smtp-Source: ABdhPJz8xMgQctTHmyAVj6SIEVsTVax+NgsmvHwYH7mxMv4oHBE1Oez6RhdvfJn20KsLb9jcdu37Ug== X-Received: by 2002:a17:906:1749:: with SMTP id d9mr31355615eje.12.1619006738497; Wed, 21 Apr 2021 05:05:38 -0700 (PDT) Received: from localhost.localdomain (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id n2sm3151431edi.32.2021.04.21.05.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 05:05:38 -0700 (PDT) From: Jerome Brunet To: Mark Brown Subject: [PATCH v2 2/5] ASoC: wcd934x: use the clock provider API Date: Wed, 21 Apr 2021 14:05:09 +0200 Message-Id: <20210421120512.413057-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421120512.413057-1-jbrunet@baylibre.com> References: <20210421120512.413057-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock providers should use the clk_hw API Reviewed-by: Stephen Boyd Signed-off-by: Jerome Brunet --- sound/soc/codecs/wcd934x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index cddc49bbb7f6..046874ef490e 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2116,11 +2116,13 @@ static struct clk *wcd934x_register_mclk_output(struct wcd934x_codec *wcd) wcd->hw.init = &init; hw = &wcd->hw; - ret = clk_hw_register(wcd->dev->parent, hw); + ret = devm_clk_hw_register(wcd->dev->parent, hw); if (ret) return ERR_PTR(ret); - of_clk_add_provider(np, of_clk_src_simple_get, hw->clk); + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); + if (ret) + return ERR_PTR(ret); return NULL; } From patchwork Wed Apr 21 12:05:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 12216033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4443EC433B4 for ; Wed, 21 Apr 2021 12:07:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57DB36144C for ; Wed, 21 Apr 2021 12:07:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57DB36144C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9315E1682; Wed, 21 Apr 2021 14:06:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9315E1682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619006850; bh=ZY4yGYgTdCze3juMQjrmVSfuqcjhzaQvmNuCo5yEzMo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AGeF4Yp9VhopV4pRa3KYvEIq2q6RVuRc2fzSKNeEyztso4P7/RGfwO+pSJLzUptVg 0pCJf/rIqjLOQZklkbbIAHTW3pYNi+4NRJuhPjA+8+qSFbfS7elddPXK/Aqt55tqIO 1Y9ZNsVy5MqQt3jtGxROqAtCjDYBBbMnG2RjXWcs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5A303F8025A; Wed, 21 Apr 2021 14:05:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F08AF8032C; Wed, 21 Apr 2021 14:05:55 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7878CF80256 for ; Wed, 21 Apr 2021 14:05:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7878CF80256 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ZQiDoc4I" Received: by mail-ej1-x62c.google.com with SMTP id v6so61830948ejo.6 for ; Wed, 21 Apr 2021 05:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WBvDDO3AKgp6HTsSIcTOIT+KCHK50v2vbG7h5wPnh6A=; b=ZQiDoc4IpWNOVnVThvEFhumSPBLHtbewiHEKSIHIOSx5I8x7cZt/mJ6PjBZ4zA0WHH MKDdn7s1SFlQHMRAkYerAo60U+rde7gj2KqAYDNb9OtSKpFiqZysc4v6MfwAkWJxRuaq cjNKPpbR/eoyvxrPd9blBLTfJgoNiTPLh9i/NAo/4qljDRN3GFX/KXdHHnMAPap7KaGJ x1Pky1d0iB++nNFBuNsjs9Ny7Nr74NyL+gg3plySGVVtLAAJCjyXgmflkF9WHteXUTKv qpLHYdBIUFKN1lmM3/LgeoZGhnILl5TcaxkJybIf2GpZvSbuOlYIF1Td6GNaRgSSmYfK aVDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WBvDDO3AKgp6HTsSIcTOIT+KCHK50v2vbG7h5wPnh6A=; b=LgO8nKN2QmMbKXHALQw9GD5vFY4jWBFvWLyRnssdQrEGFBS8K5ZcuXMA/Vh1yHskdl YizlEMoDhP9hoQLdrG5T0gcS5fLHxfGZCNYFebUxA05cGdR48GmQ64W28Yb0mXMCEcBD rXgFcDTMzQ9LAgt54biA/4rURGXYK2hMO3BYVQXTfPiFFJSjeao8BkMmRnINzaqp9G+b rkRyifPvDRC3aJ+qk8rrgHnYLsVOEo91nlsYJC4e+Twxsod1w5a0MxzvV+cgDrcSd7XA fIEbS6/jxVIwYMi+726L8KOz8xUOg4L9cEoEnEhCTGqc42+9+BKW6wLu2fm9AbrBxNW5 2E5g== X-Gm-Message-State: AOAM532Rimvcy9eccQmGhGbBA8rjEO6JQ6IW49UXLOUoDnvtWqsX/UPW hKoJfEX+YotGeVc9o3UHuaS4aA== X-Google-Smtp-Source: ABdhPJw7RBl39HDAf6162Lb+vNNYdFWkpn3xny4FcphRHCsNTHcKKiqoBS6LkEYz3O0d7GgbAK6fvw== X-Received: by 2002:a17:906:2818:: with SMTP id r24mr32281084ejc.502.1619006739211; Wed, 21 Apr 2021 05:05:39 -0700 (PDT) Received: from localhost.localdomain (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id n2sm3151431edi.32.2021.04.21.05.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 05:05:38 -0700 (PDT) From: Jerome Brunet To: Mark Brown Subject: [PATCH v2 3/5] ASoC: rt5682: clock driver must use the clock provider API Date: Wed, 21 Apr 2021 14:05:10 +0200 Message-Id: <20210421120512.413057-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421120512.413057-1-jbrunet@baylibre.com> References: <20210421120512.413057-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock drivers ops should not call the clk API but the clock provider (clk_hw) instead. Signed-off-by: Jerome Brunet --- sound/soc/codecs/rt5682.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index a5aacfe01a0d..e4c91571abae 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2634,7 +2634,7 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate, container_of(hw, struct rt5682_priv, dai_clks_hw[RT5682_DAI_WCLK_IDX]); struct snd_soc_component *component = rt5682->component; - struct clk *parent_clk; + struct clk_hw *parent_hw; const char * const clk_name = clk_hw_get_name(hw); int pre_div; unsigned int clk_pll2_out; @@ -2649,8 +2649,8 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate, * * It will set the codec anyway by assuming mclk is 48MHz. */ - parent_clk = clk_get_parent(hw->clk); - if (!parent_clk) + parent_hw = clk_hw_get_parent(hw); + if (!parent_hw) dev_warn(component->dev, "Parent mclk of wclk not acquired in driver. Please ensure mclk was provided as %d Hz.\n", CLK_PLL2_FIN); From patchwork Wed Apr 21 12:05:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 12216055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D145C433ED for ; Wed, 21 Apr 2021 12:07:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 696756140C for ; Wed, 21 Apr 2021 12:07:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696756140C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E63681689; Wed, 21 Apr 2021 14:06:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E63681689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619006855; bh=C33DTRE2PxEosLBmz9kVsY2VAAlAu8loX1FZONKfnIU=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=D4CWEVpdq7as4eLWgQ4Z8Ej74ZZegpodCH8W4iV4KOl9X8v351JinHbkTRwGolb50 RonH2QA73bimzB10z6BsKK8bwi+LCVrWs7rYRj4OgjtsbCCbRobZhX7S9rim6incF6 RWbVWDnykXhmT3OD6XWf3BDtewF3huyC2RtatMII= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 58AD7F800E8; Wed, 21 Apr 2021 14:05:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CCA93F802C4; Wed, 21 Apr 2021 14:05:55 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 346BAF8025A for ; Wed, 21 Apr 2021 14:05:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 346BAF8025A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="tMGUqLts" Received: by mail-ej1-x62b.google.com with SMTP id x12so42376586ejc.1 for ; Wed, 21 Apr 2021 05:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4saZG/mBOFusi/3PnhTOED3xRGrc2E/DVPqnSP5N1B4=; b=tMGUqLts//zB8lVUZgdr7LIydq5ZvwLd5wA32lz8Yo+EJbTv8+Cr7Dfr7hG/1UatVP XGWHgeupRgOA2jANdmYFSgsNqZvTwYYu1R8pPvZBPsqfYZB7+uu7PymmaAxVUvuspXwQ yNLwj2lyMNyIvnKlYpR8yOZKqGvRg+QoBA9EZY6kg0ewtjCX5pgFWYEI+qc8hVnTldcG IRSomtgfm36I9+ccZVfUX/mNRRDS5hp84jbCl0KotEgiZ8mTqaon154bQ7ZoCneaZ1dR h2OSF45ajUGGoQlr2ooa1OkkFez8BwdBoZygjy0A+NpkryfDRtUleThg9eD48mL9+EsF flOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4saZG/mBOFusi/3PnhTOED3xRGrc2E/DVPqnSP5N1B4=; b=RVdlCdFXX85dzLfSLjZrPFGeLZJm/mlJ4iE8ZVIZttQiOIlvkAc4ofoS9pZrcQ6bA+ G/UG/Up76mA4/bofTNBgfjKkafzPCFYs6MV/aoXAufjI99jA1xWT2AWpKLUUWl/qZxi9 87QGxIA0egibQchUtOwOmrVwCcru8r6U8nlQTQg8OSp8qXhL3jw6x0lT3CwJz4J3icWr va0MOKP9+VAH5HfzMLKD6dpZT85rSJasqAOPlzxe6uNgcHiuMk1W+hTme6SoNEUc5L2/ BQ0bycV7/FsFql7oX0TfjZr+F7VbQvICJEjq0lNTSI92cPENtb4syin/3elx9w5U+YcP JVTQ== X-Gm-Message-State: AOAM530xAle1Ijp60I8y/lYAsAD+Rx1RDaLu9XMrZdT95byzMaV6ihzJ LM0RIPq7qVNSl599tA0ktUcHBQ== X-Google-Smtp-Source: ABdhPJxwGk9Wjg5LehSvoZoZIWOwfhhtktCyjSV7rPgIolUcHr7yn1CofvWtPlVgcxdCTTfMWNbVVA== X-Received: by 2002:a17:906:1c83:: with SMTP id g3mr12999618ejh.93.1619006739977; Wed, 21 Apr 2021 05:05:39 -0700 (PDT) Received: from localhost.localdomain (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id n2sm3151431edi.32.2021.04.21.05.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 05:05:39 -0700 (PDT) From: Jerome Brunet To: Mark Brown Subject: [PATCH v2 4/5] ASoC: lpass: use the clock provider API Date: Wed, 21 Apr 2021 14:05:11 +0200 Message-Id: <20210421120512.413057-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421120512.413057-1-jbrunet@baylibre.com> References: <20210421120512.413057-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Clock providers should be registered using the clk_hw API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/lpass-va-macro.c | 7 ++----- sound/soc/codecs/lpass-wsa-macro.c | 11 +++-------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 5294c57b2cd4..56c93f4465c9 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1343,7 +1343,7 @@ static int va_macro_register_fsgen_output(struct va_macro *va) if (ret) return ret; - return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk); + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &va->hw); } static int va_macro_validate_dmic_sample_rate(u32 dmic_sample_rate, @@ -1452,12 +1452,10 @@ static int va_macro_probe(struct platform_device *pdev) va_macro_dais, ARRAY_SIZE(va_macro_dais)); if (ret) - goto soc_err; + goto err; return ret; -soc_err: - of_clk_del_provider(pdev->dev.of_node); err: clk_bulk_disable_unprepare(VA_NUM_CLKS_MAX, va->clks); @@ -1468,7 +1466,6 @@ static int va_macro_remove(struct platform_device *pdev) { struct va_macro *va = dev_get_drvdata(&pdev->dev); - of_clk_del_provider(pdev->dev.of_node); clk_bulk_disable_unprepare(VA_NUM_CLKS_MAX, va->clks); return 0; diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index e79a70386b4b..1a7fa5492f28 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2337,10 +2337,9 @@ static const struct clk_ops swclk_gate_ops = { .recalc_rate = swclk_recalc_rate, }; -static struct clk *wsa_macro_register_mclk_output(struct wsa_macro *wsa) +static int wsa_macro_register_mclk_output(struct wsa_macro *wsa) { struct device *dev = wsa->dev; - struct device_node *np = dev->of_node; const char *parent_clk_name; const char *clk_name = "mclk"; struct clk_hw *hw; @@ -2358,11 +2357,9 @@ static struct clk *wsa_macro_register_mclk_output(struct wsa_macro *wsa) hw = &wsa->hw; ret = clk_hw_register(wsa->dev, hw); if (ret) - return ERR_PTR(ret); - - of_clk_add_provider(np, of_clk_src_simple_get, hw->clk); + return ret; - return NULL; + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); } static const struct snd_soc_component_driver wsa_macro_component_drv = { @@ -2438,8 +2435,6 @@ static int wsa_macro_remove(struct platform_device *pdev) { struct wsa_macro *wsa = dev_get_drvdata(&pdev->dev); - of_clk_del_provider(pdev->dev.of_node); - clk_bulk_disable_unprepare(WSA_NUM_CLKS_MAX, wsa->clks); return 0; From patchwork Wed Apr 21 12:05:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 12216057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328E2C43460 for ; Wed, 21 Apr 2021 12:08:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3157161448 for ; Wed, 21 Apr 2021 12:08:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3157161448 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 632BF169F; Wed, 21 Apr 2021 14:07:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 632BF169F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619006890; bh=d2cOFm6R4HaftzjlQdRMddk2v/Dr/6ssdSxaorlYogw=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=M0ae+GI5/97+qE0uDTxNyWlIspwUEPp03YMkUA50X9nHQ7ry2uXVPimUT9N/sJxIr 0u+GiFVXD6hgnuyNy+orYaEW7qMI9zEwCf3nFs8LjPCWO5+oOYX91EGjZ0E9T2h/6O nod5JSaWZjwu10oEO/yhdDNeCWIA4yJvW2BOcapE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7E215F8028B; Wed, 21 Apr 2021 14:06:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 717CBF80274; Wed, 21 Apr 2021 14:06:01 +0200 (CEST) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6194EF80274 for ; Wed, 21 Apr 2021 14:05:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6194EF80274 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="qOhB6Bn4" Received: by mail-ed1-x529.google.com with SMTP id cq11so5423155edb.0 for ; Wed, 21 Apr 2021 05:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mjz+dO0g52LTTWXvSkIafdv3wxVfZ3PM2K0TUZQe8w8=; b=qOhB6Bn4fdio6Oa+hCIyEtIzF/fPU1n900yfQN1KRUOmt0VxoAXNItjh4iktYz1nFF txn7A0NZdiBTN/SeMc+MDLdsvD0dTlB9+bVCvSjWVm9JTiKHTqOLQRM4X60LqC6QfgDu gCD6ek/S3BQCAozMyvXPVavOf0CNfgcn5b++PicQrqh6Q0nBwkEIfF8GF1ssNiYrIAbV PYUbypf1GVSjexslHQOaf3gRO73TPzn6PY0qIYX1IbLGDYcqY7uYmvr5JXPdZnx0DfZP kXqVGpArZJub0qyfEZkrpe89DBxVvFNegS0bci4vYbotJ+IO9cSymdI4ojNR28q3l/J/ uOQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mjz+dO0g52LTTWXvSkIafdv3wxVfZ3PM2K0TUZQe8w8=; b=EXUWzc/Z7DxFLdmn4iCdY3eMzw1USdz4HN4Scx8/syVIpFLMz8naAJYMBWH1HcMbLB f+vCatEtnh3CbPXeGz3/KVmOGkUQAuxDYg1VABlXcHMRuPG/vDzRjWNeyY4r7R7w5Juo JyUIRxPZhsICB6qgqp/Vj0JCUrYQ8ohxNrO1+LPeRfUahKOFwjXfEXlV8CQARt8EGw0Q jtHELP9WuzdSPXBIi5CadaN03y8rhqnNO3sK86Mbc4uGUwKUMd169bDrzBOWNFj9RRuU np9RmwHXZJAGh3gNvKYPeLn+mOnoGWdARNahrUp/tDMbKhMXN6tpV7ZfKCPAsnH1L7iw 2Dpw== X-Gm-Message-State: AOAM532u1QmMhxMwSOHj4AF2Nyia2ifIyjIHCixtvtBr1nmUbq+hPJV1 NF0LHCYgM/JCc7F5BPqp3MEIsw== X-Google-Smtp-Source: ABdhPJxxLKeeLIx0fL7Nswahk3sJ8ZZX4hGBA1vUHi5Y9fX7pUBLtrsEO39L5a3O2YsxRJ32QemvTA== X-Received: by 2002:aa7:cd83:: with SMTP id x3mr37696169edv.373.1619006740670; Wed, 21 Apr 2021 05:05:40 -0700 (PDT) Received: from localhost.localdomain (82-65-169-74.subs.proxad.net. [82.65.169.74]) by smtp.googlemail.com with ESMTPSA id n2sm3151431edi.32.2021.04.21.05.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 05:05:40 -0700 (PDT) From: Jerome Brunet To: Mark Brown Subject: [PATCH v2 5/5] ASoC: da7219: properly get clk from the provider Date: Wed, 21 Apr 2021 14:05:12 +0200 Message-Id: <20210421120512.413057-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421120512.413057-1-jbrunet@baylibre.com> References: <20210421120512.413057-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Stephen Boyd , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Reviewed-by: Stephen Boyd Signed-off-by: Jerome Brunet --- sound/soc/codecs/da7219.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 13009d08b09a..bd3c523a8617 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -2181,7 +2181,10 @@ static int da7219_register_dai_clks(struct snd_soc_component *component) ret); goto err; } - da7219->dai_clks[i] = dai_clk_hw->clk; + + da7219->dai_clks[i] = devm_clk_hw_get_clk(dev, dai_clk_hw, NULL); + if (IS_ERR(da7219->dai_clks[i])) + return PTR_ERR(da7219->dai_clks[i]); /* For DT setup onecell data, otherwise create lookup */ if (np) {