From patchwork Wed Apr 21 14:09:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahmoud Abumandour X-Patchwork-Id: 12216221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9959DC433B4 for ; Wed, 21 Apr 2021 14:11:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CCF361139 for ; Wed, 21 Apr 2021 14:11:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CCF361139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZDa1-0004Vc-Bm for qemu-devel@archiver.kernel.org; Wed, 21 Apr 2021 10:11:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZDYa-00036Y-Th for qemu-devel@nongnu.org; Wed, 21 Apr 2021 10:10:20 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:35527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZDYX-0003E6-OF for qemu-devel@nongnu.org; Wed, 21 Apr 2021 10:10:20 -0400 Received: by mail-wm1-x32c.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so1404491wmg.0 for ; Wed, 21 Apr 2021 07:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6EqUfSAg+SkgsLP4QrSoWoVHrKhsANzTFjajqpdzr44=; b=CH7dLPpWVg3eYPR7sj7x4WZ2vfXbs2rbXHlXxFZ2pt4wMgua72c4iKU90OpIqvaJxC gIIq4Kky6+bMZ8zxp7KzIHeTb44lnv4jkrbBcFPH8aMCpMmiQzB6ZYorXfWPzXw1thrz 5Q+bdljYyov+KsHJOEgZ3Vqw1EijRBO9bsDz3MHPkskOqHOGJGv5GNs0wPZOTcI2joj5 cSgNS8p73Ni9EwYyopCwa26IctuzrPQ/pBtHJJGooFqX+vKXo+mtKAsZbsnpPgLuW3F2 QCyfRwB4YzIwOGeynbtzHdDYWclYZ2jDclcxucmFfht2AKgTmHatBlewwBDbh0UYlbo2 dxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6EqUfSAg+SkgsLP4QrSoWoVHrKhsANzTFjajqpdzr44=; b=tHnx0CvD/h4PNwADb0t49eTKXuqC/0lJkE56BBKKEOauwZ1ieHluA+BjaFJNmRvJmw QX1hxt5BNVHB9VmZHYGxWj0w1E8Xs5nFqAbV0hVWjp8l0SnKjCnRBQEMRlS95ynisaDl KAJRj6DsdG7kfg+/2ASLXodTVh5PTQAUTzDZxUNYWvygwRLi0xHkobLvbosF3Y86Fknn nI2SW//mV/31WUrCvg8XyID+TmHBe57p9POuP+j80T3T2yRYFaS6jeTe3wVJXAGYrGZC SsZlSwxLtuXsTQOcJYDCLyCvjIJjYXiqHGKDB1JrICuvtxoMyvbDNQ027WCqZ/6lxkQo f9sw== X-Gm-Message-State: AOAM530AR415RZA0DKg01FkoVkYYK3QhFSl2AazLVXMouD8M7J8yp+Oa icunqsyBtIeWkzNaTNebqhXv5/+hvUU= X-Google-Smtp-Source: ABdhPJw1E5/OMqpPh4bf/EQP2WoBVQRqSmyY1GvE+T6rCDvyihtTHKJy389FNx4eSkNdfzBFiOmn1Q== X-Received: by 2002:a7b:c5c8:: with SMTP id n8mr8169231wmk.2.1619014215211; Wed, 21 Apr 2021 07:10:15 -0700 (PDT) Received: from localhost.localdomain ([197.61.162.183]) by smtp.googlemail.com with ESMTPSA id q5sm3273407wrv.17.2021.04.21.07.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 07:10:14 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 1/2] plugins/hotblocks: Properly freed the hash table values Date: Wed, 21 Apr 2021 16:09:33 +0200 Message-Id: <20210421140934.7561-2-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210421140934.7561-1-ma.mandourr@gmail.com> References: <20210421140934.7561-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=ma.mandourr@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Freed the values stored in the hash table ``hotblocks`` returned by ``g_hash_table_get_values()`` by freeing the sorted list and destroyed the hash table afterward. Signed-off-by: Mahmoud Mandour --- contrib/plugins/hotblocks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 4b08340143..64692c0670 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hotblocks.c @@ -68,10 +68,11 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) rec->insns, rec->exec_count); } - g_list_free(it); + g_list_free_full(it, g_free); g_mutex_unlock(&lock); } + g_hash_table_destroy(hotblocks); qemu_plugin_outs(report->str); } From patchwork Wed Apr 21 14:09:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahmoud Abumandour X-Patchwork-Id: 12216219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CFCC433ED for ; Wed, 21 Apr 2021 14:11:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62D6761439 for ; Wed, 21 Apr 2021 14:11:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62D6761439 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZDa0-0004SN-Cg for qemu-devel@archiver.kernel.org; Wed, 21 Apr 2021 10:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZDYa-00036O-9F for qemu-devel@nongnu.org; Wed, 21 Apr 2021 10:10:20 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:41877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZDYX-0003El-Re for qemu-devel@nongnu.org; Wed, 21 Apr 2021 10:10:20 -0400 Received: by mail-wr1-x42e.google.com with SMTP id c4so2612688wrt.8 for ; Wed, 21 Apr 2021 07:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zZpYsYIIWwDjQfBvMvJ2wOCRY7GzZq3+BJCpSNNvhRY=; b=Rd5SHm4jaDQf8q5zC+vWpdwwgQ9yxmzUxnfJFgCnKqLAbSlRzvh/HWayKBifaZiY4V aB367ej4sXVcwv4x6LmmhMuc4BYd3PaGiMVy57AAWvf0Evaggp6ebqITgKy2Bk6bI/Ho tiLh5ElzKKniI+SUMfkExzH2bY18FJDKM/ER8S1dLCSBG3x4GvFNFYibAKmIfgivcfTE 6MFJlhpK/qDVagxbDVsCR7xd3p2vrD0kaTYQWm79eZkMMd72fJWrMLeJRCQFNQttRHlE goSBMjRYwBn/gNquQ6LE/oSbv3G519LXAktcexjPtc1uvvza57SPSwPO/q7AeKBUKbRf UfEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zZpYsYIIWwDjQfBvMvJ2wOCRY7GzZq3+BJCpSNNvhRY=; b=kVjbiq75nH+c0ZjKOHGh0zk/ae3nIaC12kxKAd03045N+5H2Pwb1t8bcnWLdjCR66L Hf2wtWtaWMc0ruUlgv5+O10pAqtmlP5Z6dbWgFkAQaqiZ75Ac472sUrmefSHsCOuOb/o /2Vyj7t0Xe3gwxFp/0jXlcEjAFOuFEhvWoQ3v6Casw8Nz7Q+ziB3wNhUF48/ibQo2TeT i3gYCPhWDOjAkqeytXwFVlaN7mJR1+4WxlbOBcYAaJhmSwWkGPaun5ufMotmfa77WJAE nNichdJDRIr45V+rdjZIIQ+6CPxblg/yq3A/7W8rqqzik3TlKIWrN4smv5cO2qWYvije bYbQ== X-Gm-Message-State: AOAM532j6s6vVJsumSz5l3ltqNWb52I6oM5GWTlyOe85xipvGELV7go/ iKBND8uUZwEu+2z7wF+ZA30i+fGx6NI= X-Google-Smtp-Source: ABdhPJzpDQVqstEK7FpG7/h0ayAkfVLj0fqmKv0BYT6Nk7oMnqhAGhHdsVJGAnVRDwT85tQozbs1Vw== X-Received: by 2002:a5d:4d02:: with SMTP id z2mr27195343wrt.190.1619014216314; Wed, 21 Apr 2021 07:10:16 -0700 (PDT) Received: from localhost.localdomain ([197.61.162.183]) by smtp.googlemail.com with ESMTPSA id q5sm3273407wrv.17.2021.04.21.07.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 07:10:16 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 2/2] plugins/hotpages: Properly freed the hash table values Date: Wed, 21 Apr 2021 16:09:34 +0200 Message-Id: <20210421140934.7561-3-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210421140934.7561-1-ma.mandourr@gmail.com> References: <20210421140934.7561-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=ma.mandourr@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Freed the values stored in the hash table ``pages`` returned by ``g_hash_table_get_values()`` by freeing the sorted list and destroyed the hash table afterward. Signed-off-by: Mahmoud Mandour --- contrib/plugins/hotpages.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c index bf53267532..2094ebd15f 100644 --- a/contrib/plugins/hotpages.c +++ b/contrib/plugins/hotpages.c @@ -94,9 +94,10 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) rec->cpu_read, rec->reads, rec->cpu_write, rec->writes); } - g_list_free(it); + g_list_free_full(it, g_free); } + g_hash_table_destroy(pages); qemu_plugin_outs(report->str); }