From patchwork Thu Apr 22 10:17:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lukasz Stelmach X-Patchwork-Id: 12218173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552F5C433B4 for ; Thu, 22 Apr 2021 10:19:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A50AE60C40 for ; Thu, 22 Apr 2021 10:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A50AE60C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:MIME-Version:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=irYFPzITscQLFN2YKf4jV6s8NULBCpc3FLnMOfRF6+E=; b=j4sdMrM6KKKVd4+1SUUWD8VQ0 ixnIokCZW6av8LrD+7ZulobZlQ71EQw0eXfiBl7J7N14V5FVl90+CFQXJovV/PTEXNMnnzWKTzQph ECsb2RQdN+A65+p/7loZszpdSj4LEGS/ndYvYrwcnTlskekrEsbrNt/cDUee291QPINyc1CRTdUQ8 PMAAMDVoIwc5Dd7nF3/sRSzE5AEJcbVp1ZkksIOmuxrp7ErKsWy74TTHYMACWUzAS0YUmsivkijuC sQGIIqsDavm4mpLJf5K/IBanuBw1GiOOBQWYXe3dvnp7eJL6scTWUwRBQMc0u1iutiZk5Zfp3Wt+w QwGtPt07A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZWPG-00GRRv-CE; Thu, 22 Apr 2021 10:17:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWOx-00GRQZ-Q2 for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 10:17:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To; bh=P1yzkGOkcnvwxAl/j9BN4l/zvJWfv1wrbb1pE4xRYuM=; b=Oq7/GF5KO2uk+eVAR8EfLJBVJf OnHKYzN2oz/gOEsfgQ8eS9j8lhgZ33eqADfyPSBEJAH42oPXdCbDE7O1q6AG2yqAKttuf/Glm3C1H d5s+Yv+6CbtzAfh+ulTZi74STh8EZtL26cNqYwEyQd0qKqKV/RnxkMIOHC8V9a6lRFBX5AiwKEx+R BaCjfGrF9ClSB7Mvb7anzlLtnJm0xZ2yg5Nqzf96viNvq2lr3FKxc1bLlJKSGiW+/wpx6RDqfzBMg cLp9MTuUmrk05U5uEY0mKF5SbHmTtnkILxRi2ipbMpb2ErbRYdvrT2VOrx2wmJLoda/USFbe3XSXp bP2Hakew==; Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZWOr-00DZbM-AJ for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 10:17:38 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20210422101725euoutp02f4305ee9a0f344466ff1eb52b22c9f5a~4JrnOV8xt0320703207euoutp02U for ; Thu, 22 Apr 2021 10:17:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20210422101725euoutp02f4305ee9a0f344466ff1eb52b22c9f5a~4JrnOV8xt0320703207euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1619086645; bh=P1yzkGOkcnvwxAl/j9BN4l/zvJWfv1wrbb1pE4xRYuM=; h=From:To:Cc:Subject:Date:References:From; b=RcUhcTXN1DSYB74xXQfJEQ4+3eU85kNobs/vbNmi9iZzthxc9sGKKvkt3Z2raapF7 /GwjJsy3H73qGhmh/3wxg2LEj7S7gQkWQJhFQvN65HmxyVbk6/HL2lfNuLnEhnRyYu Dqi5/lnR+GHzuUsHlwBZtdhRlQcPpOXNigI83GEA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20210422101724eucas1p24cc33a8c94a8771cfe703895822760de~4JrmqwteE2135021350eucas1p2E; Thu, 22 Apr 2021 10:17:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CF.0B.09444.43D41806; Thu, 22 Apr 2021 11:17:24 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20210422101724eucas1p13e2f002b63fe94ef2aa5268383f3a207~4Jrl9yJHG1714217142eucas1p1O; Thu, 22 Apr 2021 10:17:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20210422101724eusmtrp298a6611e5e2ac13712205d842e700acc~4Jrl86WF62586025860eusmtrp2K; Thu, 22 Apr 2021 10:17:24 +0000 (GMT) X-AuditID: cbfec7f4-dd5ff700000024e4-73-60814d34a820 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AE.23.08705.33D41806; Thu, 22 Apr 2021 11:17:24 +0100 (BST) Received: from localhost (unknown [106.120.51.46]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20210422101723eusmtip2d58a0b0baa6994b96081725352605b63~4JrlubzJW2583225832eusmtip27; Thu, 22 Apr 2021 10:17:23 +0000 (GMT) From: =?utf-8?q?=C5=81ukasz_Stelmach?= To: Matt Mackall , Herbert Xu , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= , Marek Szyprowski , =?utf-8?q?=C5=81ukasz_Stelmach?= Subject: [PATCH] hwrng: exynos - Fix runtime PM imbalance on error Date: Thu, 22 Apr 2021 12:17:05 +0200 Message-Id: <20210422101705.15617-1-l.stelmach@samsung.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Organization: Samsung R&D Institute Poland X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsWy7djPc7omvo0JBk//GVtsnLGe1aL7lYzF xrc/mCxuHlrBaLHp8TVWi/v3fjJZXN41h81ixvl9TBZrj9xlt1iwrY/RgctjVkMvm8e2A6oe m5fUe/RtWcXo0fdyA6PH501yAWxRXDYpqTmZZalF+nYJXBmL9u9jLfjGVTH93Cr2BsZpnF2M nBwSAiYS+9rXsncxcnEICaxglPhxdwcbhPOFUeLz40eMEM5nRomuV3OZYFq6Ju1igkgsZ5T4 NW02VMtzRonf558wg1SxCThK9C89wQqSEBGYxCSxct4PsFnMAvsYJXbemwJWJSzgJPH0dBuQ zcHBIqAq0XMnHcTkFbCW2DHVD2KbvET78u1sIDavgKDEyZlPWEBsfgEtiTVN18FsZqCa5q2z mUHGSwg84JC4+OwtO0Szi8Sh5l5GCFtY4tXxLVBxGYn/O+czgeySEKiXmDzJDKK3h1Fi25wf LBA11hJ3zv1iA6lhFtCUWL9LHyLsKNE0fTIjRCufxI23ghAn8ElM2jadGSLMK9HRJgRRrSKx rn8P1EApid5XK6CO8ZC4efgt0wRGxVlIHpuF5JlZCHsXMDKvYhRPLS3OTU8tNspLLdcrTswt Ls1L10vOz93ECExGp/8d/7KDcfmrj3qHGJk4GA8xSnAwK4nwri1uSBDiTUmsrEotyo8vKs1J LT7EKM3BoiTOm7RlTbyQQHpiSWp2ampBahFMlomDU6qBKf5K99Ir+fFrXdYnZdj1K/4IT1jp tj7jpaK1+527NdylH9nEjKzn/FFibN+qXn23kuVt/t4VukrKD65pr3J9G3T6X7H9ifvz93e8 uaw2m2/q5cap0w4dnBbD/9uc0/B/6KrC9bFbdx52+/A88eH57NsHRG9l3r1Ze6yu5FD/6YcB Wj/W5d68de7GnaUVB3bf0WiZuiu4Xb1hqozfsauyJ0NCCi8lexyYXjbvD8/KuBub24wD3+/N 6F0ts+g1Y0j/heRvNTU2vtbHYyp3B8/4omEZYLDf7fujOQ0XmJYudFM+w8Wte/7Vr/ViV0wr 467o3Nh6eJuDd6bN/vQnqkcl38eKvI9p+pGkNNPG8OKsuclKLMUZiYZazEXFiQA7EitGtQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t/xe7omvo0JBjOfM1psnLGe1aL7lYzF xrc/mCxuHlrBaLHp8TVWi/v3fjJZXN41h81ixvl9TBZrj9xlt1iwrY/RgctjVkMvm8e2A6oe m5fUe/RtWcXo0fdyA6PH501yAWxRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZG pkr6djYpqTmZZalF+nYJehmL9u9jLfjGVTH93Cr2BsZpnF2MnBwSAiYSXZN2MXUxcnEICSxl lNjyeC9rFyMHUEJKYuXcdIgaYYk/17rYQGwhgaeMEss7REBsNgFHif6lJ1hBekUEpjFJnF12 CsxhFtjHKLH/6GJ2kCphASeJp6fbmEGGsgioSvTcSQcxeQWsJXZM9YOYLy/Rvnw72HxeAUGJ kzOfsICUMAuoS6yfJwQS5hfQkljTdJ0FxGYGKm/eOpt5AqPALCQdsxA6ZiGpWsDIvIpRJLW0 ODc9t9hQrzgxt7g0L10vOT93EyMwjrYd+7l5B+O8Vx/1DjEycTAeYpTgYFYS4V1b3JAgxJuS WFmVWpQfX1Sak1p8iNEU6P6JzFKiyfnASM4riTc0MzA1NDGzNDC1NDNWEufdOndNvJBAemJJ anZqakFqEUwfEwenVANTfxzfQqmSsqlOD9cdWvDy1RnW3jttHO5O2138s+rE+6WzXHO9ZBf/ dn+womBKvf+ZD4l2j3eFr1EVUyub+cop/eJUw7vnH7O8mnf16IoP657KpVtPYmB7eclZTX15 9Wqmr2frWH62HHx6UHmHyAam/2yhTMEmPG94Vq7rZixjlfqeUWB8ftmll6kRez9v7Wwp/r17 o9TvTZ3WTKcjRWra/WJPNxhri25Xcr5+3M/D9gqj78S1nOd2r8tW0frgIuIXcemH9Mp7Gy+n TI3tazRllVLeMqNc5Xm98B2OJL/swpJ3zwLbU6vaZ893nPDex70kIfyo9s2Ip++/iRqdfcK+ pvyW2LTOuQIpN/ZITM9WYinOSDTUYi4qTgQARlr7viwDAAA= X-CMS-MailID: 20210422101724eucas1p13e2f002b63fe94ef2aa5268383f3a207 X-Msg-Generator: CA X-RootMTR: 20210422101724eucas1p13e2f002b63fe94ef2aa5268383f3a207 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20210422101724eucas1p13e2f002b63fe94ef2aa5268383f3a207 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_031733_647994_702358FA X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Change-Id: I028915fbee9e4a050a1313119872d6043696632d Signed-off-by: Łukasz Stelmach --- drivers/char/hw_random/exynos-trng.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 8e1fe3f8dd2d..9f455d952e87 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -142,13 +142,13 @@ static int exynos_trng_probe(struct platform_device *pdev) if (IS_ERR(trng->clk)) { ret = PTR_ERR(trng->clk); dev_err(&pdev->dev, "Could not get clock.\n"); - goto err_clock; + goto err_pm_get; } ret = clk_prepare_enable(trng->clk); if (ret) { dev_err(&pdev->dev, "Could not enable the clk.\n"); - goto err_clock; + goto err_pm_get; } ret = devm_hwrng_register(&pdev->dev, &trng->rng); @@ -164,10 +164,8 @@ static int exynos_trng_probe(struct platform_device *pdev) err_register: clk_disable_unprepare(trng->clk); -err_clock: - pm_runtime_put_sync(&pdev->dev); - err_pm_get: + pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); return ret;