From patchwork Mon Apr 26 22:05:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxiao Bi X-Patchwork-Id: 12225081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27BFC433B4 for ; Mon, 26 Apr 2021 22:10:46 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54F8961103 for ; Mon, 26 Apr 2021 22:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54F8961103 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QMAiQB081027; Mon, 26 Apr 2021 22:10:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2020-01-29; bh=IRgHqvuCftcB5LI6A7XXYJTxKOKh089s1ot2YYw+GFI=; b=i6KmHFhaH2KnmGpjQkQi4Xq8hCBK0eJTqcWVIcb2+jrDHOC3NXI0/VMrL+BeT88n21JC xtqk+Iq7TnBZoCgORPOMArLrswlE28i5+TvVpoE+qA0hJEEtN9yl47OhhlemEa+dYn1M tq+GT0JAkbr3dJWuvvcuR7cnAZ7Eh4vjuz/aG4oX+eU5p8CI7eaWjcjsTjyQn/mzONmq tQIYMeQuuRSqcmuA2WhKZ2q9A4a3o0snkZFrF7GTw6Y7fbuQu9Rpms9ZpB2NxA10ZOjZ i0zWAIoSq3TkChyMWa3GoGHdSW9Tq+HTAVlanwWzzF6CiAFLtbz44+8lQIeSbdZO2aet 3A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 385afsuk8x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Apr 2021 22:10:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6KTC105585; Mon, 26 Apr 2021 22:10:43 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 384w3s69fd-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Mon, 26 Apr 2021 22:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O8-0003t6-95; Mon, 26 Apr 2021 15:07:32 -0700 Received: from userp3020.oracle.com ([156.151.31.79]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O3-0003s7-Ci for ocfs2-devel@oss.oracle.com; Mon, 26 Apr 2021 15:07:27 -0700 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6Kle105544 for ; Mon, 26 Apr 2021 22:07:27 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2054.outbound.protection.outlook.com [104.47.46.54]) by userp3020.oracle.com with ESMTP id 384w3s65pu-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Apr 2021 22:07:27 +0000 Authentication-Results: oss.oracle.com; dkim=none (message not signed) header.d=none; oss.oracle.com; dmarc=none action=none header.from=oracle.com; Received: from SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) by BY5PR10MB4307.namprd10.prod.outlook.com (2603:10b6:a03:212::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Mon, 26 Apr 2021 22:07:24 +0000 Received: from SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f]) by SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f%5]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 22:07:24 +0000 From: Junxiao Bi To: ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Date: Mon, 26 Apr 2021 15:05:50 -0700 Message-Id: <20210426220552.45413-1-junxiao.bi@oracle.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) X-Originating-IP: [73.231.9.254] X-ClientProxiedBy: SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) To SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from dhcp-10-159-151-113.vpn.oracle.com (73.231.9.254) by SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.16 via Frontend Transport; Mon, 26 Apr 2021 22:07:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0e7a9d6-7dfb-41e4-2b4e-08d908ffabb3 X-MS-TrafficTypeDiagnostic: BY5PR10MB4307: X-MS-Exchange-Transport-Forked: True X-Oracle-Tenancy: 1 X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O5vKjBM3fozZjptfX62di4lX+XzUHcr6ULe/vpr3pEWpFpkRzF7zdnxgaPZNAN3xANuLgSWg+bMCdLXgco/f6aQwnYaSwTifO+K5wDa73RpqYU47V+J0zPw+HI4Zup/upQeA/nxy10IDoDqlAzGGkMKsYYi8eBIhwVikw4Z7JKja8iCOG7LyGf+mjK2icVzbEKEVMXW+ojZdFzH6n4YbVjhfBjlmEbeUHzP7gFKpvNcwcGv4xQEnotsutZQTc6WCE6hB760G2LMhgYOiKtg9BCYzMkwLc5P/SKI8E9zv6HDUQ63UqqB3zHldJeXtdnVSBxcnywS+R2o5yoWm1PJZKZgXtuSkzybjTYMsbhlPJlP+NNZ8QN+23Ckcn6xM0nYi1rMm9JUweEU1YVnLBBNJwUjzhRN1kN16M3JYpThCV428wDH1mgbV/3TXbhuBE/WIK8ACuOo2SC4jPrFwIDZ3DyDD+a6kkNENgZyLL4pLRcZotYAoYWuln8FVFTFFUDpxbJiHB9BjcpcAijjh786RqV1ZUQfLh9f2qwfyvUoXNv8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:-1; SRV:; IPV:NLI; SFV:SKI; H:SJ0PR10MB4752.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:; DIR:INB; X-MS-Exchange-AntiSpam-MessageData: v4gZCJCK9k+BgKtTbrFKxbLID81u/jknEt2iZ4f9w6P+kCrFxeW+eCSvz174dZWh4S17iQ7dqXSybytcy0Vtp/SHyTp9e+OW5zq+RO5mjIn92LvKoAGCqpvDG4YZuxRVgt8o1ZIODKNgie0yTzG/k85fMpPrQzb8sIZYKOXhzCNiosHXecTG7jM/UNMoXq1z/eEjzwoOrnGcYVNOds2q+fiCP+NOMlSXFLwbXSXC76M3EaAujoUjQ1lpgZrA+BdNHIhsxEuVs/7cZasJI1KLadD/VSPrJV+Xg2OIVlmGSTYCHngGEw2pMNZsYP6Z8I4Ouw4CxCjZqK2X1sStBO1t89gh+g1BBXJPWIvhYbF1XghDkrrca9BSNc1y2K6K52ft2STdR7MusfuWJDmqETDyrmA3FtocPpAXLMphQVwClpeR2iT3jg1uMsBmM3xmOy4epTnJzr8kq5VLYTPwIhSMofqZ46xXh7b+Gq45FHtpcchM0VM1debHrZy2Ru0jna7tUYCWg6QE9jcnHDGHrtmJUyR9Dcs79pLeeflgV98vcQadiR5irJ81IUojpWZOPM3K/JklBpb1+LiXvG5rae24QXkLWj4DGFa3PLRornp0IKnUqpP1ok8pCd8Vt+moPpSFs6MI8QOaRDNWxK5/lqOR60tQXWUy5Nb7Hzyr5JIMT7B/tgBjKXpuoOLkkvAO1e5JHMEm0yqxpPXYWyc36hhu2+m3h4kMrM1uz+C5ofMHnuPJA3poDbKgXDKnUgCDmuYh01LAlTrCgBkBaSx4RUI5CGLesbu8Zdu31th4TT95wDnRao2in1Pzm5KLs0w+bjngBitAE0ptMDFGDlX4BYgl4e0LR/meeGqLTRZUmEjHyT2we5w7XBERc1bW4ufBhH6VCbnglGvj5pshsM0atFsTyw2ZqsoIAis50vh9oswL3OtZ3kzWI2uVx6w5GSk+0FLvdvHORvBZk0f8YMYhIsP/VniCjCYASeDNrTLcreQIcC28bVxbiejlm3gnzkQ0C8Fqr7EPH5G3YBCGT8EfZhrCFZKc1Cvyt1BrlpKK7xQhlJVVETOkZoIGBFtK0DALgex2kupn5AeuxT/rpuC13qEgaqrpQeXdD7A4FQ7L/rGLgAGmqMZi4nDbgNaQBtYzKFQHgoFD33dz7OWE9FKzrOYw0UsDX1zyBjiF4t78PSFJVwPPwT4q0DcEuHkWlD4EkAmr33bax7h8xWPluLJL8o/vf+T/lXwJovUH0ToukGh49BS+uQ/40yW+qLJaB1ez652db+2FiviFaRNEJyqFF6kO3f4bes8JUedxYbQqo3mHmM+ZULKDujmjU+Uovfe1JgoH X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0e7a9d6-7dfb-41e4-2b4e-08d908ffabb3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2021 22:07:24.2204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: snLY8rZffYOjsGQC0zOLdHBspCuyTAIkdH+8UH/3c7TK1tzASA8A/o/dJA9lkyvNMV/XhOPJFhn/0kULeqaeWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4307 X-MS-Exchange-CrossPremises-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-Mapi-Admin-Submission: X-MS-Exchange-CrossPremises-MessageSource: StoreDriver X-MS-Exchange-CrossPremises-BCC: X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 73.231.9.254 X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating;SFV:SKI;SKIP:0; X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: BY5PR10MB4307.namprd10.prod.outlook.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 Subject: [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 X-Proofpoint-GUID: VI7mVfbq-gbBPVH2f3Z9bMWhTcqjOlud X-Proofpoint-ORIG-GUID: VI7mVfbq-gbBPVH2f3Z9bMWhTcqjOlud X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1011 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 When doing truncate/fallocate for some filesytem like ocfs2, it will zero some pages that are out of inode size and then later update the inode size, so it needs this api to writeback eof pages. Cc: Signed-off-by: Junxiao Bi Reviewed-by: Joseph Qi --- fs/buffer.c | 14 +++++++++++--- include/linux/buffer_head.h | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 0cb7ffd4977c..802f0bacdbde 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1709,9 +1709,9 @@ static struct buffer_head *create_page_buffers(struct page *page, struct inode * * WB_SYNC_ALL, the writes are posted using REQ_SYNC; this * causes the writes to be flagged as synchronous writes. */ -int __block_write_full_page(struct inode *inode, struct page *page, +int __block_write_full_page_eof(struct inode *inode, struct page *page, get_block_t *get_block, struct writeback_control *wbc, - bh_end_io_t *handler) + bh_end_io_t *handler, bool eof_write) { int err; sector_t block; @@ -1746,7 +1746,7 @@ int __block_write_full_page(struct inode *inode, struct page *page, * handle any aliases from the underlying blockdev's mapping. */ do { - if (block > last_block) { + if (block > last_block && !eof_write) { /* * mapped buffers outside i_size will occur, because * this page can be outside i_size when there is a @@ -1871,6 +1871,14 @@ int __block_write_full_page(struct inode *inode, struct page *page, unlock_page(page); goto done; } +EXPORT_SYMBOL(__block_write_full_page_eof); + +int __block_write_full_page(struct inode *inode, struct page *page, + get_block_t *get_block, struct writeback_control *wbc, + bh_end_io_t *handler) +{ + return __block_write_full_page_eof(inode, page, get_block, wbc, handler, false); +} EXPORT_SYMBOL(__block_write_full_page); /* diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h index 6b47f94378c5..5da15a1ba15c 100644 --- a/include/linux/buffer_head.h +++ b/include/linux/buffer_head.h @@ -221,6 +221,9 @@ int block_write_full_page(struct page *page, get_block_t *get_block, int __block_write_full_page(struct inode *inode, struct page *page, get_block_t *get_block, struct writeback_control *wbc, bh_end_io_t *handler); +int __block_write_full_page_eof(struct inode *inode, struct page *page, + get_block_t *get_block, struct writeback_control *wbc, + bh_end_io_t *handler, bool eof_write); int block_read_full_page(struct page*, get_block_t*); int block_is_partially_uptodate(struct page *page, unsigned long from, unsigned long count); From patchwork Mon Apr 26 22:05:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxiao Bi X-Patchwork-Id: 12225079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEB6C433ED for ; Mon, 26 Apr 2021 22:10:45 +0000 (UTC) Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47CCF611BE for ; Mon, 26 Apr 2021 22:10:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47CCF611BE Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QMAPKs132406; Mon, 26 Apr 2021 22:10:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : in-reply-to : references : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2020-01-29; bh=HNAHs9wlHBeIk3YJ270OyFCwabHVuTO497aLwHTB0Ms=; b=UHYmAHWa8DSoDLjN2VPtdiTMUgeKgH41LJijsyQDJ8GmDwM7C/SmlH2kyjS8yAYqwO6Q 0gGNkLyIjdGIb4MeEnK3SSw29dBfDJF4xI7BqJrei6OQOSSYwMqouF29Axp9gUu2qQpn VUbgxbn9/lLwUSz1H8zXqXM7tDqr28KbgLX5+c6uELHMrBtg3Rb1c8dE/AkQBnXJp81k /sMuxJ6h59kAxdO/Buic3EpNg3zrT4g6LrekfCceQUyn3GuBmac/pW2fN20r5Jk9grj3 2I6vNn6X8I5wwdAZC0jBwdmmkfcb7YRUDFap6ixNxDn7dFdntntUODU0XAQLI3APcOw8 lw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 385afpukxa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Apr 2021 22:10:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6LT5105690; Mon, 26 Apr 2021 22:10:43 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 384w3s69fg-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Mon, 26 Apr 2021 22:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O8-0003tZ-Ek; Mon, 26 Apr 2021 15:07:32 -0700 Received: from userp3020.oracle.com ([156.151.31.79]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O4-0003sS-6E for ocfs2-devel@oss.oracle.com; Mon, 26 Apr 2021 15:07:28 -0700 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6Klf105544 for ; Mon, 26 Apr 2021 22:07:27 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2054.outbound.protection.outlook.com [104.47.46.54]) by userp3020.oracle.com with ESMTP id 384w3s65pu-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Apr 2021 22:07:27 +0000 Authentication-Results: oss.oracle.com; dkim=none (message not signed) header.d=none; oss.oracle.com; dmarc=none action=none header.from=oracle.com; Received: from SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) by BY5PR10MB4307.namprd10.prod.outlook.com (2603:10b6:a03:212::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Mon, 26 Apr 2021 22:07:25 +0000 Received: from SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f]) by SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f%5]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 22:07:25 +0000 From: Junxiao Bi To: ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Date: Mon, 26 Apr 2021 15:05:51 -0700 Message-Id: <20210426220552.45413-2-junxiao.bi@oracle.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210426220552.45413-1-junxiao.bi@oracle.com> References: <20210426220552.45413-1-junxiao.bi@oracle.com> X-Originating-IP: [73.231.9.254] X-ClientProxiedBy: SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) To SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from dhcp-10-159-151-113.vpn.oracle.com (73.231.9.254) by SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.16 via Frontend Transport; Mon, 26 Apr 2021 22:07:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a8e2d37-4503-4b06-f203-08d908ffac6e X-MS-TrafficTypeDiagnostic: BY5PR10MB4307: X-MS-Exchange-Transport-Forked: True X-Oracle-Tenancy: 1 X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VwMN72pqD8+9zVPai+/fFEcyXEuxfDn97mOfBmdNNGDgkMD5ngT+5YaWVSXgTYdP+AeZRcA5mgi4kmpBgj8Ug0xWJBtYKdpAZeBGwIuujCdP49R+Jk1ocv5op9UI10MNrKDyWpcF24yHboIXFTFKs4SrklNyLL/rCxERU92ComzJLLP9952/sYyvwh61EVLz5N6PxT/IquCjBR/r+pZfUjENafE1UoievGQrLn9GjeuR7F+xZNWvnewEpJA1/l9tzjuFP3TsSrfWtWJ+criT+RpwuXDe8mIewM4zYcpVBJymEz6jAU4us5aoermiPqIPvOLc4wzw4nd9TXErTzjlc8kI8s/UPkYMV/vsecWL45NhfmT49qDodG+QCLfGe/ohRzc4Z7KNyZrbRHC/3N0lR1tVHaE4cMMkaXDxDkv9h/TUHqz/ZWbNEYS1WkMrrUtkGF+OT5lkMhMLmcr+BZ9Jzj/RKoKiaIHftlSI9ra4WgHCIeI1sSVyq16v2tYO2p0yEB0SdZRDB443s1XV1UM9le9E146gmIFwGtKS4mIDqO1mU5jacjCLyrZ2fyKl7m+q X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:-1; SRV:; IPV:NLI; SFV:SKI; H:SJ0PR10MB4752.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:; DIR:INB; X-MS-Exchange-AntiSpam-MessageData: 6KXTj43qY+Wv+rpAe2aVddFMY9DQfqLQKc+a439RrSIazpBXuZuae9TyER89RI1dk7MiBFrugdwH4wd1+3p0sygsnoXOg+2XHZ+ScO6HY2lmGNRVaJWOjzPYVQ4E9wQnjkGxAyMxpjADeUIJPxQVClCO8ax8NAr0RM0BSiGUnB1PDzTWC3XwwUxe1402GvYsYI7GjMb+DjtTjbRCP8iGG/FVEFvV5WxbeYuFa/ZNv+3yBVyvPVcUk/5iBPH3zkFSpCErSbXiyiT1+6ELKbFCu3/F6DFUY6JNnynva6/oCCdD4LLg1cBm2vthNPA5nU/rTFxBdIIXyAK8RSl3zSbbawiJpRItCc6p0szISTTQFJZfvR0qIHfGnmz4e8dl4Qy3Pbhg0uEwym5EoPgjsHoTgiLHCga1dFEpj5Pq1ucROyuJl+pDlP0D7OZjtyQ749UzEEgFm3+zjbxYG81hB4nwcPsgsXj9exOO4SbiJmr8k/yhhORPC63Z3s0nCdyr7tbTWYJ8fNzTpTxhncsWoAOCHafVd+gz2dPdA9i/bO1I+tzxcPMhhyNmEHieV47eldTNoXtuN27TS7rgzZt0+EcKuLnEYwVvmiWeHxhLsz9URufXeipzbq5F58j7p26O7m+geA9ygtrJHidmkr+piiMVKtjk6LnyZRCBya/A1Ed91QFblx4tP59CmcOFHUtCV4bzNbuVj506rGX2Sq43qJCXho47q0gXOegSnnbNm7WnW8PExKJaBW92nBpaRJmELk3iIYUA5LyuUo6D0u7JlsyvJIvw3/AXh3FcDuovi2W/qHI4/WxwffT+OOp2zzZotaZ9OeS3Em6l1tXbZ03lAeao+WLpq4ARMKDadwrB2axP1fn+JhuzT6lOkEeo+SHwWD5kJttreD120mswSVL7jj00GPAzNP4nRnf76wJWyN2qG1NTqNzCXnOi+OsTQWQFxEQNuB1oMnBcu0K4eNK/Y7p3dgz9SG6Q+ltRmnJPtuYI6tuov5cboamnQyHTov2ifdJTojmFyqmMxQDnBhtnqmhXbJnw/v9DMl1fhQoWoSEg6LqkpA6dpycnY7tOOzq1LODnGXcU+KRww8rbJXbVkVmoVBUcQI1wyoaEPEkxUFnjtmKlHd4BcUdf3aVc82X7JGFtwGd/j4TATTp09RqgwApOMOdla1hcXm1OZfRAEF8cNP7Mqq9HCgKSQkBMrEYR2Akk0cFNpFgcG2mt4vdciMcb/s7bX+Qwd8Wu2+eJXFBPVpMgYjgar9+oCttze/SyFrpZCyTKYpxH654r2vlMilld+jcGw712Gxg7AXr0v+yhLGiMbyp32CvG5SypDWh+dwmY X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8e2d37-4503-4b06-f203-08d908ffac6e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2021 22:07:25.3863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rv8xsTrN/O+NCzFaHs19l22ZD6yrK3wBAt7Blb2gKtFX1jW2QeHUoTvhSFEp+rVtP9Bomygel5Js5XujDAd3rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4307 X-MS-Exchange-CrossPremises-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-Mapi-Admin-Submission: X-MS-Exchange-CrossPremises-MessageSource: StoreDriver X-MS-Exchange-CrossPremises-BCC: X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 73.231.9.254 X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating;SFV:SKI;SKIP:0; X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: BY5PR10MB4307.namprd10.prod.outlook.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 Subject: [Ocfs2-devel] [PATCH 2/3] ocfs2: allow writing back pages out of inode size X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 X-Proofpoint-ORIG-GUID: G1PeHi4ki3h83opJEbPcd14hgeQFAxDD X-Proofpoint-GUID: G1PeHi4ki3h83opJEbPcd14hgeQFAxDD X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 When fallocate/truncate extend inode size, if the original isize is in the middle of last cluster, then the part from isize to the end of the cluster needs to be zeroed with buffer write, at that time isize is not yet updated to match the new size, if writeback is kicked in, it will invoke ocfs2_writepage()->block_write_full_page() where the pages out of inode size will be dropped. That will cause file corruption. Running the following command with qemu-image 4.2.1 can get a corrupted coverted image file easily. qemu-img convert -p -t none -T none -f qcow2 $qcow_image \ -O qcow2 -o compat=1.1 $qcow_image.conv Cc: Signed-off-by: Junxiao Bi Reviewed-by: Joseph Qi --- fs/ocfs2/aops.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index ad20403b383f..7a3e3d59f6a9 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -402,11 +402,28 @@ static void ocfs2_readahead(struct readahead_control *rac) */ static int ocfs2_writepage(struct page *page, struct writeback_control *wbc) { + struct inode * const inode = page->mapping->host; + loff_t i_size = i_size_read(inode); + const pgoff_t end_index = i_size >> PAGE_SHIFT; + unsigned int offset; + trace_ocfs2_writepage( (unsigned long long)OCFS2_I(page->mapping->host)->ip_blkno, page->index); - return block_write_full_page(page, ocfs2_get_block, wbc); + /* + * The page straddles i_size. It must be zeroed out on each and every + * writepage invocation because it may be mmapped. "A file is mapped + * in multiples of the page size. For a file that is not a multiple of + * the page size, the remaining memory is zeroed when mapped, and + * writes to that region are not written out to the file." + */ + offset = i_size & (PAGE_SIZE-1); + if (page->index == end_index && offset) + zero_user_segment(page, offset, PAGE_SIZE); + + return __block_write_full_page_eof(inode, page, ocfs2_get_block, wbc, + end_buffer_async_write, true); } /* Taken from ext3. We don't necessarily need the full blown From patchwork Mon Apr 26 22:05:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxiao Bi X-Patchwork-Id: 12225089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2C7C433B4 for ; Mon, 26 Apr 2021 22:13:54 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A351C61152 for ; Mon, 26 Apr 2021 22:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A351C61152 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QMAF4g070926; Mon, 26 Apr 2021 22:13:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : in-reply-to : references : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2020-01-29; bh=vQlZxph0Z5mdFWOL3eyOW0biy4DiFyes/EDJuV9r8e4=; b=potuW/Vr3iOgJX2IQydeAkYOc+5VHB9olNZS9SGYk3RZlNlI4Lvdpc9efFNZtY5pNo4g oFf8WQKRn5ByElkfYzpgfBTlA/l1i2CBv7Hr4H5QS/yhBHbHYhfwKHUU3x3qetLl1V6i 6BqYKFRGy2rMSFBZrQ80MOq+u3b7acI+wqOFsSqzODFAYC7V5kyf8hQXEGD1jPiIuXUa 8f6ZEkm1OuBFgOAydF9LXeVfneqB4I3XJ9Auw8EPt0uPWO6mCy7MVv9V2kPgZKpYTjYQ oL3VKGLNdJD8vlZVozvChAT0oiE0cuClOFiubViCQR5OvJU25abs0aspZ80l/Yyusi+T hw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 385afsukdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Apr 2021 22:13:51 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6L20105607; Mon, 26 Apr 2021 22:13:51 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 384w3s6e17-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Mon, 26 Apr 2021 22:13:51 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O8-0003u4-H9; Mon, 26 Apr 2021 15:07:32 -0700 Received: from userp3020.oracle.com ([156.151.31.79]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lb9O5-0003sf-EJ for ocfs2-devel@oss.oracle.com; Mon, 26 Apr 2021 15:07:29 -0700 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13QM6Klh105544 for ; Mon, 26 Apr 2021 22:07:29 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2054.outbound.protection.outlook.com [104.47.46.54]) by userp3020.oracle.com with ESMTP id 384w3s65pu-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Apr 2021 22:07:29 +0000 Authentication-Results: oss.oracle.com; dkim=none (message not signed) header.d=none; oss.oracle.com; dmarc=none action=none header.from=oracle.com; Received: from SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) by BY5PR10MB4307.namprd10.prod.outlook.com (2603:10b6:a03:212::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Mon, 26 Apr 2021 22:07:26 +0000 Received: from SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f]) by SJ0PR10MB4752.namprd10.prod.outlook.com ([fe80::7865:7d35:9cee:363f%5]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 22:07:26 +0000 From: Junxiao Bi To: ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Date: Mon, 26 Apr 2021 15:05:52 -0700 Message-Id: <20210426220552.45413-3-junxiao.bi@oracle.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210426220552.45413-1-junxiao.bi@oracle.com> References: <20210426220552.45413-1-junxiao.bi@oracle.com> X-Originating-IP: [73.231.9.254] X-ClientProxiedBy: SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) To SJ0PR10MB4752.namprd10.prod.outlook.com (2603:10b6:a03:2d7::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from dhcp-10-159-151-113.vpn.oracle.com (73.231.9.254) by SN6PR05CA0026.namprd05.prod.outlook.com (2603:10b6:805:de::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.16 via Frontend Transport; Mon, 26 Apr 2021 22:07:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 437b5311-e205-4d22-619f-08d908ffad33 X-MS-TrafficTypeDiagnostic: BY5PR10MB4307: X-MS-Exchange-Transport-Forked: True X-Oracle-Tenancy: 1 X-MS-Oob-TLC-OOBClassifiers: OLM:983; X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GsYoCKgVvrm0oFXbxxwbAw/T7JhUB/1WzclmIqMJQ5hHsUfuX1Xz0ubAHXt0nW/EQZhQP+J0m1J0ZAc+yGSN4fEqzCDrwL/ZceGXJ7iA+MqSQvPFhAKzti28mt8fRXcqpu8Gi2gOg7ByD+WZEIiy0JYGz19+JUdGkVwDtWGHkbVvGESutRwbNJuuvDcusnsZDa6ifV56CKBWzC5t3FPJ613HVKv8rHSXcbIrqyltmWCgmNpoVHtNHfziJoeHjhYQuUgm73Dx4hOIn3EgH8MEAD4oGUIL+yYQu0lvkkR1hbJP2f21rN/L8BtpYQwzPLhc6Vd8hD00rXFcCuq5Qi25rchsj83KO9IONK2on0r+Kg3aNO7GvQY0HaGjolthlN8poJIphhoLbEaW4rPX8xzyyp1eul3IIVEzJ4uL9qEOu+HibqICkVX4TXJDiuqSLDMngjfba6r63P4gEMcTINxR/9JJkwGoElizBvLa/j6zwyh0izF3rYs87lrY8sR2qrVdvZ6RT3ZiATBl51lTs+sCGYW1b5DYYa0f4qAMxYvrAvg8tjZSqBomcghnD1LyH5rr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:-1; SRV:; IPV:NLI; SFV:SKI; H:SJ0PR10MB4752.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:; DIR:INB; X-MS-Exchange-AntiSpam-MessageData: zJB6o5Z/S34hevfuW0aQA+jVyj4OuDPC+H2CQzRA7I4LiqCVL3pEM3NP0kD5jUPn5HezjKQe5zZysauNJaqJOIih+LnFzWK9JgksPSzUtX76jy8SGDeDLXUoGwvmhkODwzPqH0jJO5GCW93XKfXeqWpW9L7aA9nra0r4TZN/S6Uz8XW8Fym1G2JP/skmUfCFNA866mZxcNxElDYrZTZxcXp70ak1S7fv5/yyUe+T7s7QjHSYPJ4IoIAdYR5C2uMjnypHFGfE0NkV1OKagEL3/J7C3J+YuWol7wUq90pnny9dQkf9MAAasnBytsprTgW4PIh50BOc4cFJxBV593cnKscrNu1GM2MTc8iiD/c50sDXLgCu98Pb1yQmFrvYxdLGiYKj34+tcJNWgJDObfGJ9mE2PeZfFZR9miSVUC1ugn1mjsAEpomaG3+BvcpLfxL5tXxPafKUa7p5bx0hcGGs/+rCuMeZ0sbTC2GTA3wNKD85ECTnuEz/80f+BzZnDX+xJsUVbjzQxOj2Ub3Yri3r4z+vv2GeRrEF+orFhWuC4P0WgpSu4x1fCdr8KFqI5P8y/N1sEceiiuqd2/Z82FLYsYBwdhZccsX7jmIpPXKzQWEAEq5SOf47sN4qdbocpi1omiAcFvjYaQUrCXq7puNyrROLMK8JJ3pMPTuw9CzQ0NIK2uxS8OeaiWfwECHYY/i9/isrd2ABjgARvZvsKO6WHoOjjmM1P7tCbBzW78IDChxUwLo8eB3C4o5AiAnPcWw9qUJuUWkiVRPrBQI6H4efv/1JtCDiAUp0c819Mo7Ze4GeYKXalkji8t/xoJJhOwEcNnIraJ0maREIpktI5mlJPuv3Li2SVs7JYbtE14glC/W3tULFj1HI6RcSn1cyyglzHsUTGiSP05XWKxjGQiug1XlHA1orkBNp8swqsMl7pFVqKDWUA0hSqw3ZbkR4ISMtoSQVa4pFnqoo/NTVJM8DNaMCBLEBt24nmLOZA+qbEXcvP5Am5IcDXd4/XkNNlghNbDZQ11Sy8er5+bR+XSRAfh3LQqzqZ/7Lb/nc0cIYTjGSnJO248YQEZGoG2gbcSCYBtKNlf1Y1b+eP/TAQZj+8KTXhfbfx5BrrsoELikxYLkh+AXkXgYYKAEmSEWIe4lT0RuzHA3zgdB70bUveMH+oCMKnESnBZSt0PhY9EnOuGNmpMUGzf74BalR1sTAB/80CMi3Fy1KCPBYavhli7q4n5EBQg1/akDwqSH5WTXZAlHn/O/Rv9vzpVHomSW82tVcOUYDATZO4KHswgHnzYxFNDHX+tzjTCqjlONAZbMYMg31al3SMjF7JZR6kwaILaWz X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 437b5311-e205-4d22-619f-08d908ffad33 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2021 22:07:26.6806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AV2nH1kgmO15bSd33q5EULvTf6tmN7l6AXVOY4eg7O+YjuEZK1TRAVjsiU9PftSbml5PxPsAB6/8l0aTUbZ6uA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4307 X-MS-Exchange-CrossPremises-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-Mapi-Admin-Submission: X-MS-Exchange-CrossPremises-MessageSource: StoreDriver X-MS-Exchange-CrossPremises-BCC: X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 73.231.9.254 X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating;SFV:SKI;SKIP:0; X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: BY5PR10MB4307.namprd10.prod.outlook.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 Subject: [Ocfs2-devel] [PATCH 3/3] gfs2: fix out of inode size writeback X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 X-Proofpoint-GUID: dNnzirzdprlBGgotnObMZbg8QxBsmKQu X-Proofpoint-ORIG-GUID: dNnzirzdprlBGgotnObMZbg8QxBsmKQu X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9966 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104260167 Dirty flag of buffers out of inode size will be cleared and will not be writeback. Cc: Signed-off-by: Junxiao Bi --- fs/gfs2/aops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index cc4f987687f3..cd8a87555b3a 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -133,8 +133,8 @@ static int gfs2_write_jdata_page(struct page *page, if (page->index == end_index && offset) zero_user_segment(page, offset, PAGE_SIZE); - return __block_write_full_page(inode, page, gfs2_get_block_noalloc, wbc, - end_buffer_async_write); + return __block_write_full_page_eof(inode, page, gfs2_get_block_noalloc, wbc, + end_buffer_async_write, true); } /**