From patchwork Tue Apr 27 04:49:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12225339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27E1C433B4 for ; Tue, 27 Apr 2021 04:52:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 394D5613B4 for ; Tue, 27 Apr 2021 04:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 394D5613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=r3kdlJgE2u8Znd213RFmyHFeQTZRYti6R7sUrjkLgnw=; b=OoSNL53N8Y4crI5/3xksKTFyvM JCKWEeO/HqevPLJ6ehpK39aSZkWsZhxCkh1EwfHquwMqDtndU3Ssewq+AADeshB9V5yxPLEdtarx2 7x/rHYaeMnKXXSx6GiXF4bbFgUP1bkaT+Qmgq/H1e3jKXkXt8pBONXHcHq5L2eo6jvEX4Up0YkqvQ 6MiXn5phmd/gEuz+pyw62ImYoR0rCsB2yMr8SWivQjr0KKYFci1v05Gp9mz6XSjYiD0VgNwhy1GzS XlVRzsE9PDCnWeXRHXfgGWyiOH72IzrUDF3JqHLOgkly53mKp6aqVSuzY150DwtPVCcfKVMF74d3m mnkkSkLA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfe-000gzO-Ml; Tue, 27 Apr 2021 04:50:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfZ-000gyH-Ub for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 04:49:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=/Lr+RYT1FpY5hn8dUoDmn9NJW6LLDQqPEYPNdCKhdP4=; b=v2eeOoaXNp1PDB2o1lm8vco9tX IZtVtzD1XKA2mldPA4B5KLIKAyqeD923MJu5Qt4RtHca+kgS9n9mNIaB6q7GfrUZyuBrbHnuJ/PXG VeuvO7uBc1TOUFtPFTaevgSVCFDwjj81CmiEtvJEsMkhlNkb1O9+5RsmTYlJ6uHSL3EDfD1I4xGdP sFmJ1YYb17d6CviIynbl5j/DL1GCiQP54YxabdFiYQQkJMlmMs4A8n0167ZUkCm3nkBxz8Rz0UlHf Hvcyy4R++CdyV6QY2vk09hTk9AKk/A7z9o72KEpz0v0cf/VGlgU/7Uoxeg9J+pC4i4CP3Z613yJ4L LRg46ljg==; Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfW-00GR4v-Hi for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 04:49:56 +0000 Received: by mail-pl1-x630.google.com with SMTP id p17so4278886plf.12 for ; Mon, 26 Apr 2021 21:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/Lr+RYT1FpY5hn8dUoDmn9NJW6LLDQqPEYPNdCKhdP4=; b=VdUxJXjo2nOjp0w6z/zqYtjSMDvjWwlIfeczk4YPGAu5wgjyzMPAH36sy/Gfp/qs2w Ad6f4TmpXIQh4JDQl+f8Y6W/upPK5b5OLUlFQk09ghjRBi1dZ8/ACLHx1TFbk5Q3N/sa ouKbPjwey9Ve7CEuht4fXbthLYYccjnaBQIdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/Lr+RYT1FpY5hn8dUoDmn9NJW6LLDQqPEYPNdCKhdP4=; b=jIHJDJV2zU3gcRf0QgxdWry9NktzUejRfLpkAY+GCHXX+9rz0QSuXMcTUtBfrBsWp/ KtF1Q67B7EB7xAAHmZw9qt3q6I3B0iPTlrrqIvizlJGmXy/3nbvcqATUTci+3vF6Y4gN 5rVmfy1sJyqk9DaQoHbhvY8sEiYJvUU7u3UjW3xnYvskddoW4kdpSZ+l9mr1FzNPGgvD KD0jZB1HltQXdYCMyFfAX7WpFJnZ0WWNvwIwfPYrlNLs57hiW/Az36Ll6zHbwCt94A8i ENOapXFGxvs1h7ucqNqKWMscdWF2g5EE1SDHO/xM1JpEC+w06g+2W7tJLLDBBjw2a6hV UFiQ== X-Gm-Message-State: AOAM533oKaqH4cGk0Dz8Fmjc6PNGWh+GDpFhLjSs7z0MFTbqMyzXPT50 dP1PjyOZ8xCtTYtviQ28TvtHZg== X-Google-Smtp-Source: ABdhPJzI8SukeUv9tslKGuw8SfWxyaKGplUzCpgkZfwm4UwETueFRxso7WgNAW2bCSIJdPtvJIcTFw== X-Received: by 2002:a17:90a:a00e:: with SMTP id q14mr3000568pjp.70.1619498992938; Mon, 26 Apr 2021 21:49:52 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:3984:c4f5:8612:6b3e]) by smtp.gmail.com with ESMTPSA id c125sm1151517pfa.74.2021.04.26.21.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 21:49:52 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 1/3] gpu: drm: separate panel orientation property creating and value setting Date: Tue, 27 Apr 2021 12:49:46 +0800 Message-Id: <20210427044948.12596-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_214954_629924_C7FEF2DC X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel orientation property and set default value to UNKNOWN, so drivers can call this function to init the property earlier , and let the panel set the real value later. [ 4.480976] ------------[ cut here ]------------ [ 4.485603] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xb4/0xbc [ 4.609772] Call trace: [ 4.612208] __drm_mode_object_add+0xb4/0xbc [ 4.616466] drm_mode_object_add+0x20/0x2c [ 4.620552] drm_property_create+0xdc/0x174 [ 4.624723] drm_property_create_enum+0x34/0x98 [ 4.629241] drm_connector_set_panel_orientation+0x64/0xa0 [ 4.634716] boe_panel_get_modes+0x88/0xd8 [ 4.638802] drm_panel_get_modes+0x2c/0x48 [ 4.642887] panel_bridge_get_modes+0x1c/0x28 [ 4.647233] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.652273] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.658266] drm_mode_getconnector+0x1b4/0x45c [ 4.662699] drm_ioctl_kernel+0xac/0x128 [ 4.666611] drm_ioctl+0x268/0x410 [ 4.670002] drm_compat_ioctl+0xdc/0xf0 [ 4.673829] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.678436] el0_svc_common+0xf4/0x1c0 [ 4.682174] do_el0_svc_compat+0x28/0x3c [ 4.686088] el0_svc_compat+0x10/0x1c [ 4.689738] el0_sync_compat_handler+0xa8/0xcc [ 4.694171] el0_sync_compat+0x178/0x180 [ 4.698082] ---[ end trace b4f2db9d9c88610b ]--- [ 4.702721] ------------[ cut here ]------------ [ 4.707329] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:243 drm_object_attach_property+0x48/0xb8 [ 4.833830] Call trace: [ 4.836266] drm_object_attach_property+0x48/0xb8 [ 4.840958] drm_connector_set_panel_orientation+0x84/0xa0 [ 4.846432] boe_panel_get_modes+0x88/0xd8 [ 4.850516] drm_panel_get_modes+0x2c/0x48 [ 4.854600] panel_bridge_get_modes+0x1c/0x28 [ 4.858946] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.863984] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.869978] drm_mode_getconnector+0x1b4/0x45c [ 4.874410] drm_ioctl_kernel+0xac/0x128 [ 4.878320] drm_ioctl+0x268/0x410 [ 4.881711] drm_compat_ioctl+0xdc/0xf0 [ 4.885536] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.890142] el0_svc_common+0xf4/0x1c0 [ 4.893879] do_el0_svc_compat+0x28/0x3c [ 4.897791] el0_svc_compat+0x10/0x1c [ 4.901441] el0_sync_compat_handler+0xa8/0xcc [ 4.905873] el0_sync_compat+0x178/0x180 [ 4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsinyi@chromium.org/ v1: set panel orientation in dsi driver https://patchwork.kernel.org/project/linux-mediatek/patch/20210409045314.3420733-1-hsinyi@chromium.org/ --- drivers/gpu/drm/drm_connector.c | 58 +++++++++++++++++++++++++-------- include/drm/drm_connector.h | 2 ++ 2 files changed, 47 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..cda83314d7ad 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1210,7 +1210,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { * INPUT_PROP_DIRECT) will still map 1:1 to the actual LCD panel * coordinates, so if userspace rotates the picture to adjust for * the orientation it must also apply the same transformation to the - * touchscreen input coordinates. This property is initialized by calling + * touchscreen input coordinates. This property value is set by calling * drm_connector_set_panel_orientation() or * drm_connector_set_panel_orientation_with_quirk() * @@ -2173,8 +2173,8 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property); * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * - * This function sets the connector's panel_orientation and attaches - * a "panel orientation" property to the connector. + * This function sets the connector's panel_orientation value. If the property + * doesn't exist, it will create one first. * * Calling this function on a connector where the panel_orientation has * already been set is a no-op (e.g. the orientation has been overridden with @@ -2206,18 +2206,16 @@ int drm_connector_set_panel_orientation( prop = dev->mode_config.panel_orientation_property; if (!prop) { - prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, - "panel orientation", - drm_panel_orientation_enum_list, - ARRAY_SIZE(drm_panel_orientation_enum_list)); - if (!prop) - return -ENOMEM; + int ret; - dev->mode_config.panel_orientation_property = prop; + ret = drm_connector_init_panel_orientation_property(connector); + if (ret) + return ret; + prop = dev->mode_config.panel_orientation_property; } - drm_object_attach_property(&connector->base, prop, - info->panel_orientation); + drm_object_property_set_value(&connector->base, prop, + info->panel_orientation); return 0; } EXPORT_SYMBOL(drm_connector_set_panel_orientation); @@ -2225,7 +2223,7 @@ EXPORT_SYMBOL(drm_connector_set_panel_orientation); /** * drm_connector_set_panel_orientation_with_quirk - * set the connector's panel_orientation after checking for quirks - * @connector: connector for which to init the panel-orientation property. + * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * @width: width in pixels of the panel, used for panel quirk detection * @height: height in pixels of the panel, used for panel quirk detection @@ -2252,6 +2250,40 @@ int drm_connector_set_panel_orientation_with_quirk( } EXPORT_SYMBOL(drm_connector_set_panel_orientation_with_quirk); +/** + * drm_connector_init_panel_orientation_property - + * create the connector's panel orientation property + * + * This function attaches a "panel orientation" property to the connector + * and initializes its value to DRM_MODE_PANEL_ORIENTATION_UNKNOWN. + * + * The value of the property can be set by drm_connector_set_panel_orientation() + * or drm_connector_set_panel_orientation_with_quirk() later. + * + * Returns: + * Zero on success, negative errno on failure. + */ +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector) +{ + struct drm_device *dev = connector->dev; + struct drm_property *prop; + + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, + "panel orientation", + drm_panel_orientation_enum_list, + ARRAY_SIZE(drm_panel_orientation_enum_list)); + if (!prop) + return -ENOMEM; + + dev->mode_config.panel_orientation_property = prop; + drm_object_attach_property(&connector->base, prop, + DRM_MODE_PANEL_ORIENTATION_UNKNOWN); + + return 0; +} +EXPORT_SYMBOL(drm_connector_init_panel_orientation_property); + int drm_connector_set_obj_prop(struct drm_mode_object *obj, struct drm_property *property, uint64_t value) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 1922b278ffad..4396c1c4a5db 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1696,6 +1696,8 @@ int drm_connector_set_panel_orientation_with_quirk( struct drm_connector *connector, enum drm_panel_orientation panel_orientation, int width, int height); +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector); int drm_connector_attach_max_bpc_property(struct drm_connector *connector, int min, int max); From patchwork Tue Apr 27 04:49:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12225341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0127C43460 for ; Tue, 27 Apr 2021 04:52:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E0B613AA for ; Tue, 27 Apr 2021 04:52:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E0B613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Coz48POwQn6ykxKxzQqixbws+dKBlfXEdFoh++MiuYg=; b=imKmND+FgyNGUoyr/wIEAypGa 9AffW5o2AHfqxQYsZiLpL0vYPi4XIRYBnTHbwnngK3jHAjMf8lE7Q5u9yymn4j2w8Q/6NemgYfdtk O75mlyjxHzP1mGawSaSANbN1bTpa95QkPSwKGd19DuMTMd1wdugWIaqFGl3oXem4fF+3opkgi393n BLbReDjCV+vS+ajs28w1Etpo+EnvmfhQCbJpNCt9koX/KoDS9X3aLt4Mi8CKKskeHfbXTXMOki8aZ FXa8EP8MnB4JaSaNrHBRwn7MYHnVj+NAs/yqesw7n3xU9INkkjdPD3DIpsoBvCjr1QA38Bbwm/dRU 8UhEoxX6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfx-000h24-9y; Tue, 27 Apr 2021 04:50:22 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfc-000gyk-Cs for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 04:50:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=xF3OHVoJNfqjglnjvTxLJPf73tywjjNrGA26Syn00bg=; b=rj3PxGB04q0ATS0oedpcmsSFGF LqXoUKVYzWkgEqNzwkCPb5zfKkEanEvWgPjKYKZg5OBrNRlGF5FYCicFbxKymcIw8G1db5ZExVTf6 WRyWM51r3/BN0N6AD+1/GxFpyz0Lfl/RnImgIHbyC3ts2tzITjRPYDhBq3mJj90OBMfAVD7wkPEDS 0S9ft/muKcKjcxLKMn9xVHWWnfcKoqCptaynNTdACy26rY5rxG8/cpzR+jUdSfRaK/sZLbzo0Rqet +ddZp5uHz3lB02OpdxoK6uGczLU21ZUeM2MfVJoLwyI7Bes9Edo5f624p1ZjLvKLMyFDHB1XHeaxj iCBtg5Kw==; Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfa-00GR5Q-05 for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 04:49:59 +0000 Received: by mail-pf1-x42c.google.com with SMTP id y62so7891204pfg.4 for ; Mon, 26 Apr 2021 21:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xF3OHVoJNfqjglnjvTxLJPf73tywjjNrGA26Syn00bg=; b=aQkvabnsOYdSCbCI2Ahu8FMyIfugOfrAzX9FIMQJY9p2Czzu7GnXrtexTRQGyfcOXA zDUfD3J608v/yBPJ2tYvQStQjwqcURK8qXNGNtV4GnpwVVbXvHFDGHX/0e46PhgnQLJf wBihdkVOueiHhJkVMUT6VOim5Rl9dRrc7EZgY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xF3OHVoJNfqjglnjvTxLJPf73tywjjNrGA26Syn00bg=; b=RmBws4DvZPsgfjIUSkZ8HSMu9EmNrAcHF5hsG0VQz02gxoQJtk0IKer3PcnvHHtRVc AlYCMsIpyqGK8rUgDyWpNTlrc9d9nxhcYoJtXzr+bi3Sk+uqFadG0kJAUHDjJcOiwmVD hL3DbQBprrehWbJdBjX/D7rT7s9VGo45ZIHGLYB7z9alq62i3njKj7seSRQT+cMUQff1 0RJIT4kLXUq7CQ5EZvqdbH+ylJkmPfi2RCksUye0lm51x1aVdlH7dM2ckJ0UJbWRbilC ZFHHtQCwc63LsPjIh6elpihzfXrp4fgBb9izvEZLmv1JXtaOlrWGmCHmQh1H6QXxJOso UtDA== X-Gm-Message-State: AOAM532pc3o82/hBwgMjyR05YTNPGW0spPfZlZ9Yg+q36d/yTSHGLKlx gYOSn2XbzAQURyKgL1oR61/ZVg== X-Google-Smtp-Source: ABdhPJwPPm4u4tg6YSG/bq6wlqozKqdTA0jRIW6pE9ln5m9hymH+OexWOCKpW5EL+vxYFzyZxE6Yrw== X-Received: by 2002:a62:bd13:0:b029:25c:5ec4:c2f3 with SMTP id a19-20020a62bd130000b029025c5ec4c2f3mr20817479pff.35.1619498995453; Mon, 26 Apr 2021 21:49:55 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:3984:c4f5:8612:6b3e]) by smtp.gmail.com with ESMTPSA id c125sm1151517pfa.74.2021.04.26.21.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 21:49:55 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 2/3] drm/mediatek: init panel orientation property Date: Tue, 27 Apr 2021 12:49:47 +0800 Message-Id: <20210427044948.12596-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210427044948.12596-1-hsinyi@chromium.org> References: <20210427044948.12596-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_214958_045934_84488565 X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..0bd27872f2a4 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -964,6 +964,7 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } + drm_connector_init_panel_orientation_property(dsi->connector); drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0; From patchwork Tue Apr 27 04:49:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12225357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2CAC433ED for ; Tue, 27 Apr 2021 04:52:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 576CC613B4 for ; Tue, 27 Apr 2021 04:52:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 576CC613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lfgrEUsbN32h4O/2Hwqbu1Wg1Lufki+DGuOnxLv8cJE=; b=XWaGDGeOcpqKqgwaF7LfsIltL gt8AG2lr/SwIc/CBHZvSAWPVxA6zbbFSP3l2A8mrTZ1bSywJDvBEJNT08ASmlgjolYWpfqfKcqJAs vC0lba55ssuwd3vsHiySCwPsPScBChZSizS4eamOMCXyARUWJuau7uyJSY3lQjgMK73PQqAtHbnDW CtN6CHzX3Ry548rFafEAHu8pw1A+gzhKmT/a1c78N7YKWluvupL0Wx1wfpVFo9vmconTMS3AjSenO K1BG4FyDDAuhSd4RSJdl5OTuTl8g+qhl246EBRR0ZQ+i900u04YdtzHcjiDxF76WxZNB+GP3040lQ JGjy+D1bA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbFgF-000h5e-RD; Tue, 27 Apr 2021 04:50:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfd-000gzK-K3 for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 04:50:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=ZHnMkUtTSOS55dsDXRwNsQpwbt h96yyJogAn6J9yTaUw/jU7Zbj+BC6g+EgoLf0NNUZ+l7uDE3Y0Ds7M5burfT3dWAp9K261TWE8z+z +GT8gCw/JIjGh0/WgGo3Nso5LszIvpIsYywB5wXyqdt3gOos/7A+txXq/ChkR89/JfYwPl3PO985V B9WeSYdnqjS0IXesRqdoaw9fBlA51TNLcxM+Wo/vQoI2JYTW0u/adfIabLvyAd1Ui7zYSq6P5HpwS DiO8friFrvXgum+etx/SU/L07ekCyMNbN8ot0ZaauzJXYJPU3lpur1Od7jxRtqyxe/DmB45ZBnlt9 Ao4vkSvg==; Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbFfa-00GR6G-Tk for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 04:50:00 +0000 Received: by mail-pl1-x62f.google.com with SMTP id h20so30185978plr.4 for ; Mon, 26 Apr 2021 21:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=c+K89QY/gVhAeVZ0+WRtE2V6947IE8xTms8pbQvd+uhFOHJ2x/QLZl0aO54BBy9N6x PKAshJvy/RwX8BXEYR/ej2DI9gs6jXQHgNoUnvesfJ/1BNnYbIKLNyWO1Sy/lViJxzBo TkXU0r6xkpSpA841HlW63vUTSlXIbr7Kf5iLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=OBox5kU4t7QsWmEut4qp8HGdzeDdy0Knl7pJXeKHvk3kFqf+Crncvo9BLI8fMANCLh mkGszKIQl1mX28eA0zQGdEkK4tgWD5pFe50C2UQGdjEZs6keMlEHakds1p7nQopgC1FE AC+fVEHxOQC/E8miVjed2YPPWtv6mnlXm42gNy/JckUFvdUGQwGCHHfdkFcqWuLwN89b bg/z/AYP/NUUN2QoFEbYaJ6vrdZzEf3wKdoYYUWG53E3kLS0dhJ1xtpcb++VTieurOPS 5zl/CXpiEfiVg4x0Ke1ZaxpMEv5rAhR0QZdi1WMXKOnGM8iD4CJulRbty2KtmO2tN+pX nhQg== X-Gm-Message-State: AOAM531SJ8hedznKZNbBniQt53wSHMo/CpqnAuni5ByUWSoN7p0pz8H6 hivnu7RLhIlBicuL+twRMb9b7A== X-Google-Smtp-Source: ABdhPJy1BUt6+R21LCxa4D+U5Ie0p/vfRjiqUmnUX6m/JmeuU/QU2wgLbY7MTc98UD0cppxqB/jq0A== X-Received: by 2002:a17:90a:b78f:: with SMTP id m15mr15823564pjr.131.1619498998028; Mon, 26 Apr 2021 21:49:58 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:3984:c4f5:8612:6b3e]) by smtp.gmail.com with ESMTPSA id c125sm1151517pfa.74.2021.04.26.21.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 21:49:57 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 3/3] arm64: dts: mt8183: Add panel rotation Date: Tue, 27 Apr 2021 12:49:48 +0800 Message-Id: <20210427044948.12596-3-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210427044948.12596-1-hsinyi@chromium.org> References: <20210427044948.12596-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_214958_980676_7A36D2F9 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index ff56bcfa3370..793cc9501337 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -263,6 +263,7 @@ panel: panel@0 { avee-supply = <&ppvarp_lcd>; pp1800-supply = <&pp1800_lcd>; backlight = <&backlight_lcd0>; + rotation = <270>; port { panel_in: endpoint { remote-endpoint = <&dsi_out>;