From patchwork Mon Nov 26 04:52:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 10697583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F381C13BF for ; Mon, 26 Nov 2018 04:52:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CACCC29867 for ; Mon, 26 Nov 2018 04:52:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A6D3C2986D; Mon, 26 Nov 2018 04:52:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SUBJ_OBFU_PUNCT_MANY autolearn=no version=3.3.1 Received: from pdx1-mailman02.dreamhost.com (pdx1-mailman02.dreamhost.com [64.90.62.194]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B54029867 for ; Mon, 26 Nov 2018 04:52:41 +0000 (UTC) Received: from pdx1-mailman02.dreamhost.com (localhost [IPv6:::1]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id AACDD21F376; Sun, 25 Nov 2018 20:52:40 -0800 (PST) X-Original-To: lustre-devel@lists.lustre.org Delivered-To: lustre-devel-lustre.org@pdx1-mailman02.dreamhost.com Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 8786021F368 for ; Sun, 25 Nov 2018 20:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7M0VNU1Z1zMrUFVBm77hbRjEHN9nRqSquOSdfmI1wEY=; b=sh256Et6rrHQd3xceW1mkSmfiw otBGJdTWa/C83SmoZYSwHdvCCq/hTfUo+fe+koBu5gtOTyG8nssX9cT2/xhcW0Q07LdLY+0fq2jIQ nv12PXNqO6TEQ+bx+hnekq613XpVUmZ1BIOCiubw3ErRwGJf60nkYxyZkBRTNrrINGLR5DRo6d44g 5QsfvSY+zCvaxrOtZhgwFsxwgsFmY12TCHWbKEXJ1+ieU9/yvucCN7OavZIO1T2ISMUnC8wtWJHuM nPu57cnjKW2SK9WM90FE1R0LAQrufhPNTzSqTVsMto15zIxl4SPhf7B4DeononEiLYgCMjycuwN9B rOnDDrNg==; Received: from jsimmons (helo=localhost) by casper.infradead.org with local-esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gR8ss-0005Vo-BZ; Mon, 26 Nov 2018 04:52:35 +0000 Date: Mon, 26 Nov 2018 04:52:34 +0000 (GMT) From: James Simmons To: Lustre Developement Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181126_045234_421940_B40607AA X-CRM114-Status: UNSURE ( 6.92 ) X-CRM114-Notice: Please train this message. Subject: [lustre-devel] Do we need LOOKUP_CONTINUE in ll_revalidate_dentry() X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" X-Virus-Scanned: ClamAV using ClamSMTP Doing a compare to the OpenSFS branch I noticed this difference: Is that needed for newer kernels? diff --git a/drivers/staging/lustre/lustre/llite/dcache.c b/drivers/staging/lustre/lustre/llite/dcache.c index 11b82c63..6ee0ec9 100644 --- a/drivers/staging/lustre/lustre/llite/dcache.c +++ b/drivers/staging/lustre/lustre/llite/dcache.c @@ -254,7 +254,7 @@ static int ll_revalidate_dentry(struct dentry *dentry, * to this dentry, then its lock has not been revoked and the * path component is valid. */ - if (lookup_flags & LOOKUP_PARENT) + if (lookup_flags & (LOOKUP_CONTINUE | LOOKUP_PARENT)) return 1; /* Symlink - always valid as long as the dentry was found */