From patchwork Wed Apr 28 04:55:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12228015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F759C433ED for ; Wed, 28 Apr 2021 04:58:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 997D861165 for ; Wed, 28 Apr 2021 04:58:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 997D861165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=PDzqEGToyaud/nYwPj2hTWwMq65b12MhIznkyaaNWU8=; b=i66CNQxmsuRuVE3SmxN8bEUCAt 8K4otWVp2PUZO8XfMKg96CqHtZ0E6X1sF8VL9DVWCuun4f+zT6qMnFKHcSjtuYteoc8YCHwGnYLxy 2ZNmEHV3k2kipt6cOl6ZdobwgVq1qEEY9NJADoUb0UQRhK8tBK5rLslsn67QtzdCSQby2DQvQ4WWv FTujTX3wa4VGOoTf63KM+Ci432w55CtJczNUPYYgE6i61RYF4/xu8joTt+FFp7IqObb1e9P4yAc5b aPZbIPhuMhQLKHLURnWxFCF+eufHy8IhrBrHNTq2qA1XS8p9KdpOkKC3s9bgJMFzuxKgzQOm9o6CN 9sJ2+exg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEo-002nDN-Sn; Wed, 28 Apr 2021 04:55:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEg-002nCR-RG for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 04:55:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=3Ko03dSA+L2ZYJTy14tghnDjMB7R5pl3DSAEhsmhWkY=; b=GOTuf8DbKTiosF622lckjnYqQ0 djwzMoVPMdmMR/0UQLqjyLAKebzIMjPLgqkm157RxqN2dww0RS74uvpwkDsTnwmQn+FQTZN/P7MIf lZP4oH4P01h3GaKpObsDQ2Dyq/j2+epjYaQDdcpIw0nFzvrMjPhdX8dB9wQAodSvxKCT9AyVAh4l4 plWq1zByH0DG+LmRicg2IGFnIw7BnAeuy9DYiM4jHo3AAUFsk6083n4nMnrwirbLYKv5Ola6+10Ti k4TTuBbgBNQZebPruoD4rUU+Um0cngFyHeB+rSLFMYyngels4rdmTtVG9YadarylK8358fTyDqJje WlHCfoWA==; Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEd-00HB8Q-7j for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 04:55:41 +0000 Received: by mail-pl1-x629.google.com with SMTP id o16so18518725plg.5 for ; Tue, 27 Apr 2021 21:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3Ko03dSA+L2ZYJTy14tghnDjMB7R5pl3DSAEhsmhWkY=; b=mwgsHeQklAlZimUGKCkOjIrlNjn2iiELa+8437BG4ZoNCKVz+E61nnpldl6GomdbUV zgJyqRUL/cIW8DqN1Z0JrgcCaw2B7Dc5mgHsRibnks045oG8Q4CQaf8G4vL98zzv1j0J JNYS22xQz+aF68B4+NjHvtRUa1dPPqrsUjlmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3Ko03dSA+L2ZYJTy14tghnDjMB7R5pl3DSAEhsmhWkY=; b=c7erS7sTFN3nEobefk29YF5adLv2nJSUsgfiERLVouaijdT8K7fuaNPUdA772eATqt T7C9oPEbMIlXep0PB3ES8BA8/jQVbzNYAsFrNLYD4yxs9AlUjocu1F4aZf+iRKFtTyn2 6tQ/NQqjtzC9Z1D0Qr2/AvzzHQJnN0/UoOT3dg/6EZPxTBs/pZZ3ttv+pOIM7ybGYXBZ CBfSKvqfkZjQBTRvVSqwu4PcBfzWIqGU7CCpscn51jApXKs9Yqa+COz+8IeHns1MdN74 NOjSOIKBBQmyF77UigYDg8j+FbhbDobYKCGwMk93YFIAYo7kyPya8Qw5k/26tlgMII3I vwnA== X-Gm-Message-State: AOAM531KwLhEIRmpRqtLIbUOqFV91vaShiZLx1CmIiRLP3EPWOLQmByp nImGL6b5xka7iH0ctHfQHLzSOg== X-Google-Smtp-Source: ABdhPJyzBM03jAqIDxHWn9axn0xnm4HgXlLhHTGDzlJcsdtSKEp5v3x5LeZkV3GXspsMmxIOEEzZ8g== X-Received: by 2002:a17:90b:e0d:: with SMTP id ge13mr30471403pjb.189.1619585738086; Tue, 27 Apr 2021 21:55:38 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:8076:36e5:2db0:967]) by smtp.gmail.com with ESMTPSA id x13sm1193170pgf.13.2021.04.27.21.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 21:55:37 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 1/3] gpu: drm: separate panel orientation property creating and value setting Date: Wed, 28 Apr 2021 12:55:31 +0800 Message-Id: <20210428045533.564724-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_215539_355619_33CAC91D X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel orientation property and set default value to UNKNOWN, so drivers can call this function to init the property earlier , and let the panel set the real value later. [ 4.480976] ------------[ cut here ]------------ [ 4.485603] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xb4/0xbc [ 4.609772] Call trace: [ 4.612208] __drm_mode_object_add+0xb4/0xbc [ 4.616466] drm_mode_object_add+0x20/0x2c [ 4.620552] drm_property_create+0xdc/0x174 [ 4.624723] drm_property_create_enum+0x34/0x98 [ 4.629241] drm_connector_set_panel_orientation+0x64/0xa0 [ 4.634716] boe_panel_get_modes+0x88/0xd8 [ 4.638802] drm_panel_get_modes+0x2c/0x48 [ 4.642887] panel_bridge_get_modes+0x1c/0x28 [ 4.647233] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.652273] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.658266] drm_mode_getconnector+0x1b4/0x45c [ 4.662699] drm_ioctl_kernel+0xac/0x128 [ 4.666611] drm_ioctl+0x268/0x410 [ 4.670002] drm_compat_ioctl+0xdc/0xf0 [ 4.673829] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.678436] el0_svc_common+0xf4/0x1c0 [ 4.682174] do_el0_svc_compat+0x28/0x3c [ 4.686088] el0_svc_compat+0x10/0x1c [ 4.689738] el0_sync_compat_handler+0xa8/0xcc [ 4.694171] el0_sync_compat+0x178/0x180 [ 4.698082] ---[ end trace b4f2db9d9c88610b ]--- [ 4.702721] ------------[ cut here ]------------ [ 4.707329] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:243 drm_object_attach_property+0x48/0xb8 [ 4.833830] Call trace: [ 4.836266] drm_object_attach_property+0x48/0xb8 [ 4.840958] drm_connector_set_panel_orientation+0x84/0xa0 [ 4.846432] boe_panel_get_modes+0x88/0xd8 [ 4.850516] drm_panel_get_modes+0x2c/0x48 [ 4.854600] panel_bridge_get_modes+0x1c/0x28 [ 4.858946] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.863984] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.869978] drm_mode_getconnector+0x1b4/0x45c [ 4.874410] drm_ioctl_kernel+0xac/0x128 [ 4.878320] drm_ioctl+0x268/0x410 [ 4.881711] drm_compat_ioctl+0xdc/0xf0 [ 4.885536] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.890142] el0_svc_common+0xf4/0x1c0 [ 4.893879] do_el0_svc_compat+0x28/0x3c [ 4.897791] el0_svc_compat+0x10/0x1c [ 4.901441] el0_sync_compat_handler+0xa8/0xcc [ 4.905873] el0_sync_compat+0x178/0x180 [ 4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsinyi@chromium.org/ v1: set panel orientation in dsi driver https://patchwork.kernel.org/project/linux-mediatek/patch/20210409045314.3420733-1-hsinyi@chromium.org/ --- drivers/gpu/drm/drm_connector.c | 58 +++++++++++++++++++++++++-------- include/drm/drm_connector.h | 2 ++ 2 files changed, 47 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..cda83314d7ad 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1210,7 +1210,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { * INPUT_PROP_DIRECT) will still map 1:1 to the actual LCD panel * coordinates, so if userspace rotates the picture to adjust for * the orientation it must also apply the same transformation to the - * touchscreen input coordinates. This property is initialized by calling + * touchscreen input coordinates. This property value is set by calling * drm_connector_set_panel_orientation() or * drm_connector_set_panel_orientation_with_quirk() * @@ -2173,8 +2173,8 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property); * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * - * This function sets the connector's panel_orientation and attaches - * a "panel orientation" property to the connector. + * This function sets the connector's panel_orientation value. If the property + * doesn't exist, it will create one first. * * Calling this function on a connector where the panel_orientation has * already been set is a no-op (e.g. the orientation has been overridden with @@ -2206,18 +2206,16 @@ int drm_connector_set_panel_orientation( prop = dev->mode_config.panel_orientation_property; if (!prop) { - prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, - "panel orientation", - drm_panel_orientation_enum_list, - ARRAY_SIZE(drm_panel_orientation_enum_list)); - if (!prop) - return -ENOMEM; + int ret; - dev->mode_config.panel_orientation_property = prop; + ret = drm_connector_init_panel_orientation_property(connector); + if (ret) + return ret; + prop = dev->mode_config.panel_orientation_property; } - drm_object_attach_property(&connector->base, prop, - info->panel_orientation); + drm_object_property_set_value(&connector->base, prop, + info->panel_orientation); return 0; } EXPORT_SYMBOL(drm_connector_set_panel_orientation); @@ -2225,7 +2223,7 @@ EXPORT_SYMBOL(drm_connector_set_panel_orientation); /** * drm_connector_set_panel_orientation_with_quirk - * set the connector's panel_orientation after checking for quirks - * @connector: connector for which to init the panel-orientation property. + * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * @width: width in pixels of the panel, used for panel quirk detection * @height: height in pixels of the panel, used for panel quirk detection @@ -2252,6 +2250,40 @@ int drm_connector_set_panel_orientation_with_quirk( } EXPORT_SYMBOL(drm_connector_set_panel_orientation_with_quirk); +/** + * drm_connector_init_panel_orientation_property - + * create the connector's panel orientation property + * + * This function attaches a "panel orientation" property to the connector + * and initializes its value to DRM_MODE_PANEL_ORIENTATION_UNKNOWN. + * + * The value of the property can be set by drm_connector_set_panel_orientation() + * or drm_connector_set_panel_orientation_with_quirk() later. + * + * Returns: + * Zero on success, negative errno on failure. + */ +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector) +{ + struct drm_device *dev = connector->dev; + struct drm_property *prop; + + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, + "panel orientation", + drm_panel_orientation_enum_list, + ARRAY_SIZE(drm_panel_orientation_enum_list)); + if (!prop) + return -ENOMEM; + + dev->mode_config.panel_orientation_property = prop; + drm_object_attach_property(&connector->base, prop, + DRM_MODE_PANEL_ORIENTATION_UNKNOWN); + + return 0; +} +EXPORT_SYMBOL(drm_connector_init_panel_orientation_property); + int drm_connector_set_obj_prop(struct drm_mode_object *obj, struct drm_property *property, uint64_t value) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 1922b278ffad..4396c1c4a5db 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1696,6 +1696,8 @@ int drm_connector_set_panel_orientation_with_quirk( struct drm_connector *connector, enum drm_panel_orientation panel_orientation, int width, int height); +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector); int drm_connector_attach_max_bpc_property(struct drm_connector *connector, int min, int max); From patchwork Wed Apr 28 04:55:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12228017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7F1C433B4 for ; Wed, 28 Apr 2021 04:58:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4484561400 for ; Wed, 28 Apr 2021 04:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4484561400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GhJaxG3zvx6iHiJMzgiyEkCl0iyagMgGoGXt5a/fNJA=; b=kAlU9/YHwGe1cC8bQFSmwr/+/ qPEW1MR+x1xV6jSWMnM88DSvDEbZjwdjFs1vJ/zVO/mO9VK7HT5JCl6JpoYRWIH8rX4Tnd1BI8nuv E48k7g3/iqf2Ul+hjPjd10rwp7jBao/BtxHeUv0DMFT7ftgzMcwML/nuZ8g2KJgrU75ENCREHd4j1 ea9zDWDBeKTCJy2jMVCFn7ciKmKo/8l7Kb3swg5+RkXHcbxcnL2tXqfj5PFrgKXyTXvK5H4b+NOE3 BZBCYbJjVOujS5sIrw2cZgkgH4X4vA4FNWnPRMtRrI9N1+YLlCUOVe+nctbAsZDYbFKG0q/CFF3+h 09cp0ZYrQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbcFC-002nHK-0i; Wed, 28 Apr 2021 04:56:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEi-002nCY-2I for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 04:55:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=PZKgtO/ZJNMulddFlmB7VIsgGF 5zoMQT86jEVJZVHFy5vS0sjO52gAAbDn42JOfHiJOv2446y8AEtx2H727abS0wq3Ms9qLKzMQedk+ rNCfeH6fIqVxJFMQOMNnIz4gVIlof4ZEw+2RViLMtzTuMpE5CwthkzGWjSkW+0r3d4tTktfLoPrQU 4NJLMS+bX6Cuq8HjNmn0H9V/B550llbu9g0xGvyqbV/KFwl6PRPTPQSdEKOth6vZzSedOujS3KhHD d3gBCwjRlUPWeTRdzNT9pV46HsuxI3Yffsgbrlk+ibnMTqOk/vUSNPYjsgoSa9oZDw4BdYlYV5S3f kEjWWiDA==; Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEf-00HB8v-Dl for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 04:55:42 +0000 Received: by mail-pf1-x42a.google.com with SMTP id j6so3508631pfh.5 for ; Tue, 27 Apr 2021 21:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=VTFFF9OFqyw2YMLqAax+N1JMxY/fNr/W5AB4MeQ5uAC48RGc0An02b+Se479ddBizx XD/X1KjCcrsMtSQlNf2LW5waQiFV1rfGU+052WMVU0QQcBCnRqMhDXmhEWMSBSbhd1iI 2p/YqB6CSg/fIreO6cajKo9N3kjiKV7dDgsHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=EGD3m8BGmAnFXUMXZEqbn8MiSVA0nFxrDNx4QRKJnYyuYUa79dXAIfQHCfPRczqrlx EIDsGE4dW+xSY3ntMuJeKFKYoRSShY2bkuTIhFFqPRWlWgKCkneSMfH7IkzIE8cDfqAi k2eRbomChlHND3OuDce/CWtOkOagWVnIX2E14IOXAiyDN8sT5s43bFyuAOCnaJ/tP/aC twLppC92RltRo317JSVIuvdTpvmJQYhJHApcg1ebJfTC3L9mQCtrfzgbFPTIZPViYY3g zliggakVbsMPAhOp/onV84YmB++zAZvu3+TpSUKxTUr13eu41ulReRRD6PhgINpDWmZd 5AbQ== X-Gm-Message-State: AOAM530eN2TtyFeiydJoSZoSPZAHIrZO3ktz8ZYtsYTuqoinrz6QvOTd h5sDQZpf+l2OTjQtvT+0Sxsf6Ie+aDC3Tg== X-Google-Smtp-Source: ABdhPJzGs2DXC6vNxlFEZ8RvRfGO4uOiE+lprziJ7+wryJ2YehvrOUkYJqxr2cPuDE5cVXFo3KiZsw== X-Received: by 2002:a63:942:: with SMTP id 63mr25683673pgj.67.1619585740596; Tue, 27 Apr 2021 21:55:40 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:8076:36e5:2db0:967]) by smtp.gmail.com with ESMTPSA id x13sm1193170pgf.13.2021.04.27.21.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 21:55:40 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 2/3] drm/mediatek: init panel orientation property Date: Wed, 28 Apr 2021 12:55:32 +0800 Message-Id: <20210428045533.564724-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428045533.564724-1-hsinyi@chromium.org> References: <20210428045533.564724-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_215541_472872_21043AB4 X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..9da1fd649131 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } + + ret = drm_connector_init_panel_orientation_property(dsi->connector); + if (ret) { + DRM_ERROR("Unable to init panel orientation\n"); + goto err_cleanup_encoder; + } + drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0; From patchwork Wed Apr 28 04:55:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12228019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7701C43461 for ; Wed, 28 Apr 2021 04:58:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D524613C8 for ; Wed, 28 Apr 2021 04:58:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D524613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lfgrEUsbN32h4O/2Hwqbu1Wg1Lufki+DGuOnxLv8cJE=; b=MuNW5Wb1geYNhdlaGC6PJR3Xv hQDz3OGZDCA6nYTBVlBWNJ45i7whyTUFVm90U4vRD/OkrN23+XSKZPBORuTJPG0nc0HOBiuXiI9/0 OYGsrPc26ed4Xpd2/YDWy6lYdatw6d+yQeZMz0OtmwKMu9x1zJOXauwwsqy3qe9WFPmhgpLDXnKEW n19T/NG9cR0mbmMKP7EkqcwCuv9zICyItETdg8rwhqkNHKzFSHJsLHHP6/GXfezkuQRgIpjDnVaXs bPgegExK2IMdpRbBo7KwTi+zodYsVqYN3FUHQRWo7r5CdTdkAKePEHxCXrCM4JTGdBTL9ZMo1yQIM 0q5/GupFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbcFM-002nL2-0N; Wed, 28 Apr 2021 04:56:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEk-002nCr-A1 for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 04:55:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=zVwM2bHsKX4FN6r5NOLg1+5ron xKpO/ILL3UJwAHIarjunfs5j9LQOXhocNnTSWQkGQXS178qoyPYjSIkcZ3Jyb6lUWGYEdH2TpQbMm LkZo9w07kycx3qTLDmq9NCNlghGkVr8upFT/d7405rA2sSoVIhtJePh+Zg2B6MmklZbMJ9uaPofD0 uWEhSv2OoeQhRTOVArwq8eoXtFM8euVgasPe+N4cJJN1rt4otE+cLh9rxu5M8I9d3QTzP7Lf4/DvP gwQ4jyzw11FSvGmjVMc7DHzz+Hh6TYFklsNFEkoxs7V4ilwbj6JajcLY++3rz9Cru0E7lw0I4zWA9 KxGdrUrQ==; Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcEh-00HB9h-TG for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 04:55:45 +0000 Received: by mail-pf1-x42c.google.com with SMTP id e15so6117535pfv.10 for ; Tue, 27 Apr 2021 21:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=oXkcL1lHMS9/atp/1M+2S4oUJFLqrFv1wWQ5I09WWZB5DvznwYznRkUaU8SkfqTGEs UYeW43uZrTmQYfz++FpfwhzLxXJ4rtEN+on9zjE9ohFbgKvRHbzOENyfiyVyRz37eJiR BFTrFfuAi9YJzDjhgAmeckvfyV99TbMfYgsZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=eL+7Bcb4NoxZceS+ITOeT9XY5nNFgyom1p2pbho9PtcbC68PJdHXzgp8cqHMmIWG1i J7Re3edbPSSHN2VQuURpdFeAJns+v1O3C3vmmj4DMWNIpp1nsnwLC9p6DVVXchoL8qmf 3Qn+SfSj1U5cknA2v9jDA7/dD1CUS1M87R3fp16XjxmO6AuwPTgXqRuyU6lLvBtkETKE r1a5e9e5SOVqMI6wQcwphud48WCYZBtHwUlwAXqmBraYDenWmNf/QtF0ucDCpLGLRwJZ r0v8/PNcPwwdnbe3za9Kd2CDWpU6nM0zPYL21KCzyNun5RU48VrGha8GddLQnPqMrXlz VLFg== X-Gm-Message-State: AOAM532zzkB6jfk5TGYiydKMZDJD3tpMURoEzDzXYwFIZOcTKxw2kR9G MObEZflyaRDz1Xn8DGzSj4e8lw== X-Google-Smtp-Source: ABdhPJy6K5CdM/3nHF3p+/2eE4TdGymi9eYrEEqROe+kZTRJZLv9zhp0SI6/MmsV0uYFWsxTx8DpSg== X-Received: by 2002:a62:1b88:0:b029:1fb:d3d0:343a with SMTP id b130-20020a621b880000b02901fbd3d0343amr26649171pfb.76.1619585743151; Tue, 27 Apr 2021 21:55:43 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:8076:36e5:2db0:967]) by smtp.gmail.com with ESMTPSA id x13sm1193170pgf.13.2021.04.27.21.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 21:55:42 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v4 3/3] arm64: dts: mt8183: Add panel rotation Date: Wed, 28 Apr 2021 12:55:33 +0800 Message-Id: <20210428045533.564724-3-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428045533.564724-1-hsinyi@chromium.org> References: <20210428045533.564724-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_215543_949513_6EAB2AAA X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index ff56bcfa3370..793cc9501337 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -263,6 +263,7 @@ panel: panel@0 { avee-supply = <&ppvarp_lcd>; pp1800-supply = <&pp1800_lcd>; backlight = <&backlight_lcd0>; + rotation = <270>; port { panel_in: endpoint { remote-endpoint = <&dsi_out>;