From patchwork Wed Apr 28 17:04:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DABC433B4 for ; Wed, 28 Apr 2021 17:06:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3983613B4 for ; Wed, 28 Apr 2021 17:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3983613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=j0iJEKw2ka+MhaUAJP+NRS0paEKCRAotEacZOWWSaHg=; b=FdpjWKaKOGsrNHuah+INRyiVXW FcFWXFflwNKr+6haE6dWWnshMD5K4rgCw9ToEVG802VAFqff0DnhIpUob5vFTyK+izLhoJHatcDYq r9r64JwR44L3InsLgZxzSmpOIZU9ZpCPJf2RD2qWDLjEm1F3yRwv2VfpZ3JqK82qMd9YWwXR8QPRm vWIwUmKakoUXF8my9yDk+oRn5kzKIkBAdz/BOP03S937U7z28DjjYWvvxu6oCSxXkvXUS1RLkvc3v VqW5wNz6Z0ObDgor/5IZTeU1guMFxXze/MgqXCAZbVKFVghlmsZBn/wdln3Vi3hePIwh7BNQX8i3/ I0GJ3Gng==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbx-003x3N-Lf; Wed, 28 Apr 2021 17:04:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbu-003x2L-Py for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 17:04:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=0pk6VIR1YgK4BI5RVFJ2neU+d+ B23kKzpDHMr6l/EwivCovgVHPXDuPey7rHu1OpMeNTMMA2E3rE0D0+IE4tAko+wy4CJJ0yaUSlduC cwGF52dgVviTOU0oARS9rm1W79pRqR45UJvOUzd9UAkaBIkLfCnI/EwmQHm5oYJxaxh+jxC6hOqha 74R/cPBZSfh6AkbCPWbou+tkKaQLKK4N6mRUWwS+KgXbTu4ynnVnFUtPmQsy/hpJ+lLCaUG4CKXZo Vv8gz418QML0u0IIa/grN/Dqtb+r6sD/OF2h5WR29r6DT12NMfT8ciIDQUA0COq33aJrCBtt4P2Q+ YqsoTanQ==; Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbr-0002sP-E9 for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 17:04:25 +0000 Received: by mail-pj1-x1034.google.com with SMTP id lp8so3089006pjb.1 for ; Wed, 28 Apr 2021 10:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=jBIBU3rmtD8yOrvV4BbfL6jvMl3ciy0ye03wj6yDfhp2J/1kUnpGeFR/OS8HIQf6PN Xh/U+XybtGkfUTkRvE0s0FDOeAbg8FFa8ipJ1Rn6jBnP5+5xfZGIm6M1terr4mPVdDik GXhE2PugYOf1BqEw59QPcjed52ZYlVnVxSDqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=OiIxM6+yj3f0mwfg+YotK24SGvrNAzZ/E5HZZ575SolYroL0CidyBaIO+Y1J1HxY87 Vofruq+qepQwlTV1auJJfVWTl9sH/IV9MOri9WLEK8VjdAHpy6qWqmDzukeG+N30jsa4 2E3q2/SsbIqqpFZP8m9dNRmtJ80Eu/TeeVaeMC5GYFo3fzMMdksuOZweKH/w3CnSogzm R+61hpvk/E6WOXuhe40xdIN+VIjLVkqlrkddQlFsT9JjpdUNF6WIh/MqoA6k6YP0j1BO SVrhYcDtamYnoXjD+KSwjxxS77g/Fx8r/RHzvqBvSWz0HfrsLUbrm9CXzN7IO6LjV1ms hYWA== X-Gm-Message-State: AOAM531gn8Y3/8vbeZpLe8P1yrXqkNUzCAPOGWAkSQ9c/J24LWW8GgXC zDJSEBogs5nRLGlAscUVMTyIHg== X-Google-Smtp-Source: ABdhPJx8QtZB1FX3UuGgKCpu+6pIJEYE2bHczJrQxYOtaGxXbs4f9PBgFNWspYeBzunpHZpovHfMGg== X-Received: by 2002:a17:902:7c94:b029:e6:e1d7:62b7 with SMTP id y20-20020a1709027c94b02900e6e1d762b7mr30895825pll.29.1619629461545; Wed, 28 Apr 2021 10:04:21 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:20 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 1/4] gpu: drm: separate panel orientation property creating and value setting Date: Thu, 29 Apr 2021 01:04:13 +0800 Message-Id: <20210428170416.1027484-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100423_538504_02FE4528 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel orientation property and set default value to UNKNOWN, so drivers can call this function to init the property earlier , and let the panel set the real value later. [ 4.480976] ------------[ cut here ]------------ [ 4.485603] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xb4/0xbc [ 4.609772] Call trace: [ 4.612208] __drm_mode_object_add+0xb4/0xbc [ 4.616466] drm_mode_object_add+0x20/0x2c [ 4.620552] drm_property_create+0xdc/0x174 [ 4.624723] drm_property_create_enum+0x34/0x98 [ 4.629241] drm_connector_set_panel_orientation+0x64/0xa0 [ 4.634716] boe_panel_get_modes+0x88/0xd8 [ 4.638802] drm_panel_get_modes+0x2c/0x48 [ 4.642887] panel_bridge_get_modes+0x1c/0x28 [ 4.647233] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.652273] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.658266] drm_mode_getconnector+0x1b4/0x45c [ 4.662699] drm_ioctl_kernel+0xac/0x128 [ 4.666611] drm_ioctl+0x268/0x410 [ 4.670002] drm_compat_ioctl+0xdc/0xf0 [ 4.673829] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.678436] el0_svc_common+0xf4/0x1c0 [ 4.682174] do_el0_svc_compat+0x28/0x3c [ 4.686088] el0_svc_compat+0x10/0x1c [ 4.689738] el0_sync_compat_handler+0xa8/0xcc [ 4.694171] el0_sync_compat+0x178/0x180 [ 4.698082] ---[ end trace b4f2db9d9c88610b ]--- [ 4.702721] ------------[ cut here ]------------ [ 4.707329] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:243 drm_object_attach_property+0x48/0xb8 [ 4.833830] Call trace: [ 4.836266] drm_object_attach_property+0x48/0xb8 [ 4.840958] drm_connector_set_panel_orientation+0x84/0xa0 [ 4.846432] boe_panel_get_modes+0x88/0xd8 [ 4.850516] drm_panel_get_modes+0x2c/0x48 [ 4.854600] panel_bridge_get_modes+0x1c/0x28 [ 4.858946] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.863984] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.869978] drm_mode_getconnector+0x1b4/0x45c [ 4.874410] drm_ioctl_kernel+0xac/0x128 [ 4.878320] drm_ioctl+0x268/0x410 [ 4.881711] drm_compat_ioctl+0xdc/0xf0 [ 4.885536] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.890142] el0_svc_common+0xf4/0x1c0 [ 4.893879] do_el0_svc_compat+0x28/0x3c [ 4.897791] el0_svc_compat+0x10/0x1c [ 4.901441] el0_sync_compat_handler+0xa8/0xcc [ 4.905873] el0_sync_compat+0x178/0x180 [ 4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v5: don't create property in set_panel_orientation. v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsinyi@chromium.org/ v1: set panel orientation in dsi driver https://patchwork.kernel.org/project/linux-mediatek/patch/20210409045314.3420733-1-hsinyi@chromium.org/ --- drivers/gpu/drm/drm_connector.c | 58 ++++++++++++++++++++++++--------- include/drm/drm_connector.h | 2 ++ 2 files changed, 44 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..7189baaabf41 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1210,7 +1210,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { * INPUT_PROP_DIRECT) will still map 1:1 to the actual LCD panel * coordinates, so if userspace rotates the picture to adjust for * the orientation it must also apply the same transformation to the - * touchscreen input coordinates. This property is initialized by calling + * touchscreen input coordinates. This property value is set by calling * drm_connector_set_panel_orientation() or * drm_connector_set_panel_orientation_with_quirk() * @@ -2173,8 +2173,8 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property); * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * - * This function sets the connector's panel_orientation and attaches - * a "panel orientation" property to the connector. + * This function sets the connector's panel_orientation value. If the property + * doesn't exist, it will return an error. * * Calling this function on a connector where the panel_orientation has * already been set is a no-op (e.g. the orientation has been overridden with @@ -2205,19 +2205,11 @@ int drm_connector_set_panel_orientation( info->panel_orientation = panel_orientation; prop = dev->mode_config.panel_orientation_property; - if (!prop) { - prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, - "panel orientation", - drm_panel_orientation_enum_list, - ARRAY_SIZE(drm_panel_orientation_enum_list)); - if (!prop) - return -ENOMEM; - - dev->mode_config.panel_orientation_property = prop; - } + if (WARN_ON(!prop)) + return -EINVAL; - drm_object_attach_property(&connector->base, prop, - info->panel_orientation); + drm_object_property_set_value(&connector->base, prop, + info->panel_orientation); return 0; } EXPORT_SYMBOL(drm_connector_set_panel_orientation); @@ -2225,7 +2217,7 @@ EXPORT_SYMBOL(drm_connector_set_panel_orientation); /** * drm_connector_set_panel_orientation_with_quirk - * set the connector's panel_orientation after checking for quirks - * @connector: connector for which to init the panel-orientation property. + * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * @width: width in pixels of the panel, used for panel quirk detection * @height: height in pixels of the panel, used for panel quirk detection @@ -2252,6 +2244,40 @@ int drm_connector_set_panel_orientation_with_quirk( } EXPORT_SYMBOL(drm_connector_set_panel_orientation_with_quirk); +/** + * drm_connector_init_panel_orientation_property - + * create the connector's panel orientation property + * + * This function attaches a "panel orientation" property to the connector + * and initializes its value to DRM_MODE_PANEL_ORIENTATION_UNKNOWN. + * + * The value of the property can be set by drm_connector_set_panel_orientation() + * or drm_connector_set_panel_orientation_with_quirk() later. + * + * Returns: + * Zero on success, negative errno on failure. + */ +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector) +{ + struct drm_device *dev = connector->dev; + struct drm_property *prop; + + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, + "panel orientation", + drm_panel_orientation_enum_list, + ARRAY_SIZE(drm_panel_orientation_enum_list)); + if (!prop) + return -ENOMEM; + + dev->mode_config.panel_orientation_property = prop; + drm_object_attach_property(&connector->base, prop, + DRM_MODE_PANEL_ORIENTATION_UNKNOWN); + + return 0; +} +EXPORT_SYMBOL(drm_connector_init_panel_orientation_property); + int drm_connector_set_obj_prop(struct drm_mode_object *obj, struct drm_property *property, uint64_t value) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 1922b278ffad..4396c1c4a5db 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1696,6 +1696,8 @@ int drm_connector_set_panel_orientation_with_quirk( struct drm_connector *connector, enum drm_panel_orientation panel_orientation, int width, int height); +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector); int drm_connector_attach_max_bpc_property(struct drm_connector *connector, int min, int max); From patchwork Wed Apr 28 17:04:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7282EC433ED for ; Wed, 28 Apr 2021 17:06:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B604C613A9 for ; Wed, 28 Apr 2021 17:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B604C613A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GhJaxG3zvx6iHiJMzgiyEkCl0iyagMgGoGXt5a/fNJA=; b=dk3jUP4LT9Ma+qCw3S90ZGWe1 udZYXzYHHjQzmApRFQubtxBIOfOJNBgFz8hWEuXL5zPQIonXW8KhPavVUJExHjBI95aUYqdYOEqof aRXWisQ4k8nADt46C4GZcXReogZQGsIg76wAM1pXXIJSyrbLEIt/gOh/CC+GV7yndXuJ31NORNagr vJoq5aXdXabKtRbK+fmS+5kDdRLmC6GcyqKGYwhsZJUttcYRhwzloMKL38bnmRp/9SZFBmLWXdWgq 8urNNwVEgIOFzqgA+RTHb0YNf2Sap7OXYs/VsKJcA4ySy51S+EJDZgdSBr52c87GE2ZomFzvR2DTC oGnuo/2sg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncF-003x5q-Gv; Wed, 28 Apr 2021 17:04:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbx-003x3S-Ui for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 17:04:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=WkWjAh/hgxuJJM+evPSVfVjWnK ex//ASz/mQZhEipa79cVH61Pn2afE1ZrUPch2jDcrwulgJVuycaR+FEPOY0pUrG62wMlw2Q71Ko7+ x/u8e+9DwCPISOpj90F8RjI+PIjdVpTnMi1voYYQY2y8/YCXu4LhumJ5+gOQVypNKW4Ouw20YRVOe cGQ4HtxnGWgD9OjC4pUocRpGleh1zsOdV/d5+ccgZgwZoUNe8NhtVuwRElZdXgmWQmXu+hpBrJDia neSSBBwvq77fnPoClqXHPP3006wIfV2kiZMJMx4tQ2XO9GeK0VaMMOOG1aT4Ig+kmY2ntW046W5FW AuV79FRg==; Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbu-0002su-UR for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 17:04:28 +0000 Received: by mail-pg1-x532.google.com with SMTP id m37so2610335pgb.8 for ; Wed, 28 Apr 2021 10:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=Oh1pOQY3nDNpYWg6CBPvoxbwz9Lp5/mgbvExVmkdIhmJlVZGash3DmwrmBb4CIKHon qhIf723E2NT3KLDzilpKerGauzvnOHbY+s/nFoAFNFIGUDyS721zHl0d0K2csd5vwIJO eIVQuYBad9ZmHQ0iSC96gsmAMu/m1PJWWkJCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=LlxOdxzrJCHCdlogqi7tSmMfAGW67PMmgilgjFNk5uUSzy/P1ec0ATLLa3ebzFt+Sp Wv1gXkEb5INEFoKCKZyn34ifcfKXZkNdLifDMVGF34KeKsNjrS/J/baveWBGUr+8PdgX L0lEYcDabuFek/WwD8Tieb5gsAn0oTYM0uGbKcFbGJBI6HPmInescqBLbIss+u4IEfoq YxZMF7n7zvkstZJhPDUQROwHDucsDSOvQSNEBFGPXTafiaWjuetlDgoU6tR0tDtqNIpT BCBWW5oXq4ylsWJ9/8PuMLlXCyGee1+QXvYjkaJ8zOsiVRJDZd5X/+3LMnqiQINKJ2HK A1DA== X-Gm-Message-State: AOAM532VcmhGoU6mqKGMP2GferIPpku52BfYf7JMoMk5I6DVWDVSSQV3 7Hnb0OgZQ1Bz5hldr8BXuZ+tiw== X-Google-Smtp-Source: ABdhPJxErM53epytFNpIJdI3/a9zdSqFrICBlsEBiJkNLoECwWzSEjPVpUQPi64CmaQN2g4Kj9Mq2A== X-Received: by 2002:a63:1921:: with SMTP id z33mr28455929pgl.211.1619629464253; Wed, 28 Apr 2021 10:04:24 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:23 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 2/4] drm/mediatek: init panel orientation property Date: Thu, 29 Apr 2021 01:04:14 +0800 Message-Id: <20210428170416.1027484-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100426_987395_68BE81B6 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..9da1fd649131 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } + + ret = drm_connector_init_panel_orientation_property(dsi->connector); + if (ret) { + DRM_ERROR("Unable to init panel orientation\n"); + goto err_cleanup_encoder; + } + drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0; From patchwork Wed Apr 28 17:04:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4620C433ED for ; Wed, 28 Apr 2021 17:06:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AFC36135B for ; Wed, 28 Apr 2021 17:06:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AFC36135B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XnzRkQlLWoNwE29UussupfKs/j/pE1wNXFeJcJCVsJ0=; b=Q6OsgRSusqlHWp92poGbsOpQm Qvg8QqQqcZ/yT5VdfnM4lO6XFKYTqX6OI4y6dUe49L3fo95CxWTDaE70Ue3sUlbvCqXcY6SPQeSSK 8LgCE//sRc50aZrmXCUO1ZDkXpAfdT28lPZI/uETzW8bBfzm5jka5SkyfOy5/RYxUo8F8XN6lDBTZ wCNTuvHcyMb5EKOGwqsrzuev5CWD7CYShblTTvp94DrhRAnb0+u3+wtKN5p5JHEV+odjmRML3UCa0 Pn/CfZYXDqHQiBFt3OdX83zIOrjFru22ntgS012erd9sMxIJ7Ndmp+9iEEKA5PlfqjNIVXB82ScWb 8ohHsZaWg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncP-003x7m-5Q; Wed, 28 Apr 2021 17:04:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnby-003x3Z-1K for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 17:04:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=v4lJZSqm+9FK91AbfJ6Di6v1ej k10QszqSWCFaZaiVW1rxfvfwuNjLgn5XJu7sxy1xEQQdHeElCBfQlG6Q1SSQkKp2SFmqTsBj/Meo/ UHSBZUb/DO+71aNmjiJjiiH29CuNdTqn0qdm4xwkAVioLZvXncx6K17FQgcGQIUyNhCbWJf2G3BBw VdUY2Mn+nUTFd98uzwvS2Qg46Ck1OlRJjkC0HFjaRd6hKmNXRlFAn7Pr8fY/wvEzFkb7LVaLqsdW9 eQ6KcmbTwlD+av5txVr5cU8IX7rzhgNKKQIRJEfTyh1Qh+1oDFb5AHe39195vGkr7iG/Rd1R6eb34 KzkVu83w==; Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbv-0002tt-86 for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 17:04:28 +0000 Received: by mail-pj1-x1032.google.com with SMTP id lr7so14996519pjb.2 for ; Wed, 28 Apr 2021 10:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=CZh4ewpebCFcAjzU4EibSFFnrvhXZVPNRc4wOzEuTvrh0wTnh9QHrTxtcPEp03msf7 p7qFTJYHHFvKYz9uDrzBQ+Qy+3fq16YM4Kqd8u0m6gWqZLA9Q5vHC5ZZ5f6tWNAMjifU mPdOOxsXHBf119G0QvEHwNweX9sC3c6CawxkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=fQxXEm/i9IhpI7slTp8FBMFen2cinFYE9ezBaxNUGMRGEkMvc2ptJom0HADG8fb5uF dPY+pxf3dSupU2N02gachHdSPXKna57nwJlNW/lODCnz4sLcLYemaCGWkcZYwOOX/oRh 1W7rt7grQU9vHYJzW0yzj43p5TyYTkvCLDDGnShnpdJ2kAyuikbMTLZAJ2leJaXS/zSq gE9xhmjci1zzRVqyxySkCJ41W4glKh+ePPUtMtHfRxOB1mRTcgBkIUUc5/rSH4g9BGv7 k7MlQc3hpYVbhgQtjLFcFGoAXFbWAItJzSSw5sEvztscONLy2o/hyWlbRdMWfr1j95GI B+IQ== X-Gm-Message-State: AOAM5336IaXw+GVJiNp520VjdGIODtOF9VtxXHvMxjfbm7H8PGKvdNfr pSBpBorur86sQJe3HC/Z2F1W3g== X-Google-Smtp-Source: ABdhPJxVuaBy5Crg4238Rnf+mjDK9f2leKWDPf3f+mhW2AoCjVsaiScJhXB+4Y2JkeULZDYrLebEmA== X-Received: by 2002:a17:90a:e298:: with SMTP id d24mr10097975pjz.144.1619629466765; Wed, 28 Apr 2021 10:04:26 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:26 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 3/4] drm/i915: init panel orientation property Date: Thu, 29 Apr 2021 01:04:15 +0800 Message-Id: <20210428170416.1027484-3-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100427_313025_575129B2 X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Creating the panel orientation property first since we separate the property creating and value setting. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/vlv_dsi.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index 9282978060b0..162fb3cf0f5a 100644 --- a/drivers/gpu/drm/i915/display/icl_dsi.c +++ b/drivers/gpu/drm/i915/display/icl_dsi.c @@ -1903,6 +1903,7 @@ static void icl_dsi_add_properties(struct intel_connector *connector) connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; + drm_connector_attach_scaling_mode_property(&connector->base); drm_connector_set_panel_orientation_with_quirk(&connector->base, intel_dsi_get_panel_orientation(connector), connector->panel.fixed_mode->hdisplay, diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index a5231ac3443a..f1d664e5abb2 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5263,6 +5263,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, intel_panel_setup_backlight(connector, pipe); if (fixed_mode) { + drm_connector_init_panel_orientation_property(connector); drm_connector_set_panel_orientation_with_quirk(connector, dev_priv->vbt.orientation, fixed_mode->hdisplay, fixed_mode->vdisplay); diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index 9bee99fe5495..853855482af1 100644 --- a/drivers/gpu/drm/i915/display/vlv_dsi.c +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c @@ -1632,6 +1632,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; + drm_connector_init_panel_orientation_property(&connector->base); drm_connector_set_panel_orientation_with_quirk( &connector->base, intel_dsi_get_panel_orientation(connector), From patchwork Wed Apr 28 17:04:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA63C433ED for ; Wed, 28 Apr 2021 17:06:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6611613A9 for ; Wed, 28 Apr 2021 17:06:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6611613A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lfgrEUsbN32h4O/2Hwqbu1Wg1Lufki+DGuOnxLv8cJE=; b=cPAyjgo68cPR9z7eLJydMpRcG VVpooV47evb6Q250+Ud5ZLEX5Vr6AlxNlF9CUMmhlxBLf5Yossgqy9fInifzeKjsKGehrXgfsLUDa 7WYg0l9Gb19M8wH/c1j/mEMETWoRk/W1AN4Sxx1hXH6ntziOK63bG/dlU76xxlMpNcIPMsPXWFE7+ HYbqvIBmDCfjZm0i76/lAhXZDCbkMKeGhAZayKQPX3ZakaYUoG4bsA/u3lMf39nehlufGU9zp2TSF bme/bF5pdU8+f48Lm3jtIzTLG300O/1Dt81/76mo5ACkoWrzu/9TQYrjPPotvXXpxIjfL7L+rRenz HsJ7Phf9A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncc-003xBZ-98; Wed, 28 Apr 2021 17:05:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnc0-003x42-Pg for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 17:04:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=pH1fYJ9eOrVxKoj3cTp0RGQWq4 61CiK5DQxsbl3b88TcxLLrSUUmwudZ6D0Q9a074SvCdwhsLp8HGr9tu+507uHnLwe5wYYCgQOLmif lw14TVa4QyRpJu9kyRGIsb27zjhTkP+5SVezO5vy+9DBc4tbWmvTLK2tqt82HYMPXWB+yRrqM6gpd dncmnr/1ngqnH65g66nmt+jCPH/6Kjmqs2feJQrZv6w7cakmbdCK7l89DD3wsEqeT4GFJF/NW6ivA DrmiyUFNXR68ZX/txJrEM1TM6fEhMDDOuN11uIyx6+q/N66ikpM23Y2RYAYRHBnokG6/XBPMUlw0t 3yeFn9GQ==; Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnby-0002ud-Df for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 17:04:31 +0000 Received: by mail-pf1-x431.google.com with SMTP id i190so4574379pfc.12 for ; Wed, 28 Apr 2021 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=ZBABP32kAKUkL73RzLrs/VZTLUwl6tRRR4kreJjVivIQnqrLTx++PGkZdghCv6A51h i5wfgs4sj08UJWCJZAhmuB1UPJXH2+qBGrDT9VrYMuWAyEi9ipQ4WYYmOIrBtCW1JSTT xZT0g/d1wPha/HFRrZyfSi4R5Ae53TxzQP2kU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=NjmufMai7zKOwVeXLZj960QEySEGZ2r4vFNwFiKoFDdFGB9T6fpR8Mv78xyrye8sSO 8gAYWjpS3K7ZVsMNtxFNyRF0m4RSJX/YatdoaV9K77GpTQH/4hH3Mmc1iuTsrFzIMf35 PC63kCrQLLNSlFEX4TrTHMPEPTT4T+4Y8iiK37OwrU2FCgKke8ItBcylC7K3P6jvCg1G 3/ftxkKFQ9GDPBKATy9clORsoGlV/0zbQaWMVv3FmL33ezONg+nqBs+yhwfgkfvZ+TQv /Mh1j9hxv9FBOoiblBStv9Fn4yynXGWZSbTEwgBb8pL4LgRibtQHlNFf8shLOAVF1i57 XiUw== X-Gm-Message-State: AOAM533Su7bLqW+c0Aw7GuzfIJm5UHkauhnvYxVIxqf/0TZArk9AXMBo 4jQ6QALwhLZLY3SPoZWSoICBgA== X-Google-Smtp-Source: ABdhPJxmrYhCyqvJ9YcpCKMIp11Js7eA8QUCI7vGyyUeKC4ER8oO8PiDoUeETkQrLQ/8pN+UBHWhJg== X-Received: by 2002:aa7:92cb:0:b029:1f1:542f:2b2b with SMTP id k11-20020aa792cb0000b02901f1542f2b2bmr28418795pfa.31.1619629469280; Wed, 28 Apr 2021 10:04:29 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:28 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 4/4] arm64: dts: mt8183: Add panel rotation Date: Thu, 29 Apr 2021 01:04:16 +0800 Message-Id: <20210428170416.1027484-4-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100430_467472_B78018C1 X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index ff56bcfa3370..793cc9501337 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -263,6 +263,7 @@ panel: panel@0 { avee-supply = <&ppvarp_lcd>; pp1800-supply = <&pp1800_lcd>; backlight = <&backlight_lcd0>; + rotation = <270>; port { panel_in: endpoint { remote-endpoint = <&dsi_out>;