From patchwork Wed Apr 28 17:04:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5323DC433ED for ; Wed, 28 Apr 2021 17:05:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4B3F6143F for ; Wed, 28 Apr 2021 17:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4B3F6143F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=gO1bB2+GkP0YEinG+R+ZnR1CtddKt03Xcd2CnD96pl4=; b=Jjc6X89R73QvhsXpPbz/ye/FlY cneS+4kTpQq8B1jLe4iCZFid/62dz7bdoj1H6gPARA+22S3VTMsZRkJART9VADVdVSweLuWlIy1lb IaX56VZc4WXCTJreQ5nmRYXMHmWdCtGMIxSXMOkYFnuzHmbdJZCMzQtdyEyheMgNT/0kmBQ+mT3JI EeqFfYKCHTLBvbq0pK1wdlzy31gFzHdFcQmVmSHqMwzCCXOuJNOvkvXEav4rcOrGICbciWqV4oIAJ 26PKgtbU2pyl0+fE5b+4h4DzYqwhHjjSZYiQ6ZosUxOdAb4wXrsRsUnqHKw6AjO7gXkIIqikWAHr5 zpQZtKww==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncA-003x54-AX; Wed, 28 Apr 2021 17:04:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbw-003x3K-H4 for linux-mediatek@desiato.infradead.org; Wed, 28 Apr 2021 17:04:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=0pk6VIR1YgK4BI5RVFJ2neU+d+ B23kKzpDHMr6l/EwivCovgVHPXDuPey7rHu1OpMeNTMMA2E3rE0D0+IE4tAko+wy4CJJ0yaUSlduC cwGF52dgVviTOU0oARS9rm1W79pRqR45UJvOUzd9UAkaBIkLfCnI/EwmQHm5oYJxaxh+jxC6hOqha 74R/cPBZSfh6AkbCPWbou+tkKaQLKK4N6mRUWwS+KgXbTu4ynnVnFUtPmQsy/hpJ+lLCaUG4CKXZo Vv8gz418QML0u0IIa/grN/Dqtb+r6sD/OF2h5WR29r6DT12NMfT8ciIDQUA0COq33aJrCBtt4P2Q+ YqsoTanQ==; Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbr-0002sO-EY for linux-mediatek@lists.infradead.org; Wed, 28 Apr 2021 17:04:27 +0000 Received: by mail-pj1-x1032.google.com with SMTP id gc22-20020a17090b3116b02901558435aec1so5743663pjb.4 for ; Wed, 28 Apr 2021 10:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=jBIBU3rmtD8yOrvV4BbfL6jvMl3ciy0ye03wj6yDfhp2J/1kUnpGeFR/OS8HIQf6PN Xh/U+XybtGkfUTkRvE0s0FDOeAbg8FFa8ipJ1Rn6jBnP5+5xfZGIm6M1terr4mPVdDik GXhE2PugYOf1BqEw59QPcjed52ZYlVnVxSDqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IL6VtwyrB5+6ourxVlpFTYNY9lv5VYl4yNeQCMyMGW4=; b=F3Pg7Ay3CifFx8hT8LF0O1S+URKaKeYg5paHUlNewk8sMoCzH841gG771OW0QpGCHN iNyWDq/5zuGG6h0k8ABnZuc5g3c5+i13wUVGg7j6DSr1xCi0FtF+oEzexAUZLEUEM3ZY FsEl2zbPPSYuos9WRNK5fSScf1v0tMJxfC6IR099sggekdw25Tc9CZIQPwqf+YLA433F tcU3H0JhYJlMsZlRSeEJpZwMvo45GgYL7k1T7+BQc2u/NxXvhuR5PvxNJk8BTg1Y4HwZ lotWkue8t49rkLmipwwxGgUzGJG6U4VZkM+gFl1XBNtZNwGLvf98uSA/jBUDJHjWThjt wUVg== X-Gm-Message-State: AOAM533bae9j7NbyITocs+3AQHbIIO84sxC6xJO5ODwL7D/5YywZWHWF sFxyipOoATgNfbnJ2YZrL8VBvw== X-Google-Smtp-Source: ABdhPJx8QtZB1FX3UuGgKCpu+6pIJEYE2bHczJrQxYOtaGxXbs4f9PBgFNWspYeBzunpHZpovHfMGg== X-Received: by 2002:a17:902:7c94:b029:e6:e1d7:62b7 with SMTP id y20-20020a1709027c94b02900e6e1d762b7mr30895825pll.29.1619629461545; Wed, 28 Apr 2021 10:04:21 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:20 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 1/4] gpu: drm: separate panel orientation property creating and value setting Date: Thu, 29 Apr 2021 01:04:13 +0800 Message-Id: <20210428170416.1027484-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100423_537178_3A2B9038 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel orientation property and set default value to UNKNOWN, so drivers can call this function to init the property earlier , and let the panel set the real value later. [ 4.480976] ------------[ cut here ]------------ [ 4.485603] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xb4/0xbc [ 4.609772] Call trace: [ 4.612208] __drm_mode_object_add+0xb4/0xbc [ 4.616466] drm_mode_object_add+0x20/0x2c [ 4.620552] drm_property_create+0xdc/0x174 [ 4.624723] drm_property_create_enum+0x34/0x98 [ 4.629241] drm_connector_set_panel_orientation+0x64/0xa0 [ 4.634716] boe_panel_get_modes+0x88/0xd8 [ 4.638802] drm_panel_get_modes+0x2c/0x48 [ 4.642887] panel_bridge_get_modes+0x1c/0x28 [ 4.647233] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.652273] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.658266] drm_mode_getconnector+0x1b4/0x45c [ 4.662699] drm_ioctl_kernel+0xac/0x128 [ 4.666611] drm_ioctl+0x268/0x410 [ 4.670002] drm_compat_ioctl+0xdc/0xf0 [ 4.673829] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.678436] el0_svc_common+0xf4/0x1c0 [ 4.682174] do_el0_svc_compat+0x28/0x3c [ 4.686088] el0_svc_compat+0x10/0x1c [ 4.689738] el0_sync_compat_handler+0xa8/0xcc [ 4.694171] el0_sync_compat+0x178/0x180 [ 4.698082] ---[ end trace b4f2db9d9c88610b ]--- [ 4.702721] ------------[ cut here ]------------ [ 4.707329] WARNING: CPU: 5 PID: 369 at drivers/gpu/drm/drm_mode_object.c:243 drm_object_attach_property+0x48/0xb8 [ 4.833830] Call trace: [ 4.836266] drm_object_attach_property+0x48/0xb8 [ 4.840958] drm_connector_set_panel_orientation+0x84/0xa0 [ 4.846432] boe_panel_get_modes+0x88/0xd8 [ 4.850516] drm_panel_get_modes+0x2c/0x48 [ 4.854600] panel_bridge_get_modes+0x1c/0x28 [ 4.858946] drm_bridge_connector_get_modes+0xa0/0xd4 [ 4.863984] drm_helper_probe_single_connector_modes+0x218/0x700 [ 4.869978] drm_mode_getconnector+0x1b4/0x45c [ 4.874410] drm_ioctl_kernel+0xac/0x128 [ 4.878320] drm_ioctl+0x268/0x410 [ 4.881711] drm_compat_ioctl+0xdc/0xf0 [ 4.885536] __arm64_compat_sys_ioctl+0xc8/0x100 [ 4.890142] el0_svc_common+0xf4/0x1c0 [ 4.893879] do_el0_svc_compat+0x28/0x3c [ 4.897791] el0_svc_compat+0x10/0x1c [ 4.901441] el0_sync_compat_handler+0xa8/0xcc [ 4.905873] el0_sync_compat+0x178/0x180 [ 4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang --- v5: don't create property in set_panel_orientation. v4, v3: create property in dsi driver and set value in panel. v2: create property in connector init https://patchwork.kernel.org/project/linux-mediatek/patch/20210426051848.2600890-1-hsinyi@chromium.org/ v1: set panel orientation in dsi driver https://patchwork.kernel.org/project/linux-mediatek/patch/20210409045314.3420733-1-hsinyi@chromium.org/ --- drivers/gpu/drm/drm_connector.c | 58 ++++++++++++++++++++++++--------- include/drm/drm_connector.h | 2 ++ 2 files changed, 44 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..7189baaabf41 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1210,7 +1210,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = { * INPUT_PROP_DIRECT) will still map 1:1 to the actual LCD panel * coordinates, so if userspace rotates the picture to adjust for * the orientation it must also apply the same transformation to the - * touchscreen input coordinates. This property is initialized by calling + * touchscreen input coordinates. This property value is set by calling * drm_connector_set_panel_orientation() or * drm_connector_set_panel_orientation_with_quirk() * @@ -2173,8 +2173,8 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property); * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * - * This function sets the connector's panel_orientation and attaches - * a "panel orientation" property to the connector. + * This function sets the connector's panel_orientation value. If the property + * doesn't exist, it will return an error. * * Calling this function on a connector where the panel_orientation has * already been set is a no-op (e.g. the orientation has been overridden with @@ -2205,19 +2205,11 @@ int drm_connector_set_panel_orientation( info->panel_orientation = panel_orientation; prop = dev->mode_config.panel_orientation_property; - if (!prop) { - prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, - "panel orientation", - drm_panel_orientation_enum_list, - ARRAY_SIZE(drm_panel_orientation_enum_list)); - if (!prop) - return -ENOMEM; - - dev->mode_config.panel_orientation_property = prop; - } + if (WARN_ON(!prop)) + return -EINVAL; - drm_object_attach_property(&connector->base, prop, - info->panel_orientation); + drm_object_property_set_value(&connector->base, prop, + info->panel_orientation); return 0; } EXPORT_SYMBOL(drm_connector_set_panel_orientation); @@ -2225,7 +2217,7 @@ EXPORT_SYMBOL(drm_connector_set_panel_orientation); /** * drm_connector_set_panel_orientation_with_quirk - * set the connector's panel_orientation after checking for quirks - * @connector: connector for which to init the panel-orientation property. + * @connector: connector for which to set the panel-orientation property. * @panel_orientation: drm_panel_orientation value to set * @width: width in pixels of the panel, used for panel quirk detection * @height: height in pixels of the panel, used for panel quirk detection @@ -2252,6 +2244,40 @@ int drm_connector_set_panel_orientation_with_quirk( } EXPORT_SYMBOL(drm_connector_set_panel_orientation_with_quirk); +/** + * drm_connector_init_panel_orientation_property - + * create the connector's panel orientation property + * + * This function attaches a "panel orientation" property to the connector + * and initializes its value to DRM_MODE_PANEL_ORIENTATION_UNKNOWN. + * + * The value of the property can be set by drm_connector_set_panel_orientation() + * or drm_connector_set_panel_orientation_with_quirk() later. + * + * Returns: + * Zero on success, negative errno on failure. + */ +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector) +{ + struct drm_device *dev = connector->dev; + struct drm_property *prop; + + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE, + "panel orientation", + drm_panel_orientation_enum_list, + ARRAY_SIZE(drm_panel_orientation_enum_list)); + if (!prop) + return -ENOMEM; + + dev->mode_config.panel_orientation_property = prop; + drm_object_attach_property(&connector->base, prop, + DRM_MODE_PANEL_ORIENTATION_UNKNOWN); + + return 0; +} +EXPORT_SYMBOL(drm_connector_init_panel_orientation_property); + int drm_connector_set_obj_prop(struct drm_mode_object *obj, struct drm_property *property, uint64_t value) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 1922b278ffad..4396c1c4a5db 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1696,6 +1696,8 @@ int drm_connector_set_panel_orientation_with_quirk( struct drm_connector *connector, enum drm_panel_orientation panel_orientation, int width, int height); +int drm_connector_init_panel_orientation_property( + struct drm_connector *connector); int drm_connector_attach_max_bpc_property(struct drm_connector *connector, int min, int max); From patchwork Wed Apr 28 17:04:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54765C43470 for ; Wed, 28 Apr 2021 17:05:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4A1C6143C for ; Wed, 28 Apr 2021 17:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4A1C6143C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/bTGpQDjoE6twSUHm+qNXqx5PIRVx4vG7B18bmSp/Xc=; b=aNvpSZCCo8IPeFDHxAEjCqYGf NLzuHzSynZAzQWUj9K4OejCzeDWZ+81RIEh0huK12oryVA9vma/I6k0L+uzLJy5W5aQd/n42Nvexd EX5STRkTp2Ow4KpxGF1Xu/igHuqO2Vb2pfmQpPfNC8hwXjFoVafxxDMe6NcWNzPn6m+XcntjuAiNs dyr3VOMKDkEu7VCU76KhPTlOGHG0hg9zk1RdB3VJTcqlXsVDUPYvmcIqyxo3o+bdklDq9HkoDZKVY DdbyC3wSdDSdAWW4miAQdvInUFRDL8Ur7asWgwNuL/NkR2houIDmDZIirv2xe/+9EKzNRANCu0w62 aaxN46VXw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncC-003x5R-4O; Wed, 28 Apr 2021 17:04:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbx-003x3P-TX for linux-mediatek@desiato.infradead.org; Wed, 28 Apr 2021 17:04:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=WkWjAh/hgxuJJM+evPSVfVjWnK ex//ASz/mQZhEipa79cVH61Pn2afE1ZrUPch2jDcrwulgJVuycaR+FEPOY0pUrG62wMlw2Q71Ko7+ x/u8e+9DwCPISOpj90F8RjI+PIjdVpTnMi1voYYQY2y8/YCXu4LhumJ5+gOQVypNKW4Ouw20YRVOe cGQ4HtxnGWgD9OjC4pUocRpGleh1zsOdV/d5+ccgZgwZoUNe8NhtVuwRElZdXgmWQmXu+hpBrJDia neSSBBwvq77fnPoClqXHPP3006wIfV2kiZMJMx4tQ2XO9GeK0VaMMOOG1aT4Ig+kmY2ntW046W5FW AuV79FRg==; Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbu-0002st-Tn for linux-mediatek@lists.infradead.org; Wed, 28 Apr 2021 17:04:28 +0000 Received: by mail-pf1-x42b.google.com with SMTP id h11so4530440pfn.0 for ; Wed, 28 Apr 2021 10:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=Oh1pOQY3nDNpYWg6CBPvoxbwz9Lp5/mgbvExVmkdIhmJlVZGash3DmwrmBb4CIKHon qhIf723E2NT3KLDzilpKerGauzvnOHbY+s/nFoAFNFIGUDyS721zHl0d0K2csd5vwIJO eIVQuYBad9ZmHQ0iSC96gsmAMu/m1PJWWkJCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5arbhYfGXT82qjQUTN0xccKMerRCIU7+UPVnm07W9Y=; b=bX6WrS/kPD9CSWu4gQ9iTUo64XeloOES8rzExPZqZBIu4rPW2Sl/gsAtrC98Bpf9n1 EabJQYNpPEjkzF2e9wKHXhlebX/72+coS5uLgiWiUoXVs06OWimZutG0D8nUaawORhv2 wrKhZ/kR5oXS9VIZ0eEkojCbP9lJBqCG/1Gcu8VoADTE2GqdIC8nNAECqy7hsXwMEGDD D4UI8mR8xZUr6RP6zC7rh5qfHoi15HVxK6EezHLw6l2HqtUwMwaAxASkX58TtCIjpaxb rqTswiIrR7+wLlmXsvOxWL7EIcu5PRKqgTDvpThdNSLa1Y20oSydgz2qqyQ9zNlke6RG Zm4A== X-Gm-Message-State: AOAM533xbQ0fviON4TagTL6ep7rq7jwLA16yMc3lN9DNkiJOEZgMm7N2 /ZaJtTsXjx3VUZC3D3GpBsKx9w== X-Google-Smtp-Source: ABdhPJxErM53epytFNpIJdI3/a9zdSqFrICBlsEBiJkNLoECwWzSEjPVpUQPi64CmaQN2g4Kj9Mq2A== X-Received: by 2002:a63:1921:: with SMTP id z33mr28455929pgl.211.1619629464253; Wed, 28 Apr 2021 10:04:24 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:23 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 2/4] drm/mediatek: init panel orientation property Date: Thu, 29 Apr 2021 01:04:14 +0800 Message-Id: <20210428170416.1027484-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100426_981119_31351E7B X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..9da1fd649131 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } + + ret = drm_connector_init_panel_orientation_property(dsi->connector); + if (ret) { + DRM_ERROR("Unable to init panel orientation\n"); + goto err_cleanup_encoder; + } + drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0; From patchwork Wed Apr 28 17:04:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614C6C433B4 for ; Wed, 28 Apr 2021 17:05:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A26236143A for ; Wed, 28 Apr 2021 17:05:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A26236143A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oypGYgx2sL0+5cxSs1Hb2onhGl1YT4VFCDYNv+xX6aI=; b=cBkPUa57bJnJ4HYgMkObsEzi8 tcguJDmiKYaM+Fvwm+9xf6YNvZTFCTh58II5qbFYAQ4Qesrhji1pnuNmz+dnq1++dZMHuhqHjPt4E JD3AsfgDboLUNUnO6Mk8ambkiMHvEheRmbL3Q04GGk8lRKx0TyiuEHNKE8QsyJ/p/A8cgNivMKfpR dValswrq/VIXfaJz/kPJ3dgHqId+EmvmD3nzrF78DinrMi9O+AV9Q9YcL41E2xawYE8YwYrCpD09U t8D9NOo/9QLakFbYzZ665MBDUJH8iNPoBt0aYmnyBOSwJIIna2mCRqozWJCg/5XrXjEe83BbcIY55 9wd01tESw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncY-003xAO-B9; Wed, 28 Apr 2021 17:05:06 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnby-003x3b-EJ for linux-mediatek@desiato.infradead.org; Wed, 28 Apr 2021 17:04:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=v4lJZSqm+9FK91AbfJ6Di6v1ej k10QszqSWCFaZaiVW1rxfvfwuNjLgn5XJu7sxy1xEQQdHeElCBfQlG6Q1SSQkKp2SFmqTsBj/Meo/ UHSBZUb/DO+71aNmjiJjiiH29CuNdTqn0qdm4xwkAVioLZvXncx6K17FQgcGQIUyNhCbWJf2G3BBw VdUY2Mn+nUTFd98uzwvS2Qg46Ck1OlRJjkC0HFjaRd6hKmNXRlFAn7Pr8fY/wvEzFkb7LVaLqsdW9 eQ6KcmbTwlD+av5txVr5cU8IX7rzhgNKKQIRJEfTyh1Qh+1oDFb5AHe39195vGkr7iG/Rd1R6eb34 KzkVu83w==; Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnbv-0002ts-Th for linux-mediatek@lists.infradead.org; Wed, 28 Apr 2021 17:04:29 +0000 Received: by mail-pj1-x102c.google.com with SMTP id p17so5244427pjz.3 for ; Wed, 28 Apr 2021 10:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=CZh4ewpebCFcAjzU4EibSFFnrvhXZVPNRc4wOzEuTvrh0wTnh9QHrTxtcPEp03msf7 p7qFTJYHHFvKYz9uDrzBQ+Qy+3fq16YM4Kqd8u0m6gWqZLA9Q5vHC5ZZ5f6tWNAMjifU mPdOOxsXHBf119G0QvEHwNweX9sC3c6CawxkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fUBR0WopHj0WR6JMHf2d83zcvjlEdxgAs9fymIBITzo=; b=KCK1g/benOzyEXvSolaWTxxEinR7AKnuuhzIbFzcG/Y5WwJyhNGU5Vev+KKbUHvPTB EQrq4R5ypWYCwrW9j7MbPdD7A/K8VP8KFtXW9cLdSS1iJTYRAmvVvhUedxenIcytGn63 pVXFaEBJDEGl2epCODtzTZWVX5B3nwgp6Kgawcw6gWCZ/Ff0Q2S6+aw61K8uNewB153U QAeVFU0Xt3iMLsGierJrHeXjWqKy9ef5nmGZXmahH6wicCyk+oXIxTH8LylwYOnnYbCo TbHQakGIQClCxLf/QbLf7df3d3ccaTI/bSOSE7+IoLccIYKyq5Uu3O8jbX5sLLwTyI0G rTZg== X-Gm-Message-State: AOAM5332pcISBRe0Tvq0YLVqZJYOlnmkCL5Xx9Hk9vorkKRIGk0JSluC CjsZ43RNgGDuXSqdEqhStvGKRw== X-Google-Smtp-Source: ABdhPJxVuaBy5Crg4238Rnf+mjDK9f2leKWDPf3f+mhW2AoCjVsaiScJhXB+4Y2JkeULZDYrLebEmA== X-Received: by 2002:a17:90a:e298:: with SMTP id d24mr10097975pjz.144.1619629466765; Wed, 28 Apr 2021 10:04:26 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:26 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 3/4] drm/i915: init panel orientation property Date: Thu, 29 Apr 2021 01:04:15 +0800 Message-Id: <20210428170416.1027484-3-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100427_965795_B3A6947B X-CRM114-Status: GOOD ( 10.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Creating the panel orientation property first since we separate the property creating and value setting. Signed-off-by: Hsin-Yi Wang Reported-by: kernel test robot --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/vlv_dsi.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index 9282978060b0..162fb3cf0f5a 100644 --- a/drivers/gpu/drm/i915/display/icl_dsi.c +++ b/drivers/gpu/drm/i915/display/icl_dsi.c @@ -1903,6 +1903,7 @@ static void icl_dsi_add_properties(struct intel_connector *connector) connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; + drm_connector_attach_scaling_mode_property(&connector->base); drm_connector_set_panel_orientation_with_quirk(&connector->base, intel_dsi_get_panel_orientation(connector), connector->panel.fixed_mode->hdisplay, diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index a5231ac3443a..f1d664e5abb2 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5263,6 +5263,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, intel_panel_setup_backlight(connector, pipe); if (fixed_mode) { + drm_connector_init_panel_orientation_property(connector); drm_connector_set_panel_orientation_with_quirk(connector, dev_priv->vbt.orientation, fixed_mode->hdisplay, fixed_mode->vdisplay); diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index 9bee99fe5495..853855482af1 100644 --- a/drivers/gpu/drm/i915/display/vlv_dsi.c +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c @@ -1632,6 +1632,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; + drm_connector_init_panel_orientation_property(&connector->base); drm_connector_set_panel_orientation_with_quirk( &connector->base, intel_dsi_get_panel_orientation(connector), From patchwork Wed Apr 28 17:04:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 12229793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D366EC433ED for ; Wed, 28 Apr 2021 17:05:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E7656143A for ; Wed, 28 Apr 2021 17:05:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7656143A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FiOUDYcMxMkt6CX8Q/opm5xcJ7TE7HqO4oHitrnBMl4=; b=giSLu1W7dG9zcvuu/pVQwc0Gb q0XXtze5BpUhoxq+a5pLSZPjKgxeNSybHTUuV9NMg4ttq8miZOxO+HbAG6T8tqoKjL1/KBS8dIVWX gjZLK0gCXzxC9TbIRZ/kUv4n0oML260+5KCF5nDFBd9sYd6Kmr6+48zHN1pQrY+qmxn9LV/jnkB6i iFVWjpip49GZfaQVoM5UsidnSw21LPIDc7EkJUa763lU84GRo0P+FWYB9FqzUhvqgG1vpYFsckdw5 IqtDoztLzHPJnCNfAwFTpRLoyibMiAz8TCJnLF3QzRWFmug/rQeOSg1navsdatEDeMQ9R91m2ruxS hudagiibA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbncZ-003xAq-Ae; Wed, 28 Apr 2021 17:05:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnc0-003x40-M1 for linux-mediatek@desiato.infradead.org; Wed, 28 Apr 2021 17:04:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=pH1fYJ9eOrVxKoj3cTp0RGQWq4 61CiK5DQxsbl3b88TcxLLrSUUmwudZ6D0Q9a074SvCdwhsLp8HGr9tu+507uHnLwe5wYYCgQOLmif lw14TVa4QyRpJu9kyRGIsb27zjhTkP+5SVezO5vy+9DBc4tbWmvTLK2tqt82HYMPXWB+yRrqM6gpd dncmnr/1ngqnH65g66nmt+jCPH/6Kjmqs2feJQrZv6w7cakmbdCK7l89DD3wsEqeT4GFJF/NW6ivA DrmiyUFNXR68ZX/txJrEM1TM6fEhMDDOuN11uIyx6+q/N66ikpM23Y2RYAYRHBnokG6/XBPMUlw0t 3yeFn9GQ==; Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnby-0002ue-8U for linux-mediatek@lists.infradead.org; Wed, 28 Apr 2021 17:04:31 +0000 Received: by mail-pg1-x534.google.com with SMTP id y32so45174147pga.11 for ; Wed, 28 Apr 2021 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=ZBABP32kAKUkL73RzLrs/VZTLUwl6tRRR4kreJjVivIQnqrLTx++PGkZdghCv6A51h i5wfgs4sj08UJWCJZAhmuB1UPJXH2+qBGrDT9VrYMuWAyEi9ipQ4WYYmOIrBtCW1JSTT xZT0g/d1wPha/HFRrZyfSi4R5Ae53TxzQP2kU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gt4pb5bT5mW/MToENIuo4Jt8VqUlSnyGRgKvmw6yKp0=; b=Q7DbCdxdP9NUrx5pxiMxDZ5+DH/mQfgPVLNskJqQzE8d/gpTuDTMhG2XA8YNlr8ZAd DoRpM9XCdUKVu/7YfWCxnEO4lkTRpbF64TwMBbuiAwQc3NZMQJhKHfDrcg+XaN1tc8H+ qahwwAbaNXyfQCk2Y/oTLTH8lhR+8PmB5bonarq03bU4iXZB++fSeGcfamzZPJO6m6jT 3CyyiiY+yLdYidKmMxmwrQ7P8CBCidc4Tt14uKX2kiHbC8yoEfve1myb1blXpBZ44+1v YLo6o4LakexNTBuUCeJG5SYqxTJaWAzeO+aal8/pcCae9naGuqn03gk67XOPMKJG804O q+Vg== X-Gm-Message-State: AOAM533RQD3gYfT9OcLDVYuBKHp+DuExZsaxYQ+UozqFxghZrghYrbsR sHolt+d09lAgNVQ0wA71SKBxmw== X-Google-Smtp-Source: ABdhPJxmrYhCyqvJ9YcpCKMIp11Js7eA8QUCI7vGyyUeKC4ER8oO8PiDoUeETkQrLQ/8pN+UBHWhJg== X-Received: by 2002:aa7:92cb:0:b029:1f1:542f:2b2b with SMTP id k11-20020aa792cb0000b02901f1542f2b2bmr28418795pfa.31.1619629469280; Wed, 28 Apr 2021 10:04:29 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:1faf:c32e:8742:d913]) by smtp.gmail.com with ESMTPSA id c8sm244351pfp.160.2021.04.28.10.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 10:04:28 -0700 (PDT) From: Hsin-Yi Wang To: dri-devel@lists.freedesktop.org Cc: Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 4/4] arm64: dts: mt8183: Add panel rotation Date: Thu, 29 Apr 2021 01:04:16 +0800 Message-Id: <20210428170416.1027484-4-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog In-Reply-To: <20210428170416.1027484-1-hsinyi@chromium.org> References: <20210428170416.1027484-1-hsinyi@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_100430_316102_B8FC8ED3 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index ff56bcfa3370..793cc9501337 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -263,6 +263,7 @@ panel: panel@0 { avee-supply = <&ppvarp_lcd>; pp1800-supply = <&pp1800_lcd>; backlight = <&backlight_lcd0>; + rotation = <270>; port { panel_in: endpoint { remote-endpoint = <&dsi_out>;