From patchwork Thu Apr 29 07:30:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230529 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640C3C433B4 for ; Thu, 29 Apr 2021 07:01:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3B0961405 for ; Thu, 29 Apr 2021 07:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3B0961405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FknsfjART1RYIYgLcVkcNulG8Gq0uqS3r/J/XjJ2PNU=; b=eqFhnFLnxgjvT68GX3Lio/ZNF 4rcIXQvPL9tHYQ8cf/I3vWgdfcfulfyOpe8KApf9JaIxdIapE8YxytBM7bRKMDtwLa/oo+es44PyL rsTRRH5CKbwS/nOGIimIgGdjYs+G2WwvLR8I4ouEzTqJiodV4dy57xtKFFCNHMDqCcLrVg1WIO2Ib XbjEfNEAORsTGpb81OisDjuQfKWX1qjKHN6onydxSaeI9t1FaA+ZhHsesWsAvbM00RVxKKIYEk+f3 kxuehlpTce+xvVHBlowadvux9Ocqey0aOAMrIaAh2ihdpoOYGQ4wK4pnkVdhcvmOwLU28lzyE+fG9 Msjftkw3Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0dz-0057RO-T0; Thu, 29 Apr 2021 06:59:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0dp-0057Q5-6H for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=0M2nSZgAEBwt4XdHnOocGRksY3hFRWrV85V4mkf3QPc=; b=Mxtqd1LKlfjghpTn/+YP4CY1Oe 8eUAUXcWIpN+kr2pKMnjZ/OAhFPoqUhVC/vPS3UfyTVMix8OgXMsYlZppUwznG/wjdTZTp/wCBkzR s1O6JX1+3zZx8morqSVd2i4SOM1uLzaIFjtKBnWrUOwlBc2UjceYAPegVP1/C0Zur6FFUgo/34KJl 6CSeIGJ2M60n1dIELv0P/snjvdl5pT+fCzBcDQCphXfa0ZFGi9C417INWrP/RuFbv0/zx8bGSopk4 saFYiI9915G5vSvo10YXmCtzzwDwvVGEKqGcpPtZlqS99qXAWA5r5PbXEE4i+APnelOBrCRU4EO4U JRZOsQpg==; Received: from mail-vi1eur05on2065.outbound.protection.outlook.com ([40.107.21.65] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0dm-000QGJ-P5 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DecZbwKf4oRRFA0Sxgjoz4Vby/Wz5HoRVIi1SIYhTzDq6n+X3IG6ziwznjCLVSDr+GbrTDImA41i1M7PWFbo6NHr4s+UZazFW96djWi807giwY0U8/Ab/4gD3c3XkMwtSuYM7AtoCSHamncw5iynIfHN1K05ww/PUU1t/gzq/0epibGOf+eErTwRQr3SaNyiyFLEKpFEaOdwz5EJc3cRwtOqCxxd4jc5XS5W/OJ94E2B/4co3oVlKf4Zu777zkchuf5q9wKNR9x5u9LMh5aTCJRbQPoJd73mdVSDtvNpVW/NNI12GDsa3RObZ7kM8ydpVp38JaTUOpbT/67QLowJxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0M2nSZgAEBwt4XdHnOocGRksY3hFRWrV85V4mkf3QPc=; b=NcpkTzKmHOWMZh7ovU17ivB4egM3569Uzu3d7Lh8jxDd9YbyePmOdyfoeSjJr46yrfgoUFhip+01LAx8xwbN1BY6WFlxUrte8sF/K87Z4SwlPL9TqkoyLVUCyNRVefj92qMXbxG/D0Lw57hAW2Nwkmzj9gq89enoB+Gt3VAJI/iKwUZOC/upmQIFJl+ldykYIHfzhUh/nCOFS487gnqm0GxUve/duFta9bn6SLzxp+rdO7UJEGlIKjQt95+3yKrff35aI+qWdfx3ajJJ7poUNbv0vbiGNOvk5lUjY8yugQ9ygjmIRqwvbaEDxlnWJKT18cb6DdHQItHo3I1hdhBa3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0M2nSZgAEBwt4XdHnOocGRksY3hFRWrV85V4mkf3QPc=; b=ZxDdxttbcAInHCe6kOtNa57HN6j6nJmjBkEWpfJXXjsjgopwackQy4m3Oa9mRML8E/93AUzIV0HrF1aWE97ysDJN8098VeAowdz6LMmbx7YbKCQ9ewihb9g4sakayWSV2f5fgTFtuOeDDF+jBXm02HJ/v+aHEx0eATzrzBaOeFQ= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:10 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:10 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 01/16] soc: imx: gpcv2: move to more ideomatic error handling in probe Date: Thu, 29 Apr 2021 15:30:35 +0800 Message-Id: <20210429073050.21039-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cbd03d9-b45e-438a-90f8-08d90adc4a33 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xo4fOsQYv68abhzfTfP5TOPCcPG9ERq3QlExxZ7G00ZDdsetMR9VyhsL5oBn3DvR7PeQO35YSDbnZbSlh4aCNMqfAKdI/QMQFdVNWVvU4tl6eR9b1553/90eVQW0fZSa+iqRCIS76rQHP5vwBYYgnPucsnfEQ/EYZHFep4HTg1wTO+YKiQdSTRve3cic+xzFSHHzEEvpOtDEQM/O2ppioWbW/AULtlwa4tCo++cSndfRKjtFLLji1JrdvQWFdLWbEUWyW3EUeYEQ81boIlU2KqzDWhTj7Of4aYagD+vWwaOO+aQN+uwnXo8tptr2odhd2BdNCaQfyy56dUhqOZpFwI/7+6mo7CxBTGv5W4V/APyDMtKSe1oTHJumUWetGxnJjt6MRuoLd9e0Sep3bJ+1WQOt++Y1iXxzuJGk1ifPjVkpUMGj+JPzrFtWQDXE2xC4wAPTKz/hWH20PLB7LpMrY8ExXH2DiBwEw57cmDITb+sRZTXcQ426t974ULdwrSUjzeHwOM72QkdE8PtQZg/msfGmUt3QBogEBbwzu+r90EkWAVgD8X4DlN7RwnsoekbSKw+y1R2reK+rupnfSIIdTFzs1OkoPNpdR8qewlC37Ann2k1vsS46p9JEzaxrRz11QZjSX1anojQb4hVuxCfShEy77o/1EOdYNAdL5CMdjaA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: xjXZj7TuCCA5FVG6Adc3g0Gk4Sv4MPuAMHKWVRRDLD+/2cbrByzfKGQP/rIlnUHk+wbgh1wnrE9fWzAZAJFIY1pPFTrlGxVh/HgYvQsQi2TunQC/kWaeZjUwBDizoWRR2R1YGYRSFiqN9c/8Z4IfNOuYSj1m7x8m4t+uIWWFWAquupcW2ePVTgvKXQ5GrjFUSZlejJN896ztUJQrZaBRZiTIN3JvLfoLjZlGCPUXMQ8fv+PuYrpne0VLuoxclB3DRnkfcBIS2Tu6McQPCH/hXzkVfGDGeJfRKEIumBrUK+iFRh8286M27TbCZIRyKQn/oEzWcG846/FDn9wbRSi0Oi+rwIEKpBiSAN5sUEFi5R6jwtEphTBzRX2DqGfXxKYYFzEeLW57SSPXmkp4me7LzxP9mpVHdVNjMfIzpanfXWwrdhnbDvL3PsplPjtAvQASJmWk2WQIdllsrY5YEqQhC4i4mb4kixbYpqaAGssZYQ2FjKskLwZk5A7/4QbzeJeK/RQwpEwvMH7XOb6fOaUNxoe/TUi4opAtmvDi+MSU6HU1N2tP2LjUqgPCBSaNVepb/4QSUSO8OWlou7aD4HbHdrGKWflFX+lPU6LTpiflMjQNPGIWV4JfW0sBzLfRflVmzfyBP4EaBbti0kr5dDC6/tAWKus5BLsae6pjTIrMKh1idl7I6g4KFQUG7U17oFOtqFVScwCrzi/bfVbocIWRi+XJ51Ku3rXmNFBkeeJSYkf5TiZtJgXeP1lKy1uCvJ7ZaD+pUkJEJm3kixPR+Wb3hRWJ8OmiaTrQ5Zz3gLN3ojsv4+fUcLoREtMZfhGYUZK/pZjOiiBA9LiZLpewlLjzfa2hb0v9rFXi9YhcKvwg2zuAwhG4dQsPTpCV0r23AKW2dQ+0Fepn0u7nsoGpUCs3ZEdcFEwSNa+DPMQzZKEaayARVuQBMSJTGn0fQGtVj8BhRZYq8lyUsjACXmS1nHwKAEFPWRiE9P8Suy5wcTJVYGws76WWeFQ3rYL5eRM6UUexZuIb+54CyfROJAcbJD/km9imvAoUDHeJYzMQv/cveblUv3n7YkhB6a0rrHOXUngVVgcFPOVcKQh8RdKiY3XmsiV0lQVhfqRA+KQapO0fgTcM/mMiqvUvpb+TQx/kcge6oFv55EjgHEnjjh0NGr1BVH9s3rqs3cuC3BQZ4w59Q8DErtP0SuJPfXXnEH4nlxxmgSHwbuoMZTVbotwmselNxPMHg5dvAWkzFgYyWUXRY9kZq2o2nrTWLQ6tg9nFb7a+1g5RDah4fVWhpv48Trg9xRmu+Dr1+Gq8PIsdROYtqW7adkHYDd16BiU8/5InDQ0F X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbd03d9-b45e-438a-90f8-08d90adc4a33 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:10.7560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UT5wIPx60TxOSb1Orqm9sCb6waIFSpvP7TkAe7hgImHFByvqzv/Zl/gRxAs+AO2X0ajbZwv5h1v7h09Kk3Xzog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235914_839958_3C0223C8 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Switch to "goto out..." error handling in domain driver probe to avoid repeating all the error paths. Signed-off-by: Lucas Stach Reviewed-by: Marek Vasut Tested-by: Adam Ford Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index db7e7fc321b1..512e6f4acafd 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -502,18 +502,23 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { dev_err(domain->dev, "Failed to init power domain\n"); - imx_pgc_put_clocks(domain); - return ret; + goto out_put_clocks; } ret = of_genpd_add_provider_simple(domain->dev->of_node, &domain->genpd); if (ret) { dev_err(domain->dev, "Failed to add genpd provider\n"); - pm_genpd_remove(&domain->genpd); - imx_pgc_put_clocks(domain); + goto out_genpd_remove; } + return 0; + +out_genpd_remove: + pm_genpd_remove(&domain->genpd); +out_put_clocks: + imx_pgc_put_clocks(domain); + return ret; } From patchwork Thu Apr 29 07:30:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7B2C43461 for ; Thu, 29 Apr 2021 07:01:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1A996147D for ; Thu, 29 Apr 2021 07:01:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1A996147D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zHCLCLdRF9F1hxcQuNKmSimQaj9hBp8RNlvBepT2Lt0=; b=YB73ShWzmVWfOHgs6reOd3iPZ sIHHylz4QHQxgPMjHvLhucYyULX18C/Ov23Z0WC00NueskAbbpr6ohlFxgakBefc2BS38uUjtk0Dh qH7H668r5Gx4a2gEJt9Fh4Ro4ZJR2jAnANPAzW6Gl7d58hEKzYEu/lSw+UGXLACF5Q3TXUrEz2h0L BV68H2T/WPyWAqjhpG5FEm6coSf3S17DMv9Nm5/zpdA9JJgFk3f6ox5jSdafwekcMaXMSlh7ltgur cAgpSjQo2h5kYzzM9pvz6UsUeODG5uXNQjPpNJ2P7DkHcRyLDsyYyQM0pVv7kIDIDgJI9SedtHFaD k5a6siq4g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eC-0057TI-Tz; Thu, 29 Apr 2021 06:59:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0dx-0057Qp-29 for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=kC7LQN2bjLXeLZ/WIeQhj39T2YZ0qC/FFSLx4nhi2E8=; b=U6CPMMC69IuWmA0FH5/wyFFy3k hZV2jzARnXDYT5j21YV89+IVxipKyuXtun9lA7ubs+jf4pr0wH2bYkuwAqryKUq4x0z797F2jgLSr g5EcNeJcsPqST5E5pYvpwBbQnIIq3lItKlnVfm9Y5ZvsdmukTaCeezVlDSVDxvSS7800pXOrAiHj8 u2uTzE3DXTcT5o4Cf72h+09U9i1oke3RiefTE9sSkiaYFkKsv8Y4DMP17CZ4bM8PGxokM2ImQywcz 2zar2wZ4XYBxVGhUS4noBEZiYuwLbAj0UigOKEyVyJ36DYoPBf3datCud1oDR7sOseZ43xYXhzYIy 7Zw9gLyQ==; Received: from mail-vi1eur05on2073.outbound.protection.outlook.com ([40.107.21.73] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0du-000QHK-64 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MDFOMtaaeL9/YIUC/qkFfLD+E6wy4UThoqQ237Dog/hF/EHwaob6bDa+e+pnkNAnf/h34Szi/n4EUCMM8HoS8QJiOAYMhalYs0GN2jsz+VSzeDAk5gbbEAtHTVrILyO1A9HSsSaUvt6iE0LZJZ24iPzg8WBQh1Cf7hzUKycDpwyblUqdp4/zhTJSXGOsRORfaiarfm5fjdDYN9vRzIgkAKquqftdrZ1l1spN636pBUCjjmBKpUbrempfOCG8ku8JtB2JrXiMNnuintu77OLOWQjE2Fo7jbC6ajow+0l/LrpzeDYvOEIQfT1BkT6JsqS/FssLdrGBpy8VQgM9IPdERg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kC7LQN2bjLXeLZ/WIeQhj39T2YZ0qC/FFSLx4nhi2E8=; b=fm0wvmRjRG824sKSBWf0G/1GWBYKqoiDZRDEFKw9Qf55hR8mDcMpbz8s7CsVmfpbFy4eXRLvyOq+d0Tr91z/3QaAeE/EH5H2mPooq0c7CfTT2oiDeir9DwzXerOCx3ecdYJDvjc4KPUL5L+GflRhVFbBxgjDykyk0/R2ZjgFdXrZGWsF/pvisqYlC42tKHpH+GNnFIJtOAfVojdAfC1sXLOuQx161F5L5XaBciQe6h9wk2VutfPcFwkR01lgTjwaOmjXMh3ruvt4zsuT4J6RP6ovJt4U5dBWc2ZNV9jlHGzdlh83A1TycGPuucA5s+W/+yD8SD6rCzXj0mZUIZiAKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kC7LQN2bjLXeLZ/WIeQhj39T2YZ0qC/FFSLx4nhi2E8=; b=QsCrpsmRRVOQBztm4hkT+95WEJ1tdfHvYBrZnmhYJppOwjqhbruJvYeX5z94gpouRmVE37t7XQyNTc+ylGNT/Qv0TE7swRqq35B4cTghZZSrrqPcCQenJsthR5OBd685y6jGwqz58Lp0+lr+xrSvehKfztb7rwN8rtgDIbL4KYY= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:16 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:16 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 02/16] soc: imx: gpcv2: move domain mapping to domain driver probe Date: Thu, 29 Apr 2021 15:30:36 +0800 Message-Id: <20210429073050.21039-3-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e27b32e6-f0c7-47b0-c88e-08d90adc4dba X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MzL+sOZzVd8rsM34Tc+ZK30jA2QJyvOWvfE/Pb2MuSdkLomEI+bt9SpTYkGcaBpaMo7FLLpZQrHOMoWi83wKqu8GglM1No9zV7ToS/7DxfWi3Kj0f8Spue2CWNwyuftHpFeDIBpiiWZ/3wz72N3PdIKmBSpeXFpMdnMt9FiS9O/gmSwVh5vWjusstv8sNIgEDYJU3v1viALMlRk+3NAMnr96dJbCNykNl9/kiWDyBsKC0DTN9Pu/rcT5KqVyAB1yjWteTOZ8Ucl1GEJ7U8l/s5k4YaE6OJedneQpQdhCDx/CELaZcjOTkiyHgUGLW+nfR/sbccgYuqXOXO6+QkPtU/euhYwIcS/qx7V3jI1kE1rWW+EuqXwrLfLiIa1AFR4tQfqFq2PwmC36GrJIf/QqJ3fWabrSvHhfR2nSwnTeL2aDXcbnKO49s7SRlzSZoz/dTVM2a4ldNv+/ynOBiwJ+rQ2LhUi7CQECwOscdRT0yW1t6C0cMFcAED22LSib8ed5wxoG8Iqz8QJKPqnhLHO7l9bFNT2IYnMOx/nvSmK0qqSA3kO02bKcr4JaP88GXWSyazBpcsxmL9FgTY0058mZIhgGnVrWBSK13rroVQUc88pzBkCkqkegyNGLKTf9E4fg6d2NWBiFhlnr1NZOh++iS6ZhA+Mum0+Cgb6bjp1aSos= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: wf8uYUp+16dinba1F7uA/de6g2OxXID+S7PgNXX+qKy+oY3ePf0qk1xYlfzqSrYJJaDU4kPlGBur+qHOPJyc9TiI8HW2huHuFpsZOyY7srVUc0zJMbb84/d/VSo3Gix+vXpcKfR2K0xKQUoE1BTLbLbwMy/mF7T78PxCT+ddcvj49r23wSoLZVUJkOK68SqFBtlKlD6/avF5H7G8oqhpHxKcmKndiNTNaPOGtzlN1ZAF6M52sGObaZsOOMR1O1ZqO10BJNvxdOrDtEHGUK/gkOvRuD5yWCsQgi6J4ZDG1KvE3ymqb6tUHQCvAIlulSqKLSBAHP9kqluKVsHLwNeER+EX02s8dDBKO/ZRsCejNjTjscyV8kaKQ+zGoGUbUblnYAAwPUayPjBenCMZLpK+DDcF/WjrHJFm+5gEDoiXPH2aASS8fIQVBf1HXPyjix0q2p+X0w+0uerhihBMvahnK7PpBl+F3JVWnHmsMLedNifu1UQPQqi0Woz0Tnl/SrvUJZ3GzgbHAWNWOZxc9WNrC/w8OoYxfq+WI15PQCBiG5+yRQXQ0R2xc7DDGke6WiAHut/Sjw/Kmg4WssgvB4+9d7UYIecmooRy52bPg7Fg3hfh1pD4FJMP2nLI0oTFH1pn/ZGabocQN9ATtr/AYHIWs1AGaaNbfG1lDcdoHwAPRn7Fb4YnQr8vN8eODfQsIxEVwXFxrWtY44bdJeKLOrbZwHwn9UEJRQcrSqOszNf+yi8wumlAWAgyEzmB9BGMqRbIPRC4TzLZ9QWhyrVJUVCzSvHlM07cukAwMc9sKMLZTxGylEkeLoqdiO+5vIQvb/0uUCVaIqQutAQdZ5/00Ysh7R9vlvnLIgBtatwg/SX/g51JWvJfvLXrJnw7HjO4nroWW2NUSBB3oKgx8lz36WNnrDSXBc2WSeff60Oo3BHuBNDoiMVD8ePF0+TC5epOTgIE+4ezt6mE29WBXQglpF9X6iiqhvEqr2ueq84p34+5D+S4ypCLfdkQlUmripvwBEBn6lgmZfiQBohR9jEZ7hKQsML34LZRMw2VCX/pMfpmD0kumnmvcgo6XsXCEHVrJHsXaU0cMlRx5J1EwaOVAVzYYoROd4fwEyZmarvOPf6yPU8XPWqjahxbDfuQa2JejsUM/pKnD6DlZQXnJ+pdyU89l5FOLL7oUnhc0T7obU4YhnzhdYHuZDQap1yzkMfToSIl991tc87FwFmVKS8RoyeHw+0kSo5JWhHeYx0+QQfLUcq2rZ5FckII+Sh9crXA4SEDVmQ7JUgAXAGHpASICfgSFyRROCqtagi5bTn4d8wj165FSLDHsmNaaL2Bkv9GhpIz X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e27b32e6-f0c7-47b0-c88e-08d90adc4dba X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:16.4924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1XoSYUklCoPK1UtCbqho9pLmdHTMFpyyz4LpOYqeMb1w8Olb0eTTpqRrRmkUiNYx7aSiKsftbCmVTLtIQ3Y7ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235922_252077_6BDE658C X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach As long as the power domain driver is active we want power control over the domain (which is what the mapping bit requests), so there is no point in whacking it for every power control action, simply set the bit in driver probe and clear it when the driver is removed. Signed-off-by: Lucas Stach Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 512e6f4acafd..552d3e6bee52 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -140,14 +140,11 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, int i, ret = 0; u32 pxx_req; - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, domain->bits.map); - if (has_regulator && on) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); - goto unmap; + return ret; } } @@ -203,9 +200,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, /* Preserve earlier error code */ ret = ret ?: err; } -unmap: - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + return ret; } @@ -499,10 +494,13 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) if (ret) return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n"); + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, domain->bits.map); + ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { dev_err(domain->dev, "Failed to init power domain\n"); - goto out_put_clocks; + goto out_domain_unmap; } ret = of_genpd_add_provider_simple(domain->dev->of_node, @@ -516,7 +514,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_genpd_remove: pm_genpd_remove(&domain->genpd); -out_put_clocks: +out_domain_unmap: + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); imx_pgc_put_clocks(domain); return ret; @@ -528,6 +528,10 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) of_genpd_del_provider(domain->dev->of_node); pm_genpd_remove(&domain->genpd); + + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); + imx_pgc_put_clocks(domain); return 0; From patchwork Thu Apr 29 07:30:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230533 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088C8C433ED for ; Thu, 29 Apr 2021 07:01:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 573C360241 for ; Thu, 29 Apr 2021 07:01:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573C360241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ouoqBrTtGabo8caziGknoe6YyYlTCfZnjrDQyNQtDpE=; b=NF20LMWJU3/puJwZHFJeTUzDV /VGMAjj4wJlc9w2nQ6IAL8TdmsJnXA3Xh6FIaQwMAQDwrO42nOddLRXiMTygdz7/yuocHGgrhUY6R XPouxi/yT3uVwPW7+Lwq8Zbll8WGkenIQdZn7i1/y5DG3wkhufqEyRZ6vSZoqX6xteknam4FJa4ab Dve4lsXzIpy3S5fNdCOdTmPPvFRdHYulCV/7tzV8uOPUA1yqI60SIUWG+6pbibZFivkAnePJQGj1d Bp1LMzHUJmkngW+FTo6KEl5r3E50BJtn7fD6W7WN1f1T/Q5F4m8D92vQdbprbYd1C8kDNE8hL5+i1 lIj1BWS4A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eP-0057VK-3u; Thu, 29 Apr 2021 06:59:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0e2-0057Rk-Ae for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=AXRynR0ZkCJS3uf+R1SbVjZzRK5OghHX49NejId9ItU=; b=aldulAwGyIR0+x3vq4K4yeOgd0 c7hOwYWDOja3Ul7vMOsLlM9zhR5khtWlUDyEw3EVmVHFjwAlNA630vmGqnnCdDecedGqqVWjXECoi f52lbO1nZVOupH7drkf4n+oFWkPxGHVBKzcJ7SJiDci67Xi9ZYcknet9no5iJ+C6NHVfTKqByyjS7 +4gTX8XOqPmyumQ1GVI6cgugaO5NsbZTXoG/a0MhcS1KaMxA/ueXKgwTD+FANb6WwAgJntQVOvvDB w1NPGxUxa099hZNWKWndrE5lKmgJlgEhBejGKB7lJMG5jT7b6+2xX+bCrjqRMj8a6gubd5VTKtvjw Dm8zNh8w==; Received: from mail-eopbgr30055.outbound.protection.outlook.com ([40.107.3.55] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0dz-000QHp-Ko for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrxCHZBWD2YvHnpIiaX/V9krcRgtt1ulZX8m+mJHRJHnCtBgQ1n/srR8g3dR+CoE3To44GJeQDpo6kvGCKqedppx6Zr75wOEpbX8qdlbBQZJZWYJItk5/uaET57R3Zs/hu+5s14W8UbikfNH0d2Q040XSqhXqJ4JNSOhXtpSzjYovvAory9rHo1wbGtsQvba62ufQG2773p228C7PYqDvxdTSwLtvUDrTWzo8/0JVnorBuO33wBjyzfqf3HIQ32AakYU/wQl0x2gpu3SIGsE0nrUWLwHJs7YfT+FrKi6it6xFeM3CTG4g/GPRSl8ITWoqnxo0R9DvJZfXcC1TARhYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXRynR0ZkCJS3uf+R1SbVjZzRK5OghHX49NejId9ItU=; b=Xj4bOkrnlPKX9FwTWkotmhXYmZK0dJ9bnDs+qi8N9ZS4P8FUEdeoPXbjiEg6PVI6YJBTD7uNt/XQUttMX+0de2YL/9/UwWxGjm0F7bKQFRrKhKMRY8VVVOj+tS1OssrasS11uEqKvxHvEgufciwQEqDjA5nWrHtMEv9V/czd1f0Tf7ucM4T63qWIS0+qvttkDS9oGtts4Punu85qjt31w2bF7PYZLO/iGHMlRLAAn26ikwfNVqoPpQOcm9Kw4mRAFHgvssi95VfPg0hHXQu46Dbj76tXgw7DJGuidbxauBxQkG+QFl54+xzft0KGcp2o9qBSqceKep/ThqeaxCaK8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXRynR0ZkCJS3uf+R1SbVjZzRK5OghHX49NejId9ItU=; b=Ge74s5JH1xn1Z+nZVv8NJrkOa8gdJP7LlGWUQfKAfIs2p9jpIkmDPAMZlHGY8qrRWwdgpc4XryWRj33yVBXQarEeG+LAc37npfxJlW5Yrgu8D0FfkdDoKNWbKLGJ4OO8ZtMmUv8z+MFYhokye/aGeuLBW0KgNy/WZ2CQ+DhmqJ0= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:22 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:22 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 03/16] soc: imx: gpcv2: switch to clk_bulk_* API Date: Thu, 29 Apr 2021 15:30:37 +0800 Message-Id: <20210429073050.21039-4-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c9f3664-64a7-419b-eb78-08d90adc5127 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pMhBC/0K0xKjtpFKyI9RO+6VI9LIOowMTgY3f+y8+p0TERFw/1lrudiFcUlPb+vpqO8VXfyayOA2i9yqSB5P+AMsQuKC1+4N2ozK3IbHW6rajw3iQL5CgswLAWW92FcR8wAUp1FNsvhF4BIzKQq6s2LJAe4zOUQtfGIqCv63gcmI2NOeoU9oBL3w4JnGhuL7IQHQOjkT0if7tNfslp6z11imB/i1n3Lft+J/Iv7VoxDTa+Icqy5mKarM4FrrVaR6qJJuXKx743HSM/vCAeWQ/odg3a2eWBeyE9gq7Pe7SNJzMdr2CmUDjRKaXqwdj/qhm1AliWl2mSJbRNzT8Pesq/LLliWVyu3JCW3kbRStq08bRw88YCPWE0Z3gIzP9HwYH4jT3JrSyejQIccjEs4Bb6IyMZy5SDRMknjZZ+xzDvBno3kaBOoO38Nud8eWPoq3Ss0w3fu9ujtE/4tqNnqVFesI1AtqjHSWwilZZ3F2alz22Ml5df6G+b1UCPHVEfXnJdlrCnmZOBopp1m7chSw13XsV68k9kkRf1iRSjApX260jeM13QKrXauTjOfPuJ66233l0GmV5tF0IvJY7NZxpLZX8R7MwVWV2sNAG9BALZB21dUVrezMPHjZw/XMrxfsh21VQhBSo1pZo9jV9crCkZ30IxLirIGHCcbZfU9Vzo0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: CS20eYbjbqwD4fgF9q11VJjtaZ95tBf9651S36r2UdKV3HGIi/rIiFVNGtlCc21/YHqHZpItvlrttGKRcppfJ7tEzVWn8NLFR6ordcpFQFbiIWpOVqKL2AtgTJ4dOJOFZoWwx+OxQtACoEXxIy9CjH3zai0rZMn9XFBUvQVx7rZ6pZKQ3146uUwFG+p7sFKrs5kKjNy1FMIklkIQf33sXcL1g9/Z0SQaY5qX9mH2UMs9zX7uSzQ96JA6tzfkS/x7Vr3fl47Els0iHr4tNDbZUA2F4cZzUnuyBjWe0SOXk8MfFdvfFG3NLEOI0BHzJ6AI4O8Zn58QkzAva8eyatTAFILFBgP2jpnUEqfxZJz7bSr70cnOsJfKoIluedtBtz1S3jvza2FImvNIctvmpqaXOLL6oD7b4MsFoDWHwaokk1yehTMCxiHv1+ehumRI7enuJxvPtRhLOxh4T3BA9H1kRu+WoU3tL1d9UoksFiJpzAWxdtO9A9lHgaUJQqP399tW04uX7RjKPxbJRBW8jQLFRKuR24qYIn1hJLsxBx5K9Qg9xPpfc/5ZJ4FGdgbpXin2s8OaO6spimHGDkL38rlMEbeKlt2YRrxuqW4QkBevMMmCSjUHCuiGDPzk0ol1KALng3Onlq9yMvuEODtGLLNq4IP3nlb8yVCnCJ92EfG/zS9NCDkxrKLfja2ugKGCPuwMttd2niRWZwZCaj0uiMj+DVGEYdlFU4B4e9ERqPvD+cobrn2+kIBHXqYdIA8R2IHguldcGZCN9VBh4RTBxZWD3vOh4KrAjCew72MKkq0xr+lk5X9iHVU248137AHWeAKVnLpuHuTMmxYoUsWiUREfJGvI4bxgt9dEhtWPB+T9GPLORwFIco2Pib3s6ttbcSmYjX3mUevdREs8X96qDGd48mZrJj9ed+zMx4SIkf7FI6fsXlsNslXqEv3P8uYUWs/EePTt1/mUTAs5OHMpcJRnP+8VHWxnN1F+mQ6dTfGnRX8VFTxYT8OqfHZYQwneJ9VER1my7zO+d/rdkxGV+U7juqqaQD00B5Z7yqF+EON1+7YnUlHhwoV9cgHUDF7qBfLxJkluQazTxs+beFrF0lhy/zRQnK7qweHdtZBCH4lrwRUdNlnwPyvsMZUNPRwRN3gRCm2KSGjQxbAUV2XhTkqIaGbGdIS/TIZfZfOSdXp3iN2gSUwTmbAshP0VWka3yR1XwIn/0qUGkOtSolet+Yxgu5cagX6vhaOIjbkxFPFd1/+OmSBbREsX1/PTpR1SYyAlTUr1xYa1Pn4y72VyV+FbAnxYX4B+faUM/ZJs3pBibrISbtrAb63oVIN9XL2eMHIl X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c9f3664-64a7-419b-eb78-08d90adc5127 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:22.2378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DCbP9QzSbFUUB6HYKED957OAfG1CifW0aBfUWvaz/nCHYJ1gomTBA7P2qMUNx50ai6PUrwza1EVjxi7WTvpOwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235927_710220_DCE00658 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Use clk_bulk API to simplify the code a bit. Also add some error checking to the clk_prepare_enable calls. Signed-off-by: Lucas Stach --- drivers/soc/imx/gpcv2.c | 60 +++++++++-------------------------------- 1 file changed, 12 insertions(+), 48 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 552d3e6bee52..1d90c7802972 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -100,13 +100,11 @@ #define GPC_PGC_CTRL_PCR BIT(0) -#define GPC_CLK_MAX 6 - struct imx_pgc_domain { struct generic_pm_domain genpd; struct regmap *regmap; struct regulator *regulator; - struct clk *clk[GPC_CLK_MAX]; + struct clk_bulk_data *clks; int num_clks; unsigned int pgc; @@ -149,8 +147,12 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, } /* Enable reset clocks for all devices in the domain */ - for (i = 0; i < domain->num_clks; i++) - clk_prepare_enable(domain->clk[i]); + clk_bulk_prepare_enable(domain->num_clks, domain->clks); + if (ret) { + dev_err(domain->dev, "failed to enable reset clocks\n"); + regulator_disable(domain->regulator); + return ret; + } if (enable_power_control) regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), @@ -187,8 +189,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, GPC_PGC_CTRL_PCR, 0); /* Disable reset clocks for all devices in the domain */ - for (i = 0; i < domain->num_clks; i++) - clk_disable_unprepare(domain->clk[i]); + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); if (has_regulator && !on) { int err; @@ -438,41 +439,6 @@ static const struct imx_pgc_domain_data imx8m_pgc_domain_data = { .reg_access_table = &imx8m_access_table, }; -static int imx_pgc_get_clocks(struct imx_pgc_domain *domain) -{ - int i, ret; - - for (i = 0; ; i++) { - struct clk *clk = of_clk_get(domain->dev->of_node, i); - if (IS_ERR(clk)) - break; - if (i >= GPC_CLK_MAX) { - dev_err(domain->dev, "more than %d clocks\n", - GPC_CLK_MAX); - ret = -EINVAL; - goto clk_err; - } - domain->clk[i] = clk; - } - domain->num_clks = i; - - return 0; - -clk_err: - while (i--) - clk_put(domain->clk[i]); - - return ret; -} - -static void imx_pgc_put_clocks(struct imx_pgc_domain *domain) -{ - int i; - - for (i = domain->num_clks - 1; i >= 0; i--) - clk_put(domain->clk[i]); -} - static int imx_pgc_domain_probe(struct platform_device *pdev) { struct imx_pgc_domain *domain = pdev->dev.platform_data; @@ -490,9 +456,10 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) domain->voltage, domain->voltage); } - ret = imx_pgc_get_clocks(domain); - if (ret) - return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n"); + domain->num_clks = devm_clk_bulk_get_all(domain->dev, &domain->clks); + if (domain->num_clks < 0) + return dev_err_probe(domain->dev, domain->num_clks, + "Failed to get domain's clocks\n"); regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, domain->bits.map); @@ -517,7 +484,6 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_domain_unmap: regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); - imx_pgc_put_clocks(domain); return ret; } @@ -532,8 +498,6 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); - imx_pgc_put_clocks(domain); - return 0; } From patchwork Thu Apr 29 07:30:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271E5C433B4 for ; Thu, 29 Apr 2021 07:02:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CAAA60241 for ; Thu, 29 Apr 2021 07:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CAAA60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jfuJF1nojeqVjI9TD68pbUNKbiuFuCAWMjm1aBynebA=; b=SzTNlKqq0EpguS0QMjyISp5cn OuqJ9sK8Sp6cQLyDjrFcPHXxJdCi4HW3B0Om1CRBQBfzOhdbduEWTF91pB1PBHTymz69MwOkIvsJe KxDr0xSmptkyWpoIfv64IUpbg/fO7aXGou8JBzQVNOR4rdbb4TMUiasVavXDUjeIonSGB1df/tVlJ LyCVqlLT3GksDFbXf5lRKVpPyzATvYNvzEJ7jUMVlIUCORYutSHrd13H9F5GXzVBmITn9YgVBxD61 OsSvnXv7u1HyqDrTBq5i4W5HKjLZrdoA7Y+4yS27Z8e+sr8nw44d92skc+8EqIY8cWKC5WlSi8nHO HZgfUtdkg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eh-0057ZD-Vp; Thu, 29 Apr 2021 07:00:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0e8-0057SR-MT for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=duAT+h6+K34OrS2YoobRV3NiUsMl6gpVVhRrTmffbUQ=; b=5A0SlgpdEv4sMH/f6B8bHPnqMi /VcWx/f2DB0eDUTv4V+uhcBkHp0IqkEly/3hUJpROt02oNSBlhgYH09W4B5fqqBf3nOBbGtvjvkJJ gS3o2nJb4ZU4qt2+GXuQTAanwl0zr/W6ujXTFQUhxa3pW7BLgqo/1cUp4fguYFiqunbNzGHbSDBSx JC6xn8LIxA9mZhd1thFkhlAFdlPuCoibd6MDL62+Jr1f7fAly4gb+5DdErv2FsD9RLSPUh/MV8MQ7 voTeUhJ1HTq8OnbmDKjTq+dHXnqV2umdUy6jA2Z90fiKFMzAFTCA/WUbUOq5rlhOEbaUQWXGYIyg6 hIDp7Lxg==; Received: from mail-vi1eur05on2078.outbound.protection.outlook.com ([40.107.21.78] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0e5-000QI9-OB for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLXIJ05KmzAmcuM6ioK5tL8vA4M8Imt5z3t26a65po1a/jKpQ2dfWdyRWM105nScmMzx6VqfpYmvX127IiEY/8nS532+ZQqEit/ev586ktKIRpR/SGRgAlefc6UFJvVYNEXYZOejCgThW3k37Fif+d9tUoye7OzO7DXrXsRWX6EOZL8n5uCDGaprb5TTebAuv4NSwUbTULZ7DsyEIMY6yvEGMbw2ZQ56xJawpgfUdQ+tkPKHIFOm9xNnCWCwPVxlWAf6d531ATRvGEuP6QpxvyGMFOn7BB6q+V+JG+m1r616UOJ8ZEif32W7PIwoDl3ecJVLVGQVgmWjjsGzeUpYzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duAT+h6+K34OrS2YoobRV3NiUsMl6gpVVhRrTmffbUQ=; b=ID6OxoOU1rAVG6HMpDhi1MtOEGyf1MYETK3JmeBXD+SFHM1TWT/viY1ipY75j5ExutXLC+O0YhfMO7/snWTjR0ErSKhHbHlOjAEKTA6w8u++1dDTK1JGYpIlrWTPP/n73t8Bt0GsWlzueHdyVkUrgOAsdLaPuqgHP+eRFb+nm8xKt4IU0CocRV5qe1QUJhTYxwiHiPl8UHPsadFG8tEPZc7hWORReHawYB/HbP3/DA7b/uFK2/LgrYOU/Eg5EUC1vJJHDI8VFOuCuSDwMBACU5RQ47mWZegRHHrHZZ8nE8L1djBeCmWDyQI864SRF93GvUu160c2IqcyERIqp0iYWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duAT+h6+K34OrS2YoobRV3NiUsMl6gpVVhRrTmffbUQ=; b=TYjjJa2d7mlWFEnWnYLzw9aT7jZVDU8Z8EwZZuWBKuddQiBj+yIfK0lb9YlDXQtAN4qv5retbYTOuw3oorxeapuWl3NZGayHbQ8u1gYmbQOx55F6OIbv2Q7C2UvFwFhwoc9HzCMvpXPZv5ohPSPsTWZ72bDiMdD9S84t2Bow5NU= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:28 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:28 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 04/16] soc: imx: gpcv2: split power up and power down sequence control Date: Thu, 29 Apr 2021 15:30:38 +0800 Message-Id: <20210429073050.21039-5-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbd82a56-2980-4646-906a-08d90adc5498 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pu01Q47KtAVGm3nqUyMeXo2ObgnYnQkKBnXwkBsPGvkQnYLG/g5Q8vAokRcJ9LRb/3Bze3i69Pdd/8bG+zOLK7C5hPAqy+TcmEYDFANKalJdm/QTZGBrzhvGrLCuEQg/2Q/JmU83D55H86Ja/9bKh5Fbqr1jho5/sSsCqNlCnYA8Nabqxs+rotDmwaUqqGnXpHHmq/xZjbSEdzph1QZR73WuveeBLTEhqLe62WbZo9hHzsiB8DiAs+0OCIjwWCoIBgA/yyu6y7n3qUN+IotJuIxBzOGPIuHExKfgs2JF0W7lwDV2J1hbwlilCZDyvIG9ZAQznRt0IWVG6OJwKd8iiGeWNgNgKamkGinXzAVr+dSnRfRAaYa2RUpiG1T2RzAzpUmnwuSTiO6G53+4YPQps7alQJDaDVDHGICc1xueL83Is4i+gu5sMAp/JL67Dt3HOu0hZcgZUQbTupw8F0DsTTZIvXQ7FaziQ/5MizWia6P3Hm0BqgqgBXuKjwVJ/OTfRNb6YgswNg49Vsfl0Q29x2eNqOa/5RqjZF/4LxLpsHTOwTcu5SkOpge9CG58rsTI4tVZbS08XsSQuC9i1H6e/IYyFp/Eqzd+rmP9VO1jdx1aYakm+IdQoEMPaMjhkcpLkKqnzbqrCKMUJYbqXmKSAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: yQG8+CFzICYsLEvB7pv8RgHj4jSn8LvsYXE8vTZJm1q3boMWTr6VVz8+l8emiDwkRiQxUWto1VojOIeiEZzt/AB0nqwWsMDQKZIHAv1E4b+IC/EY1OtLRW0YHrT9prymGeIjbLUTB/Z8m7+WPyk+8bPM5SpMzHezWUtUEDSEegZlJ/HnSVauGxT9svzT2N9kjYjMTSzerEI+Z0Uk7GalFGCEZG1oDmhpUOqQ2n5p1KpWf7UeY2mzyRBH1jCxgNy9T8h7q5HbxZ81brSQybxQa5YosmU33H9tR134+0yfFjbM25t5nVjiPOz8z77Ehe7YzXwurz66YFoYWgnRFlOz25PFuegdLbTcRBjNK1w/z8yOzkKnOpAqEeBlxKs2opsyVTSC9+4+oLG7dFyz88RmrHsVBrFBMYbe5MZmscuJojqMjhnHgwrWquykr9ncLL3WVBV3xJ+xYCn11zabvtnPNS52O/gO1qyEh169RwwIF3b/elHUMohF7kRJZA313t10ivanz5GqWvPkrEe2x+aeKhrpFOIV4Z9f8fkVzFuJqUNJg5JdBU/c1KLu1VZODtO6Y4Ko32AjCSthOxsRRKO43yKwwwB6wHzEhxs2NKNMmWlPcnmua0lapHSnURLrnI5LBa2Gezr7WRxR1CPTVS+MaShMSszZWQrsMO1qfjLBzDOqPG1STLIscEdp+L74OrMfciPnVVSeto0Pa+JinSZ4v1MhTCaef7XCZhAnJejxHjd5lrd0naDJVzEqkXISvQpaUh59Gnjqzr7GIumCVW7MFa/LHVWaJo49Twx/ASJtA4BI6iGgfxeHnRk1ecHVdJOKnn1ql0WernEKRCNdxafkcFXIInW1GCcJ9QjUojQETorwpKiuDzjKjY5jKTwlSM/4QqaAJPaAugKSUPeLVzccerpOFdqVlYLGiecy2Jt3fB9f9ZuiL4oKdzHhkmt2uPTCG1G4j5Bgf+urwIoCJGeUjLxP5fFhTg3fjsEOZ3PXO5sEBAbXKtxBOVlgLuYDC5tIfx2yYRjqHzjPQl+hjssKWSCyRPYRJasz/1J1u3fQ+rwdDa7KdJvxSaPSXeeNKpXMI5kH+EqIpNLPQnfCBqCYZyPMq3qROWYwsVZE+Zjx8pWvYOvYr5/trLBLqj2KiHq5fI7ihJP2HGGFJehjBJ6Y1YETFhFH3rFe+3T/75SXyvKRocINVTxtHiczjJaPIBIi3YAO8/xKVh4tqfTHX+m1vktFn4nbWevZ9xFjap+n+wCpb8ntrq+eNl4xkftyRyhDTIfSHIYPEOtOn59/GwlZSwwXQhklqNIklUvg6udNDr8YUGU5s1HUxLLu0zWADVUx X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd82a56-2980-4646-906a-08d90adc5498 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:28.0142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QBVs9k4WoG6uWWCoPKGk+JbGoQueM0cqKPXuKHFLxAyldfxtpMiMQ9KdIJJT21qH9aF0Z3aer1xGZtP3QlGrhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235933_824616_DC472578 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach The current mixed function to control both power up and power down sequences is very hard to follow and already contains some sequence errors like triggering the ADB400 handshake at the wrong time due to this. Split the function into two, which results in slightly more code, but is way easier to get right. Signed-off-by: Lucas Stach --- drivers/soc/imx/gpcv2.c | 141 ++++++++++++++++++++++++---------------- 1 file changed, 86 insertions(+), 55 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 1d90c7802972..7356e48ebdad 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -125,20 +125,19 @@ struct imx_pgc_domain_data { const struct regmap_access_table *reg_access_table; }; -static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, - bool on) +static inline struct imx_pgc_domain * +to_imx_pgc_domain(struct generic_pm_domain *genpd) { - struct imx_pgc_domain *domain = container_of(genpd, - struct imx_pgc_domain, - genpd); - unsigned int offset = on ? - GPC_PU_PGC_SW_PUP_REQ : GPC_PU_PGC_SW_PDN_REQ; - const bool enable_power_control = !on; - const bool has_regulator = !IS_ERR(domain->regulator); - int i, ret = 0; - u32 pxx_req; - - if (has_regulator && on) { + return container_of(genpd, struct imx_pgc_domain, genpd); +} + +static int imx_pgc_power_up(struct generic_pm_domain *genpd) +{ + struct imx_pgc_domain *domain = to_imx_pgc_domain(genpd); + u32 reg_val; + int ret; + + if (!IS_ERR(domain->regulator)) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); @@ -147,72 +146,104 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, } /* Enable reset clocks for all devices in the domain */ - clk_bulk_prepare_enable(domain->num_clks, domain->clks); + ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { dev_err(domain->dev, "failed to enable reset clocks\n"); + goto out_regulator_disable; + } + + /* request the domain to power up */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, + reg_val, !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } + + /* disable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, 0); + + /* request the ADB400 to power up */ + if (domain->bits.hsk) + regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, + domain->bits.hsk, domain->bits.hsk); + + /* Disable reset clocks for all devices in the domain */ + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); + + return 0; + +out_clk_disable: + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); +out_regulator_disable: + if (!IS_ERR(domain->regulator)) regulator_disable(domain->regulator); + + return ret; +} + +static int imx_pgc_power_down(struct generic_pm_domain *genpd) +{ + struct imx_pgc_domain *domain = to_imx_pgc_domain(genpd); + u32 reg_val; + int ret; + + /* Enable reset clocks for all devices in the domain */ + ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); + if (ret) { + dev_err(domain->dev, "failed to enable reset clocks\n"); return ret; } - if (enable_power_control) - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); - + /* request the ADB400 to power down */ if (domain->bits.hsk) regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk, on ? domain->bits.hsk : 0); + domain->bits.hsk, 0); - regmap_update_bits(domain->regmap, offset, - domain->bits.pxx, domain->bits.pxx); + /* enable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); + /* request the domain to power down */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + domain->bits.pxx, domain->bits.pxx); /* * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait * for PUP_REQ/PDN_REQ bit to be cleared */ - ret = regmap_read_poll_timeout(domain->regmap, offset, pxx_req, - !(pxx_req & domain->bits.pxx), + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + reg_val, !(reg_val & domain->bits.pxx), 0, USEC_PER_MSEC); if (ret) { dev_err(domain->dev, "failed to command PGC\n"); - /* - * If we were in a process of enabling a - * domain and failed we might as well disable - * the regulator we just enabled. And if it - * was the opposite situation and we failed to - * power down -- keep the regulator on - */ - on = !on; + goto out_clk_disable; } - if (enable_power_control) - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, 0); - /* Disable reset clocks for all devices in the domain */ clk_bulk_disable_unprepare(domain->num_clks, domain->clks); - if (has_regulator && !on) { - int err; - - err = regulator_disable(domain->regulator); - if (err) - dev_err(domain->dev, - "failed to disable regulator: %d\n", err); - /* Preserve earlier error code */ - ret = ret ?: err; + if (!IS_ERR(domain->regulator)) { + ret = regulator_disable(domain->regulator); + if (ret) { + dev_err(domain->dev, "failed to disable regulator\n"); + return ret; + } } - return ret; -} + return 0; -static int imx_gpc_pu_pgc_sw_pup_req(struct generic_pm_domain *genpd) -{ - return imx_gpc_pu_pgc_sw_pxx_req(genpd, true); -} +out_clk_disable: + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); -static int imx_gpc_pu_pgc_sw_pdn_req(struct generic_pm_domain *genpd) -{ - return imx_gpc_pu_pgc_sw_pxx_req(genpd, false); + return ret; } static const struct imx_pgc_domain imx7_pgc_domains[] = { @@ -590,8 +621,8 @@ static int imx_gpcv2_probe(struct platform_device *pdev) domain = pd_pdev->dev.platform_data; domain->regmap = regmap; - domain->genpd.power_on = imx_gpc_pu_pgc_sw_pup_req; - domain->genpd.power_off = imx_gpc_pu_pgc_sw_pdn_req; + domain->genpd.power_on = imx_pgc_power_up; + domain->genpd.power_off = imx_pgc_power_down; pd_pdev->dev.parent = dev; pd_pdev->dev.of_node = np; From patchwork Thu Apr 29 07:30:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230537 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7856CC43462 for ; Thu, 29 Apr 2021 07:02:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8F8761449 for ; Thu, 29 Apr 2021 07:02:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8F8761449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gkUU506wXUwpb3nLLlf9g7QqQ5WoWgb5n8MLsBeT0h4=; b=K2OusMuAwnkDR21Y7VIF17kgp eaB34ceIwNsvCRTg8UuAkmEl1ocltwrtj+kGBxHhyzFkMkiyuJ+jnPsmc0wRp422KUj9v1OiiKbBN 8usd7JMGEMSnNPtUdVjRosGLq0q4o5raSaAXox9BsE05XKUZGRSDbkqPvgM86sS2uE6J9qSMDYF30 hTVFSzk+I7iEKsmIroV/TXPnBcXQ2rECBvhhj2Opy+CkbVrq8vTfeVEeC58Ln8Cueavn6mJK5AGNm xT+v67W+Uw+VjBwx8H4b/C5uzV4UcxMjLAm+Xql6/4xdptKwQKn1B5Hg6GkUixzaLBHQLN+mnFxED +qZlWuO4g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0f6-0057fZ-Bz; Thu, 29 Apr 2021 07:00:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eD-0057TU-Pk for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=k7rtVkFB7wUfYs+ZWvaLo2LeTqG+DCQSG+P15B/lTd8=; b=4ZzF00z5YMWdjyb4U/nmCPZDdo 5nc+RrRDyiHA1e3Nlp4W24dtAYrCtUImC8XCJn70Vs07Ke7tpRIYGo99752xiJx8+8BwOhgSnG64h R8oq7FFuDQQGiVweJmjCINyc4sQc8+0z1kTCBKYHGuuwl/ilfN+BKHJnLBW6CGTkV3DfajVFUY8q6 j04oT+bnYrjY/D/hfm/TAlFPypDHbY2r7otZN5rdzc2ZxkKsWaMnw0/lhT43mw/4NAKl55YZPFhO2 DlI4xexyeLKaC3AtH4u3Z1IS2m6mZiJ7zSZPdwIZ3DJBOoFg54wagdHIDrOoWTJtXcGx6WVnv+bFP jbG3Dpjg==; Received: from mail-vi1eur05on2078.outbound.protection.outlook.com ([40.107.21.78] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eB-000QJA-7l for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGtNL3G4nGuofF5/rHSu94hUUOQbupds5zPFPvKkFA9Jum6OnVxuf3e5AH9hZCsBx2CahfyGF50O8Df1UQCHf/GM9WyViHXg5qVcfUivbLR5J7ML8Lop/xovO97BLfTXgRLk0LKRc17O+CLhGN20/RuZoxIOvvpGfYNlxVMwgfsyivBhaE3Gwk5idWk5KCFxGFRlpat60rjkFmopM9M3Qa0OA8yqdGfStlGFkKZSJ/dcZiVYzobKhIh1BIknXo8MaS3thZg2stBkLfdE0IniCqKWKH8Y8IVt0PB1lBS+QgZrb6JLsL1l6RHER92kWGD0FVCRcNq5gOmTSR3+mDT5zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7rtVkFB7wUfYs+ZWvaLo2LeTqG+DCQSG+P15B/lTd8=; b=k+XP5V9s6FpYCJ/Bd0lkAlFm7N5ZCGhvn6pQ0KspR0xpTu7LMiQLYOPfuKYdb8pAb6PfSO+5bt8PlhfiKzOY+XFQ7jzCxifnN3K2XAGnw4IoWf9sJMGrq9GM+bTRPlxVdj01Mw7KbHf5KzXTmxfgVfTGIfLweNwwBl6HaQB7z+7rcHZYy+MyuEEbPaKmV9WjXgSFe56ZR1psp+K0/+KOJT2uHaRBFV5MRDt8+MIwYDrURKiSofa4nkuSjN5VOaAURPMEZody0jYftiD7P6oWjEtk3W/3xsbgNamWPFTUpvkXJWSZYkgt2gObT7xz6rdABwne0SD8CP8OLxvU8te1uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7rtVkFB7wUfYs+ZWvaLo2LeTqG+DCQSG+P15B/lTd8=; b=UPrTJyqSmwO/ZWrZEmLXQzoiLNJVLeayI/e8Eduar3OhkxRLMNMo83wFWLyRWpnMFswANVh6SjnpOANo+ysrzjpHKZpJ+m67C+JL+ryD04/+tF24KmWFFBehrJYMEJwYaq6d+S3FrV41ytQtGhRTg+5Y7t8nK19Refuri/fjCl8= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:33 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:33 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 05/16] soc: imx: gpcv2: wait for ADB400 handshake Date: Thu, 29 Apr 2021 15:30:39 +0800 Message-Id: <20210429073050.21039-6-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca74d105-7905-4f1e-8ca4-08d90adc57fc X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lVgTK8v17GCXEJRtxubfq0ZrFXlHJuK5VsXuJqEkwSsE4NyAsXGxPbgkrBoXzSwzn4XyKMFXQfchv9eIQE1d6G9RUfaEElwtORgcmAb7HzC8yB28BlJGmmzf6F020OL+fpIkgJLByZcIcWihY3oMi8MqGrWdRf7/OoYKadCA62UZGuEnSHwlvgpP4ZVmrE+X5phx+cImksAQ+V5d7tmFoxuaoryzmRtGUQ/9AOQMRDUrEd9ILJK5kePPBNTz01UzSkJrKXHciHAXwHjMk+l+YBae1fD4Vw2H98kyGbgTiFLDZeall0bfhhw+EqpjkT75Wg0wfjYo9EqITn80RPZLQHE8pvvgOPvHMd81lyRKd5tlttjBJrTjIkAUttLz9OeBit468C/Yymy7d+x9Q+/KLtEzfn/PwsCjhSzHJegC4kbYX7FQRx3C2HxuvJhQfaXQh6fErbGvBRWB//RW581ScKV4pdA/B0oBNX8fhwtp5tHHAkVMkwkh3yI+Fdl/RVEundNVQfQCpWrQGI0A/bWyQar/YdEwsHURIJdAv2mkGez83gAoWpPpQwikHknRfaLMOWgyonypUJTUug/PS+RIiZDu7bdtXVESpMNP+yEJXghRS6W0UozYlp0+gzOFI0Tzs8OUUBnxrJ2q/lxr/gk+w3oe3ertMkah7prHMXXSxVQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: HdW4g8mtaFGm+BvLGE95lS8AzQoBIZlMTv/YJe5JFvZ7X3hihCfntL2gmV+Tj9qsKlpWWqLlSNYIMqntCDqDdbbbqWZHZUDFd0V1EDtX2/9a9qIDje1FTKbPHLhra7qxc1SYydqsVzNbAJkMYV5qxPziZ7+O8kienLSOgdv5WGSUVsizFEIRUs3msOJ6hruDFdZPhNQkX2BL1/3UbfQnnqsmhWCr7x3VpdIodkhCY9albcckfFVv+JlobD6DVPdpHHsZhqfmaXAXgs65f83x3ag7wlm6B03T8unrEW+XtVGVCzEDBIIs/7FKNZrdkcPFJewq59V1NTUYZOco1GI3rmpPonjPPR6r5BuM8htVHHGl0iFrGlVvad972SbVdYVus0Jh4kGjzV2D9/86rp8/8p0S8GDt/okyUOjhPNTrjq/ePxlXEWogUxdPnwkIhJJwuF6Bpi/i8VkAvXmUoL0QaT9rAED2VDHsla3wINxQieLwP5G23ToC+FxJaFj2Neldw+GweTBLGQhdjEaywlRQmR3dMEOLGqWpT0PATXuJOr53E3lTK6wwgrgi7/N8UAIqAAMyHLvELN36HTMIjxjrwLmQgCIDS3L1iFrhZ/wF2cIPbHa7XhNvcz44Rzt7guthsVPbO7DWIPYpbz8FrvCP3UdOzyOz/X6T1NhH6zsTqxl2mrVAToD9yUAQsLkkeoJ9w6kptNAUntM7PbK2lzDvRk0sntAvo0AGSLCHxmiw4f6cxdy3orq3xoS+O93KBrO3QVmUIdqJKm7OLcIcajDECGprFxpdOIvDq1kd6ymAkABBXh/j1KNmO6fqwNJZi9tskssWPvlRr/LljMk7l9cDCSmhOdfJy5569JDGHP1eAIV6yVCSV9lkY5L8523HOtrNgUPL36G5AUnCmF6NZCQbjBJ2Le/76z+1KmSWPlJ6AJzy0ngf+TB0TFYjgJnPSYYVkgOOZMHPMUZ1WCZVT76BznHtDF2iIHh10tTFA2G1aECQid1CVMT55YGYhcAGlVn5+mRQgCkhB+tSUjhWc/fLlwjkFLDedW3VYyimmNBoz7O4OsU/AOaN1OlYzt62zLCuRhmIbl5IzrhdeK/MDJnhrOGpV1GIP3RpdTY9cyTjDZuj5grcRPOC3kE7AmZLbpA+XvENHIBQSpRpAhYtDYZR2lfXJeSYz1H3HdOqf1dgB4A7bj+Gacc0t8LnRKPI0x7xTIeRgUO/cfKsBpNxIOTjeQ90/MkAZvyDlnZkm/kCTwwGqAIKeTA4mW4lEMlmcTd3M4KtlxoTMScD6yVve+M3svMBLAwAI3e8RUag5Rlv30wyQFAfNkAwULbXxT5Pfl1/ X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca74d105-7905-4f1e-8ca4-08d90adc57fc X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:33.7116 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KwsUsy4l/H692/7QOjAqXPuWybQSeCxFqIHK7//8PfR1RmySjvGiINgbt0KtQDUrTickY/V2UnLT3qLO7ubwaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235939_307907_C0C9C0DE X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach New reference manuals show that there is actually a status bit for the ADB400 handshake. Add a poll loop to wait for the ADB400 to acknowledge our request. Signed-off-by: Lucas Stach --- drivers/soc/imx/gpcv2.c | 43 +++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 7356e48ebdad..d27025e37a9e 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -69,6 +69,9 @@ #define GPC_PU_PWRHSK 0x1fc +#define IMX8M_GPU_HSK_PWRDNACKN BIT(26) +#define IMX8M_VPU_HSK_PWRDNACKN BIT(25) +#define IMX8M_DISP_HSK_PWRDNACKN BIT(24) #define IMX8M_GPU_HSK_PWRDNREQN BIT(6) #define IMX8M_VPU_HSK_PWRDNREQN BIT(5) #define IMX8M_DISP_HSK_PWRDNREQN BIT(4) @@ -112,7 +115,8 @@ struct imx_pgc_domain { const struct { u32 pxx; u32 map; - u32 hsk; + u32 hskreq; + u32 hskack; } bits; const int voltage; @@ -172,9 +176,19 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR, 0); /* request the ADB400 to power up */ - if (domain->bits.hsk) + if (domain->bits.hskreq) { regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk, domain->bits.hsk); + domain->bits.hskreq, domain->bits.hskreq); + + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, + reg_val, + (reg_val & domain->bits.hskack), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to power up ADB400\n"); + goto out_clk_disable; + } + } /* Disable reset clocks for all devices in the domain */ clk_bulk_disable_unprepare(domain->num_clks, domain->clks); @@ -204,9 +218,19 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } /* request the ADB400 to power down */ - if (domain->bits.hsk) + if (domain->bits.hskreq) { regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk, 0); + domain->bits.hskreq, 0); + + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, + reg_val, + !(reg_val & domain->bits.hskack), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to power down ADB400\n"); + goto out_clk_disable; + } + } /* enable power control */ regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), @@ -369,7 +393,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_GPU_SW_Pxx_REQ, .map = IMX8M_GPU_A53_DOMAIN, - .hsk = IMX8M_GPU_HSK_PWRDNREQN, + .hskreq = IMX8M_GPU_HSK_PWRDNREQN, + .hskack = IMX8M_GPU_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_GPU, }, @@ -381,7 +406,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_VPU_SW_Pxx_REQ, .map = IMX8M_VPU_A53_DOMAIN, - .hsk = IMX8M_VPU_HSK_PWRDNREQN, + .hskreq = IMX8M_VPU_HSK_PWRDNREQN, + .hskack = IMX8M_VPU_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_VPU, }, @@ -393,7 +419,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_DISP_SW_Pxx_REQ, .map = IMX8M_DISP_A53_DOMAIN, - .hsk = IMX8M_DISP_HSK_PWRDNREQN, + .hskreq = IMX8M_DISP_HSK_PWRDNREQN, + .hskack = IMX8M_DISP_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_DISP, }, From patchwork Thu Apr 29 07:30:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438F7C433ED for ; Thu, 29 Apr 2021 07:02:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1CED6144E for ; Thu, 29 Apr 2021 07:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1CED6144E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZQhtN98jr/w6xIoHezXBpJ1SwDJTHG3rcdM78Qr/8KU=; b=aaDiFuiNcAVIIsLYWQqg5Z9Vp H3zId89El2SSbowy1vMS0Ij3gGVtkmKW7Qa3GtTgxPbmNqJ0TKIwt3GrTZQJgkDLMBTk8c4vR0L8t 9vvrQD7mA1w3r8AvFr+fxb3c4Du5d7jZgp0vi5cU3HoQz478or5IKbWvuEvnv1FTGn2qqc9Xl0BkB 0ycFJoNZ076MlB6dnI1+ykVHhAldEXVjGBzR7bYunMrsbP5XrjMkLp59W5/z9W1ee4X42mBXfwCCu vIIZkYXBqAQkvaDc7UCaNQPeALPjwMOHBAgJYyZHt8cee49DDKjcFoZjRbOLVOHxiBzjuFhWpG0Uv dh3rQtJiA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0fP-0057kh-LH; Thu, 29 Apr 2021 07:00:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eJ-0057UJ-WD for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=1f+Qunlsir5qWbv5njsoGllEEToCJYtPIul9+hHO7eo=; b=QxWAUfZ0Devvj3Xo8MD7RRMnoR rmcl3AlMjPt+xXbHhTrS/8M0xeq46TBtsiEUDk1phD9t4JPum/OcVy6IQF2mMfluIEyiaxZCfI24X P6gwAmivIqw3jatMeOYHCC3uDm95c0DqXHMkMjlrvd3ROV0IUeDsB5RN6pySITiS+p+SJV42ra9SR 94LhCGitfBdxoeAwHmDOZJoVZ0ezq3Xf1b5Netji7sX9yUcdh0d9DFGw+h6HAYq9JDKw93/cg4CBK GxHeMUdNN4I4d0PRhzgfshkXApmvppMPb43xzudLzDBDrg1m4gFbglKCfDSFKalkTlBRIRSlC8pwp lf1z/yKw==; Received: from mail-db8eur05on2064.outbound.protection.outlook.com ([40.107.20.64] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eH-000QJk-3E for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iOs5tc9tPGARcNWv1dNBwiLXmfQX6iszeHNI43YXAvBPlKE/6IxTnznMhHzOrruU2IJAls2+ONSftUe7AnUNtb9rqMvahsGZKnCtql52Nm7biegRRyAbtJhlW4TpEEOZASoHs9nlpaapm3yN8vcIiWXEcWzelYiYMVzusAIcBoGCif2gdH3ifjPmKYB7K0oJNkU8LKuCwcbv6P+FboscDhRoAvm8q72ccMnZs+HCRGk0vLOGVFyvUNOC07h/iPuZAxYftDxOvCclRRM20W9K8MA6Hm0i9muXSiXSO8KRTx0jQqfJ4ZPv25ljoWI0cKN9qWCOr2KdaLsP3IhDjh1/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1f+Qunlsir5qWbv5njsoGllEEToCJYtPIul9+hHO7eo=; b=jMHMpDxlE5B4Nrl8i8rCaZATbOD225TF+atpFQAtSf3tTTd4SCIY4eM8xEv5l7z45Z19Ra+HPy0D91Lo9IJrrAla2k0Yy/ttnxbZq+bjNS+Zk82dEFcuC3G3KvWySDDASrriu8D9qvKJwNpHhyga6/N6ygarWgBUnvRTEURTc6xV2Zd271dd+LToAwvMDdTDQIhowJOjc28FPEQcMrO35s8uHQyXUtOffl+/kR3bI2EYBFTYBLkvbChCRP8wOKgIVLHUaW6P/iX6jqXAA6UPR3o5rlRUEDCiJGhu8bn1jWcgoMXNMhMOhRSHk6MB2SUT/BRsweKgP1+vNiqC2ZVoeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1f+Qunlsir5qWbv5njsoGllEEToCJYtPIul9+hHO7eo=; b=Il3QsT4lxLn928XMq4GQ76LeE6coq/CdVNsDYRvUDId1CTkCBFjPYShLuSb9u6zxBkldV75245raMZC9aEYHsxKhFpVZiAJo3AZQr6/xfj0fYiOgz7L8A9jN3VBIt6vxMFNLMXwLhSDVXwiu77aJV4pz8QKvbT7+QfjsnZeJXdg= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:39 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:39 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 06/16] soc: imx: gpcv2: add runtime PM support for power-domains Date: Thu, 29 Apr 2021 15:30:40 +0800 Message-Id: <20210429073050.21039-7-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 987293ba-39b5-4c8c-9a2f-08d90adc5b61 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:454; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DibhZkSB8uX8TINSuuv8KdTPrOPVMXjbGtfzpfJAgt5q1ASjLiBA3JKHYzJNblMvpT3Q1kK338pTHbA75e2dThBaWUihwNrzgbs7I0Ha6K+adSnIO+rCuVikNJWdv5hvLNHGHkknUAuPA7CFmYlMOzC19qQHS/RxarqTTYgRqi6DcFOCEklvwhwGm2IkcX+V1UjrKLS+U7sil/VmTxsFbkhdLBMRJ7aqtkvtRHohd1934hP7HWyFRQpItdxGdoA2GU8/f1mFOrVSXP6gr0AFar7o4L5mtpHbKzCgqhMcFjKLT5U2m3kVkfkfUWmAxm45NiMrGb6tA0qmo7yCk2N30nQ2X/gV7ErUhYeJQfMMcQ1NNmEVNkV9N+GZA8D42u4W6wDt0R71nL81h5JwKOUwVxU89YDnmUal7Zbw4LlWwdd3rCPTfKDwun8ABY5DyBjvzMhu9Eo3dU+/6C/khpm7mHNoptd267WA1gYRt5itdMKcLYkg1mgZzsTx3dFunsd1s6HR24xw/AGnb8laZ4iYR8T/r2R9lqoO2yEGYv9yZZYFc6W3qD6VclmN3rliupL6iI1y8PDc/K1MV9QklLHoljR0rh6aQmGaSpkD/MhIwkfTLa5HO303TyUAqDnS/sJ6bCV5X7e2/4PAmzZcVyvKSoQkL1ysiVAk/4BduWFUtvg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: K8fmMoJXrgs3E0a0wkJ8Oc+PBVnjeyeLHSrBjKHVOKNgU5nW8aJtjL3u2/QY2UUjhl4QypW9/p9T+o1bv+2B+M1+SRxbTcpym2WgEjyuxH3aywLgSrkQmi9sAzqgkA0DiKgd5jJAdHO8d1PiONak751r+29YLATjJx76VosdXTRjWSj+dcM8QMODPWzhh3lRI4kDscWi1bxDMAH/iZFFiktilRw8Xb0aFhluLEp96w/VcRN5gmKOcR1uCbFo8IswqQX5pB2VFCcCkzWaf6lUFCkiqxCeV1dkMV5Ggs/XAxi34hR7/TpJ/c1JoTcMgxv8/FCSToalPS6C51fVZdXaeYJbRFKG6WwK0yMhajWVKUsrEzmX5/lJVTWCDeJGPQtr/3ZNm67C9ZQNXyxjBJdy85cerC2OjCn8AOfqShAVCs5bCmnDBj3fVERN5s2VWPe6UJkSEG2uY5mIB4KqjropuD3PhGhS3bvY02IYeO3pCn4/nu16RW2NvL2FKpt3LOSbz5igg7F5pC7rBNcGjxAqro0qeeIV3wWzza/NAYOILWCrG+RON3v3YcqLvM5STFTAFmM+HrMa/6JXtTYGzPo/vZVyyegnXYAww94X6ASzfTf6onGbOyswWfskPqLzZ0mFDVopDdjNxmu0U1FqlqWbIMCRZDImkwYNlgQUtlGWT6YNMSsLeDWhtOUXBZnFNF2l2bcupFYn8CdtOOohJZa7bXYEZF/Qy7xFgaxrFjpVD5yUUegPSnqWIBiri3AL2rg1s8PBmfbQapL2HLiTLiZ1vVaoeSrE3cOQRIULCFj2QOKb5nn0pyGHyD/kPIJBVIaaWvN1Ksqxw2HHbTNTKwKmNYp+TakADynwujFZGofmoZWKS7HFwVhJLoY8Mpi5X8LfTD/XfgK7CF7+wjCx/ZghLLI5qm/LoumKA2Olxh7v3+XkOtYY35mnGOSHxiZ+cjOQrLipRWhexpuyjKWAOlTONwYQ641TaRQN7GzH8OT6G0kK1Lkq6e5cQLYw4+EUQ1zeoFoVNWzjsTzZNVtOr7wpxQ3LQCxqPm8DseJlaIlkE1WSLe19EWNeFcPoLJvE5ebIFe9K5SuVzQxX2drvLGNggCsOjm79/k7BiwiC8gvkdpfYLCgHSs4ulUYsXmeJ2r8Iem1qbdt59DKMA1dF7Waq67Qr/tAbxpgum/eBOqO8j/DA9FIbRUZMBvWjxC4yAGIWdl63ZYAqQu1OGkWAh/vmmosqFYj6m61SV7Pi8ERZ0aqMvrxfpGECCislAO1xz28M8s0NH7ODPeCoFpw7vxGH/CvhXIomdHi5ARTNYt3p3irsE4R4kAC0yrcYUMtAHVyN X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 987293ba-39b5-4c8c-9a2f-08d90adc5b61 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:39.3651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pfdsM7ja41voJg3iL6hq7TtHLNXJITznfUcbyYz3L5fpiQwj4Z/JurT8+/LK5N/cYoZtqDWiAfSK1UW3sM7QGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235945_164643_B1E312BF X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach This allows to nest domains into other power domains and have the parent domain powered up/down as required by the child domains. Signed-off-by: Lucas Stach Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index d27025e37a9e..87165619a689 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -141,11 +142,17 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) u32 reg_val; int ret; + ret = pm_runtime_get_sync(domain->dev); + if (ret) { + pm_runtime_put_noidle(domain->dev); + return ret; + } + if (!IS_ERR(domain->regulator)) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); - return ret; + goto out_put_pm; } } @@ -200,6 +207,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) out_regulator_disable: if (!IS_ERR(domain->regulator)) regulator_disable(domain->regulator); +out_put_pm: + pm_runtime_put(domain->dev); return ret; } @@ -262,6 +271,8 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } } + pm_runtime_put(domain->dev); + return 0; out_clk_disable: @@ -519,6 +530,8 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) return dev_err_probe(domain->dev, domain->num_clks, "Failed to get domain's clocks\n"); + pm_runtime_enable(domain->dev); + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, domain->bits.map); @@ -542,6 +555,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_domain_unmap: regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); + pm_runtime_disable(domain->dev); return ret; } @@ -556,6 +570,8 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); + pm_runtime_disable(domain->dev); + return 0; } From patchwork Thu Apr 29 07:30:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3FAAC433B4 for ; Thu, 29 Apr 2021 07:04:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2456360241 for ; Thu, 29 Apr 2021 07:04:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2456360241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YY5o+ptGm9kLocYn/se4zuPCRZY572YRmCUlDcBdHlo=; b=RkXiiZn9tlqstgKqMBVX9fNuX tz786UYclFmJVrj+5nXSwC7x7aa1sJ+N1IjM/JiAHPlRqHoyRn51qr3zUx1w/lpGxfQqedtqZB/sl +MxREq2awc63J1K5fbqXVKu/SQVOZhy8lWyz3GKBYHZZllsl4uJ00toDxJ0zCyCydegOP4gq0EjkQ Wf9He3qJdn98dhoqIPMWiY66SBOcBjE3FLvE92Ym7vCXstpfwSswXuHRWUs3Ib6+zDCkeNDc5QDhc SgJzs5HItsjY/naD2AyYg7O6ZErAh3iMQKvuXX1FPjDMNG9H2sdqhfW8vX2d6g4y5GpW1QjzQQI6b Y3zm0O+hQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0gH-0057yu-PL; Thu, 29 Apr 2021 07:01:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eQ-0057Vp-Up for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=O0v8WtcsH4tJtAfSzv4uH4MYuURGDfvKhWs1KvqIGxM=; b=zviqZ/OBrNSSPbyepe0PJUg5iG Mta+ZvDIJadhbTb6H6ctBUKi9FiXypvkza0pmSTPKMwa58JYhtIzlqbb4GLRhBLOYXHeESYDEljsm A5MA+3kh4+LI8g0P9hlDVhE+maFRW/TK0e0R8bvusvHOR3i0GxLojr5buDS+OLTQeMQ7p1FR9GnR8 uNzYjaoyn00l+0Yp0MAPqZYt1E5DO/aCbo0W/5vnuajrlpidw4cE0xizFMhOcDQAYnvQ2htJtpKjO s11z6ZbKIpJz86YOp/1UyqqXU5AAba0tSg8FbtVl4Yiz2K6+r9q5ckNT/8uIv3HhXL6D3own7CSsf 4QbkwTyQ==; Received: from mail-vi1eur05on2059.outbound.protection.outlook.com ([40.107.21.59] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eM-000QKP-OP for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRe3RF/TgtVeah6yqR0x03hDHVkEOx/bdgtW0EABDhchc09fE0E84R9j5Js+8GwI6m8wtGOQx3QLXv5+gUKZpMXSO9fAB2OCGjV7Pjlr3mJMpq+KSq9wS0N9sc4QtsznDXvXcaEZ1gXvrptv9lbtf1PnR0nMzG6jTrCtgHJmypkAyUsFsGVzQmvF6suLPPwTRJy/X/DtYt2v+MtGonhEG0s2KRaAn8I1HVb0UTaW6BvpmsMXGDeTEVcs9ZcJ0spw6Ezf20MukCmbeWJlpilFqnWBe7H2BS1Aic7tCc4Hj1UcLhDV4rzifZnhxRvpmVmr1dEdemVTaTNDNxoyqMSnSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O0v8WtcsH4tJtAfSzv4uH4MYuURGDfvKhWs1KvqIGxM=; b=EuMVWix9OiL9u1BI71lXDjxrWNZ/Pd9Y3bgpFTy26gSTlwm3/How2dmLAhmUwt+ZoMyQUcU0J8gSMelMOrV9T0siHBYl4xraSfwI2KLCh3JLnDoz14YD9gfKA28uxjI4BbmA2pGyA0TVIKKp8INdGiJSUbSiH4bMHFREpj4lKLKDHsmMvAhSJkp2odB5PmGlBPEAuz3IZM6hiWLZ5mZFfxaO3fyLj3tdMHP+PhmiXU19PwNN48AiXabdwYe/l/1WgbCu2zvSX88roEb/IL+0LWnbljkHxhm0fl6wGVYUyF0uAgk+HZPcAYnz57uVZ9QpygOgeltZLOb+mF6p39KZTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O0v8WtcsH4tJtAfSzv4uH4MYuURGDfvKhWs1KvqIGxM=; b=UutrzkhD+xPnEWtVZFt2VBVAwj139+GbbT9YjzdAnxX/rvNCuw7nzcftNBYyb4XtZOm2J3icGkYJPtQgOEFAOE0ks0ffjlUaJwKHp282mj+kAygHk3R2VZsI+KQcKbbiX0EjvRdWZvleaT6vps8ICHDxZT2W79QbXWt5gz/VxyE= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:45 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:45 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 07/16] soc: imx: gpcv2: allow domains without power-sequence control Date: Thu, 29 Apr 2021 15:30:41 +0800 Message-Id: <20210429073050.21039-8-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c52b9b2b-aac7-44bc-dc04-08d90adc5ec0 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YvBA7aqvQuduiUtjeDNhmpUvIJ7F4czEsFpDYXTtInEx1Mq/LcTfxYpBhVgCxb79aN0HyNA8jIFBoPdTIlff8cF22pj7XlgoMu5FOW+0I2Y+XygMfGEMROs4Q31MMCg0eY4OB8dpiR6YAD53qhPSsKizwOIisrWblo1RiLbERE4aJLcY9y76581XeG6hWtMA5GhIegelKSrkdd6ECewNkLtHV2sSX59/8sp/KHzsIZz3ATWeXxppd+39rtnxM9O+HHRKyW6G8I0i/IGsCasb/YbJRELsOLqYaubODnFzWK9pPmmBQjqIgNa9ZmTNeHHSHo/faM0Wbf2j9g/KPW9+9Tv080rReUF1pWz+MLQBCSfkDJLVayrOvQTM7Juf+x1AuU+m5ubXn9VdL2ZWLyUD5Jy/Pyfk40ruWrA07UPsLI+nDW9aap+QxjgWxnRHd1fBILLSAzH2VORqgevqwYQczsePyT/aAXuw4JeNq2nAjj238XrpLVzD1CTktTdNiZMk7tBEa/zv9yqEjhhfW7yVqEVw/XcZ39ggDacSUP58wlkI5HOI4ZNYdW3nN3rfwup7wdvXSP6ydYDN06tb6dF7l4ISI+rnfC8lkQ9ju2Hk+9CEtcAHe342xCZVM1N9RX1ot1TDLsYFl9X947qAEOknm0QiK5+IInhpN2v6barXPPM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: EhrrDWqyTRw9lzPh7OFdgsM7HesHz1+BFndkyTtDxKVR3TRvbb7s1sgC+GuKjAkP4FTWkKCba0xG7xuAX7ri5bF8Cmw2Xw9cVuGBP3XGA/HXPizBlCG9NCn/5slK6SlX90fF6lRqaCzukr35O1N1XtifLZkheHWGnLINrHGcShBdAjJi+l5PFOH3JezR6ms42l0NmULuuGMgma3Zdq/iA6Y0HWFYJTIjuMziiMXJSdIUAmIy8TiE33MzhnVwYc7H8NqO9TAWLhHOx8yO7jruuTGmS7MLH6fD/0TGqUI6U8r9awItWhSOJ3Quy0KGGqrLMdAiFj6ui8KbT3rnUyOS3+KVx1WgnYMH5epIFotFqC14aeLlkEN7gS7qHZRpR17lacOYRQKir7R3OtA+yhQSv49SDzUG+VzpVUNjULHC4tKAuQz7zVCKvrAD1TR5Ygulw5t+l4DatyO6wsm0P1jQ1IviCtuCAL/rh2vQsn34ZKbCR/ajNnM/lB7i7WQ37fFuA9jVvBXcQgI9KaHnWcYcsjSg049E3ZoGvQ/JoxQPeQhzRolgYt0RgXMtHm3tGA9wY0NKl3WG56Tc7zgQVFoGzvunaHezxmcF/ZGCAl0dgMHA7IrvYGjj+MO0Pbe/n0CJqfUkZr9GU+rR0EO965jqn9IwJhtmuNO/wjztWyMiUNVmYpVPB8P0cAMsiqI6dOgTtO+7e0Y0yRPwt7Q7p5zfyTd2gG6yE4bm3TtlROWm5baHPpZiDC/IQ/4M7Qc87qZM373eV0tkp6UiDZPTBrZVG7b8M0DwQilj0tkWuJckig7ueyc7+Vkxxu6MOc8PQhc4xQ4y09cHM3m9TjuJer9bZ6PbD2XEWcaUOW8h0yoURqiUkhewUKSb7QC9ieDovRHn4yEn81Mjzfq+dKulhkqVnS9MOVJIKvn3cMtfuGY6WoWnymxmr7bGwLEJcOIVlzlSHzFH7vwmDSQBnK7wlInwfjcv3bWyW+FM/PHClYm8T/YvsMvgyffxZ6VEi0zauVoqI+iRX82MhdayPmwyj/wo2HqwfF/M/wMeknTstFbSY2IL5iII/FMZAvzP4zxd+s7SDa71Vqhjlor/FOMVpZRjVSdGg+eudePZyrMiRcC+icGLmFQ8WOr+tgTClh1A8ltvMqgz5NAHQfT0eVEn/q7otRJM7NQ1CXg6ksk6LSuB4Qg4eOQQRJyJz5exq1NmH7vaWHkG0v32ENTCY0qdORhj0ZefW4qFM4qyqkrZudZiavunuvjipFIxnIIn3rXaBo3GautM84l3RGBYZ/atv4J/VCHR+5MmJr+YYY9JkkBsyw1Ww0s3Y5I+7A9fQ+LGkyvv X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c52b9b2b-aac7-44bc-dc04-08d90adc5ec0 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:45.0255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8lz9bUdaOKbdmJdQRLO/2YH3HvY4wNU+37HLJiqBqeT3Qky674hFczZZwxg2u/XEMVwx7LmfdnBfrU6u1YvLPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235950_829209_4E344DE6 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Some of the PGC domains only control the handshake with the ADB400 and don't have any power sequence controls. Make such domains work by allowing the pxx and map bits to be empty and skip all actions using those controls. Signed-off-by: Lucas Stach Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 89 +++++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 40 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 87165619a689..640f4165cfba 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -163,24 +163,27 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - /* request the domain to power up */ - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, - domain->bits.pxx, domain->bits.pxx); - /* - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait - * for PUP_REQ/PDN_REQ bit to be cleared - */ - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, - reg_val, !(reg_val & domain->bits.pxx), - 0, USEC_PER_MSEC); - if (ret) { - dev_err(domain->dev, "failed to command PGC\n"); - goto out_clk_disable; - } + if (domain->bits.pxx) { + /* request the domain to power up */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, + GPC_PU_PGC_SW_PUP_REQ, reg_val, + !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } - /* disable power control */ - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, 0); + /* disable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, 0); + } /* request the ADB400 to power up */ if (domain->bits.hskreq) { @@ -241,23 +244,26 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } } - /* enable power control */ - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); - - /* request the domain to power down */ - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, - domain->bits.pxx, domain->bits.pxx); - /* - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait - * for PUP_REQ/PDN_REQ bit to be cleared - */ - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, - reg_val, !(reg_val & domain->bits.pxx), - 0, USEC_PER_MSEC); - if (ret) { - dev_err(domain->dev, "failed to command PGC\n"); - goto out_clk_disable; + if (domain->bits.pxx) { + /* enable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); + + /* request the domain to power down */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, + GPC_PU_PGC_SW_PDN_REQ, reg_val, + !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } } /* Disable reset clocks for all devices in the domain */ @@ -532,8 +538,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) pm_runtime_enable(domain->dev); - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, domain->bits.map); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, domain->bits.map); ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { @@ -553,8 +560,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_genpd_remove: pm_genpd_remove(&domain->genpd); out_domain_unmap: - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); pm_runtime_disable(domain->dev); return ret; @@ -567,8 +575,9 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) of_genpd_del_provider(domain->dev->of_node); pm_genpd_remove(&domain->genpd); - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); pm_runtime_disable(domain->dev); From patchwork Thu Apr 29 07:30:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71279C433ED for ; Thu, 29 Apr 2021 07:04:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3F146141E for ; Thu, 29 Apr 2021 07:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3F146141E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fRBEcjXkLjPXenF5Ah5KDTeXzEy8MzGJUYqlUdhoJpM=; b=e6lnzm7pXxOgBRNHECQ2D/6fN eWar5rhtNbJlvnql+CRvNEspi5Wo5n4zzH9RfTQ/Xdj4jycrW0adtvIDwyNJFUTMi/8bU60jFFa/K Nj39axdMNiUDzXTcvBjnsZTvV4nnDf18JCBBW6aNOTIJZt9u8+7M+NlHisrMPcypWTNHV+edazc49 ztmVDPrUlgeEvTIVghWrrgAXoJp1vI5+5zfJYo38OJFVqNTQRwNMySEKRZC0PdbSjFowF5wYv5/8z vyktdA2euXctMbFyCyRAbPjwu6jG6hIMJ8dL7J6oyyKi2+vRzDYQ2gOTeyM9LhKeIcQcu2WhkJgq9 MmUfAQjvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0gp-00588M-8f; Thu, 29 Apr 2021 07:02:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eU-0057WW-Tx for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:59:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=M55MHAAB3wU+mM8bEEjiU+t4iN966Q9glBMqxKp9qoo=; b=1RqMezFYNYFnWgUZxzJO+hNFvg DivdfD6jSfMlI59Z6+O5f3p1qPRvQ3BOD7lOjcVMwmx7Ifa3VZ9I1B9fytC2f3Negap7D+aieu4CZ 2l9st8luyxCDXuCU1k1paF5iwI3JtGmvCUGIPwzhd7ol9ntpxOE83QYVUtXzZGL3vpG99+JW+psQb D0n6tv6BjhVTt749Yv/l0hP8Vlxzi7h1M481BIuwvTLsEPZUUMsPHzrwRQayKcFAPkutGekJSfO1P 6Asi5zmWP/cRu5bITYdaNE4A7RBGHJMCSYlHsneICkePgNrJ0NTWgH2CSxknEyzZnfMdzWfQ3Y4xJ qfT0YpyA==; Received: from mail-db8eur05on2057.outbound.protection.outlook.com ([40.107.20.57] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eS-000QLJ-FK for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:59:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ex/Kl5E3uv4akU1oEvDo0Nd7l5TmdaCFjTrraphlt5AIh8ybc+qVbYhq/SJybgh+nCcsaVLM8X5ijSfj4vfB+iRxK/k43Yw+1lvnabomQXso9nodczn0ZX6djdUGTKtpVl2W1B/I5l+PuveV+73i7lDK2zwCm5y37641DuBnPTs0aybq/RrBSkl5v2BuyjpzK5bGFkhAN3FAxxnIDtGFErphu5wuyzi8BpIoFsQPJKZTmKfZMzpR4QK+oS7cUzWm01gcb6cprrzytjafXdXqfPn6z024dvC+QVrc8mXz60RXBmqGtX5pZ1NFiMNfEwsv89SOpHZsHEEol5sf5XWygA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M55MHAAB3wU+mM8bEEjiU+t4iN966Q9glBMqxKp9qoo=; b=hQ64rJSYdAhCoB2ppQWEtq+799N35ZOWtgKppbOi3H5SvtlvV6qFaxVwvIIPWGRSXn5OO0dt1JF/YoFWkNdRomCZPZe0fTESF18qYst1KYzWGUeuwavdPa9zMdl0RZT3RskVmTrzg4nI2QCNR9qskDL4uhoxSRWd41nTg/u7QIbVnlMfteCPFZ3rE5g32PS3uoF6SBMDToclqW+V6pe3cmqswDRCQIbE+9W01bWWDqd883PimR/Cf6V9p7sehL4DTxZ/GWVt1VGogxZ4g7PkSggyIoNQadiAqgp9twDVX5xJki3r5UjVAAcHq3pw4ZQKgLCAmdD4EhPxEYN011G5aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M55MHAAB3wU+mM8bEEjiU+t4iN966Q9glBMqxKp9qoo=; b=llEKFm225RQpT5vImJaWezBOXyajort/0QivrliMWcNNDdvm/4Ja9ehbqW2yttNfOkStfSmsZPdYmNebdZjw4ga/4KyJauvKPEeProQb5rXD8RMm848g6RlqpFIn45JGH/xYfEKJr0W4y67UUizngk6Rt3JvxWmIimGXnIQJH9g= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:51 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:51 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 08/16] dt-bindings: imx: gpcv2: add support for optional resets Date: Thu, 29 Apr 2021 15:30:42 +0800 Message-Id: <20210429073050.21039-9-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cbafc42-051b-4696-1506-08d90adc6224 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KsqGZPYwlqAtmLZLvr5afcP+82H+IhvoLSnhbAMTlbZ0mNCD21zIcnLcJ1jXDy9QoXV3jddR86tdCt3Qsd4iOJVms3xavlBlbYcgmsNjvlWy8vP4UaogHrfcIJn6fvwWZE/k0uMecULmrit3r0vUcj0hgBQM+yDNNC586cm+nXyvKjoPaCiag+hYZXBf5syfqIQyXhte2siZ6BRj0AKewAjBtsJyFOB3kedBGTfcfc/5zzPgmfV/MvP0jPPFTLvsiUqbjDMV/BEPVME/jfaWoDvoj8Obm4PjxuweCAGDBQEy9HEj6KRR5NVP46F1ZXKy/W2jTGNElCTswq9Q57HWrDoltF7AMU5wWDImIT1Lgo2/x8BWAXEjf6l+ix+jSOMriQ2uptVCueSfaaa4Oq3BJLJx/hirZaa3kc5R90wxfbJSLRvkg5m9x07kYkv6t6aCR4CkhW+lHpl0ck5KY7GOwQeQvqkFRs/aRtc+djKq1SBtAuMrri/gZzFGBTuiqKjs8YWMVu2aKAXhEJoxn1ufJYIBwX4RGlQBJq1FQpsu2ttcHWCxPawNJGQ1GNdUUdkNs8T0UG1LrCdK/1dCA5cX/41vY2z6Fy3ukOQXT5Bi9qGJxRAEpOk848kd1hwuVfLcFqPk+jtOrTYW0LsfgkAZHZ5QZxCGzW5zRjVw4T7J7T8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(4744005)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4lhtFgqRnmgfsCIfOZmaf0tteJna5mNoZ2nKpvDKUQhbSvnn6yfAz7z1ey+mURbnx2bfPaeFLbCWHXEz67wXRsdcfz9fwXsQCdATpF4PTTSM2MISmwuoTxSKHlxTIdFh7ZH00JXNsIWqUjDcDLiT+3HmfXq6fh0AMCpqoFnpuXc+XNiDP/yquxUaPC3pF5UB4k0SQ7QYQ3vmrKxAHVzj85JBNpOTlze848uTJ2uNUkLtahJRWbyET87bEL6C4lbh/RFO9aYgOK7sbABsz35+8yac4++DK/mPKXndvRIrZmEBsnieIcDlNKP7fPhQlxNcTAEMKs1LksXrS9IptqUJcgAfqiuGYYPyPSrWF9Tt3YBkDvEilYIq3rmeQEaceW+kJ35vb8KezAyhYxzYmKP/d7xTAoTn6SzTTzCOqyNH81z4LbR8I9x/5xSL3OZIoxjFJPH9s6OtLeR+9+3FefrIB93grCsCbnzsDDRvQ5KR4D+VuQVg5tV6uVtN0+K2OOu5/jmK7PbHok83HmnHx0q6sZBaBsrBUjXx0KCYb+sm52uQy2LszvGZfAKxmGC8R8TKnxQWJernyPFwGmpGOLLX55IkZVL+BIKm6aTQBwcVUYDgjbx1lp5uEuFbi4n3zebrbBXkPKiyVa6IMWUGGa8mrCSgGHrlRAe9IdBO1C1uFiTjII4C0i6oRVplqZwZghblu6c77Hmn3D/u+1QgUBVhNxz0Y7RybwpjXid/lgrtKHDUOgOZIvLIiVX9pe5AYWrrWjkQRCJPDr2JxVVoiFwjof6xfjuB20oIJ0pdXyRJSRD5tFBhD8ZnlARE8cBn3ZMW2QaIiQgNqy34bsbpip1sHZpd17Jf2ngAIdhSzn+4s8TB/dDulIpZLZrCw+H+mRF6ZpJL64fUt2hChNguxALrDpTm2f0zBHHVGpbFiqSRFJ+rAVqpeKTsM8BqskmHf6CGIqkZDz+G7Tmh19O7VOT77TGSTjI+BUI3RJKRrYIyUXhZcc/F/XKeaIffZcgeCT5uCdB5lkD4BMdRv0HXQdQk28myShpwVGYoy0aeaJaFYhxvOe41ZIZGU2tCXEW2lX1W2yAO72eUgt85iYZ2AQKpLJ0A6JFbHzDdht6Olc0lQJPCTXnlDBAuaQghnr61K2plxXzVfr/TdqkNpJ0WV7Hi7aLnRYl6huweXYO1Cllf2JVTJeVBTw10zChcQDYB6JRlmjWDMJPBdAyP/WwBGxyFMQorQgg/VSM5ALvGSzXgBV2Ud3O5R4u8/vSBP2kh6JenIh+spYWH4xp/92ZRisjrC/u6viSrgQRWaWENl9TzYNuDrBJTwnQV+4D7MgOVDon4 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cbafc42-051b-4696-1506-08d90adc6224 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:50.9178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1FKkaiIr3xqVXG2RNk8sRiCCQX3DQDX+XRORycsePpyeC64uo2AnSg1ZCrw/w5ZdMjCIuAiuDwz047Lvd5ccow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235956_536474_B6408A44 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach For some domains the resets of the devices in the domain are not automatically triggered. Add an optional resets property to allow the GPC driver to trigger those resets explicitly. Signed-off-by: Lucas Stach --- Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml index a96e6dbf1858..4330c73a2c30 100644 --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml @@ -66,6 +66,13 @@ properties: power-supply: true + resets: + description: | + A number of phandles to resets that need to be asserted during + power-up sequencing of the domain. + minItems: 1 + maxItems: 4 + required: - '#power-domain-cells' - reg From patchwork Thu Apr 29 07:30:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E52CC433B4 for ; Thu, 29 Apr 2021 07:05:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8EC461449 for ; Thu, 29 Apr 2021 07:05:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8EC461449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zwG0Tv4ObQNUhlYDzOgOcG9USf5afm6J1ygd3FbYZjg=; b=rguh1K9z/WwaUHhCsSOfnZra2 B3N55Ly/sMczBkEL9GBzHxPdcSkJzwPgMIKxG9C7BADnAJeLPtEqVPQkn/D1IH1PmukH/LIxa3MEe 3hLbeTfWJnjJhSN4hjBuZODCbrHkpVOGGyUkbTHXslwYFZ3DtGokwrIrfWG6qgu1VsrNpWTQgLTXO fZPAEZ7eJpAm06/0vmFj5NezxzodBWQ0agrQPU8mNMFiWFq6bU9CrewRFfC+f9wA6W1Exk3fxQgUK WohVSqz9yZeT+UyBQkkTH32DctH5NYKhh6r3EGftr9LKwLZU8BotK8tKjgRDV8vBU0iGEpjqVczdO iv6vqpkMQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0he-0058Mf-7N; Thu, 29 Apr 2021 07:03:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ea-0057Y8-S8 for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=LHsV2o7FPAwFDwz7mNIvKCoXLrdDQsZbcM6bqE5AUXk=; b=oMWLZNrD1jk69DlCBPV4qQ2RG3 gWLT5xqcwevbnip1KtlntPQAnvFnDybViapHY+EmrVKbjJDA+slHWzngYLWZxIZTjfuEX/nStb0xg aFxUQJ/AO+dpyshpjX5uxurKX0VDTnh+kp7eb/6+Fr7l3zh1vOmQwBW4+39vSWzfWU6Ptm7sS0EvG IlYdTc99MOS7uokFtgen9JIWHjLRQiqW988YpYSnkC14x1koOoymsLLRROrGvkKbKsffYhR+26570 rlSJakUDrNPhj9ROj/Z1cqzmcxhC0Bfi6vnOOkFrDw/Wollo0WkJoKqr1eiT6o2vaAARDnBgY3mhY BhalTifA==; Received: from mail-db8eur05on2075.outbound.protection.outlook.com ([40.107.20.75] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eY-000QMH-9b for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRQgBrBE0zP64ZzJ4ZGDkvUAOcQrYbtxzazUoDgCqKCPwQFpAwO/ml/hFMZxSx427iTjidCU5ygHI3g+8Y5HKqQQFzOVa0bgF8FSYoQWJKiDJX8MHvxNtBhv0y0V70NGCByFs3HyG66vrz2DJFzjd5D7gy7BqqT/+lvSgNvJ7GMTwZ7m5YkkYMv1rAGNzPuMWRJ9EG5766L4qYOPIUgnX2GQl4zcUvsGX6ox/cSkcY3h3Ed7VowCaZPMbU/5URmTZp7t/o2UNCN16ukBcTidNRkDT81jVig+hKaKSgrChFaJ4YYCEkahdgw0cCflVfZr2aoYW5tTviGlCRP0B/oCow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHsV2o7FPAwFDwz7mNIvKCoXLrdDQsZbcM6bqE5AUXk=; b=LOZcrh2v12DzR2fV9iONnEO7yB88D/FIEO7PiP8GrfDzEaygO4cmhrAkKaC7seiE/sRa5ZTO0cAN6/A0IxrkDJihf79bfwWLsJrWkGb1UfiHmiMjqf4/dCK2Iy+XLFNOMaro5eEcq5Jzaj6HDn/xhYBRQAzx1XJK1L8Hyg/Wo0U/Cr2HpkSHqVtROfUhlcV/qMlJAOqgGYYPOZJsFlXkFOEbLNAb010/HWFD5mbULa4CTKMkyQhoL4BRR0KJjHmJPwO2/Tr6wjCJq9n6gnJA/GSfnfKpIFygfolqnTbQgQYPnWytgZkhyktTTLBq57zrBMZqK5h61PYm8hxSV00rsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHsV2o7FPAwFDwz7mNIvKCoXLrdDQsZbcM6bqE5AUXk=; b=OM6vXwHQRU3rOkKoS8XN8FAtQRmDsf33TgGHT/GdGrtEt89dev3m6rBRIpY2x7Xn8cVY16AQmcuaxDvivDuebNLD4wDcIAYlKE690pmT2QE3nKItrqFHbf0aImuRul4iGO/3vh10HYtKunZeHnn4+RNxZ+82ZdFzfChWjE3ztQ0= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 06:59:56 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 06:59:56 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 09/16] soc: imx: gpcv2: add support for optional resets Date: Thu, 29 Apr 2021 15:30:43 +0800 Message-Id: <20210429073050.21039-10-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ac44cda-22f1-4326-96a6-08d90adc65a4 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y1gu+PNPuXYUmGe837eXwDtdZlmqeRLdpVQkrNeinfSyt9Ob6hi6W+vZK4xElDHswYKRvthouHSBMmj7Br5Dpo9p5RO7hQ2w8AVZPbGP8ddMdplYZKlFVGW3vQbV21CDMV3YJrR2dxcXHVHzIZRmveij3xxlmnMpFMlWWP5F7Rn3oE0wZkmX/OaZNWXOA1ZBzloF6ekdTt2yX7Rt7umspgGYEIpLp9rIqfIPhGVtkZ1bG7pveZ6TNWS8wvX0VWRei1EB9M/xf9cbejWGGnzPMDiMp9XAgGea7lskS023143g0qbxLwL6Hlbv6Ykqyd7O+y+C6CZHewF+Kfl5tCNu/2V+eH5bt1Sc3EDu+FUnHeGWziYUTtyUuUhaXqht+cbd6zgAGPPUYpo1rqzZ7SNb5kRgUfe+Mh1YRs6ZUT3JifOeFPNk59xUPzlbpbgj+SRFj+IYuvpKlHFcpALbwG7llbFx7SnUdewcryx4qeutuQ54PXCMyjFqGaHED2vBE4QDBSBNZSk1IhG6zqOukTsxdsBekVh4qWEVWI4uuTLB/lSEETIa/cqxIzSJJJLJ213CDGaaaj7EdpMtgqAIP0Pucdl+5rs/81RScIIyhaHChCUZN8BfA4Ht/LBw9hCvgbDXn/CR29WlY+abci21GaRnng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 1lFOAeEYjMi3QK0puG0gSEYlFeFzlfUn3BGz3+ZPKnjq3Ch+pK9LwsRNp0+qqfV/s08XGOFUXiB5tp36Pv3xRf8PaMVPLDE0X5bSIyz0zmTP77CgDp8fUG1RJYm4K2VKimcfx+PTGjKanp7WPhkCUVt/hsaxtWd4loO1T+3TD6EmdS/RnQDPPcl4p2nNO0u2QPRdKt526mQkEpbJngXNYuqYpli+mA1l2Zr3fL8vkiGS70Qafhe2YKMstvB0+Gkau0Ch1vjSoUctSKsrv01buEQvU17XDHzFB3X7JpUpufESiBtdWDqYE/To0GZD83nCf0Nss0+L77aO6WYvrK2yDFZ4nveWKELsc4jn0eR/e9Jw0maHWUPtlx5S3JM8ms1GtIn8iRQrCOhAZ7c8U1Q5ZmMmJQABI6V85/Grz6Ur6+fPvhAJuzJHi0OHnrQQAs3rvJRMBMLmSOq/L2sgtrwms2YrNmW4srz994rN9TBiEp/aP+dZh39t+pZeC8zHVSBvk+9n7I53bx3I01p+4i01blt1J0SOEnINYFPyahIQw/flQnShR01LNI1VN9kGiw/nuTXVQOqy6UGGS+aq6+XXeb8IC1sB4w5Pjf9ioiFtiThCOPYOMW0BSc/ORbhmoa4iyob+BeAdZ89FljtmFIPV35iehNY+h8YuEpzveZSvmTy9VrpHmC8z4DLZ/VNFM3bHyifuVpNaz0ZhjqWY8j2sfk3WOIhoLwWE5dVPkP9n7Y8SNdVDtKi5fJDG0rI1kFFDdRE0rrl3w+p8KjYrmnJMOZtLoX0dQ7syLzqXEm69hoG807VjrkWBKjB4VDjQdwsiV9DDtnq10cWcfYbbtPQabUk74cl+4az8o2cBJ/B+FG2Mzo+3zBWNg2B9d5VBObAdimY6bPKlkNRCkKf1a3qaKtNRn0hb8AzHbhA9NHNjsciYVl+XL5kBnHdWBNY6Bn/UQgAiG7D0/Fv61OgDUTtQ2wjWRZD7pccKXP0Zv1pAxDDBPOKvlL89JMXpd0JY65Sx2jBfXEeqM2bOp3ZoAtiLv7XthpNzq+Sk1JThTENox875d8REU+CWxVDL/Blt+BgCcC4XIc6nyhcbgGNBMi0quvwihWMreoPErAwIPZ052WT0VicAMrf0Mn/pKPfn+ndElrZTrReGEu6cBxFVuRp3uSSgplky+xh7EZq40uNER+W5Y1DuozeUuMRQC5/8IdmXrfuLvbCHyR6Uqf0iZK96gdiZtcj4AAFl/+r5IUcWfpfOSuXi1R+XLLPlEaVZdE+H0lhXHba4LV50K3R8hFsKqRTnnRmXcQr4+Swywj475yPDvoBSRCzylCcCO23Wh9Mh X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac44cda-22f1-4326-96a6-08d90adc65a4 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 06:59:56.5863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rs6O3yCp1H3F58waPt806delvUWyfjzAH08Ifb7HPC8UcwZZowRwtCPEVcraIcg6+fnfiOebTVIM7Caisg6yyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000002_369241_6026873E X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Normally the reset for the devices inside the power domain is triggered automatically from the PGC in the power-up sequencing, however on i.MX8MM this doesn't work for the GPU power domains. Add support for triggering the reset explicitly during the power up sequencing. Signed-off-by: Lucas Stach Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 640f4165cfba..4a2c2a255d1a 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -108,6 +109,7 @@ struct imx_pgc_domain { struct generic_pm_domain genpd; struct regmap *regmap; struct regulator *regulator; + struct reset_control *reset; struct clk_bulk_data *clks; int num_clks; @@ -163,6 +165,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } + reset_control_assert(domain->reset); + if (domain->bits.pxx) { /* request the domain to power up */ regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, @@ -185,6 +189,11 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR, 0); } + /* delay for reset to propagate */ + udelay(5); + + reset_control_deassert(domain->reset); + /* request the ADB400 to power up */ if (domain->bits.hskreq) { regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, @@ -531,11 +540,17 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) domain->voltage, domain->voltage); } + domain->num_clks = devm_clk_bulk_get_all(domain->dev, &domain->clks); if (domain->num_clks < 0) return dev_err_probe(domain->dev, domain->num_clks, "Failed to get domain's clocks\n"); + domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev); + if (IS_ERR(domain->reset)) + return dev_err_probe(domain->dev, PTR_ERR(domain->reset), + "Failed to get domain's resets\n"); + pm_runtime_enable(domain->dev); if (domain->bits.map) From patchwork Thu Apr 29 07:30:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70A7C433ED for ; Thu, 29 Apr 2021 07:05:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BBF561449 for ; Thu, 29 Apr 2021 07:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BBF561449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GYNnJt/DnDbeYSxKz6+FHHoPtG5LCS99Xz0cbiRZoQA=; b=PoHStHXHM1Wk9JupsT3jTLHKV 5Mzzo6ti9+hwrIM8kgdFptgpCAh9pgfRKGqLaydqwvZBQ5s2bwAjZ/0m8qSOF6d+ae2IDdPzQE6uL T/fUwhH8IV6FFqeZQtSSGkAxi4xv9su9/7F+mtqn8dGP4f5iPW8RixI9fNCC3L0TngU4APs2esdKE JDDeN1nNPJ/OzX4F1stQMWMwAvSGHLXYJfjNSUmQ4E7KsCQt3uOlI8MrGWf4tHKqec8ZxI9gz8P9n Xrm5iGtNSFrW6LUAXL1YRr+JFmtvZhYlAbZZJlB5bJ2edkKWskzNj69iMTu1HTHlVOb+PzovjQXDU 6wbqTt0EQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0iO-0058Xa-8t; Thu, 29 Apr 2021 07:04:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eg-0057ZI-Lc for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=bPyLPXB4J/0iwbPB7EI8D9Gb070Bi8quD3SL8DPcIdA=; b=Hy17UGwIcIG8QOFkaSRKLBwDMn 1+k32rZWPKhRpUtVKOxBnvKX9h6T5Rkhl4+GwlK3wTUR1tSPunT+YxLPz6OAjLInvNY0vtkLZpaiu x2Ie6OdIH8yozMNN992as7woueYUPsIKfvFRKb/qe7hLXcrjsZ9AvwICR144LAQPVGfiCNA4dmf1i a628ChI5Q5UyeKBDHcCIOOnYtVz0eBK+PMHCwNH1aB0XAttQAGimG9gm7LQqzMqkVyKqNJYxEwxEZ 8kX/K+xfJfr0IVld47vuVPr+mX7gOMPusH8Ri/TjVud2qy1wNjFVdy8+o461KQ1q7m1S9Ic3gBys/ BbQ5g4Bg==; Received: from mail-vi1eur05on2046.outbound.protection.outlook.com ([40.107.21.46] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ee-000QNG-13 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z9MUwi8GezCFMDtNXk8hQ8T477jioKnMclLC4YqMiy66OdJ5d3YdKL3N3Lsiu2qLqczJoSpHKAB7k6laPSRaP/WR2BvNMSNmP3wlwkOeNiBQTcCkBt4j17APOkagpS5YjltFKqhKNEQ8mT/kYRdQin+UgQOSS3A51XFbLe50nIQCnJllo/2YWsp1QVpf0EHpNhUZd/KQG4Yk6W8jeFagz0MTYwqx+SO9T9jNiKsWOQweg0Rji3Xlp8glj6kEQGHapGArL6kyo3UNbIMD0lTRCxpxDX91+IkaegImuPf5u7ruJQT3+ODprD1iY/XZTWke3/YNQ+5bo5kR9g0zyZDIuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bPyLPXB4J/0iwbPB7EI8D9Gb070Bi8quD3SL8DPcIdA=; b=lXOAYuFNYTcNbEibageCxy3JIrq8ogglM+RFYeqKIOi0M2I+KjYekihNJDjhUdmDs5kvAdOmuid5MJKjIr4MnYs3Lw5yl6p/6CQPNLLLQ/fXdVE5EqbR++qUW+MpBpfcM92NbNyhUCDj9j8dMY/F4lp94noYeHIV0Lm3HiBjsKalHzR4UZh7IiFpvJaC9WJ+MsnuY/ewQAw3k7oq+kY2ErOYzegYr/vliHLF0CApW8UG17+h/kzZLSC840xD+U/CJkY8RHfBPddZYFOmEbZ3wvd1+bXR2p8znJFH2AtDsohg82Ufh2uq7/N4sbmYeDyi9yrmVMwcyVuyre063zmytA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bPyLPXB4J/0iwbPB7EI8D9Gb070Bi8quD3SL8DPcIdA=; b=WgBl+y7y8P6L18RwPxVzcdcaliXGvMjQ5wlzBKLmU7KZ0c1TQbdb5sRB+BEkqgAcwKrUHWHugumHVqgK4ZmhL/j0mvPe80RWmuW9mQkGXiQVFuBFxS7C2tDopntnTxqLodyg6OO8+EHcRPhXWD/vXdF/3TCKtAszfDHUSKNxvyQ= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:02 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:02 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 10/16] dt-bindings: power: add defines for i.MX8MM power domains Date: Thu, 29 Apr 2021 15:30:44 +0800 Message-Id: <20210429073050.21039-11-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 06:59:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35fb29b5-5462-4474-2afa-08d90adc6902 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:497; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s1+SUJUKbUnpA+GDS1rJV2wIiqKwrhjEHSo2xeUm8DyqpVqqjgEW3DePjNGgRi1025nq8d2Syw0u0JBd4IJjHLFGPalyT3PuO/mBZ5kck7fZEp12Rhmkqj+Y/iQ/HbdksrQ0sQog9wfYhAPupVyQFlPwZR+JQNG2plcr5nA2aJJzRZkuBLXxbpPbRV2H4rh1Bo9rcWhIP1dja2TynuOhtesFgm/mBwRJhTV2+4bpUY9/sXjt3gxXKWgXm9pV+yKGq2DadfMRI/OQtiSbxnk51MZ2iih1PRaCugAmGxuDYrMPo8bFnVNcYcMnHQ8IDYicicCCuZ7g2eGkKBTdPItIVnil1hIaZ89asEYsujYXPC3J81Efarqv/2g5GIqDuuVC5Tlt8Rbi5ECulmGHata3z1Zxx9Bd5fvQlQjf02CBpqQ0H93aGleh9sOnJ2HskmeJATnIvEr9c60lTuoqGeaE3kEHtHoPVadiDUKTwQbW2mLonCUK2rfG7ClwsCCoG4Of0XQ60qhR1o2sovfjFsu0lRR7fLvMWjnPQRnT/mrTASIffiYddvF7m1WiuYvh4hUhpxbI8XWN5qRrTqwvEeDTgkJzgIMBeawEwIOn6DTRnMfbawSdTeibld+OzRgoB+fbllbWTJMEmpKOXDMSD4+IBAFVI9EhU2RDuR9sB55+Q1o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ZjEvEvWZcDmDCYGp1qHKpysp4Cd+RZp5wK+kQV7F1nGn2xKabLNCCAZIfXZqX2r1draB0DVC7GaZ/nnpc9A3kINKn0RVIN62Gj3HLDExABE209uvX0D4QWWHljxeg+6B+IyApUb9H3B4hqw/yo6zbHMpd+t737Owt6hK+S/YtQ9U+jft1viE6zIxNuHm4qEnlltko3S9G9uHHhBUTT+dUvUBPs/uaKoJ5l4mZZx8+Xq13YM6cp2fdfkKHsWVArjRh5Tuxs6kZbgAEuVriRpoXfxKaRQsENz2Z2ht2SQRs4xCw3B8f/mM1C5x0o9gAhsp1Nl9EWVcaycYPoBqr4kElGKNgFZ0/S2JazAyaESq3Dns0lvnxWfz/YRnDyWeK0I8oT03Ho6ZIHc40+XNGACXVsLqoIIsCbLrT4NG8nCvglP+oC+Yk+spOCG4eq8vsKhlBd+bRPkX8YBOTnDKMfjKhrrAprHYmZ4icdxvfdTZ/vYfDnf36kAm2RbaN/5DRVOQ39N5LIHuK8zC6fOaJNaxIqV+LXyOkxAxxHM4zFVtypBjv9SF34XKPyTWpqKupTvB3L0xHsolWxQ4trZL3bTw20utZ3b5NIWRq2SUulDmvia+vZYdh344U/mQNCj+cQ0GIcNORpgpfyq1htBcceJZJuDHEZtEDkvgA3rW4+Et5Q+y7wIlJUU/yj81ejb06WPZm97YDId45+/MBCrP7GQ9lis1HmoZWjPMFxMKMvRKvIXFTFl9oTaUmXN1R50sq9v6T9mUxYdZdMOOzzJKRGcpjsK3eebfr4uLZ+p6hObYhALeNobthojT1vZlN9FV2reGZxJ7bju0N5B4m/wIwpNHqnw6HTwE3YHDzGvdpUNMjAxUtEc6kv3CMeli0bFy6AIsKq5w9aKI5AFqV9q4y6MVSmmaseFaIddlmetAXw2TxGhfDZk/GPpb5Pt9xljpizYZVACzHiq6n+KuGoiebegpqmMCFJX5TW6DFsZMgz/XH9BFKBWbq9vlzO3uiTZW4B4bIhTWNg8rcy4mCczimkbnNupQ+8fvPBfIX+lQOBYr+JGnFMmSJgPqfjEbkRZdiZ0v0Q2zZH3BJo3Bw4aj8/alnyAWSGZvxk+8/REgtc9VpzGgnf4RemnzCkXCAfsb8NMR2+askiUQ2mTvQzC0F1bcZozFtWhDPvdf50GZYF+HcEC6GOVndwxj0K/gxSZVuv8fPLQg23cw08O/k4Pvwz+oinpHURHq7Zmyad7wKkp5W3Dm658lN73fSUIIcUWle49BdxrCv/0KSJMhWR+ayr9IpK8do7yp01nTDer7pnd7HxZYrkm850mgf9xCgmycx+qxQKZ1try5SrM3wQdPt8xLsQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35fb29b5-5462-4474-2afa-08d90adc6902 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:02.2177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLCNnjNVT/f4nb4x1KouMziQbTsbCb8+s986BKA7MJ0NkPxu+p7OeHQtb0QG7I71BbLL8wRIUoiKOEU5h/PX6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000008_093029_C9C2AD33 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Adding defines for i.MX8MM GPC power domains. Signed-off-by: Lucas Stach Acked-by: Rob Herring --- .../bindings/power/fsl,imx-gpcv2.yaml | 2 ++ include/dt-bindings/power/imx8mm-power.h | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 include/dt-bindings/power/imx8mm-power.h diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml index 4330c73a2c30..d3539569d45f 100644 --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml @@ -26,6 +26,7 @@ properties: enum: - fsl,imx7d-gpc - fsl,imx8mq-gpc + - fsl,imx8mm-gpc reg: maxItems: 1 @@ -54,6 +55,7 @@ properties: Power domain index. Valid values are defined in include/dt-bindings/power/imx7-power.h for fsl,imx7d-gpc and include/dt-bindings/power/imx8m-power.h for fsl,imx8mq-gpc + include/dt-bindings/power/imx8mm-power.h for fsl,imx8mm-gpc maxItems: 1 clocks: diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h new file mode 100644 index 000000000000..fc9c2e16aadc --- /dev/null +++ b/include/dt-bindings/power/imx8mm-power.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ +/* + * Copyright (C) 2020 Pengutronix, Lucas Stach + */ + +#ifndef __DT_BINDINGS_IMX8MM_POWER_H__ +#define __DT_BINDINGS_IMX8MM_POWER_H__ + +#define IMX8MM_POWER_DOMAIN_HSIOMIX 0 +#define IMX8MM_POWER_DOMAIN_PCIE 1 +#define IMX8MM_POWER_DOMAIN_OTG1 2 +#define IMX8MM_POWER_DOMAIN_OTG2 3 +#define IMX8MM_POWER_DOMAIN_GPUMIX 4 +#define IMX8MM_POWER_DOMAIN_GPU 5 +#define IMX8MM_POWER_DOMAIN_VPUMIX 6 +#define IMX8MM_POWER_DOMAIN_VPUG1 7 +#define IMX8MM_POWER_DOMAIN_VPUG2 8 +#define IMX8MM_POWER_DOMAIN_VPUH1 9 +#define IMX8MM_POWER_DOMAIN_DISPMIX 10 +#define IMX8MM_POWER_DOMAIN_MIPI 11 + +#endif From patchwork Thu Apr 29 07:30:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230553 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCBFC433ED for ; Thu, 29 Apr 2021 07:06:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 109426100C for ; Thu, 29 Apr 2021 07:06:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 109426100C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TNDPkZ5XHF8JyFY2HvFWoXiDZW/Su8mAebwFJhUdxEI=; b=kTNBnxR/M91LziJ56gLlUC19p nT41KxoyxVrOFAllPrfJturGtldcZG5d/o2xn4d6pQACm1YMsx7oRqtY7iEcrn+yIsOlbtCFpauVK nj+vC+wSwZbKFSE6EX3CGdG4cKmSMRFMoDVOwjPOzVM8QvylPI/EkPVHpnyvy0GZuAldcI35Ec7EL ita0q00F7dth/zBVCFRInvZnRf5CtNGjCgiIbQBXs5KigGWanna43wsz5xEdAMS1JobOcBluDKrTR j+LHnOjwC8MB8BZwDZr32p+jLBL+zdOnPmKvX7UWjjr6V5qisxaDj2rVBehqdT7zK/ZQEBc0mwah/ mnwUUedfg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0jD-0058jG-OC; Thu, 29 Apr 2021 07:04:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0es-0057bS-BH for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=NaurbrjLB6nOPTOjFp0Uh8A/qK1LVe3tZ+BjaCuhpUM=; b=jaldHPY7IpJPOLAwDn9RBb5qZ2 Cf/v2Wio9hZLTKI15eGQwi+KE5MvxvKiCVFsHXL/04nwcECdEGsjx7LggYL2/Ma9RFhSemdvqDG+8 OT8F+cHF2jeuNOsm2lE4juJ2/PBzytkvJNM8rZzFuoMAFepfXDwHQKnR4PR7x1FQLAR67PVR55rRW BfaQSZr9ztYe0IgIzyn664mbpm0uytr7EsccGJuav4gk0ZzYY1OGTlbchxoDx0OujK/GikW3cPdpE VYoIHj41rLDuXg0HxEE7+BkpZVtayGVoR3kiSOfblJN2+W4/lCF65BvxqkH5yILdNc/3E/mQ3BAFd jcpXhjvw==; Received: from mail-vi1eur05on2080.outbound.protection.outlook.com ([40.107.21.80] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ep-000QNt-7n for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WrThyt+HR5mAkGfn1PA+V6ovjGeLmPv6kIHw1ekaJ+zBsDg3oqaT6Dn+6oF1DN4lUnUG6Le6TAb3ZWFcyqo8P8YL92vWQl4Ia+zBmdVIUDzppbyyKWJ7Ulf9F4z5bRo+whv/QF6ID+kNKO/UjuX1aqqg5qvUcxre60ruak/Pp3nNG/ipInUG1/my6R5/N2i+jPlkX30OhesBMrVooxFGgg5/pCxGWO1tsyHVwq7zFzVi1sUlxJUDR7fEZRWBbHZ0jQUxfT2GWhuQfSzh5D35382zjLw+9n3QCpKytX4QT36JnrHAuzZn1hWMC+82kzhUVjRmkQVUBWn3QZoKg1DxgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NaurbrjLB6nOPTOjFp0Uh8A/qK1LVe3tZ+BjaCuhpUM=; b=GWe2l7tUqhNOdM5UK9V6/kloLKQYbrb82qyfAh8tR7CYnwpL+G/b5CqdK9MxyFM+xiMEetw3SGWwNl6j76k1QyeN3Th+4aAf5qIBSNi9+k6xPwQXWvFi8Y/Lb/YItKX6FUNLS3VVcgqLluvQ6jn6MX4edtvdRf+I2sfcEvTDusU7RDVHMe9g+i2aoZRIq3sLxRCZzLa1StQcTivHJ3oMp0H2gOAGuVlqljgfzpyNs+vW4kNtlclQ+Z2Qz4cK4FQ0qGqNXTuKMcBamOAiFh6hsVCokKl1wB039tRqM6RQdHe7KPOn0SjoRJftxgc6CMGEdCDZ6SKc5Y7BVjKySqEftQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NaurbrjLB6nOPTOjFp0Uh8A/qK1LVe3tZ+BjaCuhpUM=; b=Q3hIz6dQVazRj+6+bQjJ6qc7jgXFpqSc7/Zm5EGLH2he7jURFjWpJDvftttRtIY0Sbx/2LRoDKlw2bIIKHFRvTVBFJ86MWBnpaRbha3TcjthK0ywXjd/h8+7HUfIwgA7rvsZj8tpp0Q73MvYEWjiOFrScLCIVPvwtztPct3RQ0s= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:08 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:08 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 11/16] soc: imx: gpcv2: add support for i.MX8MM power domains Date: Thu, 29 Apr 2021 15:30:45 +0800 Message-Id: <20210429073050.21039-12-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ed00c51-d805-4a0e-86ef-08d90adc6c5e X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: az0BQV4d/j99vXPHY8bOJMGJ5gAUOR2hphhpWX7LEmJee3NAukCH3A4rbNqluYyRcp3mZDi6DqvgO8BJVq5a2yhB30yorfQHlYnv9dCPKB9JRRGuGP5q6+/h6Q6E9tL+exWSlzAS5ei8L9zViDPR9rtJ8ZhN5zHTKZT4XrbIUQPVP4bKvS6om2+5yv4io913w09EsWhUBSZXTUAhLJOdBHKLNkI8dNlQvTAkcJKhB5qubQFW7/KVv3lMzCzOUbDGIaieP3cr2kOwJS3PiKIJZfr5ZvPk6tW/J/D+Yy4u6/L3/mGkTd1F8kyIsxXuBy9WLO1Fo3UFdZFB3SwJkk+LcPgHhRqlOlVuUwIGIpOhmZ2npVxzbo2+ycgIpWWrHOiPzH2Wb4oNU/12SxcweID1Ye2vxapwx0I/hnPXYqzWsFt2TDSr/r4vYmAIztu8YzUaEfK7xD/DQzVaZdI1/h76qiGCkKbuFbkgbv1IRvJFpJ2aRZGZpnybRaECU9SdU1VcW7OqyzEL8bhlt7LU5zhmLA73rR4Mdx1yadWb245s9xyDBM0d+TazTLOdTOJuv0qAhP9YCnbPxT8tS3s8qzItzik6YXRt714HdlVEFtvU7Wd/sUrnHDzNnl7qch3XwcvEGrtLJQnvX8LAAET2jtUYitk1JoE0O3/WAug9p9Lk5gk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: r8BWwzJvKq4QpkWPZ00DBP6YRoqSzbJ2YCKTvWdaJWr/0/WoEgUsLEuHWjDWUM8tihL+C8+Zq4Lg4uD8pNWIz37EPpDsFcoyTgw0z+gJ7+icns38jcM4Kwm6ojoc+07b6PO8A/he5IH861Ml6s8ba7simjV43SwYhMh782n7HCHC/aHRq7D76qPddQK5yrqOvMOCLMLKVr1q3etpXD5AF/+pLDJxWdi6UYoZ6tlx/S8Qf4ORwd3Tx0UenZICeNgnJDgeWxtvVeWPhdpsoC8y5RXEG3sB5/kerKoG7K4dlXK3iqOLEzxvQAQS1xZmZgGLfzCLGulGiEpwVRvZ/TPmN+0a0+XdAE5XLx9Itx9d3QjOTfA1Kq8cRy0wUY2R4wfD/eUczu+XNc8o7AFihlQHuyhDwn1uA4B7RTfxUSOlqfFaACkqJu8GmeBflN0GLb76JkiUSUhFLNSIry65eVgKJM9WjqUao6+cK52ZcJje46LE4SaIM+y1scT68BhOv/GQIuNNrWlG104pI58+APY7p9PxF/BTRdymY4qWpDMATfZd9e/xEg/2JVnMSR76d+/bDZLD7mQ/rcS8n3NoRuPO076d2mgeCvU3Y0G2uJa4Qwf25uxc4b+w1xat1tHMqR4a3gixIt54GLnUv/rMwblfI2wlrEBwVToFhXM/Cy4bSJwQZsFGGCkSbqbzHoplKviznGJAjQ8CsQ+GjNRL+mR3ERGvu8qbzmv7gk86BP/KsJ/kJ8us6NWPqG2Huetr+OiqB6+Tld2W5jQRWmsIB2pIe9Q39xmX3fmLMoZwX9cJZwRiOs2EnKbO6S1vSsKEXwFoTnMAvwQFDap/t/GZBp3F7fCERfkh2Tc/i7doMSJcYgUodKJMHCn7miByE4iqTRGwZn5Map9oL3oqE/btC2HHRZ/7HCzwviVXsCtOswPVhItAvCrXxcTkKGhHpD2qzdgJBTMZ881Y3kbYdClH1l+lr9xEpkVj9j5S9f26FB4v17rnb7HLwZXeGNTR/+GxoNKJ7vlbGC8iG5d74AaKHAzoNQwbOWHqzjtF0SpY17ekj7j9Me2PzsKE+tna1Cb+sbKhbmurpVI6I1qenZWOnnG8LMn5CwOico/Xeo4DfckhsGv4lKvBQM38WDJmOrudeiYbkcDNXSliSkg2ME972kNG0FjTX9S3kn4CGtjU399DET1Fe8BfMJhS0Fd2k2oSVx+Ik1vK/ztlVcv6sgWA65RrWH7V+hkbo6BmTp1/fghBzwAxyMBfgkaPk2t+qJwLxiqWNnNLheUsfmtzE+YCV4ql+Sa2z2r3CctgogQDJj50xdwjrUo7wjaKx2Z0IebjcNl0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ed00c51-d805-4a0e-86ef-08d90adc6c5e X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:08.0391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: joQhISrIxJTwxCdPj35nUFE64mLaa30VXja4SR8jOB4IWB+PlQOaaDGvKpJQYOyhJ2kWGvglHUGd6yWbGD10eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000019_465474_1B8E663D X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach This adds support for the power domains founds on i.MX8MM. The 2D and 3D GPU domains are abstracted as a single domain in the driver, as they can't be powered up/down individually due to a shared reset. Signed-off-by: Lucas Stach Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 168 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 168 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 4a2c2a255d1a..5642dd236c10 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -19,6 +19,7 @@ #include #include #include +#include #define GPC_LPCR_A_CORE_BSC 0x000 @@ -44,6 +45,19 @@ #define IMX8M_PCIE1_A53_DOMAIN BIT(3) #define IMX8M_MIPI_A53_DOMAIN BIT(2) +#define IMX8MM_VPUH1_A53_DOMAIN BIT(15) +#define IMX8MM_VPUG2_A53_DOMAIN BIT(14) +#define IMX8MM_VPUG1_A53_DOMAIN BIT(13) +#define IMX8MM_DISPMIX_A53_DOMAIN BIT(12) +#define IMX8MM_VPUMIX_A53_DOMAIN BIT(10) +#define IMX8MM_GPUMIX_A53_DOMAIN BIT(9) +#define IMX8MM_GPU_A53_DOMAIN (BIT(8) | BIT(11)) +#define IMX8MM_DDR1_A53_DOMAIN BIT(7) +#define IMX8MM_OTG2_A53_DOMAIN BIT(5) +#define IMX8MM_OTG1_A53_DOMAIN BIT(4) +#define IMX8MM_PCIE_A53_DOMAIN BIT(3) +#define IMX8MM_MIPI_A53_DOMAIN BIT(2) + #define GPC_PU_PGC_SW_PUP_REQ 0x0f8 #define GPC_PU_PGC_SW_PDN_REQ 0x104 @@ -67,6 +81,19 @@ #define IMX8M_PCIE1_SW_Pxx_REQ BIT(1) #define IMX8M_MIPI_SW_Pxx_REQ BIT(0) +#define IMX8MM_VPUH1_SW_Pxx_REQ BIT(13) +#define IMX8MM_VPUG2_SW_Pxx_REQ BIT(12) +#define IMX8MM_VPUG1_SW_Pxx_REQ BIT(11) +#define IMX8MM_DISPMIX_SW_Pxx_REQ BIT(10) +#define IMX8MM_VPUMIX_SW_Pxx_REQ BIT(8) +#define IMX8MM_GPUMIX_SW_Pxx_REQ BIT(7) +#define IMX8MM_GPU_SW_Pxx_REQ (BIT(6) | BIT(9)) +#define IMX8MM_DDR1_SW_Pxx_REQ BIT(5) +#define IMX8MM_OTG2_SW_Pxx_REQ BIT(3) +#define IMX8MM_OTG1_SW_Pxx_REQ BIT(2) +#define IMX8MM_PCIE_SW_Pxx_REQ BIT(1) +#define IMX8MM_MIPI_SW_Pxx_REQ BIT(0) + #define GPC_M4_PU_PDN_FLG 0x1bc #define GPC_PU_PWRHSK 0x1fc @@ -78,6 +105,17 @@ #define IMX8M_VPU_HSK_PWRDNREQN BIT(5) #define IMX8M_DISP_HSK_PWRDNREQN BIT(4) + +#define IMX8MM_GPUMIX_HSK_PWRDNACKN BIT(29) +#define IMX8MM_GPU_HSK_PWRDNACKN (BIT(27) | BIT(28)) +#define IMX8MM_VPUMIX_HSK_PWRDNACKN BIT(26) +#define IMX8MM_DISPMIX_HSK_PWRDNACKN BIT(25) +#define IMX8MM_HSIO_HSK_PWRDNACKN (BIT(23) | BIT(24)) +#define IMX8MM_GPUMIX_HSK_PWRDNREQN BIT(11) +#define IMX8MM_GPU_HSK_PWRDNREQN (BIT(9) | BIT(10)) +#define IMX8MM_VPUMIX_HSK_PWRDNREQN BIT(8) +#define IMX8MM_DISPMIX_HSK_PWRDNREQN BIT(7) +#define IMX8MM_HSIO_HSK_PWRDNREQN (BIT(5) | BIT(6)) /* * The PGC offset values in Reference Manual * (Rev. 1, 01/2018 and the older ones) GPC chapter's @@ -100,6 +138,20 @@ #define IMX8M_PGC_MIPI_CSI2 28 #define IMX8M_PGC_PCIE2 29 +#define IMX8MM_PGC_MIPI 16 +#define IMX8MM_PGC_PCIE 17 +#define IMX8MM_PGC_OTG1 18 +#define IMX8MM_PGC_OTG2 19 +#define IMX8MM_PGC_DDR1 21 +#define IMX8MM_PGC_GPU2D 22 +#define IMX8MM_PGC_GPUMIX 23 +#define IMX8MM_PGC_VPUMIX 24 +#define IMX8MM_PGC_GPU3D 25 +#define IMX8MM_PGC_DISPMIX 26 +#define IMX8MM_PGC_VPUG1 27 +#define IMX8MM_PGC_VPUG2 28 +#define IMX8MM_PGC_VPUH1 29 + #define GPC_PGC_CTRL(n) (0x800 + (n) * 0x40) #define GPC_PGC_SR(n) (GPC_PGC_CTRL(n) + 0xc) @@ -523,6 +575,121 @@ static const struct imx_pgc_domain_data imx8m_pgc_domain_data = { .reg_access_table = &imx8m_access_table, }; +static const struct imx_pgc_domain imx8mm_pgc_domains[] = { + [IMX8MM_POWER_DOMAIN_HSIOMIX] = { + .genpd = { + .name = "hsiomix", + }, + .bits = { + .pxx = 0, /* no power sequence control */ + .map = 0, /* no power sequence control */ + .hskreq = IMX8MM_HSIO_HSK_PWRDNREQN, + .hskack = IMX8MM_HSIO_HSK_PWRDNACKN, + }, + }, + + [IMX8MM_POWER_DOMAIN_PCIE] = { + .genpd = { + .name = "pcie", + }, + .bits = { + .pxx = IMX8MM_PCIE_SW_Pxx_REQ, + .map = IMX8MM_PCIE_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_PCIE, + }, + + [IMX8MM_POWER_DOMAIN_OTG1] = { + .genpd = { + .name = "usb-otg1", + }, + .bits = { + .pxx = IMX8MM_OTG1_SW_Pxx_REQ, + .map = IMX8MM_OTG1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_OTG1, + }, + + [IMX8MM_POWER_DOMAIN_OTG2] = { + .genpd = { + .name = "usb-otg2", + }, + .bits = { + .pxx = IMX8MM_OTG2_SW_Pxx_REQ, + .map = IMX8MM_OTG2_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_OTG2, + }, + + [IMX8MM_POWER_DOMAIN_GPUMIX] = { + .genpd = { + .name = "gpumix", + }, + .bits = { + .pxx = IMX8MM_GPUMIX_SW_Pxx_REQ, + .map = IMX8MM_GPUMIX_A53_DOMAIN, + .hskreq = IMX8MM_GPUMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_GPUMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_GPUMIX, + }, + + [IMX8MM_POWER_DOMAIN_GPU] = { + .genpd = { + .name = "gpu", + }, + .bits = { + .pxx = IMX8MM_GPU_SW_Pxx_REQ, + .map = IMX8MM_GPU_A53_DOMAIN, + .hskreq = IMX8MM_GPU_HSK_PWRDNREQN, + .hskack = IMX8MM_GPU_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_GPU2D, + }, +}; + +static const struct regmap_range imx8mm_yes_ranges[] = { + regmap_reg_range(GPC_LPCR_A_CORE_BSC, + GPC_PU_PWRHSK), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_MIPI), + GPC_PGC_SR(IMX8MM_PGC_MIPI)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_PCIE), + GPC_PGC_SR(IMX8MM_PGC_PCIE)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_OTG1), + GPC_PGC_SR(IMX8MM_PGC_OTG1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_OTG2), + GPC_PGC_SR(IMX8MM_PGC_OTG2)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_DDR1), + GPC_PGC_SR(IMX8MM_PGC_DDR1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPU2D), + GPC_PGC_SR(IMX8MM_PGC_GPU2D)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPUMIX), + GPC_PGC_SR(IMX8MM_PGC_GPUMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUMIX), + GPC_PGC_SR(IMX8MM_PGC_VPUMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPU3D), + GPC_PGC_SR(IMX8MM_PGC_GPU3D)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_DISPMIX), + GPC_PGC_SR(IMX8MM_PGC_DISPMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUG1), + GPC_PGC_SR(IMX8MM_PGC_VPUG1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUG2), + GPC_PGC_SR(IMX8MM_PGC_VPUG2)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUH1), + GPC_PGC_SR(IMX8MM_PGC_VPUH1)), +}; + +static const struct regmap_access_table imx8mm_access_table = { + .yes_ranges = imx8mm_yes_ranges, + .n_yes_ranges = ARRAY_SIZE(imx8mm_yes_ranges), +}; + +static const struct imx_pgc_domain_data imx8mm_pgc_domain_data = { + .domains = imx8mm_pgc_domains, + .domains_num = ARRAY_SIZE(imx8mm_pgc_domains), + .reg_access_table = &imx8mm_access_table, +}; + static int imx_pgc_domain_probe(struct platform_device *pdev) { struct imx_pgc_domain *domain = pdev->dev.platform_data; @@ -707,6 +874,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev) static const struct of_device_id imx_gpcv2_dt_ids[] = { { .compatible = "fsl,imx7d-gpc", .data = &imx7_pgc_domain_data, }, + { .compatible = "fsl,imx8mm-gpc", .data = &imx8mm_pgc_domain_data, }, { .compatible = "fsl,imx8mq-gpc", .data = &imx8m_pgc_domain_data, }, { } }; From patchwork Thu Apr 29 07:30:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF927C433B4 for ; Thu, 29 Apr 2021 07:07:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D7E3613B3 for ; Thu, 29 Apr 2021 07:07:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D7E3613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lv4f6accuF8rSIdD1YE3lTn1t+7EyykatYmYxn8Gq6k=; b=AplT2YSG1xDZq1kZac37i4pEv 3W34PdSfYSy0oK9pah2SEe8zNsKseCBG0d9MqsSHItz2RJcVgzbNce2oat7H3w52fTPxgnpE6oTFs BfK9BGWCVUexyyRcFfuwO8WXwcnUoHnRVWs3PN1RaiFGh7FsFyGGA4P/UahZ41+RzdxbIXczWnuoW cdoveh3GYmP3CRCRCJJod8ezlIv8ksbWKLD3QhurVsSEYUiAxN1jZ8SkLg5dIAp3G/xR+6WEUeI4U tpIz3XeQtZmRXgptjfpt8aLfHpoUzlX1MGV2sF6QdJ4c4VBS1Z20ACRD2hIP43hCPl3XH3oeov4AT g4299265g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0k9-0058xQ-Ro; Thu, 29 Apr 2021 07:05:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0eu-0057cg-0x for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=budKuoe6Ufv0QKJXJ+5Czx7NA1GYxskYolbO4lsYZg0=; b=uJXyw2LtxkR0zadzaCdWgsJI1F GuP3fqTckbIhJo7Q42H76ntqE82VsXJEjaYhQ/yZRCACOs2AiRtyuCflQRDxZ8uVtdleMF2kVDYdS gJr4a10T5pXoyMmxPWNsF62tuWDxlawpzwQ9bIL0w/IbncIJrCPAsVwm93KRUm+GscNE4df2cPVnR V7pGBmAnWhhOifh8kWAKgPp1zuJYNG7jBV7BzEDUfj/E7McjSVC+xVCbP8B/R2+yxQLqwh+TpxM0Q qs5/ucvt5dWvr1jp05eUmX73ze8JFzxqe9XoOt8bBVZPvElwZZSktpPdRw1UeQTWIOyDQeJLLKm2C KPsegZ9w==; Received: from mail-vi1eur05on2080.outbound.protection.outlook.com ([40.107.21.80] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0er-000QNt-Ds for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+55lq9uMPg1pb+QKJvjzxWhUNaV+bqwxosloepZ/Vg3CqjsnUW2zPlUPQvT2FkgilgTxLqs1iVAajWE4/2Gnt28373FOhlnn3atxXALlKcsNPnhkmUhLBDg0T2XmwmnwuNVMJUk8x2BSFqbN5J8WfrUnHCEey3E4ROBQYuNBb0iS1SWW1dY3MmCrki/xdbE5wemujt5/2E0Xw3oHJLDIOwD6Jjw2CWV1/1MgyzBRq0JKWkA/CAunRG6HGdHf+2mAR/F9JweAsQrSO3P0qfdNbPNhF/GOa4Jhss+/irv+esz+C+Y4+SrCzir1boNNJvNjV0DoqPSjZ75hN1SPE93kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=budKuoe6Ufv0QKJXJ+5Czx7NA1GYxskYolbO4lsYZg0=; b=gNMCUxyqJWATS+yGJj9pumPo2PXV/bqOpd0hmv9F1bFiSSDDsY3rpMzDEE28HnTDSSOO9wu+4+WKy32p0qRlVeWyZTIBFXdyF9fgcH3dDAnzr8O5M/cChN1oR1SlvR5G/eFlZ3z+7iqgnw9DATZKGCzi364xYXqz71TOOmeyLybF7R+KuWvt6WREJ0EFm2Tuibz5B7Um0RZchaMQ6D8JuZv7+q+umJ232mvF3C1ohnQMqLdeF9l6Q5PgiwIUCchnPMk0RvYaXF/WLK0gEQmqg22ClhjXNWEr80YTn06kqHVUG0VGlb2BqVieJe0Ena8+WHFzWTt0w6Q15lqXgWFrOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=budKuoe6Ufv0QKJXJ+5Czx7NA1GYxskYolbO4lsYZg0=; b=TfN1bmojuApVy/S2rOqHE4xKblVrWrEFkKrVoK7jnGqvEt7/Mn/eRD1qjD10n/miJfAnu+N7IiXfdSLZ9QDWyjHD5F1EIJdE6mvhHKoyHtS29KzVaBBKlibyqMhCnwtJK0poj1UQiocrOIuwTXGUcbdFzhSUKedv38+mfQVSGJE= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:13 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:13 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH 12/16] soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power domains Date: Thu, 29 Apr 2021 15:30:46 +0800 Message-Id: <20210429073050.21039-13-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 122d1fd7-4bad-463e-684d-08d90adc6fd7 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AE/FMBq5eqPcXnamE0Q0wzOtqVfBt23Tlwfuuo6MoV8RbUL5SOhIJmbYVoxpnRhDiwX4XhUFvQofvCha8sGvI1XZnWaCT9mfCDhI91I5QmWenoSRgNGyx20bN9JZo+o3HmdD+nUVpWGIaqQSz7Hvkv7wrsxmw+DNoA3YeuHU8/cAD3PXff0AnrjIoTd60UyqEqdof0uMjg4YvO9PGHWl8K+XYd0Bt43M3d+4LpHg52RGP1yjypYH5FhTeHSSSEAGnM+EB5+PcolnSolLU3j6Kcr0l/OzmD0eBzX4MSR96+qjcVDQOaRMO2vRxiyLfAqKQT25SRsJsoIevX80/fNKW5o/wSo7UGZKoSDaYj3Qp7vMo52NuE0emlLyagtj0krN9/zvOK7i7OvSW0Vm6nu5YH2gEtr3uz5ZwroeTwiM2IwuLfRdVLN/Jtejxas8r+rDo03hkMmMKB/l2K2svSKnEdSCMfavQ0o3HRTxwggCnAvFDTEX0HAOT92HvWWQcQ8YhUTKT8vnU19f1lcG09YFGac5Df/PWZP4iaxwABcCgxjECve84ebvZyDuu+loybCZTM7wZqNrVTa6pxPywhe6Mu0TUctB7vwdpbSW47wW0Ofin8NbrzZmep0r6nEEg6DwEDJ7Ky68Ozg2aMfRM/QY2rB2LYAjidJ1JRNB8qPWOFU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: /kAUDZPuL5OZYTzi83o0YLM7dSzyXpH3yupSfEzdy/V5UAeRn2Lr7iJi3fL9IcjvDTvZ8S6BQE8eptlCqrKuSV0jrNXrReXDMb5rBQLQ1zq78lwY9KB+7fz2v6slG50ft0J5Av8Cw9p0M/D3Y7GLTd/qjpaGf9o2jtzyGX1Oqadh2P9wVsld/vukkf16MkWs2mX6keH0XEwdmevAIdXhwOQj9/j2A/KKRn8Q/c+rt2AQqX/rsPi7M1DUCasMlwrfZF1JLa2UVTXOcCF2LkQ6d9YOLngeO+/m2YNegbuPXad7wRaNA2FdlYMSyRxih5YP93+oCk0+jQMU3L7vxOvBTNJwQDqNiMRpvVsbGMcBIiv7spbiSRwyb6VouyE6W2QvltItg4wMEk7mI0U9gsw5LnX2VrRromvlJ2yKPNrYdmAFWvvj38mnBfkMr6kMWmQcydKZcYyWKnsYXTXrr4cAwQ5qd/b7XegzWsbYnGABQ4LPNo6LTmx1S1S32338fnAjnuHuu9EWT4Ri67/FaaTD0JDWxa0wTY4EA303OaKgt0EdPbJMxkiqyp1fIBixOqmIy6H9YZeHyeQQkrus10cgFLzmmGMWh148CUGkO3SgcZYLNL3byrWlANt0ZxEt6C6Fm/SXJYpuyK6nBNcBvZeNhHlzwM/SGPMzxA9srSMbm790qefd41M1/yWQ58R6jViR4rPqT9DQ+xjm9cBxZjhUtZWeT8cOSqJotCzL275ePLo4cdBkPiRiauS2ShYRDhqa73d5YyaEG6ewiYSV8JitzMVDXfupbsMTqrROT1RDmunKW6roewFDsIbESskKnujwqyo5Zn7f79Buadsy3bn/cdjLO0zqDhFLPo6lTBIFQAd1T6eyib7bCeGI0WTVsgFdpIkah1f21Vg/Ne8pDTVLqs1vFT8K/3NVxRNxfPC/z8hUg7XpiX+bxoUU3dl9uan7JZbAEG31O/yxHy1qBXvBCKbB7BmDLM0ZC2HYX0xFBWEIWt5uk7HlAZHmo4qjqhuyyE86J+niyuD3AvDj6boe4Pj8vBZxxhgqGQ++kB4wlpa/cq3EVNvNhklqQBYOw7naLxynZvFgEYeWwspo1x4ucWkXCh86kuTr/LRu6WSQXT46y8Tonqv/z22D/hYzn+WO7ojFApKHEx8CWG35lxaD9KCDYUih2P+j5Q3g/aomChglSXnOA7cEVpZkFv20ti4WlUcqhNJjV8O6ImSkDYoDKxL+rcozzcFafQfA778nvO3Hq+nTHoKMQ7nZRHfZLhrXyEVAL2QMRiq1OBoTVU4ztsrpRmOSUCxP4Cf/DAVGFFUyhG+LkXVtf2KB7m8B2aIB X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 122d1fd7-4bad-463e-684d-08d90adc6fd7 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:13.7295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 09Equqc8t+4hFKlRVG4GMYbKUSdzbKzAigsDvPwTZtTPHLp77kJZF2wh/ad7nxidCuT3kwaVXxzp3B937W4Jbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000021_491883_0D345CBC X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach With the BLK-CTL driver now in place, let's add the missing domains. Signed-off-by: Lucas Stach Signed-off-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 70 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 5642dd236c10..42b9be05e1f2 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -646,6 +646,76 @@ static const struct imx_pgc_domain imx8mm_pgc_domains[] = { }, .pgc = IMX8MM_PGC_GPU2D, }, + + [IMX8MM_POWER_DOMAIN_VPUMIX] = { + .genpd = { + .name = "vpumix", + }, + .bits = { + .pxx = IMX8MM_VPUMIX_SW_Pxx_REQ, + .map = IMX8MM_VPUMIX_A53_DOMAIN, + .hskreq = IMX8MM_VPUMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_VPUMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_VPUMIX, + }, + + [IMX8MM_POWER_DOMAIN_VPUG1] = { + .genpd = { + .name = "vpu-g1", + }, + .bits = { + .pxx = IMX8MM_VPUG1_SW_Pxx_REQ, + .map = IMX8MM_VPUG1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUG1, + }, + + [IMX8MM_POWER_DOMAIN_VPUG2] = { + .genpd = { + .name = "vpu-g2", + }, + .bits = { + .pxx = IMX8MM_VPUG2_SW_Pxx_REQ, + .map = IMX8MM_VPUG2_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUG2, + }, + + [IMX8MM_POWER_DOMAIN_VPUH1] = { + .genpd = { + .name = "vpu-h1", + }, + .bits = { + .pxx = IMX8MM_VPUH1_SW_Pxx_REQ, + .map = IMX8MM_VPUH1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUH1, + }, + + [IMX8MM_POWER_DOMAIN_DISPMIX] = { + .genpd = { + .name = "dispmix", + }, + .bits = { + .pxx = IMX8MM_DISPMIX_SW_Pxx_REQ, + .map = IMX8MM_DISPMIX_A53_DOMAIN, + .hskreq = IMX8MM_DISPMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_DISPMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_DISPMIX, + }, + + [IMX8MM_POWER_DOMAIN_MIPI] = { + .genpd = { + .name = "mipi", + }, + .bits = { + .pxx = IMX8MM_MIPI_SW_Pxx_REQ, + .map = IMX8MM_MIPI_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_MIPI, + }, }; static const struct regmap_range imx8mm_yes_ranges[] = { From patchwork Thu Apr 29 07:30:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230557 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D4FFC433B4 for ; Thu, 29 Apr 2021 07:09:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 498176100C for ; Thu, 29 Apr 2021 07:08:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498176100C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oP8jTtSmjiulizYsPUtg839glSN7CNA+7wAJ/YCXsBM=; b=P2ntIhK9HGZghHf9sruH5RklB 5Oh7RQxs/e0KImuj44FmFykEViz83jXn79xLOVQrYJ8rfC0AUJJgWjM8Q8QonQ9Ss5XYxZbbLBuh2 DT2JvVWo2hEb80w885cqz97zvOOM8iqK2VSyPvoQtCG73RbOPyirOzzoT/IQWALRxzIF+y8ZUbpel 4bc7knxi3xE3wPvM0QKHGNa4OCj1eVhIp/bzEulh1A2HmgOHAtiI53csJvlaKdtFYoEwaxs29DhFd M6+bq51bkH3YFVDgi8dEarxjScgclGbYSpJJIH9d1BTKOExyADREhptpOUdvh/y87T3rr0S8Ez4K9 cjK7tGm4g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0l4-00598P-Q2; Thu, 29 Apr 2021 07:06:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ez-0057e6-SA for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=ScCgM6Xj3MfaNGdmWO+nsQf/c4MtEelA8j3CWroZwTk=; b=fz9hluHsZefy0o97mXp24mn4qZ gzHASNoCsHTPig+rJRee+m/d48nQkU3VJ88ZS2N1X391XSu8kfUBJizrYUtvOfMMC3/MaT+kEsLc8 b2YzKgxuA8dmddywjcUXTL/6/Qzch9klOUYWZ7PFarsqK8ZSHm12vIlyiuK7S5rI44xH6XkDsEXa2 7puBouxlFl+5hT1Dr5HY92HAeiGpsa5e61/4161PazX9SP0NxGW5oYGMMDoXdl2Hvp1PZX0gTT5sg iyFBAMuGGzZthyr4vB0SNiqIU78BFldo+zpSU/eWMsxl16BCHaqwXdmD539SWrJvoqIC8d3Q1tYgz eeGGnxCA==; Received: from mail-vi1eur05on2069.outbound.protection.outlook.com ([40.107.21.69] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ex-000QOt-Bs for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fS19RF/JIGea46wxVz1SdrhZJph2D1EtcJH5yZAOQs4dZs4rOFQ23ZeBibYY2GSXRAAo1nL1N1bcR7rNncwg9/MW64DgneS3EwJ4vRClcgkMnHStsADOa1DDpMg6YgYY8ogw9ge93aGvWfNpEw+rljkiz4S5tEaTDTrtABs2mOTOLMInhoShPitAbSeuaAMcmWFIfQm52rqMpJTHZ+Nq3RbeDWyyTsTNYrbpNJq0S5pYOqp03vSBKgoioyOHUy0rVgrijhsP/eXGvVMBqssTDbJKpHggSURuLA+bRpoihtLqrLIjbMHs6nTsUNYGdC8GWhI1WKT0yzk7qr8/M9iGXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ScCgM6Xj3MfaNGdmWO+nsQf/c4MtEelA8j3CWroZwTk=; b=V1cRWc0d8ImI4Iz2JzIgQ1mqFv1I+QQd8lw1afg3o+kl6cLd6/OvKB0huJi68SRtCTnDy6tLpLVUdyy2JeRywZTV9C9vW0esHb4/UHG+7SRs+a54Ec+5FUJjHuMiSN4kXd++oK5R3WAVD/A3X5ga0tQyqqQXynx3xc5lw+5Inz+YvT4tA0j0YISOJRmPPbA0xdyTJpZbZ4b5nuFwUwARwe8zn/WudNDZctii15ZzXwl4IXtcsRwyahWRRDiKj3hLTPthsOVOj0/DzBUqoRzV59HHN7nru0zEBiL9nCr8NqQqC6vT9BaK4RbEfiytRgzryxZ8OCaE9dNKcaR4FTkCYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ScCgM6Xj3MfaNGdmWO+nsQf/c4MtEelA8j3CWroZwTk=; b=V5mlwA2XrvREJ/i9E+ED27elRnXvzIKGdpDSkwLKWhNUkrGI+pE4axtpWDJwZ/9ghKY/CJKKkAwFO5Om2kkam3yoNNpH11fUjEStGfiiJp4q9fM0typTNqa0+nZrHWh91EqRdaynl7D5YbURwtq7SXXiUmgU+89toytCmkd+0ME= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:20 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:20 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH 13/16] soc: imx: gpcv2: correct pm_runtime_get_sync usage Date: Thu, 29 Apr 2021 15:30:47 +0800 Message-Id: <20210429073050.21039-14-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 615bb2b2-6687-4cd4-2a6f-08d90adc7367 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:989; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WRVRVPHhcwGCdhBGX9LKXXBsTw67Ti6a/Eun1tfvgSuLI/ogJ4gqKRj07mbXX/rbj3PLfvgX9VqXpshYuumy9yHmO+mklPfRlgHbximGMSMjyuGfAy7DCOCRtthXF4ubvs+Q4PN9i/L+rn1IRMi9tnaJmEae4b2tXlQwI3wqjP+6nBPRGHXYxtyjkkBGIItX/OB3bQ89KAngkql0aguhX6VsYmhyTMH0NxyahkDa4Un8bLPT+xfiZPSMOMYMQ2qxPtaljLnRuDYDWGxm0phzP8MV9K6mVm1mbVkNjNF//irAeBR+QE2wjxvAGzgyb8sWu6MXy1dSYoqsCtf/YFWQilwWakYuPpgdURgo6kvVmb9oBRkxYHRxjzmOEQ/gwjg8uXVNinNVEwxZ2grzrQnU8DX6MQaNKwi/2uqSolMmkS5zvYLRzRIdBTq2mC2yAjtuTKrzJJ3IjgJV8UMgvGIcTHLrLCnZBKWocbylCZ4NobFYiHTKO2axNfMIcnA/85g8k7lwBR6jLwDUftbifuw77xI1sKkCpGRHm7Fsc95OOCB/03TC1Oi7ay6FezlLyWznS8XWEwpKjRP3AOvzOnehSBCUGcBVWs+TEqM9aspEFl3rhHKyLLSx7dlObbEkPXDcz6ceKaoM6X53zXom7d2B8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(4744005)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: AlMN295AY+G7neEculDspmywES2brq4KqsUJMHPfb/0U3OiZwVxd5VzKRHNxvs+O0D4Tib3jupFIsAGlhSPK+Dj93SEi19xfhewVREwkCSw67/XPW7ikfS/ymA2GEieg70/58tud6fdorKlhqa8L78xzc5Spkq1iGKstCnCb/IyV+gfy0mU72tPoFTZt+tfm0n5SMQr244AjVHKuAJSimLvnvezlPzeBGgthV0QMxe5ucnG26ZmZY+eciaElAEd7elkqdD9sz21zC8+hYtpMEr/txhC9zpa7hSRK8L0PNqA27ZXhNcgy02v6smuTjAjvflh94MvzwAXBho1U7jWa95LQQqBHfMm0dcHC6uzH8GnqS3DW9oruC5rzaOCmwrpUHSY2XZwszxcFJ1g/xW5eZwJtFznlSKCvO7kSSKSsgvKg++8TxgUanZRhE6pXwVcSCEOOF3FfMgL1X3sOtOFEQJZNoYK2P5Qvmly9esRkWw5p8nbYZijYvsRhdbc8VcQHJuh3cMLKouRjjOo1r/VMY1r7Qp3Kp7Rrs2TRo0XqL2qH8cSaQLbuSLHCBwP9bW8daRmhu9e89xyIWTk5rYACN6oyZzZV3izdX5kTQRFu1ToDpMD/vSaR7yrPsU5E/6e/UTzS0C7n6XAywXxGWngCeum0IPJfWHfer74Dzh/7vD8b+kCMf1uc7Ydacw729vR7AHVGNQSgpdEzSo3aQFC26jnmBDP+26MdoeAs8gxuRXwQDYUYhOaPZXTnmY1XlzdBSFco4kfjWqVTWnGg74JEu/IQJ4lD+29xSuYqj80NxnJ+ST7ZckNo8lGUKBUk92BUubnvjxJ9hTdOqemR8wYZ1EfoGrrLrIJBBMOQo3MipjOn0snRY/jCarswWXFaBhAPpgg7xIHdxwH0yJGNkjJD1P4aGTHcNgY2iIRYvBvszPyXPTQy9anzFr5m/XH+X9yIMgkkZjgW+nOpaFCG51XT2JOd/K9f4f1oqkCmAlKlageQS30ckYrlg81/NbyNvohEB4Li/vhfvdbnu/aS/huRPu5ufbl4W3CLbJT2sRuwpcbFKAm2ahPr5/CruIZZ7Deo7r8O2NknUZKLNh0/b5xTGwLXSC6rEb5CWxyrp0kWi87MMY4UhTJ3iDUeZT9ULg0Ot1n0iXq41MG8EpSJUf8Awo8M7frkIMGQ0wy4Qq1Wt22feaM+i5aj6ayfzRfEVlq3rhcpYLi0JExbY/pZSiqPhHpMgmOU+FU9peWYgX0F8BIgsFBXkVPgQXlqlkIRlcBm/iGYDl/H2SnemJPyT2e8N8eb4QnMH+4WN3EpyCCpnBVb6KsQdA6Orgp5tPEyVKce X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 615bb2b2-6687-4cd4-2a6f-08d90adc7367 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:19.9207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t4uHnv+aVGy4Bw0g+MLaHX/VO+yZ0aI9JnH5kwcigIWroM0O6lBs4mLOTOgYj33P7obK57I19SxU+zses8Dr7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000027_429265_E2E3A092 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan When the return value is negative, there is error, otherwise it is expected. Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 42b9be05e1f2..d2ce47a5ebad 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -197,7 +197,7 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) int ret; ret = pm_runtime_get_sync(domain->dev); - if (ret) { + if (ret < 0) { pm_runtime_put_noidle(domain->dev); return ret; } From patchwork Thu Apr 29 07:30:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230559 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A90FC433B4 for ; Thu, 29 Apr 2021 07:10:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA327613B3 for ; Thu, 29 Apr 2021 07:09:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA327613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=igtf7IYDxUuMCnpOJuCtBmjuHTcX+GLJtIPWwP0XtUA=; b=EZN60+59zgj7vIxCwukxsSs0n NVGLzn2F5RR5alhblRAQQTC1BYKgH957+nDqoaBhbb12dK9AmmNyfr9zK8uxv4FIiid7yuXXtbXzV +RBsAj4RHbgmOMW4kMOMUAkK/FQDpaEtoA4NbWLWpyschCPYifi5LfzWUpT0BgzKNgxU1LMj/Fdou hnwkYozx8c531x9LwrYxBWrjcCRZi3HRa/z+w5CqQrKaDJQXxfVzWVIgeY10hF3bnkFxnK+zHLS7K 5Z4vQGaQrg7eRHdXfIUZ08UNZzyPJjm2YCSgI9WpUD38694DZQeucENSaC/2xiTGLlT9PQR499hNL XY50E9T6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0m7-0059LA-9A; Thu, 29 Apr 2021 07:07:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0f5-0057fs-TZ for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=RHBirtV3NAhw3AiaHaqJ6lCADJMK4dINT7svEGoqJ+4=; b=acXlzYKEBWynlpmE/VPxTb9Ice +BtcgcixPKzuttcx/ow0bhlpJe9HT+yA0Qyp7SdQMrUtH9+IQk0R6cCjJLxcJgpnp6I58xagrVpCq gxvUKA9WBJonkOwaf5Qvfr6LkxT3ZV+cGaPXzQhZW6Mlrfc2d2xAP4sE2Dy26IZCo7ZaXjK/W1xJl GBVDHVKLL07Pra5nxrWuv2blvCDjegy+8BWGDlQ5+LXRcYQxVWapa7EM4xi8X8aOgBhlCDmpdfjdl IkmrxpcJvIvjyrfItHLtvVGnrfq60RDRyaSflEsQeBWA0XUJ1xKtKDGSc8OFosnVlH1W3wLi9AD2D qd9nmM+g==; Received: from mail-vi1eur05on2051.outbound.protection.outlook.com ([40.107.21.51] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0f3-000QPN-F6 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3fzDnKk9YY4eLok2lEhRGPMo5xA0dtDrEHuYuQToROPisHgB3RNgwC5Q2vaek11LGLr+QNxQWl/3YmZ0O2CSP5J3YmjsCf4trdJhNCfX7ni+9fJumHck9JBqo1uB3yLzrXUvxHPjDENb9mpUotqI7D+0uxtPK41dJ3zPGF/oMZmAKN4yhBiCBOhP2myDmextjWhhw6pSi/0KkZHuE3q1r+ABwBXhmDoJaGvNB7DH3WWNjjvxdca6UeC9nPpfovP7ih31IeTv7wbpVHQs8V+6bN/d3JYeaAvZ65VVvJMdeeZtRyHswByRM4AKxP4g6Rc2IvU5Mw+xIMi+M1FCA16DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHBirtV3NAhw3AiaHaqJ6lCADJMK4dINT7svEGoqJ+4=; b=hQYQZ4cIhqHRCCs0M0TWPds0UGGaWGnNPeiMmBdlnpcEXEnwHrbWUWfl8SjjNQU2CWSMCac8adf+1lV86g6X+G6ApGcZzezP1upp9S1Cpgc+Qv4GZSof+mzQIaS3zWHJ3TzXDHjrlc+NcnVhwkL4PQxaN3MHLuT7NKcbZYwNgIohmLME6B0axvo1UUbEjIKMTmbkE7r6iQuvNxBkTGN5zyuRw0Tp9O5zGsx3gaThcSIS6dFDj18Jc2LSbjrCELJUKtosw9V8Yh+WMl050p0/kGQO2ne7UCuPaP2mhRpEKUVDNgc+bWfX7sDzHYhm4L2kxnr8QXD+fdB57TmhPNU4xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHBirtV3NAhw3AiaHaqJ6lCADJMK4dINT7svEGoqJ+4=; b=cO5QRugmyT8ryc7LyFoP5RGTO7wAjAXbP0VDLfwtnBR7w56OeT3xF5UrakmM0LPKE6oGT0ImW9QM7ciD/ofrro77IUiOBJipP3y9F5q4aggb65lIVw2UJtitfBRFuHK2k23Hyl+3otGji4IVyyQJjgWrMtLhIvF/un6eZtSreUk= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:26 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:26 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH 14/16] soc: imx: gpcv2: move reset assert after requesting domain power up Date: Thu, 29 Apr 2021 15:30:48 +0800 Message-Id: <20210429073050.21039-15-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea4b35c-90ee-4a94-b26e-08d90adc7722 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XHwKodM0mHdLdC+G92jbKoGVq+9Y5K8GrlbiVjY34VmG3nauwNpDABZocX/0W7oep/V41jJD+Q2yw98R1mMCIaC4G2BnQDIKQcGA3vfFjDXYU9ZdWc+N/mWsK50sB9wb8mmLvowwyuxDA4w8G0bqkQBTJ/GkVSiIqmQ7C0Pem3CMVkoJK8ApXATqKieHDmH8tpFekKEIv0J3EL4+Z6VzuMDHPX/ZRIVYk94cTCdk2cq+iDshTl1wown4MDgY6JiwNMQt8e+hEnM5BJSa88MGZmB7EWrLjvr7rHEc5HC8dpyJ8EMwjxAPzSCsVIl2CzTM6ngBxxUFiYdlCMfWE8vAovH+jtzS86DeBGUQ7UZ6oj52gpGolzB1DZn9ovUQORr3T16CLZyofmZEQajEKkX9SqF1eSggnlvL/ZPo0WUsEbzsiZHWG3zEYNkTILElTN0XU0EeE5o6WDgJAudiP7WBhU1JlV/MryzS4c3DMTUkwcR+bQrETPFdvWBVBTgv3wR4LGzA/Qni4RxaRLZKn+bELjf5I+sb99sUp3GaBsbCs4qmyYIdwxqN4sx2NoT/BL83DM63rp5Ytn+uLtwNJWneRxjX0vFgfxBWJifTqFEzvx4NvlLkJULSoa4zQsUiM+b108nPMgyzLZxInqyswXyKJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 5YCld2DVre/yPv41wT47rLAH83fjQADRvf44H04gSlRX1x513y3LBYPC/wOmkNFEp5K0PItR6WEf2OF0UmYdu82O4ZEX6ooXQto0yp9eKOzDqXOp0+8wftesTVhfMhfLDHqFLDJkesOJLppvmmOyZktiZ+jERoVWvDWQOvXAwUhniR05BLYL+9PfJcDLObP6kXHDutfhX1QIITEbtLp7/PR72kFYIdu+4qdtJoEc/SU1kcMriv0gq7YQntaAYNU/CqHzbMVA9+TVj+ju27Nk+byvPikuQSOlAZwLQgiTNucOauiJtYl3AaouwOzoXrKrrTmEetIfSb0FI66feNcgovI2AGz4DYNhMktcqJFiCtlmi6cDElv7d3+WJUDopj1NtNQOulyB1dp+EVL3n0Ojda4CIBDgYbkUyxZwPh/Ja2Gh6m1G+USE4OzMFoiwP/Q16sUoBnYudsgcrEzkBjMeEPurJvS72BermwL+vXI0cWalnkTK7ewgc9JMK39LBzNGjARMBSwsgfbe5YPVMVsRb6p77qUE0F4LW5JrAmPhhjk3mVU41QB52A63EubEfis0XzLWWefg4STEy/QuSUwLwoFVxER/j3v2DnDfnPzSmBJsSHHuJ2FXIet3LnJP1prIuXglB8DDt7bjkldncwuaUsRDy7H396QybuV96VtbSJw94zOB1MQ2PHR0N0/Nzr4mGINl1jZfVawH0n5mDJFfNIU3Ff394Bi5OvhBmwpulluSHZJjRP5S6gIVAmy9NDiOJh8lxQRo/RSuJhKEFUrRFzn6CuKeFy5fVLwpODn1JFraDxetuZTrtj+z31QH9rmIhrQGTISVxHq9eGpOsno1NpD1WbCnblwaPduJcbXnvGCWR8mIPa2bBM4oyoxmSC/4nNTcaCuU+7wtzhwsQecOoN+o7pR+UteUkhiorHNIwtGBEECt0hxE1jPfU8tb4ETzqfZ7Jo7ee9Ber9LCfo5kqUjBWP6j3XAfSHA2pdFAWBPGUxxKxprgqnsEa7OqGydOUfi1vgy/+FF47AFNUpilkH/o96EgmDxyoHFvfRAAIjsmzTDhSFxC9n50G/gC/RHBmknmO1UDc3OxIWlY0C3hHnE8gS+NidLVlCJcfFQlLdj6PQQx3tIL+d4QQfI6u57lJi7dT5oK93pK1vnmME3Q5G6ZOTc44u2rZVTVvTB8j2qX9dw1J1+2mBiZwqPVZnYLlub8gcrZOGeOp8BBgsGYamup40yafrJ7P7Ax1MYk41+QMW7+TDofBYeFfkW2JCTxPFn2igCxrcp4ijUSkAded1Yn0XapHqH+EXV0tmi+xQuO/+wiHreWgd5d8pL+2nW+ X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea4b35c-90ee-4a94-b26e-08d90adc7722 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:26.1179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F6Yw0U72vxymGgVwissWcSWFEGCAs4UB4kENe9pJjAtTiy3o0cvLi/4QmIidf7dWKWV7LbsSE/ooUKzUgPkpNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000033_529669_A53FD277 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan The i.MX8MM VPU power up sequence is a bit special, it must follow: 1. request power up 2. reset assert 3. reset deassert This change in this patch will not affect other domains, because the power domain default is in asserted state, unless bootloader deassert the reset. [Note: We expect bootloader leave the domain in asserted state, but this may not always be true, so we might need another solution to address the VPU domain requirements] Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index d2ce47a5ebad..072f519462a5 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -217,8 +217,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - reset_control_assert(domain->reset); - if (domain->bits.pxx) { /* request the domain to power up */ regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, @@ -241,6 +239,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR, 0); } + reset_control_assert(domain->reset); + /* delay for reset to propagate */ udelay(5); From patchwork Thu Apr 29 07:30:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6570AC433B4 for ; Thu, 29 Apr 2021 07:11:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB1D86044F for ; Thu, 29 Apr 2021 07:11:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB1D86044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CwX/THavBAX+o0HD4L1PB275jZxAwLDuzb4z0IpjT1U=; b=BcwU/8mCp2Lcm/oZOac4fn1Zz qIc8llZbKNRf0ztwSc2KomYDRRD9SoaducCX5+rUrAncjymhUneP74qRWX+OOfAVTagRUMeQ8Bqj9 EMyofJcbOjxHsI2G5+dKShp2pZDw9nWzd6Td7wThsCJYRJo3TgQx9qSsH7QAD2MHLz/cXp4+vMqni 1IfFk+8FtIO4V856W4eVXaTWBmEL/QP3hskkMFcm2Kx4Cv2hQ14gG70vN+k9EsaUlSnPVRApghvF/ PN8o3CYyRb48HVfw4rulZqZvdwXm0PLhKmO9ze153r9ltxxlK6eBrWuJg4igv9984T3pqcF2eimVm KnHAgzUNw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0n1-0059X6-VQ; Thu, 29 Apr 2021 07:08:48 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0f9-0057gw-VT for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=QyVFzo6FDwBuBULigZlxWIA8Q3htTSbXK72A7UBeEMM=; b=HRVjFb8BjzIqp1QgBt+FGj+pTQ +rLCTKHD82+9mvpzjbHAyPAT7f/+wmN0CnpZy+cXTl30zshSHNpm4OjReJ6ZIYHu9lJcHEcvWCQWc IaWIzaHuVlAOIb61GlU1MNGRElhsYV3bFrll0FXvkt1AiPvd542QMEMc4NgtMamXvYsAL/PAW0Haa unhq7Oopc+byN4t8kvacGNPXriUCZ0fPGcLS8xTXXFP1WoE9RcsUesqlfboZF3RAPbLEh6sQJaE0V N0daiHPbjHC5dUNgioHEitGbXI+tMv55Ty9pvwj1Jdhlc/0UGuuMvBC2B0oeBzoijwmC73TYPV5fw YigK0QEA==; Received: from mail-vi1eur05on2050.outbound.protection.outlook.com ([40.107.21.50] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0f7-000QPe-HH for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SsSbqhMhGbkreTzi0rSSwWrDGlIVWOsdYLf+k0sd93swbrdvusFpXOy8HHNPp4nU9fueuf4PXSO750PIuzIbflE3XWkQFHPMOekizHlLWQ6Bo5TqofXk0wYBrN3e0lBs2zVe1U49OjOkj6bTkMAEj8YzbPZ8sDwf310Y2Clkfk11/fhyYmBlOkVNM3Yx0zHK8vFI8RahL9V/JsaHge+txUasGlSHoF89JPfjLDjgg2XlwgaNQCvW1or0wYTKO+Ehtwf1zmWlyNiVaLVtosZ8Hwkbs8SevhN+1pkrgv1KHi9buuMMBUHcnL70ZjTOMmcnj+5zeROOuUeNu33PY0+EhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyVFzo6FDwBuBULigZlxWIA8Q3htTSbXK72A7UBeEMM=; b=OVMuiWIgTqvF44VlsPp+R+g93AaCKdxXmCNZz/OUf8P5DA2V+M+n5cMJLkvwXdakPA+T5NQJ5auOKRTKeMd9mphKJ3PWmzIJ6tC1kc6tG6hEZj4OH+Ktzu/1ucyik/RTty8x6Pv2cdoHYC1AFcLacd+K63eMf0gjhL7Rt/07pKGWTqgSjBw9MqMrqEyyWR5omwHA1TQ1qzTkzatZ9PIVGmQpnrt3dDHDowPTFswrT4l7wIr6F8QtCLPkU5xWKTiQP/moMZBz5if/37iVBDsTVLAgaUcVkGcbKYdtuiGKlJVWQcro8KtZR9GBPzT0hC/BTk4rOQuMC5ET3tk5clVDxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyVFzo6FDwBuBULigZlxWIA8Q3htTSbXK72A7UBeEMM=; b=G8yqUG1TttUKAWJym6UGCOA+0qOwsnRSvC9KJi7EaxErdSQIqJWZliKsQVidanNNJppgpbr0GmWnZ5c8ER+M1cXDmHDECrALnTE4Lf6ME1STiyn/gKbG7T/IGEBoXRsjtv696+kofEJQVqCqe5jC853sl8THsSERJl+5kEepOYM= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB5468.eurprd04.prod.outlook.com (2603:10a6:10:86::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 07:00:32 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:32 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH 15/16] soc: imx: gpcv2: support reset defer probe Date: Thu, 29 Apr 2021 15:30:49 +0800 Message-Id: <20210429073050.21039-16-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abea79ba-6298-4e3c-8dfb-08d90adc7ac1 X-MS-TrafficTypeDiagnostic: DB7PR04MB5468: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1265; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TzFKLxeViH8WCvWls0FdnHFivhaokFVupNMVND7IkiIwI3re3Eb5J7wYPY7Gq8o1kc+OpziEBJ7IE+edZm6iSvHJ6BLcg/fm4cpy/P69iVr5ZZXIPwgXpCAMX4D5mZRgmGalVZNlJgVk2pcWD5KpVwqoX4+aFR4XgZO2p6RvGbdQyOf54etiJCOCF8TTaDz1R1o/vbBjehEPuiNecnj4T4mwvHSCctBmmCC7H8OMcHf1DwfSEtEauh74aeiV4drpIFy6mx86U/lyCPUpAOQ4sBgDKbOjnV7Yg+ykettcB2ONLYziYQCmTdDuEuT4P+o9bmize0YZn4pkoQEEHqaY54XYTFWKLbF2Jdr3N0lSMn8cxTCsBSm7Vbb+G571mxh04KIgl4A1yG3M5BBkpxrhqv1BkOfhHk96AhuzkdpRn5QsQFn55/jsFwTa8QkWXrsPS2BRwulr60buvuoH+KgHRzZWBnpknwtrT2yCzTrSuFby8V70K9Eg4zPoyzAiIdQT60r1jZxwJ8qwYIn14efx/4nWUHmMLHJJAPOlyKFoXCXmijCga52cSjmuIYjEH2L7DCohsM7sKYWWvv/F5pIvmgkFUKK1H3FQzbRWrNhJ637f1zvcW41DZxjqQIHFh+m1WfZebnlRUM137rJ64r66kQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(2906002)(8936002)(4326008)(52116002)(38100700002)(38350700002)(6666004)(956004)(6512007)(83380400001)(8676002)(66946007)(66476007)(16526019)(2616005)(1076003)(6506007)(186003)(6486002)(66556008)(7416002)(478600001)(4744005)(5660300002)(26005)(316002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: YuV8IKhMebdl7Y/egh47PWBTzwB8ObQf7+nxwDdv/8zYAf2qKgEU6t2C35JANJkKs7aZkxMfxDfzYG7IaxFLQz258eUKJ/COTdfW8VGHpm1g90q22MAdBmHmFBt6SbmWz8JzhC3dqJ04D2lA1+K1CKh9SIA7TrNI9fsz0Sv/dCkrc2shpQ9zP5aMntwGKweWmr369Y7YsRwxIAWN6lETWHV7WYproPsvCoqnTgEOwfpDjrWzdxFwIIcc/gNpmyFj85Cc81VBgihK2nZdGdgFq5s1R0CfUJ11Tlp1PmL3prVzxet0vVglAmk6f8AFhOh1FLGJmvgR6rSYSt/zaWLt/3sAeCeUDh6T5c2crOBvbPBv8B3Nc5o/DGPLSAwMSPvPSpNvXZqhtqJ9UI299jrLWMMs/fLiJ9HS5QIkQbjCTwp5OWvzFA+X4+ithHICTIRBfinbhcf7jJf1wASJsBwOrq5j/MZGDetUvrYxMKWNCxmsiZFi8e7ni3SaHr/IR6U3udQ/seyewMDabNVt0R3ko3IsVXaLt9qWJf/AZpHSgKLWSpmWyeJtvGAHBIEdacuxjQ652+J3VahKgIFovRz20Fd9y+C1VoyhsEPmual8uEx+MlsiddBqn4l3HJUSX0rLgKQTmU7Ig0KH49U3EPGkCKqgK14+GqpL5C8/jrWZKVSrPlJDtJ560PsCNTUhhPiSRRc5rqES73O+wxWPTVzO1vt3bUlTJSoeHqzJ290fcRJhvKoTrBKtdwefpDHkDRGG6bxorAe4OUJzLbrIFtvuNl2f4DRlkWIpc2GnwUM9RaOkFF5Je2t/Kt9HWqdOwfnLSlmMIJjHjVE7yMdVk8Rf+4GXrNYlQpsz7NgFhx978Ra8kjsnhDLxUtxXsHXSURNFSIBRjusowAvAho0Gt/wwcUBvLQXD4c+62fAdRenc78LAfVRxxUXYptJfytqKwT6/uHE1jzs8ww5UdGP1uFDRuGyC0O+N2Fpv972U7Ccp6EmotsaqiQM+OgwKzra39AY8KaE/PmJtJ8PnC31FOCMPq5gwLzY5sVvnP5hiOmamfFsmEHhfPhOrFom/4hBB33IVeRRJVodKGNct122uCaTWSSNcJcV5DgK2GY1e6BjRDlPzSmmeZJPSf8g2xiFhaynUgFq+CRkCgFJqpHqSKtz6K3ovA5Eql8cQa3kNJ0grMI5Db8qeBGk90SGBRVo4UIkIy6qQVeclSJB3kwMd2IPzhvfIKUdBNjVc3iYs4jcHbLWgfQnq874QZaNOEGnEkkd2ghR2Okw6Uz0QKLlZ9neKxjdjRUrrW1tyZpXz8BN3VwiQ70VD0Lc5JUZWl/rElilW X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: abea79ba-6298-4e3c-8dfb-08d90adc7ac1 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:32.1932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pu0lMIZP6m5H8hAsRxcFA9PsXL0+P5Dr6SvPqnejJt4AN4uMhz0bDa9YzTYFYivh8qRA5CdRAFprmvrMzB2YVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5468 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000037_595336_F5A94238 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan When gpcv2 probe, the reset controller might not be ready, so we need defer probe Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 072f519462a5..49dd137f6b94 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -784,9 +784,12 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) "Failed to get domain's clocks\n"); domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev); - if (IS_ERR(domain->reset)) + if (IS_ERR(domain->reset)) { + if (PTR_ERR(domain->reset) == -EPROBE_DEFER) + return -EPROBE_DEFER; return dev_err_probe(domain->dev, PTR_ERR(domain->reset), "Failed to get domain's resets\n"); + } pm_runtime_enable(domain->dev); From patchwork Thu Apr 29 07:30:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12230563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDBF9C433ED for ; Thu, 29 Apr 2021 07:12:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41A116141E for ; Thu, 29 Apr 2021 07:12:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41A116141E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SrdJt/iG52BFEexcrV3B84DbuA970cvVb2M6qsDkKCY=; b=WmzUpKNyQnijY/T9BkcSZTeBU v74j/mZBW03nvfQqhhpj7m9KGVEmVIrporzMy3UujdIBMzqWncgDt8Df7ccZfycJ2N3bqjCGARLuL a3yEs1A9eqR3p8YO7BugfiVEH7KgPzCYhpxRFLaH1uZlb2Zy2PRc/JWkNqJ+dun+Icm6aaCFRMKoV xHwkQLm4GM8otpO3jKS5xpXIEIropdXAJtrrNpbeXi3Qc+NjOiqz3OQTBozKfuNnBhbawg4hp+pmq DKJ3WX2SYscICQBCR430ow0l+cvtPdYkNtZx0C+KkC2AWr3dm8h9UvmA5WTGJOY1wqWqxedBCzLvH tsGhMmtMw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0nx-0059le-4n; Thu, 29 Apr 2021 07:09:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0fE-0057i9-8o for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 07:00:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=Lt0GIkn1Z91P2rEtQcj8GdYvp0eIbCO3iKRwi1e9AhY=; b=PKGRCwlabWi8TfvYwLunlrTQ1x eQV0E4ovcIc7ZsVGaHp76tvTuzrSil9uyi+/FNmN9k0m6B+uo02UR2T+cLkvld7FE0fYfKYRBg/l7 c5vMUhkhNsUC3PTTGJCsh2fpuZxeRUbs6xIM4XEws1T70roLwwcXlXIT/j8UJDRofOZnUzSgP6jQP iEvCe7V01Fr0clJb+/wMpggDLPBSfTBw+DjeycI8xLIjWb4FXdMDtlpnThA3uUgyOLIy4ENxM0nJQ +Sz0juXS+3RdyzxS1aqvoj6hvrlBuUY+VtmSf6DbkvFHEgnlhy1/wlDszZyXRCf4rIJaUBYn18y59 phbjwBwQ==; Received: from mail-eopbgr130085.outbound.protection.outlook.com ([40.107.13.85] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0fB-000QQS-M0 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 07:00:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQO2OWGFjqmnec0GBF8LUrhi+IhrMn4XgGb1bvq4eqCYW/WO9E/CM5A4S8wSQdIAzpIvE1XCisUl2R7MYorlNw+zb11XObTkDhg/f3NkboqtaaXikckFeREITdW1LcqYJiDKN7lRHNB058cKd2gUsn1CF4Ph6/m12c6THR4YiGje9y7mD9tFvCsu4qipMMbXHFaXDXZafIYBIP1c158RMRiwKVzVgh46aDeggacfSImBq0a1OFXPf0WlCRF0S+fuattIwwk958EhxSx+LlRDuwDwb3BkdF3GbqcQLbJhkSHrVQHqp5GG2oedcBzq7Bg+KHMNNoW0VUizpfC9CJ3nKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lt0GIkn1Z91P2rEtQcj8GdYvp0eIbCO3iKRwi1e9AhY=; b=BKZ0A2NU7XfKwsUjBzFgdllsqfp17sPh6mfitCwmLky3QpHvtaOUIha1Bh2cj8i1+RZAeLgttsc+lvBCeXK/bRqC5HKbNy0aNQ3GoelAsZLb8k4CJr8CuOgilmZ5GCjCQ4g9zkQflwSmHBi6yc1YSIrlOdQXntLiDNJKVIRSM6wSFO07G1e+iZEEauGhJtbatybQNNn/5zE8ipP1M2WAjExEz89f2o8O5eHOBU0+bZIEa41DU7iwV/Z0rx8X5+DoRe/qVbzTzSZKXxGwVH+hGUsLh9h7IjJWy+2jV8e3jmMu87I6WZSAErU1xbAt6Beu+aeREngFjlwwQWBOmgq3Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lt0GIkn1Z91P2rEtQcj8GdYvp0eIbCO3iKRwi1e9AhY=; b=HpP0gIMi29XulM98xoqDdl438CK8Lg8mB1uhW2JrAhx70lvnTXOhiSfwri59LoFjf7gvcSMaRbMPEjRYtweLEpiMK/wnbi02MAP6Z7KKkP/jvz+LFdrbr+j6FmUd01gj0w5UesdZLdXGhLmvytBY7C0T5Igv5R52Njel8pW8XjA= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7930.eurprd04.prod.outlook.com (2603:10a6:10:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Thu, 29 Apr 2021 07:00:38 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 07:00:38 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH 16/16] soc: imx: gpcv2: remove waiting handshake in power up Date: Thu, 29 Apr 2021 15:30:50 +0800 Message-Id: <20210429073050.21039-17-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210429073050.21039-1-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Thu, 29 Apr 2021 07:00:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7d04067-85f0-48cf-760e-08d90adc7e6c X-MS-TrafficTypeDiagnostic: DBBPR04MB7930: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 03Xt0Oee8/Uw9QLXIFuK057f0WopZ5iQriehjNIsZ+fGrpI3LaMByBI9Fb820Go5hB09VGk9Img74vBkn3njJrPtdOOSpMGPl2i+NIh+boxZ2xtKqf6fCRDVK6XDdYotInxm2AR/tOUlBQxiAM1SoPHHvU+mifNPhmN0pDUCsKFshGlhGDeeojbBCJju+Hie9S1cj019LX8xM1USrn4yT77uvJDgQVg+LLjV4ccXOlxnEIBD9c6mPJFTDhpxstrPJZ5aG4QGW5qhm/xTrX9NnenDap7Lb4Z7dMyWVQSelNc4nOMjPfhEu/shrjZSKXaWhH67+qRJhVlq4ce9A2C744oVJDHOdLUV4H/+fOXPTUmmYJj4tZ3IERNGQdqm/zf+25Y4R+tOKI+BBfZDp7YX2RpATQj8WtigLJQHHrcJItI4+wFKhSdllNx7ufit7pTvMDVzGzwxz9OyyQYH27dOug1RXtYbhLSqm57rHh7Zl21N9XffbzOV2uAg0HgzJdATNbvPNgQFyVQSkWvxZ7vGCJk2xPrahwCAfyoZj6NgX3HIhhvtQzlsyW2HV3v972Bvp2DQDW3nSskUzVdAouyH5Nc+pu/YQqpquQBmOBmWczwh66KKzs+Ty/Ogi1XYXJWPtr7qafaFRWByigyqQqQP9A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(6666004)(2906002)(7416002)(26005)(52116002)(5660300002)(8676002)(66556008)(478600001)(66476007)(16526019)(186003)(316002)(6486002)(38350700002)(6506007)(2616005)(38100700002)(1076003)(83380400001)(86362001)(4326008)(956004)(66946007)(6512007)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ZTkE2z5f5NSOdbQdUHISGK00PrzkfHximtDFJrLyGWsXB9MIn/mzQecQ5v9yPwX3pGXY/WSsNYVp1u9vl7QJTccJLL154MX4QE5/FldS9R5kw7PVrromuvcHWuG6C28KQRyH0i3Lvd7Br7mvemsdY54TV0k3+5QQvemZhxHKATGGE0p8diHeA/02x3wFvWPsZIflnfMfspkcGpAQ4fLEuSxBHp5VeLA9xO9WV34uylo/30WmNM5KFGtzybFHWbnz14rxpBNmFQ8aFGAtKjw2yB6sI33mcY/W5qoNXhXsXFn6SlYubT3m9oTfvThREQHcuSxnda0Zn7rQn9yyWl+KksJBmuJ6kuymf+HiuetefVCT65aXIq6v8hsku4EQurKFzpMXDNoiNvTIMlPiwDbttBXuwsMeDolHUEAMxXXWsJXgufAkZZEiziOxkA9tf6VIi8AgYJWvijPZsNRx+BB+Xrr8acACgPHXaNGQgEeAYhHXVk0OjfzAmS8aHFpxjIrefXcnpIlOGIk7JIXhWz+APrs13mNYZJ2cYm74+DObqhUlDT7OH5957oD0ASj/TsM+szldTczVMJ4XsJnsLSfY7uK/ir5TDfGlE8+nCHFS2pZxi5pvtHlReZT7sg1aeLHXSu2Jr1EhIQsAh3nIW6wR0YkO7ooyVMmBcZXWMUNlgTwtjfgal4mn1MurkZrrnbrrP6zII9XWrWkX3bL2gDjcDjWSgLmH3bNXfQ2XLBEoSTJuCR58v4nmnoK+K6/FtU6WH9HYl5Fh3J2SNM+h7bI4RXoR8fpWfMEt7CvY8fxN/S+Rr6C6jg6F0ooLJheBGCEmT7/mDQnbxz8KAywAEkc913xB9HYpTwnJTB6lUeX21rKMNpxVpYBv37La02ZroEUZdGz6ULprPM+HUpcHjUf/agnX6XpDXj2xJdrtpLDpQEUGfsFbL3rhQAFMf6A0a76qy8kCirSRp6Tmpmo46YJE5tE2KrS9dQUFNLTVhjmA7DlroXOn8GNx621mryLftXiq16vAIoC26oqIEZT0UvD+CHciK3ktRXSvPi4KyXdxzGbQ8gwC9fE5hWZQ7tPwzoQhsD2j3a+X35fcjcM3KJGE5HPAmLZKEYMkH5a9Fw720BMzuR2LCh0It3MpYsVYTmNoIXsQYE9UszRcVNDB210++dILONNw84MOSFFi8DTbrf2DeAk9USx+tePRMm2co1+K8x6rScpaUA43boyENo+gkd98TA9hII2JmH8Sm+Lw6haTA8EhK62DDP/Uw2rK4i0qlOqRO1GCpLS19gz5s2Wpl+vAKtZ69q09fTRIsXyxcnChDGYB0RVoLXx39mGpo3vX X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7d04067-85f0-48cf-760e-08d90adc7e6c X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 07:00:38.3674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7rz9Gp33AnDEBSy0t8HDkTm02K6QeTuzBv74RhWOELeJsHz2cR3nOliAYyBv2sVqPB1JZucxS2EZlrtLQpJQsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7930 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_000041_743701_9A6BF786 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan i.MX8MM has blk ctl module, the handshake can only finish after setting blk ctl. The blk ctl driver will set the bus clk bit and the handshake will finish there. we just add a delay and suppose the handshake will finish after that. Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 49dd137f6b94..04564017bfe9 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -251,14 +251,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, domain->bits.hskreq, domain->bits.hskreq); - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, - reg_val, - (reg_val & domain->bits.hskack), - 0, USEC_PER_MSEC); - if (ret) { - dev_err(domain->dev, "failed to power up ADB400\n"); - goto out_clk_disable; - } } /* Disable reset clocks for all devices in the domain */