From patchwork Thu May 6 03:56:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 12241603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBFEC433ED for ; Thu, 6 May 2021 03:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94CA3611ED for ; Thu, 6 May 2021 03:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbhEFD6A (ORCPT ); Wed, 5 May 2021 23:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbhEFD57 (ORCPT ); Wed, 5 May 2021 23:57:59 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB70C061574; Wed, 5 May 2021 20:57:02 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id z3so3095754oib.5; Wed, 05 May 2021 20:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Fb7g2E4p16Bv98KyBPLGHeYuLk+5q+sEUbPLsjTLLHk=; b=LqZpqiAg6EjfakLBXvDRzNV8ll0mhXt3RTvkQFlsjholqchimOSHdVjQHhTmmPqS8J YTHSjI/ro7NfGSXZp7A021z+MpB/r1evoPxCNQGYvk28F5f3iDpSf4cKcb/wApDFzG1j 4J2Wt37ixsY46KEcKva/Zp6uulFub3dzlw+6aFE7rUYZspgogdecvM7iL0XXI6Aw4M/R R0O29gCGmwvw8szaCEyw8ixgGeJTIy3Asr18Df3Xp9CIR3KddJ8L/rta3x4/AsToGZxU mnwA41+HlsbdYnE/njTpi+mUJyOc4iPqMvKS/bdiGcOG3l/jcs4Ld5htEB5e6K8960PY Ca/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=Fb7g2E4p16Bv98KyBPLGHeYuLk+5q+sEUbPLsjTLLHk=; b=BtWuKSxokvfKfjh2SX+cj7VYztlmEVXimwe8Uc+8TAeJjLQBEYhX9FEyyg1o2p4Smx DM4RJHQ1ZGXM6S3cptxZQOlY/IsHB9MFEycte/+SHtUvEM1dqWAmbieE1c0bYhia+SGb 5V4MwALfb+vYvAGVbWVFAwaDask3JvgMtbwCgyWy6ATushEKslbdlBuZqfzfh7pQIvVK x1MzQMRsWsBzsJjAO1wlE6KWYXFCJH3INtVFL1FpQZDnRZvmmXXuMTgiHawnhQoW13cQ 48zJOHRwlGNWVuET/v/CnZinFi8X4OeNRt0l0ekByeSXNIOrgX+kSfigYcEuC+pjcbu8 XRSQ== X-Gm-Message-State: AOAM531usAKT8ffvbSbvUxUf/h4fJgS/V047PhLFoN0qrVR1xeXxBJJo Tg4OP7Qg4JfM+2pfdyxFWFw= X-Google-Smtp-Source: ABdhPJx6PQAHklNzbcJ/pA8TWo8g5lgkbtrE29LUFDwAOl4k/YCS72mNY2sAO8s6rr7sO9ajbpGq4A== X-Received: by 2002:aca:3385:: with SMTP id z127mr1550908oiz.23.1620273421909; Wed, 05 May 2021 20:57:01 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id q1sm338354otm.26.2021.05.05.20.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 20:57:01 -0700 (PDT) Sender: Guenter Roeck From: Guenter Roeck To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , kernel test robot , Andy Shevchenko , Hans de Goede Subject: [PATCH] iio:accel:stk8312: Remove ACPI support Date: Wed, 5 May 2021 20:56:59 -0700 Message-Id: <20210506035659.765109-1-linux@roeck-us.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org With CONFIG_ACPI=n, W=1 and -Werror, 0-day reports: drivers/iio/accel/stk8312.c:644:36: error: 'stk8312_acpi_id' defined but not used Apparently STK8312 is not a valid ACPI ID. Remove it and with it ACPI support from the stk8312 driver. Reported-by: kernel test robot Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Guenter Roeck Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- There is another patch pending which makes whitespace changes in struct acpi_device_id stk8312_acpi_id. This will result in a conflict if this patch is applied. In that patch, it is claimed that the driver would possibly only be used based on its ACPI ID (even though that ACPI device ID is not official). Link: https://patchwork.kernel.org/project/linux-iio/patch/20210401144226.225928-1-jic23@kernel.org/ I can not determine if that claim has any truth in it. Still, it appears that the device ID is not an official device ID. drivers/iio/accel/stk8312.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c index 157d8faefb9e..2fc30cfe1457 100644 --- a/drivers/iio/accel/stk8312.c +++ b/drivers/iio/accel/stk8312.c @@ -7,7 +7,6 @@ * IIO driver for STK8312; 7-bit I2C address: 0x3D. */ -#include #include #include #include @@ -640,18 +639,10 @@ static const struct i2c_device_id stk8312_i2c_id[] = { }; MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id); -static const struct acpi_device_id stk8312_acpi_id[] = { - {"STK8312", 0}, - {} -}; - -MODULE_DEVICE_TABLE(acpi, stk8312_acpi_id); - static struct i2c_driver stk8312_driver = { .driver = { .name = STK8312_DRIVER_NAME, .pm = STK8312_PM_OPS, - .acpi_match_table = ACPI_PTR(stk8312_acpi_id), }, .probe = stk8312_probe, .remove = stk8312_remove,