From patchwork Tue May 11 08:45:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E26C433B4 for ; Tue, 11 May 2021 12:22:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F84C6134F for ; Tue, 11 May 2021 12:22:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F84C6134F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Z6/nMwpwGf9spaQhu6JuxdZPRa3pHatRBZ13lnCEHlI=; b=Hm96+U9eG4yX5YJuJCztvW2JvJ g/tv3Tz8/WXvEyG0n74azFMIwcZj3yPPK2IUYA0FT8x3sNtrRWbyMI+HrPUa+aujAIz2/TzpB877G F43jNYLQzq/76cJaBAcHpTkhZ/H0N6CeCfZnAlXp8WjnW7JzrQCNwRQTIBIAqTLydBGAY3ImbmkOU dt4z84ktWyFJgxq6Hu0uKJnHSG1ewEF+28w9bWeaXit3OJfEC3udy+UCyFjjk7Md1uwsSwQ/s80pJ rIriLzIIORMUPeUhDJPCEAYy6CZQlD9pml0jS7uybQaNd8AGUProv9mTDovnH36HXK0Q9x9bK5M+m 8MOScCEA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgROS-00HLyj-Jq; Tue, 11 May 2021 12:21:44 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgO1m-00GdAS-SQ for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 08:46:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=5CBltmpXQ3TrZuhyeJzcOYKOCMvUvyex71m0Bdoegyc=; b=YxgcqBWQ+a791ODM+Qf4HFnaI8 ZfyrihvB6VvuPYx67MgG5MtQmQ8nn7u28oOQxa1JTICH4icVQsZVEe7P53w3mthJirj4kOx6qEpDZ 1xe0upNyXb7FDO2s03nrvj9Pqz3Z/b1WWdKYoDaL8BeOJPkqSowYvdS+7kk7+Ebe4Ox44YUHuHaqY jy373q6DrU1tkHaFqMQ8ZKqML80ZlengUiVLMsGTlQHBVBQzxRt41Y/GWBsvWWjU45vNxmD0kh76R 4TgZBOB6Y00SGFgX3IPRLT4wNuFFvgwvbjAbM4XKpKBmMa6fJtdCTmLO+W7eFux9/ZnqHHY2AyekU M+2B/EtQ==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgO1i-009PMX-EJ for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 08:46:04 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FfWf661x3z1BLJP; Tue, 11 May 2021 16:43:10 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 16:45:40 +0800 From: Zhen Lei To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , "Marc Zyngier" , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] irqchip/irq-mvebu-sei: Remove redundant error printing in mvebu_sei_probe() Date: Tue, 11 May 2021 16:45:32 +0800 Message-ID: <20210511084532.4234-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_014602_685089_C53C5768 X-CRM114-Status: GOOD ( 10.84 ) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_014602_685089_C53C5768 X-CRM114-Status: UNSURE ( 7.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/irqchip/irq-mvebu-sei.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c index 18832ccc8ff8751..3a7b7a7f20ca7a4 100644 --- a/drivers/irqchip/irq-mvebu-sei.c +++ b/drivers/irqchip/irq-mvebu-sei.c @@ -384,10 +384,8 @@ static int mvebu_sei_probe(struct platform_device *pdev) sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); sei->base = devm_ioremap_resource(sei->dev, sei->res); - if (IS_ERR(sei->base)) { - dev_err(sei->dev, "Failed to remap SEI resource\n"); + if (IS_ERR(sei->base)) return PTR_ERR(sei->base); - } /* Retrieve the SEI capabilities with the interrupt ranges */ sei->caps = of_device_get_match_data(&pdev->dev);