From patchwork Tue May 11 10:04:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 12250847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D922BC433B4 for ; Tue, 11 May 2021 12:45:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89D7E61628 for ; Tue, 11 May 2021 12:45:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89D7E61628 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Lvv4GkZ3d/zHacATpNrEd2q+4sNbNKxTApJWGCTojoc=; b=PXdupisIumL5OIN/f4MEOddNNH 8Yk5jxqriWARgEQ+Y03vMPTGcwRSsQSxhlS+pIZAXPw/CSfHWvAUu3kE2v6y1wsjlQ9+67GQiMYSf PoM6qrF3+PADNgnFs/Vjm8WKzTZv7sHCYo137cYLSmqKWwBYrcCrjsMT7ULK92zAgerDQwPYThRTi xECPVE4aFCqcGvVD3FDW2eapoMEzvX3iZ6UtsrN6u+HpbGMj2dbGcgyDa+G2++ujJtavIL7UsNIvj U8q3nb5YDw2RK819wPrGBP6iZw1HQiJURrHE6+3rtNsVH0IYQNt1sxLvbkSQ9GCwfz2SXrYKl3YJX gnefy2dw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRkA-00HS7K-9k; Tue, 11 May 2021 12:44:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgPFg-00GpJ6-Ql for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 10:04:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=KAvtiyho2oRWDt22RDA4AGbpolYvDS6gwMyQVCScDCw=; b=WxH6DZVMbZ6iUIpjO80XGZz0zW lp7e7jwZqDD+e2dLGOmH/Uk+CcNLI3g9SvhB+VwQN9kD4cCmUFefIZODgxYUS7mhOxiSEw+2kvBCE 6CgF6Y+KH957yqpW/CmY5jrF6o3oJ574lQea8zrCNOxIc+jPTlL45x8SP5IR/cMdIJaMPU7VtwyzY fojpxQ2seZ5C1bxm9YVVl+IIfrwVSi9/PvzbSx0gysytCbDIBHGAIe1kY4uplr4DrBvDGCtp/AgFa QkfX8kZxctM8TH1Xadqxg19fclNtQwbPIJbajncwp1KJHr1LWpIlzHAI0Xm8oK+PhdW438dz00udK 6d7msQtw==; Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgPFe-009SQe-6D for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 10:04:31 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FfYN21X0LzPwln; Tue, 11 May 2021 18:01:06 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 18:04:19 +0800 From: Zhen Lei To: Thomas Gleixner , Marc Zyngier , Maxime Coquelin , Alexandre Torgue , linux-stm32 , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe() Date: Tue, 11 May 2021 18:04:09 +0800 Message-ID: <20210511100409.5103-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_030430_414411_E738D4E5 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei Acked-by: Alexandre TORGUE --- drivers/irqchip/irq-stm32-exti.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index b9db90c4aa566f1..4704f2ee5797a1d 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host_data->base = devm_ioremap_resource(dev, res); - if (IS_ERR(host_data->base)) { - dev_err(dev, "Unable to map registers\n"); + if (IS_ERR(host_data->base)) return PTR_ERR(host_data->base); - } for (i = 0; i < drv_data->bank_nr; i++) stm32_exti_chip_init(host_data, i, np);