From patchwork Wed May 12 09:02:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 12253109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9461C433ED for ; Wed, 12 May 2021 09:02:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33FAB61420 for ; Wed, 12 May 2021 09:02:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33FAB61420 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F4D16EB71; Wed, 12 May 2021 09:02:54 +0000 (UTC) Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B15F6E067 for ; Wed, 12 May 2021 09:02:52 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R591e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04394; MF=yang.lee@linux.alibaba.com; NM=1; PH=DS; RN=8; SR=0; TI=SMTPD_---0UYdpVrJ_1620810169; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UYdpVrJ_1620810169) by smtp.aliyun-inc.com(127.0.0.1); Wed, 12 May 2021 17:02:50 +0800 From: Yang Li To: bernie@plugable.com Subject: [PATCH] video: fbdev: udlfb: Remove redundant initialization of Date: Wed, 12 May 2021 17:02:47 +0800 Message-Id: <1620810167-89132-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nathan@kernel.org, clang-built-linux@googlegroups.com, Yang Li Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Integer variable 'identical' is being initialized however this value is never read as 'identical' is assigned the result of 'start + (width - end)'. Remove the redundant assignment. At the same time, adjust the declarations order of variables to keep the "upside-down x-mas tree" look of them. Clean up clang warning: drivers/video/fbdev/udlfb.c:370:6: warning: Value stored to 'identical' during its initialization is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/video/fbdev/udlfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index b9cdd02..f40dd6d8 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -363,13 +363,13 @@ static int dlfb_ops_mmap(struct fb_info *info, struct vm_area_struct *vma) */ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes) { - int j, k; - const unsigned long *back = (const unsigned long *) bback; const unsigned long *front = (const unsigned long *) *bfront; + const unsigned long *back = (const unsigned long *) bback; const int width = *width_bytes / sizeof(unsigned long); - int identical = width; int start = width; int end = width; + int identical; + int j, k; for (j = 0; j < width; j++) { if (back[j] != front[j]) {