From patchwork Thu May 13 16:38:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F0F9C43460 for ; Thu, 13 May 2021 16:54:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E63D6143B for ; Thu, 13 May 2021 16:54:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E63D6143B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEbj-0006Bi-0Z for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:54:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMj-0002HT-5M for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMg-0000jE-VL for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bW5gbIH0gVW0SIl2TNyDBPbRck/tAvlYokCEWuHZkDo=; b=XIuhEKBRXYaL3FuyaIyWx8dxPd7XyeWn8QbSMsQOdgF5hODL+Uq21CU9wMQIqCyulnXX6x oN9R40iZGaVDpc0VeP1kKfcqpWVfhmZ49nmLp4tQi5wkGZfYOlqTk5z5RqpmndK8UGb2vy S3bxPXrdsFpQQs3mpU2qD2IuE4cqcho= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-lyAmd97_OnOJdu8DwzrPqQ-1; Thu, 13 May 2021 12:39:06 -0400 X-MC-Unique: lyAmd97_OnOJdu8DwzrPqQ-1 Received: by mail-ed1-f69.google.com with SMTP id n6-20020a0564020606b029038cdc241890so1426840edv.20 for ; Thu, 13 May 2021 09:39:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bW5gbIH0gVW0SIl2TNyDBPbRck/tAvlYokCEWuHZkDo=; b=IUtNqSvL/BVejEZ1HsfNEvDfIv8Vn9hX0GaP2Zj9uxYRJWQdjugkSjuUOx9q+0uiWP Kq5DncODMz+aRUTnCatP6t4D8cyR77M1najaekFIQHIPIOGL3GoA5JSZcez73A/J1SdY 71/KQSL3iX19vqwso0BU7UOJUrzxPlpguUfQcXI6a7KwjWOBd1vOgPWD+KbnSujH5+jP GLUlEG+s3yp7hvpZ7YaFMPFgNo5UHcPx3hVL7FXCAX+DMNDz5ODaF8hdShF2dWsrYXNd jHPCC2bn3p4NseSYCpH8h9mqwkFdpmyurQ62lCNoKFnOqvHk863E7OeDo7vqHpLAMwYl 9aWg== X-Gm-Message-State: AOAM532fL2vTKxIwOfmj9ayLjKjDhSE3MjxobL2S3Ajufgkrhj6r9VUq XWrHqEQdEToc2VyxU755wcFvunpD74ybYTipRGSSdOb9aimYxNAZ6ShWMqwqNb1ZMGnKrWjFQhe rdsHEamrha7XHPNzphJan2whKSTVFAba6Hp9KxMBsuJbjwo/ldt3kL66hGX6L93g9 X-Received: by 2002:a17:906:5917:: with SMTP id h23mr4105839ejq.457.1620923945252; Thu, 13 May 2021 09:39:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrXzw29CRvct8vgvUH19mfvMTnZDWe4CE76WQl44rPKgdBUG1b223i/h7qZhPzWi3i9CoEyQ== X-Received: by 2002:a17:906:5917:: with SMTP id h23mr4105802ejq.457.1620923944909; Thu, 13 May 2021 09:39:04 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id y11sm2539673edd.91.2021.05.13.09.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:04 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Date: Thu, 13 May 2021 18:38:49 +0200 Message-Id: <20210513163858.3928976-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , Greg Kurz , "open list:ARM TCG CPUs" , "open list:PowerPC TCG CPUs" , Igor Mammedov , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse dependency to select the symbol. Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson Reviewed-by: Bin Meng --- default-configs/devices/ppc64-softmmu.mak | 1 - hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 -- hw/ppc/Kconfig | 1 + 5 files changed, 3 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/devices/ppc64-softmmu.mak index ae0841fa3a1..cca52665d90 100644 --- a/default-configs/devices/ppc64-softmmu.mak +++ b/default-configs/devices/ppc64-softmmu.mak @@ -8,4 +8,3 @@ CONFIG_POWERNV=y # For pSeries CONFIG_PSERIES=y -CONFIG_NVDIMM=y diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index b887f6a5b17..67723d9ea6a 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + imply NVDIMM select ARM_GIC select ACPI select ARM_SMMUV3 diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 7f91f30877f..66838fa397b 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -23,6 +23,7 @@ config PC imply TPM_TIS_ISA imply VGA_PCI imply VIRTIO_VGA + imply NVDIMM select FDC select I8259 select I8254 diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig index a0ef2cf648e..8b19fdc49f1 100644 --- a/hw/mem/Kconfig +++ b/hw/mem/Kconfig @@ -7,6 +7,4 @@ config MEM_DEVICE config NVDIMM bool - default y - depends on (PC || PSERIES || ARM_VIRT) select MEM_DEVICE diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index e51e0e5e5ac..66e0b15d9ef 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -3,6 +3,7 @@ config PSERIES imply PCI_DEVICES imply TEST_DEVICES imply VIRTIO_VGA + imply NVDIMM select DIMM select PCI select SPAPR_VSCSI From patchwork Thu May 13 16:38:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255981 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB4CC433B4 for ; Thu, 13 May 2021 16:57:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B64B613CA for ; Thu, 13 May 2021 16:57:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B64B613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEem-0005DT-K7 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:57:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMu-0002Mu-7y for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMl-0000kJ-1P for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=SpOF1dwBqbrBOfue/VffN3phkJPRIRmKKNmheNSzYZkrBCiEl84diY4wx3Uz6BT5dYVYtH RJ6eFh9ZgkSMVoJ4GA4BK0kXgvxTiJY2FBFj73lzCAd6OWu5iKLFzH9EeP9J/63SBvFMdh kORqyeY0zduFTAw01kW7nZULQoWZm8M= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-K-BANdI1NCukM5dvVQphfQ-1; Thu, 13 May 2021 12:39:11 -0400 X-MC-Unique: K-BANdI1NCukM5dvVQphfQ-1 Received: by mail-ed1-f71.google.com with SMTP id y17-20020a0564023591b02903886c26ada4so14943576edc.5 for ; Thu, 13 May 2021 09:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=C/+mnddZD0Jt5VVwdfQpw9V4xXvUj1U/BsNzceRSystrPClZnBCnLC12Z3XXdd6WQw V5oTO3B90+HGAGe3cjFcM+x57LRQenE0Xp2Jc+ZAhh+gwFgaMqqQytotNnDyi7hnGxF3 wZMEtoWMiVZH15TWfRC4JUdB6BcILqLjAhhg9e4uCCn35MeSQo12rfMY3C35vlDGG3/r vmucUas0l5schvH+SsZvvwp89iJ8EJJ4YshZNtpKyJ8qOg1jqSSrByk5dWq1Y6BFKxK2 652st7mWfGbQN3S5oUL+WxnpufY1pi0wCZ8b4G4RyOrWrkypxm2ij7DogsQMf6Nlx/uz fgzA== X-Gm-Message-State: AOAM530omYf0rzBpLt1LfrVftJeHEcaa120Rlt6Xp/0Yt7KhnrY2W58r FmwwPa+C3w6u4L440JJjvvd1ougCZJKJCHqsitEFGHC1xKHOZ6x8ERmRPlFWv4W/IRByC+mVyfR beTslBui1x8T3a1Hxrr4fMGA5htUffWQKDou4uyrVUEVFCYVtuaypIHKtBVf8Y7wK X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659188ejb.375.1620923949810; Thu, 13 May 2021 09:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3rRwCF9pZ71vFd93cXhzmvhSqn1g1AzCJRzfmiTLGOhSM/2mbCl5wEmp1SgZQMcoMTUp6Wg== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659173ejb.375.1620923949646; Thu, 13 May 2021 09:39:09 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id di7sm2695781edb.34.2021.05.13.09.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:09 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV Date: Thu, 13 May 2021 18:38:50 +0200 Message-Id: <20210513163858.3928976-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "open list:IDE" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_devs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV config IDE_ISA bool From patchwork Thu May 13 16:38:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF79C433ED for ; Thu, 13 May 2021 16:55:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA7B0613CA for ; Thu, 13 May 2021 16:55:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA7B0613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEcP-0007mF-Uz for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:55:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEN1-0002QH-WB for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMo-0000oM-Tt for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RxjBXIiwUsk+hse5zMCnX9XGKfKUwyxRJGBY/GxWjoA=; b=RGPluhZw8+wsRSAF/EeUQeWleSPTWj1Snx5ejazf+wyXBbzpC1AdJnlO5a7y9YGglIT56V 4tKqrhwqT/AnzfF6tbK5OwktjEcZIPtZ07KfIPVgmf+MWH+jXCE60k/ByFqCG1kOrzbzSX yzZLzYmikTTfmRo7TsvPo9BIM+3Ldxg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-6WuGVLylNQaVIbgylxwGNg-1; Thu, 13 May 2021 12:39:16 -0400 X-MC-Unique: 6WuGVLylNQaVIbgylxwGNg-1 Received: by mail-ej1-f69.google.com with SMTP id z1-20020a1709068141b02903cd421d7803so3181600ejw.22 for ; Thu, 13 May 2021 09:39:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RxjBXIiwUsk+hse5zMCnX9XGKfKUwyxRJGBY/GxWjoA=; b=rXAJZAp8mZSs8h1Ee+aqTya6ENbJvexUkAX9ybQ5WhJbwQrA2qwdghm/x6Fjn2BvyM QHVXLgodLrqklT8Cv4JJbi1KdAXHZx86eCp3Prm7PbDc9Krkrwso0qlv5KjuioOJsaZf d98Mro5ucAJYWdbu5kK4nvHfEC14SMwnpGJfLmojuFfAGpAL8vul1Nu6EYvHFjPQ3qRA poF8Evx7WZ9klJTupVR9PYa297/JYPnDUqc+1CGlxe6fGvqlqNt6Yk6LaOVsKTwkqn+8 luXvB3dnZ0ldl9pgTrwS2yIBsb/GHTh3X+hgCYtZRxPWy4wZhVkVwrqUz4PBC6WvLE7N TMOA== X-Gm-Message-State: AOAM533rV+JQKmoVQJHvj/93sJ5MDjbeFGnjnm9D6LjVVwT0hNBOhcs7 OUKQ42pCqiKkfrWEbL8w8fSbhamA+Myxxaern/x3Gl+Q5lrA27uZC8qB6KSSqgz4y5eQbUh0NTg zVmm+1c7egeVCDqajm8RFazhVhPCi0RPWUOlNznfDepbPeKyfPGYOhTdoNZzphYCZ X-Received: by 2002:aa7:d955:: with SMTP id l21mr50910805eds.118.1620923954789; Thu, 13 May 2021 09:39:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+qSalJJDt2JNg9zn0iZ+C/qHcv7Yl0RzDuccxLeSdACCCZgMRwF1QO1hCLOiH+aqf5ul2pw== X-Received: by 2002:aa7:d955:: with SMTP id l21mr50910783eds.118.1620923954636; Thu, 13 May 2021 09:39:14 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id s2sm2635684edu.89.2021.05.13.09.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:14 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Date: Thu, 13 May 2021 18:38:51 +0200 Message-Id: <20210513163858.3928976-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Peter Maydell , Doug Evans , Hao Wu , Tyrong Ting , "open list:ARM TCG CPUs" , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX Fix by adding SMBUS to NPCM7XX. Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hao Wu Reviewed-by: Bin Meng --- Cc: Doug Evans Cc: Hao Wu Cc: Tyrong Ting Cc: Corey Minyard --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 67723d9ea6a..85c6a1a088c 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -373,6 +373,7 @@ config NPCM7XX bool select A9MPCORE select ARM_GIC + select SMBUS select AT24C # EEPROM select PL310 # cache controller select SERIAL From patchwork Thu May 13 16:38:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13684C433B4 for ; Thu, 13 May 2021 16:57:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC59F6121E for ; Thu, 13 May 2021 16:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC59F6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEeZ-0004fs-O0 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEN7-0002T0-WB for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMu-0000qU-1U for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6C7WWutrNcOZs1K+Kika/F95HGC7AnV8YKzuCNwKf5Q=; b=JJwjmOOtW0cYKp43iLeiMNtMYd5h9tYiSKM2KJIl72MJCwvmgbwU0l9Wa1XsDCWTwEw8C2 mLBhEAMNaBideGbbW2r3icPFH2/y42lxGULXLCkbxV9BO65bcGEgJk7yYvw/XX8+Q5X3KZ lI/7ZkrSJkE6H4SO8ByNyC+YRVQNoiQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-c7EWng4DOmOwnH8n0JMv4w-1; Thu, 13 May 2021 12:39:21 -0400 X-MC-Unique: c7EWng4DOmOwnH8n0JMv4w-1 Received: by mail-ej1-f71.google.com with SMTP id x20-20020a1709061354b02903cff4894505so1989410ejb.14 for ; Thu, 13 May 2021 09:39:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6C7WWutrNcOZs1K+Kika/F95HGC7AnV8YKzuCNwKf5Q=; b=To3I1M99xJI7ypfEZUqoMVYkRwIo27h3IpTaxDHs12L24Wx4CzCfPI9JGGSyozyLZV v4g9WMs0agLhji6gpYWyLjq9tzgceo8cSeTSoWbfoPWRZW10x3PMus+JgyYkWZJ4ZDeY +0F9+GnAhAAAqp2IFOlda6KbZbzGMUBUdvuIutgS7KUJX9ZBX0336XGnKs9HeIllZ8t8 HXpHk3cIHbhXFNj9K8/nXlgByUCA/EbD3rRrbzNqynCUSefvn0OcQV8ZSX9RVQewPWJC l2tIhbvH7UTYKMANHs8kp3BenBLL9KGQQWR50/DnacrTs+uxyp8Cm7YgPaZMvqLk1GVI 9v3Q== X-Gm-Message-State: AOAM533G55GRMtzTjS3XED+TxcbcG4UUMft1Z0L4GLXtK8+ibFXQ4d7y EQ531JRobhnuvVpFdVjrj+dcJg7ExXLx99C28qBM9qEen/xJSqf8qxrkdZsw94b/b8dkbjORlX0 907nBQXIjHMcmYmDWp5AZu8Hi1QtddgCQsyqcNxaB+hfxuMk4K7rspOt21pFqqpPF X-Received: by 2002:a17:906:c14c:: with SMTP id dp12mr44642612ejc.312.1620923959658; Thu, 13 May 2021 09:39:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9XaXQidoNghPAg+0dwQ1tb5c/B6aem8zKmtpGmOCyf9a7Lfrws4EmmpEpaGgvsrxIOpWzsQ== X-Received: by 2002:a17:906:c14c:: with SMTP id dp12mr44642592ejc.312.1620923959396; Thu, 13 May 2021 09:39:19 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id cr21sm2011294ejc.2.2021.05.13.09.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:19 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 04/10] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Date: Thu, 13 May 2021 18:38:52 +0200 Message-Id: <20210513163858.3928976-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "open list:ARM TCG CPUs" , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 85c6a1a088c..5827c092b28 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,7 +386,6 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 - select DS1338 config FSL_IMX31 bool From patchwork Thu May 13 16:38:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F362EC433B4 for ; Thu, 13 May 2021 16:57:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4ECE613C5 for ; Thu, 13 May 2021 16:57:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4ECE613C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEe5-0003Rc-Q0 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEN8-0002Ts-L0 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMy-0000s5-P1 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/ktmwgutY2Wn0xDD9O8rw5tOPYKtHCv9CNEw553h8k=; b=Qicf9NnolEU7QtOssgKbSh9CF/B+1G7nLi7yZ2BHLzYTsmK4yIVp7079mN660bEQTe/1M9 SnHwvjFd4IefVh0QA00pb+HbmyB8JpJ1HjE+iZeLci3iVTTzJsqpFpOjzJCTYQKJy9MxPm xs6YxwGpVk3vuUI37tBLJZx7qBNqCTE= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-3MelRioxMmq66hd4LF9i9g-1; Thu, 13 May 2021 12:39:25 -0400 X-MC-Unique: 3MelRioxMmq66hd4LF9i9g-1 Received: by mail-ed1-f70.google.com with SMTP id x3-20020a50ba830000b029038caed0dd2eso3817453ede.7 for ; Thu, 13 May 2021 09:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y/ktmwgutY2Wn0xDD9O8rw5tOPYKtHCv9CNEw553h8k=; b=tOyjNtd4BUwPP/2qk8cSyLsicqiXEwO9OWnjGNpYCxAFLNTp++4oHFTZAmrh0L4zjE 2UKRvwWhUo0Khsndm5TL/ZX7h70oTihMjFGI9skgA3gh/oIqwQCbJySeP3uXxhL8fC6L kajRrKfpWYq4Op6O1IJ0hI84gUPyKGRpUv2J/WjXkd2+W4ZGw5RC6/ZZoTebbRlaLT7O qY6pqajQd4eaXE/6h5BssArW7+QkBRvU6L+eWdvWTIicDJifeuU8h7FByE/wJeFa07d0 wZAIpFP+u1n0bYD4LweENnJdCXwEKLTQbO1ceA1yA/+H8vAudkVtEqRnqzQuG5U8TvtZ 0s6g== X-Gm-Message-State: AOAM5333zcGCpfJ3pXx4k0VUQQkO2OT4gejn+TPiUmG8yXcJ3DQ4cdZ8 kK06EAYwmGqOQHV6Rikqdy/nU5IBGbbqE43jZk3ncgABDOZ3VX+x72xcaSDYwwRmLbcgeS7HUp/ 7R/mu3M7jQPGvesSecK1WqKtMornnIr79DtrD6/cC+JxfeKlbnGqZnnxAHfgLhxDB X-Received: by 2002:aa7:c150:: with SMTP id r16mr50496724edp.82.1620923964326; Thu, 13 May 2021 09:39:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2oIMAwKi64pSyQ+/EOA7l5jS4AZ6eeIr0+GVabPzXT3cRYsU1kb1XZCruo5g3CWbSvuKTcQ== X-Received: by 2002:aa7:c150:: with SMTP id r16mr50496711edp.82.1620923964198; Thu, 13 May 2021 09:39:24 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id x13sm1511947ejs.93.2021.05.13.09.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:23 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 05/10] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Date: Thu, 13 May 2021 18:38:53 +0200 Message-Id: <20210513163858.3928976-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "open list:ARM TCG CPUs" , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Guenter Roeck , Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core dumped) Fixes: bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- Cc: Guenter Roeck --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 5827c092b28..6bb34926bb5 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,6 +386,7 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 + select SDHCI config FSL_IMX31 bool From patchwork Thu May 13 16:38:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255993 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A334FC433B4 for ; Thu, 13 May 2021 16:59:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3993A613CA for ; Thu, 13 May 2021 16:59:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3993A613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEfu-0008Bl-40 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:59:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENB-0002XS-Jk for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEN2-0000wD-Sx for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjYvOAyPTrpSNhVqdAN7BGoQLHD/mxypL8yaob15sP8=; b=d/2nrCJ+P8jf4ZmHRa21qIKT0wzxiEG8neyC0ei4N/lLFgnQKKEFLXrbldW+EEsXX9zoIt FpE+qhk+msB7HFuGSGJ+Vw52zMPZYo9P6FXMKn9Fl3eaEswinSytuDQtcQdBGjhZI9Vamt pLqHUXHvkEOGOC7iL7wl0VXbtaYnKog= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-E9TKCaN5N_iHmZ3uJU5LUQ-1; Thu, 13 May 2021 12:39:30 -0400 X-MC-Unique: E9TKCaN5N_iHmZ3uJU5LUQ-1 Received: by mail-ed1-f70.google.com with SMTP id h18-20020a05640250d2b029038cc3938914so3253627edb.17 for ; Thu, 13 May 2021 09:39:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XjYvOAyPTrpSNhVqdAN7BGoQLHD/mxypL8yaob15sP8=; b=X1rSe0GMNiurOAsDtsplM7xPoj+K/dR2nxBX5FX1LI/itu/83hzmBbHM6hQpEPDhvW l3MXgkm1i/pKoA+H1DmbbixaOWWjbJiP5fBRNdySUpAQSSwxVSrShNjA7q6xN0XmSxGs SQ9L70gc/RU0uSwOHEVqreuGwrcumtifuAVB7tXn1t1ZEHX10yeHJXBgkJe7yszxEWTd 8tE+8wuT44ftGMh0qWqWn+kCtYUiDf2TgBYCPYfE0IT5TSSRMta1MiQyhGqHnNSse4u5 j5Ay3gslMZLUkY0V6mgyZ+MMe0KY+C0VSyjqEwtvnr2WTzjOKIOYupo9+5lwCYeNYUcj iJFg== X-Gm-Message-State: AOAM530vxYspKqCtNM53OVQUMOx66gq8527cEY8zrJKjm95vMTIZ+/oi EvJzAWzGcF5gQZS/VT9D00rgjeC5AmIDu5VW2Uf8//75T/67Xxa+dPBK5ZpFrfgi75jNW8u63MU fvEXWj/7G7rDsr6W8j9kYEPYjn/3A+jpjSdYTrswIWFljmoZgANUCCUElwL86bAEd X-Received: by 2002:a50:eb47:: with SMTP id z7mr52056289edp.68.1620923969310; Thu, 13 May 2021 09:39:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQQR8VCvYN64Fsq/tEUlN0mpcNMtt2b6hN9PG/yK7gHSmibN4yT03uqEfFRMs0WBiaNdkRSw== X-Received: by 2002:a50:eb47:: with SMTP id z7mr52056264edp.68.1620923969072; Thu, 13 May 2021 09:39:29 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id w21sm2598159edq.82.2021.05.13.09.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:28 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Date: Thu, 13 May 2021 18:38:54 +0200 Message-Id: <20210513163858.3928976-7-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V TCG CPUs" , Bin Meng , Alistair Francis , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Fix that to solve when built the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create': hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") Signed-off-by: Philippe Mathieu-Daudé --- Cc: Bin Meng Cc: Alistair Francis --- hw/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index 86957ec7b06..b72a248809e 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -12,6 +12,7 @@ config MICROCHIP_PFSOC select SIFIVE_CLINT select SIFIVE_PDMA select SIFIVE_PLIC + select SERIAL select UNIMP config OPENTITAN From patchwork Thu May 13 16:38:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35A4C433B4 for ; Thu, 13 May 2021 17:00:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EB036121E for ; Thu, 13 May 2021 17:00:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EB036121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEhD-0002Sd-6Y for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 13:00:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENC-0002aB-I4 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEN8-0000yu-Ql for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vt0rPlIVTA2zME2ANb52VRIm2f7ixfDlgEfuDufRLOU=; b=IexCJojMUMYhFmnQ6W79s6+fKCdMZekTAhkI0AjCacI9tzpUXpdEvqazCDTG69WeR9KPGg SvU9zWISxCQ73Zh7mXGHe9BhSn55xc9MOCNaPzYsfwbkgiDko2QjDI5zzt8G9oeKLf857b aKkH4+jENcYfTdg+DFX7OiWJWa8SFss= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-PKcSlLMnPjWv5nCSpzWcDg-1; Thu, 13 May 2021 12:39:36 -0400 X-MC-Unique: PKcSlLMnPjWv5nCSpzWcDg-1 Received: by mail-ej1-f72.google.com with SMTP id x20-20020a1709061354b02903cff4894505so1989730ejb.14 for ; Thu, 13 May 2021 09:39:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vt0rPlIVTA2zME2ANb52VRIm2f7ixfDlgEfuDufRLOU=; b=EscYRwryutM9q9aIYKkOuN+DNK3ErbQEQQq/8VruQeW7FMTKiLfJwH5lP73LNmU7Oi dyZOQioD8RtUCPrvWIwcVDuKWeSqcgaohixi/+j3ALP1STQjq5Zou/fQfcglMNXbChbY yjy9xCDP5kGboeRoYzYYnsyxyIbdMqkNojv3JF9CaD2zMG9nLRXvQBaNzN3lrFxJGH7q 7mWPWRAfhRs8SaUTYtAdgc7zcdMUElxFG62Z3HYt2dOSINfAZIATMh7SZTKvaLayo9C1 1oHuPH7Og4BAqo11eIOKV4OTwaZ1NcmojG4jM23ZWl/vahhHhXCInh4azZ0Xw6R+Ff41 Tkug== X-Gm-Message-State: AOAM531Zx/JHmA8OFQ9wsMPUR/1F9tTHjCz3vgaZiaC1xZKKuEjU/192 8MO6aTQjqqoRKV58GRrRbbPZ7CJdggLBQ/00msFf+AVpUuDPs6sKSHPoSUX7IVuH/6vEvNgBMoO off7LF+Ke+VjBkL/M/jy6oDCDBm0zW7BowZUVK5fU/uQa2+ungk7F3mdDplYeakWn X-Received: by 2002:a17:906:9246:: with SMTP id c6mr45279436ejx.10.1620923974156; Thu, 13 May 2021 09:39:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxE1l7ofRjRJFGt9vB7ZIomsyEQvq5BC5uZr95cBlF78n+jfrvZh5DW7F56Oa6yX27iwzRPlQ== X-Received: by 2002:a17:906:9246:: with SMTP id c6mr45279413ejx.10.1620923973899; Thu, 13 May 2021 09:39:33 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id r17sm2644904edt.33.2021.05.13.09.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:33 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 07/10] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Date: Thu, 13 May 2021 18:38:55 +0200 Message-Id: <20210513163858.3928976-8-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V TCG CPUs" , Bin Meng , Alistair Francis , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- hw/riscv/Kconfig | 5 +++++ hw/riscv/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index b72a248809e..b22736169c1 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -1,3 +1,6 @@ +config RISCV_NUMA + bool + config IBEX bool @@ -35,6 +38,7 @@ config RISCV_VIRT imply PCI_DEVICES imply VIRTIO_VGA imply TEST_DEVICES + select RISCV_NUMA select GOLDFISH_RTC select MSI_NONBROKEN select PCI @@ -75,6 +79,7 @@ config SIFIVE_U config SPIKE bool + select RISCV_NUMA select HTIF select MSI_NONBROKEN select SIFIVE_CLINT diff --git a/hw/riscv/meson.build b/hw/riscv/meson.build index a97454661c0..ab6cae57eae 100644 --- a/hw/riscv/meson.build +++ b/hw/riscv/meson.build @@ -1,6 +1,6 @@ riscv_ss = ss.source_set() riscv_ss.add(files('boot.c'), fdt) -riscv_ss.add(files('numa.c')) +riscv_ss.add(when: 'CONFIG_RISCV_NUMA', if_true: files('numa.c')) riscv_ss.add(files('riscv_hart.c')) riscv_ss.add(when: 'CONFIG_OPENTITAN', if_true: files('opentitan.c')) riscv_ss.add(when: 'CONFIG_RISCV_VIRT', if_true: files('virt.c')) From patchwork Thu May 13 16:38:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12256041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC99C433ED for ; Thu, 13 May 2021 17:03:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D66D61354 for ; Thu, 13 May 2021 17:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D66D61354 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEke-0008GL-Cv for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 13:03:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENE-0002fj-0H for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENC-00010c-9n for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=fVQDnjQ70ArC9PNqIIqFpPXf+2lRhZ8TUW1yuBySJHlIjN375yUqY2nGCoIMYZ31BOFmrd Id96KG23lQa5Q1RzLIteJHi+X2l80NP76wgN3x1MGyLEhl+2PamNIiPaF2FcPCz5QQS9G3 laDIyYnX6brw9WG1beHWQ7XlruHY/gI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-Y8oR7OqBOR-71WTKRZYJ4w-1; Thu, 13 May 2021 12:39:40 -0400 X-MC-Unique: Y8oR7OqBOR-71WTKRZYJ4w-1 Received: by mail-ed1-f70.google.com with SMTP id k10-20020a50cb8a0000b0290387e0173bf7so15044021edi.8 for ; Thu, 13 May 2021 09:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=GIX80vJLg/ZaJQPYxamfHXTbYe7qk6pI+bUm1V3f8PviYWlD+V8tyP+pT0Npl5AM8o V50ha6bIb9WGyA0EPvjMpftKmugg6m96mPlf4n/QRyHRralHuWee5ZhjjF1mASK/dCLb eHWih4CiXXjZAVtGsfkqxwFkRJI89ZPekBF0K8EyeqY4nUl+7XLE/eP0N7wabzIvnKRN xrVuhLC+BdeZrAQe4P9SQexwwzDk51LljeJswCLppiHDhFx6DevOPLWc9hzVURE0MsO5 tXhDtjBG0t8kxJtMYU511m8Du3OQYPnpsL9lZf+eLTCOgmE/ruhnfB+TCV8cMr5cA/Ax NUQw== X-Gm-Message-State: AOAM530cEAEADUYfPUy1HB5wGpxce02dd+LwD4lVD135AKEkmqKkcvz6 snobbXVFB2biJg5bVFdVXBmFjq6Jg+O8Ks1MNAtreY4InpNWR36wiOEyueKQLhvlSVKEOpNc6lP Q2WgCmovlY10HemmDLEpQC84bRkE/Giu4tDu1GOY/l+kgJT0OZa1yOXQLECl8TI7h X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117606edq.310.1620923978896; Thu, 13 May 2021 09:39:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAzVgm8Qwn9FiXpF/yuznqTA1YfSKUmYrD/MywIqRiF1fT01onNfI3Q+vOESyc3JUACn3t3A== X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117585edq.310.1620923978688; Thu, 13 May 2021 09:39:38 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id i6sm2713664eds.83.2021.05.13.09.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:38 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 08/10] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Date: Thu, 13 May 2021 18:38:56 +0200 Message-Id: <20210513163858.3928976-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kurz , Amit Singh Tomar , "open list:PowerPC TCG CPUs" , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Andrew Randrianasulu , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=y config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson Reviewed-by: Bin Meng --- Cc: Amit Singh Tomar Cc: Andrew Randrianasulu --- default-configs/devices/ppc-softmmu.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devices/ppc-softmmu.mak index c2d41198cde..5a7f99d1e45 100644 --- a/default-configs/devices/ppc-softmmu.mak +++ b/default-configs/devices/ppc-softmmu.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu # For embedded PPCs: -CONFIG_DS1338=y CONFIG_E500=y CONFIG_PPC405=y CONFIG_PPC440=y diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 66e0b15d9ef..2e4c56eb770 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -128,6 +128,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 config VIRTEX bool From patchwork Thu May 13 16:38:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D609C433ED for ; Thu, 13 May 2021 16:59:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0A2E6121E for ; Thu, 13 May 2021 16:59:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0A2E6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEgj-0001c5-SN for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENI-0002uV-H5 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENG-00014d-V3 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bFMY1wPkAX0kvucte6aKA1pZ+Ccdar2/PwwvnNc5vY=; b=GOwdpDKZCt8w68mlk2jWBTa1NBLupYS93EaMx1J6aJwjUw0prnC5HEZfnH3x647WMWJqQX MDAcJd94iubbTqoWz0FN2sJFa9lIXcQ2f6uwIeVyH5FjMcuJpbCenwLmJieRSaXypGW7RW VJ/QCq7xJa5AoPgEruZto/uF4EFb8OA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-1nPJV6mjNi2rc9op6nJj0g-1; Thu, 13 May 2021 12:39:44 -0400 X-MC-Unique: 1nPJV6mjNi2rc9op6nJj0g-1 Received: by mail-ed1-f70.google.com with SMTP id z12-20020aa7d40c0000b0290388179cc8bfso14863213edq.21 for ; Thu, 13 May 2021 09:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5bFMY1wPkAX0kvucte6aKA1pZ+Ccdar2/PwwvnNc5vY=; b=rPH/t/tmptHsmf1JerhmPznexgOoFbat3dn8xXPZvxBJem2P+vHIgJZ0S1PLcGFgK3 xC/HjfvaPrprv3Ml2jr6/vcoyO6dXI9Y3Z54+vN+ApD7qEz6iB7QqJTTeNeAojzdqA7/ COSkDuqA0OOtFx6ZqfXrdCnLYNhW1TK547MmEZ5bbws4Jb7MZnqLhjbz/5CHVdFQczPe bcsKB70QkVwFPd7WsnHMyywO0V4JONCQXxm0w9TAPmn6bztXwf184MmN8KM1W4eGnYU8 plA+9LOhvnchaoaaNynxiQJ0ickWbzRHWmdQlRWA+5YODHR97BA4/cV5YfDQlqZksj3B ktKw== X-Gm-Message-State: AOAM533KaicKjtIR/R/WWOrb/bvG9ytyXq5/Gq9kw2HNaEPDlcbWj2Ox LxkKW9k1okLq/NAX9oHfCUcVOQtuqtHwtDc0G8xxm+jBPXTAgNy8vwGBgsbHZAkpvWRRjA8+VXa iGkpR6OBbo6shdbDBFDtlecDQbkpIvo0O6n++6enNBfNPU2UpSxRLnjpjGL2MBahz X-Received: by 2002:aa7:cc98:: with SMTP id p24mr26599600edt.353.1620923983606; Thu, 13 May 2021 09:39:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9Yfa+X1wXqN++Raq2r/eiE8AApNA1VgBUQC+GklA6Tu6xOGbOboIOElrzIapP3GjQzgAk9A== X-Received: by 2002:aa7:cc98:: with SMTP id p24mr26599584edt.353.1620923983459; Thu, 13 May 2021 09:39:43 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id t22sm2705341edw.29.2021.05.13.09.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:43 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 09/10] default-configs/devices: Remove implicy SEMIHOSTING config Date: Thu, 13 May 2021 18:38:57 +0200 Message-Id: <20210513163858.3928976-10-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol which selects SEMIHOSTING. Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, they don't need to select SEMIHOSTING manually. Simplify. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- default-configs/devices/arm-softmmu.mak | 1 - default-configs/devices/riscv32-softmmu.mak | 1 - default-configs/devices/riscv64-softmmu.mak | 1 - 3 files changed, 3 deletions(-) diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devices/arm-softmmu.mak index 0500156a0c7..341d439de6f 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -41,6 +41,5 @@ CONFIG_MICROBIT=y CONFIG_FSL_IMX25=y CONFIG_FSL_IMX7=y CONFIG_FSL_IMX6UL=y -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y CONFIG_ALLWINNER_H3=y diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/devices/riscv32-softmmu.mak index d847bd5692e..5c9ad2590ef 100644 --- a/default-configs/devices/riscv32-softmmu.mak +++ b/default-configs/devices/riscv32-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards: diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/devices/riscv64-softmmu.mak index bc69301fa4a..8a92f0a2c74 100644 --- a/default-configs/devices/riscv64-softmmu.mak +++ b/default-configs/devices/riscv64-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards: From patchwork Thu May 13 16:38:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12256039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E5CC433B4 for ; Thu, 13 May 2021 17:03:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A84F561354 for ; Thu, 13 May 2021 17:03:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A84F561354 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEkS-0007Of-Pj for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 13:03:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENN-0003C8-A4 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENL-000183-MJ for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WadOX/ZSMqkQkMfPHC0fuGiD0zW0hwXcxoICsAvYPk=; b=FD1d6/wY3njUvAzG2sV37fWZDNQzD32o6PPLFi2ucfsGGbrTs92dZga0nCcCUjmzvRETIY rxmKNF7dMU52GGNf46qEJMjvFZoLxFIlqqw3rnEWcK0o8m4JGYvFd56Ip5V2Mp41r4QYIB u+/U+hbUap0jekauZOIo7Y9oQPeo3TU= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-91oD0jYBPdWjLFsDJzg_bg-1; Thu, 13 May 2021 12:39:49 -0400 X-MC-Unique: 91oD0jYBPdWjLFsDJzg_bg-1 Received: by mail-ed1-f71.google.com with SMTP id g7-20020aa7c5870000b02903888f809d62so15018066edq.23 for ; Thu, 13 May 2021 09:39:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3WadOX/ZSMqkQkMfPHC0fuGiD0zW0hwXcxoICsAvYPk=; b=TcROoNXKNmzAU3dK78cho8gb341mAS99SisHkiPyJtfC6CoLB1osqnQz/DD8Yl83X6 apV9Dk1gMC5XrTzHSEhR9YHMVq9PNeX7GsqjOWSYrw9yvoqFIW34kcX5IB2ludhLtXlW WHMKZRwnfDwckr1zV2TglY6tWbQywvAQRmKqk64w3VSMRt5Uf3MQIRvV6wdUA5xyEnvB Z+/tggtI94uRPu9Ppqq03VpdG1TUb9/CIQ1iNa+SO2XJuA4xL+xd5DkEgiB6KDIDEgbL rcAxC0fokedKaULZVD7uQdAMy0svYTdehUt3AlcRqLFU5TSLQBRt7Sp/E7IFcY5Qz8Bw eSJg== X-Gm-Message-State: AOAM533HjXS2QYY7C2dLjkpo8LNloNTvbFRG25qnqbDkkbZYS/WgvVEp kQWA9VNksDzrvLwRAl2DnffpmV41ORj7Fq+hOVtLLEBuFGqXrVdSGv0B1dwkbGPkcRz4J0oMoEX TWY8WmGiX/PcB0PhWsiaGzSXWyyan7Y4xxt5eoUJx68nt9vjacOlBvl+o0PkfFW6y X-Received: by 2002:a17:906:a20b:: with SMTP id r11mr44939268ejy.323.1620923988267; Thu, 13 May 2021 09:39:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMJ6G/mXyzvazrhxsdibSvEBgHlW+rXnAT9XNGvaw1X6w45ziPOwXYaDQ3/XElNOsKdyU9Iw== X-Received: by 2002:a17:906:a20b:: with SMTP id r11mr44939248ejy.323.1620923988073; Thu, 13 May 2021 09:39:48 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id h9sm2661538ede.93.2021.05.13.09.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:47 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required Date: Thu, 13 May 2021 18:38:58 +0200 Message-Id: <20210513163858.3928976-11-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets. Move the variable assignment out of the block documented with "Uncomment the following lines to disable these optional devices". Signed-off-by: Philippe Mathieu-Daudé --- default-configs/devices/arm-softmmu.mak | 4 +++- default-configs/devices/riscv32-softmmu.mak | 4 +++- default-configs/devices/riscv64-softmmu.mak | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devices/arm-softmmu.mak index 341d439de6f..2713e5e9eb7 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -1,5 +1,8 @@ # Default configuration for arm-softmmu +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y + # TODO: ARM_V7M is currently always required - make this more flexible! CONFIG_ARM_V7M=y @@ -41,5 +44,4 @@ CONFIG_MICROBIT=y CONFIG_FSL_IMX25=y CONFIG_FSL_IMX7=y CONFIG_FSL_IMX6UL=y -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y CONFIG_ALLWINNER_H3=y diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/devices/riscv32-softmmu.mak index 5c9ad2590ef..7219f9749ad 100644 --- a/default-configs/devices/riscv32-softmmu.mak +++ b/default-configs/devices/riscv32-softmmu.mak @@ -1,9 +1,11 @@ # Default configuration for riscv32-softmmu +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y + # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards: # diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/devices/riscv64-softmmu.mak index 8a92f0a2c74..1d1b8bb9f68 100644 --- a/default-configs/devices/riscv64-softmmu.mak +++ b/default-configs/devices/riscv64-softmmu.mak @@ -1,9 +1,11 @@ # Default configuration for riscv64-softmmu +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y + # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards: #