From patchwork Thu May 13 17:46:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 12256135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6239FC433ED for ; Thu, 13 May 2021 17:48:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E600261106 for ; Thu, 13 May 2021 17:48:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E600261106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=0UsuYQegczq4atObl6LIcryOZTcz9ejqRbGtxncPX30=; b=XM/33lsn1OqMrXfEShDS/gxbVY 1w2EFxbJw+dMntVsm5oAJn+fViE5UTTSsRO6Dnp9zlHd3YqH0OlUnMuIir5KxnekQSU7ue7A4Pv6R 6f8uD0Jc81mOAXg68RDXlSPmffrgJnmMm5h1MTfZBbkMoY8PS+OSY7djmtYzhCMdYyQZIa0758A5r Ofm+ShZDs1puwdeDFoOUM2qLy/pY3ZZUxTNFz55pjbIO9k2sRCMs1Vjo0edFTBxfGzoP0+8nEUDUf mBwq1HGIEWUkeLrFbaTZbUW+HFxVFsAIdRQiZogbB8OJG5WAS0q/vgwfijDu+9se467sJm3eMAMXA qOk9/wwA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPi-0065xf-7K; Thu, 13 May 2021 17:46:22 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPg-0065xI-5M for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 17:46:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=zdTDXiO3NCoXj2kA8r3dNvE7uEpdg8I31kDVNthsFDo=; b=zTtRR5CDIrjiS4sxK4vBP4x7bA lfe/d33RfvZDf7UwZL2WvYjl539l+FEDuTVyyhGHt8g21Rxk9yndiGRPtkSRqU8yAyX4Q1IlAEy0Z vR0gYzH5B9uR9uQs+jmqOOEvTPO8tvDR/aowSi0f10czi7GduXF61ogD9qzXL0SkvZdKFWAVwJA2H AA+wvt0HWM3OkaGJVipxBDtw/2V8zFt2TpN7tbBLvRdJ5ceIEw7pTWQFf0N42yZGL2VDuUXX9qvM1 4EmYp/00R1hL5pogS/WIXovzSUVtT0HwMSJsdwH3ILjWRPAPF33PITfxMVzO76T7gS2olpyKWdYWO zKAuDgyA==; Received: from mail-oi1-f178.google.com ([209.85.167.178]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPd-00BQQ9-70 for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 17:46:18 +0000 Received: by mail-oi1-f178.google.com with SMTP id v22so21179962oic.2 for ; Thu, 13 May 2021 10:46:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zdTDXiO3NCoXj2kA8r3dNvE7uEpdg8I31kDVNthsFDo=; b=Dlcpo73ohdB50k2X60R302go2GS8xrMpNrOWyVZdNWVpuESUCjIMVxakYLNDMFU8xQ b7y1zl6V7D2e+hNADMTsrvoJvQkg7PKD5q6XXQ3+9NCqxQD0G0OgjW78QE4ksKSR9nti ZOO3J7YFHlm2xqOAVFwpwgg2JGHPle86lsRbS3e2WAgANLiOHmSXoHwazUlzLAOQlXwJ EH2S3Odn/hdORgwi2bFye+9YbYtHrg2S7PDH5Lr4wj8+dBApadroUMn0KxJVDLviMU0x FWK+CMYEoMV1fS58OXMXfhAIGXqofqD/UIHlPsMyInf3KX2CWdjtsOvC4vH9lTjtzDhQ NZUQ== X-Gm-Message-State: AOAM533hA7O6c0XeScGxkSIx48cwhQLv+mh+j8EVFA9SLDmh2Ab6jwpH /43NZOenV2d/ckKqEg9H4Q== X-Google-Smtp-Source: ABdhPJwu1PMiWUZJT7NXkbCBsBEbkfjyoJAb+z9Xpcg555TCUXYlw1jL00oWGRfvNungPOXDwuivBQ== X-Received: by 2002:aca:1a16:: with SMTP id a22mr31566448oia.55.1620927976007; Thu, 13 May 2021 10:46:16 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id r7sm799574oom.46.2021.05.13.10.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 10:46:15 -0700 (PDT) From: Rob Herring To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Matt Fleming , Masayoshi Mizuma , John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: [PATCH 1/2] perf tests: Consolidate test__arch_unwind_sample declaration Date: Thu, 13 May 2021 12:46:13 -0500 Message-Id: <20210513174614.2242210-1-robh@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_104617_279727_0D58695C X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There's no reason for making the test__arch_unwind_sample declaration per arch. Currently that's done 2 different ways either with a declaration in arch-tests.h or with an arch define. Unify all this with an unconditional declaration in tests.h. Cc: Matt Fleming Cc: Masayoshi Mizuma Cc: John Garry Cc: Will Deacon Cc: Mathieu Poirier Cc: Leo Yan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: linux-arm-kernel@lists.infradead.org Cc: linux-perf-users@vger.kernel.org Signed-off-by: Rob Herring --- Note that the only thing really arch specific is getting the stack pointer. I'm happy to refactor this further to just an arch function to get the stack pointer reg. Compiled on arm64 and x86. --- tools/perf/arch/arm/include/arch-tests.h | 5 ----- tools/perf/arch/arm64/include/arch-tests.h | 5 ----- tools/perf/arch/powerpc/include/arch-tests.h | 7 ------- tools/perf/arch/powerpc/tests/dwarf-unwind.c | 1 - tools/perf/arch/x86/include/arch-tests.h | 7 ------- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 - tools/perf/tests/dwarf-unwind.c | 4 ---- tools/perf/tests/tests.h | 2 -- 8 files changed, 32 deletions(-) diff --git a/tools/perf/arch/arm/include/arch-tests.h b/tools/perf/arch/arm/include/arch-tests.h index 90ec4c8cb880..c62538052404 100644 --- a/tools/perf/arch/arm/include/arch-tests.h +++ b/tools/perf/arch/arm/include/arch-tests.h @@ -2,11 +2,6 @@ #ifndef ARCH_TESTS_H #define ARCH_TESTS_H -#ifdef HAVE_DWARF_UNWIND_SUPPORT -struct thread; -struct perf_sample; -#endif - extern struct test arch_tests[]; #endif diff --git a/tools/perf/arch/arm64/include/arch-tests.h b/tools/perf/arch/arm64/include/arch-tests.h index 90ec4c8cb880..c62538052404 100644 --- a/tools/perf/arch/arm64/include/arch-tests.h +++ b/tools/perf/arch/arm64/include/arch-tests.h @@ -2,11 +2,6 @@ #ifndef ARCH_TESTS_H #define ARCH_TESTS_H -#ifdef HAVE_DWARF_UNWIND_SUPPORT -struct thread; -struct perf_sample; -#endif - extern struct test arch_tests[]; #endif diff --git a/tools/perf/arch/powerpc/include/arch-tests.h b/tools/perf/arch/powerpc/include/arch-tests.h index 1c7be75cbc78..c62538052404 100644 --- a/tools/perf/arch/powerpc/include/arch-tests.h +++ b/tools/perf/arch/powerpc/include/arch-tests.h @@ -2,13 +2,6 @@ #ifndef ARCH_TESTS_H #define ARCH_TESTS_H -#ifdef HAVE_DWARF_UNWIND_SUPPORT -struct thread; -struct perf_sample; -int test__arch_unwind_sample(struct perf_sample *sample, - struct thread *thread); -#endif - extern struct test arch_tests[]; #endif diff --git a/tools/perf/arch/powerpc/tests/dwarf-unwind.c b/tools/perf/arch/powerpc/tests/dwarf-unwind.c index 8efd9ed9e9db..c9cb4b059392 100644 --- a/tools/perf/arch/powerpc/tests/dwarf-unwind.c +++ b/tools/perf/arch/powerpc/tests/dwarf-unwind.c @@ -7,7 +7,6 @@ #include "event.h" #include "debug.h" #include "tests/tests.h" -#include "arch-tests.h" #define STACK_SIZE 8192 diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h index 0e20f3dc69f3..462546bfc5f7 100644 --- a/tools/perf/arch/x86/include/arch-tests.h +++ b/tools/perf/arch/x86/include/arch-tests.h @@ -12,13 +12,6 @@ int test__intel_pt_pkt_decoder(struct test *test, int subtest); int test__bp_modify(struct test *test, int subtest); int test__x86_sample_parsing(struct test *test, int subtest); -#ifdef HAVE_DWARF_UNWIND_SUPPORT -struct thread; -struct perf_sample; -int test__arch_unwind_sample(struct perf_sample *sample, - struct thread *thread); -#endif - extern struct test arch_tests[]; #endif diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c index 478078fb0f22..a54dea7c112f 100644 --- a/tools/perf/arch/x86/tests/dwarf-unwind.c +++ b/tools/perf/arch/x86/tests/dwarf-unwind.c @@ -7,7 +7,6 @@ #include "event.h" #include "debug.h" #include "tests/tests.h" -#include "arch-tests.h" #define STACK_SIZE 8192 diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c index 83638097c3bc..a288035eb362 100644 --- a/tools/perf/tests/dwarf-unwind.c +++ b/tools/perf/tests/dwarf-unwind.c @@ -17,10 +17,6 @@ #include "callchain.h" #include "util/synthetic-events.h" -#if defined (__x86_64__) || defined (__i386__) || defined (__powerpc__) -#include "arch-tests.h" -#endif - /* For bsearch. We try to unwind functions in shared object. */ #include diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h index b85f005308a3..1100dd55b657 100644 --- a/tools/perf/tests/tests.h +++ b/tools/perf/tests/tests.h @@ -133,14 +133,12 @@ bool test__bp_account_is_supported(void); bool test__wp_is_supported(void); bool test__tsc_is_supported(void); -#if defined(__arm__) || defined(__aarch64__) #ifdef HAVE_DWARF_UNWIND_SUPPORT struct thread; struct perf_sample; int test__arch_unwind_sample(struct perf_sample *sample, struct thread *thread); #endif -#endif #if defined(__arm__) int test__vectors_page(struct test *test, int subtest); From patchwork Thu May 13 17:46:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 12256137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD870C433B4 for ; Thu, 13 May 2021 17:48:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C09261106 for ; Thu, 13 May 2021 17:48:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C09261106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ES0FalhPH+vTv+ZZzXNoWKOqHSWtwMnCmHuCd9kYdY4=; b=GV8aYTy3OQZFTC7D/PnxD9ZX4 jFbzN6y8AyTIGeNzJITB32hcw4gRA81CqY41HsqaaTXOLC23iP9V/RugnqTG/5BrX8YYMTQPTkkS0 EJrmPkBCPxoq2ryn+KfSmzLzAH4PXc61JISCPQ8LHl0LNPXS7+liif2meyCLQ+Iojs7EcJuxP8iSv J5ZeeMHVAGR1umq25ydRXA9hgjG66MfDWrSa+yRKTbKfwe7TllOhQGJktJileKe7LrMNdb0ymF71c wSR+o6l+UBP2tGa+SpHjXCzIDjCXxFYPKsR+DJWzGqbdb7b8TZehe6gfyvXgwxwhp6THsXpWuZEJu NM74H2V8g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPs-0065xw-BV; Thu, 13 May 2021 17:46:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPh-0065xR-0X for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 17:46:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=qtMRaGidq5AIIb5NEfzMSRmyxAUVpPVeHx2ahJS34Sw=; b=NLp3RhkYi1FCHClf+ZPFUjk6rf qp9pXGp11ew4Ns7wyDVdSCiECM4+g/DnElLeTJr2xznb++qYaUcPtItzVjfADfW64o+twrAA13oXY K5qz3aZW0iJhD9jb56ZNLIO/DKgANArB7Kufroi2gkohfgO0a93S1f26wrRDphgO7kdimje2x/g84 F/2/c8BvzELS1Gb2Yicxgb2e8n0uITxiMKnsyW+5JUhEyr9CcOSURPiEN4oqn1MhzKKTPA2gS4wqb MuMPrNqSvlcgBcl7a7bXDZ0Ii49fDsKIgDEz3Nz9IVx9BMOBlz7SuD/Af8XhOxmEzmqQxT79ZPh7v mYlpPrYg==; Received: from mail-oi1-f179.google.com ([209.85.167.179]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhFPe-00BQQO-I8 for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 17:46:19 +0000 Received: by mail-oi1-f179.google.com with SMTP id c3so26002847oic.8 for ; Thu, 13 May 2021 10:46:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qtMRaGidq5AIIb5NEfzMSRmyxAUVpPVeHx2ahJS34Sw=; b=OedoudDLV+okMdyV+URyzm89YCXxbGfdDZKK0QYEZ0/j7ciSkQKyW/qnFEqP+WmX0N oQ2A6KzrJjTEaXfdLMu6qMj2XXnRdP0/wmoLWAckTMxdW47hmsLyGSLUFcueLp5mnD64 33qOR//TDKSb7H8oUQDJ5+IITWx7tHQgcJL7S6lxjPW4LY7llce13kzwh1HydRezBFP4 FFUg0H/rwnBpZCau4x8hX7ZLdD6SXIdHOhsLrTMtAf6503GrQGWD2pURPBjV/O2uKNEU S3yskpkXErXoW0xU590bCrTi0vpxpoyOlPuzgpvY85275Oy2b8q44lorEmp3OLZPKItV eDMw== X-Gm-Message-State: AOAM532D1HK4Xu3mGzdDlHWe5Bs0llmXxtKgYTRaRbTOMrpok05WbXjB rugyiJ9vvHZZWCZnRl/aUQ== X-Google-Smtp-Source: ABdhPJwuMdqfKqn9iX2iIR2PPwGy55N98LKN3VvKhFptsqRWnJyzDnOhEEPv9Vyxo+12EJy9VC8Ugw== X-Received: by 2002:aca:5758:: with SMTP id l85mr4047077oib.120.1620927977614; Thu, 13 May 2021 10:46:17 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id r7sm799574oom.46.2021.05.13.10.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 10:46:17 -0700 (PDT) From: Rob Herring To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Matt Fleming , Masayoshi Mizuma , John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: [PATCH 2/2] perf tests: Drop __maybe_unused on x86 test declarations Date: Thu, 13 May 2021 12:46:14 -0500 Message-Id: <20210513174614.2242210-2-robh@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210513174614.2242210-1-robh@kernel.org> References: <20210513174614.2242210-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_104618_616107_E93250E7 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Function declarations don't need __maybe_unused annotations, only the implementations do. Drop them on the perf x86 tests. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: linux-perf-users@vger.kernel.org Signed-off-by: Rob Herring Acked-by: Jiri Olsa --- tools/perf/arch/x86/include/arch-tests.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h index 462546bfc5f7..9599e7a3f1af 100644 --- a/tools/perf/arch/x86/include/arch-tests.h +++ b/tools/perf/arch/x86/include/arch-tests.h @@ -2,12 +2,11 @@ #ifndef ARCH_TESTS_H #define ARCH_TESTS_H -#include struct test; /* Tests */ -int test__rdpmc(struct test *test __maybe_unused, int subtest); -int test__insn_x86(struct test *test __maybe_unused, int subtest); +int test__rdpmc(struct test *test, int subtest); +int test__insn_x86(struct test *test, int subtest); int test__intel_pt_pkt_decoder(struct test *test, int subtest); int test__bp_modify(struct test *test, int subtest); int test__x86_sample_parsing(struct test *test, int subtest);