From patchwork Tue Nov 27 19:24:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10701327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 983B614D6 for ; Tue, 27 Nov 2018 19:25:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89BE32C3B4 for ; Tue, 27 Nov 2018 19:25:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A9852C3BA; Tue, 27 Nov 2018 19:25:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F7892C3B4 for ; Tue, 27 Nov 2018 19:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbeK1GXz (ORCPT ); Wed, 28 Nov 2018 01:23:55 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45378 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726348AbeK1GXr (ORCPT ); Wed, 28 Nov 2018 01:23:47 -0500 Received: by mail-pl1-f196.google.com with SMTP id a14so16066556plm.12 for ; Tue, 27 Nov 2018 11:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g/OwqtmgRAMd4U0V7CJeRYYW1Xv+UBnENuWIkRgDFsI=; b=W4Xnc0SALXHsz9j4ByrOWWy847eCAQ6Wd2A84EDRsWc7ccN1/IT4QDaNoKSMM0TDJa R+Mg65g8yCPFXcGXoa6IlbEwhL4/q7NUCCY2vfgBJZAl+rRoGp59qH6KwlDM28gUYEHK gwApdT7YOjXtHZ3iCv75nd+PnNU8xhwDwErA4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g/OwqtmgRAMd4U0V7CJeRYYW1Xv+UBnENuWIkRgDFsI=; b=Q7/dwb+qZ9FxNjSOsUERqm/KLDFU9WlS02lthomDIVXkO5C3//cG0Z0NSKV6fpioO9 aHdvrJOZEIhJqW/vc0klcEl82dE+MFe45Eg60kLHqm4S1UEi8k7hSYOXW0TRI5QjDuGh kTHsgCEwlQ0cyC3lmNSZVx0lub1I143l2zoxES8ds0wBZVGTsJ1AXo4awktITrD8P2/g +6JnOoBpTq5+LQ5NN4fbirkWJps0DOT++7GIGWfhwUl75zCFsoWFnJnjVWch9tWGBwvO wiyPqaxUwEClh1QbTUHIR6sYbNucvvnJzi7ep6zAIH5MM4gwSd9Agj9VNjl0BoOmSjP1 D1dw== X-Gm-Message-State: AA+aEWa3ISSW/HkHU30glnnO6Cfn6TACoArrwrniI0pwMreCJiVV68lw Vx0D0rLG1wMHY+2SQhX02/iCtQ== X-Google-Smtp-Source: AFSGD/Xjp/XKfkBczfxJMIw5g2S8f8QQZtyqrvf/+O9/QAWxHFzXJV+OGoclwbuglCmki3KhqcR6Ow== X-Received: by 2002:a17:902:b701:: with SMTP id d1-v6mr32075209pls.29.1543346692646; Tue, 27 Nov 2018 11:24:52 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id i189-v6sm5543091pfc.16.2018.11.27.11.24.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 11:24:51 -0800 (PST) From: Douglas Anderson To: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, Taniya Das , Douglas Anderson , devicetree@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , linux-clk@vger.kernel.org Subject: [PATCH] dt-bindings: clock: Require #reset-cells in sdm845-videocc Date: Tue, 27 Nov 2018 11:24:43 -0800 Message-Id: <20181127192443.136158-1-dianders@chromium.org> X-Mailer: git-send-email 2.20.0.rc0.387.gc7a69e6b6c-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The #reset-cells was listed as optional in the bindings for qcom,sdm845-videocc. There's no reason for it to be optional. As per Stephen [1]: > We should update the binding to make it a required property. It > doesn't make any sense why that property would be optional given > that the hardware either has support for resets or it doesn't. sdm845 support is still in its infancy so we shouldn't be affecting any real device trees by modifying the bindings here. [1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings") Suggested-by: Stephen Boyd Signed-off-by: Douglas Anderson --- Documentation/devicetree/bindings/clock/qcom,videocc.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.txt b/Documentation/devicetree/bindings/clock/qcom,videocc.txt index e7c035afa778..8a8622c65c5a 100644 --- a/Documentation/devicetree/bindings/clock/qcom,videocc.txt +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.txt @@ -6,8 +6,6 @@ Required properties : - reg : shall contain base register location and length - #clock-cells : from common clock binding, shall contain 1. - #power-domain-cells : from generic power domain binding, shall contain 1. - -Optional properties : - #reset-cells : from common reset binding, shall contain 1. Example: @@ -16,4 +14,5 @@ Example: reg = <0xab00000 0x10000>; #clock-cells = <1>; #power-domain-cells = <1>; + #reset-cells = <1>; };