From patchwork Mon May 17 08:22:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pan, Xinhui" X-Patchwork-Id: 12261181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3012FC433ED for ; Mon, 17 May 2021 08:22:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD9A661184 for ; Mon, 17 May 2021 08:22:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD9A661184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 44B5A6E8EA; Mon, 17 May 2021 08:22:46 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E5C26E8EA; Mon, 17 May 2021 08:22:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q7QXlZBvKwFKp1y64Y1c3i7MNnG63qihCyScBFs3DFPLljjAxBqS5U6wDnSjUcqev6yqMPVKJTaw6hkANIMel7365nDItT45zYV2qBsakZiHXpJKaD0DJSVXmJwnZm13jO6y7QBzFno7AD97ajSR4nj7DDGRhFCp6spEbnoYykk7FUtxnWpHO1tUtP4p3mG9u4Pbu/Y1rJsJdinQKb2b8AZb1qIxkVYefeYrhUt47JGMFHL9wo7m89O6psnN2RUSAzKQQDf34LcjLT5z070cryy/n7ZYhZ1cpcCaHs+GLTD7SA7ovfu/0uCjeHtQKRGX//qipXbnEMEBE8HgYqRDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t0ERB0v+O04n0+NPzPFpx2SbGXpa2N0jA0T5cTCZEuw=; b=MCoKnwA4zPYNFNib5iKw7f8HqvvqgiyZGvxruZEI5ltL5W259xEzorKTFTIvIhY5hPn+rqGz+x8WBor7XR4ZxQ35aFJhsiYrjrbWjijlEzuJocJCi9BcvH5KiddGENbM/I3PL+aPCveJ6y+RbVHCH1THG+8T+CcvF4eenSWM3QfHXcsw/hmTVBMzFUa5oKbnYtvSiSFQ/f4r/m0ySEqCavaKE6TAHR79IcG/fUk39VcpOLgXSxGPedkee5TpxYc4MtE7XmjXtmipS4nAaMS4zaJhtKuCULAThwV7NVFs2nyGIp/pAQSGmgfQLdtAXTQG1uQAE80/ZBw4VDV4EnSLOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t0ERB0v+O04n0+NPzPFpx2SbGXpa2N0jA0T5cTCZEuw=; b=qhB6xMcbDoKney3P6vrRNrAW/EKFhI+yrzV6hCKUFd2IijhOUmWrgMDdSjwresiZlfsYdIg2dx5Djxf/qVFCWvI+132eYJHOTAY4xuOFjqeqFnj1IuIwNj0VPgCfNwI/R7XR9kIMbiKjUGoG7qmpCTtR7onWSuUB60bf+k5MR4E= Received: from DM4PR12MB5165.namprd12.prod.outlook.com (2603:10b6:5:394::9) by DM6PR12MB5518.namprd12.prod.outlook.com (2603:10b6:5:1b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Mon, 17 May 2021 08:22:43 +0000 Received: from DM4PR12MB5165.namprd12.prod.outlook.com ([fe80::4543:6802:6acc:c92d]) by DM4PR12MB5165.namprd12.prod.outlook.com ([fe80::4543:6802:6acc:c92d%5]) with mapi id 15.20.4129.031; Mon, 17 May 2021 08:22:43 +0000 From: "Pan, Xinhui" To: Yu Kuai , "Deucher, Alexander" , "Koenig, Christian" , "airlied@linux.ie" , "daniel@ffwll.ch" Subject: =?eucgb2312_cn?b?u9i4tDogW1BBVENIXSBkcm0vYW1kZ3B1OiBmaXggUE0gcmVmZXJlbmNl?= =?eucgb2312_cn?b?IGxlYWsgaW4gYW1kZ3B1X2RlYnVnZnNfZ2Z4b2ZmX3JlYSgp?= Thread-Topic: [PATCH] drm/amdgpu: fix PM reference leak in amdgpu_debugfs_gfxoff_rea() Thread-Index: AQHXSvPpcLPz3EMHG0SAziNVEtRCPqrnVRtv Date: Mon, 17 May 2021 08:22:43 +0000 Message-ID: References: <20210517081632.1563569-1-yukuai3@huawei.com> In-Reply-To: <20210517081632.1563569-1-yukuai3@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=True; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-05-17T08:22:42.888Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD-Official Use Only; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [180.167.199.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ddec04b4-a47f-48eb-85db-08d9190cf1c3 x-ms-traffictypediagnostic: DM6PR12MB5518: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hswYKjpNLnwvcWtrmSF3SuaUhbPs1qcUGtAs5+rZFZ5+Cb24qbErJ1sddOJC4i+Lz55Mc20mRbQ52Y/d4VolYQMjNH8Gyg1aAuJT+b63LlVKohpI3m3hsLs0QTM8ohfJDh6M9OVQ355NVGFs0xO0pDlsGpooP8zpm4IwwEFomkaICRyTapMcY9pqgts9pFtL5djIJO3TGTtX+KmEH1yUF11uCTVoZH++1wXFyKkidQJrSLlTMSACf86D2lTtS71Iy1QDjd0qZ2+/VoDoKDvNWBV4B1LeqHSLsiQMuptSvVzclkQGEDSfpiXE6u+lrRoI4fYsq7x2/FCSEUlyf3Fd7yGRWXKORsBdpjEHVNiYFb1CYf01TjQfRMpxPBZYlgZAGhvS9LQQYdPqoASs+5trnpzRP6rikfL+AtFC1PWvKgpJqk2Pv9LlGt6sCtwhECvG1r1GXujizzaBS5iHyRtl80DmtBSNhdcfsYpOghvX5mxk3tXAuwmyfsC5KneQR/2Wl1ytq1PdiM7fh0EIiqUPjGRjaXk40GGvYRNKaujME/3u8Tp1GqBmDD0SAzTH5Kb8tRT4wB+NnMsaKa1GwOH6hnz6nYLL5rLDAhX7H2RBu6k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5165.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(39860400002)(366004)(71200400001)(224303003)(9686003)(55016002)(83380400001)(8936002)(6506007)(38100700002)(33656002)(122000001)(76116006)(66446008)(26005)(7696005)(64756008)(2906002)(478600001)(186003)(86362001)(66946007)(66556008)(91956017)(316002)(110136005)(4326008)(66476007)(5660300002)(54906003)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?eucgb2312_cn?b?ZHZ1ZS8vdWpQSlM3akZVMjlGMlJK?= =?eucgb2312_cn?b?RTlIY216N2xyTDdVK1BEODg3WFN0Y0R1YnBNQzVNNHoybFdlWHk2QlM4YW8rR1Mr?= =?eucgb2312_cn?b?aEt4R3dkOFc4WWwydk1RS3JkZlBZZitVTHBlTTc5cXFpa1VRNERnSDIyVnhhRGpy?= =?eucgb2312_cn?b?alBHOFBZVVA4c1g2bks3NHJrZXJiUHJqOEZTMGVkRi9uc1Y5R29TSGRDYWRCcVEw?= =?eucgb2312_cn?b?RnJsUHo0eHdDajJqdXNTVzFOR3FXSHo0MXd3Y0tCUUkwQjNWNHU1dU1HTWpnLzhk?= =?eucgb2312_cn?b?WTY3NXFLRGIvQmpHSkJoT0lnNVhuYU0ycEVBWHFqbmR6WUcvc0tqRk1SZFIvU0l1?= =?eucgb2312_cn?b?a3FUU1ZxaGszQ0MxSlh2QzZlWk1yVDM0Z0RiVHVVL3Y0dTRCVGdyL3k0b2hWSDhH?= =?eucgb2312_cn?b?OENrdU9qV3d3dVhueHdSeWpIWTJWcTlLUW1oUHBCZHQ5eDJQN2Q0RXN0MnF4U3p6?= =?eucgb2312_cn?b?NzUzZVpJMDg4NnZiWkJFWk5zWFRsREtvVHp1K3M5YVB5TDRhMEdqR1VJcElTOXBW?= =?eucgb2312_cn?b?N1IzM21JRUtJdEEvcTBDWkJPRmxPTHZqMzZBeWFWTS9KRlJ2bXE4NDNrTDBES29Q?= =?eucgb2312_cn?b?enJnWnBhY0ZYeG5zai9EelVDTThibUpHNjdYcGE4d1pHMjdGZWdIYTN3QURzYXZH?= =?eucgb2312_cn?b?UnpyRU9qZExrcUZsT2N3RTg2VERRd2lFVks5bUFEZzhOZWQrQlNTelpzdDVDcXR0?= =?eucgb2312_cn?b?eUxPNWJ0K0IwbWt5ZlprWVhkcE4xNXdXbldHNE1FNUtmQVdZQm9MWkJVM2wwS3Q3?= =?eucgb2312_cn?b?QVpOTTNSTC95S0NDYjVNT0t5TVZYbzFHRlRRanB3VSt0dmY5NHRNTVRmZjZQakN4?= =?eucgb2312_cn?b?akF1MUdlaFZjaWd5SEVwbHpnNmdGbkVCNjlMa3lPUFNwUExWY2pBL3N1cXd4QlZz?= =?eucgb2312_cn?b?MmNidFh1WE0ydzhiNW9HYmRJa1BQeFZVbFdrbGlydHFVbEVPSXNGeTVuak80bnBm?= =?eucgb2312_cn?b?Q0VIUGRrdjhNbWN5L2dLYTB6U2IyQjhsY0N4SC9VYkJzeVlyWUpEVjNBTlJHM04v?= =?eucgb2312_cn?b?cUlGU08zZ2J2VGxHb21BQXowYjJ0YllJSys3NTZkOW95VkRsMm1Xa0Q5Vis4Ykw0?= =?eucgb2312_cn?b?M2VMdHZLRDRncENLZ21zTE81OXAzb2lXMkFCdmc1eHNXOVIzb2dGMDVoS3BGMDNK?= =?eucgb2312_cn?b?K3k0WEJxL2VOTDdTelV5bW9scEZDWXFHSFZ1TUxzZkkxSjhkSnNjTlFVQm94OGhU?= =?eucgb2312_cn?b?NXB0SU84VnpDQXFYSGM4bjRBOVhOVEprWWF0d2V2a0hWNXd0ZXU0MU9xY1Q0emR4?= =?eucgb2312_cn?b?Q3R4bG1oNUIrNHRjaHFpWFBtRFhOQVRzQW9nQnl5RTlBaS92NHVrblVmb0gzK1dQ?= =?eucgb2312_cn?b?RlBhVzQySnI2VnBkT3dCWFRyZkpOUThEOVUrbUVIVHNaKy9pNnVEUlVRcnZlMW1a?= =?eucgb2312_cn?b?NXA0SkFDQnhmMHdOQzQxMHZ0eEZNZlQybGxSekVKNGJERXM2ZWJ0Y09mZHpXTWRC?= =?eucgb2312_cn?b?SzYxaDl5blRqRG56M1pCMlE2TTR6N2VCWFVWN3M3b09BQklmMzJkK1FLTnVkc3Vh?= =?eucgb2312_cn?b?MmM1ZHcvWHpBb0tla3JXR21oTXlRVjdESWlRT1c0ZjhPYTJ2YmRSRXBUbENFT2tR?= =?eucgb2312_cn?b?QU4xa0VlUGJKSHNJSStYbjZnQXVxcHNHckx2Ymd1TndPZGNlZnM1UmdrSG8rQWpv?= =?eucgb2312_cn?b?ZFNZTFFnbHB4aUFVWndHVWVaNlhieWhKeDRsZDAvQ3EwUGV0ZmhHeWNSMldwL0Vp?= =?eucgb2312_cn?b?MmZXZmVwR1M0Z0hrbmQySHpzM2w5SjVuUXE5?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5165.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddec04b4-a47f-48eb-85db-08d9190cf1c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2021 08:22:43.5403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r5BO6aGwLe4i/p9cW9/4gsZpZcY3NjWZ5aLoeyWerG79EXkPVx4Dok0TdGaI5C/+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5518 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "yi.zhang@huawei.com" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [AMD Official Use Only] thanks Kuai. But code below matches the other code block in this file. r = pm_runtime_get_sync(dev->dev); if (r < 0) { pm_runtime_put_autosuspend(dev->dev); return r; } diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c index bcaf271b39bf..eb7f9d20dad7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c @@ -1058,7 +1058,7 @@ static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf, if (size & 0x3 || *pos & 0x3) return -EINVAL; - r = pm_runtime_get_sync(adev_to_drm(adev)->dev); + r = pm_runtime_resume_and_get(adev_to_drm(adev)->dev); if (r < 0) return r;