From patchwork Tue Nov 27 23:06:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michele Sorcinelli X-Patchwork-Id: 10701619 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6081C14BD for ; Tue, 27 Nov 2018 23:33:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FDA62C9F5 for ; Tue, 27 Nov 2018 23:33:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 439332C9F8; Tue, 27 Nov 2018 23:33:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DAAA2C9F5 for ; Tue, 27 Nov 2018 23:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726304AbeK1Kcu (ORCPT ); Wed, 28 Nov 2018 05:32:50 -0500 Received: from confino.investici.org ([212.103.72.250]:29124 "EHLO confino.investici.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbeK1Kcu (ORCPT ); Wed, 28 Nov 2018 05:32:50 -0500 X-Greylist: delayed 1574 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Nov 2018 05:32:50 EST Received: from [212.103.72.250] (confino [212.103.72.250]) (Authenticated sender: mikefender@cryptolab.net) by localhost (Postfix) with ESMTPSA id A56DB62536; Tue, 27 Nov 2018 23:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1543360026; bh=A92VaqWw9sxUZGzi6dpSiFfldo44yS+b96N8gwToLzc=; h=From:To:Cc:Subject:Date; b=j0n0H/Kd2FKMhW5ZFIsqY1AXhn0IXbl7ukqhHcxh6TaDUjERq7mwlYEQJYUzBWuo4 4eD3E3xuAFzSi3CAbvvGSyeeVMSeKicmsALQFmmxknRLcA4wM/7xe2aNqex4gjWUcZ 2J8VBo1YCn1JDk+vm1BKaACV/p5GAAp8N8h4mkTQ= From: Michele Sorcinelli To: =?utf-8?q?Pali_Roh=C3=A1r?= Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Michele Sorcinelli Subject: [PATCH] dell-smm-hwmon.c: Add XPS 9570 to supported devices list Date: Tue, 27 Nov 2018 23:06:37 +0000 Message-Id: <20181127230637.8673-1-michelesr@autistici.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Allow the module to be loaded on Dell XPS 9570, without having to use the "force=1" option. The module loads without problems, and reports correct fan values: $ time cat /proc/i8k 1.0 1.5 -1 35 0 0 0 0 -1 -22 cat /proc/i8k 0.00s user 0.00s system 7% cpu 0.033 total However, the call may freeze the kernel for a very small time due to code running in the SSM layer. This is a known issue with the driver, and can be reproduced with other supported models. Average execution time is 33 ms. The command line tools from i8kutils can properly set the fan speed, although the firmware will override it, unless automatic fan control is disabled with the proper SSM call. Average fans speed (when firwmare automatic control is off): STATE -> RPM 0 0 -> 0 0 1 1 -> 2500 2500 2 2 -> 5100 5100 3 3 -> same as 2 2 Reviewed-by: Pali Rohár --- drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 9d3ef879d..367a8a617 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1017,6 +1017,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"), }, }, + { + .ident = "Dell XPS 15 9570", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"), + }, + }, { } };