From patchwork Wed May 19 18:21:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Gix X-Patchwork-Id: 12268073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC05C433ED for ; Wed, 19 May 2021 18:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E02536124C for ; Wed, 19 May 2021 18:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbhESSXa (ORCPT ); Wed, 19 May 2021 14:23:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:32191 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231349AbhESSXa (ORCPT ); Wed, 19 May 2021 14:23:30 -0400 IronPort-SDR: JYECfz9NyGyneCdTdzlBx3aFKFzyPPj0RaB6fjt0JhDkRlvq36HeKn8Dcu6ajVyoOHxJybLrfw 5ucj7+SRWoxg== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="188175119" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="188175119" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 IronPort-SDR: B7XPx9d/xJ/Q3mf2CyV99hcDuj1zxRbwvjTMu8/LE/htgDv12pDrI77vUNPAivwaZcEjC77ZCt 05JyaQS9Nc9g== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="439838647" Received: from bgi1-mobl2.amr.corp.intel.com ([10.212.229.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:08 -0700 From: Brian Gix To: linux-bluetooth@vger.kernel.org Cc: inga.stotland@intel.com, brian.gix@intel.com Subject: [PATCH BlueZ v2 1/5] mesh: Fix delivery of PB-ACK to acceptors Date: Wed, 19 May 2021 11:21:46 -0700 Message-Id: <20210519182150.1680987-2-brian.gix@intel.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20210519182150.1680987-1-brian.gix@intel.com> References: <20210519182150.1680987-1-brian.gix@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Rwmove unneeded initialization that prevented the Acceptor roll of ever recognizing a valid PB-ACK. --- mesh/pb-adv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index c74dae79f..83f922aa8 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len) first = !session->link_id; session->link_id = link_id; session->last_peer_trans_num = 0xFF; - session->local_acked = 0xFF; session->peer_trans_num = 0x00; session->local_trans_num = 0x7F; session->opened = true; From patchwork Wed May 19 18:21:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Gix X-Patchwork-Id: 12268077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924B7C43460 for ; Wed, 19 May 2021 18:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72DDD61353 for ; Wed, 19 May 2021 18:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231376AbhESSXb (ORCPT ); Wed, 19 May 2021 14:23:31 -0400 Received: from mga02.intel.com ([134.134.136.20]:32191 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbhESSXa (ORCPT ); Wed, 19 May 2021 14:23:30 -0400 IronPort-SDR: iwZNCdZkBuXf9nQsvg0byOYA3x5R1TOxi2pKIZ65lLqu/Bk4C5q9QR4W2Sv+mxmArq8H6kAC/z 84Sj9l+QSUsA== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="188175123" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="188175123" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 IronPort-SDR: fE2nuZavwADey3THaqNsxiLXjciPJ1mVCs2QqDAvZA4tIUaVA0PfbRtbdRmt2GK0ykrBnS3RIk 66VFUQgdj6/w== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="439838650" Received: from bgi1-mobl2.amr.corp.intel.com ([10.212.229.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 From: Brian Gix To: linux-bluetooth@vger.kernel.org Cc: inga.stotland@intel.com, brian.gix@intel.com Subject: [PATCH BlueZ v2 2/5] nesh: Normalize endian of public/private ECC keys Date: Wed, 19 May 2021 11:21:47 -0700 Message-Id: <20210519182150.1680987-3-brian.gix@intel.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20210519182150.1680987-1-brian.gix@intel.com> References: <20210519182150.1680987-1-brian.gix@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The Mesh profile specification defines a Mesh byte order of Big Endian for Public keys used to calculate shared secrets. Further the specification sample data also show this same byte order for Private keys. However, our internal ECDH shared secret calculation requires Little Endian byte ordering. This fixes our DBus interface, and debugging output to use Mesh Byte Ordering (Big Endian) for all human readable input/output. --- mesh/prov-acceptor.c | 8 +++++++- mesh/prov-initiator.c | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/mesh/prov-acceptor.c b/mesh/prov-acceptor.c index e806b12ef..0dbb84f50 100644 --- a/mesh/prov-acceptor.c +++ b/mesh/prov-acceptor.c @@ -223,7 +223,11 @@ static bool acp_credentials(struct mesh_prov_acceptor *prov) print_packet("PublicKeyProv", prov->conf_inputs.prv_pub_key, 64); print_packet("PublicKeyDev", prov->conf_inputs.dev_pub_key, 64); + + /* Normalize for debug out -- No longer needed for calculations */ + swap_u256_bytes(prov->private_key); print_packet("PrivateKeyLocal", prov->private_key, 32); + print_packet("ConfirmationInputs", &prov->conf_inputs, sizeof(prov->conf_inputs)); print_packet("ECDHSecret", prov->secret, 32); @@ -307,11 +311,13 @@ static void priv_key_cb(void *user_data, int err, uint8_t *key, uint32_t len) return; } + /* API delivers Mesh byte order, switch to little endian */ + swap_u256_bytes(key); memcpy(prov->private_key, key, 32); ecc_make_public_key(prov->private_key, prov->conf_inputs.dev_pub_key); - /* Convert to Mesh byte order */ + /* Convert Public key to Mesh byte order */ swap_u256_bytes(prov->conf_inputs.dev_pub_key); swap_u256_bytes(prov->conf_inputs.dev_pub_key + 32); diff --git a/mesh/prov-initiator.c b/mesh/prov-initiator.c index ae9c646de..c62577523 100644 --- a/mesh/prov-initiator.c +++ b/mesh/prov-initiator.c @@ -222,6 +222,9 @@ static bool int_credentials(struct mesh_prov_initiator *prov) print_packet("PublicKeyProv", prov->conf_inputs.prv_pub_key, 64); print_packet("PublicKeyDev", prov->conf_inputs.dev_pub_key, 64); + + /* Print DBG out in Mesh order */ + swap_u256_bytes(prov->private_key); print_packet("PrivateKeyLocal", prov->private_key, 32); print_packet("ConfirmationInputs", &prov->conf_inputs, sizeof(prov->conf_inputs)); From patchwork Wed May 19 18:21:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Gix X-Patchwork-Id: 12268079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160EDC43462 for ; Wed, 19 May 2021 18:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6C946124C for ; Wed, 19 May 2021 18:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231381AbhESSXb (ORCPT ); Wed, 19 May 2021 14:23:31 -0400 Received: from mga02.intel.com ([134.134.136.20]:32191 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbhESSXa (ORCPT ); Wed, 19 May 2021 14:23:30 -0400 IronPort-SDR: Y3hcyNRbQGgt/cxnJF9LcnOtJpgx0wDBnNobJ1HYnOYOJiYTITCQZCbYAC6kVLp9j4k52g9IvM sDzncdi6eQdg== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="188175125" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="188175125" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:10 -0700 IronPort-SDR: Pki1Cdi8WiKsWcsNjt0f7JynskDlkQ0IlCe91K7pwyQyQtcye7moIZ+uUCrifIjoc+WHRyOigo /+o0OSJ0WT5A== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="439838654" Received: from bgi1-mobl2.amr.corp.intel.com ([10.212.229.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 From: Brian Gix To: linux-bluetooth@vger.kernel.org Cc: inga.stotland@intel.com, brian.gix@intel.com Subject: [PATCH BlueZ v2 3/5] tools/mesh: Add all supported OOB methods to cfgclient Date: Wed, 19 May 2021 11:21:48 -0700 Message-Id: <20210519182150.1680987-4-brian.gix@intel.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20210519182150.1680987-1-brian.gix@intel.com> References: <20210519182150.1680987-1-brian.gix@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org To support the widest range of mesh devices, we need to support any possible capability combinations that a remote device may request. --- tools/mesh-cfgclient.c | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/tools/mesh-cfgclient.c b/tools/mesh-cfgclient.c index 49069674f..a4a6f21ab 100644 --- a/tools/mesh-cfgclient.c +++ b/tools/mesh-cfgclient.c @@ -104,7 +104,17 @@ static struct model_info *cfgcli; static struct l_queue *devices; static bool prov_in_progress; -static const char *caps[] = {"static-oob", "out-numeric", "in-numeric"}; +static const char * const caps[] = {"static-oob", + "push", + "twist", + "blink", + "beep", + "vibrate", + "public-oob", + "out-alpha", + "in-alpha", + "out-numeric", + "in-numeric"}; static bool have_config; @@ -419,7 +429,7 @@ static void agent_input_done(oob_type_t type, void *buf, uint16_t len, struct l_dbus_message *reply = NULL; struct l_dbus_message_builder *builder; uint32_t val_u32; - uint8_t oob_data[16]; + uint8_t oob_data[64]; switch (type) { case NONE: @@ -435,15 +445,15 @@ static void agent_input_done(oob_type_t type, void *buf, uint16_t len, /* Fall Through */ case HEXADECIMAL: - if (len > 16) { + if (len > sizeof(oob_data)) { bt_shell_printf("Bad input length\n"); break; } - memset(oob_data, 0, 16); + memset(oob_data, 0, sizeof(oob_data)); memcpy(oob_data, buf, len); reply = l_dbus_message_new_method_return(msg); builder = l_dbus_message_builder_new(reply); - append_byte_array(builder, oob_data, 16); + append_byte_array(builder, oob_data, len); l_dbus_message_builder_finalize(builder); l_dbus_message_builder_destroy(builder); break; @@ -580,6 +590,16 @@ static struct l_dbus_message *prompt_numeric_call(struct l_dbus *dbus, return NULL; } +static struct l_dbus_message *prompt_public_call(struct l_dbus *dbus, + struct l_dbus_message *msg, + void *user_data) +{ + l_dbus_message_ref(msg); + agent_input_request(HEXADECIMAL, 64, "Enter 512 bit Public Key", + agent_input_done, msg); + return NULL; +} + static struct l_dbus_message *prompt_static_call(struct l_dbus *dbus, struct l_dbus_message *msg, void *user_data) @@ -618,6 +638,8 @@ static void setup_agent_iface(struct l_dbus_interface *iface) "u", "s", "number", "type"); l_dbus_interface_method(iface, "PromptStatic", 0, prompt_static_call, "ay", "s", "data", "type"); + l_dbus_interface_method(iface, "PublicKey", 0, prompt_public_call, + "ay", "", "data"); } static bool register_agent(void) From patchwork Wed May 19 18:21:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Gix X-Patchwork-Id: 12268081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0739EC433ED for ; Wed, 19 May 2021 18:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBEB6611BF for ; Wed, 19 May 2021 18:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbhESSXc (ORCPT ); Wed, 19 May 2021 14:23:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:32191 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbhESSXb (ORCPT ); Wed, 19 May 2021 14:23:31 -0400 IronPort-SDR: tq3uyetoQbDlIM0z6OifqnopVg0I3RAO91QAZPmrKWpaAmE3KZQ4icWhWoiIVCCp9nHhqJ4wFR DbIfQEKfPflQ== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="188175126" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="188175126" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:10 -0700 IronPort-SDR: QLx7tLkIRlkoE8K8uHL7J6APZRIdiP2owKUjV2vKDvXvQZ6dPE8I9Um7lJFKcujo9ouZjj8frL YpxOt1TPmpUA== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="439838657" Received: from bgi1-mobl2.amr.corp.intel.com ([10.212.229.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 From: Brian Gix To: linux-bluetooth@vger.kernel.org Cc: inga.stotland@intel.com, brian.gix@intel.com Subject: [PATCH BlueZ v2 4/5] test/mesh: Add support for testing more OOB auth Date: Wed, 19 May 2021 11:21:49 -0700 Message-Id: <20210519182150.1680987-5-brian.gix@intel.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20210519182150.1680987-1-brian.gix@intel.com> References: <20210519182150.1680987-1-brian.gix@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org To pass IOP testing, we need to be able to support Input OOB and Out of band Public Key exchange, This patch adds agent methods to support those capabilities, but are turned off because the test code uses insecure fixed values instead of randomized values. --- test/agent.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/test/agent.py b/test/agent.py index b46cd95f4..57a74183d 100755 --- a/test/agent.py +++ b/test/agent.py @@ -35,7 +35,9 @@ class Agent(dbus.service.Object): caps = [] oob = [] caps.append('out-numeric') + #caps.append('in-numeric') -- Do not use well known in-oob caps.append('static-oob') + #caps.append('public-oob') -- Do not use well known key pairs oob.append('other') return { AGENT_IFACE: { @@ -56,6 +58,27 @@ class Agent(dbus.service.Object): print(set_cyan('DisplayNumeric ('), type, set_cyan(') number ='), set_green(value)) + @dbus.service.method(AGENT_IFACE, in_signature="s", out_signature="u") + def PromptNumeric(self, type): + # Sample in-oob -- DO-NOT-USE + value = 12345 + print(set_cyan('PromptNumeric ('), type, + set_cyan(') number ='), set_green(value)) + return dbus.UInt32(value) + + @dbus.service.method(AGENT_IFACE, in_signature="", out_signature="ay") + def PrivateKey(self): + # Sample Public/Private pair from Mesh Profile Spec DO-NOT-USE + private_key_str = '6872b109ea0574adcf88bf6da64996a4624fe018191d9322a4958837341284bc' + public_key_str = 'ce9027b5375fe5d3ed3ac89cef6a8370f699a2d3130db02b87e7a632f15b0002e5b72c775127dc0ce686002ecbe057e3d6a8000d4fbf2cdfffe0d38a1c55a043' + print(set_cyan('PrivateKey ()')) + print(set_cyan('Enter Public key on remote device: '), + set_green(public_key_str)); + private_key = bytearray.fromhex(private_key_str) + + return dbus.Array(private_key, signature='y') + + @dbus.service.method(AGENT_IFACE, in_signature="s", out_signature="ay") def PromptStatic(self, type): static_key = numpy.random.randint(0, 255, 16) From patchwork Wed May 19 18:21:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Gix X-Patchwork-Id: 12268083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55533C43461 for ; Wed, 19 May 2021 18:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D78161353 for ; Wed, 19 May 2021 18:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbhESSXd (ORCPT ); Wed, 19 May 2021 14:23:33 -0400 Received: from mga02.intel.com ([134.134.136.20]:32196 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231349AbhESSXb (ORCPT ); Wed, 19 May 2021 14:23:31 -0400 IronPort-SDR: 7opeTBdAjsvC6iogaIvrUOGO5ZmQgMDt3OZIa+3k7UigoA/lQ+oXN7rwAKCiAm/YRU6yoU5xdH PVIlYYYw7ROA== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="188175127" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="188175127" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:10 -0700 IronPort-SDR: L+lgoYgn2WKlzko5HSRYu7I4NIVjMFHEODsXDRNtxk9LE6gUxL+WMz2besUCmUsGAWdA4inb2m 6wNbzWgYtdIA== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="439838662" Received: from bgi1-mobl2.amr.corp.intel.com ([10.212.229.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 11:22:09 -0700 From: Brian Gix To: linux-bluetooth@vger.kernel.org Cc: inga.stotland@intel.com, brian.gix@intel.com Subject: [PATCH BlueZ v2 5/5] mesh: Add single threading to prov-acp ob messaging Date: Wed, 19 May 2021 11:21:50 -0700 Message-Id: <20210519182150.1680987-6-brian.gix@intel.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20210519182150.1680987-1-brian.gix@intel.com> References: <20210519182150.1680987-1-brian.gix@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Certain IOP and stress testing scenarios can cause additional outbound messages to be attempted before the prior outbound message completes. This patch adds queuing if outbpund messages are attempted too quickly so that the additional message is not sent until the prior message is ACKed. --- mesh/prov-acceptor.c | 88 +++++++++++++++++++++++++++----------------- mesh/provision.h | 1 + 2 files changed, 56 insertions(+), 33 deletions(-) diff --git a/mesh/prov-acceptor.c b/mesh/prov-acceptor.c index 0dbb84f50..f579a143b 100644 --- a/mesh/prov-acceptor.c +++ b/mesh/prov-acceptor.c @@ -42,26 +42,15 @@ static const uint16_t expected_pdu_size[] = { #define BEACON_TYPE_UNPROVISIONED 0x00 +struct deferred_cmd { + uint16_t len; + uint8_t cmd[]; +}; + static const uint8_t pkt_filter = MESH_AD_TYPE_PROVISION; static const uint8_t bec_filter[] = {MESH_AD_TYPE_BEACON, BEACON_TYPE_UNPROVISIONED}; -enum acp_state { - ACP_PROV_IDLE = 0, - ACP_PROV_CAPS_SENT, - ACP_PROV_CAPS_ACKED, - ACP_PROV_KEY_SENT, - ACP_PROV_KEY_ACKED, - ACP_PROV_INP_CMPLT_SENT, - ACP_PROV_INP_CMPLT_ACKED, - ACP_PROV_CONF_SENT, - ACP_PROV_CONF_ACKED, - ACP_PROV_RAND_SENT, - ACP_PROV_RAND_ACKED, - ACP_PROV_CMPLT_SENT, - ACP_PROV_FAIL_SENT, -}; - #define MAT_REMOTE_PUBLIC 0x01 #define MAT_LOCAL_PRIVATE 0x02 #define MAT_RAND_AUTH 0x04 @@ -70,12 +59,13 @@ enum acp_state { struct mesh_prov_acceptor { mesh_prov_acceptor_complete_func_t cmplt; prov_trans_tx_t trans_tx; + struct l_queue *ob; void *agent; void *caller_data; void *trans_data; struct l_timeout *timeout; uint32_t to_secs; - enum acp_state state; + uint8_t out_opcode; uint8_t transport; uint8_t material; uint8_t expected; @@ -99,6 +89,7 @@ static void acceptor_free(void) return; l_timeout_remove(prov->timeout); + l_queue_destroy(prov->ob, l_free); mesh_send_cancel(bec_filter, sizeof(bec_filter)); mesh_send_cancel(&pkt_filter, sizeof(pkt_filter)); @@ -126,6 +117,21 @@ static void acp_prov_close(void *user_data, uint8_t reason) acceptor_free(); } +static void prov_send(struct mesh_prov_acceptor *prov, void *cmd, uint16_t len) +{ + struct deferred_cmd *defer; + + if (prov->out_opcode == PROV_NONE) { + prov->out_opcode = *(uint8_t *) cmd; + prov->trans_tx(prov->trans_data, cmd, len); + } else { + defer = l_malloc(len + sizeof(struct deferred_cmd)); + defer->len = len; + memcpy(defer->cmd, cmd, len); + l_queue_push_tail(prov->ob, defer); + } +} + static void prov_to(struct l_timeout *timeout, void *user_data) { struct mesh_prov_acceptor *rx_prov = user_data; @@ -140,7 +146,7 @@ static void prov_to(struct l_timeout *timeout, void *user_data) if (prov->cmplt && prov->trans_tx) { prov->cmplt(prov->caller_data, PROV_ERR_TIMEOUT, NULL); prov->cmplt = NULL; - prov->trans_tx(prov->trans_data, fail_code, 2); + prov_send(prov, fail_code, 2); prov->timeout = l_timeout_create(1, prov_to, prov, NULL); return; } @@ -258,7 +264,7 @@ static void number_cb(void *user_data, int err, uint32_t number) if (err) { msg.opcode = PROV_FAILED; msg.reason = PROV_ERR_UNEXPECTED_ERR; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); return; } @@ -267,7 +273,7 @@ static void number_cb(void *user_data, int err, uint32_t number) l_put_be32(number, prov->rand_auth_workspace + 44); prov->material |= MAT_RAND_AUTH; msg.opcode = PROV_INP_CMPLT; - prov->trans_tx(prov->trans_data, &msg.opcode, 1); + prov_send(prov, &msg.opcode, 1); } static void static_cb(void *user_data, int err, uint8_t *key, uint32_t len) @@ -281,7 +287,7 @@ static void static_cb(void *user_data, int err, uint8_t *key, uint32_t len) if (err || !key || len != 16) { msg.opcode = PROV_FAILED; msg.reason = PROV_ERR_UNEXPECTED_ERR; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); return; } @@ -292,7 +298,7 @@ static void static_cb(void *user_data, int err, uint8_t *key, uint32_t len) if (prov->conf_inputs.start.auth_action == PROV_ACTION_IN_ALPHA) { msg.opcode = PROV_INP_CMPLT; - prov->trans_tx(prov->trans_data, &msg.opcode, 1); + prov_send(prov, &msg.opcode, 1); } } @@ -307,7 +313,7 @@ static void priv_key_cb(void *user_data, int err, uint8_t *key, uint32_t len) if (err || !key || len != 32) { msg.opcode = PROV_FAILED; msg.reason = PROV_ERR_UNEXPECTED_ERR; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); return; } @@ -326,7 +332,7 @@ static void priv_key_cb(void *user_data, int err, uint8_t *key, uint32_t len) if (!acp_credentials(prov)) { msg.opcode = PROV_FAILED; msg.reason = PROV_ERR_UNEXPECTED_ERR; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); } } } @@ -339,9 +345,8 @@ static void send_caps(struct mesh_prov_acceptor *prov) memcpy(&msg.caps, &prov->conf_inputs.caps, sizeof(prov->conf_inputs.caps)); - prov->state = ACP_PROV_CAPS_SENT; prov->expected = PROV_START; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); } static void send_pub_key(struct mesh_prov_acceptor *prov) @@ -350,7 +355,7 @@ static void send_pub_key(struct mesh_prov_acceptor *prov) msg.opcode = PROV_PUB_KEY; memcpy(msg.pub_key, prov->conf_inputs.dev_pub_key, sizeof(msg.pub_key)); - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); } static bool send_conf(struct mesh_prov_acceptor *prov) @@ -365,7 +370,7 @@ static bool send_conf(struct mesh_prov_acceptor *prov) if (!memcmp(msg.conf, prov->confirm, sizeof(msg.conf))) return false; - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); return true; } @@ -375,7 +380,7 @@ static void send_rand(struct mesh_prov_acceptor *prov) msg.opcode = PROV_RANDOM; memcpy(msg.rand, prov->rand_auth_workspace, sizeof(msg.rand)); - prov->trans_tx(prov->trans_data, &msg, sizeof(msg)); + prov_send(prov, &msg, sizeof(msg)); } static void acp_prov_rx(void *user_data, const uint8_t *data, uint16_t len) @@ -614,8 +619,7 @@ static void acp_prov_rx(void *user_data, const uint8_t *data, uint16_t len) if (result) { prov->rand_auth_workspace[0] = PROV_COMPLETE; - prov->trans_tx(prov->trans_data, - prov->rand_auth_workspace, 1); + prov_send(prov, prov->rand_auth_workspace, 1); goto cleanup; } else { fail.reason = PROV_ERR_UNEXPECTED_ERR; @@ -638,7 +642,7 @@ static void acp_prov_rx(void *user_data, const uint8_t *data, uint16_t len) failure: fail.opcode = PROV_FAILED; - prov->trans_tx(prov->trans_data, &fail, sizeof(fail)); + prov_send(prov, &fail, sizeof(fail)); if (prov->cmplt) prov->cmplt(prov->caller_data, fail.reason, NULL); prov->cmplt = NULL; @@ -652,7 +656,23 @@ cleanup: static void acp_prov_ack(void *user_data, uint8_t msg_num) { - /* TODO: Handle PB-ADV Ack */ + struct mesh_prov_acceptor *rx_prov = user_data; + struct deferred_cmd *deferred; + + if (rx_prov != prov) + return; + + if (prov->out_opcode == PROV_NONE) + return; + + prov->out_opcode = PROV_NONE; + + deferred = l_queue_pop_head(prov->ob); + if (!deferred) + return; + + prov_send(prov, deferred->cmd, deferred->len); + l_free(deferred); } @@ -680,7 +700,9 @@ bool acceptor_start(uint8_t num_ele, uint8_t uuid[16], prov->to_secs = timeout; prov->agent = agent; prov->cmplt = complete_cb; + prov->ob = l_queue_new(); prov->previous = -1; + prov->out_opcode = PROV_NONE; prov->caller_data = caller_data; caps = mesh_agent_get_caps(agent); diff --git a/mesh/provision.h b/mesh/provision.h index 1a11b691b..1634c4d40 100644 --- a/mesh/provision.h +++ b/mesh/provision.h @@ -38,6 +38,7 @@ struct mesh_agent; #define PROV_DATA 0x07 #define PROV_COMPLETE 0x08 #define PROV_FAILED 0x09 +#define PROV_NONE 0xFF /* Spec defined Error Codes */ #define PROV_ERR_SUCCESS 0x00