From patchwork Wed Nov 28 09:53:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 10702209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 04BC413AD for ; Wed, 28 Nov 2018 09:54:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A616B2C3D9 for ; Wed, 28 Nov 2018 09:54:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99AA92C5B0; Wed, 28 Nov 2018 09:54:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 51E772C3D9 for ; Wed, 28 Nov 2018 09:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VYuLAL9Chwguo4JxOqgZZZFcfjcLCnwOKJum1xJ9ZGY=; b=iEjgG7nX+kHfmiuLLO0Z2x2KQL HBmwxRVh1axTPTpn0mdY9I45W+Zg43x5oN5KY13TOyRerk8PSe0pkl/dMHyccIrcJ+zATG+Ay4w2V JGOqfOkYZCBTjGFPy+MGYzi9pPMfD+ojTu7TZO99BLA5KtsKnCR0AN4+8vEVg7XzY/CSSCvx+Msfu YlFP40XAzUxoq7T8Kx2/xaccvERviciusIe7vqXvg17CU8lUDcx0H9UOd0X9E2G27IML7nfeB56+B BbzjWDk4YCfxRi1JuT6YIWV/r3hUFdYpdT0yqErExximmZFALS1MdBz9NKk1Qtn7LBXjRerAvqilM Bc6dzbzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gRwXx-0005wO-IG; Wed, 28 Nov 2018 09:54:17 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gRwXt-0005uY-QL for linux-arm-kernel@lists.infradead.org; Wed, 28 Nov 2018 09:54:16 +0000 Received: by mail-pf1-x444.google.com with SMTP id c72so9921713pfc.6 for ; Wed, 28 Nov 2018 01:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=phuOQIHhtaiR8GKkWxLxlxfb87tGYPgu+E8hPrCYdbs=; b=jbgq0hX/OBEwP9H7k7pO2RwzvNfpvBVKnjj80CGRXEdMwt9Y/1vhBdGPxhL292ua2g LKTgHYfYER+ZLzOMfQhCwfA40Q82Q+c4Y9knDBVM15zD/b7Ol2jlfAqLs0a2LdRps/v9 jzMGR9cyccdeJ+hp2/k4XzzBVqqZJSBJQduCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=phuOQIHhtaiR8GKkWxLxlxfb87tGYPgu+E8hPrCYdbs=; b=lWOJm424sgGF0iYy9K5HHsJ3RIzhB0wYXbHVawJdLUpqK5yVn05SGo5MCmP31g1zI6 liZ/7B0oU4uANzCWRuj1JgmQys8g2PKXxiQlA6ONGghoYbcuXuJ4vLyMea7Pwi9b7XoP P3mamn8Q3HYHNmsV/c2ZGLiWeIZHTskJ/qQ5sLGZWd9YDiiCb1BesxPCjgCAU6yRQTxK nDdgsSiJ+veHXeDv7EvSXGjnzd6Y7bCOmjUj4ao0JucuHoxLnVjnOUZU3eOgVTclgnoo mDj2HBIl2WhEzNDpLWRQtzPv5iRnq3uuZL+kANdaU7cMHcvAslXkkySaL88dMP47bi4R t2ag== X-Gm-Message-State: AA+aEWbqhNHMUEM+Sr+32krI2d9tH6ItKpl9eVPE2Kusy91TEN/zr7xg SHLuGYNrc5tvClYHDFQbvKR2WIq8hQEAQg== X-Google-Smtp-Source: AFSGD/U6fm79MyS8kX8LQgobST9zhr3DlMly+JetZVc4psrEkCAiLkRG75+VGUt+EtDzk64sNRfl7g== X-Received: by 2002:a62:6e07:: with SMTP id j7mr20472163pfc.135.1543398842768; Wed, 28 Nov 2018 01:54:02 -0800 (PST) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:b852:bd51:9305:4261]) by smtp.gmail.com with ESMTPSA id r130sm11223806pfr.48.2018.11.28.01.54.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Nov 2018 01:54:02 -0800 (PST) From: "Hsin-Yi, Wang" To: linux-arm-kernel@lists.infradead.org Subject: [V3] usb/mtu3: power down device ip at setup Date: Wed, 28 Nov 2018 17:53:58 +0800 Message-Id: <20181128095358.42498-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20181128092953.41541-1-hsinyi@chromium.org> References: <20181128092953.41541-1-hsinyi@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181128_015413_855519_C8F0AEAF X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunfeng Yun , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip, so host ip sleep will fail at ssusb_host_disable. Power down device ip at ssusb_host_setup. Signed-off-by: Hsin-Yi, Wang --- drivers/usb/mtu3/mtu3_plat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index 46551f6d16fd..792c420fd4ad 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -200,6 +200,13 @@ static void ssusb_ip_sw_reset(struct ssusb_mtk *ssusb) mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); udelay(1); mtu3_clrbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); + + /* + * device ip maybe poweron in LK/BROM stage before enter kernel stage; + * power down device ip, otherwise ip-sleep will fail when works as host + * only mode + */ + mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN); } /* ignore the error if the clock does not exist */