From patchwork Fri Aug 3 03:12:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 10554513 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B45A6157D for ; Fri, 3 Aug 2018 03:14:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D4E82C08D for ; Fri, 3 Aug 2018 03:14:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 90D952C08F; Fri, 3 Aug 2018 03:14:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A9AB2C08E for ; Fri, 3 Aug 2018 03:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727581AbeHCFIS (ORCPT ); Fri, 3 Aug 2018 01:08:18 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:6065 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726898AbeHCFIR (ORCPT ); Fri, 3 Aug 2018 01:08:17 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie3.idc.renesas.com with ESMTP; 03 Aug 2018 12:14:05 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 84A58808B7; Fri, 3 Aug 2018 12:14:05 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.51,437,1526310000"; d="scan'208";a="288698566" Received: from mail-os2jpn01lp0146.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.146]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 03 Aug 2018 12:14:05 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jcH3P0Q3tj5EshD7MX6pw7DqHi9qiFxXS+B49JTPcd8=; b=PqZb3U5eb6/YAtISus5I3N61XVXGeMS/8DJmsJyrLuctYWrPWD2YlwtT/X/mVliEZCk2MPN03KK2H3EWQiiirpvLsycXFY0haLL8h4rlzgaBOxa1VQiLQrji8GkuxMGoYlqJSpod/Z3KVU0ytggtFwElDACQeHInrdYIRrPc/bA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.144) by OSBPR01MB2293.jpnprd01.prod.outlook.com (2603:1096:603:26::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Fri, 3 Aug 2018 03:14:03 +0000 From: Yoshihiro Shimoda To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH] usb: gadget: udc: renesas_usb3: fix maxpacket size of ep0 Date: Fri, 3 Aug 2018 12:12:46 +0900 Message-Id: <1533265966-5766-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: KAWPR01CA0063.jpnprd01.prod.outlook.com (2603:1096:402:b::23) To OSBPR01MB2293.jpnprd01.prod.outlook.com (2603:1096:603:26::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c68733a-f472-40eb-117c-08d5f8ef2a86 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(8559020)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:OSBPR01MB2293; X-Microsoft-Exchange-Diagnostics: 1;OSBPR01MB2293;3:JCCxYZ3Jrt/Vswcv0vf2xutJX/9jffgyeVaIsjTXISnlFEDfOc1Urda6aESt/tLzpyEnqzhkmIhgnbtTdhGJ0n/bjCnQS2THPKCQKmW0vSo+e7iHegCE8EbgTGe4s4yukWqOqkgOlMSUT6ZzfqhaiXuvkg3JemBlweYY1VOx1eYz2z3fzbhoIPP8KtSp+WY/HbfWkKYwg/fsMP/ld2aNBpKYN3Upq6Aud6nk+UaNBWOrciKLEQqLuygVo9btwn00;25:Ny8f/aeH7eWT0H9Vl1ntXX1dSYH4cAkXj+og1pMczN7xNBftm3Sgu0zWx3oRRvmxHzTut8GHxqPKr+dI8picLaMyx/TIOsKFpxj4Fpp6xHzuJ62Ni41eNAuVCjJFfK784/YoXVcACnMwPf/2jmEo/kKfPfVW17WstDEr22EytmL7otYHpfazSbv3Ms7lK8xbfxi93a3/7d9IjKh5zHJUSm6VOHJDhidbysk8KFzz6wyC0egUBi2MIYyYXuKfQZ54FCvsPPEqY2tkVU4KypHwjHHl2OlF+8nuWnoh3dkNwD56JLn58VpVUuicXy5yB7BQmKjLPWEhH4+rOw5+NWI01A==;31:nuvOJEUqNZw/3y2F0pu9sijiP6pp/lkDnTt1nmeVsOMX8S8y/FfbbOr8u18DvCE99YwporS+eMSmnJtIXFfKh5kJQriE/tlY+skKdjBgPOK5apGjjsxUx7v/2/bmvApM7CNxRGS004X36Anct5DkcuBIlrvaz8GvK4eRUo0hld+5SBTXGIxrxd/LngFiSkvVaJuJVDAI2fojWl0YVVJNopO2f+iYfBSie4CEOeOYA+Y= X-MS-TrafficTypeDiagnostic: OSBPR01MB2293: X-Microsoft-Exchange-Diagnostics: 1;OSBPR01MB2293;20:JqdDrDz91hyV3Z9Cgald/nTNcuMobv8yBtfN2Ad9U7lB609yLf+8XbOKbo1EpmyHba9aq8Mp40c5dPgWUUeBWH+CgD4kMXY+Q/p3uknCHj2hf8jUmW3LvD6wQYbTcFdS26OZOWgKYlAChpMegJsyv/zdEe3vZFWAIG+JClBrOdtsYyO17wXF5HRW4S46yI/L6bmuKK6Re2znEyVZg+Zh9+1qOJngMrbXfclseFv905TO7HOGiKVfZvzCowAG4679zSaF/AE4YAC0qhr55Wm1Nt70XLTQ2VACXwq9xpq22auLHl8x3oCRUU6nXuvcmT5Ks/0v2H+NXqxggyIXnVWDlIoQXDevz/+gVO4wT/w6vXHJ0k/WW9Ir5G1Br3GkGZjDUum4+wySF33tlJXdQqlWdAtM4oLxgvW5FhRwE2bXQgpC5XAYR5gJ5uCLDR1Kaj2zWuJNM9XO9RTn3IeWrzfnLFU6YayEb8mKYlO2R6fXbaDjtGux9tcebj3Uk5trRYQA;4:SN1gH/M4IHSpEX6kQGI+ie6vQ3cDcpYoNU2Pj5HmoVojzTSMbJJFD6iEbra823tdJ3chh+iFji9kjcdYn+cPFID7jW+gYWemk6QOsSRh3mHXGwGOLrPO422VRvhwCJej8t4CAnQiF55SZNthVDMS26UlIFnZsgjS1TVc3OtsNGtsgj30jRAxEj9l5JskS5ieXIBjeyac5+lhZ5H2rjc+EYXmtjXOKkiSgWM+2PWr93APsQonFQ196jE99SIpdDsm2YWP9HgUEdyk9kQNDxgGWadloNVnuvpMbYtSfFNwGl91wRajJD92bYZwAImkKKk/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231311)(944501410)(52105095)(3002001)(93006095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016);SRVR:OSBPR01MB2293;BCL:0;PCL:0;RULEID:;SRVR:OSBPR01MB2293; X-Forefront-PRVS: 0753EA505A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6069001)(39860400002)(136003)(366004)(396003)(346002)(376002)(189003)(199004)(81166006)(1857600001)(8936002)(6916009)(6666003)(2906002)(6512007)(5660300001)(3846002)(6116002)(50466002)(48376002)(36756003)(68736007)(97736004)(81156014)(2616005)(14444005)(476003)(486006)(42882007)(53936002)(50226002)(956004)(47776003)(66066001)(25786009)(78352004)(498600001)(107886003)(16526019)(386003)(16586007)(4326008)(6506007)(316002)(305945005)(7736002)(105586002)(2351001)(6486002)(2361001)(8676002)(106356001)(26005)(52116002)(51416003)(3720700003);DIR:OUT;SFP:1102;SCL:1;SRVR:OSBPR01MB2293;H:localhost.localdomain;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:0;A:0; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;OSBPR01MB2293;23:5i5BSL7U/3wdWmKFVudFszAvgZBsZE6J2vmy5Mj7XqjsXPgICcHHxvWBzzEoQTxan4HjOxVCgveOpYaDmoxTJcjTS1M6THThnSdSg0kHYtqWAjZhpb2Fp7aNUBgLKzh6J3f/J/8msM0EHyQ6LCqo6PVXxGLSdJSXIB5V1NEmYNfNEiWA1cfpdSNVSzVNpEaIU1iwL3GqQku93IX0Z8oKjpY1HkYp7f9wGRemQtDefIt4IStzLuiHc8L8nBYgTqEd5mZzz8dzB6j7KvjxJ8FWHuprrEc60jBnKsdK6oMQqVsBIIjyl8iawbcSkJY1ltml2V2bCJ5scgy70N1oRU58b3SijRBJb4cLF54dG112XUXqBw4s30vltvFWgduo3qscz7naiKZZCXp4PvN2KhHfBb9nRxQmUpwEHVkrnIC7usnjOwz90YHK1lbCDUq86+RFBg8WrPIKI7ygDjjtz+nXOVY+uJ+TO8JyLRqwqNYzUkYxGMuMdElWGiTupQfHDT9t/pF+nWVLlOiJlCLGqFZ01K0ULra7D+DSJwW7Bfor+gTNOCCyT8Y8ufVzpLIpsM7SeOlQjMkKgp7hH3+/c+AYurJlx22D9t60HF7R4itb2oIqpwcpR86iAMESk8UxQ4O9WOXd3BeWiu3kKvGPJxNAsGzEE6FoOvxaS6tYRJUESaNpWu501YxZ9MhxmydQRzZgvCqdLozGgdhCO7dhPSosdiq/E+eRpyZnkoamQYBqBiSuDl6nmJ/Q29huxU2UKdgHGyMEwSrqgIKvm8TDgmka7PHEFiZuSIUknTXN6ldamXiN0yEu+5mVCSNjRL7dmc3svssfkH09t2Rzv4WzxVMW2cRxbUDthF68FAfdc4cVQmApQn+ylpfpiTnWyS6czfFbMY20ACkcRfBPQJ/LeDVyNdRck7yYRh2iRSTZgunNk8zKDtktBEiNpkZHSBW2kt6cKyo7iBHFznj4m/xxgedBBi5eoYWcAdpn7NUka98PFyKlrXn5HHRnwW+sHBW8blMtn40WxYtupwLkZNUUvpPd9raxZQ5ivdfL3U5GuUUfDVdglnyryFG46l35UJJ5dl9t1Mhjkoc7VSiqRUEc2tvZpAJy7tyluWq3n5ifWNoC7ysYPUfNmfduzi7O5Z1xGZ1p757xR06ni+XDQ+QgFXLpLWv+DiqgMUPrnIUI/igmrIqC9XtNU8k84odKaNqieUFtxIJOYvBS/bmVM6BpyNyYJnOPawtRA2aDM/gJULF8F0X1sZ8ReScb3r494H+ksyth X-Microsoft-Antispam-Message-Info: 9zcBsLyMoad81fDpePqkNlxEMoeANepiV3JHDUAyDARqbHAZSvBR5pFAT7mmit0XmorpMeMdKRMZd38xnQovWOwqwS/s1ijKiVos7SHlxnG3+QMNAAc/XHAWZACPVLqxZLOFyrrdxsB5K1lil+VV4OG4zfxH0qp3U7CQcal11uoqYqpv3uIPEz++yHfMjNkcR5AJl1CBESJueY1LNtO5CfltQhTLzr4ymZM1DVSpevxYHthbZNGx1iiM2+uWHjmJIwThCciUAEO+Vkjl0rVZFm6NqekHcJlY9xCZuOjt4UVPuD2IDZ4fWzvCrJKV5KJKsWzgHEWHbPovjILECjXAo3KQx496EDVISHdmCkXXYWw= X-Microsoft-Exchange-Diagnostics: 1;OSBPR01MB2293;6:BEBhEd/aiXbuUVI3yobfLzbE8vbHb5T1caLM4ze0ZergI+bjN5oURUeB6rCSgVhDUv5NqdDo9bhWGMFf88ZdVmuyKBJbm72KYfaTkCT/IVRYtfcWK0Ty9EEiwgyib4M51hg0JmsxziCf6OwdUwHMsYUP2ONVhjDijYdJsoy6pWEmAS1WNHEzKC8Z7r4eErOBFuCmApSIqtvEX4S55x8spn94T1ou86SDHWQkiMu4LbM4VGbDNuMfyt5gd/4/Se+dvgjo86UCL1+GHtj4gPmJw9uvHaoQPsG1ljjrYUF0LkkQ8oDEyTq//7C99NHZxcVy/CI3Wt9Fxq8YH5UtovFOO6CaDhjta5m2fs6Ppu6Gnk0L7kkVYedeD0oVJ/UyyILqHu9tGdVSWRJ21w3OA0848EEWdASa0IYuFE0EngFO4CiXiZdbSkMymGhREp0o2C0+QS7zvzuQSe1nctP2eJrkrg==;5:94py6drlPmP7GWH3lak1VA0DK8FPVSHCGxqE/GXNtVxb1BXtJF3FIkLVYdmbQO9kGx4hOdGbuD8+IYhuoqRTI9b3PpYD7+ro4FxA72V/UIiPYdEXfHvqazzVNFMCOrabXSUYCVdz7pGnT3NX3UghpoGvDj1akqVy9ouyeFYEzbM=;7:99o2Rp8AqvUD2iqot+xocicpf1TJDsP5D8HviHbidh8ct4tBIZIn78Wx9/oa44xsmy06rF32V3mp+eybIaMUZbTKA7HlcFBn4pUEeakSziS++NjGZIOMmpWf9LvGXiVnl57OnKuf3Y3qeX6Zsai2qilYjS+IiBZWGhGkzALyEzlYdQTMPR/0Pfc9HAOqrjVm6cbmXbacJNI60Ff8jScKYkRpip/1mskwpPZKTikw0p3DtE2zieCXO5RHeJoB9jPP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;OSBPR01MB2293;20:PWSg6r6e6iec40wciywij+BXC3ptkw79z0fWHRk5PyOPjL9mA1pKiXCNQ+VFxFdEXTYi0FeiFjYf8DzwfnJH8MQ0fpzHfztZih6lYX4f/TYfg3DhsRdQbViGSM6ByFe8Q3+T70s17ivUxc3V23eUeeQatd1XxB8myfJTjx2F6eM= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2018 03:14:03.5794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c68733a-f472-40eb-117c-08d5f8ef2a86 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2293 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes an issue that maxpacket size of ep0 is incorrect for SuperSpeed. Otherwise, CDC NCM class with SuperSpeed doesn't work correctly on this driver because its control read data size is more than 64 bytes. Reported-by: Junki Kato Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller") Cc: # v4.5+ Signed-off-by: Yoshihiro Shimoda Tested-by: Junki Kato --- drivers/usb/gadget/udc/renesas_usb3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 7cf98c7..5b5f1c8 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -787,12 +787,15 @@ static void usb3_irq_epc_int_1_speed(struct renesas_usb3 *usb3) switch (speed) { case USB_STA_SPEED_SS: usb3->gadget.speed = USB_SPEED_SUPER; + usb3->gadget.ep0->maxpacket = USB3_EP0_SS_MAX_PACKET_SIZE; break; case USB_STA_SPEED_HS: usb3->gadget.speed = USB_SPEED_HIGH; + usb3->gadget.ep0->maxpacket = USB3_EP0_HSFS_MAX_PACKET_SIZE; break; case USB_STA_SPEED_FS: usb3->gadget.speed = USB_SPEED_FULL; + usb3->gadget.ep0->maxpacket = USB3_EP0_HSFS_MAX_PACKET_SIZE; break; default: usb3->gadget.speed = USB_SPEED_UNKNOWN; @@ -2451,7 +2454,7 @@ static int renesas_usb3_init_ep(struct renesas_usb3 *usb3, struct device *dev, /* for control pipe */ usb3->gadget.ep0 = &usb3_ep->ep; usb_ep_set_maxpacket_limit(&usb3_ep->ep, - USB3_EP0_HSFS_MAX_PACKET_SIZE); + USB3_EP0_SS_MAX_PACKET_SIZE); usb3_ep->ep.caps.type_control = true; usb3_ep->ep.caps.dir_in = true; usb3_ep->ep.caps.dir_out = true;