From patchwork Wed Nov 28 21:08:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 10703377 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3072C14BD for ; Wed, 28 Nov 2018 21:08:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 225952DB59 for ; Wed, 28 Nov 2018 21:08:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14E612DBBC; Wed, 28 Nov 2018 21:08:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACEC12DB59 for ; Wed, 28 Nov 2018 21:08:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5530C6B4EF4; Wed, 28 Nov 2018 16:08:30 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 4D93A6B4EF5; Wed, 28 Nov 2018 16:08:30 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B436B4EF6; Wed, 28 Nov 2018 16:08:30 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id E4E536B4EF4 for ; Wed, 28 Nov 2018 16:08:29 -0500 (EST) Received: by mail-pg1-f198.google.com with SMTP id l131so12919317pga.2 for ; Wed, 28 Nov 2018 13:08:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=BLgbuRLcI/bRm8AtJQvQU2O4wrCkafUGj+9CeVsGb08=; b=p1ZMdLuWfbzniDvCPe2ZPJDiiTVHSq2kA/lXFKLRZlClnxc7NCXLwPyrqW7cV1b4S/ OHXvdSXPP1Cf1aTdwBQy9OpUOMOwr6MbPRa/L0T5wSIEp/tA6ihiq+IQIyWWfj6pdw2P 8mwMExDTUse8bMeUNGqO3wxJV3uubVD74qJWzYW19Mn7Ubo+Z/TTjhXEacWc2EDuc4Ee cwnFxN2CAcX9V6a9YnIQDW8g6Q43cwcKQ0xV0OBR+uStMsyurg1hmmdhUphrPLgDTG1+ 4j8AA+ls2dBrXCpmlX/xyntbpPgnnSXgeuC7KuqS63ELCJhuiVC1FH2KyuWffwAdNrfh hrfQ== X-Gm-Message-State: AA+aEWbz8B0H7NUQQpElV6GVsumSuevvZOFrVxQN/u+mVPP0ZPg14lAU A3s+WYVER51gZNgffj4DRTviUXM66X2rG2zTuGUpGvnrldFYzUD4zVhiFUSmkrMyIoyd/ztaTj6 51z+agtnvM+CeyFIcExSCLwVZwOximogC7VzJvQG0HwvKW7+T1Zdu4TfIXdmZKY4x9EbYBfnQ6u UfyA3g64NwLQQKopNra7zmAKh+ye6/BEw5SSfhvJaZnTPxDI7TEUJpWHV2seSiR+oWk2r1tWehq zCzebo6ooMbo0ah9b0zk3lGFOF6lGCiukRTQVvqDqRXUucxw1wl/ggvi+mPkleXPafdW7aZfIXD 9X6QjS77nhG2o/KQstQ+7P5urIo7lwMOnrA6gPmcV4u4snFaDNfkuP7g5CTmDO54LcF0E4NbPK1 t X-Received: by 2002:a63:f811:: with SMTP id n17mr35494710pgh.23.1543439309516; Wed, 28 Nov 2018 13:08:29 -0800 (PST) X-Received: by 2002:a63:f811:: with SMTP id n17mr35494629pgh.23.1543439308377; Wed, 28 Nov 2018 13:08:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543439308; cv=none; d=google.com; s=arc-20160816; b=bUm/K8kfZDkH4WI2MPXoJ4VPg6aFAb3CoZGZkNFswPwcx2FrLIqu7+CCVwWi/sO2tN wR9iHLDHGeg/vO5tIeuNiE77QFWO7YpjrhA1JQsQtzIuxXUFcr/66OXUqGwszp8ZFEvE UqPDajAnz9KGX7YejA+tbiAw0mR58Zvs3zDoLdSSvT6e2BilEvKzuMQb3EH5DknEsBpv i5DndgMT47Mny5//gPSPiTcQibx2YpOg2RvqJaz0GqYPrIQLzGTIJ3f2Y8b3IAuGoXLW 1CV6tuGTTl+fIgfGYVkmBjq4S8AQ8Zrn2DeL5iIe5+YhZjlbgP1q8SmVcOtHHEt8DuNS ot0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=BLgbuRLcI/bRm8AtJQvQU2O4wrCkafUGj+9CeVsGb08=; b=e13jfg4zJzU/F42xpNYtZ9K5LEwmwzKug+mAysHGpDG4vnZyzi8haKYCC0TdG6r+vr ghTqjZC8oNj4wemsAzsksR9n1JiZG0LT9aK0znRe0rUX0h2w5M48Ne6oOVTso0X8q4kY FqoeqilmWL3bw72aN7yDQQSA0YOwnoOFb9QBtJvbuFK+Sh4HKT9wOiFk2rpifnwjSsKu nHQImu9nahKOZYbSl7JmGBoTY2AsJWHW7qKNq9eLE38+xTOampKfYJd95M4R2GouCbpm 4D7dHk78FEHdz+EqwloKWncTBv3f6BN22LFswvnx59p3v7M9p+5vpiU0/RvN+Gh2n1v4 hLCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mCaMiCE5; spf=pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id x8sor10906018plo.55.2018.11.28.13.08.28 for (Google Transport Security); Wed, 28 Nov 2018 13:08:28 -0800 (PST) Received-SPF: pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mCaMiCE5; spf=pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BLgbuRLcI/bRm8AtJQvQU2O4wrCkafUGj+9CeVsGb08=; b=mCaMiCE5n0Tqx+FvUrVcWTEZZanc7MgLVM4SzDXy45X1tMzX8xIM+xVZ9tY0FMYUhJ u9MmlPNi/XpEY5WBlFfSBKgddkdyjgFMcvAJ6Uz8iYdF1y0QK+gCyKTUm6UGjvkd+8dw NFxv1j38a5boczmOVPYQqlRCt5rBo1h87vOyhYPlc0VxyxV0/iN47V6Z/dwdLS9T8QJh WdZvHjHZq7Gz7L6Gjse52L+QdStO3r9BLgCK0yc0of9/u0tgbf9ZQEC3qbclMh5oAl11 bYOtOfs2EH+b1HNu0ka2aUnxgkYy1HkjJpj3yRq1ZtvnRQplnrhMuwrVaQWNM+YvHEb/ SAIw== X-Google-Smtp-Source: AFSGD/UyNEdYxOb8jQUfnTd9ZxOkNg4PcwOaFC34vxZflmkp5FYb9kmdAoPHXiYksylrnzW6ogNzgg== X-Received: by 2002:a17:902:f01:: with SMTP id 1mr34228698ply.143.1543439307889; Wed, 28 Nov 2018 13:08:27 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id s84sm17820897pfi.15.2018.11.28.13.08.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 13:08:27 -0800 (PST) From: Wei Yang To: mhocko@suse.com, akpm@linux-foundation.org, jweiner@fb.com Cc: linux-mm@kvack.org, Wei Yang Subject: [PATCH] mm, show_mem: drop pgdat_resize_lock in show_mem() Date: Thu, 29 Nov 2018 05:08:15 +0800 Message-Id: <20181128210815.2134-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.15.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Function show_mem() is used to print system memory status when user requires or fail to allocate memory. Generally, this is a best effort information and not willing to affect core mm subsystem. The data protected by pgdat_resize_lock is mostly correct except there is: * page struct defer init * memory hotplug Signed-off-by: Wei Yang --- lib/show_mem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/show_mem.c b/lib/show_mem.c index 0beaa1d899aa..1d996e5771ab 100644 --- a/lib/show_mem.c +++ b/lib/show_mem.c @@ -21,7 +21,6 @@ void show_mem(unsigned int filter, nodemask_t *nodemask) unsigned long flags; int zoneid; - pgdat_resize_lock(pgdat, &flags); for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) { struct zone *zone = &pgdat->node_zones[zoneid]; if (!populated_zone(zone)) @@ -33,7 +32,6 @@ void show_mem(unsigned int filter, nodemask_t *nodemask) if (is_highmem_idx(zoneid)) highmem += zone->present_pages; } - pgdat_resize_unlock(pgdat, &flags); } printk("%lu pages RAM\n", total);