From patchwork Wed Jun 2 14:38:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12294987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42554C4708F for ; Wed, 2 Jun 2021 14:38:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED42C613AA for ; Wed, 2 Jun 2021 14:38:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED42C613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.136058.252457 (Exim 4.92) (envelope-from ) id 1loS0e-0005tH-VU; Wed, 02 Jun 2021 14:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 136058.252457; Wed, 02 Jun 2021 14:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loS0e-0005tA-RR; Wed, 02 Jun 2021 14:38:16 +0000 Received: by outflank-mailman (input) for mailman id 136058; Wed, 02 Jun 2021 14:38:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1loS0e-0005sy-1a for xen-devel@lists.xenproject.org; Wed, 02 Jun 2021 14:38:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 71181ff6-5a02-4ecc-8ddb-64c302e781e0; Wed, 02 Jun 2021 14:38:14 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-fj4UwSf2Mm-DcYEsuE4KTw-1; Wed, 02 Jun 2021 16:38:12 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3389.eurprd04.prod.outlook.com (2603:10a6:803:b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Wed, 2 Jun 2021 14:38:10 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 14:38:10 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3PR09CA0027.eurprd09.prod.outlook.com (2603:10a6:102:b7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.26 via Frontend Transport; Wed, 2 Jun 2021 14:38:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71181ff6-5a02-4ecc-8ddb-64c302e781e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1622644693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NwFfkvN5qesznExZCGsK7iQb4IOiNi91GWuoqxon3zs=; b=gT4qi+QA0NZDOeZoN/hT1L9GVEq7Oc5Q4kNQ49xKAeUszTKA8TZEkDS9HQye/GkkFBQ6CS qZ5mQS8Qeo+R3I1eFZg5q0MlD1fNwEQ8LQHTJr/FhiBsDLpDwRHjnT44o4ZDJj9hTSSx5x XIKI4ZSsn1nDhmX40FDOu1wxZP/U03k= X-MC-Unique: fj4UwSf2Mm-DcYEsuE4KTw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSDGrNyZP2yRCRNUCaB/sV11E3j2ANDj7pv529Lmn9WSEATdpDWrogMbScch3fCElReMwBpVlLK7wwGYhVrbVJKVem5tvE6ZgwpqBPCqAYra8S47GSW20l+xRwsa9cVjeagY5926ZOUwSAWbfil4uUO0f5WpoiCfGTZz540dIcyMNs/7563fznh9HtVPGzy8vPa5mIQ5LKBsBgwXsT00M4Qsb2XDKPyHyKRNfMOS6qN49dDuy92wIOExEnvEcXRMoIh4rxoCE7tRWMhtLDH53qbTvcK7oUjw7v3aae6ZikdNu7j/HEw+ZYyNfqHGpM5HJggyiPl2ztsM5WkRwfOOTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwFfkvN5qesznExZCGsK7iQb4IOiNi91GWuoqxon3zs=; b=GXJr5kgLroSZ5wGR1x0wIfKMNnH7aod3+77Ot/CKHFi8YMcb+vHuW39l7xyC6JCwJl13B15rpQb3PZs+lYvV7d9N0lLXuisqcuTQY4uz+qBXhuvveJHbdZR+X3D/Yk9rI2fd750mPLFjKBtiHS3uBif3Kph6KUu/JAX/RKf67JIqU7sMT/dh45LpP6FH7QFX5qLlBcTLWuecQJ2KHDhhrK80P7uZO1gZnUOAGIZAqGfJP1+L53rei5Yq5st6zS8rRzFPVAv0/bUfZGOREn5Ypxj5cZGUDhVWEx0pYtWoSuWGV152pwlYu6zJIV0ctSG2zwuCIrG506caa5MBHqwZvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] x86emul: pad blob-execution "okay" messages Message-ID: <3250a871-e49d-d3c4-333a-eff435e092c2@suse.com> Date: Wed, 2 Jun 2021 16:38:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 Content-Language: en-US X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR3PR09CA0027.eurprd09.prod.outlook.com (2603:10a6:102:b7::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f1df024-eb5c-41e8-9f64-08d925d40b11 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3389: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:331; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g8oKK5Rf4pWZGEwj763+nFvZqNie8ZY0Ad2iXG8xu4cjylSDa39yI73bDxOEGTDDFLk4g+hyvuz7rykhyxgHd3rzg7t8G0El3UcY74CH6U73ulGy1BJT1kSsJlTJkE7byHhs7Cdxhx1ruLouLByE1H7kMTO9jH09aWpUi//lmbFgHBH/jNqxwOuxaAYxo1oB5GtZ5o5EmU4IBpJqbGFiKyEgtXZtLHe6hE25TDsk+9BCISGG/qHiB2S1totUDrFbxcYM0mM/JNiZR3HbmAly/R5v5GSLzgbyB4vcfljrV1CXSjp2MprvupynlFd9CeKnkTVBajdnDtMwc6sgReFjOMwbg12f2KaoHGy5YqxIjbVdWky+Vmf1oFsQLfUPntiqhe7Nt/JRwHkp02LHt3+cwusOyN41/K55MfS1rk1kE53lqEJxTVlrXYEMYdN7jIFA0l9RM8SR59UZk+XruCPYLhipAL6OD6htA4yfDI/W+7CSU6t6T137nFJTEk1m+dtoevyY0DFE+sG7wf5qOTWmi24PbjXWiue1NaGwfW4FxtKGxbLLUVbX3nZG3C9bOnuW9zPWjsALBgJt/j5AOoNzE+cnUeKbriHrYRQ0T6AOcQoROCc7UEqAT6D/zPQEZQ11XR9MxB0kvML8Yl3t3Xkuj5FkIH6qABApLGRyN3Rtu4fpX9is0tPoi8/jiA1lkiA9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(376002)(366004)(346002)(39860400002)(4326008)(36756003)(5660300002)(16576012)(2906002)(54906003)(316002)(26005)(66556008)(83380400001)(66946007)(38100700002)(15650500001)(86362001)(2616005)(8676002)(956004)(31686004)(31696002)(186003)(16526019)(8936002)(478600001)(66476007)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?zzdWTIgCz/EcWyRP+VbsVYossGkXkj?= =?utf-8?q?r8T3Ni1s9TCwk4vdaSsxJDIjMtMCvKpL0LIEiLV1wvgkbi/Z67Lc3GxPeCTBT3pk3?= =?utf-8?q?Y5N/moXn28LO0dJ5+sqrAPHG1wNobG2Cp7qP59G/L9K0Prd2gaxGMa0SV/3LE35c/?= =?utf-8?q?8N0pmdTjkjIyeOC/377KTOO6hdoPYkD1IeVBy+BanLXPD4uh/59K8aMvsFngzkd4S?= =?utf-8?q?Aok/o/9PEwm/pZe34UvEno0Z08g5duYii9vx8SbrjUxQUByjf2lZ2piByk1hHWsej?= =?utf-8?q?DDLLv0RmxwhZ72EigvZX9pwBCxpM8yQojU31x/eShHvFcrDtIzfJHElrsdtDTckJy?= =?utf-8?q?k33pCKnNbsrq/5xNwIoH4QClUiifInqrP1gYJepeqBxB2QL5WPRjyoJfyJlzQhh8m?= =?utf-8?q?RLDauTz12EBuk84ZW0E0YO4KrrfXzkPZ8bejFIkWMWQttf3NlWV2ZfoX4vXzpvXJx?= =?utf-8?q?zkGtvOHLSDbMl71Fm0CnPYqJjTBp7n0IXKuiHbAr64khM73MLJwTudEgBtofBArvn?= =?utf-8?q?fhQBOvsRrzbD3/DfPyD7GJsrQgX1jytSiy6qjawGUTsGNTxC27vxp2tFslLx6Ja7G?= =?utf-8?q?CO/Noj9v+Kp9NYLwgewvJVLMfK5R/M8jtK2ApxDxYWqQvQi8IwfrxmT+5stCi/BrW?= =?utf-8?q?5Bgeiaq3fzyRNPZE7sKHuCsy+4M2WaJpt2Vlpn3zEYekUgQI9Y6Sxs3hrQp8HD91A?= =?utf-8?q?G4AzrDaIo7AQZIkSVOlCQLORUVgO6ccKy8nyQvKhz+3KZmpeM+xxB+BlYrCJW9n5s?= =?utf-8?q?mwnoGyi31eNVGGz+EXMfmn1/2TqBvyGb7ns5QZGLSZQa02YD2KN1qvlQJrICGzmhA?= =?utf-8?q?NeJ9E2X7R8PH9hGb6LB8xkTuprk7dGd/gnZvtdExM5ZwVxrtd21AoLIQ6I+0//DwO?= =?utf-8?q?SgUYnRySGucMUx1fvjW7rLGYwUskbOFBu2KNpRpjLULoZp2ZDwGalhxaVZur6avb2?= =?utf-8?q?xZSPTUO0ZqfUadySByELxbuswTbe+hfXQoAnQZZD87h9gKqDTg+Fo3BVO1WPe601G?= =?utf-8?q?b24EYSiPVLXfzQikcAXfKbFAmMAqLHr59WNF2mu6xRP/NmcULZq1MvEnXy24DplKS?= =?utf-8?q?P+rOv33gorxsQ7Wnp0oWbcnxETxINqpNx3ibR+nmmJ3NRgh/GNsVTpN9GCPGJCt9T?= =?utf-8?q?d/SMnpnzt4BsBoHY0yw5vUB+H7AtPzTNwi8+PMK7cJbtsveQvGxHYy7ORScp8jrrz?= =?utf-8?q?rd5mD5NEUgaWEPiLcNqeLjEyvGdsWr2t0wpLATeBmCpeSRhecYOLXe35UQQMvdhbJ?= =?utf-8?q?C2R1jG0V7lEe4i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1df024-eb5c-41e8-9f64-08d925d40b11 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2021 14:38:10.7389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ohapvO7SF/xZdV4WVrYjNIe5U3ucFkyB4Ex0KvgyJnvWpdHr/iiTdiuk1phcEQ1KiGh9DiMXewppcE6dvTlEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3389 We already do so in the native execution case, and a few descriptions (I did notice this with SHA ones) are short enough for the output to look slightly odd. Signed-off-by: Jan Beulich --- Many descriptions are longer than 37 characters, so I wonder whether we wouldn't want to bump the padding to 50, 60, or even 70. And this perhaps despite then going out of sync with the individual insn tests earlier on (which I wouldn't want to touch). --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -5181,6 +5181,8 @@ int main(int argc, char **argv) for ( j = 0; j < ARRAY_SIZE(blobs); j++ ) { + unsigned int nr; + if ( blobs[j].check_cpu && !blobs[j].check_cpu() ) continue; @@ -5196,7 +5198,8 @@ int main(int argc, char **argv) if ( ctxt.addr_size == sizeof(void *) * CHAR_BIT ) { - i = printf("Testing %s native execution...", blobs[j].name); + nr = printf("Testing %s native execution...", blobs[j].name); + if ( blobs[j].set_regs ) blobs[j].set_regs(®s); asm volatile ( @@ -5212,11 +5215,13 @@ int main(int argc, char **argv) ); if ( !blobs[j].check_regs(®s) ) goto fail; - printf("%*sokay\n", i < 40 ? 40 - i : 0, ""); + + printf("%*sokay\n", nr < 40 ? 40 - nr : 0, ""); } - printf("Testing %s %u-bit code sequence", - blobs[j].name, ctxt.addr_size); + nr = printf("Testing %s %u-bit code sequence", + blobs[j].name, ctxt.addr_size); + if ( blobs[j].set_regs ) blobs[j].set_regs(®s); regs.eip = (unsigned long)res; @@ -5233,7 +5238,10 @@ int main(int argc, char **argv) regs.eip < (unsigned long)res + blobs[j].size ) { if ( (i++ & 8191) == 0 ) + { printf("."); + ++nr; + } rc = x86_emulate(&ctxt, &emulops); if ( rc != X86EMUL_OKAY ) { @@ -5242,13 +5250,17 @@ int main(int argc, char **argv) return 1; } } - for ( ; i < 2 * 8192; i += 8192 ) + for ( ; i < 2 * 8192; i += 8192 ) { printf("."); + ++nr; + } + if ( (regs.eip != 0x12345678) || (regs.esp != ((unsigned long)res + MMAP_SZ)) || !blobs[j].check_regs(®s) ) goto fail; - printf("okay\n"); + + printf("%*sokay\n", nr < 40 ? 40 - nr : 0, ""); } return 0;