From patchwork Wed Jun 2 21:52:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 12295737 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5040C47092 for ; Wed, 2 Jun 2021 21:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE936613DA for ; Wed, 2 Jun 2021 21:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhFBVz7 (ORCPT ); Wed, 2 Jun 2021 17:55:59 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:38789 "EHLO mail-pg1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbhFBVz6 (ORCPT ); Wed, 2 Jun 2021 17:55:58 -0400 Received: by mail-pg1-f176.google.com with SMTP id 6so3429843pgk.5 for ; Wed, 02 Jun 2021 14:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=35KIHc2zbuqTDDmHxLiGEjjkMvfweMiA7dOZFvgi+4Q=; b=LjLCPWyUJCv/nwUzKFfEIhyVhVfkxZ26x4S6/dHjpZfmu4UWHdiIykV7QdhTgyDSNk EhJsuQdjywMyc0patC9/YhnK4GAEKwXcWBH1k9VcGDPLLnGjo6s3g0NA4yxRRM2jwLtJ aOdBLSMDVdqFcVTlHqXB8ayK55NwWyV5sFYOg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=35KIHc2zbuqTDDmHxLiGEjjkMvfweMiA7dOZFvgi+4Q=; b=dadKN2peTPUJ1d0fl9uKdScPTIWCxR1QqFiNVExutl2JCFGu4LZiQC4htm0g/vz3nP bF9ma1ydGU7DRqYAwn9MZJnw5xnm6FvxdFt9iCgnx9IgnxpJj7YPrf81Fpb8xdnhi87q ofkQhgNC73Z8dpyMvgtKrur9BNa8WhIf8S+XNo2vt16qo33xkPc4UgrPPT+BZTvSKn6F kpDiiXZlra56nYpEVl3qNvPUugaI6WIn6k+BOsIPt8eKnJlIti1aqElVpqQ08i9EEelG EG9bJ+DDYx30sey+ViXhamKDrkVcTntm6XcvJTyvI0keNwAwUB/4NgT9ZTKedo5TPaDM CeUw== X-Gm-Message-State: AOAM530KXCYfy/51sgQD7Pqy2snCbK0d9tIFgPXX+0G2qIcp4fPDD9Mp TrZ+sZni8AY9zlXgdW/URlheNw== X-Google-Smtp-Source: ABdhPJyxg3ClKV30rkuhRaEjtEXoFLZP5PUk5uHwm06Hhq5bZhf8yYnj5RfUFCfEaRDEHlS+nL22Aw== X-Received: by 2002:a62:7fc5:0:b029:2de:5813:8890 with SMTP id a188-20020a627fc50000b02902de58138890mr28955694pfd.60.1622670780709; Wed, 02 Jun 2021 14:53:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i2sm364203pjj.25.2021.06.02.14.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 14:52:59 -0700 (PDT) From: Kees Cook To: Dave Airlie Cc: Kees Cook , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB Date: Wed, 2 Jun 2021 14:52:50 -0700 Message-Id: <20210602215252.695994-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602215252.695994-1-keescook@chromium.org> References: <20210602215252.695994-1-keescook@chromium.org> MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=331c9dbab9265663d4598c7d5fe5739206ff6d5a; i=Fc5wke0Q0f+i/yxn94DGR+5HIU9duCLMgabBT2xqE4s=; m=wFfctFfoMi2zK6PlZHUypYp3tGHtf9WefM0kh+Zb8ng=; p=2mlWRMfcN4+QsvDCUI3dA5+oKnCQumRrgTAwchW8Ges= X-Patch-Sig: m=pgp; i=keescook@chromium.org; s=0x0x8972F4DFDC6DC026; b=iQIzBAABCgAdFiEEpcP2jyKd1g9yPm4TiXL039xtwCYFAmC3/bMACgkQiXL039xtwCbhEg/+Imd 0I18ddKDJ9AiCRaG4Zm1BLowuBeI2IKKfqbSeXmJVztPyaBSLkLUiCIzM3MraBgl3w6HXFulytfW2 nep/TIf/0nf4qsDdCuOEnaBb8hWd04D8gGmQfqmrvTcIXv1RFcvb0io3fZbESdDpGrEKC5Cathvfg mKqvE4wkTDCtAiGjlK3mb5httl3x0WSV9StwVD26pfFgqDnVNfpxzbqVYfsEfDslKlpQaqLpqoOhq WtU4Dct+QHtYkk4kTSZ+xZIAL0POqSf/2kIYYII/N4dlF5sc9SIdUjsfUEO+OlYboBiabk1sGEyzN qjh6zeiMPt5Gp8cH57QRixWB/UIOhDwgKq5jVkMC5Qev4r93gj19EjjHKEVThWtrJW1uXmfgfgRmS 4pO5aXWdh6U6EdFrG3/h/hfqHxxBc7zBjUPkli5zHNEvLYVodijf/wWXHAIZ+V1LAk2811KyASnSc fHv6akvRK//nNX4CYCb+suSdUD79IzDdK0UtBj4f9k2+aZZZddlhraBwEbSRNUPjGUnYJ20xGI2Hu HV7uZiw7qFYjJFzyvxzgQEZNLcYb8VMYigUHPc+8XdMiICDvqC3PH/+ZQBT0NvAJrUb8Af1FZJa4d EQE+6ZRFjC0Hq5YzPHOoIpnJEPHz6KwlwcRmXWI/3q6u1VHLg7D5d8J0B8fzkQjM= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When cleaning up other drm config dependencies, it is too easy to create larger problems. Instead, mark CONFIG_FB as a "depends": drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! Suggested-by: Arnd Bergmann Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ Signed-off-by: Kees Cook --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3c16bd1afd87..90891284ccec 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -83,7 +83,7 @@ config DRM_KMS_HELPER config DRM_KMS_FB_HELPER bool depends on DRM_KMS_HELPER - select FB + depends on FB select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE select FB_SYS_FOPS From patchwork Wed Jun 2 21:52:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 12295739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C71C4708F for ; Wed, 2 Jun 2021 21:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18703613E4 for ; Wed, 2 Jun 2021 21:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbhFBV4D (ORCPT ); Wed, 2 Jun 2021 17:56:03 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:39738 "EHLO mail-pl1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhFBV4B (ORCPT ); Wed, 2 Jun 2021 17:56:01 -0400 Received: by mail-pl1-f176.google.com with SMTP id q16so1818319pls.6 for ; Wed, 02 Jun 2021 14:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=294OLwHTColeKIbvM+Vxirn0n1T4QgV6EDZpTr74zIQ=; b=TPRhf40qFHect27NNVxe5HetAqBac8ZEqrTA6gXjniSh3j9Js2prokUdMKY1HzVkAF xf+7Wv8hjoeFaBhzy4ZlNv1Uk7WKURjIros/bhV+1xfc/X3fh3PR0afmqqHwLqfq6GgS UAm2fggL0u2uN7X88Tmj9A/BaL/6sRP9TOyPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=294OLwHTColeKIbvM+Vxirn0n1T4QgV6EDZpTr74zIQ=; b=UedvQXORE/dMrbXHzEaG/0zqOMndHAq5DWwG7VhzVj0la/XSRQtx/uGxZTSve+x6Ao NN0SvNgwAHEkIvoYvVE9jgJduZzteVmG4OeyXH/vwbJaiXwSn5IYk3p5bwE3qNJqsumq gsfBkpI35nQoNiARF0d6PIkZxWg+ZidQ0lygPv6fpaOW6iIsE+J1sQZ8fbVgV8svuQ1S Gqu9AmzkexngH48jo6KBy0iCiLcFkIHrS4Ga8mCaZMOWJUvD4U6YCf5HKRvj5fdvMi09 dVXQ5brIw6ZbPWrAacWwcPbBcm1RbxlwC+qrrSSnRSL4iG8+JBRjBU6drSU7efsTqzkR /hoQ== X-Gm-Message-State: AOAM533w7Tj4cOcVi3CATCE1xpL34qWHZQJ+sf5b61FtbnLxc2TURDsa X/pmmHSWdAzKpEntwUqNh2MGBg== X-Google-Smtp-Source: ABdhPJyDYLf1Xk/q7chv1V0jA9dP3c7q0nRFMdSazCr0Tpvc6IKLruHHQQ7BjHSxbyk6f6duIFiwHA== X-Received: by 2002:a17:902:b48d:b029:fd:e7d2:4e98 with SMTP id y13-20020a170902b48db02900fde7d24e98mr32198306plr.55.1622670782179; Wed, 02 Jun 2021 14:53:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w26sm646667pgl.50.2021.06.02.14.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 14:52:59 -0700 (PDT) From: Kees Cook To: Dave Airlie Cc: Kees Cook , Arnd Bergmann , kernel test robot , Sai Prakash Ranjan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Arnd Bergmann , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 2/3] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency Date: Wed, 2 Jun 2021 14:52:51 -0700 Message-Id: <20210602215252.695994-3-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602215252.695994-1-keescook@chromium.org> References: <20210602215252.695994-1-keescook@chromium.org> MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=b3814fe4bd33921403b01af8b87c0ad8bda4b97e; i=F41GiRbSdBaON2nBD/u4X1mdcnbCCx8eKO1cTn6eM9g=; m=lCmQIRI6GhZ9M8T5GPwD8Xs9Sn4SkeWxgYU4anLVMAw=; p=GXRYnPgQOHuLukoESgGOFME4H/mwNAwviL4ERy8Ru18= X-Patch-Sig: m=pgp; i=arnd@arndb.de; s=0x0x8972F4DFDC6DC026; b=iQIzBAABCgAdFiEEpcP2jyKd1g9yPm4TiXL039xtwCYFAmC3/bMACgkQiXL039xtwCZ8cQ/+KNj z11/7Hu0gAQx32xz2aL+8PMUyEZJqRMjh5EGmjm0yiQX4o3bHcTetWySoAhqwuIk0pCd3BTuP4gco KSpa/Z+9Jt+BynDVOQlpeHeWbyLLpdiQCkoF4pXNNhzOo+MbIuS74tCICtglNjGNxftt2fKDuVHhj i4V6elio1VpugMPwKfrfjYHPEdQ4372aKhuXo4spji9jt66KRthG50aWFnfvp3nFTsVMAIJshMb13 bkAVIQIDjxmtHn8iKn/W2yvjQ7IFqE3wtOuKG+c1DUXKhm8MJI5GPVJ8IpIrFxBsjA/Yyuy3J7Zu/ ZGDG8GnZo3Ysiilg/GJ75bufLueWnlQZfqyUKWQ5V+qP2HpvuKQtNIrO8sommNnUCJizOTYjD21bP Z5RXFTFdfyVRJ2Tq3SP8bhgRfZH9oa0dHTUOEw5RwgppvexPNvcN++XDxvhSCfW9MCgLHFNOeyyyi lZX9Q2tN4ATnUHdyqehbHl+/A89ZnEpbC5dRGManNN9tuqs0PtxNV23j+UdD0MhS+hUdgZvaRo1yv X5DLwoDqEZ9kve0nSZnu2ctNezGnFF+0nIlPvjl3Vj7xFv6CUrTNf6S0JcGfNeBYXLriPpyYBkwNk 6FzbT9lJ472MPfz4K50kbiOzPdOFO6s7+H1jljAZHbOz0luWUINKZ0yTMIB82cwo= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Arnd Bergmann When LLCC support is in a loadable module, the adreno support cannot be built-in: aarch64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gpu.o: in function `a6xx_gpu_init': a6xx_gpu.c:(.text+0xe0): undefined reference to `llcc_slice_getd' a6xx_gpu.c:(.text+0xe0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `llcc_slice_getd' aarch64-linux-ld: a6xx_gpu.c:(.text+0xec): undefined reference to `llcc_slice_getd' a6xx_gpu.c:(.text+0xec): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `llcc_slice_getd' aarch64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gpu.o: in function `a6xx_destroy': a6xx_gpu.c:(.text+0x274): undefined reference to `llcc_slice_putd' a6xx_gpu.c:(.text+0x274): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `llcc_slice_putd' aarch64-linux-ld: a6xx_gpu.c:(.text+0x27c): undefined reference to `llcc_slice_putd' Add a Kconfig dependency that disallows the broken configuration but allows all working ones. Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") Signed-off-by: Arnd Bergmann Reported-by: kernel test robot Reviewed-by: Sai Prakash Ranjan Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20210103140407.3917405-1-arnd@kernel.org --- drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 10f693ea89d3..52536e7adb95 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -7,6 +7,8 @@ config DRM_MSM depends on IOMMU_SUPPORT depends on OF && COMMON_CLK depends on QCOM_OCMEM || QCOM_OCMEM=n + depends on QCOM_LLCC || QCOM_LLCC=n + depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n select IOMMU_IO_PGTABLE select QCOM_MDT_LOADER if ARCH_QCOM select REGULATOR @@ -15,7 +17,6 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM - select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE From patchwork Wed Jun 2 21:52:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 12295733 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F8AC47083 for ; Wed, 2 Jun 2021 21:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2754613E4 for ; Wed, 2 Jun 2021 21:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbhFBVyp (ORCPT ); Wed, 2 Jun 2021 17:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFBVyp (ORCPT ); Wed, 2 Jun 2021 17:54:45 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 684F7C06174A for ; Wed, 2 Jun 2021 14:53:01 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id q25so3281862pfh.7 for ; Wed, 02 Jun 2021 14:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lq+j7EC+Gx3WCGnwMoYdurN9sibRpLzB0GmPg/1XgI4=; b=ZW8yTi6GD9LVnQGgbwo7rCdFxHYAbahm6RVRbWxUIawzLI1CZPjxowlt8Hh1exyuRy k19Q3/ejbH+Q6mmwftrSaksUZNmGAHo28+6bOBlc+RR5jrUI/MNmiWATRfTeZQy+50x7 1HaZvk1hcHdu+y/2AQxBt8PoB7Wuh3DNjuPMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lq+j7EC+Gx3WCGnwMoYdurN9sibRpLzB0GmPg/1XgI4=; b=aANwC63GnNOADZzFRzuZemlZ/2TwEAIZR6zTxmcmjtTcZAcO1Vqa5hhyCHwUfq/d3h PJ2ELWAcBXzTeEZSdagU77PeEX5uwIujOWQI30yrbDbavKO2rI3hNuRGjBVhuhuTAOFj lXl4dW6o8yRFqjxXfSzzboR9wRs84s66ZyAcO3DtOvDY8QlnJ5iuw14pH2K7QPFeeCs5 CWPnYml8w5gkUTjS3ipZD+bZ7d4lBCtlV0RLWF5S4FoDC2ChgeOKCeeQklhYnZDpIh4J TAIldQ1UYgMTuhopIz+x6UKbR/EbIoQVa+ac9JN83evfY9t1bEcnx5HdKIzMJERK74rW MFlA== X-Gm-Message-State: AOAM531kA83AXFbm2f6R4jJGB7qDSFEDSYI/JVyd7Q/N6Phbai4onhy7 PzTUahd+cW5lg3DLCogMDFFmLg== X-Google-Smtp-Source: ABdhPJwmcFpZGL+MxakC+BMaC0MaiMcHHXa/0QiO/Q1wGXl+KYNDte2SuGLilUulhfJf70RgoiQNyg== X-Received: by 2002:a63:5243:: with SMTP id s3mr36032666pgl.247.1622670781046; Wed, 02 Jun 2021 14:53:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u18sm479143pfl.9.2021.06.02.14.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 14:52:59 -0700 (PDT) From: Kees Cook To: Dave Airlie Cc: Kees Cook , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Arnd Bergmann , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG Date: Wed, 2 Jun 2021 14:52:52 -0700 Message-Id: <20210602215252.695994-4-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602215252.695994-1-keescook@chromium.org> References: <20210602215252.695994-1-keescook@chromium.org> MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=332597a6d55ed7eafea0e90e859a70f13cbb227c; i=8MxRaXNzqVxdNVEPomOFWVQoDm0jYqtSTv9XIpyrwpc=; m=udlaZ1oHXV60sxBE3Nj6kbx16O3UEb46qJEP0WlSHd8=; p=AjO2aPczGcbQWOJvkZf4iZvbUh/TdY0/fYtGPqGdXnA= X-Patch-Sig: m=pgp; i=keescook@chromium.org; s=0x0x8972F4DFDC6DC026; b=iQIzBAABCgAdFiEEpcP2jyKd1g9yPm4TiXL039xtwCYFAmC3/bMACgkQiXL039xtwCaH/w/9Foi 8lhEBwfuFJ6LsrHV4FO6P7z7eFV1kN4o+2J1Zmw4efs/Rbr6c60xLBs0XZwZh13P/22y1XlpC1kxW nB/VM8cAQMCj5SOxBKkLCLdEyFXD7npP+jABSBaJk/tS4pb+jX+96YlL7Xk3aMREcp4d9/ZMps6sC bxHo2Ntevt1AYcCdv6SMb4EBWb2t9IEzpi+6ULPpHsPPDDjH/WGwAfPK7Zj//O6y/rNyORBjt+FX5 Gun1bYScjTwT9PhgIcQogqC8rvWBfsfD09c+wV3tJmwOhBUpw9KnKwGuRCMMEZ0FjmgI75dlG32XY 416CaNox8VLvwQVNdEQKaNwmvlKdaGBBNTQJb2xE3pK6AjiLVox7eGZvbp+deVGSdRy2YKsEUEEhs kZSZiDrkwsNHeurzSwohjPMzarPu0mbca5jr0+riWGNlDLAw90NjaDPML1l6oD5Puv0GN6yJ7h4Nx +Q1u83v/2xJrZmxmBPqE8yqefVrRA9f4+cHjYq/SL07Jy67UzzKmchNJZOkId93loyBeLFMMoSTKJ 1gix2nwn5DV1kZWXpEHTjnsFR4QEmaocAc2CkBVOjmSMa5r+cjE4dPIOiOpffPRkgOxxETj04+WAF y6npaQq+RmPQ5235GZUtT+hHCoPNTyIhoC/QYFl8y0xfR0LpIwsPkEMMlLGeACwU= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Avoid randconfig build failures by requiring VEXPRESS_CONFIG: aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_vexpress_clcd_init': pl111_versatile.c:(.text+0x220): undefined reference to `devm_regmap_init_vexpress_config' Fixes: 826fc86b5903 ("drm: pl111: Move VExpress setup into versatile init") Signed-off-by: Kees Cook --- drivers/gpu/drm/pl111/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 80f6748055e3..c5210a5bef1b 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -2,7 +2,7 @@ config DRM_PL111 tristate "DRM Support for PL111 CLCD Controller" depends on DRM - depends on ARM || ARM64 || COMPILE_TEST + depends on VEXPRESS_CONFIG depends on COMMON_CLK select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER