From patchwork Fri Jun 11 13:04:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12315707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521AFC48BD1 for ; Fri, 11 Jun 2021 13:04:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2FC661364 for ; Fri, 11 Jun 2021 13:04:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2FC661364 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.140371.259377 (Exim 4.92) (envelope-from ) id 1lrgpq-0000pt-Rc; Fri, 11 Jun 2021 13:04:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 140371.259377; Fri, 11 Jun 2021 13:04:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lrgpq-0000pm-O6; Fri, 11 Jun 2021 13:04:30 +0000 Received: by outflank-mailman (input) for mailman id 140371; Fri, 11 Jun 2021 13:04:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lrgpp-0000pg-AK for xen-devel@lists.xenproject.org; Fri, 11 Jun 2021 13:04:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1d143e79-4179-4fa9-86da-e0fecf4e644e; Fri, 11 Jun 2021 13:04:28 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-34-6ZGDkgUFPcuVh2sEyKoULA-1; Fri, 11 Jun 2021 15:04:25 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7149.eurprd04.prod.outlook.com (2603:10a6:800:12e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20; Fri, 11 Jun 2021 13:04:25 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4219.022; Fri, 11 Jun 2021 13:04:25 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0030.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 13:04:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d143e79-4179-4fa9-86da-e0fecf4e644e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1623416667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VJz7WJrgdIu7Yqmi+3r6jyJnowYjSigtTjONlNknBI8=; b=gtjUX3CISnuQ2fTVG7UYOpvnxWJQcPfWmnQ/ixTrEFXG/B7kmFzy2YhhbwYwwyFeqFGz/4 2DnScSW0iLPARVKQL0YDvHqKOjWLqMXaI8EeXCFXxduryCXaWhcvcx8GxoWTty2FagiSC3 pKn4qk9rvrv87v3+RwCNY90LBPhNfLc= X-MC-Unique: 6ZGDkgUFPcuVh2sEyKoULA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGg10AqhXHEfQP8m5wR+6flTYcReNqfTEbj2jNr8n75ZcFKu7iHfUewtyhzEngJIuSMjsHWxCNSsDL66LJUaQ8SwvFnUlbx6APDBS3P4UwTM0BJg1iolg/tiiCyhd//axNv3qy6B41/WPMqSBjeec9aKfZE8KT10VyBtUbmV9j9OpqePZMXX19YSOKNxiIqnRJ5pp62b8+zuk44dup5Rdu4DC9C2bZqFPX/8/IeQ+QYYBKD8AP/NDzM1XdaPSAv8FM2dfziNXFdk/mAk3qHl5GQEqTCsHBu0JY/Dy84fF0OBcbhSp+mmKl/xyPhrMKQnfLHonDFTvhd8qP1Cp/bF6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VJz7WJrgdIu7Yqmi+3r6jyJnowYjSigtTjONlNknBI8=; b=EgztL39ul5Gz9vMdI1kEQ8pynhDab82CRX6kNCEXVb57YkI2RjrAGsDm20YzNg7879jQfi5YZ0IU/SfwLgfTQ+RxkgXQ4vP4qdF1eCkicnMlj3viecYMcnDG3iyz56bVBvI8OYsJn0Y0AQIrEYL/Nxk/YanfVOwf/U+rNQlGh5OshY6lYzxmSrzpmXKpe9gQORZcGDav22aC2Xr98rY+2HiMslx97yfXdj19PXf7ps4QnfDJReEdI548cYXpOr4p/BGIsrJYj/aWzA2ShWvlTlmXMDFK5BkC3ujEfzzd4j47faShYe8fijisCo4hEe35KjW4KJWkdxc2FFtpk6B7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; From: Jan Beulich Subject: [PATCH v2] Arm32: MSR to SPSR needs qualification To: "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Julien Grall Message-ID: <2d0ac238-bf23-51ed-9ccf-6fd65fc6eec4@suse.com> Date: Fri, 11 Jun 2021 15:04:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Content-Language: en-US X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: PR1P264CA0030.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23b1ad84-5d1b-43b0-03ad-08d92cd97026 X-MS-TrafficTypeDiagnostic: VI1PR04MB7149: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1q/TJE+uZKjo/oGWygKuGIjHPS2SBMKx6CI7IP+heHaiSj8BozcLBbi6zUkz2V9EYW4JVHXEz//mjulEK4TPjhgEY9R7fHrI2oN3LKaJfoZ2v6DNdtwhw4GsZeT7AvVkHjdohWHy75rTrwmo6Ic7KIdiGnUEDI1P4Eq2c0Nc0orxNRreJ8Uk9AWrCsqLKwQXCXEuknVy9kECl/2nT12f1PCV1HATwKp5V0EUHEoRwUXz/N/WVWOgYqfn8wUOMzGOgYE2ULOvCrthmmjd8XNe6K+H5PWs7jG6DoRkSjEk5sfYFWtkNX1438EyN+FlPS845HsbAft6pZyxwtCPKh9WVfvTCJP3mNIRJD5bEaY8hobxiiWGzgmNolXGWR5/w/1VzvmLbrO1OLfRwIpoAPPs+Ti2SU8RYUaSZGvGUxW9vYrk3oFVOJGMDOL4a2lxWUINaLDYkNa5xiNigcCqykuDfx1byPBh4BgUltguNDWwgKpYElRcAfBoC+P78Qfst7vsOcOJ8meaN1JotHd4ikz4IybDNAvklZrdtB6KV/PqGCOYjOf+sfxAYaMbSxsm6wOgYpfqvYXM0Ws+EemGjwE2oJ8wGo0pXCqVlWApla5kbmOkfHYYKq/kHf/Sb3DgybEYs4HEFESV/49K8TvR09Dse9bA52505bLC4We1bCuxt7WhzuwFLhCDjIV1R++M6Bkl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(39860400002)(396003)(376002)(136003)(16576012)(4326008)(66476007)(478600001)(6486002)(54906003)(8936002)(316002)(66556008)(2906002)(31696002)(66946007)(5660300002)(31686004)(26005)(8676002)(16526019)(6916009)(186003)(2616005)(956004)(86362001)(4744005)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dlxeZeuZUOMhU2h6y0K9whRjrxbA?= =?utf-8?q?1gENnZgymWwBo+TF7A03BQlkxXhC2VI1LvfNBEaGCTU5w0N0ASzTNf28lQUijEj3B?= =?utf-8?q?OHqfIu/pGa+YwCTjqDZpqWHnbDi+581xYLeQMQQvh9oTRPZj34+lGoHKVqAKPV2M2?= =?utf-8?q?HHEgE25Ui5oeEsEc5SMfvk4gP5p3xj4UE1u6zM9ViyZUaeYBA7XqPHWUQkhEBKKHc?= =?utf-8?q?+kH1UEfwq1KekN4KlDzLuuzrqL4b5PB9fJZelvm54lyCCsBnRzP6Lhl247dJUYEFr?= =?utf-8?q?Pjl2DWXUlcglsRe6BAAGlcxbdZfpjCmreos42yxf0CdH2U+0wEePEJukTXC5rbZai?= =?utf-8?q?J4UcsKXSZl7l542J27OyJl2J8wbCgbck4pU04FbD+IKX8z60z6HKrMMXRp62ELr51?= =?utf-8?q?UvU1GKmcTCqOcXsJFm6shd71TTp1nAE6lxJ4lEsy5Hg1fWC5WunExYhZoOJOhkPAa?= =?utf-8?q?/f6OlKb9enum9NyhLBrUIz+erq8lsabKcVM2iD88HaGRviGWSpWhPYvJJjnirJJ9d?= =?utf-8?q?9u+/BsAcJHyQ+CIhvkTgBv+SliB2AiodePQvl3xZs1T6EBiv7TvNsLkdzOE7wMmq3?= =?utf-8?q?GDB04QkKnbFBjsXe8SQQdTYq4bZGLitV+DU2c4jpomel//5XS6KgBr493Zjm8Tt2Z?= =?utf-8?q?h/B4JPAK0XfzXg/+NtYhGjSeDv2D/2lmxA+4MTfD1BplwiM2My6PmtyfEkoADy+Xz?= =?utf-8?q?yMOlBwhZ5BrMa0zDagrFwnIgUTv9R62e7Gv7VvzC4gOx6z0M/NINIxXtR4KHuX0KG?= =?utf-8?q?xCyjUrnZjVQfpoGnFQeFKDjxkrYLFa3R31lmHj+qDMhs/8YVKgTPWmedP5sE0Bcqg?= =?utf-8?q?VA3ZqSKujNou8J19ANHYNxtIl4Ax2n+lSbKoVvOFsEbY0ROfGARbdS3nxoAhOX+wX?= =?utf-8?q?TRBYr0LnACdb032NizSgH+DYjQwBKyxg9xXw2KTUx6hdv7m723O/i5Mk94YdX79H1?= =?utf-8?q?lhiOfrFdHVJt7JfVMJdT+ZLVe8epHtfj8ZmgsyK9HyZkfY5DP8tDDx8Q9DkJF4tZ+?= =?utf-8?q?7lV/q/cuNZW0pqy0RgHMrYBoiDJNBYGnegEnBCCNmwnva7Sd/BHhH9i/gXDhAeWl1?= =?utf-8?q?QZ0CyEXGaEzWxkItNuh3giZGYinXdATuOOpNGs8KrHIzmyS/J1RvqlbxJVUyPOGG8?= =?utf-8?q?uBAi7436UYl8fWrIyP90QriNwBFFlIjyQL4XnGJTvgVrQ4Wti1BONT8Lj7bZxzoWb?= =?utf-8?q?8Rr9NcH2A9EDQY2ypieGLcO4upeFATSp/dDf40MRQyvPq3IXeMX1gBMoS55urYkTi?= =?utf-8?q?nUdVqdvV2d5dhkCa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23b1ad84-5d1b-43b0-03ad-08d92cd97026 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 13:04:25.1570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EPR8fvUfmOVHwW6DbMGBAfY7VTAzernjFunAgKVhGgvI8BJrDE+zR2ve1QdxWSg0PzS3Ch/ENFbiuyoRRQP4nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149 The Arm ARM's description of MSR (ARM DDI 0406C.d section B9.3.12) doesn't even allow for plain "SPSR" here, and while gas accepts this, it takes it to mean SPSR_cf. Yet surely all of SPSR wants updating on this path, not just the lowest and highest 8 bits. Fixes: dfcffb128be4 ("xen/arm32: SPSR_hyp/SPSR") Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- v2: Add doc ref. --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -395,7 +395,7 @@ return_to_hypervisor: ldr r11, [sp, #UREGS_pc] msr ELR_hyp, r11 ldr r11, [sp, #UREGS_cpsr] - msr SPSR, r11 + msr SPSR_cxsf, r11 #ifdef CONFIG_ARM32_HARDEN_BRANCH_PREDICTOR /* * Hardening branch predictor may require to setup a different