From patchwork Sat Jun 12 06:03:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiang Liu X-Patchwork-Id: 12316885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A97C48BE5 for ; Sat, 12 Jun 2021 06:39:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA32C6120E for ; Sat, 12 Jun 2021 06:39:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA32C6120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrxIR-0000ub-H5 for qemu-devel@archiver.kernel.org; Sat, 12 Jun 2021 02:39:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrwk1-0006kS-59 for qemu-devel@nongnu.org; Sat, 12 Jun 2021 02:03:33 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:43740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrwjz-0001H4-BQ for qemu-devel@nongnu.org; Sat, 12 Jun 2021 02:03:32 -0400 Received: by mail-oi1-x231.google.com with SMTP id x196so8216335oif.10 for ; Fri, 11 Jun 2021 23:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=O8FM9eqyBLedaVhXuxy1OMJoAvfvBV+KFhyeVhD0AdE=; b=jeNmlwHLq2iKb2GBOdvOKQTUvzhG+5Mk0xg+94V1/2wB+FEhSPMpSQJyq/bJkT3eWs dlsPpk+jYfInOItejTBZuW4iYWCiefd7QDSSy4oHeHhspFhwyrZt6H6GHn3oAHm6XBrS dUD+Jg0B6wm5P1nb9NurjIrfNBH/97v7+sqn+YRJKelbAV9lO4/v5WQAb88QbQNqrbPA xppeuBnTH7g2SbEdz4n7lBKz/9Nb3M/iw2iGaMmhDj5GcUy9M7cAWGUPq1moe2jYpO8M V7oZRBx9ManhEk2VseevTfmtJ6najbMEpdM196YHXQr5cufhBabh3HMKZI6cf9CzHfX2 xHaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O8FM9eqyBLedaVhXuxy1OMJoAvfvBV+KFhyeVhD0AdE=; b=AXmtn2wniymL9zekEY+/2mZ5ZVoNJ+3+NVVInxIfAEQqHjNSRSqLpvD7WdjXyYG2oX iYCv68ssO85NdD8wB2v1/5HX5AxBAUUZg2fufDEjrTPGUNjZTI9lx+l1s9CB7a6WfwTd W6d7NrX36OVMNMEoDQ2CSbNiK0BBhGt9VukIYxzcdx9pU+5Vb+042sgB3Oir11DBVjZb Oe2JH6y/y4Ean31oRSZpijCcOxz5lKqLSXPe687VCjJktj5V1stXlSpWH8FzZOz8/+jL uxP+XCFnnprQcCktCmbR8ySh4daDQXVr5tsJIgAwSl5+bOG9mXYaZDjZOBLZwbGfcRWz g/uA== X-Gm-Message-State: AOAM531rxGITepJngH5T6tck7xryW4WjcvIMO5pKr2rGz1O7pMkalCoX EBnvy54gIphmOrV+mKcS3n42Qmd1XHS9m1exCVMWSXdP0LMfoA== X-Google-Smtp-Source: ABdhPJxjczIxpugYbnepkgJT9HtB6Bn8ga9F2zaYT9T1OcpmFQCrnEObzygZcEQWL8xS3ee8FZSLJBCV3zu/9012Ew0= X-Received: by 2002:a05:6808:68d:: with SMTP id k13mr4651017oig.83.1623477809036; Fri, 11 Jun 2021 23:03:29 -0700 (PDT) MIME-Version: 1.0 From: Liu Cyrus Date: Sat, 12 Jun 2021 14:03:17 +0800 Message-ID: Subject: Subject: [PATCH] hw/vmxnet3: fix vmxnet3 g_assert_not_reached bug To: qemu-devel@nongnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=cyruscyliu@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 12 Jun 2021 02:38:22 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: cyruscyliu A g_assert_not_reached of vmxnet3 can be triggered by a guest with the root privilege. Remove the VMXNET3_REG_ICR branch thus get rid of this crash. Fixes: 786fd2b0f87b ("VMXNET3 device implementation") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/309 Buglink: https://bugs.launchpad.net/qemu/+bug/1913923 Signed-off-by: cyruscyliu --- hw/net/vmxnet3.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.7.4 Hi folks, this is a suggestion for fixing this bug. I'm willing to discuss this with you because I'm new to contribute to QEMU. Best, Qiang diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index eff299f..a388918 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1786,13 +1786,6 @@ vmxnet3_io_bar1_write(void *opaque, vmxnet3_set_variable_mac(s, val, s->temp_mac); break; - /* Interrupt Cause Register */ - case VMXNET3_REG_ICR: - VMW_CBPRN("Write BAR1 [VMXNET3_REG_ICR] = %" PRIx64 ", size %d", - val, size); - g_assert_not_reached(); - break; - /* Event Cause Register */ case VMXNET3_REG_ECR: VMW_CBPRN("Write BAR1 [VMXNET3_REG_ECR] = %" PRIx64 ", size %d",