From patchwork Sat Jun 12 12:31:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 12317043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24EAC48BCF for ; Sat, 12 Jun 2021 12:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 738DB61156 for ; Sat, 12 Jun 2021 12:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbhFLMd4 (ORCPT ); Sat, 12 Jun 2021 08:33:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:38012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbhFLMdz (ORCPT ); Sat, 12 Jun 2021 08:33:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99D3361002; Sat, 12 Jun 2021 12:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623501116; bh=wz5v0ImnA0pHYk6PkAn79QziXlAAml0OVK/ns66FljA=; h=From:To:Cc:Subject:Date:From; b=VFmyJlWV2oILgx46ou5ipjbdRO2sNPSzNHOn0+N4YxCnxMFrWdQZOzVMCRGCl3yvV fPaHB157b8tljj2awf9nMX1ZFJmWNd8/pLu/iLzPvUg6jIxLSJ/4SLVRDDLI3fmwSl xVYl0TblkO7T25+TOHN5AlsUFVqaSD56unaEr386yzJJWuymsAhp0saExVBPH/27+U fNV0O+iKzxN1VXXIkadsxvQONNK8YPCz80JT4FCBJZcrDrODnuHmhmhaGwnsiz9/lE MnSDyYVlSYnzLJaR+RWjyTDguhQPf+MrLsMDg+3dwc06TsryEu5c/teqJgYO4IcE3u J0isYIH7YT+Jw== From: Jeff Layton To: Eryu Guan Cc: fstests@vger.kernel.org, aweits@rit.edu, dhowells@redhat.com, willy@infradead.org Subject: [PATCH] generic: add a test to ensure that page is properly filled before write Date: Sat, 12 Jun 2021 08:31:54 -0400 Message-Id: <20210612123154.8098-1-jlayton@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org We had a broken optimization in cephfs and netfs lib that could cause part of a page to be improperly zeroed-out when writing to an offset that was beyond the EOF but in an existing page. Add a simple test that would have caught this. Signed-off-by: Jeff Layton --- tests/generic/XXX | 53 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/XXX.out | 5 ++++ tests/generic/group | 1 + 3 files changed, 59 insertions(+) create mode 100755 tests/generic/XXX create mode 100644 tests/generic/XXX.out diff --git a/tests/generic/XXX b/tests/generic/XXX new file mode 100755 index 000000000000..0ddaaa544609 --- /dev/null +++ b/tests/generic/XXX @@ -0,0 +1,53 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021, Jeff Layton +# +# FS QA Test No. XXX +# +# Open a file and write a little data to it. Unmount (to clean out the cache) +# and then mount again. Then write some data to it beyond the EOF and ensure +# the result is correct. Prompted by a bug in ceph_write_begin. See: +# +# https://lore.kernel.org/ceph-devel/97002.1623448034@warthog.procyon.org.uk/T/#m9f34b328623b493c529505e12f64f4dfdbddfb27 +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + + +_cleanup() +{ + cd / + rm -f $testfile +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +_supported_fs generic +_require_test + +rm -f $seqres.full + +testfile="$TEST_DIR/test_write_begin.$$" + +# write some data to file and fsync it out +$XFS_IO_PROG -f -c "pwrite -q 0 32" $testfile + +# cycle the mount to clean out the pagecache +_test_cycle_mount + +# now, write to the file (near the end) +$XFS_IO_PROG -c "pwrite -q 32 32" $testfile + +# dump what we think is in there +echo "The result should be 64 bytes filled with 0xcd:" +hexdump -C $testfile + +status=0 +exit diff --git a/tests/generic/XXX.out b/tests/generic/XXX.out new file mode 100644 index 000000000000..4e7653858e51 --- /dev/null +++ b/tests/generic/XXX.out @@ -0,0 +1,5 @@ +QA output created by XXX +The result should be 64 bytes filled with 0xcd: +00000000 cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd |................| +* +00000040 diff --git a/tests/generic/group b/tests/generic/group index 9a636b23f243..204a9b548f78 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -641,3 +641,4 @@ 636 auto quick swap 637 auto quick dir 638 auto quick rw +XXX auto quick rw