From patchwork Tue Jun 22 00:39:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12336189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8482C48BE5 for ; Tue, 22 Jun 2021 00:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AA4761350 for ; Tue, 22 Jun 2021 00:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhFVAmE (ORCPT ); Mon, 21 Jun 2021 20:42:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhFVAmD (ORCPT ); Mon, 21 Jun 2021 20:42:03 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01723C061574 for ; Mon, 21 Jun 2021 17:39:48 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id c7-20020a17090ad907b029016faeeab0ccso653033pjv.4 for ; Mon, 21 Jun 2021 17:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rOHLQhB/zsp0QBNgF7Of8RLVs1zhcVo1qCLsNxBTdmA=; b=bEc1qtq4Oj3ScROAT3XarW0kD2iIdoMYwVC88tInIfEh7npnyMDXy0QsRE0tHN4RES tYhVkMpGhV+R7F8xr2Po8qgLcQsTTWuHCDXwZLDiBWzKh8t1Jdw19pdsPhJZhOzTu8RR m1GyF76BM8wBIb/gJyGZnrY463F+HV+JY5pD5SZ7J7wUVTyMuuV0+Sq3dDOOGtHTBZS+ 9WiwU4yYMntJCNMuINN78RGlXOXJ5j7iRztj9/yCK34WaBkKm8z4kUZsxjUMZcndPZwg 3JViFKu8txANG5ugut03ITUc49iYSSLNTSHAEI5oQMhexrMWLXT+h25/uJMd8FcO7VTI 0dTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rOHLQhB/zsp0QBNgF7Of8RLVs1zhcVo1qCLsNxBTdmA=; b=FmnlYAdtjyn2wHt0i7e1FTiyv1487fSGxH08RO8Cg2JnIJxa5LsTM6QRw24BWfHCH/ lz7q7vuuo0sJfA9Dk/NinAsT1oURAdbvSc8hzkrhEF7QKXV+8s035ZnAzTfAF9gXuuME kZfsqIzmXJq4Zr5WghCeYdk+H/sKD3bvx04iMXpYfprm9e0lSuFYqxj8AnqSmsIN3rhY ItRpxNj0DoW69VKzNE2pFoIn8NsOcSieMKG4+MH098qskh6PYOoNjYcB9LLv33Ota5zo Iy+wPsCpD38gXNDXd6o1ggLc6Et6BOllDi8qQvylM7cKY1sjcJN2c4TIM0TROBFKJehs APKw== X-Gm-Message-State: AOAM533r7ErEqj4Frq+Xj27XcYo/uI4IQKLZ/IVHqsc/aoUPqYFsTy4z iBlSNACEdTtD8eKi8nW1pazU9w== X-Google-Smtp-Source: ABdhPJxEKCaZYYRjjpA2vP6kFRaRaTSjTUfJoPCzCAxaalKrP/S8V43ufV8t4bp1+ZYc5NwJIkMY0w== X-Received: by 2002:a17:903:31d3:b029:ee:bccd:e686 with SMTP id v19-20020a17090331d3b02900eebccde686mr20751488ple.1.1624322387588; Mon, 21 Jun 2021 17:39:47 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id h11sm17722762pgq.68.2021.06.21.17.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 17:39:47 -0700 (PDT) From: Shawn Guo To: Jassi Brar Cc: Rob Herring , Sivaprakash Murugesan , Bjorn Andersson , Benjamin Li , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v3 1/3] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Date: Tue, 22 Jun 2021 08:39:17 +0800 Message-Id: <20210622003919.10442-2-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210622003919.10442-1-shawn.guo@linaro.org> References: <20210622003919.10442-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add compatible for the Qualcomm MSM8939 APCS block to the Qualcomm APCS bindings. Signed-off-by: Shawn Guo Acked-by: Rob Herring --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 5dc1173d03fd..96b29aa6c338 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -19,6 +19,7 @@ properties: - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - qcom,msm8916-apcs-kpss-global + - qcom,msm8939-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global From patchwork Tue Jun 22 00:39:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12336191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F68C48BE5 for ; Tue, 22 Jun 2021 00:39:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD84A6135F for ; Tue, 22 Jun 2021 00:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbhFVAmI (ORCPT ); Mon, 21 Jun 2021 20:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbhFVAmG (ORCPT ); Mon, 21 Jun 2021 20:42:06 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA951C06175F for ; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id q192so8461414pfc.7 for ; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=s0hSFyBOMIAWlCuSu1vBbDo1kcTnOHZBktwNR9sfYvA=; b=qPJdSN7g1AsTCXEWl0N7D5lxwqBZepXT3xL4VOp1k3OpauOOUFtJUck7NEIAOh9UWY pAjIzFSmKm2YCTX+CTW0dyhaW53po289RV/eVDwTpEWi0lDhxs/XflWq7fLhopWl3AZh V24oVr/ZKaElrwBOdqDzwE4cXevRsoRvu3OKPpdiL6UwEkfliqTMPtJYH+ARZInZHAbY 23JzTiG2ynK7AwYqVPwbPK2VmSjFzPlHlN2sYRvIEl1q8lFeS0U37kDLJ2lpaKsD+Y7C YXlFPLDaMKFH8P1ceC9Qhr50FDDpMTl1V1GfmW1BbCtiv4Rx043gIP3kLQjLIfieQG75 4uHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s0hSFyBOMIAWlCuSu1vBbDo1kcTnOHZBktwNR9sfYvA=; b=H+0NAcUTin5xplCTiAH0Engz7UsD/1tD/i9KybHGf6rYQt/tD0mE1mCGRWNUGLKpDw TuRZmqOW8414S0PcaHVkK5GN2OWa/Ki1WyNgkuIKyzMSmsGPMQL3zQCVBqmrNx1ih0wj HitZkEApI+MEzpcpjKqNNmJ/DUbOExR4dkhtUgDoU1UR80C3Q0FTmigsmTadlzh8gWi8 CkdFDKjQcCSS9Fu3hXJNcNxjxBexwv9Gy5DfC6BSOAEnwhIj/4LpPm0jb9pa09bXUsgO gJyo4cqNvfE+yOX2v4+Lj4pZX6VakdOewTdPVCeTDWqScIL/JQCTFvw3h0wniiPsIiV6 WX6g== X-Gm-Message-State: AOAM532I/GZoS3F4x/s8KQDFgoFvVfTzIvQ2ZF4rbHwxMpl3S9TDrr2G 8p2wkspvHly2DLElbjWbjF57fg== X-Google-Smtp-Source: ABdhPJxlEhuoFcHTsQnLHecAqG8hLUmDQm1gRFgQQWrBkWCoX6wr4nEvTWJDiCqzeSm2SPW35s7ZZw== X-Received: by 2002:a63:c1e:: with SMTP id b30mr1142770pgl.118.1624322390352; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id h11sm17722762pgq.68.2021.06.21.17.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 17:39:50 -0700 (PDT) From: Shawn Guo To: Jassi Brar Cc: Rob Herring , Sivaprakash Murugesan , Bjorn Andersson , Benjamin Li , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v3 2/3] mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device Date: Tue, 22 Jun 2021 08:39:18 +0800 Message-Id: <20210622003919.10442-3-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210622003919.10442-1-shawn.guo@linaro.org> References: <20210622003919.10442-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org In adding APCS clock support for MSM8939, the second clock registration fails due to duplicate device name like below. [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' ... [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk This is because MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock control bits. That said, 3 'qcom-apcs-msm8916-clk' devices need to be registered to instantiate all 3 clocks. Use PLATFORM_DEVID_AUTO rather than PLATFORM_DEVID_NONE for platform_device_register_data() call to fix the issue above. Signed-off-by: Shawn Guo Reviewed-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index f25324d03842..15236d729625 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -132,7 +132,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) if (apcs_data->clk_name) { apcs->clk = platform_device_register_data(&pdev->dev, apcs_data->clk_name, - PLATFORM_DEVID_NONE, + PLATFORM_DEVID_AUTO, NULL, 0); if (IS_ERR(apcs->clk)) dev_err(&pdev->dev, "failed to register APCS clk\n"); From patchwork Tue Jun 22 00:39:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12336193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5238C4743C for ; Tue, 22 Jun 2021 00:39:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DCCC610EA for ; Tue, 22 Jun 2021 00:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbhFVAmM (ORCPT ); Mon, 21 Jun 2021 20:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbhFVAmI (ORCPT ); Mon, 21 Jun 2021 20:42:08 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82720C061760 for ; Mon, 21 Jun 2021 17:39:53 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id h4so4089022pgp.5 for ; Mon, 21 Jun 2021 17:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=99szBSjbwnbGcFHQ+lhV33yeyCNyKEyxf0WQiXYwyIE=; b=kj24lNONGYpctZVMSl2KCnBuXpgtKd7zxpj8ZS9+44D8+K989zLy3x/mOfhpRhmn6i blRULkF9T/vy2ThOLs1xiUfYL8Jj1pulL/Sfw5+txF61qmJDhyWj1+mvIPtEywhs5M8H gtwE/odv6fRP+lE9j0BhgipIDqVYz9SdfjJJlJOFUoMJEsdIq/SU0nyFVabtJZzTds2F NIG+VSlNoZBMQaqwu8lA3cIDRRo4G1hJfMDOPTKKCRkUhjO+cr7CCtrv6CLgCFTCVKDO 6kuNsKakUvxxLvq7j0dbtZF8EuoJh/C++cMQheujeuvUxHKsUfIbgT75ta+2d8Wtmwq0 686w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=99szBSjbwnbGcFHQ+lhV33yeyCNyKEyxf0WQiXYwyIE=; b=IyPAk7xk5U58LpjoaSg9wyhMbHT8MTWvx8fL4L6BiCKJu3uLju316cIWi2fnoWeyCw 6ix036nBCAU+k8RxpuxXJ5ICgC9VjWeU0IQyaV1agFHy/thCibnF/mGHw2cD2nTSj9yp ZEqsq35kj9FYsVUEiYhdMphV+7Gr05hNq3ThKC2vJiSodnZt69UlSMXaxpA/mq4hycZA ZWv12aVjM0sbxKMOz4uTWtI0I6b0/y32ls33v9DdmUBmU3QySuDsYj+XKf5GygzpNRr0 gKG/4CmEBmiKuogaCWPjpfmoPh2veK1Js7AZZ6ctq+psNXV2MFO5/xEJuFzbtkc+BSfj FOTw== X-Gm-Message-State: AOAM5319y9SXjuhViKSEAMMrjiZ1fdPpTfC6E0z1+BJJI6+RYqW7X3GZ KP8gdeLIpWJ8FgXtzTWecnTkgA== X-Google-Smtp-Source: ABdhPJzBMYbQlqJqiFeGYnZVp/15nkjNDWIC81F/P340wTn89xX0o+yle47JXGlxqHziDuIZhkYaDQ== X-Received: by 2002:a63:d410:: with SMTP id a16mr1146799pgh.298.1624322393123; Mon, 21 Jun 2021 17:39:53 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id h11sm17722762pgq.68.2021.06.21.17.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 17:39:52 -0700 (PDT) From: Shawn Guo To: Jassi Brar Cc: Rob Herring , Sivaprakash Murugesan , Bjorn Andersson , Benjamin Li , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v3 3/3] mailbox: qcom: Add MSM8939 APCS support Date: Tue, 22 Jun 2021 08:39:19 +0800 Message-Id: <20210622003919.10442-4-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210622003919.10442-1-shawn.guo@linaro.org> References: <20210622003919.10442-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Enable MSM8939 APCS support by adding the compatible. It reuses msm8916_apcs_data. Signed-off-by: Shawn Guo --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 15236d729625..1699ec38bc3b 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -158,6 +158,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { { .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data }, { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq8074_apcs_data }, { .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data }, + { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data }, { .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data }, { .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data }, { .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8998_apcs_data },