From patchwork Tue Jun 22 14:21:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12337711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC1FC48BDF for ; Tue, 22 Jun 2021 14:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A487461369 for ; Tue, 22 Jun 2021 14:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbhFVOXu (ORCPT ); Tue, 22 Jun 2021 10:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbhFVOXr (ORCPT ); Tue, 22 Jun 2021 10:23:47 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968C5C061574 for ; Tue, 22 Jun 2021 07:21:31 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso1663447wmc.1 for ; Tue, 22 Jun 2021 07:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fKZsPSsndtv0jSomcSYBRePIyQQCNBSpFDpWRlbH/as=; b=Hg5k20muA413JmnSvpirZPJSmJkUv1JCW+fW2uc2GJ1Eu2blchQS2fx7xlmXkh531h 10It4JinKkvLdu/DYLg0WW8D/JpIk67FD3ePru5+bRgVUG9cTtlySIOtDS2CX9NX5nzZ za1jtcvT+Nndjid3yDt0MnsULPBMjKb8mCZR5dJSFI5Gs7pUqeYGERz36CZa6xJS8rzF BtgJ4grnYeTA5pV87Cc/NxnRB3UjRWnPK0Pt2q3cdNBQOsPL+54C3bxqfUAg8FW7P4Yp 4o+2G19uLL47WKHEDz19KJTee4cZukNOVL0UtGlHEGrTPBvtsSq4lVSYGys4CxBJst9k mUrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fKZsPSsndtv0jSomcSYBRePIyQQCNBSpFDpWRlbH/as=; b=bmX04hKzTyJpfVGaq+hS4QP2eGO//Clc1YRYHmeHx2D0GT74KQaA1Xj9Kuby4KMabb cRcF74IcXD5HxVPtjh/XHQxCh5uAKClBUMxi1S4vxQ1rmeHzb7PzjN8FvO0xuK4VzWyP 45xku7AnPcyqSonCfMJ9q6adtQtExJ9e4aOtLYzkI2rvwFLsFgxeRva2Lyk5Gp3LBNGQ nmajCtzjkjI1xOQFSfGJ3uyElBBADdCoR8NAqBJkp15DJlVzo4tEeWj9uoa6pxSPEe+t HW471b4CeLy6QZApCaXzOIEvlt6oz+y2tWze+SlWdk36VEkBUVxygiboRuuODLczEwdB QdsA== X-Gm-Message-State: AOAM530J7db4wgxJgWubEua/FsnYGx61n682UBdfO6hODHpvOZJLvy4q /b0da7Pn8qEaNf32ORC1emAzUyvDosAscw== X-Google-Smtp-Source: ABdhPJxvjl5t4FgnbEOLw1FKg7zEbvqrZrW8ug4Y3psft7EkfbDnnOaKsLXswdSZdtv66jwCd2y4Sg== X-Received: by 2002:a1c:984c:: with SMTP id a73mr4655194wme.17.1624371689931; Tue, 22 Jun 2021 07:21:29 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id r4sm22617395wre.84.2021.06.22.07.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 07:21:29 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Denton Liu , Felipe Contreras , Kristof Provost , =?utf-8?b?w4Z2YXIgQXJu?= =?utf-8?b?ZmrDtnLDsCBCamFybWFzb24=?= Subject: [PATCH 1/3] Makefile: move ".PHONY: cscope" near its target Date: Tue, 22 Jun 2021 16:21:25 +0200 Message-Id: X-Mailer: git-send-email 2.32.0.599.g3967b4fa4ac In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Move the ".PHONY: cscope" rule to live alongside the "cscope" target itself, not to be all the way near the bottom where we define the "FORCE" rule. That line was last modified in 2f76919517e (MinGW: avoid collisions between "tags" and "TAGS", 2010-09-28). Signed-off-by: Ævar Arnfjörð Bjarmason --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c3565fc0f8f..4dd9711a653 100644 --- a/Makefile +++ b/Makefile @@ -2737,6 +2737,7 @@ tags: FORCE $(FIND_SOURCE_FILES) | xargs ctags -a -o tags+ && \ mv tags+ tags +.PHONY: cscope cscope: $(RM) cscope* $(FIND_SOURCE_FILES) | xargs cscope -b @@ -3245,7 +3246,7 @@ endif .PHONY: all install profile-clean cocciclean clean strip .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell -.PHONY: FORCE cscope +.PHONY: FORCE ### Check documentation # From patchwork Tue Jun 22 14:21:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12337713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C70C48BE5 for ; Tue, 22 Jun 2021 14:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC22161369 for ; Tue, 22 Jun 2021 14:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbhFVOXv (ORCPT ); Tue, 22 Jun 2021 10:23:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbhFVOXs (ORCPT ); Tue, 22 Jun 2021 10:23:48 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34457C061756 for ; Tue, 22 Jun 2021 07:21:32 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id p10-20020a05600c430ab02901df57d735f7so1887313wme.3 for ; Tue, 22 Jun 2021 07:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fue2WtfXsyGV2IUFnwpUG3baMPEWktuB05WWVgppe60=; b=QXZH9Ct+3ZFP94ROPsDjvI4jAfyIthLg0Cq+nu/DQUYgSe5bg15AU6h4mSp19E2C4P gE4zQH2YlxgezkmC9zg0u6yspXx1NiFP8JxkW58yWk5e/P0BCH5MgmWMTnObD/0TvuPy ZEdJMokzvJJ7kER8p5idb8LxS6sjxbaJXFSF6yQGnEHdTa0ZQQpmJjbQ2qOAqRj19+PT /5a/K7N7mVxzP0C/1yddI//+nfwcqzlZWxLcVx6mh20dn4sF2BwcIeHtjI2G5ZRMxBxp DtHqaSgBXc5KH3OUoM2vqaukX8AZRIvbLqbWiH0DUTihJs0Zr/RMQDeLshn7IH2tUQ7f I7Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fue2WtfXsyGV2IUFnwpUG3baMPEWktuB05WWVgppe60=; b=J1KsoqLU+1sG9sGfQ8ibFj8gRQ9UuiD9MxPxJYOgj+PMLmKGd0FxBCaQNKvP5i1gUU 0FxfQAhuvozePydb6Ai1v0bdjqSUhfVKWmbAA8WDBB1RGaxzHKtVTSiqqMVgq8/PX3i5 IzCW/rYpMJKQ9Tc6iMB/ejGd2Dot6RaY6wqSdVcLMkuimDnntFn5GQesEYuCTa5pN9te H99Q5qVxHtr4M+zO1BABriHBqjnCcT/y8lGGJPpEPiJsuDxSwz+qvibQ6zGRnSFknp/q IPZG7+SNsmesrsDUUC1KQ8A2Wxuv6WCG9GLnRMJHqmXRMplUEYw8tGg7llB7RSyhwCxz t1bw== X-Gm-Message-State: AOAM530TL70+ENQlFC96EKF8D8b8XcIMbKmImdSnInSbFxmbdTvnEkkO DdmLFJO2bxxkyJlL8aF1EqYGkAgg/iTfRw== X-Google-Smtp-Source: ABdhPJyVcQw9f/wAiZhoUBNE4iqIF+ds6hjFSW3i6zoL5TeBOdvdFNlE4DtKhuDT6bsbYmx8XBVGMA== X-Received: by 2002:a1c:a406:: with SMTP id n6mr4745831wme.130.1624371690623; Tue, 22 Jun 2021 07:21:30 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id r4sm22617395wre.84.2021.06.22.07.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 07:21:30 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Denton Liu , Felipe Contreras , Kristof Provost , =?utf-8?b?w4Z2YXIgQXJu?= =?utf-8?b?ZmrDtnLDsCBCamFybWFzb24=?= Subject: [PATCH 2/3] Makefile: fix "cscope" target to refer to cscope.out Date: Tue, 22 Jun 2021 16:21:26 +0200 Message-Id: X-Mailer: git-send-email 2.32.0.599.g3967b4fa4ac In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The cscope target added in a2a9150bf06 (makefile: Add a cscope target, 2007-10-06) has for some reason been referring to cscope* instead of cscope.out. Let's generate the cscope.out file directly so we don't need to speculate. The "-fcscope.out" (note, no whitespace) argument is enabled by default on my system's cscope 15.9, but let's provide it explicitly for good measure. Signed-off-by: Ævar Arnfjörð Bjarmason --- .gitignore | 2 +- Makefile | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 311841f9bed..d74029c1ca7 100644 --- a/.gitignore +++ b/.gitignore @@ -217,7 +217,7 @@ /.vscode/ /tags /TAGS -/cscope* +/cscope.out /compile_commands.json *.hcc *.obj diff --git a/Makefile b/Makefile index 4dd9711a653..25d2a3e5ddc 100644 --- a/Makefile +++ b/Makefile @@ -2737,10 +2737,11 @@ tags: FORCE $(FIND_SOURCE_FILES) | xargs ctags -a -o tags+ && \ mv tags+ tags +cscope.out: + $(FIND_SOURCE_FILES) | xargs cscope -f$@ -b + .PHONY: cscope -cscope: - $(RM) cscope* - $(FIND_SOURCE_FILES) | xargs cscope -b +cscope: cscope.out ### Detect prefix changes TRACK_PREFIX = $(bindir_SQ):$(gitexecdir_SQ):$(template_dir_SQ):$(prefix_SQ):\ @@ -3211,7 +3212,7 @@ clean: profile-clean coverage-clean cocciclean $(RM) $(HCC) $(RM) -r bin-wrappers $(dep_dirs) $(compdb_dir) compile_commands.json $(RM) -r po/build/ - $(RM) *.pyc *.pyo */*.pyc */*.pyo $(GENERATED_H) $(ETAGS_TARGET) tags cscope* + $(RM) *.pyc *.pyo */*.pyc */*.pyo $(GENERATED_H) $(ETAGS_TARGET) tags cscope.out $(RM) -r .dist-tmp-dir .doc-tmp-dir $(RM) $(GIT_TARNAME).tar.gz $(RM) $(htmldocs).tar.gz $(manpages).tar.gz From patchwork Tue Jun 22 14:21:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12337715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3333C49EA4 for ; Tue, 22 Jun 2021 14:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA5CD61374 for ; Tue, 22 Jun 2021 14:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231445AbhFVOXw (ORCPT ); Tue, 22 Jun 2021 10:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbhFVOXt (ORCPT ); Tue, 22 Jun 2021 10:23:49 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA34EC06175F for ; Tue, 22 Jun 2021 07:21:32 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id a11so23890870wrt.13 for ; Tue, 22 Jun 2021 07:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r2F0mwQWsf2MYZfsd8hVyE7T38UqUbUXq6hLAlWDdYE=; b=IWswlEbBHUweswefjQSGQ6Ek/2DV8dXBL0XJvl23EIsX7R8LK7XUHzUKJjRq/7ePSn YwGy/yHju5HAc42sgRAZdy5438Rf5LFKmrq2WsuwkNE6A1gPi5T0GVS8HM3Lhbg12H5O NZnM2vycGxZVWi+D5AAu2p1QcbaQcCnydRIycD6amue7gdkDtxSVCszd0hfsWg+A5QGt YMpa2/UyGhMmRIhcGoLCVk439F0RbEuWqymjwPyEe5WRt1akbCdv3DG34bk8E2Tr/5hC IOBwnvicOWQuq9FEru/bqBW4HtPaRo2/6eQPFZ6HgsXcXOpOI8dTpQ7TQRuELgg/tTY7 D5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r2F0mwQWsf2MYZfsd8hVyE7T38UqUbUXq6hLAlWDdYE=; b=tZ+u30/Zm0O8IgiQBaB/xYHYRAp0sfagm+NoDGL6omPQ7dQ+SOrqOjY6I0RFoVAg+w USJHo8obgrcMtMWepsoOHkS77Viu74oKx6vGgMUIekbDN3/Hjznf/4GEU+rWaBOxbqVq AZ2vZSP1cG2ted3hUu+ZhVBmzdvHUOuASWNaT2jAkViuoz24S401Stl+b9uFQw94PVPf n+d/Nb48jke7id4TKuvZCKszRT4ovExotfT00pnWVCHssCW0zO+xC7QGS37bxUlqeSJs ZroxSpGo8qKtMGVPcSFVoCCNgzFIU15w8/8sgEIh24CA3xaIaKXVePyKTrCyO43rpC7v a74w== X-Gm-Message-State: AOAM531uxs4XBsK29QlXJRJxKZl22Kz23uwthZ+DAOix3RW5w5fx/VhG ZGhbbtRJJS2KEhMoNoyW99kXmVNhl+LWCQ== X-Google-Smtp-Source: ABdhPJw0ULuN8FDB+O4B4x+BR4MiaTDSfmHig7AOhDyKFq5TRUp8pQI5yQwkDHp5fNOKleAxPyb7JA== X-Received: by 2002:adf:f34c:: with SMTP id e12mr5063967wrp.299.1624371691401; Tue, 22 Jun 2021 07:21:31 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id r4sm22617395wre.84.2021.06.22.07.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 07:21:31 -0700 (PDT) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Denton Liu , Felipe Contreras , Kristof Provost , =?utf-8?b?w4Z2YXIgQXJu?= =?utf-8?b?ZmrDtnLDsCBCamFybWFzb24=?= Subject: [PATCH 3/3] Makefile: don't use "FORCE" for tags targets Date: Tue, 22 Jun 2021 16:21:27 +0200 Message-Id: X-Mailer: git-send-email 2.32.0.599.g3967b4fa4ac In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Remove the "FORCE" dependency from the "tags", "TAGS" and "cscope.out" targets, instead make them depend on whether or not the relevant source files have changed. I'm also removing the "-o" option from them, that seems to have been cargo-culted when they were initially added in f81e7c626f3 (Makefile: Add TAGS and tags targets, 2006-03-18). It would make sense to use that option if we had been appending to tag files, it doesn't make any sense that it was used after we'd just removed the files file being appended to. This will potentially cause a partial file to be left behind if the command dies, but my in-flight series to use the ".DELETE_ON_ERROR" flag in the Makefile[1] will make that problem go away. I think even without that it's not problem we need to worry about in these cases. 1. https://lore.kernel.org/git/patch-1.1-9420448e74f-20210622T141100Z-avarab@gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason --- Makefile | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 25d2a3e5ddc..89d261230fb 100644 --- a/Makefile +++ b/Makefile @@ -2727,18 +2727,19 @@ FIND_SOURCE_FILES = ( \ | sed -e 's|^\./||' \ ) -$(ETAGS_TARGET): FORCE - $(QUIET_GEN)$(RM) "$(ETAGS_TARGET)+" && \ - $(FIND_SOURCE_FILES) | xargs etags -a -o "$(ETAGS_TARGET)+" && \ - mv "$(ETAGS_TARGET)+" "$(ETAGS_TARGET)" +FOUND_SOURCE_FILES = $(shell $(FIND_SOURCE_FILES)) -tags: FORCE - $(QUIET_GEN)$(RM) tags+ && \ - $(FIND_SOURCE_FILES) | xargs ctags -a -o tags+ && \ - mv tags+ tags +$(ETAGS_TARGET): $(FOUND_SOURCE_FILES) + $(QUIET_GEN)echo $(FOUND_SOURCE_FILES) | \ + xargs etags -o $@ + +tags: $(FOUND_SOURCE_FILES) + $(QUIET_GEN)echo $(FOUND_SOURCE_FILES) | \ + xargs ctags -o $@ cscope.out: - $(FIND_SOURCE_FILES) | xargs cscope -f$@ -b + $(QUIET_GEN)echo $(FOUND_SOURCE_FILES) | \ + xargs cscope -f$@ -b .PHONY: cscope cscope: cscope.out @@ -2922,7 +2923,7 @@ check: config-list.h command-list.h exit 1; \ fi -FOUND_C_SOURCES = $(filter %.c,$(shell $(FIND_SOURCE_FILES))) +FOUND_C_SOURCES = $(filter %.c,$(FOUND_SOURCE_FILES)) COCCI_SOURCES = $(filter-out $(THIRD_PARTY_SOURCES),$(FOUND_C_SOURCES)) %.cocci.patch: %.cocci $(COCCI_SOURCES)