From patchwork Tue Jun 29 08:28:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12349519 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965C8C11F66 for ; Tue, 29 Jun 2021 08:31:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC6F661DD1 for ; Tue, 29 Jun 2021 08:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC6F661DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E89BD1683; Tue, 29 Jun 2021 10:30:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E89BD1683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624955494; bh=eWI2YWSYg3pseFcSRjVe3s8vkP7X+JqpXSJ0ezKK+IU=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=MObPkBgxT3uXdn32S3G6/eVxllNjUb+q3SB0YqqdxaWCldncVmmInR8KU+ceaQBRu z5bNmUBKX6cFabjYX6zESq/UeF1MUiHdATWSAoPpCkIUTEDZo1/I1ipT+QU3XuyvBg FeePf7GDjS9qamlzGD3swQGY9DmeJKQJP0ItWaEk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id ABD18F804AE; Tue, 29 Jun 2021 10:29:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1F5DDF802D2; Tue, 29 Jun 2021 10:29:33 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07AE3F80156 for ; Tue, 29 Jun 2021 10:29:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07AE3F80156 Received: from mail-pg1-f197.google.com ([209.85.215.197]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ly97M-0000Ia-Uw for alsa-devel@alsa-project.org; Tue, 29 Jun 2021 08:29:17 +0000 Received: by mail-pg1-f197.google.com with SMTP id o9-20020a6561490000b0290226fc371410so12678701pgv.8 for ; Tue, 29 Jun 2021 01:29:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zT+AAyuwYYGwcA7gJxKF1kV6Ix+q/p+7TtOQey3g0sY=; b=kJyfLxvdm101gSlw7bvW8uICRL/kyV2Ms8pNTA9ONwTEzts8hJC+a8E3zwS8j17zhV M2QgqonhMB5IYqMeAMMQ4pNAnsihNM353utcBnhE8IIY5PvrTP48N/NIfbRqRhkxjfCX 1FbmHxJovSP2X3ePc5yalrNdutjUXBYDTo1nBJ3EGQZV3m/EdrZpvoolr8xd1ctEJlET 4GOAXjugAGa1kCNsXCsEIxNO302R5arzjbTGEKgVLOOHBXsfDWkIF32ftwMHE7w8KcoM e/vQWcQVk6Bc/I94jxJJibITVAHo6Ykmy8iA7KNPzBNRheqicvIbbZpEZsMEsHG10Lp3 EUlQ== X-Gm-Message-State: AOAM530SvO+yCfyY0p0LrxF9A/F+cy3ulzXhxfJ6ZZk8SWm891fi8zG2 pdZ51kBoM/Fnu55DfcqEZFMfJC7vIPW0yedMa97sNJ1Q4JeoOiQ0JyGCHFFEX0f4EkhWKGqK7Nw /BeAdj026/AP7KrapPH/Lrk902NFpyV267fjHdw8+ X-Received: by 2002:a17:90a:6602:: with SMTP id l2mr1096605pjj.103.1624955355717; Tue, 29 Jun 2021 01:29:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYKEDhGe+xAvSsUjWW8jMLc/HpzQELmLPbu/30Sr5x7ckwsp151qQs4Wn4g+L5Rw7f6AYP7A== X-Received: by 2002:a17:90a:6602:: with SMTP id l2mr1096589pjj.103.1624955355485; Tue, 29 Jun 2021 01:29:15 -0700 (PDT) Received: from localhost.localdomain (36-224-198-238.dynamic-ip.hinet.net. [36.224.198.238]) by smtp.gmail.com with ESMTPSA id 28sm17526830pgq.39.2021.06.29.01.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 01:29:14 -0700 (PDT) From: Andy Chi To: Subject: [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Date: Tue, 29 Jun 2021 16:28:57 +0800 Message-Id: <20210629082902.408881-1-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , alsa-devel@alsa-project.org, Jeremy Szu , linux-kernel@vger.kernel.org, Huacai Chen , Takashi Iwai , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 450 G8 using ALC236 codec which using 0x02 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ab5113cccffa..9c3bb1a2b849 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8336,6 +8336,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), From patchwork Tue Jun 29 08:28:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12349521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FE1C11F66 for ; Tue, 29 Jun 2021 08:31:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4F1861DC9 for ; Tue, 29 Jun 2021 08:31:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4F1861DC9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 15BB11690; Tue, 29 Jun 2021 10:30:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 15BB11690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624955502; bh=ZJFOz+DMEBEpfzL1W1rZhT7DbBAy/bn2830yHy2z6dE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WBtbdlyreQfKXr6sLLdzdL/Vv/G1tBtCeesbg9uoxYJp2R5QqyPKmhQf0Ls15+4IJ wZbscRlMeDE4WdXmhq1HRfJP9dFy69pXHRqjen0uhLfkRIvG+VYULrmKiHfiLv84hF vE3o7VZiJqVLhhLSe+RuNy3Z1lfX55BSKV9Ds0Ck= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A852DF804B0; Tue, 29 Jun 2021 10:30:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 23CBEF804D6; Tue, 29 Jun 2021 10:30:05 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EF446F800EE for ; Tue, 29 Jun 2021 10:29:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EF446F800EE Received: from mail-pg1-f200.google.com ([209.85.215.200]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ly97R-0000Jo-Vl for alsa-devel@alsa-project.org; Tue, 29 Jun 2021 08:29:22 +0000 Received: by mail-pg1-f200.google.com with SMTP id p2-20020a63e6420000b02902271082c631so10846206pgj.5 for ; Tue, 29 Jun 2021 01:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N9fgFCKAEnFNvPWv2zgFK0h9Wc7b+MXEQqnNhBWeWpg=; b=aR7f5y6JKEViUnNo+5TQizFVaCYnvZFlQcuUKjFGp4n0exO61wDdk4zkTKg2aMHGMh qbVAmzNEH2YttRTKUehoxwzcQCwTdTYk4WXgjwglXdEtLrPIQVjubinJw5D1eMQenTpM Jq+cEWUgAJybF3s4NUZdXEKXrN7CvgOwNzLU2BDVfaJTfGoePxD+Gj9wcO/2T0ZPx1Sy T7HjYqQ5rsuIbpTEoKePqxJlccZrHTVImpK5POgsyr8Za3tBD7i/b4j8L7oOOlQBN79d HZlCZip8ZUqiWOvO2dwZbJUQ/t6IknkVsbFnqCphGTrNHJ+JvRCtjoB0n8JoHOGLoQDD P7tQ== X-Gm-Message-State: AOAM532rK+oba4J61bD4Awik+jEm1zx+rln+e++uxQ58F9IUhZSVlEie 2CUl4UJopjsjY70tXsw/m0qHWoBFd2jYiIizXFoPk5aeTStN2n6YfDbPko5BQz6xvfNdh835DaY W4ikdV8hvgpW7TZa1mnD4xpSrUjVaKMXTd1TVC8Ka X-Received: by 2002:a17:90a:5885:: with SMTP id j5mr33035762pji.89.1624955360773; Tue, 29 Jun 2021 01:29:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzszoUHT7VwstDKZhSSaQyW593EDxYrzS5Vzev/O5do4/MJXnQWrHt25Un4IUdkUWjsxRoDw== X-Received: by 2002:a17:90a:5885:: with SMTP id j5mr33035735pji.89.1624955360549; Tue, 29 Jun 2021 01:29:20 -0700 (PDT) Received: from localhost.localdomain (36-224-198-238.dynamic-ip.hinet.net. [36.224.198.238]) by smtp.gmail.com with ESMTPSA id 28sm17526830pgq.39.2021.06.29.01.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 01:29:20 -0700 (PDT) From: Andy Chi To: Subject: [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 Date: Tue, 29 Jun 2021 16:28:58 +0800 Message-Id: <20210629082902.408881-2-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210629082902.408881-1-andy.chi@canonical.com> References: <20210629082902.408881-1-andy.chi@canonical.com> MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , alsa-devel@alsa-project.org, Jeremy Szu , linux-kernel@vger.kernel.org, Huacai Chen , Takashi Iwai , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 445 G8 using ALC236 codec. COEF index 0x34 bit 5 is used to control the playback mute LED, but the microphone mute LED is controlled using pin VREF instead of a COEF index. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 9c3bb1a2b849..25a32b718fbc 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8344,6 +8344,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), From patchwork Tue Jun 29 08:28:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12349517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA08C11F66 for ; Tue, 29 Jun 2021 08:30:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE1F161DD1 for ; Tue, 29 Jun 2021 08:30:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE1F161DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 49BEB167A; Tue, 29 Jun 2021 10:29:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 49BEB167A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624955443; bh=YHzWIa69ElM68S511DfZwwMO3O+q84es27oKk79zhyY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ItIzlpTajvn8wDhGr8QHqzokl/W9+eEG19BV3Updy6/ouXoxWHEGgcGtWUg0h+p4V qjdQhRllJZCftLBdUCWwEtrrC7inEC6GG/C3xu5/9J+r/337g4Zd2u3QtEHNOcoBn+ C3ES8l3xwhAmt+qM+TncGLdDxHi24wRANFEhqnjs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 17A00F80156; Tue, 29 Jun 2021 10:29:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56BEDF8025D; Tue, 29 Jun 2021 10:29:39 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DE51BF80240 for ; Tue, 29 Jun 2021 10:29:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DE51BF80240 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ly97W-0000L4-TY for alsa-devel@alsa-project.org; Tue, 29 Jun 2021 08:29:27 +0000 Received: by mail-pg1-f199.google.com with SMTP id p14-20020a63fe0e0000b0290223af1026abso13689392pgh.20 for ; Tue, 29 Jun 2021 01:29:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=toSlKwLIoJaylZ3jHBQTTvJkInZwz79Yfvkqkzo/W98=; b=sLasDBVWOaU2AwTN753wKpRuhTj4hYpVyvUvlLNNHtCXCl7gV5hLwD4J0fyLza3SOt 4VL5AoXGf/Bu0YcZstygUM0Jyfh7pau1z938xUHjcRrHov3a68MwFNuQwWFSk2rB9Yfe dYf8cSWx8lmn9a3xqVoQokXBXJWXfIXOgGw3fLe6VF9O1qoFW/LDLMWdmTP1QRwSRheo 4zwyXfVWj+N1X4TE4waOd3BgiZ0XPEPGDAUIdY8knHrJ5XPnBq6FbLgv06kM4X0Jy6AX 2K0ckG05fiXLhtwxQhQ4mopsAOr1DgZRIckB3LC4bBcnna+HASLCRGepD7JQMQwcdea8 x3dg== X-Gm-Message-State: AOAM531OlsAdkue1AKC+Id3GTtkU8n0ZKcZTwWfbK8A19XzGRjBOMU/d eZ11azx9KM7E2bOoxiJZUdKgJKqxhptFQW+k6Z1ICIBUWsbl8639Bm+kuH13u89sXahOM4gBI+G OSJnmIZBkBKfsgIrMN50MyxdHdzqPKiK47dH0PdRS X-Received: by 2002:a17:902:7446:b029:128:ec77:b41e with SMTP id e6-20020a1709027446b0290128ec77b41emr5395336plt.80.1624955365642; Tue, 29 Jun 2021 01:29:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3rJTpLAVpOugSkqbdGzg37BM1HfA5uvI4BBZMTPky38pJlKqaSYVeohwYjsgN0PugSolhoQ== X-Received: by 2002:a17:902:7446:b029:128:ec77:b41e with SMTP id e6-20020a1709027446b0290128ec77b41emr5395324plt.80.1624955365446; Tue, 29 Jun 2021 01:29:25 -0700 (PDT) Received: from localhost.localdomain (36-224-198-238.dynamic-ip.hinet.net. [36.224.198.238]) by smtp.gmail.com with ESMTPSA id 28sm17526830pgq.39.2021.06.29.01.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 01:29:25 -0700 (PDT) From: Andy Chi To: Subject: [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 Date: Tue, 29 Jun 2021 16:28:59 +0800 Message-Id: <20210629082902.408881-3-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210629082902.408881-1-andy.chi@canonical.com> References: <20210629082902.408881-1-andy.chi@canonical.com> MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , alsa-devel@alsa-project.org, Jeremy Szu , linux-kernel@vger.kernel.org, Huacai Chen , Takashi Iwai , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 630 G8 using ALC236 codec which using 0x02 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 25a32b718fbc..58e185c6e77f 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8337,6 +8337,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),