From patchwork Thu Jul 1 09:14:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12353759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60414C11F64 for ; Thu, 1 Jul 2021 09:15:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB03661480 for ; Thu, 1 Jul 2021 09:15:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB03661480 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B508D1690; Thu, 1 Jul 2021 11:14:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B508D1690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625130940; bh=lrxWBpJfBtJYLptobOR8icGi57hOtUP5jmu59iAnpkg=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=pGW09ciApSqGvGADdP/uywtWCPdj0ezQSJhTsfw3sgDmg3ukpnHV4lakQEsJY3hZ6 pCYLZysAkF+f23NMMK3zkCCMdapSuyaPP8qK3SP90pVf7Z4ULOcrD/fO9ledc2RpYA dkzGfMYuqvOUZ3QRX5Fq86qApBoC/7JrAB+c7t3E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3416BF802D2; Thu, 1 Jul 2021 11:14:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A42D3F804AE; Thu, 1 Jul 2021 11:14:47 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4F9C2F800E3 for ; Thu, 1 Jul 2021 11:14:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4F9C2F800E3 Received: from mail-pg1-f198.google.com ([209.85.215.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lysmK-00074F-6o for alsa-devel@alsa-project.org; Thu, 01 Jul 2021 09:14:36 +0000 Received: by mail-pg1-f198.google.com with SMTP id l124-20020a633e820000b02902283854c3ccso798144pga.15 for ; Thu, 01 Jul 2021 02:14:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xPTN30ZO1AZ2z4aTyWnCz44BtVf74Dz6y2exPPRRYvk=; b=S4wueo6LV/Wo0ADl1T5eVuImLUP+ndKQTAKNZKr9C8P0qS/RPvA5dsBdpXQ5TUWuAa csbX3vH+FDx6Njkcyi/Hp2mtDetrBl6XIymXYXdvh6JgTqDr9G4JNp4yCfI2rWT93B0a dGQE8qK16bviZ2vnuQwevFDhjBWSMTP+6St4ZNBSrL66fYF3oz7IBYNyl2DCQOWQ+AjR d5/3YWeZHNFrbDuIUub/jiRKzuuyBs70QpVEa4dFEWF/BE+q/qkVYGvEujKEyNL0+DcU KdZ5PXKqXH2JO6g90csPZhE8+qgljVX77ESUPyKi8REp42pM5roUlsjy0xr9l7+MEvf9 tW8A== X-Gm-Message-State: AOAM532vt0X5DelyJKF+6mwF3N0UXu6ExvkgnljEJpRbQLXa3PyPzhXV 1ISVyEWMNlzWlt1rE6RgWED+cw67kJ1SM7O9hAJueRex0INhSkNHkhM/TWudxHJbRgIMT6Cb+m6 0qK4a4+iHU/gWogMrR46n2jjHLikMadKeGBulbA7y X-Received: by 2002:a17:902:760c:b029:129:2dde:f8c9 with SMTP id k12-20020a170902760cb02901292ddef8c9mr3176918pll.41.1625130874934; Thu, 01 Jul 2021 02:14:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDXGfAk5uAuYrbBFUdY4xpCYOLzlyf1KZ2iTm/g8dW8upHdP5SCvvii2IzXt3bTlRvzhG33A== X-Received: by 2002:a17:902:760c:b029:129:2dde:f8c9 with SMTP id k12-20020a170902760cb02901292ddef8c9mr3176876pll.41.1625130874499; Thu, 01 Jul 2021 02:14:34 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id c14sm18133190pfj.205.2021.07.01.02.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 02:14:34 -0700 (PDT) From: Andy Chi To: Subject: [PATCH v2 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Date: Thu, 1 Jul 2021 17:14:13 +0800 Message-Id: <20210701091417.9696-1-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , "moderated list:SOUND" , Jeremy Szu , open list , Huacai Chen , Takashi Iwai , Werner Sembach , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 450 G8 using ALC236 codec which using 0x02 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 308a58a83f33..6c423172a1f4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8363,6 +8363,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), From patchwork Thu Jul 1 09:14:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12353761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BB1C11F64 for ; Thu, 1 Jul 2021 09:16:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F0A61480 for ; Thu, 1 Jul 2021 09:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F0A61480 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CD685169C; Thu, 1 Jul 2021 11:15:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CD685169C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625130991; bh=10ApzUPZT2iN0jFAY6VgW1BlkffTX5+pDPxLSa8vqdo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vEaKHie0OoMlmo87hDuLfbmg4eXFH9Dd9FxOMLW5e11V7ya4oIiXCwJTV9X/noUaR LVseVjIdOPtjF6zwa9FvLIQV11xzuJDJeIVwwlZb1BdwiKxOGDVA8QJj6WvZv0i4Wu 7/44dGdXc/WHksd94FwNRMbllyDTUuQCCz5V3JVQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 52667F804B4; Thu, 1 Jul 2021 11:14:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6312F802D2; Thu, 1 Jul 2021 11:14:49 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9005BF8025D for ; Thu, 1 Jul 2021 11:14:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9005BF8025D Received: from mail-pg1-f198.google.com ([209.85.215.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lysmQ-00075P-SO for alsa-devel@alsa-project.org; Thu, 01 Jul 2021 09:14:43 +0000 Received: by mail-pg1-f198.google.com with SMTP id 1-20020a6317410000b0290228062f22a0so3699105pgx.22 for ; Thu, 01 Jul 2021 02:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q9/fqvpbjKgQMRg7iZrW6B8O8Uu9VdWOniL08X6W/aU=; b=iVGfnelAnPUAnU+8sT04Ni/xNSi4zZLEhqpPKHYo1L3+e01ERu9DE/eJ8vm2ROfFh9 7pL3riUUZ0ovkDsxe017SYLMtgatrSDPWInOQbcbOTuCmB7uXR6yzmsTqbduZIU8VAP7 HmvukqGTl5GteOja8u5PcuagmSD7bSPEYiOdxnOCyZuI15f9J4fTwk/zcWIaL2+aQmNq YVm8wmCdmA1bDLh/gSHzRwAVRwCUEvfsoRzLT00g5+le/fyXKeHaOYOocMBpDXd9L63p al+VoUU8BO7MI9ZrwYzPzXh8aV6Slzlk3OIej87H/deiUerVeEA1XI0oNO8xiz9s7GUo Rhcg== X-Gm-Message-State: AOAM530aPWjglE9IyUGQ7Ta0t+X0XCk1vx7jd7VBizaW1sFWq1GUgsqZ npxH+A26vpwiSJFvLRaKdUw+ENeR9JCsya07S5oLlCXcFlrJZXqwNDtPr34qfyy/d9DV24cR9mm gNP/xB2jHbyavoXMM6i/XaVrLFd/lXrrCb7DJVYac X-Received: by 2002:a62:6447:0:b029:30d:4bba:8b5a with SMTP id y68-20020a6264470000b029030d4bba8b5amr17894357pfb.71.1625130881480; Thu, 01 Jul 2021 02:14:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJasFPj16Ov0bOfkITpp0DDnYHeL11ZbT+TguiSAiGd55GdvBTgzRgX2sTPujm8vg8dEQ4tA== X-Received: by 2002:a62:6447:0:b029:30d:4bba:8b5a with SMTP id y68-20020a6264470000b029030d4bba8b5amr17894332pfb.71.1625130881287; Thu, 01 Jul 2021 02:14:41 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id c14sm18133190pfj.205.2021.07.01.02.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 02:14:40 -0700 (PDT) From: Andy Chi To: Subject: [PATCH v2 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 Date: Thu, 1 Jul 2021 17:14:14 +0800 Message-Id: <20210701091417.9696-2-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701091417.9696-1-andy.chi@canonical.com> References: <20210701091417.9696-1-andy.chi@canonical.com> MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , "moderated list:SOUND" , Jeremy Szu , open list , Huacai Chen , Takashi Iwai , Werner Sembach , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 445 G8 using ALC236 codec. COEF index 0x34 bit 5 is used to control the playback mute LED, but the microphone mute LED is controlled using pin VREF instead of a COEF index. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6c423172a1f4..949c8e5ac54a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8372,6 +8372,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), From patchwork Thu Jul 1 09:14:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Chi X-Patchwork-Id: 12353763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76217C11F64 for ; Thu, 1 Jul 2021 09:16:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1FAC6146B for ; Thu, 1 Jul 2021 09:16:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1FAC6146B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4D4C11693; Thu, 1 Jul 2021 11:15:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4D4C11693 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625130996; bh=gKU3IVwYlUpQUqnAmSJfLf9ACVX13XLuFM5RjPHQu5c=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LIayaa8WqjfHmeN05EpZn74wJ0x8P1JafoH/S5MGA5qdn1YXuD+PSyCcBTTiSXuCO QydQp8lsN6pDdZhhUr/Z4Q5Y4FicpWLioMe5smpPWxU5XsHhFOdTCRgcCVf8CXJmQ9 ljGmtPhTaUDPQzweO9gIwBdLGrRS60ayJpAeW5k8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 07746F804D1; Thu, 1 Jul 2021 11:14:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2735AF804CA; Thu, 1 Jul 2021 11:14:51 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C1438F800E3 for ; Thu, 1 Jul 2021 11:14:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C1438F800E3 Received: from mail-pj1-f69.google.com ([209.85.216.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lysmV-00076O-Ul for alsa-devel@alsa-project.org; Thu, 01 Jul 2021 09:14:48 +0000 Received: by mail-pj1-f69.google.com with SMTP id 16-20020a17090a19d0b029016fc64ff1a2so3025308pjj.1 for ; Thu, 01 Jul 2021 02:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=thOYF/kB9x653HZTqKgDY2UQjnQQ7jDfvkUX/K+iT50=; b=rSqJtG9fK+/rPsXDADgwQJqLudPht86KVFmCA8RF/6+KsgVhERk420K+yORzbKmSM2 fXC61qOrU6IljwlXO9C1N6j5Lgh4NBpXkwUWUvvykblGDJWy6OauF+J+waJZdYWtL3bP 0eneetet8ko+HfxqMa3Vhrz+RkvQQ4CbfCPH8Mt6WqyWPsgrxrXMZ7Ba4tmHHjKEQ17T sRjBVz9YXW1Ze5ZqX8tanmMnqQ6eJVr/BAxSfQz9SAjeKen5xb3fVrQNN1x2uDNUsYHT fJaZ/eqaeX7rkBEDevmT6/EeXvOW3WdP66/gKOtpKVQp1ivuEzsD9Dn0RRcwJTS2tCsl u1yw== X-Gm-Message-State: AOAM5335AIyUzc0HJl+DqLQO6Kw//y7JH289BWzIdwmqm7seECWPqmbX eegSOcml9tk1ckVzMXlKJpXqg6Adc0FLxE1aYps+Kz2j3f/Jii5BLSXEZhroMWECRMjI8Oosp6v OrRXisdw90lhZSTvNuUjILxB5FD+SziLtGTDlvUfz X-Received: by 2002:a62:aa18:0:b029:312:28be:4783 with SMTP id e24-20020a62aa180000b029031228be4783mr2887261pff.28.1625130886695; Thu, 01 Jul 2021 02:14:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ3TmTny8WhyKTbAgqeIgvERKNfRFu0t0IJKVmV1iqpjj5R9HueAgkvwx/RI4KMUANW2BVZg== X-Received: by 2002:a62:aa18:0:b029:312:28be:4783 with SMTP id e24-20020a62aa180000b029031228be4783mr2887232pff.28.1625130886498; Thu, 01 Jul 2021 02:14:46 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id c14sm18133190pfj.205.2021.07.01.02.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 02:14:46 -0700 (PDT) From: Andy Chi To: Subject: [PATCH v2 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 Date: Thu, 1 Jul 2021 17:14:15 +0800 Message-Id: <20210701091417.9696-3-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701091417.9696-1-andy.chi@canonical.com> References: <20210701091417.9696-1-andy.chi@canonical.com> MIME-Version: 1.0 Cc: Chris Chiu , Jian-Hong Pan , Kailang Yang , "moderated list:SOUND" , Jeremy Szu , open list , Huacai Chen , Takashi Iwai , Werner Sembach , Hui Wang , andy.chi@canonical.com, Sami Loone X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The HP ProBook 630 G8 using ALC236 codec which using 0x02 to control mute LED and 0x01 to control micmute LED. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 949c8e5ac54a..79e066b39f5e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8364,6 +8364,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),