From patchwork Wed Jul 7 09:40:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12362279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B3D3C07E95 for ; Wed, 7 Jul 2021 09:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17F4961C82 for ; Wed, 7 Jul 2021 09:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbhGGJoK (ORCPT ); Wed, 7 Jul 2021 05:44:10 -0400 Received: from mail-am6eur05on2065.outbound.protection.outlook.com ([40.107.22.65]:39360 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230429AbhGGJoK (ORCPT ); Wed, 7 Jul 2021 05:44:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BoJrQ6FE8KDaR3Jyge9c51Tr0EqiCwZM0PSxn1jMusiIEV+QTKHGp4ThMQeg6g7og7BYgoEAjHkCss6uIu3dqbzWjOj3hFqUHUIL5EkhGong8hQiJLhX4GPsVslDIc5OUnuEN0UkeaSXw+CLwueb7KJ5i8K0Z+VZIQmfUI20loWwyMraPHmzV2nRLx7JBJ5NUiG4vjdQpRduxfkZ3K6S1axILSd4Vdim+WtQZQ5FEmTIP/SNNMTsyvl5IWX3hsWRgL+W5/XqbjMKgynJuMiLhCq3aMhsisCZqI2igMJjcdcSJ8y1ktUr36wRTGk8hm66kGndJm5Syw7Y241FamlJyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKsbWyfe07PseCqnlASYSgLMBrjN+fKjPpDfJ2JrCSc=; b=JW8rgsZPyE8A2lFzsJp3uCwhsAhK5su++dZwiYrBTM8JjAPynT5i+A9ou93m62V1jUNqnTmtayCkdFU7wGx2Bn/n3LaGkXht8XOABREVIOaHG5ZKrSjwsXoklMgLE0YM5U9jWpy0mcrO8OMgvis+wJO1SprEfqS2bekztetQJWw8jG4MIU9b7piL9S8lfAwoDh10s0BKzsArT4VJmtsKT8whBVzrm29VoitpfK47pgOzmREbvyIjWCpAMwwfGc2trzsccOzwBM4A3ns3TEyiFpzrjCtD3BilrT/OUbGIH5tX86wOLXLvUM6VFB0FFT9/KCJnWNgB7KwG/BWJ/bM+4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKsbWyfe07PseCqnlASYSgLMBrjN+fKjPpDfJ2JrCSc=; b=l0t62PBviupkUOCZITq6TAGK1Z2gCsfWYjcjluGJqtn+hM96illfymbjl42I3QCOSVuDRKDF3Uc39VsYNVHtyyET0MTBzdGHv0QYVtH652ViKdRHLknwCefDwSCao1l+8AclWO82fEK9ZUy+l+qaJl9CkJ1sfbJ5672vxMHS4WI= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 7 Jul 2021 09:41:28 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 09:41:28 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Dong Aisheng , Peng Fan Subject: [PATCH V2 1/5] remoteproc: fix the wrong default value of is_iomem Date: Wed, 7 Jul 2021 17:40:29 +0800 Message-Id: <20210707094033.1959752-1-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Wed, 7 Jul 2021 09:41:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc235263-4229-407a-6666-08d9412b64e5 X-MS-TrafficTypeDiagnostic: DU2PR04MB8824: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a7+jf2P3NQ0pdNOSW0e115pxpNihia1haT80Z7EFcPUq9FzMqhHdPRG/deN8ay0v//vDL2NmltYgMiMPQzzDq2CsefCQHWU6MhUXHrQ9uJ4TyshBsgl3EkqPZgoguqWJ/ncWeHLLXehKPEjb4AnBmBbaZOZlc15lurCic4t8aj/n2RCtnaaZ+UIj1TBx/yucWW6TnmkV7WpodcD29CCeMLwPaFYNUeX6nS8Mrr/P8iM0TECTKv4u0JVZb78CWxj/PQSbGD2MkZlkW+Wd6d1yzIP4ut74N1rdmP3ZnuRRsfhvM+YASrsxv8IlHI/EMgWNBZplMmuFMBYBf6ELYWOnbHAwJuE8QqzhkN/z9cROUxLNMkoOlSOfPG5rF6A1CgSEidFsrueZYFdv4mAbCrDoQFm8VI3uDsWhxMV2hFxi9a6IYTrj47kx4SrM2pg+ERR1Pr1c5ZE7Gld7y/4825XObS9L+8OBmPGJKG0lsuENiM6BHcJ6eMknTePgCCPiiES250g70IoM+LtrXx864JfiEXvZMR9zFEbFQGcweh5cVgrB0fKrqTDSRPL2ZuWK53lqJS4bHQHwvVtIC+ttM2E0ztCnBhVy7AfY2rb8yCgVcH1CHhXgxCoYYtIOhY60IPehPdcQ2Mq5XI5hq8L0UeabRMhX0Xd6QjMMrWwVnmvunj/0zD7a5igga5f7qC+rcCoqJqvGMFo2/86Pg4DgfK6ieg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(5660300002)(316002)(66556008)(186003)(66476007)(8936002)(66946007)(36756003)(54906003)(6506007)(478600001)(86362001)(4326008)(83380400001)(2616005)(52116002)(26005)(6916009)(38100700002)(2906002)(38350700002)(1076003)(6486002)(8676002)(956004)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lJ/juckwM7NSWXTAhdvSOADklEsyKcsT4wc2Rsl0B0e/EUgEPqFyQHX95DML6skX5U0lyK/cOlvE/NOM2P2U9eQx/R5GhXTt4Yqh5VPrFh6KUYkSEx1nZxcRMhFalcimt4C2tTdGgLPiEpp1zENQWIknGG5CCsxpDi26gNjChN2dB0wxO3adKB5dOIsKDUAYsPrpXKB+VAejxzuEaxS1Ck/0AmfNFpHlXJqBFfvpgk1uZB5AYUsLVhcgu5ezjihP+VrQxP/ui/pmlTTCY9Y12adYHL/1HdVaeYZE0sJ6yqRNuGbN+Y2DRFCZuNKnfExPiQjMRnZnWU2UmG/UWWINFrho83JdXPI3s7c87+ZZxx+bGDOAu53s524dXGi3who5e1SAjzGkM5twNukgXvuaNf0zu8TCxueNl+WO4s7WwvyYfoF0yiN/sTBupqHaAqLl6HC4t/JVRgXJ6Fk39tfFpOX1pIKsNlbcSpdb9DJq52b+lprw2XKAhhXZS+5udRB2gerYGJ5jZlLECLqC8CyCSeb4sQx0u7kKDUGdpBPaKKO7aC+SKC7M41MPrk9EDaPMi9IDN1V/oRhiJiuYaR4KfFrzdFcl1JX0y+Qkv7xp05yrEieZZzFOn5dpsip6wwn7+DU4aNw3X0YusrJvCXmG3F1HzFgPj7eiT7T5s0I80Bgbj/AqLUSPsNErxDBIRjYcwoTfhdcMiW75QV2tpUvOd+tOInjL75Iun9EZRxNpFy4CB8eS1FCGbLfWyFX4gk1HR5ygkiqsqGUcwfGoycg3rWOLv3bUYxNry3mlnxl8tEZavMpSbnBRhh/HK4vd9Q2CoaJ5komlv64bgXF5W8ooJQcts6hPHLm8vf5Hm5glGAFTzptuUZ+mUU/0LuTcEujMrraLV7SgVQw82LPjHnJRghgFb9/iRdsLpqOSNeQA6kgcOy+BiGrZjqImxfyx/2kh2eULDTTM7/pVgb9vrsnKZlCKXgbDwT+GwcDU5dQtiQ32TBChzo7jJn0uhLHlYODwXkYuD6WJdnhxQlJ2R+uu6uB0S/GljxUVz6YN6xGh0S4dGNYkkoqpYvmg2sKPjT3cBw3VtMw5l/Ed8OsaOaC3c1C+d3wBM6q+KxhYVpBwSh/gBmQpg1YBcrVZ9hCsy/owV/m83q1lPyOdLNgsuPoP5R0gQB4LV64ZvOZKyWAVZkPhWlGXUCLBH8sVokYKomSWC0hcDaHGhDbunTgnMyLm3iA+n1wG+h7dDfJoDc4vIkavkxlmVQgh/e3RaUMl7DZej92vzR2pW2ZGtc11z41rng4f+fgMJW/bkhHQtTC/+VLu+NneMKMRH3OazM4Sgm2k X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc235263-4229-407a-6666-08d9412b64e5 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 09:41:28.5613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7EKlvcsZWS8bDDse4Sd8bYB7oDTP/ERBF7HMciB76OHt1Qxhh2O9TGU+5GFPziO9KL1lj1Z6QF38qlliE0kyBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Currently the is_iomem is a random value in the stack which may be default to true even on those platforms that not use iomem to store firmware. Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Peng Fan Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va") Signed-off-by: Dong Aisheng Reviewed-by: Peng Fan --- v1->v2: * update rproc_copy_segment as well --- drivers/remoteproc/remoteproc_coredump.c | 2 +- drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c index aee657cc08c6..c892f433a323 100644 --- a/drivers/remoteproc/remoteproc_coredump.c +++ b/drivers/remoteproc/remoteproc_coredump.c @@ -152,8 +152,8 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest, struct rproc_dump_segment *segment, size_t offset, size_t size) { + bool is_iomem = false; void *ptr; - bool is_iomem; if (segment->dump) { segment->dump(rproc, segment, dest, offset, size); diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c index e8078efb3dec..3cd1798f17a3 100644 --- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c @@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) u64 filesz = elf_phdr_get_p_filesz(class, phdr); u64 offset = elf_phdr_get_p_offset(class, phdr); u32 type = elf_phdr_get_p_type(class, phdr); + bool is_iomem = false; void *ptr; - bool is_iomem; if (type != PT_LOAD) continue; From patchwork Wed Jul 7 09:40:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12362281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A20AC07E95 for ; Wed, 7 Jul 2021 09:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E03EB61C7C for ; Wed, 7 Jul 2021 09:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbhGGJoN (ORCPT ); Wed, 7 Jul 2021 05:44:13 -0400 Received: from mail-am6eur05on2078.outbound.protection.outlook.com ([40.107.22.78]:29792 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230429AbhGGJoN (ORCPT ); Wed, 7 Jul 2021 05:44:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MD+2mWxl8svukDVtrXu9pcayVE5mCHPlUgqOLLuNZj7UtfhCIrMabwe5NBvr4ECG5YrLL8W2Rxfe7YPHT8O/5Ki2YeHtg407v8YZcHlg4zzI8TSlBBzQxEWr/B++SIuC7PqZV1341hFLsRFfnf/23V6f0umrENDFaAtyaQm6VdaA/fpuh1rdaZJMXe5nWzsPqkG0JZf5Q2qRvhp/qSurAsvquO+Q/I3bEiz/xPZEGumeTkls78b0Q8fh2Nxs64kB2rE1pNn2TLVbdEJTGr8yhBXJOhmMdB2Dxrs1d0ZFZpkDzu0NuWNiMiPYfJVv+zghQjzWBq/y+ztAXCwgRs9clg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWQDcF5O+cEIYybOy1SEcSLOpdhIOMyGfjGsYKhZrBU=; b=K8CAPPmqbKnFZJQYIB4UcwQ2MWWvjRPbFxg/BarrDMqOzHYIPGNQdrvOXMTFcqmThNW3S/0la3pUyqDs4iyGxP005xQdy5I1znK9uw/wPHPAiKia4WwR34sSgS/9rx1o/0TBumPY0ZgupH07Z7A7j6EK6lVX+8xu6Vz7hzbvCet2tybiuTWa7+6AxspiOdeGZCCQLndkH4Lxdvz7VgrLpsvU7jeJsrl52aqdij6cm2ZGCt2N8UvB/IVBHGO0bRRDFE48SN7XYAT+1capU7+mgF/xrLAPHAL4HIBlpZoULczSet3mICgxVutDtdUfPDLPXHwmKHb9je/DgnZhPNJeog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWQDcF5O+cEIYybOy1SEcSLOpdhIOMyGfjGsYKhZrBU=; b=pNPmCsLg/u5QEQN6/jVpI2WoPkts78KQWcq1GVRUkMAFLJrtgXCWpwHKGSKhbjG+4g0T0dB9jvl1j+1w8dkcIMvDeU1yyYE8A1bTqFxoBI1uEPrpUokO8tOTQ4gTK34fTLxcThGqvzFQUShYoAKoOxqgeYQyR7WiA7A7OaK2vzA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 7 Jul 2021 09:41:31 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 09:41:31 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Dong Aisheng , Peng Fan Subject: [PATCH V2 2/5] remoteproc: imx_rproc: fix TCM io memory type Date: Wed, 7 Jul 2021 17:40:30 +0800 Message-Id: <20210707094033.1959752-2-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094033.1959752-1-aisheng.dong@nxp.com> References: <20210707094033.1959752-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Wed, 7 Jul 2021 09:41:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbd5a01b-b21f-46db-c7a1-08d9412b66be X-MS-TrafficTypeDiagnostic: DU2PR04MB8824: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:469; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jNVIUWyXf+bTGyGupsq/JoLjWgJ00fImBxGTI7KVCERKl3jLCCyiwWm1Gpoyl+oSURLoskO3dGCwv8h1zUMSzTZsPZLJxLeqHaN/L4YtIwMZw3qT8sGJMQt0ieRAHwyYcHWkpYhaQSWAij19d/4Q92DYlWUkVJqzq+/DXRE+MktCzlD07+Qf+GOKuBuK8+OOcCCKLaUFDNhu0Dw+8BQz10WKfEPXWPs3tNgl8pvcKgOLc39SsnIWlZFagChW806kkqLxSKa92P/qhAcvoj9JrHM+xnlNLBnxGXxwIHJnlKTD9DW8Cbnf38yYsGb6Jrz3jwrPK15Gw4JBHDB3GhVn6NhFWupGDdWVnztxWomgbrDnecZlZoiuX0DCuE3Omh5PpVzQ+HgYL+h/gF4FZVUcC0j6pBadDn5obHaPgsxWmr6SXwnjj3e3LUDm7zqApdctRmr1RKVzRoAWBjAVutX1hBhXjt+BJMHe9MTX2Nm73dB1iKFSHwzCKRW18hhP3XN+G5qphx+DKg+a8R4+OtZinYPZxsTzb4oV7JuOUWjTLZdC6xLtMo+LZ1Gif7MR7wfeI3P+MllyxS9H+5v+1QDTtL8b3ur7V61oSdCa6P/I9IjDwsqH68111Bw6ZPITzHI5UU1x5l2PQeZvhIaiOvxYKrmMMbYG+qeooGJPMU0T4PukcfSNrKRYIwbk4EDZ17YP56QvJoosmkYyp19lrdhu5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(5660300002)(316002)(66556008)(186003)(66476007)(8936002)(66946007)(6666004)(36756003)(54906003)(6506007)(478600001)(86362001)(4326008)(83380400001)(2616005)(52116002)(26005)(6916009)(38100700002)(2906002)(38350700002)(1076003)(6486002)(8676002)(956004)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fA+/Yy2fWx4RIzGLthhHZJiKVcw2D6mSt6krM6KnRBp7t+FLTiouTF65uI3PdChpTQBgiq1ngYuDZ0nMsCBzafwrtkrDFRTHDTmJqntD/YccJeQvkxQirn2TnNPMl1kMdIjz/CkohL6rSWZGWHW25j3oI0+LRN8Ckti4xSCNc5DjJe9JH7h87aQXbuxGKCoTx+6ivbxpX06dGvkEj84xg8zCoCGGCktSH96VTk+4UevKcwk5dCQgJrZU81WvZoAtxnY8+X1VJzUWudvDiv/iHJtJ02DX0atf7EXFW4K0YCPgxFMWkFxjuFi/wPWZtLyfsQ0NvSYKJOw3ZS+NMTB46uu/v4cFDZaGkwD50G6xbMFMDE5lXFmgI+Q80E7Lulut8iRTxKsFZEfhp6p83uXriGj5HDDLfrzsD9q6qDUMK5ki30ZkPAy8Oup1vKd35guaPJLVg/ODniYapir1h5CyfbdCIpRQeSH4olLpfCJOw+J2QF8YxSIZuyQs0VuY1nw/tTQixZicH/zcZnxRO0WbA+wsaqcqamxAMrmaTW2rU2DC1n5cW+Oqa7NbBcYFSTFjSq4vYtz3TH07kEO8FdVR1L98LHt4yBa7fd/9KLxSho/6BPGfP6lqDGuZxeW125Z0OdcBLq52ToY3kO+0Q94/jW983W8HZy6pjI8hSns+rhDqetOZtaaPFa/AMoWbsBq53W/t144UahgbumHtKhPAD6Ip0jOJMw5X9YyN4SE0uhmgFaotfrDeqL0xBg0lJIBT0Njgh7mj7e6OcszLj/Wyb8ugIoYHB8hqAeNL9Yg8Ol6MGrDIur8O3yPvH2iC9KShYQaPuQqmqw4ZuRWzjJt665lCmAJUYwdEq006VHsFrpkZFep3DuTMx2sy2ZuBiPXPQULaxmXYBJm/BCCmN6P4Lv1Nd0Ze4gbuR6utNj66/cg7woybeFJXJdTijO2KbfdgL1TQR3kU8yM/uKDUZeiHc09xJrJ7K2CdXXpN77yXS4LxuTca7jQrTP+uEHRwaKzTncc6241eZL94WNbVaacjmk5/WmOVq7FycDGFQy8vwYIoyU0BgB2XnB318cWFwI323hh0At920Jad1BQHBhlUNFNOtEnfa3MiP/j+A7AhjaDx0Ygx/vjl2aPZK92TW0wstQjvjJlMH0O6kx27+AYr7LpyKPEmS4Gix2+xcexnnj6zAUeccGD9xZquXmVC3DJJVVhZ0kdfMVvopOonih7rN/S+hPes/YwpMjTVAcAya3oAsC0IdKdHfF7N02ZwYVPV2khE9wfgbcAAhqw9gSUEOkXF/soJDicCbWaZkJskPRnNtkQ0j9DsF8N1l1XR4nkY X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd5a01b-b21f-46db-c7a1-08d9412b66be X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 09:41:31.4874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y8Ns/AKk++mSu+6Y3o80Kzva9jkigPyV/cHei4k8ZKOkFCPujqHF8Rt1EOvyK8638kl3VW893m7AO8ETMesAoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org is_iomem was introduced in the commit 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va"), but the driver seemed missed to provide the io type correctly. This patch updates remoteproc driver to indicate the TCM on IMX are io memories. Without the change, remoteroc kick will fail. Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Peng Fan Fixes: d59eedc0e408 ("remoteproc: imx_rproc: support i.MX8ULP") Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P") Signed-off-by: Dong Aisheng Reviewed-by: Peng Fan --- ChangeLog: v1->v2: * using ioremap_wc for non TCM memory --- drivers/remoteproc/imx_rproc.c | 35 ++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index d88f76f5305e..71dcc6dd32e4 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -71,6 +71,7 @@ struct imx_rproc_mem { /* att flags */ /* M4 own area. Can be mapped at probe */ #define ATT_OWN BIT(1) +#define ATT_IOMEM BIT(2) /* address translation table */ struct imx_rproc_att { @@ -117,7 +118,7 @@ struct imx_rproc { static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { /* dev addr , sys addr , size , flags */ /* ITCM */ - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN }, + { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S */ { 0x00180000, 0x00180000, 0x00009000, 0 }, /* OCRAM */ @@ -131,7 +132,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { /* DDR (Code) - alias */ { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, /* DTCM */ - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S - alias */ { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, /* OCRAM */ @@ -147,7 +148,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { /* dev addr , sys addr , size , flags */ /* TCML - alias */ - { 0x00000000, 0x007e0000, 0x00020000, 0 }, + { 0x00000000, 0x007e0000, 0x00020000, ATT_IOMEM}, /* OCRAM_S */ { 0x00180000, 0x00180000, 0x00008000, 0 }, /* OCRAM */ @@ -159,9 +160,9 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { /* DDR (Code) - alias */ { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, /* TCML */ - { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN }, + { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM}, /* TCMU */ - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM}, /* OCRAM_S */ { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, /* OCRAM */ @@ -199,12 +200,12 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = { /* OCRAM_PXP (Code) - alias */ { 0x00940000, 0x00940000, 0x00008000, 0 }, /* TCML (Code) */ - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN }, + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* DDR (Code) - alias, first part of DDR (Data) */ { 0x10000000, 0x80000000, 0x0FFF0000, 0 }, /* TCMU (Data) */ - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* OCRAM (Data) */ { 0x20200000, 0x00900000, 0x00020000, 0 }, /* OCRAM_EPDC (Data) */ @@ -218,18 +219,18 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = { static const struct imx_rproc_att imx_rproc_att_imx6sx[] = { /* dev addr , sys addr , size , flags */ /* TCML (M4 Boot Code) - alias */ - { 0x00000000, 0x007F8000, 0x00008000, 0 }, + { 0x00000000, 0x007F8000, 0x00008000, ATT_IOMEM }, /* OCRAM_S (Code) */ { 0x00180000, 0x008F8000, 0x00004000, 0 }, /* OCRAM_S (Code) - alias */ { 0x00180000, 0x008FC000, 0x00004000, 0 }, /* TCML (Code) */ - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN }, + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* DDR (Code) - alias, first part of DDR (Data) */ { 0x10000000, 0x80000000, 0x0FFF8000, 0 }, /* TCMU (Data) */ - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S (Data) - alias? */ { 0x208F8000, 0x008F8000, 0x00004000, 0 }, /* DDR (Data) */ @@ -341,7 +342,7 @@ static int imx_rproc_stop(struct rproc *rproc) } static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, - size_t len, u64 *sys) + size_t len, u64 *sys, bool *is_iomem) { const struct imx_rproc_dcfg *dcfg = priv->dcfg; int i; @@ -354,6 +355,8 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, unsigned int offset = da - att->da; *sys = att->sa + offset; + if (is_iomem) + *is_iomem = att->flags & ATT_IOMEM; return 0; } } @@ -377,7 +380,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i * On device side we have many aliases, so we need to convert device * address (M4) to system bus address first. */ - if (imx_rproc_da_to_sys(priv, da, len, &sys)) + if (imx_rproc_da_to_sys(priv, da, len, &sys, is_iomem)) return NULL; for (i = 0; i < IMX_RPROC_MEM_MAX; i++) { @@ -553,8 +556,12 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, if (b >= IMX_RPROC_MEM_MAX) break; - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, - att->sa, att->size); + if (att->flags & ATT_IOMEM) + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, + att->sa, att->size); + else + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, + att->sa, att->size); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); return -ENOMEM; From patchwork Wed Jul 7 09:40:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12362283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B19D1C07E95 for ; Wed, 7 Jul 2021 09:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92B3461C7C for ; Wed, 7 Jul 2021 09:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhGGJoQ (ORCPT ); Wed, 7 Jul 2021 05:44:16 -0400 Received: from mail-db8eur05on2076.outbound.protection.outlook.com ([40.107.20.76]:12801 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231223AbhGGJoP (ORCPT ); Wed, 7 Jul 2021 05:44:15 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bghOQvAqtUS6JN//fAmw4chWqBLSkB4SIMnzsPPVhTF302xofKyMl9Tu/WhLQrFAu7nZEzFWWrYyTmiN5DmZdHUBEypeWU47n/Fp7oQRLUC+cLCrC1cu7lLjhhn8Wg1SIR3Wfh4zP1EcpGAU3djh/3GDD7knIAtYto/A1Pa5C/JUaVMwD1tow3C1RSJC3N/xjsbPXtU7yT5XYjjhQk9h/HYX7s8EF1HJqBzy8tTYEYKJlJZ9nHTtorEQq3WQk0biTT+w2XO2sD1dLEhtgiVBLjpKluOgbC0JnIw6hW38f+XOYwiPBTGgqXq5QlXmwk7FfTBQJoFSDxohgz2WpCg8ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9031WpIjCstWowIFUsijoHpz/rOg2eR5mjmUhbJU/4g=; b=R/JQZoN94SZmmk8VvLfuUujG+8PBnHmNlYgVIiHnoDeEFC8S63GxDKpy4bwTznJx7XK9OAuQnikUcdMjdP6lEYWauLqNhngQKkmhh3q4qegBqnsYy6GJXUMRxtl4scxTLY3+2Hbl4SEw3sinQLMz/+WFgAQ3Y3MGU9kd22NgQIkxelehiAbd12khYsXmrNhHsuYlT/Ku5WNirygvATb8j/tsysdTnC/fdkaMYTuOPiXPJTDv34MhowYlwjqTO+7oZlvMiwiZz6Wq+s2fL0ZNmzxXemO4gMg5QksKb1zqEjAHhZG3KPFRrDc86FZ+Q2baOgza+6QhNlcHreyjyWgDsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9031WpIjCstWowIFUsijoHpz/rOg2eR5mjmUhbJU/4g=; b=SKC7d30AdIOHw05dgSrwWvDqd7vHr2Q3kHWEHl87JNU+BMtWv5EQWoYun/6+usPPvJHms5aZ939w6/umZMjjytXURwDCj2CnMX0/MYIwUW2bsHnIw0dFK59qvmI4mlCBVunMBWtrOzcTXpqCrZGQWrIkVnHg27cD86KvA8R4sCQ= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8565.eurprd04.prod.outlook.com (2603:10a6:10:2d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 7 Jul 2021 09:41:34 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 09:41:34 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Dong Aisheng , Peng Fan Subject: [PATCH V2 3/5] remoteproc: imx_rproc: fix ignoring mapping vdev regions Date: Wed, 7 Jul 2021 17:40:31 +0800 Message-Id: <20210707094033.1959752-3-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094033.1959752-1-aisheng.dong@nxp.com> References: <20210707094033.1959752-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Wed, 7 Jul 2021 09:41:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d1a7a1e-5668-4632-2e6b-08d9412b687e X-MS-TrafficTypeDiagnostic: DU2PR04MB8565: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:398; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gysN7ltwo/zxubAXabr9WHJNFTZITUSguIYTsnAHG89nZDVTnhOpAhIAoWViynHz/I/+S8qumwaHqpgv3Eox+JNT6Z/UazOq5xHI4LYvPycqaH9HivmmzUr/UeCimTXO8VLsYz0Va4vR5aFwJwiLvV9hL7XwbmR/t96+siRhFY1EmmIn9tXLDXikmMEKR1+Bpdbzzpzclu1D9f+TO24EjFbATrxUL1OSw6tlKlpC1F8jDXEUdE2XTB9BBAGS0uPuD44lRR/q22KSOQ4Lgbt5v51XUJH4zPYUBKPXeAPmAAqUx8oe0ceIllZROcCw3SnPjUYm+OQBI9244+xJlDra23rj13VPkyEliw7vbIQxGUyUcojC47/+myoLPqYSrjn9+s6M9OxIfsCiH8yPSwvsnoDivg6tFeCAqUO3iHTSrs1rSOboLCcNQ/hPwAunMrkKOJPk4JKRG3gw4VaYMO4rB4Itz9BuMR3r8foYCr1XHv9ocU43nXH2gDTRQjuLoCQeGNrNiFTsDjOliETVw8EJZIS4j3i6JaNCfNV1tGc+o6tvlSDkCT6ivE3KP5OMKai0pbqH9ja2D3ccxXoGaMM8qJ6g540ejV+ANVj4GjwJlUl/86TBpcef6c2KeKAh65EacUc3/JO0Mg5wEj7kgqSetM1qzMFYX1O4N0DpgIGkTl9tgcjWcON4/xfn/8/GMbZFsF9XrGbFOa/ib7y3+2fsuw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(6506007)(54906003)(4326008)(83380400001)(66476007)(5660300002)(6512007)(8936002)(86362001)(26005)(4744005)(8676002)(478600001)(956004)(316002)(6916009)(2616005)(66946007)(66556008)(38350700002)(52116002)(36756003)(186003)(6486002)(38100700002)(2906002)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LaSv0rpqbJt4ew0+heKs1JX8ISsfLObf3nDHpENnJl/ra8GjKw4LFFzu4+TNQiPv65t1e3zs8Fz+FjJNRbE9w4Pmcg0BntuhwWw6+Xy8vJ7Ne04z2jIVaFYWdtv2YK/jxUteRdKeWisbo5r/UgaF+laUbcB79/+oXjV7vSGHQjEOvyw4UPjptgroEJoGc4GNzXHIC5iEh7KnpD5bFpuBXnNKhZ+ncub3XUFHZlN9vS5oFS4jDqiw64jCrI09LeeMIZA4hhMY0SCP9TM74XmTOEGsfj7V7vKObCK1CnHW8SvCgl3i9UoRBQ7F8VUiHSi+KynYVof/+9trIPNF3MdMo0Ucy1dB+uqC+nrU5Pxiobl9kxGoCFbI4GDoBNrHz+6iDTg/ok6VKSB69RSGeNG9UjMNjdWwodXCzvd3ol4vo8jpoeDyJHwBhUhCNqY332vO12vvDpzWpouDoNabemeWPpVuLWXFN+XNGobQs8JZ8JRXZJZt0kxkp1X2jZBVpgWWEbeNCCQC/GXDC6FyuUnPtfj5gRdM+9hEjJNxu6wWeYXwHKT0h5kPx8EKo8y3Yh/w36vdVWVXLbd0w/c6KHudusQihUQ1nh98xXVn2XZ4+vEzt6frok3PmJ/uUx6a0iCAK5w5r7XX9o2RtkpLPcqkzsmtpjBpZkz39X6WDQkB0qkCE9e50OrYqPMTW9ujCEp59WCyiy0ZEFGomeSpt7ywYIWJWCxUrQ3HnSCY+qksH4tb5Gr4xPudg1BbdvP52GOAXOYdXCVfOY/IB7LM3npmPDNb8J1TcHTx7S3GFC/8cvGmBCrUvyY956BNhzd3Ftw4g9CsGnDmiilF3qexEtUiXfS+mxLqJN7eGquHXtO2di6X3BrXr+b8EFE/ZOpYO6Oc7Hh96Og4HS3d+za8YT/RpYMFjy81HXo24/FcRupb59tLukCXSFPkcS3xn7MevkAWk2qbi3aBEb9K7ehm7dHZS8OlGeEhWBKXupuxtLjpw364AUONg6PpS2mmh1VlrlBRBZ4yafGnCd3td2Wl/mX5aq8RqFWHd7B/fMczxivSBsnXqU9fRGZNOm9EnAqLox2zh8oGPudPpz6hig871nVnwwzh+6CKa7c52zfWVF7XS3TarTgUM4J37gi22BEGUjTEBz/iqv6nCq7REOj0j5f32CoERQcHqGRZisFXT9kmY/yL/jkiAjeU8DD9xBBs/fDAM8TEUmqSd8ISNHASuBGVvtSn1lqecMuq8bT3mTXWlTJPlwnKOLj9Huh4JPgB9uuuNnczV0pAvzQLv+UUFaZXslwtZ7RN9F+TNa4nBXzYQNYPm6JAOfDZtC2z0zsLgfqY X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1a7a1e-5668-4632-2e6b-08d9412b687e X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 09:41:34.5121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rU2Ghdo+PyXo5Z0yTjnnSTUs+xSMsTAKcTMPYen7ZIlUgzqo/Fh04XT8cbYaPjkjjCwsAwvSt+IyKjIBVYRunQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8565 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org vdev regions are typically named vdev0buffer, vdev0ring0, vdev0ring1 and etc. Change to strncmp to cover them all. Fixes: 8f2d8961640f ("remoteproc: imx_rproc: ignore mapping vdev regions") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 71dcc6dd32e4..abfeac0b1738 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -582,8 +582,8 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, struct resource res; node = of_parse_phandle(np, "memory-region", a); - /* Not map vdev region */ - if (!strcmp(node->name, "vdev")) + /* Not map vdevbuffer, vdevring region */ + if (!strncmp(node->name, "vdev", strlen("vdev"))) continue; err = of_address_to_resource(node, 0, &res); if (err) { From patchwork Wed Jul 7 09:40:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12362285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3026C07E95 for ; Wed, 7 Jul 2021 09:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE1861C82 for ; Wed, 7 Jul 2021 09:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbhGGJoT (ORCPT ); Wed, 7 Jul 2021 05:44:19 -0400 Received: from mail-eopbgr00081.outbound.protection.outlook.com ([40.107.0.81]:3396 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231137AbhGGJoS (ORCPT ); Wed, 7 Jul 2021 05:44:18 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BcYn+CbZnoOWB4CkeGe5nrn/v7Ak13aAAfQJ3bOoP4nPi8PQyLVbWapyzLNPYvKS9egWv3/HOzKNRsICRUp6s+/wCzXlW9+ndhqjgH6EWfrvHtZ4+fskfSiJkIs4B3wbU9qXxUmfLrJ6o7anF92pGDfqYMa9X71i0Hk1tfSvH4VifcUD/71PIRqXIah+Icd/xFy2Fwj2EAihbSbZZN48tWwjAAcNB1vUJTp1OUZNzW69XRekN7WJmhB5u8qGvMQ0Jy5HUbuH9qO3RMlU5RedPQ7MQvB0mcE8oRSQYOBtPojDrmf6dvYC8PKjjDxexOVC4HnGowIdv4mw3w+nVP/mtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZ4CCtzDIvRohMokDR2J0zvOA1H6R1v9iDVQXY60U6g=; b=PCxbHz8lGKmdJt3XnMeqH1aDvD2Fw2iqFI0RlOB90f7V6iaDKx2kPxI446GIZt8tFkat5ji9YUhAEK9Zoi9fAHIe8qhSZCQizHsWVmsRmRfAugRS4zkiji1T82S09orTnEt2zAT30B12g2OGmgLw3lcl/1WcFLWAo/4mr95PMWTr6LjEWrgRmRU/yg2kqin3pdGkkDcZxFFWIKInqr5atvc0lkUlSZlnBa+hI6DWcFif+afy4mDfgfffWErABqfLA9dLCjcYV/S6HbPsbZL0W01HMxMhbYbvSlSVDfUiX7POtozAnQRmyuTKjoGGgeZtatgdcaEAgHQTooRYEiCQxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZ4CCtzDIvRohMokDR2J0zvOA1H6R1v9iDVQXY60U6g=; b=maJtbTPGmbE6wO3F44h/gW3axCQpIYCrMr4AhO2SHa692X0LTYkXx+0Km9z0iqM4v5Xo7TFs/1uvDEEvlwjxg+/U56bOo4RWwfnh2fY0F45QLh5j6DhzJJAeFOMEaFMWHx999S0V9bOj37bAb0QW98s2hL7E62G/Q+A1usV6N9M= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8710.eurprd04.prod.outlook.com (2603:10a6:10:2dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 7 Jul 2021 09:41:37 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 09:41:37 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Dong Aisheng , Peng Fan Subject: [PATCH V2 4/5] remoteproc: imx_rproc: fix rsc-table name Date: Wed, 7 Jul 2021 17:40:32 +0800 Message-Id: <20210707094033.1959752-4-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094033.1959752-1-aisheng.dong@nxp.com> References: <20210707094033.1959752-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Wed, 7 Jul 2021 09:41:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54c4b72d-dc86-4ea8-cfc5-08d9412b6a43 X-MS-TrafficTypeDiagnostic: DU2PR04MB8710: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 01nJDq3eCjiGTQXvMbq7jzEiFMeIEowgm2hBxM5teds07hyDrPGgXAMFh3uXSGluMLHH9G1JJBnLaC5ooRlUrflqixXJkVBXw1LnmReLuJW9DYqJEhUGKXcsA6M6hWgKdYaoDimfRHBkI0bAct8aCVbYc59R4yXLo2M/wqht0wnu35k4WOVmgyA4HWAkK2YJDKJPwXFuaZJuN0AZvgZRTgtszg4o60dWufxzCadaw8Zzuz6kx2sTyTtXEwRtb+9O9OExJ+GKhL7drKj1lKXCsq4kH5921l7UXG5lRvOHXi/KIRYz4VdO30fZCa8snh3syLITAq3VFKUydKbfzla10+6EetkedqygrktakrYer/EDOdnYhSVPRSKhHevipPwZwUqH/giyiWBskwq4UubXcmkk8eRyqwcN6JYWtRNsj2KacagIQ3sz6O1QZlCHW3v+sqOPhGjSe3rQQkjDUWnKHF1GE+25rkKEjWBa0ARx+01CTAX+oSi274cH4vJWEjKY8bgeD9h2Y4sGaKs/ihahacgQmdkM8pIJLJfeBts8a+ktC7FatAVXw/bfCiVaGTfC1nlBJsSeaSp1h61FgUfVaDIGrb8zPaYMS4U+ea/Ni3Nc8LxOzZvMCmwvKIFiPaMB6iirZ5178ezsksLk/m3sixjkRO+NRCDTi2f/AlVti+VeXbprsLABhY8cKmBw9uKATw715bZGItFd/zqG5HhgcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(4326008)(54906003)(36756003)(2616005)(2906002)(86362001)(83380400001)(1076003)(6916009)(6506007)(66946007)(26005)(66556008)(6486002)(5660300002)(8936002)(478600001)(4744005)(38100700002)(6512007)(956004)(8676002)(186003)(52116002)(66476007)(316002)(38350700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xczBY/WFFM8R2vgU7EsK0uICbDthgTGbzXS0n+fHHSxvPZivZCzGjjuuMSF/zbTRzfFm1q0Ib3uSkP0fpM1rexxvfiY7yr15W4K8eG9+Li7AwvYQBJPO5a5V37AH8zxoE6fhaEg87teVoIGxJx+AuQQst3XIJAGQrXeF0ZbS+cDjgr+GzsvAK7f7e6dZ7DGy2y3cLEccZmNq7qpwnP1BFVG36WQm/3YCGlTRC69V5eiAUgVhgCzH9GBkchzMMxuoieZbaG6y1SU2ELEckPGwxfzOypgXOk1PZnXhEi9euJ7V/TH7YvOJUKZzdwJn/OolKOZaBk7GiUy/loyUD43k7/9sAlF6S67f1HBNumANxjgTR2ref3vALdFTqzzox2smrsQ5d+hoKNg/3OLnW1DFbggx9ZbTmwhZqh21DmbecYfis5/UVYwdfUlVomsrs4jJniuPr+/pvUcwk+MX68yYpjRiTmLpLMq/TtRB8/t7aM+ZJuHn3JlJsICsr7JfdxYPbIebAx89rV6F8XpXYmhl81FXxJbV25XW/wFerPZeJbFG2rBNHBZ+4BhkE5FyzT0lVMozmRpD7D3qR7BgHXLPxryEzCfPEz2olnjarUJJc76A0tL1sdK0soJNmciIcNwojddllwA04Z9tuAko8PXAwscCMi2daAOyny1InnRzUXBnG67GrAWiGMZASzj4uwWZl8nxUHNmtqkOGRUYZl6I32faTITuBQG0BG/x81NiCoVLYsi977jTXQiLmxROAAr6XtprG+Fu/eEDN3BfYydrMmqHS98rR+Wn/og8PJ0k9/EnqIPWXfIg9YOrltrXTadQVhKBDRXKNJiSJBAjZFfS2i5G5SEajIjG5SWVfYYxe55UjtGM0xnwVFv5BOWznQctZeT4Z2eGZxmP7RKqvegvxI8nvnnrEk6KqVaQNPKUKdFXxbRS+RvpQyPdmjcJjhmsFnI+d56x3xI8N73LzD+DpSpip4lWMcKDZP7P8braDzQJVPwqfGoXEAfntgZ5ZnK6TFMcAOEkI2RNfZz7jAx7dJj1kBn3uUWkwHwD/Lc+56ztc3EnFOZs2utm/QNiO98hMz0vxQ1vGc/vEWvEX/vVGRiOFLYt4wj+zHV0B+WsT9cEfjjjMtO7uRiruOke+Li+M+dd5nZfjWFlf4F7pX9SCdy5FPr9g1U+2gr6jblFlQmjsRLX1QngmbCCzgJe/SQSRk4dhvQbeDg8A2zWapJtjGRS57eHjpopHaVlg9yfameuCjhNS0pKS1HNvOaQnqu4jRTOEri/R0kpqenn17+NOur3jvDZdg2/hEnee0xCUD3f/thZj53V8HTWyvyvoBVb X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54c4b72d-dc86-4ea8-cfc5-08d9412b6a43 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 09:41:37.4910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wqn8CT9erjXjiVaa25EKpHE4+EcRgGHifPJnTMP6ZWCeH2xe+WkURQNswYxq1V0cHs+Wl7SfRzeeZsu6xr9/pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8710 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Usually the dash '-' is preferred in node name. So far, not dts in upstream kernel, so we just update node name in driver. Cc: Bjorn Andersson Cc: Mathieu Poirier Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index abfeac0b1738..ff620688fad9 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -604,7 +604,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, } priv->mem[b].sys_addr = res.start; priv->mem[b].size = resource_size(&res); - if (!strcmp(node->name, "rsc_table")) + if (!strcmp(node->name, "rsc-table")) priv->rsc_table = priv->mem[b].cpu_addr; b++; } From patchwork Wed Jul 7 09:40:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12362287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD50DC07E95 for ; Wed, 7 Jul 2021 09:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 904ED61C7C for ; Wed, 7 Jul 2021 09:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231137AbhGGJoW (ORCPT ); Wed, 7 Jul 2021 05:44:22 -0400 Received: from mail-eopbgr00085.outbound.protection.outlook.com ([40.107.0.85]:34710 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231175AbhGGJoV (ORCPT ); Wed, 7 Jul 2021 05:44:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n8MnL31M4Jr+WVipx7HAk+EhQTgeyC5/XzAks0p7Sc7w5IBR3fZwCCKZzugOjNvWgSpTfvLtF/nkEoKDY7/g+8UJQQUap6m+ZyrngQsNg+vx3WdN+a47yWBMVMNuX2dEVRFnw7z169pnd9/4pWNSMo52dZpMVhYJwFWiv8aBusUPs4/MaNldGsAIX9kPrclRLkGVLNtkGlY0zrQZjxJgF+cx5J4fXjk5CHFYaYv71CwE02UvzuhGUz/3LWaa9Adv6oYh+UbItsJCQLizElWCGqabEdefbIR+ZqqA5ko28XVj/VkERDN8Hr61fr4Fxz/tJb5Mfdwkj+PU6Ts5dAnhDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOmpuJk0w1nfBcrwnubtNPSRtW5XKSKu8QPZLhagQNw=; b=fngLNPHCceIKE5pZpCGasZSDuYz4we3OC8qam6aQt+nHgSUVOCdDrKy/LxVWyr2BPfGywlMhBMmLqXgR39gqMalfXU+KZoUKOXKBRHaSwvjstGedmaHSXDpPJtbVo8qTJQixo+L3WrgiWVVT/Le6qeSsDW1VHQBf7NKaDaDdw81PyfTAEeXtYigl2RbulifK1++f42JyQ/f57RcBmBoB6gwQZ+lRjLDdDoLnhxMQ1bOkk0ydV6Oh0JZuIFysn/aSue9d825eO7Lg1jbwLOtD4U6bY8O3w52ms5tUnRo2qiXr0FU3tlQ5NRf/W6RGqhsI/94Om8a6N5Mn6daTYvijmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOmpuJk0w1nfBcrwnubtNPSRtW5XKSKu8QPZLhagQNw=; b=q2Wp1CtFr/SuKqddeHLDGtbRleqOQmdwQsw5p/ciOlchu/txU32Jha6LdwJeA4qBaQl9PDmRR1o6da6jOwe1yP7G0lw9WvVQddCJoEV+oe5aussmPMmG8dKnTLVi8Cp8C3AhSyjumW6eOfg3Lv1i4XUPGp5rXF6LcYU2PCenNVM= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8710.eurprd04.prod.outlook.com (2603:10a6:10:2dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 7 Jul 2021 09:41:40 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 09:41:40 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Dong Aisheng , Peng Fan Subject: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Date: Wed, 7 Jul 2021 17:40:33 +0800 Message-Id: <20210707094033.1959752-5-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707094033.1959752-1-aisheng.dong@nxp.com> References: <20210707094033.1959752-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Wed, 7 Jul 2021 09:41:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02b6f69a-8450-486d-fce1-08d9412b6c14 X-MS-TrafficTypeDiagnostic: DU2PR04MB8710: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8O1b6Nrcb4MecPLNQkkdoDSws67I1ZzfC5ZLY1dSO+BzQ0uapAxL5/904GappQDnOyrYjVNopudloPFTDFwt8a/Q7CPiLkSI2O0yEalqzWEM8EtyiIFoguK/IwBytb4S5tdQqLClgQIKGOOVdcdtDgXIQMDUd1Vr9/OLdgcJZJHssGT5ke6QyAj/Ky91zRcIFqFcT3S1hT4btC9W9VCGqV1zYrO4IESpTgXFXP2AvcDGliqDfoYhkMC2VdUTLB2/IBtmd/kOf7Ba5lyJqSjsk1Qtz5xnejTJljkb+Q2Xx3sGRnjA0WQ87sFteDyEmA4BL6wMtV6+NfbgxJBrDpVT+kdb1CuUxDYHj3NxHpbUH49Lbj44In5ME9zisnjqmhtoPnfZfux44HyuWnwedhpMFs88YU7S983gEIyEAhPNt+Uhu/el41ymqA5dr8V7IrCNXBMfq5bIqs1o+5ZIOKZ4ASKa12z+BoxauVbPJX5qPok0Hs1W62KlyTma9E+T9iJSlqKkKyBtA1huZHiELETx/p44ass+0FtnKHt6xQB0alt+38ldJeyWdKj53QkchyI+1GxHOrcxReH0ZvlELA/xG2oEykk09DSz37dFefvfsKhBsoED8t5bahXxdKqKHa0cvJ5jjRPOh8Snvyod7e+KpSjsZ2Z9Xmp5xa7oPV90c3khQqafKA3M6WveWByRwS7WFnLeQ9bivbBBCqP/Kw8/UA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(4326008)(54906003)(36756003)(2616005)(2906002)(86362001)(83380400001)(1076003)(6916009)(6506007)(66946007)(26005)(66556008)(6486002)(5660300002)(8936002)(478600001)(38100700002)(6666004)(6512007)(956004)(8676002)(186003)(52116002)(66476007)(316002)(38350700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tmeOYPCkydT3cbp9YebTELvrhlCykmrjjVJz9mjEtlzmgxdDIDOwigurGKR5v0Og6k0pAGh3uedH3AdADVzEt+Hhg9Ql8IbQKvnrq5SkjqhyZlJlMs4Ibh8Yk8ZoZAYTO3L+9S0Fg1O9zOYbzyZwaA2cOYGXFh0qydBjofcvgFOEc15k/Qq4ld/2oWMJJJ8D4trqGFNMJSTlADtX7sVDXQyR2Yi5uiaqNYEXVgZzllAeoyNEmJlmMIpFfLyYMfSv0Kvd4nBNF5rHgg83sMVRDPuWfzC0fdNSQgpZmKJbjh+GIZ44pMV5Fn9lrti0h/h7uT2jOQlUoYQKb0bd+RvtH1WIUoL9RtyLNjtIm0nI0UmkgwEtLQHvc9VsEByTFH5lHEVXDwv7li614rNdPxG/k8blKGynl77zAlM2FG/Pz8WnXtA5o8NSGaMbYTyGboxr8w1aVk76jaq6k0B7kH1UnREN7dRqrL1bLGNaxuJQZ/tStBZM4iKH1DhYvd2AWwA6AMQVHMsgsBq7AP4R0zRNL71LE0DMb0XoEJn3DMWr9dyOY3uyVparwdCPeDpwMqVwo9gwBH7KCykIJH40AW4oDVfomGBVFGH2CkZG3t84DyM9zqJHnbYxY5A6gN0j+2kYW7CayiYQWPSa6KuSk7ztU3GX2Ywpoeyg8wkY2rnIw+auMhD8oYxH0GJRv+NVbvBazS39/IWBpyVBr+M62JbCxTkkZ18dEFc5X7Im+UJtenXpD3zfhPqrRwDH0BHtLY3gfNv0pdzhgcXB7kKefNCm/P9udXkCDZK3pQrBjMV2pcI2lidv3F1g35m5bzcRZvyf73ZXbCf24xaF/nht1t4t1E/6n3mJKtIK6L7arCcIj4LeGlNp0e9Gw/Cy2wosy/kCoAIqtnnBiHJU8kbdUUKBkr3TeraWrpOidf4AIQCcLZoDsSQxexe262YsnJQ8Ef7jOiNehLpbYgag1SQvcDx9kUGd/+ABxSLc57btZ+wqzdIinI+3gEGNQQUMjcNa5Mda6HuxffwEi60hZuRuRcp659cWjXCktHjF3j5SJsNe8alb2ExgMeHrRJ7oA2ExUwsPKNv+lDBXcvpES4NM8UMIWMkWzouOP8lCbfKsJOUF2xZvWQ4MqEN5FLBcStyb19pF/IaHZJh3x054pgflmu8Zlx2SIa2OPyEAOc+CWTeH82BhHs7zLn1NNCZvxHrLkCnulzbSuKx7DJBeTOC2/+LQnVWyibNqRodCLOofS0eeA8Iffqjxu/cJWFox7XHRVbbGnZ0pQVo+uHcx09iU6jULLQeOK/oB7+jIeraTFfuAydcLQ4nyiFxDRDm/IWFuLh/X X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02b6f69a-8450-486d-fce1-08d9412b6c14 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 09:41:40.5476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5SPhwld0oB6QlwEtGbjsmySs8JKJf5nJUmu4w4PFr48NQH+jPCJC/C2gNdGETR+loDDm1eYUmJ5W/o2JwdwlJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8710 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org DRAM is not io memory, so changed to ioremap_wc. This is also aligned with core io accessories. e.g. memcpy/memset and cpu direct access. Cc: Bjorn Andersson Cc: Mathieu Poirier Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng --- v1->v2: * new patch --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, break; /* Not use resource version, because we might share region */ - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %pr\n", &res); return -ENOMEM;