From patchwork Thu Jul 8 09:10:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12364769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C79C07E96 for ; Thu, 8 Jul 2021 09:11:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A0146146E for ; Thu, 8 Jul 2021 09:11:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A0146146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B22E6E895; Thu, 8 Jul 2021 09:11:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD8A46E895 for ; Thu, 8 Jul 2021 09:11:05 +0000 (UTC) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E194282DE8; Thu, 8 Jul 2021 11:11:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625735463; bh=v4bVoRD53O4Rz8K6iYCnCgki569VZie03IcR3yzZahg=; h=From:To:Cc:Subject:Date:From; b=dOieoYE8YXLDAIzAxx6hfonY3mCuzzwin8M8jbaBmvdjStMAYSZLun9NSdJgwGxPM 0mst50bKbrNtwIbg0+0P3Hub4GDxbLPU2jFRqHqYt7JLR29dihA1KFKk4jmcqHcMws CPx7gDnqLAIdUz3hy7Z9QRFsT0bDf6Eyw2UEnWdDVHQ4Ol0bbb2mDfPQLtb+9wCtwh 86E3g9JJAt0bLFYbM4jUfIT8bKuEBheoZD2ifPduey8Ld49TYXF0mHSYLSGJ4hSZNI 54mRCXTUga7KAwVlezwgkVjenkaKiN1AeiOpjEovx+cESYrsnBlyfHBUZzO8YD3QPy ZIG/6YazpxuDA== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH] video: backlight: Only set maximum brightness for gpio-backlight Date: Thu, 8 Jul 2021 11:10:58 +0200 Message-Id: <20210708091058.56317-1-marex@denx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , linux-fbdev@vger.kernel.org, Daniel Thompson , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Sean Paul , Meghana Madhyastha , Thierry Reding Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") says that gpio-backlight uses brightness as power state. Other backlight drivers do not, so limit this workaround to gpio-backlight. This fixes the case where e.g. pwm-backlight can perfectly well be set to brightness 0 on boot in DT, which without this patch leads to the display brightness to be max instead of off. Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") Signed-off-by: Marek Vasut Cc: Daniel Thompson Cc: Meghana Madhyastha Cc: Noralf Trønnes Cc: Sean Paul Cc: Thierry Reding --- drivers/video/backlight/backlight.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 537fe1b376ad7..dfb66171dec41 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -676,6 +676,7 @@ EXPORT_SYMBOL(of_find_backlight_by_node); static struct backlight_device *of_find_backlight(struct device *dev) { struct backlight_device *bd = NULL; + bool is_gpio_backlight = false; struct device_node *np; if (!dev) @@ -685,6 +686,8 @@ static struct backlight_device *of_find_backlight(struct device *dev) np = of_parse_phandle(dev->of_node, "backlight", 0); if (np) { bd = of_find_backlight_by_node(np); + is_gpio_backlight = + of_device_is_compatible(np, "gpio-backlight"); of_node_put(np); if (!bd) return ERR_PTR(-EPROBE_DEFER); @@ -692,7 +695,7 @@ static struct backlight_device *of_find_backlight(struct device *dev) * Note: gpio_backlight uses brightness as * power state during probe */ - if (!bd->props.brightness) + if (is_gpio_backlight && !bd->props.brightness) bd->props.brightness = bd->props.max_brightness; } }