From patchwork Sat Jul 10 16:54:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salah Triki X-Patchwork-Id: 12368789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B0EC07E95 for ; Sat, 10 Jul 2021 16:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82CCC611AD for ; Sat, 10 Jul 2021 16:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbhGJQ5W (ORCPT ); Sat, 10 Jul 2021 12:57:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbhGJQ5W (ORCPT ); Sat, 10 Jul 2021 12:57:22 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD0EEC0613DD; Sat, 10 Jul 2021 09:54:35 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id ca14so2280868edb.2; Sat, 10 Jul 2021 09:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=qN42ft8TO2D20OJfcUBVmNsGjubNKzxaIpoGBDjnO30=; b=KG0sSGBzPIyk5dn/9sNt5fk1YQ28ryo6J2vVotiVbPPWEYatde9dumrcWhqceKiI3f IPDwqLnDEWzLXU4vPZg6+SegLfF3/3Fvf1Isv1yl3+vTyl+pgYUDMKM9493eZ7qT0H6o 5b0907j01AT7ZHVH4/ByLhKetsMah6WUxupKX5PMuvRFiBj1gQKNDlHIuU5sPKJDBnDt YUqV5R/mnwb5U9eQgia3WxIs6JQDH1RYmi2/snrCPZ8H4rvyP/iulnc6+hBdBYWwzhp0 u1/Sgp9M50AGqYuBpdzY4FElsnwk0WjKDAZPGi/gKFo3pKmp5QH5WZPeBc6OWP7ERKdi eviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=qN42ft8TO2D20OJfcUBVmNsGjubNKzxaIpoGBDjnO30=; b=Met8Keoe20GeKKAbmMkhcE6xTxioMMieM6xU+jE5IEXSojveYpKmAuvoCqQfadHQOV VanYY9hRyEB4IevKCjnRt1Lr3MVDPPc3Q5so7blJ4o+lDFSslE0XNYsUMhDOyj/0axT3 +p8lzCMm8LXStTzmmpR1r6N9fTRHXRIeCJyBB2+0T5J8h6NWO1QoQBZCbL+KGPjuID7R f37+66cDl5NscrUbAGDPBytCRwhzIAHdafr/uKb4Hq7RWIC0KWelBq+O5Kj/edocqtXs jPI5JaH8J5wkYF5jPywZK8VfpTio05KVvUILLuZQNjrRKqBHYcUYG2+6Kimtwj+N2L01 HCNg== X-Gm-Message-State: AOAM533caYDaWphKQPTZG+UxXxrzJ7GBtUjWBfIK6jd58nkrBi0pWkS6 N5xy21kh4SomMGbaeSNHPDYyxAt6Ovw= X-Google-Smtp-Source: ABdhPJyGZeQGHL0WIRf20gdnN8dNBz8RmT6sCRdzAsQgX3VQjmUP/4iWG4gOTCW+bCr/hOuxLfsJ5A== X-Received: by 2002:aa7:dc01:: with SMTP id b1mr54151950edu.239.1625936074121; Sat, 10 Jul 2021 09:54:34 -0700 (PDT) Received: from pc ([196.235.212.194]) by smtp.gmail.com with ESMTPSA id e2sm4854801edy.12.2021.07.10.09.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 09:54:33 -0700 (PDT) Date: Sat, 10 Jul 2021 17:54:32 +0100 From: Salah Triki To: vkoul@kernel.org, krzk@kernel.org, allen.lkml@gmail.com, romain.perier@gmail.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND] ppc4xx: replace sscanf() by kstrtoul() Message-ID: <20210710165432.GA690401@pc> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fix the checkpatch.pl warning: "Prefer kstrto to single variable sscanf". Signed-off-by: Salah Triki --- drivers/dma/ppc4xx/adma.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c index df7704053d91..e2b5129c5f84 100644 --- a/drivers/dma/ppc4xx/adma.c +++ b/drivers/dma/ppc4xx/adma.c @@ -4319,6 +4319,7 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf, size_t count) { unsigned long val; + int err; if (!count || count > 11) return -EINVAL; @@ -4327,7 +4328,10 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf, return -EFAULT; /* Write a key */ - sscanf(buf, "%lx", &val); + err = kstrtoul(buf, 16, &val); + if (err) + return err; + dcr_write(ppc440spe_mq_dcr_host, DCRN_MQ0_XORBA, val); isync(); @@ -4368,7 +4372,7 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf, size_t count) { unsigned long reg, val; - + int err; #ifdef CONFIG_440SP /* 440SP uses default 0x14D polynomial only */ return -EINVAL; @@ -4378,7 +4382,9 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf, return -EINVAL; /* e.g., 0x14D or 0x11D */ - sscanf(buf, "%lx", &val); + err = kstrtoul(buf, 16, &val); + if (err) + return err; if (val & ~0x1FF) return -EINVAL;