From patchwork Tue Dec 4 12:46:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 10711705 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4DC6B14BD for ; Tue, 4 Dec 2018 12:47:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E04C2A96B for ; Tue, 4 Dec 2018 12:47:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31DF52B539; Tue, 4 Dec 2018 12:47:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 494D02B3A1 for ; Tue, 4 Dec 2018 12:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=TA/S0kxrunX4UxpUXCBLu3j5SUfeR80TrZAO79nURzM=; b=UgT HSSCJcJYJrk5qjzbDaGFpI9fo+ko+oKxzhBVlu4D2HY1MlF+jhyfqe7WPg1IWqjgrTQaotZkLgvEL XTFK6WMtCO2yYaZcKIVSKw3N2oclc1inOKlxQ8cJhdcvvozYARHEBCz4SYVOgnp7iquHESkmcEKmI IDM7jz2UbUR8ih4/qSX+lV7pLRzfluNpaDaUD1F4T3RpQOBSCRwIGnsNToFCJnnkUOGJGHqVUG2vl Sk9lFDweR+Sz4voXoTpHOAgK+kj3FzTLW2TArWS5unDL+rnTtctuFVYGKq8m5RIKQz6GiSIUX2pDA /Jy+84jsi25gUS6YLeKDbdmPP+AyFSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUA6g-00052j-Lc; Tue, 04 Dec 2018 12:47:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUA6c-0004qi-Rs; Tue, 04 Dec 2018 12:47:16 +0000 Received: from we0660.dip.tu-dresden.de ([141.76.178.148] helo=phil.dip.tu-dresden.de) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1gUA6O-0000ku-Uf; Tue, 04 Dec 2018 13:47:00 +0100 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Subject: [PATCH 1/2] arm64: dts: rockchip: use correct pinctrl for syr82x on rk3399 firefly Date: Tue, 4 Dec 2018 13:46:52 +0100 Message-Id: <20181204124653.3872-1-heiko@sntech.de> X-Mailer: git-send-email 2.18.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181204_044715_074831_37987014 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On the firefly the vsel pins of the syr82x regulators are connected to soc gpios, making them software controllable. Right now the pins do not get configured at all, so cpu_b_sleep_h is configured as input with a pull up while the gpu_sleep_h has a pull-down. In contrast the pin names indicate both should be high in their sleep state and low in normal operation and the fcs,suspend-voltage-selector does mirror this setting, so enable the already existing pinctrl entries for them and also fix their naming to match the schematics. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts index aaa485dbe081..ea63477ca9fe 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts @@ -456,6 +456,8 @@ compatible = "silergy,syr827"; reg = <0x40>; fcs,suspend-voltage-selector = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&cpu_b_sleep_h>; regulator-name = "vdd_cpu_b"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; @@ -473,6 +475,8 @@ compatible = "silergy,syr828"; reg = <0x41>; fcs,suspend-voltage-selector = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&gpu_sleep_h>; regulator-name = "vdd_gpu"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; @@ -589,11 +593,11 @@ }; pmic { - vsel1_gpio: vsel1-gpio { + cpu_b_sleep_h: cpu-b-sleep-h { rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; }; - vsel2_gpio: vsel2-gpio { + gpu_sleep_h: gpu-sleep-h { rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>; }; }; From patchwork Tue Dec 4 12:46:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 10711703 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C408014BD for ; Tue, 4 Dec 2018 12:47:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B42EA2A96B for ; Tue, 4 Dec 2018 12:47:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A80B72B600; Tue, 4 Dec 2018 12:47:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 17A2D2A96B for ; Tue, 4 Dec 2018 12:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=c5J6zlAyELyF7L6G0uubpFGoqEoiLbcZbw3ZIfmDc7w=; b=gNt6/UKVLQ8eAnTXNRIB3mkPpj NmzkXoYrOTPeKFd1q9m5/I7mgMxDrpmaZyA66ych6fEBcMNJQgGlOXhn+rCyGS6keF5pO7HyMviOg xIk7ze8cOH/w1ZYBxP7bjNSzH7b/F2rTNHILV10mEwPg7MZiySp6lQdJL8CR6fJTLzYhpjDOXJQcc 2Qo/UYCb+UX8ureV4groots09bA73GCTl++TnDkVsz9n9ChFf6CvmwzkG502CuKIFF50vOkFLlSTc uRM3Vrkp3z0pTUtNU7Iqm8TvWEbYJuniELHsQBQKGK38RrG78mHU/bXOjHsNuz5Zge/BITjUhBa9o +lfTGkeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUA6g-00052Q-8L; Tue, 04 Dec 2018 12:47:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUA6c-0004qj-Rv; Tue, 04 Dec 2018 12:47:16 +0000 Received: from we0660.dip.tu-dresden.de ([141.76.178.148] helo=phil.dip.tu-dresden.de) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1gUA6P-0000ku-43; Tue, 04 Dec 2018 13:47:01 +0100 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Subject: [PATCH 2/2] arm64: dts: rockchip: add enable-ramp-delay for syr82x on rk3399-firefly Date: Tue, 4 Dec 2018 13:46:53 +0100 Message-Id: <20181204124653.3872-2-heiko@sntech.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181204124653.3872-1-heiko@sntech.de> References: <20181204124653.3872-1-heiko@sntech.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181204_044715_079125_DBB7FA7C X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The syr82x regulators have a hardware enable ramp delay of 300us as indicated by the datasheet and also the rk3288-firefly use of them. Therefore add the necessary properties for the two regulators on rk3399-firefly as well. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts index ea63477ca9fe..4b4c15ff3242 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts @@ -461,6 +461,7 @@ regulator-name = "vdd_cpu_b"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; + regulator-enable-ramp-delay = <300>; regulator-ramp-delay = <1000>; regulator-always-on; regulator-boot-on; @@ -480,6 +481,7 @@ regulator-name = "vdd_gpu"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; + regulator-enable-ramp-delay = <300>; regulator-ramp-delay = <1000>; regulator-always-on; regulator-boot-on;