From patchwork Tue Jul 13 05:52:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12372811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1879AC07E95 for ; Tue, 13 Jul 2021 05:53:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA86F6127C for ; Tue, 13 Jul 2021 05:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA86F6127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wWvxboHos3RLq+QXZWv4sXGiB8+U5skzuJqmQWbXFUk=; b=rwrRfJFUEwDzqm rr1E4BUzg+eVQzjqVqvKPNp/g/NIQixqGIGBnrB2f6LFJNKiY2/6LNFnltoj+SM9WPoV8bvxv10Wt i2WHeLJBPjBP4LQ4umyGlgTNrA3wg7L3iRlwNW1Wh9bQNMpuv8FmdgAAl0atdAAzD0e//lrRdkrZS AaiXnApzrPngsy//U9seqlyAyISTh1sRm+CIyrFlCLOvtO9ckz6lsbEMfeXJS+WKUR+5ROrVT8OuQ l028eexAVZKAWRSK/+XsXIRefnXXnKIujtG9WOasicQ2A5XQBESwcMrEe8wMxZYYzsOH56REIZyHm 0JRq1GrpjQjG0hItGGNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BLu-009BW0-Co; Tue, 13 Jul 2021 05:53:06 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BLs-009BV3-4H; Tue, 13 Jul 2021 05:53:05 +0000 Received: by mail-pj1-x1033.google.com with SMTP id p9so11471906pjl.3; Mon, 12 Jul 2021 22:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lmng85Px0u83llASk+gk5rLgTOQ6j6LNMSKSt4jMIeI=; b=HM9+khwIbE9awn14IA/b6gDroV2+LORNN7AdsQSFBtmzJ22vchCVTor7Jw2ieUqR9Z HXFmq/Rq5fMRiGYFCf4pRBfU6GnzpboUCVozgRPqug0OJBYenXciDngP48dxjYL05+RF ZAXdtqxbz+Ur2j0VmB5sU1MXhOWgL7cyF9fg6VB8EQIuA5Cz7thVWLDs4nKYzLANITrI jcR7MrbGlMEy+jGCCMCcWgTKF9Q5euNBpoupzwd8Vcf82NyIg6L1ICWaM02+QX4FrkyF ij5SUNIQU5gYrFNOjGWveoYWsp8lBtUH0iUwBGs4Ek0Xkm8ChFM5y4+jQF3s6PhEhCYZ RDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lmng85Px0u83llASk+gk5rLgTOQ6j6LNMSKSt4jMIeI=; b=o17N1Jl1SQs8n+tS6AeEy3Htsb1qcaWaWfkzEjxG4oX6ZZh+Q9kBVJWMfk0tNoXie8 +/YCdT/LSF0cU+/xuyFaGyGI0rd8A86259Nrzd5i/Wcc9m9HxjOSWhqoE4uAO6sD8aQt Asz+9/7ahsHw3cWLnv+8mcQRkCJLYzm6PC3V9EiSuUHru9eisb7d0JG4aTBJPsqc26qJ NMARyY1dOh5En3W2RdxfnsAC8+/Q/hwqWyVOXfzzfTEnpEJ5p307SL8PQs18XjBfTAku Ojhm7/171Gl6ScdKgZnpkaXvpgYz2CQGojhTo0SavR9CQm9TDV8YlgfS9vfkvkw3kpKz hcuA== X-Gm-Message-State: AOAM531gcW4SeexMFsn7dm6ZRG35VXxqzwEkYa4l9iS02jirAUb8bkw3 Gb49BlfESNdLHZkt1S/NsD2mxDUu6aI= X-Google-Smtp-Source: ABdhPJwTq9nwszpBMHHsyvcPH3Z+S8RDoz5Pl7U1c/xalzChkAACyz7SaZKkAeJe60mg+uGUG5V/uQ== X-Received: by 2002:a17:90a:cd01:: with SMTP id d1mr17784189pju.106.1626155583078; Mon, 12 Jul 2021 22:53:03 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:02 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 1/3] ARM: dts: meson8b: odroidc1: Add usb phy power node Date: Tue, 13 Jul 2021 05:52:13 +0000 Message-Id: <20210713055227.1142-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_225304_212968_E9FA3F60 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing usb phy power node for phy mode fix below warning. [ 1.253149] phy phy-c1108820.phy.0: Looking up phy-supply from device tree [ 1.253166] phy phy-c1108820.phy.0: Looking up phy-supply property in node /soc/cbus@c1100000/phy@8820 failed Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board) Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- previous version [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20190113181808.5768-1-linux.amoon@gmail.com changes fix the vbus-suppy to phy-supply, drop enable usb0 # sudo cat /sys/kernel/debug/regulator/regulator_summary USB_PWR 2 1 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.0-phy 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index c440ef94e082..ced1ec1c4878 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -32,6 +32,25 @@ emmc_pwrseq: emmc-pwrseq { reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + usb_pwr_en: regulator-usb-pwr-en { + compatible = "regulator-fixed"; + + regulator-name = "USB_PWR"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* + * signal name from schematics: USB_POWER + */ + vin-supply = <&p5v0>; + + /* + * signal name from schematics: PWREN + */ + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + leds { compatible = "gpio-leds"; blue { @@ -378,6 +397,7 @@ &uart_AO { &usb1_phy { status = "okay"; + phy-supply = <&usb_pwr_en>; }; &usb1 { From patchwork Tue Jul 13 05:52:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12372813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6E5C11F67 for ; Tue, 13 Jul 2021 05:53:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F94B61008 for ; Tue, 13 Jul 2021 05:53:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F94B61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KD6jlnuEK74Bv7kWn+sfT+W6O7hrRBGK+fQgRnPs+cM=; b=qHYyqCCjEuIPiE MRPW9vFnNBYbgfcp7CTQJiw/UI++PHC2xZTfgj8/jmOswHIDPv5LdHTBoHMdTOCaMMYuhnMMfWdkA 0u+0X1KSyQgX2SzjSANJmnDS0TvZxINR6QqZq/QL1TEgEhRiZDsWcoCiv5gzRDmG+wwZJD17y0nHY rQ1z1SwKIWsv5+9nCtqe9YEgr7E8yV9as0o9q/uvtUj9EsATnMyLUwsPvCidh07hrS31NU1z6xAVd qCqhH1Encie7d0cWLGtcbJCTUKKZ/Z/dFT5lz+1R//oaPgPDEK2nXitXZZdcERn/DVqXlVfXf6iBl HJlq1XyVjLOLJRVmBaqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BMB-009BbZ-5s; Tue, 13 Jul 2021 05:53:23 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BM8-009Ba2-RB; Tue, 13 Jul 2021 05:53:22 +0000 Received: by mail-pf1-x432.google.com with SMTP id y4so18532910pfi.9; Mon, 12 Jul 2021 22:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Apgi9n+xzAXbVBKSBVdWWRXmCTfXVngS5mFHrsICTMs=; b=B3ioeD3woNIR4eb4hYTJ1NhFODGfBWkLQ9pbW53Ntmb0NMuamJ68xfCoZup2ihwriq wDTdzx1v3MTl+aAOIs/ekQHiM/aKejL/nxL3x8BJdgipqgLE3wFo2YPg7ldQwfZea4Bh 3dsNR7dD8JwY6QQ2KB7P8/RzBAAwf8aHWGHO0/clNBOfbGfL4AmVcKQUN807hxODN6gB EUucJO5xCUoV6wfDQ4zA+io413074TdWGFJDSU724W7lXds6Wxjq1TlPvEoMA/3pYU+w XDDAiUfnXdayzbwwUm8THqEOFh/pkzRqJDOxCfHAdJwf3vkbSZKByKaTbKEVRNfUWDO6 ny8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Apgi9n+xzAXbVBKSBVdWWRXmCTfXVngS5mFHrsICTMs=; b=g+HqWscRzYJBvnziF7/1ZRonxCTR0olILwIywFdYfCkhTB/Bronp/qfhyinkeKHApc m6Vy8i4nzxB463yEDc4LBMIeR5WLUZvdOso26Se94B5/FZCz2WsscOvvkQLXPlJuZInw UJsNqf9KEsj+v2z/r9OMnxmP99waQnI61UnEbiSAL0riLOY6bdkaoEQN0+F7Qli91q3/ Qffj5fmkeG4FAorVFrf87QBmaGXRm1A8o0N7r2J5h1J6sQMOKKmuEar9X8B2/Y2dTdcj F2dVmMLmociPkCUsJgFfvoC6JXYDvZsAm+AfvZfb95Qvp6JwyWl95UZmfJ+0eULXs0if wWYQ== X-Gm-Message-State: AOAM533602FtJ2UBu2rt/+Ob3Ar9cmCmZSzzvuIsxLJmtvvCJ9zL0Q1U vAaSg3zmaHVwxLnssfD/1cr34LzGYvU= X-Google-Smtp-Source: ABdhPJzxR8bJEgTzU8kGrjBoNAgSB6f2OziGqch2oqIf2DEC659r67p0cjibkB2R9Nn/dIX5P6vx4A== X-Received: by 2002:a63:e205:: with SMTP id q5mr2716251pgh.404.1626155599825; Mon, 12 Jul 2021 22:53:19 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:19 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 2/3] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Date: Tue, 13 Jul 2021 05:52:14 +0000 Message-Id: <20210713055227.1142-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_225320_935309_9A0A490D X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Power off the PHY by putting it into reset mode. Cc: Martin Blumenstingl Signed-off-by: Anand Moon Acked-by: Martin Blumenstingl --- Fix the commit message. rfc - Keep vendor driver sequence for the power on reset of usb phy [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20210617194154.2397-8-linux.amoon@gmail.com/ --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 03c061dd5f0d..2aad45c55494 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -219,6 +219,10 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); + /* power off the PHY by putting it into reset mode */ + regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, + REG_CTRL_POWER_ON_RESET); + return 0; } From patchwork Tue Jul 13 05:52:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12372815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00C3C11F68 for ; Tue, 13 Jul 2021 05:53:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF50E61004 for ; Tue, 13 Jul 2021 05:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF50E61004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2gX/L27iImolSq3ky0kl97+4LCOhlWyn/4LMPw9wUF0=; b=vVOd7m8Ci6Xz+d XH/xs6GaOi3i7IrSW9aNBywNCvIJIcPaBCGsB7RPJLZKCifhGjCXmL4Yab7ubZvVod9sCaklWbXjq mhIZ/rSicU8oqmGTOAnL9NJXBX5OF4nTZ/hjzM9tHVXRJNuYGoIeFVLy+t1Q+bYuehm3vd7D7l1HC CPURJ96PVvVr38wGOe+4bZ/WEcovtb6SRRYeDlHwisH4PAAChfOnrxSATEXN1Sxe3zy3Vx4VPEGQY fC/Rw+0NBBkUDv28iaQrOXYdoS94dLRaHuaz8RUBohlKGF0hLynggJsMUdt5/vORQFX3aG3JBB2v5 Fjr8+DgPfQyQJBi+yIHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BMS-009BiN-3q; Tue, 13 Jul 2021 05:53:40 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3BMO-009BgK-NL; Tue, 13 Jul 2021 05:53:38 +0000 Received: by mail-pf1-x432.google.com with SMTP id a127so18542039pfa.10; Mon, 12 Jul 2021 22:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xqebAial/PxUvQ3x7+4RUByyPvCTdM4/Zaewy8REn3g=; b=rBIoJZjfWAT0sRt0CuW/uq1rjG98twshMCwuo4VaQt6XMH78VOKYuwbYlZD2OvKgfC WA+Orzbash1JXWVYc0LdD905jDTo2UNkKue11N0vhizpwQ1+hnchElQEiJBRU4v6SNjt Mp932YetKM2iQLa5Nj/9O4vS6T72OamP4Gp0oLWthTjgZqMEn8Hqaxfw3XHgTdWLAhZJ vNOAFY6WkHQWtbg4rtTy9EVA/q3m0LRP78HkRgMFtqdlBlTwDRm300n2ERdzYDs/3G9W dA1Ba+NjXPXtME0rbYx3pBJjluJAjATB5KWc6iP4PSMQA1ewHyFDULGomor4s9LVEIhQ v9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xqebAial/PxUvQ3x7+4RUByyPvCTdM4/Zaewy8REn3g=; b=qASb18DU4kf8B8UkyhMbxLbpzDcu3Gvo3H6rDrHzfVItenteVCbmPp7DQvD5+ie5Rs 4SmamRBYKJR4q5GR23N9+LNGgP1B64tritbZF0zKTM6eWukNMwS5e+6Isd4+jSUa+uid PlnHRSrpmRHx06lyG7RhEd8Nrw22cBAY2CeVNA+ndhrpO4Crr1OnISW4mubfJrnx3T55 /Ozi0VOjGg7SlkZqdcDNE93rVqEBHX36zDKPl038UDdUnQwA5dPUgJmNs26a90eDyUva bgN/Oj7T15MHmK318S0iqk1sLZVfaRf/ipBRWHDzZ+FellpoQbzx/280Z4/16f+m7vKi s0fA== X-Gm-Message-State: AOAM5317zYF6IOyj18/xuGPG3zVmOlyq6X/LLBOUEtkQCoV0yCrraGUw gRvhWE817p5uqzMYdOhavEW4mK5zphc= X-Google-Smtp-Source: ABdhPJyIw7eqiXGaYJ6UUi8zfg205/gHaSO1yNYTVWBN8ejx2F1ONjtA2jg18NkFnJE8nk+PVkgMIA== X-Received: by 2002:a62:5105:0:b029:305:324:17ae with SMTP id f5-20020a6251050000b0290305032417aemr2832898pfb.28.1626155616030; Mon, 12 Jul 2021 22:53:36 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:35 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 3/3] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Date: Tue, 13 Jul 2021 05:52:15 +0000 Message-Id: <20210713055227.1142-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_225336_790574_4113C353 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready yet. Silence this warning as the driver framework will re-attempt registering the PHY. Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Cc: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20210617194154.2397-9-linux.amoon@gmail.com/ --- --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 2aad45c55494..cf10bed40528 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops); if (IS_ERR(phy)) { - dev_err(&pdev->dev, "failed to create PHY\n"); - return PTR_ERR(phy); + return dev_err_probe(&pdev->dev, PTR_ERR(phy), + "failed to create PHY\n"); } phy_set_drvdata(phy, priv);