From patchwork Thu Jul 15 07:14:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yutian Yang X-Patchwork-Id: 12379143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5015C1B08C for ; Thu, 15 Jul 2021 07:14:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FBD461358 for ; Thu, 15 Jul 2021 07:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FBD461358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F24B8D009F; Thu, 15 Jul 2021 03:14:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2018D0065; Thu, 15 Jul 2021 03:14:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4428F8D009F; Thu, 15 Jul 2021 03:14:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 1C8EB8D0065 for ; Thu, 15 Jul 2021 03:14:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 04A89824805A for ; Thu, 15 Jul 2021 07:14:56 +0000 (UTC) X-FDA: 78363960234.02.53B4546 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf13.hostedemail.com (Postfix) with ESMTP id BA0B110078FE for ; Thu, 15 Jul 2021 07:14:56 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id u14so5060606pga.11 for ; Thu, 15 Jul 2021 00:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=mRV8T0Y7cNn0dZ1dErTOtwAnuaw6Z0Qy+uCvTtEyaTo=; b=vFtzqUBvmddAmZZqsG14TK4QWHXiT5KHj9HFC8vgyb5hrS2/dp1iWg8Xn9XR1PVMje RIbuEwx43xdyXeI3tmOlilqZnDIMbgOibBHvyTaSmaYLNFfz2oMkQob1ZXlRZZgYAiHs LAWwumRlpNxmON9Cq1aD18fpN9qTntofk5f4ADQCynWnEUntwteGhIwMTNjFhLb2B2Pp RrRlj7VYqj1N5iCTLftMz9i9xbHl3a97tsOyOvXouaXjECHyX8oaT2ZY3RwNha4UXRXn DZRDhgqamNZ6gJTGd1MdLTgr+mK1B1IgPwiOyw+z8nyzSw8v+r/TPT9r8sR0xVgUuY+n gGCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mRV8T0Y7cNn0dZ1dErTOtwAnuaw6Z0Qy+uCvTtEyaTo=; b=gkVoerlDwwLwFfjsHaIhR1U0RyF8lTMPkh2YBhSC8qtRSB6cPkvF1EcJzMbolV58ZT nlgE+kGhzz/eK5q0dixcSTaaD1c4QUTFykV0pvgoepIXoCH3ya2Vr3eGVPES8J2cAE5a ydJ03ACi61OSQeXznvFdnNu3UqkBCW01mvCXR8PJxfad8SjiQwBLaBp/Cda5jRXIL/qQ epkNZ6tTG02MkHyCqvKQmV3C5AxRIjvuLtcFnIfjFp20ReMJk69qlmSbE8aI0w0oKda2 iAFyobHDyOpfIsEjTm/qHPyJpdn5k1FSYo7Cndtt84Jg+J1zK5B2DKxhuZmrAr3aSqOK /2eg== X-Gm-Message-State: AOAM5316qmeEveYnJrc7DBR6zl1r8UK0sQbTE1wASqSUgrpyawNgcnYn BfL+C66vpsie4x45TTm6gY0= X-Google-Smtp-Source: ABdhPJz818Bcq5pfeU3/6FZn1KLD0IfUeAgA8NMe1CCFxf4XMCMK1xoX8WZMVpDI7FABGnk6AvlfXQ== X-Received: by 2002:a63:e0c:: with SMTP id d12mr1311771pgl.386.1626333295725; Thu, 15 Jul 2021 00:14:55 -0700 (PDT) Received: from honest-machine-1.localdomain.localdomain (80.251.213.191.16clouds.com. [80.251.213.191]) by smtp.gmail.com with ESMTPSA id o25sm5912494pgd.21.2021.07.15.00.14.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jul 2021 00:14:55 -0700 (PDT) From: Yutian Yang To: mhocko@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, shenwenbo@zju.edu.cn, Yutian Yang Subject: [PATCH] memcg: charge semaphores and sem_undo objects Date: Thu, 15 Jul 2021 03:14:44 -0400 Message-Id: <1626333284-1404-1-git-send-email-nglaive@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BA0B110078FE X-Stat-Signature: zftcc6ur7nffoux7zuq4ba5hut43siwd Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vFtzqUBv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nglaive@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=nglaive@gmail.com X-HE-Tag: 1626333296-191620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch adds accounting flags to semaphores and sem_undo allocation sites so that kernel could correctly charge these objects. A malicious user could take up more than 63GB unaccounted memory under default sysctl settings by exploiting the unaccounted objects. She could allocate up to 32,000 unaccounted semaphore sets with up to 32,000 unaccounted semaphore objects in each set. She could further allocate one sem_undo unaccounted object for each semaphore set. The following code shows a PoC that takes ~63GB unaccounted memory, while it is charged for only less than 1MB memory usage. We evaluate the PoC on QEMU x86_64 v5.2.90 + Linux kernel v5.10.19 + Debian buster. /*------------------------- POC code ----------------------------*/ #define _GNU_SOURCE #include #include #include #include #include #include #include #include #include #include #define errExit(msg) do { perror(msg); exit(EXIT_FAILURE); \ } while (0) int main(int argc, char *argv[]) { int err, semid; struct sembuf sops; for (int i = 0; i < 31200; ++i) { semid = semget(IPC_PRIVATE, 31200, IPC_CREAT); if (semid == -1) { errExit("semget"); } sops.sem_num = 0; sops.sem_op = 1; sops.sem_flg = SEM_UNDO; err = semop(semid, &sops, 1); if (err == -1) { errExit("semop"); } } while(1); return 0; } /*-------------------------- end --------------------------------*/ Thanks! Yutian Yang, Zhejiang University Signed-off-by: Yutian Yang --- ipc/sem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipc/sem.c b/ipc/sem.c index f6c30a85d..6860de0b1 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -511,7 +511,7 @@ static struct sem_array *sem_alloc(size_t nsems) if (nsems > (INT_MAX - sizeof(*sma)) / sizeof(sma->sems[0])) return NULL; - sma = kvzalloc(struct_size(sma, sems, nsems), GFP_KERNEL); + sma = kvzalloc(struct_size(sma, sems, nsems), GFP_KERNEL_ACCOUNT); if (unlikely(!sma)) return NULL; @@ -1935,7 +1935,7 @@ static struct sem_undo *find_alloc_undo(struct ipc_namespace *ns, int semid) rcu_read_unlock(); /* step 2: allocate new undo structure */ - new = kzalloc(sizeof(struct sem_undo) + sizeof(short)*nsems, GFP_KERNEL); + new = kzalloc(sizeof(struct sem_undo) + sizeof(short)*nsems, GFP_KERNEL_ACCOUNT); if (!new) { ipc_rcu_putref(&sma->sem_perm, sem_rcu_free); return ERR_PTR(-ENOMEM);