From patchwork Fri Jul 16 10:36:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12381923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 339BDC07E95 for ; Fri, 16 Jul 2021 10:37:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1009613F2 for ; Fri, 16 Jul 2021 10:37:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1009613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=46Th3YtQ/Vo4w1shtrLYgeUuEehaioQmcJtduxewB4k=; b=KhXIsmUv/cSBiW fOrqRw9IVQKjIe1Q+xgGT9H6cZnM5dmCkgMHXUlFBMxeVMkU7Bn07MdA+esPHq3zGsB4Mo3uYbq/w 8+jBn77z2n2xA7BwjuR/3JrbLWImrg3S2e+wcsZTyOaAWZmNhJ7C00y4WbsY7qeyI9MG4ib8En89B lA1v4Q6kuzXliLU4XtneDLTncu8fpqs62hca8GlJ+zp6JVol9O1hMaM12Uq9/Ub3T/cUoCn7ugx22 MtR49QWlXCyCadjkums6tzONGE9LlhEewkG+meiW0JwS22RTZUw1UdOzk6/K4MfLhZMgEnHRRRGdg UPRsPxFt/nEzB7qbOYww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEB-0048cn-9c; Fri, 16 Jul 2021 10:37:55 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LE7-0048XX-MC; Fri, 16 Jul 2021 10:37:53 +0000 Received: by mail-pj1-x102a.google.com with SMTP id b5-20020a17090a9905b029016fc06f6c5bso6779771pjp.5; Fri, 16 Jul 2021 03:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NOqh4iRv8bzMC1v4LkBjVvsD8Lkl7UjXzwLeX3pJkx8=; b=S+HZDh+6imXk19NG3CPuTcEbgILrztpxAmUk0TtpzjM7XS0iHTzqBM1cQOM86udfnW YeMeFqO9KZmtln4zin0hp9YkejLcs0SxhITpg4a3lIu6To685WU/rrTvBIim4KfQCkFR GUVr3WzXiAHTjcGdTAKs9yc4eQsKZXme4S2zeaz7xqfsY0uxtS38PhMRHqZIwscoNYvI ULNGGcNtKRcdm8tONmPoXIsduyt8h8z5mrX3HpT4LPtWKpmXSoQFTUKZqYQuw2E1GKjf ZHXqcGycinnFF+I/xUJfzpZwkXkxRJZlGZWsT9R2ba69iBc5vsNrsN2pJkn/AC5Lb6Qv h0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NOqh4iRv8bzMC1v4LkBjVvsD8Lkl7UjXzwLeX3pJkx8=; b=KdUeggV5Zuq1qE6IrmI3SzHDCZjeTPFMbiO8GIqDTx5zXp5ceUFbzN0AtGzCGV2HWP CtfqWqP/vdR7bEeNtmYj/r38pVWerD49GlV1gF5h2nlMyd6aX+ksZVQmea+W/f6OlENe vOYmZI3EGImAf1WN/3CUM0EF/XCHImhseqBST9Etd8eKZRnEZgQO+g/1vOFYVzlTfCNz +VWYT0HtUrIsIQ1jLay80ifx0Ot7JWDXargQQy4kFJoIAqrmgbDze293ZI8pXsg3QH+s 8WDD+SfOBnCbLAwYmnySQ9mnpxQDfJ2i46Y79hC+gDuxEzRwMFEilhajzZ98EDzurtrR rg+g== X-Gm-Message-State: AOAM533X5XgIa+KtUfpzoKzszahJklCmo8F7dybiO/h9vWBV8hZ9QZsQ uekhjUynRPrdooLI/3KPQCU/t6Uqiks= X-Google-Smtp-Source: ABdhPJzH+ZY1CMrp9Is4HwQkAVX+28YqBZJDdwXI/77fszRGkHSp3wSrVmA55QJTPYuYukJ2ugUzUA== X-Received: by 2002:a17:90a:658c:: with SMTP id k12mr14765303pjj.167.1626431863792; Fri, 16 Jul 2021 03:37:43 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:37:43 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 1/4] ARM: dts: meson8b: odroidc1: Add usb phy power node Date: Fri, 16 Jul 2021 10:36:33 +0000 Message-Id: <20210716103651.1455-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_033751_780716_00005284 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing usb phy power node for phy mode fix below warning. P5V0 regulator suppy input voltage range to USB host controller. As descriped in the C1+ schematics, GPIO GPIOAO_5 is used to enable input power to USB ports, set it to Active Low. [ 1.253149] phy phy-c1108820.phy.0: Looking up phy-supply from device tree [ 1.253166] phy phy-c1108820.phy.0: Looking up phy-supply property in node /soc/cbus@c1100000/phy@8820 failed Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board) Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- V1 > Fix the Input GPIO polarity from HIGH to LOW. previous version [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20190113181808.5768-1-linux.amoon@gmail.com changes fix the vbus-suppy to phy-supply, drop enable usb0 USB_PWR 2 1 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.0-phy 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index c440ef94e082..26e8f91e0950 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -32,6 +32,24 @@ emmc_pwrseq: emmc-pwrseq { reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + usb_pwr_en: regulator-usb-pwr-en { + compatible = "regulator-fixed"; + + regulator-name = "USB_PWR"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* + * signal name from schematics: USB_POWER - P5V0 + */ + vin-supply = <&p5v0>; + + /* + * signal name from schematics: PWREN - GPIOAO.BIT5 + */ + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + }; + leds { compatible = "gpio-leds"; blue { @@ -378,6 +396,7 @@ &uart_AO { &usb1_phy { status = "okay"; + phy-supply = <&usb_pwr_en>; }; &usb1 { From patchwork Fri Jul 16 10:36:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12381945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C744FC07E95 for ; Fri, 16 Jul 2021 10:38:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98C6B613F7 for ; Fri, 16 Jul 2021 10:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C6B613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r5V1RWYW4DGb1WeIXSZd1pdrhiC9O22g9VrtFG+WiGY=; b=OLM3zosmt2HM7Y 2KiC3u+LffQiBuJWvi7ow48/GVCx04WVwi6uFN6qwYg+mW+k4Cyo2qnNaHzNenR3NvYBO6gqd1bms 888tTomS4ftjB3oxuIr1cc0pmus3HwlWXKhTinnitjQH9XAQIinK4ul0OyHQisxtDzFCZtIk0eGiJ 3hS5qoym/8h72kXdx1mCDe8xtJzBA64sORNkI3ro8c8qw6cf9dUbUMZft8SEyY2qS3xZrKjhy4gyz YtAPPh91ClseQCxk51UpHTyhYzRdzKFyAXfoYNF1Bv4apAV0KytBFN0uFaretOOZJzz0Z19FiYUPP mNOzz05f+O07bB/DJDiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEU-0048jk-1Y; Fri, 16 Jul 2021 10:38:14 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEK-0048fW-6O; Fri, 16 Jul 2021 10:38:05 +0000 Received: by mail-pf1-x434.google.com with SMTP id a127so8552564pfa.10; Fri, 16 Jul 2021 03:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VmmdmkhCXO7AkJW07YrDSJja8AB+CMGTjyDZ72pZ3SM=; b=XLSE0l9iqM0FUsdbXgwyYeUrxZueBS2H6c7hqHRL9yloc2KjuRPsCFY3K0pJgN92Jl I9S81ExFA/RPQv40q29hoSSelFqrR9ivp1lUaAz/6Stwhu6zR8137DTnjOpD6NalZNyi tNm1WWPQbRBc7D6YJMSnmh8zapD4oxafFu7J2Bq2kMnAU8Ofu+WjuhZD+U8vs9Pv4ELL LaLf79ZEbZ5A/kLT0Jppqmff93zKY4Ku32+2+IZ0XR3Mpg9T7xqtH+0buG0S2xibGBaa zGQ+f0bd9lIJ5JmAcZpotR+I+V6rUUJKdn35klF80vjgtPpiDymMNs9A9u6abhyRMZLw Jz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VmmdmkhCXO7AkJW07YrDSJja8AB+CMGTjyDZ72pZ3SM=; b=nlSnlL52s4/nv0+POXk0I3tpz4nUQqAs/W0s1meB++x+29sF16W+OtJHZ5WwTi93HW XL7fBLmVppOnjLFqyfp/97FgSnYZ7MDKqayKZsDKO1sbbrlfzw73dA5/ij2QfD66Vs4c vxM3GNga0aNr7hK7R4/JF+ZXhZjwF5J5a3VoXQP8x1ZFd3XVbDu6VsHY78vAOkY5gvBV uLUHTFNOTd6UvgNFOA8Za0ayVaQWgNqS93yTZkMw1wkyHZ/8q6mAYL9X7aPBKtbD3fj1 yttN+SsKLj1M+uQ4a0bgqro6jM2rNazzZ0pYYlHw3EM9oYOBCQRoKZeviePSX/0JJBlb rIVQ== X-Gm-Message-State: AOAM533ZqScH9rXn1vRV9gppGQ/vEFtDxiekdaMuHoWxd0TQw3TTR1CR 0Ma5affmzmFguY6AGtDlXg7h7kovm+Q= X-Google-Smtp-Source: ABdhPJwcfKzs6LufNBOvTwQDhzOMXdnw2fdKAY5SkFQfRpvVwVTYBM5CiUo9KwmAaTJF9L0qBS4k9Q== X-Received: by 2002:a05:6a00:2:b029:32e:3ef0:770a with SMTP id h2-20020a056a000002b029032e3ef0770amr9954297pfk.8.1626431882813; Fri, 16 Jul 2021 03:38:02 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:02 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 2/4] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Date: Fri, 16 Jul 2021 10:36:34 +0000 Message-Id: <20210716103651.1455-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_033804_269316_6ADEAD86 X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Fix the chip enable signal changing from Active High to Active Low to enable input power to USB power. Also updated signal name as per the shematics. Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- New patch in this series --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 201596247fd9..3f4f16a5dedd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs { regulator-max-microvolt = <5000000>; /* - * signal name from schematics: PWREN + * signal name from schematics: PWREN - GPIOAO.BIT5 */ - gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; /* - * signal name from schematics: USB_POWER + * signal name from schematics: USB_POWER - P5V0 */ vin-supply = <&p5v0>; }; From patchwork Fri Jul 16 10:36:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12381947 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2511C07E95 for ; Fri, 16 Jul 2021 10:38:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83F4D613F2 for ; Fri, 16 Jul 2021 10:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83F4D613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aM4HY2RMROZsDRbR8gz/YJ5jVRfN4sUYPv88EDafdpQ=; b=OQ5C9TbFhbUWPd fam+KT1+d+3DLKyXtlgyhY5UcCL7yBcbYQMXjplUfUl0KlsoU+OdHVeH2/tzpizXg+bNAx5xIopOh beK3MPB/Kh//d50dGCGSOhtNY1LFufGnCmLLd3tPaOCsVg9PzZkFLUlsC2rxuMza5kQlAWsKmjE8+ vg58Ty8uiX/o0GIE4gW/jqOZ31LlJLn+LTC3yMH2DhIXghY4cdLbIsc9u5hlq7eQ0odx75j4eSGz4 udUNaekn+WGcGfJdYl/+tFcMB7+Y2GEGKc2/V/YwsuOY43hc5fnC/PjjlkDa8FU7omdGIYTMWUx9D cwHQHSTTTs/vsuiN/1lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEt-0048z9-QF; Fri, 16 Jul 2021 10:38:39 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEd-0048ok-8f; Fri, 16 Jul 2021 10:38:24 +0000 Received: by mail-pf1-x42f.google.com with SMTP id j199so8562897pfd.7; Fri, 16 Jul 2021 03:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ijibuOn1o/zyXxVK7//BA8fe5lpTivScoHePVnxddFU=; b=Qf9SOx6QD4X/slJCbBN3lWyDjpm8rnJYlFnSC/XJk+r2LL92hc6zo+WOtnP91fFVP9 tBS4WjcJvji4dkub0v6NU6k/wBh9Cz1PvNCFuH0oHzKURPH9YDtjlVPtskhmeYbMTej1 WuohWqOG/YtBzDZ3TZqFHj7G8FRZ23T682i3tQ3v1OCnl/E2ttkFVxvaipcM16pADatb dvdawIST8n+R8jieSnYb0y9oCqZUgwthwXXuEQnnF9nKqtfeSWdihPHE815Dfmrn8Pnv noafRwT/Ncmk3Ct4XeXxNL+ONmErwWKEEqs4a/TxDBib2LoSjDIWnCG4pRXMRbPWJVFU QDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ijibuOn1o/zyXxVK7//BA8fe5lpTivScoHePVnxddFU=; b=UqVi/BKto1iVecWogoiB1R5Te4r4wq0V5grBgpg+mbqe/2bnQAEtYVFFrAisT7ea8j if/TZrpTFR8t9nT1atYobuewZmdGNQPjWCU5/TdaT0a8cOFL7JWBTQg57LAHp+6+S3m4 tSOzFy1LTtRwUQQ8RVOIOHD5sCjcwyeS+Uoz3PJjj94DrBfXJSlqQn1RRTbePRqzzMOp BHD/djyPxLywMR3XDhq2bC8gdZP0jrn2Bu5HYAtHYLGe/CAKzXLWaLqvJBQ0YEd379NF /a7Dxd1CFkR58ZVwr2lF0WjnT3VD+zYugU7rfyKxMNaPrHkrb3jmWanq+2WYCmyXdD+S fgCA== X-Gm-Message-State: AOAM530dsEGtUBjJ3MvArT1TjIDByaw+YbwP4SIoQhunuAi34VIexWRu wHEIaONsFjtnrog8mpuq45Gq5G/mdtk= X-Google-Smtp-Source: ABdhPJwzFIVx2DLzzS7/EOrIoZqSrUxxZHYoV9gOL39E9P3TfTI27j0dDyl6BT242VupYDs0781MUQ== X-Received: by 2002:a05:6a00:7d7:b029:32c:b12a:d65d with SMTP id n23-20020a056a0007d7b029032cb12ad65dmr9602132pfu.44.1626431902028; Fri, 16 Jul 2021 03:38:22 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:21 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 3/4] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Date: Fri, 16 Jul 2021 10:36:35 +0000 Message-Id: <20210716103651.1455-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_033823_368841_38000354 X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Power off the PHY by putting it into reset mode. Cc: Martin Blumenstingl Acked-by: Martin Blumenstingl Signed-off-by: Anand Moon --- None: Added Martin's Ack --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 03c061dd5f0d..2aad45c55494 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -219,6 +219,10 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); + /* power off the PHY by putting it into reset mode */ + regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, + REG_CTRL_POWER_ON_RESET); + return 0; } From patchwork Fri Jul 16 10:36:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12381949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F238C07E95 for ; Fri, 16 Jul 2021 10:39:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D60D3613D0 for ; Fri, 16 Jul 2021 10:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60D3613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1uGH6IHtrT17/QVNb6ceBQTethQNjymMz/t83uxvomM=; b=nlShncimG2rO2t v5pAnRK83bsGUj7BsD1uC95tPHG70QV+PG7/lo97b17qwxG0M8sBfEqgSKq7QNhjsOQiZ1bRKTFaf pihTr7eezgm0HrJLRrrEuaPTtPgw9Gy2kGpRFrE+2JEHR4BfBpGqQ2iX2W6YtR80C8ov4WnFcML7h ndrlIa0nEAmMF0IDkL1LR3JBy+bp7mxvNeU7trZA9yz01ATQBd1beidTWpbo2bTdjfOI/jewlx5he HVIliDZzzt0exThejOsB36/5Ob99gfE/+MyjMA7AMDZ8OFO9jDiNNKzX4kD1NljqrLB+JP2/NHSxU xDS5dccHzAl1wWsUqw3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LFN-0049Dn-8D; Fri, 16 Jul 2021 10:39:09 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4LEw-00490O-TU; Fri, 16 Jul 2021 10:38:44 +0000 Received: by mail-pf1-x42e.google.com with SMTP id q10so8555298pfj.12; Fri, 16 Jul 2021 03:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w3d3QBhIUG9rULiQkPjmvB3VFugYPgFTgKGsQs/0OIs=; b=edMHLZZ9Joy3kORNlbb3fA7Oip6TpGrlESLPRoP4j3s+sAQLT1SlBoA6nDewPTbeVZ adOYB6al4mrObEuWESAJ8eKqdNEMX2eOcU/YxWBmqhLKf3xbN45sNRIeZKrAtBqyiz9f nX3dORJt+ID97uW4aq30eSU7zpLvGnWqQQDutpcN7gU5/m6ZvhDGcnZwvjjaNnqkhHWH TaAulTOhfwFITR/T+aDhl6mwTAAaYhoKE8723LObUi/eM/LbPvenJ3bIctfUxk92bowR BJ6DACx3dWU2weZVjdGuyk0HaB1noOWHalBTdjC8xkh7RLFCqkc388tyQMAjAHw2k4PS KfJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w3d3QBhIUG9rULiQkPjmvB3VFugYPgFTgKGsQs/0OIs=; b=FfStSLpkyrbjpXLX1Fw/m9rhchrNEHUYQWAjgxUHG/fAto1dPlOarQnFFh3RHtJFPI BCxl85M9KNK+xbfx3jwH8zLNqv7q/ZfDvZpchOYDiTZYkN7YzWxJWpjAeJ8OqVrJ+e+Z lo0cj6MxeHema8+Hv7gvQIANlIoWJ0LaahvBZSGNUsC+xkA/dQ9SGk1jCVI4qadKWsyd 5g3Etv4nFWrkRU8M2OueYxTUxRAQWv+0cqgKcopNtcMBRBNxiuTGgSSCH2LwvVRL7Dce pIubHdh0w28dI2CxGEu4h0iZS3F0S8U2nl1oZAMKabwL+D5M2fwYF5iaG1MfpjIW+RCe i9zg== X-Gm-Message-State: AOAM530ObTTBGFMCJa3Kss50w6fwlo3TpcRaxPpEEF/t1yBAh8VmJiek pyPRIVGdaRgu1f43m4WTryl7/1OHYIo= X-Google-Smtp-Source: ABdhPJzRs9l6a/USkfsyP9AF6K5QWyN3b48FxjpiD1pQ49VAVuin34TLdB+q2UIjut4p6GMWd5n0vw== X-Received: by 2002:aa7:97bd:0:b029:32c:56cc:8fa9 with SMTP id d29-20020aa797bd0000b029032c56cc8fa9mr9677013pfq.65.1626431921511; Fri, 16 Jul 2021 03:38:41 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:41 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 4/4] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Date: Fri, 16 Jul 2021 10:36:36 +0000 Message-Id: <20210716103651.1455-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_033843_057016_BCE5312B X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready yet. Silence this warning as the driver framework will re-attempt registering the PHY. Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Cc: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- None: --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 2aad45c55494..cf10bed40528 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops); if (IS_ERR(phy)) { - dev_err(&pdev->dev, "failed to create PHY\n"); - return PTR_ERR(phy); + return dev_err_probe(&pdev->dev, PTR_ERR(phy), + "failed to create PHY\n"); } phy_set_drvdata(phy, priv);