From patchwork Wed Jul 21 15:16:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12391265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73068C12002 for ; Wed, 21 Jul 2021 15:16:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 425B461246; Wed, 21 Jul 2021 15:16:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C88261221; Wed, 21 Jul 2021 15:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626880584; bh=Fsb/lO6EIVRYku98DmBHA+9V7KQlDJSWmeWTp5o1OA8=; h=From:To:List-Id:Cc:Subject:Date:From; b=B/XD7tgdnKEjKkJIhCNAOpgpA6u5CpE8s2vLImGVgzJanA7NvBxKzAAxYsTbcQ44Y W2md8saNb/+FjTB+EEfowd/uW2ebgwf4/4OrW7QflUiSAh9A+VCHA3aTEBxxXlM1NH ddHKkvhuzWijKlwNnACworQ5vmAtWW3s5oSqqWSVFHytefForg0+vyDapW4a0tAct9 L3nyysXOCFHQIETgGUcpn+FnHNZ7hrpzTvjCx1j8w+pIiLTgQJ2N93RtbKivslEARJ tIrfkw55sQjQCYYqFdPr509dK79nGl6Wl17a2bUHdQH24lJHZUjATQj4xxWfUax2fp tRCcVDspE9+uw== From: Arnd Bergmann To: Linus Walleij List-Id: Cc: soc@kernel.org, Arnd Bergmann , Linus Walleij , Imre Kaloz , Krzysztof Halasa , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver Date: Wed, 21 Jul 2021 17:16:04 +0200 Message-Id: <20210721151620.2373500-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 From: Arnd Bergmann When this driver is disabled, the board file fails to build, so add a dependency: arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit': arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration] 472 | ixp4xx_pci_preinit(); | ^~~~~~~~~~~~~~~~~~ | iop3xx_pci_preinit arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit': arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration] 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) { | ^~~~~~~~~~~~~~~ arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function) 231 | .start = IXP4XX_UART1_BASE_PHYS, | ^~~~~~~~~~~~~~~~~~~~~~ arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init': arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration] 376 | ixp4xx_sys_init(); | ^~~~~~~~~~~~~~~ Cc: Linus Walleij Cc: soc@kernel.org Signed-off-by: Arnd Bergmann Reviewed-by: Linus Walleij --- arch/arm/mach-ixp4xx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index bf14d65120b9..34a1c7742088 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@ -91,6 +91,7 @@ config MACH_IXDP465 config MACH_GORAMO_MLR bool "GORAMO Multi Link Router" + depends on IXP4XX_PCI_LEGACY help Say 'Y' here if you want your kernel to support GORAMO MultiLink router.