From patchwork Thu Jul 22 11:25:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 12393897 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D93C6377D for ; Thu, 22 Jul 2021 11:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A800961248 for ; Thu, 22 Jul 2021 11:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231712AbhGVKot (ORCPT ); Thu, 22 Jul 2021 06:44:49 -0400 Received: from mail-mw2nam12on2135.outbound.protection.outlook.com ([40.107.244.135]:13313 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231286AbhGVKos (ORCPT ); Thu, 22 Jul 2021 06:44:48 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZR/HzZpCq07pZHdOfGpbc9Sirb4CjcSs/eX39Tnc0ueMnwRCQd/gWOaG4jQykVIB69o5byPUHfjgXCoYkcIF/qMUw5oIV/L2Oe0heyK5Dup3CQfn22OYZBHbEVNfHB/OPLVMRj4BShDxjoIMkSuhJJsDSroHa2sjeRr/EcovD+txB4OtP+wJCNien+cmjMayN1Zg5I+0JXVm6dw0hEwb6zVtj8UWzYE7TbYEMLo4lRpFScACf65UVc08BnGm7mdCPcBqlnRzLaRaT5waZrRLtEIRMToau+fzKxLFrgWTV3jtimb9SQgjA4bIc3AzIr4+qT8VgzYAvl6SPL8/zmpBIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Df260Gzj4AukDhsjZAPvoQl9x1ZvQ4VnaNpctJWhrWM=; b=W1hvEvUX/857unPHvkMwBF681uVfDcpkoy0efmWeELWevah0A1yqBNHhOF/+NnVG/Ai+WsIpfLSuMnZz6tdpYHRF0kojaYFPYvr6cdh1BRFAWPLKK6ls7kkAboHNVbHQilswQdhM0FI1UON9pwOjPo3s98ujI5EtQkY12zBC6q8jtIKCbjiSJ48UbYN4CqicCkfbztzX7qqvx8ehOOGfOhIUq2FELCzr/NdYI1jlLK5bAGU57cdcJozqYDw1iePwWIYTqvJRV2fX7EmKXR7JBNNFnGJrTadWr5L86LqApuXFBcQetP7RUpQOUTN0Cn7MUkTm3li6kCzGNEA8UxnHhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Df260Gzj4AukDhsjZAPvoQl9x1ZvQ4VnaNpctJWhrWM=; b=hIYUX2X7RrCHc6gSzf4FWOWVJfMdARxZMUoBsgLxoj+1u7I5J2itO/iLbM/gmnsYZZ8q8BZrJ5i4CiA8a2ZxaVPwPsGZaYs0g6prfFJnOLLlfKR2Zi0O5JFLobC932KdSoft4ae2cpMRw3vy/UIvw1MIE4kUB9XXkQ0Zrf4FpDU= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) by PH0PR13MB4874.namprd13.prod.outlook.com (2603:10b6:510:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.7; Thu, 22 Jul 2021 11:25:21 +0000 Received: from PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::cd1:e3ba:77fd:f4f3]) by PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::cd1:e3ba:77fd:f4f3%7]) with mapi id 15.20.4352.024; Thu, 22 Jul 2021 11:25:21 +0000 From: Simon Horman To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, oss-drivers@corigine.com, =?utf-8?q?Niklas_S?= =?utf-8?q?=C3=B6derlund?= , Louis Peens , Simon Horman Subject: [PATCH net-next] nfp: fix return statement in nfp_net_parse_meta() Date: Thu, 22 Jul 2021 13:25:02 +0200 Message-Id: <20210722112502.24472-1-simon.horman@corigine.com> X-Mailer: git-send-email 2.20.1 X-ClientProxiedBy: AM3PR07CA0116.eurprd07.prod.outlook.com (2603:10a6:207:7::26) To PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from madeliefje.horms.nl (2001:982:7ed1:403:201:8eff:fe22:8fea) by AM3PR07CA0116.eurprd07.prod.outlook.com (2603:10a6:207:7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.7 via Frontend Transport; Thu, 22 Jul 2021 11:25:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5397bf7a-73ca-434b-6163-08d94d036433 X-MS-TrafficTypeDiagnostic: PH0PR13MB4874: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A/249ZUvKRn0Q+jv+Pcbl60avVkNKRx627xhF9ua7V1kJUeJqUjs6f4sRFSH4b6nINDItV4OJZSDQsAh2vBdi7gR+eOiJgm8tUecF23kATVJfCbgwHmqQLDqIzOBRYtiwn+DFJp5yt68/Bnp4UUOwy/+fOun2lmjvbdx8ImL2UXjw2E6zgh6eR63dBLhTh023ZjQV6MPASYPDhFIGZbJyzuO8owS0BZH1uNZ9V3O+NJo2HRcSPs+DKWifQYnoRxMM3AMBnkRPjLkAtWVG8SCeGvuhsv+UXKcjjCuJXetSpbyXkoT0tgoNkJs/R/HgfisXMIrJ31rYfDHrdfSFfnCBvFE5E78bKA9xK/Il0oF/VYTaDe9JWhCWWsVivMlXncXc8VdFkAEReyP3RwNgLMICTQsjT2fEEn7QjKe77qCzZm/ekr7OpDS9/82EENPyZKQaUICWdfHCCqXHcTrXRZtq4cxk59NceS7Ag4S4/uxrZ8KfJc65tKPrZfdzMuzjtqpvXTxdzReF7J1Capy8x6IpSb8ZKrsnxAr7c8gBd5BkCmGfpRtpl3txnkcnXd1+6n5Fo10spAnwDz+JWKeLSvbmP6dWxOX+bUVqD0CcgIX9vraPLSlDMWJVSut7hAb+47yea0ZmsLLotGosLILP9TeIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR13MB4842.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(39840400004)(136003)(396003)(366004)(376002)(346002)(316002)(83380400001)(2616005)(6506007)(2906002)(52116002)(6486002)(4326008)(5660300002)(44832011)(6512007)(8676002)(6666004)(1076003)(36756003)(8936002)(66556008)(66946007)(478600001)(107886003)(186003)(66574015)(110136005)(86362001)(66476007)(38100700002)(54906003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?wt16Wdn3CqiXOZ6zr/ATDyBrR69P?= =?utf-8?q?WpT7chs8/TGeLdZxvKh0C56Npwk1daH/ltx6zVQf2N9DS6gnSeji8mUwmMPGORFXc?= =?utf-8?q?sEZEODKbj/0H0oHlQ1VYK+cx6Dgs8yFZXDtaqsUKAGbo9VSD3ECw7XCWr+Jxf6XIJ?= =?utf-8?q?ij6Qy1FY5P69NBeuvZ12HdfDmU/XdbVghcIcLcNc0/u1TNia5WUb1uuNb9QvGQtCU?= =?utf-8?q?HLuJguVfJUah3sNxekIjQp+auMRsaKsgFIIRXIgyaDOUd6pUPQZDWV/w9sOEs6PWh?= =?utf-8?q?sxdvli+siDmLrTpvSGGbc3d8o/iSN5vkls/D9qkoX57DqlK5eo1pZ0T6NY9wXna46?= =?utf-8?q?EC6nPjr7zssGbxkUx2o9Q+ylywnHYSPsySQXVclLxC/eyWTFJ+rhjlfzleH6F5rwp?= =?utf-8?q?HwggRZ/lFNYVBBbzFPiMiI3S4DZqkzXLG3JHZsr364fpU9AhQl/HIdiSAdPu+jBgi?= =?utf-8?q?Xaf9dhfd8xwJDtocrIvP1R/fs+zwgCo+d64ZANlHNIIrzKa5zOoUIxfSsCsyRgFsH?= =?utf-8?q?tmKh55RAqJU7ygcZ7UL+HuNntxlnvzPjGJIY3FQv1mAuLWCd57BiUZJpGjJ8zNtP/?= =?utf-8?q?nGJipqVZMBloqatqNyqVegKpFpgXcFDEGcJY9Mljfg/5+aybd3jbEpYN5hbBOkjsL?= =?utf-8?q?izVLl0GVoQafOuNphNd4Hv9BnPIO+IKdM0FtAQgrCrwnidstXRTFy/HOoRJFofRiX?= =?utf-8?q?hxz/2O/wVEG3vyDXPHsiKySYz/V8BAUT4slGp+VFEpPyzffzYVzJfcxKpxO6NZ+lS?= =?utf-8?q?lqNPTY6mdJLnqyILQWv9faIIeMqxPcLjxvNXqh4YFlztYzRT8o8D3NG3V9mT1wBCY?= =?utf-8?q?Z0vCSrv2DbIeUVVyScD3+X8lRaWN6Mu7bBD4026tw8aGrRrS2eEfu84hRKQfyZPoU?= =?utf-8?q?aQr0uhoSe33HcaNVvUIUUpYRwNEagbZjqUc7P1LMQlQYsUKxqQGSaQvo6EpU0iGU1?= =?utf-8?q?cq/ZGZeWfR0GIimmXUiTYdnYLpsgjSPELHdMitIfyof3ymUVb6ZqrSBNBV3UOdiWw?= =?utf-8?q?uAzMW40APng3NIB4ougTR1UiklyiAt5pa+2NaQ4hze2FruAANL6O4jDglcKnEhmmA?= =?utf-8?q?aBIDAP5EU7/BK8CIFDdcMdbtRgY/w+uE4dWGrIo/9weicuGq4fitM3tMYXjldYmGZ?= =?utf-8?q?G0qKdWkAO18zuaPKmzJvQCFXS7WKv/umni93uIY3JLvPoD0nuIyxfoIbN3yIrEJM2?= =?utf-8?q?21rKgknLmopB2G9nZ67Nsvcz6DVpJ/FGks6h0pSKC6Xxhsu5afQ0pX/6p1QyoWF8P?= =?utf-8?q?PY+6UOAcV4+qTN+VXcY2cPMH4hbqfvRUiYqv4UD78cvQPUxAhhqHWiQaI3gwcUk9Z?= =?utf-8?q?x2oN5FGBH5Zta0C?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5397bf7a-73ca-434b-6163-08d94d036433 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 11:25:21.4270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0PoXYWenJHsgRO4s0foYY3NDkvcUIXpapteYQjgK489vzTuuK0HRouPD0cFSdCAilmugVHkygncj6LFtuyMDJ5c2nwaQJu+4S+Du6zihuzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4874 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Niklas Söderlund The return type of the function is bool and while NULL do evaluate to false it's not very nice, fix this by explicitly returning false. There is no functional change. Signed-off-by: Niklas Söderlund Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 5dfa4799c34f..ed2ade2a4f04 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -1697,7 +1697,7 @@ nfp_net_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta, case NFP_NET_META_RESYNC_INFO: if (nfp_net_tls_rx_resync_req(netdev, data, pkt, pkt_len)) - return NULL; + return false; data += sizeof(struct nfp_net_tls_resync_req); break; default: