From patchwork Wed Jul 28 18:37:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ojaswin Mujoo X-Patchwork-Id: 12406611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7818FC4338F for ; Wed, 28 Jul 2021 18:40:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 486F760184 for ; Wed, 28 Jul 2021 18:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 486F760184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8KkDqj8i2jSod43VywLlAE7eoLbJlYA/Sk20kyvAW2A=; b=Fa7t6S0sysJs3i IotbIjoOL2AEHwZaUsdYPDDamNgbVjID/eLuU+ZotOw2XdkJsrAqmR2rGktzg/8vTX4/yGwvcwDyL oAspx15rwH5tuIh799shzHjMtGfv8PDQRx1XubN6v6j4da5EZrLPzBi35MoLK0gvibH3R3kavScQ3 10ww6aMyNRyMjjOQBey7wGeviT92rYRgaXyaCaB2iMNFtOdCoJSmfnWi9v0kbRTnvEi0GRt7Oi6Jt E0iMj6Pl6MFP9/f/P89bRdLI2wq3H1xFJUW515EMJP23j6HFL8Ra098UJpg/35galC/PT0xQ+yjBG JvnDyrWsQGtJirGnVqeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oRB-00265P-UZ; Wed, 28 Jul 2021 18:37:50 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oQw-002611-F8 for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 18:37:36 +0000 Received: by mail-pj1-x102c.google.com with SMTP id l19so6607228pjz.0 for ; Wed, 28 Jul 2021 11:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/HKHgCMwSYNJz7C9WSRJXjjx/3uDyYNDVr+Uqu/p/O0=; b=K+H4NOT7UUHHWFYAg9yiWvijMB3jBRhq9RKDe4Sw0tUVoBlNSi31/H8Vx5dXnoGdtD qTfvdqJSIdoTA+uIpWBTyChw86bjNLBD8CY8bTwBdCBVVnmkpvtwic4uxWxvvNmokmG4 R+3J1v2qdBo9Wih4Cp4IAEU1TWGWIiaVdwLuyGrKZVWXr/DI+qdhRdeTIpfkXeOpcKPj b8SUUdghvlOlQPfzOgtvoCXNdMaz228nPiS/W8GAQJVC7KIz7SNw7Fvo+IvZWSfrghiZ s6JPVgpHlOREY5njZkFHuaURhMfo/SUJdgsLQON692tb14wxm3YvntBHFJIF9JvGphJh y5FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/HKHgCMwSYNJz7C9WSRJXjjx/3uDyYNDVr+Uqu/p/O0=; b=H8BQwIL70K6QZdfQk31PW83HHxyNn6EUfgRuU2nbttheoJJcXO7QGzK8wF5soNMHyX GMJ4UPg05KBEqQPRmtf7euzEM08cDl7RRNZxPSwm+ZfX2oqsUQuhmop8NRM3iJvQntgh RLOykrHma7tcFBLHE0rr6D9iIv3vw5DOwAVi6vIExA98/KxkWcAxxBlPegJZOSRUa3dm EpnYTAr90WX1/OE0h62nXVLeKj4Xq7WRW8uWju1OOzNpnL3dJ8TI3Su27vRUoSL25OOL 7oI/7Qxhul1GmjpMtCRdEATNKNWCvOiW0xUDcTPpgHlgpMWg2MdWmEvirfH6wgFTGW9o hEHg== X-Gm-Message-State: AOAM530iSJr4fqmWLo4C552wE0gDggOFok2+gSpDt6726yTuDz4Jcl4p w1ZapZnLAorhVwQWfJSsek4= X-Google-Smtp-Source: ABdhPJxO/VUIURLhsLeGRJkKZNHkyUMtKDGzQDbiP1kpXCHURdEVsbtOYulN+6SiojOs3ii1soumqA== X-Received: by 2002:a17:90a:4306:: with SMTP id q6mr10667054pjg.202.1627497453542; Wed, 28 Jul 2021 11:37:33 -0700 (PDT) Received: from localhost.localdomain ([122.161.51.5]) by smtp.googlemail.com with ESMTPSA id t71sm559021pgd.7.2021.07.28.11.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 11:37:33 -0700 (PDT) From: Ojaswin Mujoo To: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com Cc: dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Date: Thu, 29 Jul 2021 00:07:16 +0530 Message-Id: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_113734_554974_62D48517 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Before this config was defined, the cdev used to be created unconditionally. When an earlier commit introduced this config, the default behavior was set to disabled, which might surprise some unsuspecting users. Hence, make this config default to 'Y' to be more backward consistent. Signed-off-by: Ojaswin Mujoo --- drivers/staging/vc04_services/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index 63caa6818d37..2b70c37cdd09 100644 --- a/drivers/staging/vc04_services/Kconfig +++ b/drivers/staging/vc04_services/Kconfig @@ -23,6 +23,7 @@ if BCM2835_VCHIQ config VCHIQ_CDEV bool "VCHIQ Character Driver" + default y help Enable the creation of VCHIQ character driver to help communicate with the Videocore platform. From patchwork Wed Jul 28 18:37:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ojaswin Mujoo X-Patchwork-Id: 12406613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3B9C4338F for ; Wed, 28 Jul 2021 18:40:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 800286103C for ; Wed, 28 Jul 2021 18:40:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 800286103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qh/x+PWqIYQDl0FWmVQ7AENciHltNMvuhvS1fdYRjv4=; b=nNJgLS3T2nePXP Hv3Gh2JvB/UwzzHdfgLy2TjARN6y9ucbqjXHZ0BQSaa/ofD0CkXFy2cSqRvxDm6enR6dI3d/NXSxn JrXU6H+uVQCBf8d9HoUPtY3niuIuQwXl22gKFuTQUYQh7EOfK8cIwHlceIHr2yNGDCwXhntSCY5sZ vep9Zrca35Z74OCDPUYKQyH6jtZvQSApenpMyzaH9pqoj/iT/FPr2z6q8ndsKY4fbeNsp7d5yTCZ8 wqY5wTnHa97ukLuVlfZG7weZJwSLOvwmkLde+VFYIh/5z6meUC5HTNFvrAXq/RfGdTABBpLW0fB6g P1DIDxh3l2q7EydP7SfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oRN-00267K-MW; Wed, 28 Jul 2021 18:38:01 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oR0-00262e-1r for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 18:37:39 +0000 Received: by mail-pj1-x102b.google.com with SMTP id m2-20020a17090a71c2b0290175cf22899cso5488295pjs.2 for ; Wed, 28 Jul 2021 11:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U/GUsHiEOi8pxx5BgkWQTDzqvSb76Y9K2dEa3vpQ2Ew=; b=bEB2XxcUOEeJcy8i/cl6wtbs8VTUqJWxy5q6ELQJfiH3MWg7tTFr3J8MAH4UCbj3iY 96CcsaP75w6R3VmXObi/aZOddKA7ILsBAle+0VekhsgEQDrB1grYlhzmOH0vA0LmDiyy HuVH+lZhAg6z7ttsa+VaL1s6wj3cAnHidYeX2Wsw+X9Or2E3A5Zb9NIrkfC1+B8N9rY4 KhL5j+aH/5iYC3+OKu0zRocNPdB00ZYp3X3jQtCYbh894F1mfhRydjdEQPgGZREk6dYx V+ZnGO8qmh6tHwzxr8XgI+izgSWjHQisosM/hCC4ucXAdjCyhVGVUV37xHb/1TXb4qy9 bkog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U/GUsHiEOi8pxx5BgkWQTDzqvSb76Y9K2dEa3vpQ2Ew=; b=GnoySSG1LO3dlYdLAMuVSMSgJ0hrWY25bYW6sfwUN2ZIpNJtnAIVlfiiTXznbxonvQ R+Wf+6ufp2GSD1iT0jdCiTRBgXDFt2BJ7tODZXruQNXYDFGw4d6ZH3bL+n1MFrkJebHV SVfroxeAe5BWW0KWomHngvHnaCjwPflQJKzn1ZRTcvay9x9Yp7TL3EnZDq446JmdA2uw 0iub/ab7UhcXipPHCqoZASx6ChIqlO11EOZ/Yr/f6HWNXKZXEDB3xJKTOijW20S1Wa/F SO3xmsGzZBZAkWDb/p9hfbwXBEXrBO18qq8MgcyWmLhSpoTOSNMWu/CiQ9lFc/Lm//Ru hsXg== X-Gm-Message-State: AOAM532yJ8CtGbWkRnvCxFI9COcWj16gcy4PrOMmnQi0cA2GYh+7chKm /lRclAaoEhTsVnqaar17wBzdTzGjdnw= X-Google-Smtp-Source: ABdhPJygT5kY4Hvlg3aGDih8JDsDffrs3sZtH2XQFUbSav9nzRcJOojn5hMrR0Prd3c5qrIiH2JA7w== X-Received: by 2002:a17:902:d217:b029:105:e265:65c7 with SMTP id t23-20020a170902d217b0290105e26565c7mr1051678ply.16.1627497457076; Wed, 28 Jul 2021 11:37:37 -0700 (PDT) Received: from localhost.localdomain ([122.161.51.5]) by smtp.googlemail.com with ESMTPSA id t71sm559021pgd.7.2021.07.28.11.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 11:37:36 -0700 (PDT) From: Ojaswin Mujoo To: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com Cc: dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: vchiq: Add details to $CONFIG_VCHIQ_CDEV help text Date: Thu, 29 Jul 2021 00:07:17 +0530 Message-Id: <9c9c128b41e31d6bebe646e052aa05c44b19eb83.1627495116.git.ojaswin98@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_113738_124684_A738A2C5 X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add some details to the Kconfig definition of $CONFIG_VCHIQ_CDEV to help make the motive behind it a bit more clear. Signed-off-by: Ojaswin Mujoo --- drivers/staging/vc04_services/Kconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index 2b70c37cdd09..cb02d8a4cb74 100644 --- a/drivers/staging/vc04_services/Kconfig +++ b/drivers/staging/vc04_services/Kconfig @@ -25,8 +25,12 @@ config VCHIQ_CDEV bool "VCHIQ Character Driver" default y help - Enable the creation of VCHIQ character driver to help - communicate with the Videocore platform. + Enable the creation of VCHIQ character driver to help communicate + with the VideoCore platform. The cdev exposes ioctls used by + userspace libraries and testing tools to interact with VideoCore. + This can be set to 'N' if the VideoCore communication is not needed + by userspace but only by other kernel modules (like bcm2835-audio). + If not sure, set this to 'Y'. endif