From patchwork Fri Jul 30 04:13:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B65C4338F for ; Fri, 30 Jul 2021 04:14:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC8DD60FD7 for ; Fri, 30 Jul 2021 04:14:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC8DD60FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x/YjQxef9CNBnyPWcq0uhJuDW7tu1V7VN5Rvd5PTvs4=; b=Dy9K+RdR0WiuPR 38YFPcCwd0IDVyEyrsur9P+z5mU5xyv1h1PysnkPxyMlLrQxjCtN8fOmf1SXnpZshjAV5i85nP3e+ IqMnFB5j0HBRS0wBUf5l0cLHHvIfxeI9qYjQoqPFzhcyAuqQhQU7aB+dR8LmGsUR37S17XgldPseT CGt5Xx4nTpBmZ9wLQPP5jOylvVSd4XrDxcVv0xSX1LmrI0aio06ID90sgI+zPOD9YC8LQ4zd//hfW 0V0ZFD81pcq12rcJxTPKKUBqxNvbD+7UqrnuRCSbSqwN2x4zuMPWmdInzOFukNBhAnRebU60IHISu IOykEp0YySm7TMmMECsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Juv-0073Ow-Bp; Fri, 30 Jul 2021 04:14:37 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9JuY-0073HG-N3; Fri, 30 Jul 2021 04:14:15 +0000 Received: by mail-pj1-x1029.google.com with SMTP id nh14so1539648pjb.2; Thu, 29 Jul 2021 21:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AoyWEpL0YVaQE9+ONyJr4LFablmBYJyxFXjy9TOBNNM=; b=e4g8fCwQWSMiPKyMS3xOy0kn8ySE15HVD9klYxHd0iWkDDCAhg5u1WiUT7OZgaoWOz WP4rgRiC7L3WdQL/FXiN6QIMaK9Iu60ECweg38Nqysz/PxliK2vQG7UngRyZabypHCoy jB5gdbbQJRakgljm3aaHZBlDj6JqC69f1zIw88Y6Pqpla906qN3Ny0mPSgHWbWcbu+93 tiSM0FfmpwjET5hATIpcxPJcvkLZ6awmz8H4wt3S5gdua4HVJto2VRUumnAawsznE6Ss skxEt/Lp3eVLaV2U3mfw0Sl2nmByonaf0My4XQRa5f6+Fbr+/0stDORGFfRgRSr7A3nL ZpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AoyWEpL0YVaQE9+ONyJr4LFablmBYJyxFXjy9TOBNNM=; b=osJ8WgpCkMpn+c3F1ugf6rKVINhs05ypa22wVEWIg1niglGtIZcdeM+Iquemnketlm /FL/dpJw0d4zlO7GA49UerMKt4q+H8scx2XgBLi8uPu+hRPx110Y8iL+MazCM378td+S D79MP/5lZEODhoSq0m73Z9eejBOCNMSo7nlVXSO9Ouslned1NSEXFo1rfSleNZF3bfId pcSLArQ+snlhd9HvmUJjR7W7LsMkMxjArTbIIY9wRJd4jWvDxiEhav4PhJBy1Nd2g7EC 2g308ugmcTDpyofZ5WYU0BiVw2/eqFfTtyWNjp58lJjUoU7cC7lY5Ebd4HkWp9+kUSKo y9Uw== X-Gm-Message-State: AOAM530rFt5sApuZEuCg2QOMVTIkjLpQI2AuU/SVNsFERDAgSADMc0X6 x6SUc9WpLptXlNHaM9VG1k8= X-Google-Smtp-Source: ABdhPJwx/PToy3FwF3WwEtnts+RJLI8IjXehkAeFuBJIPYUzM3QTFrLsAXSHWvmAw5W+PHEUysy22g== X-Received: by 2002:a05:6a00:26d0:b029:32d:7d40:5859 with SMTP id p16-20020a056a0026d0b029032d7d405859mr593191pfw.76.1627618454004; Thu, 29 Jul 2021 21:14:14 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:13 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 1/3] watchdog: meson_gxbb_wdt: add nowayout parameter Date: Fri, 30 Jul 2021 12:13:53 +0800 Message-Id: <20210730041355.2810397-2-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_211414_791739_495E202E X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Add nowayout module parameter Signed-off-by: Artem Lapkin Reviewed-by: Guenter Roeck --- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 5a9ca10fbcfa..5aebc3a09652 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -29,6 +29,11 @@ #define GXBB_WDT_TCNT_SETUP_MASK (BIT(16) - 1) #define GXBB_WDT_TCNT_CNT_SHIFT 16 +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool, 0); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); + struct meson_gxbb_wdt { void __iomem *reg_base; struct watchdog_device wdt_dev; @@ -175,6 +180,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; data->wdt_dev.min_timeout = 1; data->wdt_dev.timeout = DEFAULT_TIMEOUT; + watchdog_set_nowayout(&data->wdt_dev, nowayout); watchdog_set_drvdata(&data->wdt_dev, data); /* Setup with 1ms timebase */ From patchwork Fri Jul 30 04:13:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB6BC4338F for ; Fri, 30 Jul 2021 04:14:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E69AA60FED for ; Fri, 30 Jul 2021 04:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E69AA60FED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tqx87pGklioYiPTvH+fiVA/FAS90/LVlTKA1mS+pPlk=; b=CVURVipgOtezHB /+JMNNyWZ2q3QLDNeNwvXF4tfTKS4rknwiHjfthqK2IwA7rrxPB5cjlQT9KkVc1LYScC3CZ+P96HC BEpK0ovO3wO4pY1qy69hsgdmg336KH2F1WL3bRlVyrh49CCNYp9W4yIuwe16Aerq5+2RO5CO6As7T m/BuO5cnLH5SJ8I1oXCClk+M1/tQRTFsEW54STvjGDfGY46xWAV/exQVf+CMEGkrWpI0LZRsCbSld hywWYSjy6d3WK/Pxs9OjMlcOW+IYUaARWYVK2pXHY+qfcpprww+1e2R69lQc8zRw2MBE5xly4g3dU wTCpAyeAc2HD3l0Igx6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9JvA-0073Vg-2C; Fri, 30 Jul 2021 04:14:52 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Jud-0073Ij-TM; Fri, 30 Jul 2021 04:14:21 +0000 Received: by mail-pj1-x102b.google.com with SMTP id k4-20020a17090a5144b02901731c776526so18869239pjm.4; Thu, 29 Jul 2021 21:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CedIVTVLdu/lypJPj4Dg+lxWwqXrdBZt0BeM9wWDGz8=; b=jZ6MhW4oRJotCzmn9yT9MzAXcuBUV4+57oKI8XRLcj5BfUBrWhl+uwGd7F82BKF8pf 2c65NwcMmRf/nSdIRKYUcqzqhtpou4abeb4Ybc+mn06aHa/21n5HQeCL2pKcGd57TBxz ZBYpPZbt4axbS0We7eLYBb9y490YVQkggWcgf+PFyov6L+VmI0HdFmqNt34ih3C0VqDK N6US9Tbo10ixo3qPxXM47CupTy23gPjLzUlmkaA95zzCItYAd4TQyEb8tc6I99/Fz9Pk diUucro3uDhnpqsaxEXmbvJJs0NUwZn426AKrqMZROSxvv20o5uRKGsBIQXEqMpo4lgP Z4/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CedIVTVLdu/lypJPj4Dg+lxWwqXrdBZt0BeM9wWDGz8=; b=sr28C5ujcWS34aMqeSo7zmP2ucwC45l0YeroyPcwQztBclrk9RuG9/6WS49+kRipOb KYnterCMZhmVfKTV7hne2nlVmdO/YAK5R/+NK/lkZILTD4QgV1RGDpfA2yE5RwHz/+1Y wKgd6t6i4BXWcW1hQtwzeadTJeaO8u57dd5BF9+GNK10NbE311S4Sj26dVapMHX/bkP6 NsnDXvPLdFvVb1DZJy8JvM59F7LKybqaYK+xRzi6TYnv5prg74h7oTcgE8p+bL8+5cQR KSDpF/fwZ6sjTw9Z5/H0kGVs+fjw++CfnffQ0a/EjL5AiDNoXzOdHPzz1z4PMLo2NjTx kycw== X-Gm-Message-State: AOAM532DlgQUwcFTGIuXKCTcdPXOdYudtPGEpoyNpK1tr8Pmcj5rJDSm vL+2SkD9ullgRpgvHKJ0IDI= X-Google-Smtp-Source: ABdhPJy3kNbcx3oc1mWZ4cBWSGRz4ql7ZJ9dNzE7MfbESnJvcd7q99M/D3ctid0xDHHp5sx1BUSIlw== X-Received: by 2002:a05:6a00:1352:b029:331:afed:38b5 with SMTP id k18-20020a056a001352b0290331afed38b5mr793450pfu.5.1627618459222; Thu, 29 Jul 2021 21:14:19 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:18 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 2/3] watchdog: meson_gxbb_wdt: add timeout parameter Date: Fri, 30 Jul 2021 12:13:54 +0800 Message-Id: <20210730041355.2810397-3-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_211420_005535_2129A247 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Add timeout module parameter Signed-off-by: Artem Lapkin Reviewed-by: Guenter Roeck --- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 5aebc3a09652..945f5e65db57 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -34,6 +34,11 @@ module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +static unsigned int timeout; +module_param(timeout, uint, 0); +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds=" + __MODULE_STRING(DEFAULT_TIMEOUT) ")"); + struct meson_gxbb_wdt { void __iomem *reg_base; struct watchdog_device wdt_dev; @@ -180,6 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; data->wdt_dev.min_timeout = 1; data->wdt_dev.timeout = DEFAULT_TIMEOUT; + watchdog_init_timeout(&data->wdt_dev, timeout, dev); watchdog_set_nowayout(&data->wdt_dev, nowayout); watchdog_set_drvdata(&data->wdt_dev, data); From patchwork Fri Jul 30 04:13:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44F1C4338F for ; Fri, 30 Jul 2021 04:15:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BE936101C for ; Fri, 30 Jul 2021 04:15:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BE936101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qsKgoI+cgoxrSN4S2wctg+Gx27pH8whNG+WKOKXcMzQ=; b=atTMNhmPC0Os+E eSuIMzU7QQABYPPtmezTf9O/6l7/V+h9TYalPPNHi4KP85cZR6qczW+3KVzJyajXGv+uEaZCgtPdb J+co4nibTa+bx+jhFHBBqD1Tj3Q9y0hjj+xqK5E7s/fpPr1qr5keqXMghaTaFiGFjdAhsH6nB6ejb H/pyeqTSOaDQowbnshKTEMM5f7OL7xUWDNYzWJB1b/QHG+CSV3oav/zdOLn3jR/hGxGhafFMh4+FF Jp2/ieU5yZN5UgVc0agIt/e+zeg5DIbGfj5YS8bbQczhJ3B6uo/TOMivsIQSIZXDhbA5Fv0VBDlpq SgDuckwttj+NSHxoeaNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9JvP-0073e1-8L; Fri, 30 Jul 2021 04:15:07 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Juj-0073KU-Qt; Fri, 30 Jul 2021 04:14:27 +0000 Received: by mail-pl1-x635.google.com with SMTP id i10so9552415pla.3; Thu, 29 Jul 2021 21:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=THlXvdugKjy738Af7uzCz/sE8sNAleTeISkp07PWT4A=; b=H35Ors0FFD34qtaXeNIP4c1cwPkkHP4ht1nwzgRtEWswKY8aa7wM0bzDdrblMnMRiE Fcuxs+17mCV4wQSM7/e6+MN730M2l6A5Jb0b0SuEHDsezAOw/q21R86m+3D9jXMRLrco Y0HtifeTjE6szdCS6sbtte1nvlYq8DLuhUDzhzxzzOMlZwzF23VOCxGx/FxAfVrcdZe0 YTuS0LMXEgs/i3yBPygZylVqAYYj4xioM36QXq+RXoBBwQM/vHbhNwjQX28zMUtfyplX iRGU3qcPingRUYPqlWeh86+yOmTZgC1hcdKt+xURMvWVXmoE+JvLGPJuo40vDaR7vTPC twaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=THlXvdugKjy738Af7uzCz/sE8sNAleTeISkp07PWT4A=; b=SsBQB3hnayP8m76CBHdvdemljU62zL33sWerr3VHkFcvrbNtjohH+4yB/zDgNhSPYA LodRPZ756oZgRrLYyXondgZg+DYyHXZg1fw6U7WctD5vAzGyObyhjG/+/6K1GM19adZJ KNX81Zuj3/CboR/YZy4MLqAwrZ9cjDWO5kUrTelSR95NDz5NUnDdaG6QYxYfw4T5snef wI9bZyFyIal5F96sZS1hjtpHizKhfSRsbDvtbb5NTV+W+n/4h3UCD0/pKNVCeiHz7JQd PjeMge4iNRWbGLt4RZ7+27GhlbvfyTbtWEOqTHkhLzvsh4aTcw2UaneQRq5uOVjOhsLB VEqg== X-Gm-Message-State: AOAM532wc2tZDHK41o66we1dKMzIkFLjKLgcBYvgtq5rzxT4eIzizuJl sg7c+tDlyXz1J0Xs4b16KUU= X-Google-Smtp-Source: ABdhPJxvMMQTQ8ZucVsWnf6w8qPI5/FCghjRAAqBf7VfGnkGVfCSZ1aInLllbvRQCIWqY/rqbG7lDQ== X-Received: by 2002:a63:1f5c:: with SMTP id q28mr527713pgm.114.1627618465126; Thu, 29 Jul 2021 21:14:25 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:24 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot Date: Fri, 30 Jul 2021 12:13:55 +0800 Message-Id: <20210730041355.2810397-4-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_211425_931545_5835A33C X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Remove watchdog_stop_on_reboot() Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default. I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process. This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not. https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@khadas.com/T/#t Signed-off-by: Artem Lapkin --- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 945f5e65db57..d3c9e2f6e63b 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); - watchdog_stop_on_reboot(&data->wdt_dev); return devm_watchdog_register_device(dev, &data->wdt_dev); }