From patchwork Mon Aug 2 12:58:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mehta, Sanju" X-Patchwork-Id: 12413915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763AAC432BE for ; Mon, 2 Aug 2021 12:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F4C760E09 for ; Mon, 2 Aug 2021 12:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233853AbhHBM6w (ORCPT ); Mon, 2 Aug 2021 08:58:52 -0400 Received: from mail-mw2nam12on2075.outbound.protection.outlook.com ([40.107.244.75]:40129 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233702AbhHBM6w (ORCPT ); Mon, 2 Aug 2021 08:58:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCgO0LvxO95DbAz7Tv8jsMeBKs47yPndr4U+xqxseBF6L0aKFBluAXLqnz5T2LsW8nBKw9yi4uecWDZRb9KeR4WbRvwuow4/z0PkpnCL4f0A9f7TeJgis+vw+CXxwiOfKmzAUO0g887FqBW93OYvz+Nb/qyUC5fwkUkbDlCT1fv6m/K1numcxa+vCq2vldq9o8EDGNxmPTFWJSMNberWfPqqe7mjZL0i6+IgEJfh6II35WibDBNEmPG2G32NC9b2VAPwwzcfa3avvEW08bLxhKzzduAyWAkJuUCwr4lKqjxpQz0INnc1ppUlrj62jlDRE8wHE5ZBNqTQ6VQwas24jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVC4Ne3ZupFMW1StyoZIpu2L+Qt776R3tU4D4x5NkYQ=; b=QK4QkHKMwgcqxo2gFNxwStqbhr6tvDkSgux2H6dKGSXPX+VdT2nI54LXZqgC3DcS228TPmlSALEsKiEODFZN38Lac75FjZnfZEsRzchQi5U9+WnKWbNvLQ+sciVtFIbxYIIxzxcXbs0NmvTDq0Jc2NU6DW/n+ZdnM0MsCkUQR1VJ9DgNx+9PyTxnc+ujSlk+/59kmw/10xrnWmOeqItIDlW4EYe4xL0T8I78BCSmejbIdZ+svzUz+Th6svtX453L2Lza0wAMI9eNIjYXdgPlhpZ+xxIQWSkmr/iNJvqLeCUZaD88KBOhu8zHolxzIagfSkOMTzwpVZ35ZKRju44ABQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVC4Ne3ZupFMW1StyoZIpu2L+Qt776R3tU4D4x5NkYQ=; b=lEZXSN6G+uDxOVJx5NLe81d/wdvOklAHOC83wl+weN04BVz0pWJivdy6Unv3FWyYjznoyJRkMGlJSpC9VKomZ3U9C4PaxVQl3J+zm1iQpaFJLpJvhtATB65uyKr5CzQZ96I43Ok1/AiFLdSKGVZRw/gzfpRen9IOnn6f/7u4HS4= Received: from MWHPR15CA0033.namprd15.prod.outlook.com (2603:10b6:300:ad::19) by CH0PR12MB5025.namprd12.prod.outlook.com (2603:10b6:610:e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Mon, 2 Aug 2021 12:58:41 +0000 Received: from CO1NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:300:ad:cafe::89) by MWHPR15CA0033.outlook.office365.com (2603:10b6:300:ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT008.mail.protection.outlook.com (10.13.175.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:41 +0000 Received: from sanjuamdntb2.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 2 Aug 2021 07:58:37 -0500 From: Sanjay R Mehta To: , , , , CC: , , , Sanjay R Mehta Subject: [PATCH 1/4] PCI: Add AMD USB4 host router device IDs Date: Mon, 2 Aug 2021 07:58:17 -0500 Message-ID: <1627909100-83338-2-git-send-email-Sanju.Mehta@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> References: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed616601-0cca-4fc9-6f89-08d955b540a6 X-MS-TrafficTypeDiagnostic: CH0PR12MB5025: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Kx4qVDiCut6cXTBukuCcF7iy300kV8q2nWYttnCWYg5e+kDjkhIix+1x/eZSvsnelDMCQpGsp36rahPSASeArGVWVqb4mjQmqSUcFJabPoq99+nOyjkm6UT9Ug3OdTLjclpwziuWaVxQ3aT3EdnTsTMnQH+xUmz2kA+Y/xQW9H241g4xyXgzE351DR6/0QsGrxrBBoTHvdXHfTNtUePcXr7g6WsRWMZQ9+YmK7pJiJaDrU4BapY2356gyFiNCcTPbtD0gC8RojBV/qsk0hWS1ybSYuqVbBffnq0fDDqBW+8AfWF+c220gc/EK5ZmDy5oIpJXHqYx4+LNhfn1nQdaarycSHd2rFl9nBhiEktjVOL+WM7WGTUF1VmSDEVThoWVHxedytWFbjgqLNUMZpV31yj8PafYAz52p5MBmWJAcOjcn56+JO1bcC7TykgGj0X2nmaQ02vNygSAw/8iAVJVeSVxiXmXETSJlzGgl9XVIty7kRCjVoJPyPiy21Rmi2ePXMalKx5QnGHcDZZ062t1dQSl2dBfiI2AKNMuXpfyaSRysUfZHI01IRQiCw9/xFX6FjQcMjCygS0aAZ80+NZVZIv61OZKpFLtzTC3wkEFYJjxOK+BrJe8B1KlBt0mccVL06mYxwYaUi5o0QQRTWBQdm7/n4TiKfBC9/rfMyQUKyX8hxYslmPbm4PEY4agov5yLmo1rdqz4E68mbfYXUU/I2O04PGMxSy7PsT2CCXBM4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(2616005)(110136005)(82310400003)(36860700001)(4326008)(26005)(81166007)(7696005)(70586007)(5660300002)(8936002)(66574015)(316002)(70206006)(8676002)(6666004)(86362001)(426003)(47076005)(16526019)(336012)(356005)(36756003)(508600001)(186003)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 12:58:41.0127 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed616601-0cca-4fc9-6f89-08d955b540a6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5025 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Sanjay R Mehta This patch enables support for AMD USB4 host router. Signed-off-by: Basavaraj Natikar Signed-off-by: Sanjay R Mehta --- drivers/thunderbolt/nhi.c | 4 ++++ include/linux/pci_ids.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index fa44332..d7d9c4b 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -1338,6 +1338,10 @@ static struct pci_device_id nhi_ids[] = { { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ADL_NHI1), .driver_data = (kernel_ulong_t)&icl_nhi_ops }, + /* AMD USB4 host */ + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA0) }, + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA1) }, + /* Any USB4 compliant host */ { PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_USB4, ~0) }, diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 4bac183..6d50019 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -604,6 +604,8 @@ #define PCI_DEVICE_ID_AMD_HUDSON2_SMBUS 0x780b #define PCI_DEVICE_ID_AMD_HUDSON2_IDE 0x780c #define PCI_DEVICE_ID_AMD_KERNCZ_SMBUS 0x790b +#define PCI_DEVICE_ID_AMD_USB4_HIA0 0x162e +#define PCI_DEVICE_ID_AMD_USB4_HIA1 0x162f #define PCI_VENDOR_ID_TRIDENT 0x1023 #define PCI_DEVICE_ID_TRIDENT_4DWAVE_DX 0x2000 From patchwork Mon Aug 2 12:58:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mehta, Sanju" X-Patchwork-Id: 12413917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E1DC4320A for ; Mon, 2 Aug 2021 12:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E197360E09 for ; Mon, 2 Aug 2021 12:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233802AbhHBM67 (ORCPT ); Mon, 2 Aug 2021 08:58:59 -0400 Received: from mail-co1nam11on2073.outbound.protection.outlook.com ([40.107.220.73]:2048 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233752AbhHBM66 (ORCPT ); Mon, 2 Aug 2021 08:58:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kr4oSHVA3SC9dTtt3GsR27uwNztID/mGFgrqu+P+f4oYUWDfiGRO/mO3VRTQnnI90GCYJoGh+MRHVGoPFMCfS9sZRaAOGAdflaBPGJhBVKEVvGDauT6JCyZBpesbajvwxoBQfKH3wVrXiPO/LEsxoh+wVLM8HBO4jX+vDNYanvXFzxFvyUEW8Omso+nT0uWkjK2w9VilF+O94Jp6/XMI8DzNAv6UigX8RXYHzOr5RBNIG4a5AavpVRS4BSVyFkmXm8oO8SrqjEa0uuSv4UI3ByM1VdpCi0xvt17JfbWQln7bHxNdiClu7hM4pIvnTCp73Xr+b18+Ol9+ZzIvcVNHmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/d+P+4nhytX/RzEd38Eq7qJPxrQkjnAZsyP2P6O/idI=; b=oWrYwAChIrsO3MBLp3f3w3tsHxapXVPRR9qqqosgKpIjXz+lJfUkSg53F+A13kZ1U7iJtyrCyqnbCndGoa1qN81nl9XG+6phOrpE2U+zpc9d/YiC68DBMgKT1h/phXatFJ/fq+XR5Qmrlu9UEmhg15+aRRq79PYBSY9LHEymI5OV9f491Ln5Mr2pQAB2WMI0+y525EzyDVlMQjru0QPricP5cJTJNPzSKXjuvigLYD1VDXXxTaIAZ/znlm+8kX5XHWFHm2Xz2txC+KR0VW8cdQUdMQhFzo3U7dzx0K4wR69kzobS07YsLXoQCFurxDjqMHM9jlznfWrfqVWPAptO/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/d+P+4nhytX/RzEd38Eq7qJPxrQkjnAZsyP2P6O/idI=; b=YcQaqoECLtESu71F5xV8Xoc60SH7PAtkGgBn+IbG6Zo6OGPINRN74jbkGj+somt5WpW9yoE7V4opn0dfIjBzKwnLd9yJoU6lbGGkjxvL2oUFMhdQj/+alc1/QvkBl63CC0r8l76oPl5Z3d0T1BnRTPkwj1heiBHzu/dveowqN9I= Received: from MW4PR04CA0288.namprd04.prod.outlook.com (2603:10b6:303:89::23) by CY4PR12MB1398.namprd12.prod.outlook.com (2603:10b6:903:40::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Mon, 2 Aug 2021 12:58:46 +0000 Received: from CO1NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::4f) by MW4PR04CA0288.outlook.office365.com (2603:10b6:303:89::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20 via Frontend Transport; Mon, 2 Aug 2021 12:58:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT038.mail.protection.outlook.com (10.13.174.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:45 +0000 Received: from sanjuamdntb2.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 2 Aug 2021 07:58:42 -0500 From: Sanjay R Mehta To: , , , , CC: , , , Sanjay R Mehta Subject: [PATCH 2/4] thunderbolt: Handle INTR when Disable ISR auto clear bit set Date: Mon, 2 Aug 2021 07:58:18 -0500 Message-ID: <1627909100-83338-3-git-send-email-Sanju.Mehta@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> References: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2403fd50-9f82-415e-73e7-08d955b54397 X-MS-TrafficTypeDiagnostic: CY4PR12MB1398: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1824; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4JRRub2Jm09fZaJRNrTKKhS52z3mLr/8mVOOIPTaaGGiY5pHsEDJDMFQIKYYC4J+Z+/WMcaPiPT86CI6rlfYDo1uUj3QDsMpfdyzbdPr9wZij8rkTo0POT9PcaATW/jevISQ85UUN0GUNw5ZAyX20mc/ZL6U4QA1AWKjB3i4pnKXWaXRVRAiBQJfsSMPlsqLA146w7MWtbVkttBBI8GsW5NScokfbQNhWiXdeas+oRPRsb3r0OXcWpAih0YosfnD6ujdQ4KQkwhH9+avnYDsPMyab2boqlhCTnCyj9PzuDFhPYsCp5I5QZlrBupd4sHMQl7AhXJbZGdqCC5LVkCHrzWdBL8LEms2HSCXFzvxFlRC2ba5E7y8OxVz2InZ5gqE0r9r1RFh8+0KlXWyD3W4Ojz9IBgYQenrM1measutVyhd/AsCe4TBU+ucRoJCdUEyZPjqJbws3GSUNCvt501hkgxSoyY6O/tJ9Y7Mfi29KixRpkctlFOtLReroMuYSN09DUI7yqVidh5XlzkbZZJo9mTMaXiSy5G8LEOxRqc7DpECSpXqepaneeBfMMalJEGQYVb4/60OE1lq3xCErwFFTHxUwmn1iwkSykvo8BQUw1nsnhejzpvoxROKGIczgqhlLzl2ntteloNgtqQ/zDdTjMxaXfd0GBOHoNFIGlO6dgIZ4PwuBuFkPejcahK8CbL/ezJSxmb+dgHkLTpP2ddtVzfsHO0pekSAistO+0QdC3U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(396003)(376002)(46966006)(36840700001)(86362001)(47076005)(336012)(70206006)(8936002)(36860700001)(8676002)(16526019)(186003)(70586007)(26005)(6666004)(83380400001)(36756003)(82310400003)(2906002)(316002)(426003)(2616005)(82740400003)(4326008)(356005)(5660300002)(81166007)(54906003)(478600001)(110136005)(7696005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 12:58:45.9417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2403fd50-9f82-415e-73e7-08d955b54397 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1398 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Sanjay R Mehta when the "Disable ISR Auto-Clear" bit is set, the Tx/Rx ring interrupt status is not cleared. Hence handling it by setting the "Interrupt status clear" register to clear the corresponding Tx/Rx ring interrupt. Signed-off-by: Basavaraj Natikar Signed-off-by: Sanjay R Mehta --- drivers/thunderbolt/nhi.c | 26 +++++++++++++++++++++++++- include/linux/thunderbolt.h | 1 + 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index d7d9c4b..63bbabf 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -74,7 +74,11 @@ static void ring_interrupt_active(struct tb_ring *ring, bool active) if (!(misc & REG_DMA_MISC_INT_AUTO_CLEAR)) { misc |= REG_DMA_MISC_INT_AUTO_CLEAR; iowrite32(misc, ring->nhi->iobase + REG_DMA_MISC); - } + misc = ioread32(ring->nhi->iobase + REG_DMA_MISC); + if (misc & REG_DMA_MISC_INT_AUTO_CLEAR) + ring->nhi->is_intr_autoclr = true; + } else + ring->nhi->is_intr_autoclr = true; ivr_base = ring->nhi->iobase + REG_INT_VEC_ALLOC_BASE; step = index / REG_INT_VEC_ALLOC_REGS * REG_INT_VEC_ALLOC_BITS; @@ -377,11 +381,31 @@ void tb_ring_poll_complete(struct tb_ring *ring) } EXPORT_SYMBOL_GPL(tb_ring_poll_complete); +static void check_and_clear_intr_status(struct tb_ring *ring, int int_pos) +{ + u32 value; + + if (!ring->nhi->is_intr_autoclr) { + value = ioread32(ring->nhi->iobase + + REG_RING_NOTIFY_BASE + + 4 * (int_pos / 32)); + iowrite32(value, ring->nhi->iobase + + (REG_RING_NOTIFY_BASE + 8) + + 4 * (int_pos / 32)); + } +} + static irqreturn_t ring_msix(int irq, void *data) { struct tb_ring *ring = data; spin_lock(&ring->nhi->lock); + + if (ring->is_tx) + check_and_clear_intr_status(ring, 0); + else + check_and_clear_intr_status(ring, ring->nhi->hop_count); + spin_lock(&ring->lock); __ring_interrupt(ring); spin_unlock(&ring->lock); diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h index e7c96c3..bbe7c7e 100644 --- a/include/linux/thunderbolt.h +++ b/include/linux/thunderbolt.h @@ -478,6 +478,7 @@ struct tb_nhi { struct tb_ring **rx_rings; struct ida msix_ida; bool going_away; + bool is_intr_autoclr; struct work_struct interrupt_work; u32 hop_count; }; From patchwork Mon Aug 2 12:58:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mehta, Sanju" X-Patchwork-Id: 12413919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6301FC432BE for ; Mon, 2 Aug 2021 12:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D0A460FC1 for ; Mon, 2 Aug 2021 12:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbhHBM7D (ORCPT ); Mon, 2 Aug 2021 08:59:03 -0400 Received: from mail-bn8nam12on2041.outbound.protection.outlook.com ([40.107.237.41]:20897 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233665AbhHBM7C (ORCPT ); Mon, 2 Aug 2021 08:59:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QHsFkplyFyMMlzz0LAnNuJYaQ83kdAFGWPoz4YjCpRCmEyr+RgysEfCHK2eWFp7tTBWZ2U5d1vtpr+yYZec4fThv3pfP4rIHkIPM7VMDneHzWVtBE19l4o/bdOLn3PDamdqIVdBp31k48hlsywYSgxJguxm8zMgB6I1WZ2e8eCE1K9nWDuolLn3513aB9cvJZISOEVtRhVmbEi25ZYRaa0QahKq+7Aw4xEz4OYkHkwmpBYaYWXyaq8oZrL3IWHFiIH/hwaolDPd32mKs4lADZMv4hhThOr6aIn3yoSFZGEQUpxfqd5CMuR+4oU4K+yVAwqda3xWmwrQDZ1LA6XTmNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4TQM/JSgcsWKb8ikUP6GKgFsbliHiRzN40UngX2oFU=; b=HF1T+UmwKN69J1bDcVUDFuCRcKHQoOucnaDb1CYhqb0XyRMiVHg2dqc/am5OH/MTiLr55GlxJdDoLiqVDlBQnS+gDVO8lZ54qwdqly+4MSDQxRlGYCD5bH8cV5ufoHCUyNDw0srErRAJpATdNvVKNtMplctKBEOs2LGcVasjG+aODLTViVcEpb83UYDmcjYScpIn+srYY+5VFdDqLLvBt3DdfwijUi4ZumWR6ugmvleq6GenVP9PderpgHB9bRh/8jNxB2TQxltP89kZIas6AN4fjx5ezNe0SbXnP9sYmyG2N1uFCKL6lVi4Z2+BzXBbxP/FyAWTuICgxiwSzR3Y+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4TQM/JSgcsWKb8ikUP6GKgFsbliHiRzN40UngX2oFU=; b=itsDIMNfIXlgqWHdsHJZCbEAbJv2QK5r1M9bMDEnIkUbqA5Rq8T4UB74Z+wWfl77yuXwpCeRWr0IgTAbNj44qqI+P8iKT4iQDQlz0R3fDES8H4zekU93SxYXEOw6scKJrT+bKqwMypdtV9oRP+95QQ4nnWnq7tN4AstmbcoZcc8= Received: from MWHPR2001CA0024.namprd20.prod.outlook.com (2603:10b6:301:15::34) by CY4PR12MB1384.namprd12.prod.outlook.com (2603:10b6:903:3d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.26; Mon, 2 Aug 2021 12:58:51 +0000 Received: from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:301:15:cafe::12) by MWHPR2001CA0024.outlook.office365.com (2603:10b6:301:15::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:50 +0000 Received: from sanjuamdntb2.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 2 Aug 2021 07:58:47 -0500 From: Sanjay R Mehta To: , , , , CC: , , , Sanjay R Mehta Subject: [PATCH 3/4] thunderbolt: Fix adapter init handling during switch add Date: Mon, 2 Aug 2021 07:58:19 -0500 Message-ID: <1627909100-83338-4-git-send-email-Sanju.Mehta@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> References: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6174010-dde4-452d-b799-08d955b54691 X-MS-TrafficTypeDiagnostic: CY4PR12MB1384: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AATgcFIxFh+V4sQD6hXPAUxeYstwrYm5/GuJFeyDXqgJ5L+ssBxNSk1s8Pt2dr2vPfQNSaSjruNmQNkuB5hxaWQQrTVqGDlrZliAPdsyBQaPo2C5AgJoAgU6IvkiaV6dHz6F87Xv8T/1fcaYw41QSXTAw3O9OElTd9Bd4zC4xmKNJtkTB7FEcB6c917ydfzS6IP+Sl4IMecSynz5yRpAA7uH7IX3Xr9UT8I1zFeCcdEk2H84ebHF1qgZOrfORaXH8tTWMyzcxq0heGffH9LxhNmO2D//JliS8TdorlXiMDg9f2hiX6aOn4ZwagwznrFAD5wZchJHadnwCHLdjyty8jvpgOj5qqK9ZyxjOFIdiCWn7gU2aUxQkP3RWpvh3gX5FAK+X4kBrJnWgLQrkkoXnKEgJQOhmd69hMI9E5iEVF3IV7jVRzd1F/uqHzFD3WFcYdRv2FTDPMpge4eIy/Hi6PQNDhGD8ywxRQSl9heZ4OQ5Y/byKaC+O3pGtI6bOBsrxyRjgIlnJpV4seNXNMPjtBoHYJSX3blBkTJqw2ks7Mqy6rQz7gDSUG2il/HlGbht9juYvDqJn89Fk80dhwGdkdOXBTI1qK/N6Foiy+IpILPKO5iHmuUOlWS3LDPdedVa5uOhZa4fVoLhrNpg8TzN0FFHXSLnTXFPZ8QfB5vuckzHr2p/h//CmouqBCnhfKFaMOR1FK2xsbKfzZr7MRJMzcZ82PcKZxheHZ2vouDQQjk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8676002)(86362001)(83380400001)(2906002)(66574015)(356005)(186003)(16526019)(8936002)(5660300002)(36756003)(336012)(6666004)(26005)(47076005)(82310400003)(4326008)(2616005)(316002)(110136005)(508600001)(70586007)(70206006)(54906003)(81166007)(426003)(7696005)(4744005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 12:58:50.9463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6174010-dde4-452d-b799-08d955b54691 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1384 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Sanjay R Mehta Adapter0 (Port0) is the control adapter on the AMD USB4 host router. As per USB4 spec in "Section 1.8", Control Adapters do not have an Adapter Configuration Space". The read requests on Adapter0 time's out and driver initialization fails. Hence Disabling the Adapter in case of read-request timeout and continuing the driver init. Signed-off-by: Basavaraj Natikar Signed-off-by: Sanjay R Mehta --- drivers/thunderbolt/switch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 83b1ef3..effbfe4 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -2747,8 +2747,9 @@ int tb_switch_add(struct tb_switch *sw) } ret = tb_init_port(&sw->ports[i]); if (ret) { + sw->ports[i].disabled = true; dev_err(&sw->dev, "failed to initialize port %d\n", i); - return ret; + continue; } } From patchwork Mon Aug 2 12:58:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mehta, Sanju" X-Patchwork-Id: 12413921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C7DC4320A for ; Mon, 2 Aug 2021 12:59:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8257D60F6D for ; Mon, 2 Aug 2021 12:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233858AbhHBM7J (ORCPT ); Mon, 2 Aug 2021 08:59:09 -0400 Received: from mail-dm6nam12on2057.outbound.protection.outlook.com ([40.107.243.57]:37728 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233862AbhHBM7I (ORCPT ); Mon, 2 Aug 2021 08:59:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+cE+MxViPek7fN/nZOuTQ8uPeY3GuMN+HPL7SXzp9cR6Itce6w5Cn4XhvEQVArUJMidEn25mMmQYIvSsjquF8kOPDhZM+AxZMeFdQjStlYv7Woc1TGdI5mPPfzwUOY4xtGgVqpJVqnLJwtgbqkYKmeMFhyf9um6Obs6tbZhsZ8ytyX3laetsqhgCFr2EnLfHwYmhgmiQehXPxwgs7tzxzaKK4NheP4VpzVP8+LjqkMJtgxQ1FCv64QFnI02ZqY/sPAACKOCzgWrawSQcO/p9/D2bKrevQr1EPa0Js3hiwgUsQh9Jg7X3FJmskqi9Snkis7sJoYvUbYMAT7v58ZLOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=elF+gUZZbDHy8dzKKKso/rwGO9GihzH8aEPEOh4MQng=; b=OICW8zhI170j3wP0Kcw2UfmXoEKiG5uU9Wsy0xaaEdozqhBhzRDgcTNVfK20DluHVtIcr+frnC6pB7mPqLWiOO0U+toe+r9FwYUvUKlBtyYZs6pAweO2d88ChkyLurTVITerVkogtEUbvRXrQIo/yi2eMW3lC//b6vmJ7Ewu2TJlOgvlsV7+zN6Z4JvKamzhGylh9kdEr+7ikPSxO1Mc70gA92EU7RuYdArEqkKG+dtb+jnHUTaZIITCZxcObyxO2XxnvPKIUBjq9U+KTNTQ6Djl28NNiuBW9+Ji0vtnq1udxnG0IXW1iknomRAypvhBThNkCWLNY3QIaxdsthgqZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=elF+gUZZbDHy8dzKKKso/rwGO9GihzH8aEPEOh4MQng=; b=inXq9P5IC7UblvtVfRMXdNi9aGwKh6i/VFDWoXKS0sKzjetHvuB7p/HpUzTbQ+HLnnePILE5V+SkdNRuiP/H2j8UzfkKJOfPfXqIWLYbz1RIbiOHchFYcsMGZ4nAgXkG0VhO6l28vWaYz2FfytHQ29AEtylyIvebmpfICG609U4= Received: from MW2PR16CA0006.namprd16.prod.outlook.com (2603:10b6:907::19) by BN8PR12MB3233.namprd12.prod.outlook.com (2603:10b6:408:9f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Mon, 2 Aug 2021 12:58:56 +0000 Received: from CO1NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::f6) by MW2PR16CA0006.outlook.office365.com (2603:10b6:907::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT044.mail.protection.outlook.com (10.13.175.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 12:58:56 +0000 Received: from sanjuamdntb2.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 2 Aug 2021 07:58:52 -0500 From: Sanjay R Mehta To: , , , , CC: , , , Sanjay R Mehta Subject: [PATCH 4/4] thunderbolt: Fix port linking by checking all adapters Date: Mon, 2 Aug 2021 07:58:20 -0500 Message-ID: <1627909100-83338-5-git-send-email-Sanju.Mehta@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> References: <1627909100-83338-1-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc6ff003-13ac-44cc-1abc-08d955b549bd X-MS-TrafficTypeDiagnostic: BN8PR12MB3233: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uDrHXj8qNfK+Y3c6YXDmUeaBKGGV1fR8jTaThc8f/ftUAucughJQdErsCpz/X6F+ensYnSXz3Rmujf3oqlzzQIUDsE5HxNJ6xxewUHS+YBjH0q97qqp1+O0XBgA3y+q/LPvWklSTRgaVKgbHKmYMgWtLIMhtpQbJP7hxmXzvNenkMZZBkeSt+jsIHWSCIRFaCo2lH4uQdf3EcIau6qAX/DmTu0uCNmTjYkD3wF1SfXnSLWDEfvWzYj6RoUMxYBBJbpbZmBm63SR5T1HCni85zR9mdG+O3izMnUGB08Fmauz5zTY+E+XFMXSw7k5UN4ndrJ3rxX+q1qxCJeuHwyKMx/6g2gSfESx93FpWTFGUQb4Ws8c7SJNn3JnXa+DveOACufEMje0MvjfhsD5LRrrjVBd4ccaXg3ZVeix2veP/nTXz/FzUAI/FlPU6oqWJ/SDX5Y6d8Rh5T8G/+/XLqHchomO+411JKcl6F4sF2/pN7KN3lt9T8VFucr4cFfvhESTxp22NKC+/nzcnHR7+bD7F17YHoFryGYxGtGuVtOlWiPFi7vj0/avGxSXYtswaCdYOgO4Fj7UXJ87aoBKl0I+i35hEoaoCDkZItJfzgseJVSIf3J2Aymo9FAq6IMFEEgUnMmcYOypQi632SdUQbRArK+D9J/xp7MxUdqtlVc5foQ3AVNkzNBznfsLkIYtSI2QQ5ZDgOTwEWy1aBPbJTh6CHvTcr4bvfyWw6XvfGIxMtGQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(396003)(376002)(36840700001)(46966006)(47076005)(82740400003)(110136005)(7696005)(83380400001)(478600001)(2906002)(82310400003)(54906003)(5660300002)(70206006)(4326008)(70586007)(8676002)(8936002)(426003)(26005)(186003)(16526019)(356005)(336012)(36860700001)(36756003)(2616005)(66574015)(81166007)(316002)(86362001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 12:58:56.2568 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc6ff003-13ac-44cc-1abc-08d955b549bd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3233 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Sanjay R Mehta In tb_switch_default_link_ports(), while linking of ports, only odd-numbered ports (1,3,5..) are considered and even-numbered ports are not considered. AMD host router has lane adapters at 2 & 3 and link ports at adapter-2 is not considered due to which lane bonding gets disabled. Hence added a fix such that all ports are considered during linking of ports. Fixes: 0d46c08d1ed4 ("thunderbolt: Add default linking between lane adapters if not provided by DROM") Signed-off-by: Basavaraj Natikar Signed-off-by: Sanjay R Mehta --- drivers/thunderbolt/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index effbfe4..8b2fe67 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -2456,7 +2456,7 @@ static void tb_switch_default_link_ports(struct tb_switch *sw) { int i; - for (i = 1; i <= sw->config.max_port_number; i += 2) { + for (i = 1; i <= sw->config.max_port_number; i++) { struct tb_port *port = &sw->ports[i]; struct tb_port *subordinate;