From patchwork Thu Aug 5 03:32:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12420217 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC70C4338F for ; Thu, 5 Aug 2021 03:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09CA460F22 for ; Thu, 5 Aug 2021 03:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231500AbhHEDdO (ORCPT ); Wed, 4 Aug 2021 23:33:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235289AbhHEDdO (ORCPT ); Wed, 4 Aug 2021 23:33:14 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0612.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::612]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED9BC0613C1 for ; Wed, 4 Aug 2021 20:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIFxhwbyDPXDu2+v39taAIa8vw6wFcsyOp3gPlNDwd9e8qSOV8DhapKUWlYY6D7HKfTkhkHNarDLIr0uulW1c8NeRoIJu/dt4Zgwo19gaaIhRvDHzUyA7jD3G1Juzgp63ZofLe7BK9V2N7j+x8W8uqBQ4A61H4A7DebWkBYbM3oFnuZHaFExR2y87vc5DMAwoEIh4KhdRcPMWg04DyYTSIwrYWrSTI46DYZMhrTTpxGy7B/0cWlZG5XKKBVw12BJJSffOH1Q48m58JfH6Nuj8k9JIqK7Tj3QBmfstlvXPgOXVkMd71Scs+ilUBh4uWRyiDYEQkdOMZ9uR0gMty6KGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXFJxVIoVk11oX9ieK4a8eXnmL+i5PORCezGKhyEA5s=; b=M28xKwsqLdD+8Z+zSb+I9eaL7VaCku02ih7UDArZg4kb+2mnewdBpQ8ldw4/ePW3N328hQF89suMR0xg04RZ/SojvuXaeUhVpN3nYA1Ntw8fg0KWHZ08XBcAWgZEGNn8SKg58hHzFU1AVn4Q0bCNwoPRD7zpjImT04C/Lybe/o4ekssJlRxzsHHWK4gCD70AM2FNiSKKqTHeO7fcPeLIHLuby7tcsEjtORdYU/PYM09dT3X/kDfbLSjKtpA6kVwpjoeR1nWThnqABR1S0O72mUgK/piBVDGQc17kD/N7CstcPQmWtB4j4NKodiW+XM4uGngt+9dGzCo8Gp2ikKDQow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXFJxVIoVk11oX9ieK4a8eXnmL+i5PORCezGKhyEA5s=; b=cUKbZxeQJcpwjfU+dgVyvi2XAAldIWydJ7HFCQaYPiBAjtieHkJAQXiEsDz0qEfjj/cXLbHB+h2R0/RIHacjvK8vTSaCIg6agexlCdN03ljci1YWivTHliFvb7DW/WdCOalxX93HjpqT3XMuplI7ZEDMSEIxwJcjT+KIqkzOrQE= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DB9PR04MB8448.eurprd04.prod.outlook.com (2603:10a6:10:2bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Thu, 5 Aug 2021 03:32:57 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4394.016; Thu, 5 Aug 2021 03:32:57 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com, Dong Aisheng Subject: [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem Date: Thu, 5 Aug 2021 11:32:02 +0800 Message-Id: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 03:32:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02693285-a96b-4ffe-1fcd-08d957c1b7ef X-MS-TrafficTypeDiagnostic: DB9PR04MB8448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AdWH6WZvliQGqjd5uGNkFkA2X1oAhejh2fITEoY/jwFxeXn5KsSimF65O2Pv5qdMNbQX6S8L04yUhB5pGv5/Jgv+ucCIuaiyFVN/ulyDuy0JNliQvhU9otfCgGnMObHXrxaqNH7bLpdJGeC7L9U7uNSbD7D4SHfXdFJXLtn5CPTYfL2xuiTM2PKnJ6W1bwxOfkMpA2seOyUo7xl9/tSeVe48W3OSOFZNob7Fknbq4TBHifojcMr1/wyUtNYtk+xGAv1T05Y6Px8f4GE7XNi98NjObiVOXSeCVmYF0n7Wb5wk8kXclrqDQjU6F/yWCgErDZRqGnPYwo/2Oyr9FVcFFCDcXbEAD3zPufvmwI7duZwM1rsc5wG50Lpi3GHrIh0wtXTmdU7meHm29kgSFbDeerbVtYYaeANRbLYCqQ0u9dywoGRY7NfWjyF3kdh2DJAWGhAT9/YWwJ1WMUiR29Htu8XMpAFqNfeLglq4mY3oHwGjZP/wIgVwSqBJkQDVM3lp+BN2R/EdB3RNqhsEiOfDxVuOR9z3Fr3UMCF5MX9AFCvN62xgN0xhdwBdH0GSvP/1p+HMNl0mtqOUyj/pdQwiRsstkU0GiAu6j3aMMxqovTvwchOJl/CZ1wDdpnbM7PiwaJqlGfaEdn71BY/cWHdS6Q/gTNT40NzQH1VQ/coZx7KLxsStbjravPG4peo2JbyCMH+2gPb/MFOirBV2+0rh+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(6916009)(6486002)(66946007)(8676002)(1076003)(6512007)(38350700002)(38100700002)(66476007)(66556008)(8936002)(2906002)(6506007)(186003)(2616005)(36756003)(86362001)(52116002)(478600001)(956004)(316002)(83380400001)(4326008)(5660300002)(6666004)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uXl3OS8SEz24MTjBuMlWgYg46N1Y3vvITP3z6hWLRwdowezAb2LNWXiym3oXgzDe/09R2YPeGH8gDgYnS4BadF9rFd1F88yMeC3taCezycyUVBozt/rpC8HWSncFsHQIdtDix4wGuEaij6/MSf2ntOgw2eRIGbtL+zebWC+1+/1p0dHgJqcdWWYsUPpcQler4zGHODdpK7gCKCj6WIRNbBJNIjrRLx356+AqptdYJcwO6KWsEHWjLOTrqSyTiTfzkyUjm7UTejuCskwHpipEmYc4fkMjcxhlaUhLDuG5cmv7x1zM0UG2SUoZDFBnlNCvguvE6kv+1YhSTM/g0u/9Wk8ibzOjmEscMStI+l4ldbL5au/wzAixJjJXcq6XitvrZXx54xGrsqKpQOzgdTrwHxw5PP3NMI8ll39qtEBYuN1LoPFFPK9Iva/FQ6GSyz7arBmh1LKh7pwk5FbgthBr88vmFedtpMQsHnmqO8lhlCcsgKFch3IJMCIpVgtr3Ker7VjoimgY5cua+J0RI2MC9ZSyl6E5M549klc5/qcriMntemLTtx2fn3zbWjfjL42HeJSByax1oZxu8zSZRaGWlIciya0iBVldC9Wu3nidjU9bpiYVoP4steHt2wlZwOcJLgrIBhYHS68v426fMQaW6yBMw8mgRG1wSThOQRkaeJeCjkM7R3CrK3ybmGdhXE7s2dMb0/Gu5hEtYMYRl2y6j0t0ppnOSldhOPLLUV9YIhX4icIIc3lQ1DjuqweXIocqlbGuZh0Hj6Rz4HAQ6H7wipqLTB1gg0aftQy3iFoydeA0OWR2AgktEU6GoFtzhthvIk9lFCygw2aL97V4rfD209Z7LU1iT9nWgJawICPWyXN5MsK5wmYZSvv+S0fCA4JxX/9tdN5X/PdtodAC55g6cd9rK938ofaH53E91ICg3L0BvzX57FjVGu+DoLJ3Rtybi2+dVXsntPg/gw2FjDwyxm/Qvsd1mxq/lLmVWhOYq916AikaTrslZd35CCTeYdbjSjJeq9cFsdB/CuEoLx+NuvqiTWQNjuoToE6GdmZzKJE9Nh4JgZ2azWBZclSF+2QrS8a+OdCJz/Z7Ka/rZwnAEqYf6LHHZFDoz3554sGblBlHr+2Opc+XQ8uHn+wurLM91gPndYlYyoifHUlcH7t/oceu+6hQKZuzRLXrXMQBgSK5r4ywMrdVfl9ZPBC+9E3ZDwVFoLB3iI7MVKImM1DFfF4ryJBkQ/nP7SfUtjyDh4AKx7IyWjqyzWC6LO/4/t3ETRbx3pqj1/nQ+245LxyEonka8sd2R2sn+SGV0OcSa8fP2uu9igfzYFyHWWX9gFwk X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02693285-a96b-4ffe-1fcd-08d957c1b7ef X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 03:32:57.8191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JPdzVDGydNCh54D1U+IJbgPz2xXB4RHdsWP5uLsHAEBbXxvT9pmjnVz1yWNoOq3pNhwK58Eo7CvFlDrg2oyisA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8448 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Currently the is_iomem is a random value in the stack which may be default to true even on those platforms that not use iomem to store firmware. Cc: Bjorn Andersson Cc: Mathieu Poirier Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng Tested-by: Peng Fan --- v2->v3: * no changes v1->v2: * update rproc_copy_segment as well --- drivers/remoteproc/remoteproc_coredump.c | 2 +- drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c index aee657cc08c6..c892f433a323 100644 --- a/drivers/remoteproc/remoteproc_coredump.c +++ b/drivers/remoteproc/remoteproc_coredump.c @@ -152,8 +152,8 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest, struct rproc_dump_segment *segment, size_t offset, size_t size) { + bool is_iomem = false; void *ptr; - bool is_iomem; if (segment->dump) { segment->dump(rproc, segment, dest, offset, size); diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c index e8078efb3dec..3cd1798f17a3 100644 --- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c @@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) u64 filesz = elf_phdr_get_p_filesz(class, phdr); u64 offset = elf_phdr_get_p_offset(class, phdr); u32 type = elf_phdr_get_p_type(class, phdr); + bool is_iomem = false; void *ptr; - bool is_iomem; if (type != PT_LOAD) continue; From patchwork Thu Aug 5 03:32:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12420219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C60F6C4338F for ; Thu, 5 Aug 2021 03:33:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABA0760F22 for ; Thu, 5 Aug 2021 03:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238513AbhHEDdR (ORCPT ); Wed, 4 Aug 2021 23:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235289AbhHEDdQ (ORCPT ); Wed, 4 Aug 2021 23:33:16 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0612.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::612]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0AC4C061765 for ; Wed, 4 Aug 2021 20:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xr4rFWfCqY7KVx4tI/NP601KH7W9TjinQyhI8PrSDAsZyGWuFYhfeVOqxg4cRJG+xQ9rwuY3e1skgUS2ma/CWT1uNkuKxFbKGVOGILqEFBkWoxqPmIEWV6LyFC/H51s3yMWK4HMJ+a22I7Vgo0FpR9Qi2hsCgf3qugsJ/coMl0MYcjGD0O8bgXPrDRSAlxK8kmPZPG0JIEQ/q+dLXbwhk2LB+uwbT45bCBrw+8Yz/ARYUR6PMrk7jNTZAY9xA0K6857uFaaSxjyvKg7ROPM37KhJH3FIbTDA7LWxprRRPGIP1YwaF3/KsIMG45lFbX406umyZYpvLfc1LWPUJ5V8DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTj/rFzXsr0ViQlVtC8kOS1uA1z15u8wzxquuYhrtzc=; b=g58/MZGUvRtM6tItltdcI1AX6dWxMH2rgPYabWrPZ2UxS/Onl8t/GxSuobv11eyz6ddLc8o+vtQJ/kPv/XXbQN9yV8MP+xZ5bgy+zsYQNnG2efQb9g0DVqEtUc4JI1wMFEOT+zwd2OBvw+hYOAA9pvM+0w1zX+Y/5j+IAmPyAsTrfI3tL+70c6ms5aBD3j2CCk4vWQgoJbve3oPvO0PLopHy/gI2APcGu+/Y5xEXAnw5dCXRnMjVxpXu2FhnxYFZ58UNrpwZVlSCFD41sVgytGBYPuJ3mRGwrBalVG9XdCkZLcUguANhQxcNJTOoc/EyeLvpPF1IpOGXDeF3s3CqMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTj/rFzXsr0ViQlVtC8kOS1uA1z15u8wzxquuYhrtzc=; b=CZHqGCJ+wmNtYhBYT2tLxDRNA/LRpRq0+GxINVh3W7yz2TLNVHTF9j4gWT8fsS5qOrD0rr9drYtOiC7HvoggUJK6Jikli++xhcSn1BLztIr70ncxfmjRb0uszCMJmsXT4ggCpqUuak+CHY6JoPUr7Ar66lmBfEmAXKXQd2k4KFA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DB9PR04MB8448.eurprd04.prod.outlook.com (2603:10a6:10:2bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Thu, 5 Aug 2021 03:33:01 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4394.016; Thu, 5 Aug 2021 03:33:01 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com, Dong Aisheng Subject: [PATCH v3 2/5] remoteproc: imx_rproc: fix TCM io memory type Date: Thu, 5 Aug 2021 11:32:03 +0800 Message-Id: <20210805033206.1295269-2-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210805033206.1295269-1-aisheng.dong@nxp.com> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 03:32:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b88d01d2-621a-4b60-b979-08d957c1b9d5 X-MS-TrafficTypeDiagnostic: DB9PR04MB8448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:469; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gWUnkEFonmGVFr0CWA9HbxpHy+3XPQczMsYLMK58E/7zbMtoWTFNbUXWTeRjMN9TYmerbzcmNxvslJ5c1JhDJwjD7tXR3BcdsbiQSplrsWjnTlJVT+WugCsNE5nWDrC9lhUWv1bMnq6h3Y5HjzUPBX2k/0a2aZEWsPmI5ytiRfWFTK3cMyBlYye8q/NUqcdtiC6h3X1AC6UAg9mL2WWKuX1sxaWiwVxVh4/k+AlfnEv3dvZVnnAcGsM5ewb9ebWiKFaN1rewle5ykX7CJ300/Eoe08N5nUteKbBAikZeqAExtcrHG8Q1HR60GkOLZ3fw9+IGpeeHllpNnpasThbSzGzp7aQVXOs/pbNV1mw/vn8bO0pFMkZDHMWQZcQemBRYiqos0lJ61YfDaNcB1XDRwwSYC3/SXfCZrPlAnb4pdYU0nrFqi5OLs1PLTltsjGryt4SJ5TBZUHd5pZq8AnqEWhu5DMLa15mZ6YHPheXVGznuZME1bZ29PI3IrzirjqQeDwM3R6kJRJ8vkNNb9aWjUFCHt5XDTRItASEOaksTwP5GBkcp8WfPLRHqn79h0C03nQO6Kfmq9RNzBILmNSqSSrnJo2OBU1sVtXye2R/XbkvQpnDjl/yhJncRtk6w8l2Ooh8zZmhb3wBG4Bg+zTXAWic48l+VFc6syWTmnCvzeIa3KmQqP0FeGDxt4znMGzNr/lIQlscDgWmTQjVeDONWnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(6916009)(6486002)(66946007)(8676002)(1076003)(6512007)(38350700002)(38100700002)(66476007)(66556008)(8936002)(2906002)(6506007)(186003)(2616005)(36756003)(86362001)(52116002)(478600001)(956004)(316002)(83380400001)(4326008)(5660300002)(6666004)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cXibNH5dVm2ZaPDw2/voRWJQEHbs4frGfUSpy12JbC5ypsKBQhScnjgJZutTKbD0plwNzmGR2zyixYysOjx1XywDjXdB6U+pUEle6gGIKchWIEP7E/W97M5CLNvPghPEoytl024XedMAF2PYDkcIj1MNyQAJHpCnclmnI+/E1UCiEFLgDoY5n4GZsOwTkQmiFchsWSq4Uovf8GtkKz5HDevkszBtnEAKWnSCscHX5WpxTxUvjbiibByn5JsBUn8oqOZIWFlycFj7HippJuAe+OAPc9Y3cbsyK8tzWo3lY5J/HwEYPChuQxwsGkzjr9VOVtG2Awhe9i0Ihj9DIDRfXxJQf3lMTtKs2gR8drsDGdcNnoy+9Iq9zdCpcs+iW4QUXlolFXDqZdERS3rwLr/HRcr6TApSmtnPlPJuxgQC8NthIv6ym3M78A4UfgMHCjhkqFGHPk/LYFF9hq8M7YOLd0p1rubbOzDqGE0MgLFLVQGa7ppwV7lTkOPiuIqMibXDHFkUxX5zxRcr2Dm/jmBVYhXe9eAZfz71Pnn38W+5/d2Xw63Q52smeshSldBxXBPuD39Q9CAqnhLnezU8T3HY7uxuiglN7lBBd5Ixn9C4PGMkmtGo2xng/94llRcBLJY1xb4+dUo4H1qhc57GfEtqfuY1EOSMD/seZ4VmRKUcrQXOW+F+N3yRgD1eN9YzF9m9Fu1mlqWXg2T53yUcgLRaBLRhXe5VtaDselpe/u7brdr+s1sQZvkzbS1Vhncrl8dE2E7GXbAWKh0OeWsNncBclCFb97AJMDgxp0IW6ogJaRDMb2ro4RuUVvRsq1qy52UgFkM4CVzffXdZtrkkLkUleQzpqpIO1lRlFTNM2dXCVOT3htI0cDWZ4abLGxTX5zpIY3pHv1CO2GbcfY/Y33SQZ4o8rimvF6AW1NEjMqgFatEBZRee7J5sM94UUSD7xSqLK4XZZuV+oOBgT1UBa4GPNHnWQFUYgYD62UB8lHRRSxosOv5Ifqvw/E0E06Zp1VwFFJGg24CYdWIoyKTSw4UH/DE+p01SY/Aej1SBLIcPlo38fBubj0CpK3YKNw4n2pLD9/NQpRVWq3zwrSHwSd9LFsJuZk9cpDXqWTaRtvR4NBc46irPXfUGvsHnZw6cEKpgcV7Z+HyAq/TeXYJRRaQZbq3PWR5y1elHBKI5xmUAyyj879eJdifDFJi1mt441vhg2h2jnKnE0Gl8KQIleWE/z+ustS9a7LKEldNHVwTBf9y2Hzgb2lc8tDsjBKw+kKdR9koWviedlQ0sbL2OvVPJ9YH+v7E3A4HT9o6vDJWPkTcpX7OgdklJy5DSI18UaVBo X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b88d01d2-621a-4b60-b979-08d957c1b9d5 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 03:33:01.0131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C5BxJPHUw3ylw+ZsHEA2vQ3SWNniw81OjkRpl2/G2PdcLAuwQnojhYnm0UNkYx38+Viqa4ST2/udrg8FWelQZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8448 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org is_iomem was introduced in the commit 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va"), but the driver seemed missed to provide the io type correctly. This patch updates remoteproc driver to indicate the TCM on IMX are io memories. Without the change, remoteproc kick will fail. Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Peng Fan Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P") Signed-off-by: Dong Aisheng Tested-by: Peng Fan --- ChangeLog: v2->v3: * fix commit message typo and drop imx8ulp fixes tag Patch content unchanged. v1->v2: * using ioremap_wc for non TCM memory --- drivers/remoteproc/imx_rproc.c | 35 ++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index d88f76f5305e..71dcc6dd32e4 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -71,6 +71,7 @@ struct imx_rproc_mem { /* att flags */ /* M4 own area. Can be mapped at probe */ #define ATT_OWN BIT(1) +#define ATT_IOMEM BIT(2) /* address translation table */ struct imx_rproc_att { @@ -117,7 +118,7 @@ struct imx_rproc { static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { /* dev addr , sys addr , size , flags */ /* ITCM */ - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN }, + { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S */ { 0x00180000, 0x00180000, 0x00009000, 0 }, /* OCRAM */ @@ -131,7 +132,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { /* DDR (Code) - alias */ { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, /* DTCM */ - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S - alias */ { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, /* OCRAM */ @@ -147,7 +148,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = { static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { /* dev addr , sys addr , size , flags */ /* TCML - alias */ - { 0x00000000, 0x007e0000, 0x00020000, 0 }, + { 0x00000000, 0x007e0000, 0x00020000, ATT_IOMEM}, /* OCRAM_S */ { 0x00180000, 0x00180000, 0x00008000, 0 }, /* OCRAM */ @@ -159,9 +160,9 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { /* DDR (Code) - alias */ { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, /* TCML */ - { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN }, + { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM}, /* TCMU */ - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM}, /* OCRAM_S */ { 0x20180000, 0x00180000, 0x00008000, ATT_OWN }, /* OCRAM */ @@ -199,12 +200,12 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = { /* OCRAM_PXP (Code) - alias */ { 0x00940000, 0x00940000, 0x00008000, 0 }, /* TCML (Code) */ - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN }, + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* DDR (Code) - alias, first part of DDR (Data) */ { 0x10000000, 0x80000000, 0x0FFF0000, 0 }, /* TCMU (Data) */ - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* OCRAM (Data) */ { 0x20200000, 0x00900000, 0x00020000, 0 }, /* OCRAM_EPDC (Data) */ @@ -218,18 +219,18 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = { static const struct imx_rproc_att imx_rproc_att_imx6sx[] = { /* dev addr , sys addr , size , flags */ /* TCML (M4 Boot Code) - alias */ - { 0x00000000, 0x007F8000, 0x00008000, 0 }, + { 0x00000000, 0x007F8000, 0x00008000, ATT_IOMEM }, /* OCRAM_S (Code) */ { 0x00180000, 0x008F8000, 0x00004000, 0 }, /* OCRAM_S (Code) - alias */ { 0x00180000, 0x008FC000, 0x00004000, 0 }, /* TCML (Code) */ - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN }, + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* DDR (Code) - alias, first part of DDR (Data) */ { 0x10000000, 0x80000000, 0x0FFF8000, 0 }, /* TCMU (Data) */ - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN }, + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM }, /* OCRAM_S (Data) - alias? */ { 0x208F8000, 0x008F8000, 0x00004000, 0 }, /* DDR (Data) */ @@ -341,7 +342,7 @@ static int imx_rproc_stop(struct rproc *rproc) } static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, - size_t len, u64 *sys) + size_t len, u64 *sys, bool *is_iomem) { const struct imx_rproc_dcfg *dcfg = priv->dcfg; int i; @@ -354,6 +355,8 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, unsigned int offset = da - att->da; *sys = att->sa + offset; + if (is_iomem) + *is_iomem = att->flags & ATT_IOMEM; return 0; } } @@ -377,7 +380,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i * On device side we have many aliases, so we need to convert device * address (M4) to system bus address first. */ - if (imx_rproc_da_to_sys(priv, da, len, &sys)) + if (imx_rproc_da_to_sys(priv, da, len, &sys, is_iomem)) return NULL; for (i = 0; i < IMX_RPROC_MEM_MAX; i++) { @@ -553,8 +556,12 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, if (b >= IMX_RPROC_MEM_MAX) break; - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, - att->sa, att->size); + if (att->flags & ATT_IOMEM) + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, + att->sa, att->size); + else + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, + att->sa, att->size); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); return -ENOMEM; From patchwork Thu Aug 5 03:32:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12420221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFAA7C4338F for ; Thu, 5 Aug 2021 03:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A568760F22 for ; Thu, 5 Aug 2021 03:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238519AbhHEDdX (ORCPT ); Wed, 4 Aug 2021 23:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238518AbhHEDdT (ORCPT ); Wed, 4 Aug 2021 23:33:19 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::602]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D85C0613C1 for ; Wed, 4 Aug 2021 20:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BGowfnb1GgCCnMdJzryKPqTuMhOP/yRqHVhIVGy8RVxCtdrjlPDHYV7ldHNEYxWo7L6W3X8sTOu84jchJd8xsQUGOqJmX4NkRQjJUQAxJfl9NHImyoTMF5VNu2aNBs4gxaNxl78ciKkXVSMxjC5yM76JuA3FJIzW9bQ1a0Kxp6PTUt8hasLi2mHoM8ylhMRl3UGPP8drzzYzUgsnuD3I461+A+DfjRDhCeGtnjhQccXfu/dBTP8rZNPM81AqI7e8KQEbsCOyOi/hMKNZcBNMpzk0LhImr5MIgItik+Li5Jnz3gn4K2hXxR01IqrNkiVSDEI6Y/dq2DOjPPCR6IfPwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nkgk131VuD+uhNQpJ3YGKTY2ONIZQ4oZ0IgMay9vy/4=; b=WXtojKVQo9c9NTdk784d3XIo1sVOm+Rfqeon9NKBasba5cftEtWYjFGG6MiNvYVGvQo1Gf0/pUYSXSja/P5SJlaGzww+sZ0YzS4CuUfa6V879P+eyqSFrtTf4ARmeyp1j71LaeYBETzvFINL6e4OddQxybNormUCM1SCCy0JC1VjhvevtfxuY1XmkjQrSWendRJKnhiHpt+9wb3ECth73njcI+IP1NhdqyWIBk1cp3qxl1p3rsnMnZOP2iVFOZ3yRuHc9hfKh5656Xudd4/bACcXYmG47bamlSZt79agJaK8LWCS2nJceh9Rmqkv9foHj4CJ+QWipa4Y0/0ye4y0vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nkgk131VuD+uhNQpJ3YGKTY2ONIZQ4oZ0IgMay9vy/4=; b=Ueu/8UrEuPiXWQsciXuetWwQyilrCg8nAIAPSwKpRUUBEHjFDhVMuuouC8ULDXKLs/Qm6OgYmwWBM+3jg575KpLa/xgOo79wjKcrTovOCgq0OVEnsiyF8E3MOLTRZ5hlTseIbRa+SPw0rMOpO9j4mnqAk2kz9il3hoFs/vdxUWM= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DB9PR04MB8448.eurprd04.prod.outlook.com (2603:10a6:10:2bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Thu, 5 Aug 2021 03:33:04 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4394.016; Thu, 5 Aug 2021 03:33:04 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com, Dong Aisheng Subject: [PATCH v3 3/5] remoteproc: imx_rproc: fix ignoring mapping vdev regions Date: Thu, 5 Aug 2021 11:32:04 +0800 Message-Id: <20210805033206.1295269-3-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210805033206.1295269-1-aisheng.dong@nxp.com> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 03:33:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 342a8145-466d-43b5-b7a9-08d957c1bbbb X-MS-TrafficTypeDiagnostic: DB9PR04MB8448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:398; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T0DewMlTFGXhPBBPjkiB4xYpzFviSgz7A/oJH1kk0hJvp7hAPhj6DTp/N2svLC59PnxxiPspQnRKKEITh4CxEjdRE5F+pSlvObllhJkVGvqs/UEKHAkxDVhmNLngvfGp2EEZNXgQJ5cnxqCDTkCI+tu1yTlXkBVgrmTu2ar3AZbbCi6+QSEZYjBIui7EQ4VEmJI6Een9e0DBAjGRfAxVYuxTK5dZ8dvLmUJAZEGv1reGhSbft085oiFC2mCL3lBSORMqV7tXpikTveX4Fxen3PUG1WC+1sXiIC/xgHzZ2GUy41V2cDvmESOJbXzuwwt6NsE4RafYsJW0zR6I7G54ZwX933QWsnBxTGTSiB8N1jvCWMe3Zwr4qJbxWF1cwpaodIPnqvaZKDn+bvtmcsNZTCw4q4jkVkih7du7CODmswehnAaRjh3Lzncmmrp8OupuYvxGMu8hIFQ3pGgTXj0pYteJgXlOGW3XVroKF3a2p5rbCnP/JWpmxqyyepYK1OG1O4EV3RczbqHe9+OqbqSvn+orQO2YhDqs8T7m4jsGz5wbOPLG7TSMig9Z7dZxwtoQSj7LjraF7EZBT6hYploaKnwpRY3m4jcvyfFRBAyCXEljFJq3wrLk46DsfPDPXuH0yhEC12NAW6+zdtBB4bfALZ1cb+qvPC9M7IKh971DktUJ61KRh6nnMuOeLPFi4wb3e/9XVxpSBuBaiMdkJDtykw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(6916009)(6486002)(66946007)(8676002)(1076003)(6512007)(38350700002)(38100700002)(66476007)(66556008)(8936002)(2906002)(6506007)(4744005)(186003)(2616005)(36756003)(86362001)(52116002)(478600001)(956004)(316002)(83380400001)(4326008)(5660300002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sGfYNHsfGa5h+OCLdYOyP4hz0rLmwj/jGI8fl8FypGOVcv/67FV3rBG3x8yP+ZCXMulh/qqpKP7DtUUy5aCv141JvorE+eT+MQwf235lOpe5OpJjNKSMQnSb6wmCZoKjInqSqQH2EqbFtY1kDB3m3c2QbfYWUEoV41qvbK9PYmuEw8KfZxf4o2mZcYps8UnaBKTY6pK87TDrSJ6DpcOfqvDKdV8uXx1KbLsGVvTdtogLmU6P6BCCKdI2WR7cDK+ZBPoL82oAftWtSZHoFFH0qqLMcq0AK8RWP9pwMTTPAOPwkQP3Bo2I7WwSWEhmwH+3s7keqO/VheCcJxX6KlDHub621KcuL84R4nHqubYRnMUNn8RP6FnF7G0VRsCg8LtW0gjbduuRnPVh+SSEDhWTj7e66DBQHIuhqlTzhLiSquQOETZ2MOIIFfV13IGzvvLj+ecQlVR4YSNJRBp6jEULxDAHD+Mexk2KVvOF+44jCAx865B38/Ryg5Muvu1p4Oyw0EOR0wrsGt7/w4nOIu19FY8virEdmwPcL9dXHNp3jXSn0038x+G3/FAQ8A/iKyox6CNQXjvKKYcHtOioYJlTRFpd68HFJeZkI25yn6EZgZobSpzyn3kO/z9HahZAee1GOwCB8jCJkSMAgLB6aD8tUHoYI6v9E1iHT/mCa7Oc5NXyTIQZDQLL8RYShfwZZynlUFF0vZ+Jv8VpmxXtQTjLsL+0e9Obt2x7P8JmSDsqKGj/GcO09v6YNZ/yWWySNYeohUqdBDLQPaoOjjwVCaG/b3ZQMUqJs/1vC/H90uii+0h0Vguj3YzxLM/QS6hHNU4GaFbDXzSi7NI+pfIUQ4Ro62JcjuT5WX/GDIspk3gCaJev+i4ap3bJlBIT7I2o5Myfd7SQGtZbUnZmJf9IhYfHinBde/ghqnVjLh7aN0rKlOfbDH1v7m+tFkdcj7DU73mSFVpsaAnB5Z1DrTYY8iY0q5WK3cPwS1fbG7I1fAEiOwp0j7P7npQljmopIy6abvkgTUEfhMe5hh7K/ZsjmHnoP+czyl6+VvyPUs0ba4svkgrSIQAFBQsKderIXWQdhFfwFvVto8LD5PYxmz27AbEUzZvVrGbqLqPnV50oe3IVmEfD5yLCv88MfYEREkI8b1Kd9M5LaXMZseDpdToTzdCbAqWpbqjxuLyD+5Bj2neh56fTGjevpY0t8pvWDchbXljO1UBYmTJimFhbaqdvQ7dclOhkPAcY5eY9OxLtV4lPzjjKXUATuPRbGSD/fI2mcFkN4stVw1oQ26DXqXe4WYh4TIB5IQU0CGgT46n6WNrB5UFVAVug5egbtlfE2+EZAJHE X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 342a8145-466d-43b5-b7a9-08d957c1bbbb X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 03:33:04.2748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Q8o1zVgJF7Pjv4aEQ8zCI9du4oF24G9NLjiOCv57VcwSBT3Y3xhU036jQZ3yteSByLyuYm5RYOi6cS7q5pVXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8448 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org vdev regions are typically named vdev0buffer, vdev0ring0, vdev0ring1 and etc. Change to strncmp to cover them all. Fixes: 8f2d8961640f ("remoteproc: imx_rproc: ignore mapping vdev regions") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng Tested-by: Peng Fan --- v1->v3: * no changes --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 71dcc6dd32e4..abfeac0b1738 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -582,8 +582,8 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, struct resource res; node = of_parse_phandle(np, "memory-region", a); - /* Not map vdev region */ - if (!strcmp(node->name, "vdev")) + /* Not map vdevbuffer, vdevring region */ + if (!strncmp(node->name, "vdev", strlen("vdev"))) continue; err = of_address_to_resource(node, 0, &res); if (err) { From patchwork Thu Aug 5 03:32:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12420223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B07C4320A for ; Thu, 5 Aug 2021 03:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44E1060EE4 for ; Thu, 5 Aug 2021 03:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238518AbhHEDdX (ORCPT ); Wed, 4 Aug 2021 23:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235289AbhHEDdX (ORCPT ); Wed, 4 Aug 2021 23:33:23 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::60d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E2F4C0613D5 for ; Wed, 4 Aug 2021 20:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKSRcPoMcOFYwiUwNtYtlfCIOuN0ZrLFMO00iYGonzLXn9KpiR6OJZzhFAJOb4t0B3P5i6GOpC8NM7JHhOjWihKgaa0r7iJKhNvl9WJDc1J9eXSZ34+ZgzrWfkcLeF+yYtzXXrWyHcFLHQag6ASqps/m1nuyE9saEvYyPlW501sJIRCpNWY9cNhcxmM9/SoCBPE8h1zs8L+ZwLubUy14wMhEvKfapdj+29E8FbTBMzpbt7gjDSQdI1k+QmDkSO+xmaLWnNJzBzceFfgKw9utHoV5tgVw+Xr7uJEKtF90hrR/VpcNWgQX7VEZ9Sbfpf9cbU3ZG5UKf7bqovMhDFIaaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBpBiotzyw//tLTA1XFzKDFQ/dO7RtFjNUmHTpoqKW8=; b=EsbFMKmLkcvzykwiAGAO9grRtpFlWTVdbtLgZMwN51kiqYT2yCwA7jmNyFCQ+M6hzb5RTMN5BOHzKu/pb12nyFc+1EdqX/bEbsJDaa/N+f5Jo0oNhUAX2t858PH+RKhgUo82q/ZozSsQsH4azXktNs1eR99BTrrqNkSLaV43zJ5YJTB3ZM6ElOsPx1UDRMSDNKRVUn4uHtCA9GmqjbBRU9xoa0ISf+nD1muf8Rsn+daxdyJ4ATvgnSjPN2h5lo3/EUf8z0KeGAE4JA4aRUq/HAc5nv4jtPG6jxbuYtcZNd8QdJEViYKcdLRyC+o5BdnWfYKNrAcwgkOoaj0CMQUqHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBpBiotzyw//tLTA1XFzKDFQ/dO7RtFjNUmHTpoqKW8=; b=SZ1TiGDWLEdaY/7Ifr4A+7xIFIWZ6AD/czf8UV6MGSiXmMvENvjrJsAFSTVd1TFFW3xXTUBFAy3ZuyMnfpN9tsL3TB/qu72mkPEY62bj3ml6NaMiBTYfMK2NjUF+TLwR8o+N0W8cQQZiLVqxnfd36W562csl6zgVP8i4m4Jrxbk= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DB9PR04MB8448.eurprd04.prod.outlook.com (2603:10a6:10:2bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Thu, 5 Aug 2021 03:33:07 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4394.016; Thu, 5 Aug 2021 03:33:07 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com, Dong Aisheng Subject: [PATCH v3 4/5] remoteproc: imx_rproc: fix rsc-table name Date: Thu, 5 Aug 2021 11:32:05 +0800 Message-Id: <20210805033206.1295269-4-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210805033206.1295269-1-aisheng.dong@nxp.com> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 03:33:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d751a60-5b70-49f8-d9b6-08d957c1bda8 X-MS-TrafficTypeDiagnostic: DB9PR04MB8448: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JER8vJyykgkKEF/jOx2c//+ClVQTnbWg0Mr/DN1+oPcKPUXKuwxh798aY6id5PElkw0Tbn81RzIjq5TuxB2bexvw2siOLc2gYGNnm3lUnGbHi+4Y/i6/bUh/44acLqi1/VDdfTEEZBh1H0CpZEFKeB/jf1jwIpFXA4OTHTUoOvR1WUiLjNMjfNl5kJk6xep3CfTJlan8xaChxthnA2EEViyQMOsq0VSpz99t2LuEBlpOPC+ZoVG57RYJuG15bROZNcJ/C2ATpFflmKf4Ygra2/NTEXNP010pwcAac2GUAhocclpo8SlR8LIWAi09gTU0q6cEZA+Dj6ycv0HrPPG/XXAxnOA0hn2seME5+Hqd5h0Gz4cBhcmmi3M1RK3pQvrR84bQ4N9I4TT1JV2LbcWPz+HYAoChgafnLB4ps/9gL/s9aPFfdaC51R16UynTQKUloex7VFqgy3zmJUWFhjkL1BbUAcMh3oAvdIJ41e66omUnZKoptyTjoWzObksdpspqaDDUXUi93lM2Gc3Xafv2qO61TkgJil6g2GhzIwC2wrkKQn4xXP3zASP6k9okNi5tXgau7NPjERW0sZ0vsKKvML8rX1Z48nh0Bn0igTlEYU3SoTdFTwof25VNAWpL+tW4jdKwOysEEhfYY9A5tLXZZHw18Z/VQdYPXFUd7Gr9rSir26R+66koRaZMWuw3jXnAdAuiWIeqTHDFtKwTTYxm9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(6916009)(6486002)(66946007)(8676002)(1076003)(6512007)(38350700002)(38100700002)(66476007)(66556008)(8936002)(2906002)(6506007)(186003)(2616005)(36756003)(86362001)(52116002)(478600001)(956004)(316002)(83380400001)(4326008)(5660300002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Musyhlilk3CL8FQQSiBVU3C2fUx208f9CVHdeVkuxmh/YDic9GpD7PDN7//V6rQB1cLs5mfwF6otBHCBJhPRRoBjPef4tyuH15hRya7rug/C3nC2tK1z2eI3UMRbVFX1DfW+urPwoNVsh7e8MgKuFKdVKo8FF7udTdL4ovOTL6g6dboeb/qPBqefcr+X861EMA5afVB40LWAvgeTGfxdbJWZrpgDeLqsKQ9GPIEkCNgH/WqXTcI0aPcTc/wr5v9TqA6IWe2N7bdffvcRvd2ejD53VRgoyQl14LFCrfnKpvSOl5ksARuhUiIorxurwqGn6wGj6GiPr0DnLYa1TIITgERtt1rcszg1ZcBo8qjqp2PgmJ/4+Ae3oMWGRn3ball8urtKt0ciAw1+nnpj0g6NV5r3Xt02jFgQfb+e4YstzByYv1OPFEpiutkcyBvx8tVLPsYjX4ubgo5XjrIBfbGG1PvlVXAslfU7bEnJ6M2HwsNKgchHJ/BjJ4AaGcQRCTMhaX601D+Zm9dI/d3CMmrWK8uQlp8wyW7YCHeZshNugPNpA5wduC1N5vhQwJSEVdJsjT2CSHcbxsmIxsqvtbzxIhs0GeSEb7EnVziB85YPd2PtVNW6bK19p2UGoDenU2MEnJAAOhOOEPXHJjvBXA1gd2griafxZF+UeXPfZIOzOTVXB/g0OzTJ1po+xxw+cWjjEBoGBuHUZno158AzY7pD0H+wULC8w4zWDYxeqJQW5tNglMtFRZvC17FYLbnuKcYiYL0HQK7/vYhurn6lI8g+El44yPSPQJ+m3BEp7Eh24LnzRhQZy5JCJ7tCBWeIGTXtktdXEX8eBXUWrUD/+AngrgkFhlqQyYxtEE0rZe/70GnX1raoJTxzSg+fyQn9dFd6HMDgeOqHpqlSOPQU8rUzXJ1CfqZa2Q6ov8JMwdPAr37xass/h6hRMrzdeAzZ17wygIAzUbl7XML1bITI43rK3lJ/drm0HbY9622SdoATe0feXs5IFBRZXWmdxR+ahY0sqqwj813tzPSuZwWzN4CsOKEnoys8oirn324UPRVLLt9D/rGzDAbwDpl6DvTP2FHhi/I+WfTsiw0JvBLh6dnzbfYnKiwS3DqrUfOfdepee+oG4+vUn8paHnY11DSJRsU9yqkKOxaRhmyvVTvhhIed577gHyd6Qm3ULzT8sd+YCVcFddxN46aYqrcJVFNZfuYgTU5xEPgRB/msASLa9V3B/cCYeCNcovbOq3q49Ik6xPCOxY4E4ex7hPQvVgibqP5dlLVEl5NlBJi8PUAjZAd2D2xXl4APn9M8nVv8FHD1atDMLtkwKidOivrTKT2ojAnN X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d751a60-5b70-49f8-d9b6-08d957c1bda8 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 03:33:07.4598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4anR6IkcJC7kTzHLMEj9vnp51S+RWiiE98kkjg4Y8o1avAcmsqM+yvCYV42DjehSZxndKLVIJ06OUUa9RBlc6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8448 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Usually the dash '-' is preferred in node name. So far, not dts in upstream kernel, so we just update node name in driver. Cc: Bjorn Andersson Cc: Mathieu Poirier Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel") Reviewed-by: Peng Fan Signed-off-by: Dong Aisheng Tested-by: Peng Fan --- v1->v3: * no changes --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index abfeac0b1738..ff620688fad9 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -604,7 +604,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, } priv->mem[b].sys_addr = res.start; priv->mem[b].size = resource_size(&res); - if (!strcmp(node->name, "rsc_table")) + if (!strcmp(node->name, "rsc-table")) priv->rsc_table = priv->mem[b].cpu_addr; b++; } From patchwork Thu Aug 5 03:32:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12420225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A27FC4338F for ; Thu, 5 Aug 2021 03:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D27C60EE4 for ; Thu, 5 Aug 2021 03:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238520AbhHEDd1 (ORCPT ); Wed, 4 Aug 2021 23:33:27 -0400 Received: from mail-eopbgr20089.outbound.protection.outlook.com ([40.107.2.89]:6822 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235289AbhHEDd0 (ORCPT ); Wed, 4 Aug 2021 23:33:26 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hHF/TCpP84qMtOAkITXdjbM8Zv1uXn/0SvkaUl620gHq4fuEkUuiXo3sKgnJ4Zc2cnKOq46b8L31JO/p9YtsFlnMgLM1TZJgQYmaOU6i5DNj+FAzRG73TBMzWqu1yUX4G2tTFK3isSMkbKWj1Ryg7L0Q1T8wxP236LzFuPzoh2w5kKK0lp5zwxf5eUIpEE3Ap2dU45chV+BvQWkt1EQInsXKiPFSwBsxl4mVW4eoUstzIzbmy+EZcTqq0bt0FJzFe4XAyCSzCAs901Smpfvz7+D6sqdhsOM0NZR3QuNKPKAgzJm0jDGTUWb/4lZKHLLwGf7o4bVxs1DWj+HaQ72zoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhYZ+GHfcDIW1uI8dOyAGzRl6ub+6ExE49yh+oSEtG4=; b=HWja7CS/YnQuFpODSeZkncqaSE15aDjs+VSOdSqTbho+Yh2ksmQlLcXu7slDg03Vwl9FZpIODMdyD4UmTjmzA8ZZJsFOTjUOzzh8OOjE2F3ftGrJBZK4ScW+8t+JOnWXCF/P/tL2CAI62SC1JmkWI8p6+v8DC31dTdkXXZ6ulc8yYmgAm2W3RBotQI8Do1rdQ1NjIPa4E8n4Mp0Q9lW3jNwB7OrORmMN1DFhWI1PBBVxBxPUiYmGkrpJM6hUQ3QPD8D6RL1EtDSPh2o286hwhe8QtC/EjvVaGd5j95eKcjjJzMRw0PYWP/gGmxeLyExKpIoFot4T6dwl1jMklklxQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhYZ+GHfcDIW1uI8dOyAGzRl6ub+6ExE49yh+oSEtG4=; b=UXoHLVj9leL0hoNqESy3I+hiY+kjSYuofoZvt90c4RCrj0wwr2CE+B1vo1XrJB6rddVN3MvLtcOzHYkkqjGYWqdGktJ7e1sTpqBaQhFyS/INZEj6f4qlZKz5Tcouo0sqJ1eB/HCFjsqAK1jjwVhIY0wkyo9WRpyKaIAswjl3Jhg= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8837.eurprd04.prod.outlook.com (2603:10a6:10:2e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Thu, 5 Aug 2021 03:33:10 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::9daa:ab21:f749:36d2%9]) with mapi id 15.20.4394.016; Thu, 5 Aug 2021 03:33:10 +0000 From: Dong Aisheng To: linux-remoteproc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com, Dong Aisheng Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Date: Thu, 5 Aug 2021 11:32:06 +0800 Message-Id: <20210805033206.1295269-5-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210805033206.1295269-1-aisheng.dong@nxp.com> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-ClientProxiedBy: SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR06CA0085.apcprd06.prod.outlook.com (2603:1096:3:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 03:33:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37c36038-00a3-4613-736f-08d957c1bf8f X-MS-TrafficTypeDiagnostic: DU2PR04MB8837: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u2r53EPmBwCnz5Xm6CUnhR3aKr5l7OuIi8uA4/waM5oVjX7khUWtw36nQN0daleRS7MLtKeibMj14qvtwTDkI1u2nybxemvF9tCTixGDGJl7u+oKzgnJrwjEOWqkpCAXxcd8Q6JX8iXq7gBBxs5pQC+P/T0oHklDs2McaZE+EbKhdj4ImjnUoP/3IO5no9P8tDqEmk+f5BLjoKB4BeA7GWwHQoNR89etKIfQw0zKhZjGoi6rw1xd3EfV7YQuo0rhJEYBci+/SAO2Pg9mAhoKqilJrU13ytzsKkOGKTzT5kifF6wXaffWjfi1tju2obJz+GNM6WzwWOGLQG+1ERxqmOAh80/luP05v5CbFAtjRvOr1la5rhqDMcGXMSAcrrLn8l/Yjogjr7VJZ8YdOnmr7ZnCiB7kEq4TxXh7fdf8k5270F/YRimMBzQkCX07ie6i7eXrfFwsx9tU3l3JxvwPlzOLzTeXMhOvYiYLQUUmKxprxHHJbMBkr7H75/SmVgVbTZA1iR/R5GgZIPbPVwT+sLTSfv3a3z2Gf6m9KbqEhxTGD88vJze1PRknjKjyEdp5CWDExPie51cSgxd5bh1ihdXf5IjHB/eNKX9hxFwmBeglovqCqxVBTZt9dJcGSVqXLEZq8jGuP0ir1YZ2gKdhYsS2jHpOB+jHuwveWyYKT2m2yqtuw/w2uWI1IZIEvvy7GYhpWs82nmXEZQLGJTFKtA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8477.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(36756003)(83380400001)(8936002)(6512007)(316002)(1076003)(86362001)(6486002)(52116002)(2616005)(956004)(38350700002)(2906002)(38100700002)(6506007)(478600001)(26005)(5660300002)(66476007)(66946007)(186003)(4326008)(8676002)(6916009)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2JO+PrugtEq0JDQR8B1FbGJCJti1EO0I9Dwrn5wM0699vZYme333jL9Ds6OA7/7KAZinpsj/9eiHig8yoqKVn7uhS3Twce1x/5Ap/7BZP5jgy52nJDE+Y3SsnmrlmhpL401yllEc7YiuQkHjMCiipVzUN9dxTwta/1F/530l5W+1lt7qK/uhBiXBy26worr7qACEto+6zNXdfW1Ic7fifliYvtgQVEYfh4N9GI3bAbyFqxkK2sCUaghXFnual+QBeXSG8CrOy5ZUYhrU8A/k+RdeTcGcQ/xCukJhYh2DG47Z5QoYDrT4cOGQN/ceLV+x39nPNGBd0naGajmHssoSkoVIWt9Ki1KXrXIIDwLvrwbC4KPf1BFl0QIYPTsZgUAcAy5tLbPMxS2XMe9gae9ACr4iYJoEPeyKH5ijCRBHNBj+a4xA4xXWdocbsoATMJ8wBJyE5DikxYmPGiXxxLVj2DMYRpw+wBTu9NqlWeHa/aCj13VIRk35yaSHV6n+aXTvOJBAdslcW5j/8ACyXhB03flL34VCdVXLcQbMpxr90UCth662F749tUIJfPNRPBtoSfyDZRlNBc7v/5TNOu1MpAzbhy8aAvE3T1TtUbDwOBg1qYnYSrBeR6J6Gc5MMS/m7Xq+tCOTEvNT1OoE6N5vurxFrhEA+1gFsfJ//6S9Q1wFe5n3th5SgBPHGbBvjkzwhMpPK/EuofsPmY61qx1Tez8CK8oXx3q4l6W+chrPiSaE7DntvGCkF5wC/dUniZ41JXKANpQrd86yg3gEXd1ifGIl3biQ4a0R8AoiNoIFdqISaD7EBUo0z+xdSfq0pTzcw2O+3/XLTPLd3OMQNkWEnpkzZpiGZkaDef27rLu9Wco2nKa4tzdHd6QZMoAq1T0FPTB1U0Ns5CowOWXug8Dnjji/lh5HOAr2Wh6YQS8D8CqF7377xwi3Zsi+bDOnVppys/YtdUh7TrRnlTwDo6faaadYQw9egnjjO8taQsZZd8CrONjSQ9lpmywjM4BPDSM4OB+7VNzgcamTUNOzXgXr2t4Qygiv9PBAbu0lzX+lRMDqhxcpqKcqFwvWMr0DgvVhQ3tfr3YTRz+fZZA3IFTNK1nyOAn830qTyQCkfNexHZcEuJExvTguU6GNLq0Jvmw2x6BsFGP2QfmovuCjmlGbgvQwf5x8Sy8gi8S+go6Pl5mWeB5NNu7fXyMZIuZTrrAQKPXvMAtdDfArtjvrP69cQgc0IFbhfVWv3MBUT+m7SIbc6ll7MIzwKNR2+Rv4cESwDzphm7Thre4Nzn34WJIqd9fzXgfzSax0pvX+scH8833e2ZlGnjZmr8efrx4K2xQS X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37c36038-00a3-4613-736f-08d957c1bf8f X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 03:33:10.6338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RBZPibbQ/NeX8NdrVcKWaXUIYPJNcQOo+6bc5HiK6/ZS2Q9Yyk3D4DQJzO5SpTJvPEgZASHa78Dn0TEX3NH1/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8837 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org DRAM is not io memory, so changed to ioremap_wc. This is also aligned with core io accessories. e.g. memcpy/memset and cpu direct access. Cc: Bjorn Andersson Cc: Mathieu Poirier Cc: Peng Fan Signed-off-by: Dong Aisheng Reviewed-by: Peng Fan --- v2->v3: * patch content unchanged. Only drop the wrong tag in v2 Tested on MX8MQ and MX8MP, MX7ULP. v1->v2: * new patch --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, break; /* Not use resource version, because we might share region */ - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %pr\n", &res); return -ENOMEM;