From patchwork Tue Aug 17 04:15:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947D9C4338F for ; Tue, 17 Aug 2021 04:17:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C22960F14 for ; Tue, 17 Aug 2021 04:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C22960F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mTXmBx3XaFZGwQtiqAPZ9kdUQZyETZ54Jj4UMQEyOY8=; b=ac2k9COiCOaT7q syVjB8cxhqu8BPhEwBVMtin3wFBDoR2e7CevAuncRCAxrk5x3wWEm5mtx+KlBv2k4gHAoSsXisXLA 9LX1btUwD9E1DPbnDwItZFs9eoQyS83351BcOMXltGqtFvPzQ/CggGSKFEhsJ5h5l8gEm+sNjUMD6 lx+pnZxKAXPEi2OOzi95ytlUwJig843yhzmDfQgCOdeSrj5i3SyAe7OEOOkbrygkkZEsRyjQNfU4V 4eWx6/yom5h5lEN0wHePUnntrzIM1WHvH6l7Fc0c6qN7NAF2K6evdvwKl1IyvTmDe63NMHKHiU5jU Oadgg7pIaDSD9pkEa4wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqXs-00155v-VF; Tue, 17 Aug 2021 04:17:48 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqXe-00152X-Oa; Tue, 17 Aug 2021 04:17:36 +0000 Received: by mail-pj1-x102d.google.com with SMTP id n13-20020a17090a4e0d00b0017946980d8dso2776673pjh.5; Mon, 16 Aug 2021 21:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aFbf5MZvdHne2nfZzSqkqs09pAcRMOYPxHTfv7PVwSk=; b=gIdDzzrbItxf9RBdIOJGtF1f1VKiW5B81efUiKJIM5vqEKjS7oaj8l2DsTlGL6NhFS pN/dDl8WnWH/0KBbCXmvvTm2SddGx/fi9o4bYMqTNuBg9Ok76Q6NlhRXy+SeVZZjWyYj ljxtinJfGm1kAVJfWKWy7PsHuLQNAwKxD6ao0wignJAajpAehmE6Yzb0CdrjH75Bd6GS D6UQhDQ2Dz+/zTz1ANlr8RcyT9oA4J2vRwP7MEeGOGiA1go4rEy2kpcCJXjzdh1A/Qwt +dc+xZVLYZ40/Y1RAreCe+c2Yr/kMk2vQoql/JX3TYrqGDzpO9Dv/YWUWb7+mTBsaJ3b 12rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aFbf5MZvdHne2nfZzSqkqs09pAcRMOYPxHTfv7PVwSk=; b=AZWB4lU2Mao+KZpsuPRIYzMssFPjAchIsEKbnjhLUTw/NqqxJ0GjCPZFzWMIXETG1p 8f1j5EOVNNmZPQ2obYULFHB8hnHylhn3GrB1cENaFN3IcFq03oUEF5nf6VRQOcLifXFK ToUhK7dQnGYi2Dyd59D4nHaB/uSJzDGVfDgXh81yi3DGAprfDcqdh2N5ejoWd7AZZZZx MFoBbM9QIpQ1xbsP7zGQ6uruig6kdog9xUYp8V/k7vzA3KImBPE7FP7xqsQMh8mRfbrJ xx2B//NhcWrOTYMBwb73hLB+JWKV8/mxwKe31SpDTVPSxxOT+TR5R1KLCoj8sCnFONyO J+Cg== X-Gm-Message-State: AOAM530clSVEtYqzQb/b7mm3hT1gG6xXJywXMuvAGgtPvGkOIjyf1Jc4 +LKqvYT+3KUJoEjs8UppyQSVhWQUpphgXw== X-Google-Smtp-Source: ABdhPJwUmgJHOYZGmqb7CZ/IPnyklBdcoU5GSH6oVqioOWLbpzvI57uFAQR+YepvUxw6cA9JFgqcEA== X-Received: by 2002:a17:90a:9308:: with SMTP id p8mr1457358pjo.119.1629173853769; Mon, 16 Aug 2021 21:17:33 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:17:33 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node Date: Tue, 17 Aug 2021 09:45:35 +0530 Message-Id: <20210817041548.1276-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211734_843307_06936E78 X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Add missing usb phy power node for usb node fix below warning. P5V0 regulator supply input voltage range to USB host controller. As described in the C1+ schematics, GPIO GPIOAO_5 is used to enable input power to USB ports, set it to Active Low. [ 1.260772] dwc2 c90c0000.usb: Looking up vbus-supply from device tree [ 1.260784] dwc2 c90c0000.usb: Looking up vbus-supply property in mode /soc/usb@c90c0000 failed Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board) Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- V2 > changes gpio polarity ACTIVE_HIGH to ACTIVE_LOW. Fix the source power from phy-supply to vbus-supply. [1] https://lore.kernel.org/linux-devicetree/20210716103651.1455-2-linux.amoon@gmail.com/ V1 > Fix the Input GPIO polarity from HIGH to LOW. previous version [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20190113181808.5768-1-linux.amoon@gmail.com changes fix the vbus-suppy to phy-supply, drop enable usb0 USB_PWR 2 1 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.0-phy 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index c440ef94e082..30ec6a7f20c7 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -32,6 +32,23 @@ emmc_pwrseq: emmc-pwrseq { reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + usb_pwr_en: regulator-usb-pwr-en { + compatible = "regulator-fixed"; + + regulator-name = "USB_OTG_PWR"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* + * signal name from schematics: USB_POWER - P5V0 + */ + vin-supply = <&p5v0>; + /* + * signal name from schematics: PWREN - GPIOAO.BIT5 + */ + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; + }; + leds { compatible = "gpio-leds"; blue { @@ -119,7 +136,6 @@ vcc_3v3: regulator-vcc-3v3 { regulator-name = "VCC3V3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; - vin-supply = <&p5v0>; }; @@ -382,4 +398,5 @@ &usb1_phy { &usb1 { status = "okay"; + vbus-supply = <&usb_pwr_en>; }; From patchwork Tue Aug 17 04:15:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA28C4338F for ; Tue, 17 Aug 2021 04:18:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C41960F14 for ; Tue, 17 Aug 2021 04:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C41960F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nou+6MoAQ0RmBOPmrKTaeaupV19EnPLOYaP+Y+rNu+Q=; b=EiH3TnCOOtTIAg 1k0Bv4qV5puiTyl1ZNM/Ymh/kL4Plb/HRuCsz3VQ2ZSKzUFHFnV014VFjlmYZnWvMut2MkO3OZ2gH VLt/zf0eqHiPTmzk5SsmMZZceokOmEXamLuULaIO31b+YUJ8zLBIrYkUfEX2NXYBOikCYVgZ6sr2o BI/4fb88j7IKtSP9/AdUItmsgSiOdugj7JZcQXUQ5j57jj3Ra+UTvepAKofX3aibG8dZj9sD9TdFB 1SFoQBK7w+qpa2ay9FAOpBu9+onJYAvnnAxcwL4GUJFkM8mH8OPakx0vONTe0A2AmEW4iuC1hi14R asT6kqJTaFGe7oNC56Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqY5-00159p-Qx; Tue, 17 Aug 2021 04:18:01 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqXr-00155A-KW; Tue, 17 Aug 2021 04:17:48 +0000 Received: by mail-pl1-x631.google.com with SMTP id q2so23289787plr.11; Mon, 16 Aug 2021 21:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WrPbB+5M+oz2QlTFFMfglVQ9FsfsETR7zFLPhL/v+Rw=; b=IzBlfkAauUlpDjMMtmgcL56b6rzVxn983ktKVXmYuw5WA14jv7Sz8mZ/wFC9eFLio6 0hZIlKatszcNOgM4pGyPfzFaXs0fp34CVSWt2/eK+ZH2faDbDZdHxWQaYcUIW/eOxYVH ZWYdGMYMk5lvmGKGk8GVbrNfwKhDNBxGSNGNUQrnGjaEhPkOEQrY33HBAUjKvDFKx7E5 Fuuw3Fk2yRdwQdKT60q4LRuhnT0OM09vM2/4JxFhA2m6ksE5Tk4V0aOVPdEmb1k7D9A3 NMAt+3T7xNAA0hmmmJ+VEe+WBt22c4IYYthiV0Xc2t2XIvwKjj/KSlelK4IUkv2eJXEm 7wZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WrPbB+5M+oz2QlTFFMfglVQ9FsfsETR7zFLPhL/v+Rw=; b=d4391SpKgyczIWh+Q8FyFd2+yg7fSDfgbvhA3/2mSfqWpYVJBTmH89d46MeUV84JCn 929Og2o8SNp9bKzIytw7Wi9TBFpmnslOkhGY6KHbsw64spXRqDxSe2/eEsbNo5hsdqlp jKvkV7iNXj79Az9kx8cOoydg2mmpzY9a8MOTL/huxVNGk4gCjIA/6CnVx573I/tDLQ24 H0BCEdScqd90NGgi9MLUG3umVp84spAFKl7H0PQ6vbiogT3hUUYP/ZHCzrrKEpCmDbi1 vVaOOrGHvj5zrZgYuqrhnoPRyo6MA+dpy9P5TaLCe74Cdw3CksNFmzlMa3JpZnr6wFjR 2JDw== X-Gm-Message-State: AOAM532iSLgxaCdgeMjPsXSOIjBB+xBtHrqp6+CRpT9Mf76E+QYwiKJT DvosJWllqI+bfr/IS+4AH4Gy9ZbzPFGCaA== X-Google-Smtp-Source: ABdhPJwY6Z5H8ETjkybmV0OLdsKQHAgPwHpXa9txzJwJRXyWQbn3jyZ/VpzTqUkwJTiyNEcNhD5F3w== X-Received: by 2002:a05:6a00:24c1:b0:3e2:1171:34dd with SMTP id d1-20020a056a0024c100b003e2117134ddmr1619553pfv.27.1629173866630; Mon, 16 Aug 2021 21:17:46 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:17:46 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 2/6] ARM: dts: meson8b: odroidc1: Set usb power source to always on Date: Tue, 17 Aug 2021 09:45:36 +0530 Message-Id: <20210817041548.1276-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211747_720359_AF0377F4 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Set P5V0 and vcc_3v3 power source to USB to always on so that regulator should not enter in suspend state. Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- New patch in this series. --- arch/arm/boot/dts/meson8b-odroidc1.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index 30ec6a7f20c7..5e5953152452 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -65,6 +65,7 @@ p5v0: regulator-p5v0 { regulator-name = "P5V0"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; + regulator-always-on; }; tflash_vdd: regulator-tflash_vdd { @@ -136,6 +137,7 @@ vcc_3v3: regulator-vcc-3v3 { regulator-name = "VCC3V3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-always-on; vin-supply = <&p5v0>; }; From patchwork Tue Aug 17 04:15:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526ADC4338F for ; Tue, 17 Aug 2021 04:18:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 181A060F14 for ; Tue, 17 Aug 2021 04:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 181A060F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5i/XAh6QJFt9bZ9fjKyzCJVJ+CjYTNQ7hHql1eyOkqo=; b=OMDpdjKwx45JFv OJrXxwYnjmmgdL+khFwT8uE8eba9SUBk3nwOz4m2u1exKSTpbTNRW+yZlazsLEFqTutql+X8rzw2U tp4jaPtKQt49pLxyMsMIMaf5Jp1W4RTUIJkYLBKFqAbzH+awJstsTkoYbcLs06JDcP6upqGqbAT5l 5OOROuWLx3KOqS8XjWQKO9nMZjJhwpf/svEvLO/IaMgcl3JqMgbKnFkN5V/vIlAD2dwMnBWxnvlFm qBMAAtY6PFltfUqTQiYrxM7Yy2hAY7oCSIk1yaEHp6iU7LbgJRKeaH94rucQLIq3ET6sKcPN0w7di Y//dqyIcYBSm8oqcM5bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqYL-0015Gg-Dl; Tue, 17 Aug 2021 04:18:17 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqY3-00158v-OK; Tue, 17 Aug 2021 04:18:01 +0000 Received: by mail-pj1-x102e.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so2857933pjr.1; Mon, 16 Aug 2021 21:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PpxBu92wuMGjuu73ePdt2ALcCgck/seakH/934m3wMk=; b=n5HdRhWN5TbSsnCX5eXDbIAbobwmKyo+CHqfdwkqrdHQnVLWXT8u+L8nIGHr/ECqzb LnEjs3TlTcURBN1F1O4OnGvtU9DhfM16sEj1b9HqXw4SBXTIimi/6pKKRuVvJz0RX65o wC7lDDVsPali39wzzZaYD6xBKsF+3meHaUR9BFSo8QlGS41AWghmEocachcYu+qygeDD ugY8xvQggKaURnuY5a3tr9/6uw1apcJav2Tb8OBA+lu/NLi6TlsmACO6bVzj0KVzDQQF huxwClnFDfmTO2ppMM8PEXUxM4vSXdvTFzQJz8cwQ9PxSLg8O4rOq+IUeau3DRAlenF+ M++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PpxBu92wuMGjuu73ePdt2ALcCgck/seakH/934m3wMk=; b=uEcSGycavoIEkutXLuG3C7Y+CWNJ8XyORNZfFzBML9temuHPtuUFgzgEsi5qchE8nP DTlHwT2Ei7xw4gNE/zxsfenKi+M3UX/cPbiousm2YezoioTs+IMvw+6vSR3d699QYEdv aDfOSQlR0Y2Ori23/M7HiuCps6YOiVLWKlsbEpy2bi2Isz/h/Blkxhlw3xVJtKBEKVPa EmLTK0SpW1KmLbLbL1GXZZmSQG0nZNL+6B0xtWyxoT5G9alBTgZJFh/dL06DppakA5Q6 xUN5dcqgE9dLTB7bW/TryngFiudR6l+AtQnsGOJ6ApE1GDmKMoq4rVz5htv1VUrywG2W m4Pg== X-Gm-Message-State: AOAM531GlXFNVFi1sLCtV1NspHILKwfVKRnobrkn/QYSvkgK75fd66jF lsQdzWM8jErYsBr8LyudTnDPFYGF5TL3EA== X-Google-Smtp-Source: ABdhPJx9t0wz2w+3ZEoqQyOMi/HcbFuDmHp37FDbVUWs25k7cQkfmZM1eB4P53YnrNBeune7MzcWuA== X-Received: by 2002:a17:90b:4b45:: with SMTP id mi5mr1498660pjb.43.1629173879025; Mon, 16 Aug 2021 21:17:59 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:17:58 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Date: Tue, 17 Aug 2021 09:45:37 +0530 Message-Id: <20210817041548.1276-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211759_837990_76E47519 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Fix the chip enable signal changing from Active High to Active Low to enable input power to USB power. Also updated signal name as per the schematics. Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- v2: Fix the typo: shematics -> schematics --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 201596247fd9..3f4f16a5dedd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs { regulator-max-microvolt = <5000000>; /* - * signal name from schematics: PWREN + * signal name from schematics: PWREN - GPIOAO.BIT5 */ - gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; /* - * signal name from schematics: USB_POWER + * signal name from schematics: USB_POWER - P5V0 */ vin-supply = <&p5v0>; }; From patchwork Tue Aug 17 04:15:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440423 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC70C4338F for ; Tue, 17 Aug 2021 04:18:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63A2B60F14 for ; Tue, 17 Aug 2021 04:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63A2B60F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iyXsSsLgodLKRwpObVIgSX+tWNufFz5HFAa9YaC0Dz4=; b=r8uMYsT4GcTG1X vke0eXA5ed8eOI5rqaRoj92C0St+YQIYnDfsbvHH+rrMy3Iz1Y3zIIj/iuBL1wFqDwAcVGFc1vMrT gucdrNyBESQcFNDt1MIUEfqaA7escDvSo7sJE6XfBPOJyKpYxOTdXjduVYDdNjHnnl/PGUXXtzNjd oSQyL9x5YlbcY7iaN5Ng3oHxnYhVbZQpIcILkMkAfgkdzDzw0yzhtrVa2AU5Gta7UWWzviadEcVBR 94DbRX1VYe0ZISt5UfVadhlHC0ACF08/Xn9Lhc7BXk2uwvvCv7dyDeeXv1ezHfHOpgnCkhETOvRXN sWbACMQnBinf4fFxBiaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqYh-0015RB-3P; Tue, 17 Aug 2021 04:18:39 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqYG-0015Du-4j; Tue, 17 Aug 2021 04:18:13 +0000 Received: by mail-pj1-x1034.google.com with SMTP id hv22-20020a17090ae416b0290178c579e424so4138430pjb.3; Mon, 16 Aug 2021 21:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qmVeyhKiZb0zIqPGmwLOmayId0eC03bF22fmrGDOy0E=; b=jmymeSrHo7vr4RSmMpg+BEmhKUQli6sFp0rFo9D3+E89ww7eYY+HbdlJrUxWxftooa BFTOAVErFz90/swbCz5EBMx8JO63ei9tsXSZpZ8KiWT9Msp96N1CwKJ6V9v0NspRpX4v x2zRy0eZ1AZ2EZoNgGTQsnVVpjtMU8qkAasHRWpADvgiRj+KxQMW1ex0eEoYR2E7Cf/c ejupe1OeSlL73y7DCERI7g0OApZ9mJrizuwBmlLKj657fC4qxsYwGxuxhPnNZb1g3M9I UL/YkduJuvzi5nZSLfq6DUir/v8ABjrpKHo4Y21l7i2064zRNicPImwRrGrIGhqR64ah m0WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qmVeyhKiZb0zIqPGmwLOmayId0eC03bF22fmrGDOy0E=; b=ACoiun/rKCCWripCokYHDQjskFZKpRrJEyzaDKNMgsfLlqr0NFXWbpEOJu/OY6MML7 gSKqjzDNnLid/4IIm3nu/DW3eptp6f5CFNQr2crgEloPGHuUK9H7KfIJdb9mXmSlNSeN Pf2R2eR/DM/G2gBqv2FIQkdGgd1ai/6B513QJh9r0u97+JacDC8scaXwOdjo4hHUc9yn DmuxZfR0dbH6E62j0o77Q35fVNHJpsLog8lLyHhFK3OCMpavqulm+vUSMtLQpC80uR85 RmnJJOP4gzGluJwL3afw4K7lZvE1b0lPIccWjpYcf6mWIz0kAY9GdF2RaA1DM2HuyL1T 7Jnw== X-Gm-Message-State: AOAM532uba/y5AuJrBPFqrBSjEjtT5zKhvvpUflqmIb1uaGvBatAgcN6 kJqmiaq2r7pJcKwViQ4g2R8bLigAprGTHw== X-Google-Smtp-Source: ABdhPJzJKgheXvAVNXiCHRktmaDbDCjw9+UQXMmXIXMck1UzOs34Ekk2v5ohhN6ywg/uss/MLZ55fw== X-Received: by 2002:a17:90a:ce0a:: with SMTP id f10mr1461562pju.71.1629173891353; Mon, 16 Aug 2021 21:18:11 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:18:11 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 4/6] arm64: dts: amlogic: odroidc2: use vbus-supply for power source for usb nodes Date: Tue, 17 Aug 2021 09:45:38 +0530 Message-Id: <20210817041548.1276-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211812_237019_56B87046 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Use vbus-supply instead of phy-supply as power source for dwc2 nodes. Drop vbus-supply for usb0 node, as it will handle later. Fixes: e841ec956e53 ("ARM64: dts: meson-gxbb-odroidc2: fix usb1 power supply") Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- New patch in this series. --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 3f4f16a5dedd..01bbfc4c091e 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -400,12 +400,10 @@ &uart_AO { &usb0_phy { status = "disabled"; - phy-supply = <&usb_otg_pwr>; }; &usb1_phy { status = "okay"; - phy-supply = <&usb_otg_pwr>; }; &usb0 { @@ -414,4 +412,5 @@ &usb0 { &usb1 { status = "okay"; + vbus-supply = <&usb_otg_pwr>; }; From patchwork Tue Aug 17 04:15:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFF7C432BE for ; Tue, 17 Aug 2021 04:19:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC01960F14 for ; Tue, 17 Aug 2021 04:19:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC01960F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0bmLCZyShx0Mjacq7xO/DE0H3gGZJMdvFXb0sQWZmY=; b=A3zo52VAatCMXf g2NvkGz4cel9eqf9CmR36WV3q0MHr7a4npIKsrHNBamDzfnLnYe8sIBw4JS1y7cl83ynnp9y0Jz6H EAnojlHfRTIEp3lFBKH+Vk1PRrBXtB+9tiMKls1th29RD4B8Kx79jn2Bjlx4gck9ugCpGZ0np1viM 513XmPyCHNX9cmrvTi+dcZzhYrwDBF5Lf9/H7rNBrygzVDjt5cbddvkjDSR22RTiQ0rYIAKEmHTcz BFndbV2U0gfTPwrtvvJ857UDj798fRB+h6ePPR/UT5rZyOjjtjAKc563336KIWgun5CxYTtIDdO+I WbVb+I3Z6vxNMdce3NtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqZ9-0015gE-1o; Tue, 17 Aug 2021 04:19:07 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqYX-0015KE-07; Tue, 17 Aug 2021 04:18:30 +0000 Received: by mail-pl1-x634.google.com with SMTP id a5so23309095plh.5; Mon, 16 Aug 2021 21:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/De+hbEmJZRZ6r7uVfFxTcLTqZUJMY0uXYnWBmH2jqY=; b=UPAVPx813tLu01hoTQDKKDPD4TQMFuDerro+n95jRRkWNy/RT0SO9DflqJSdOXEpo8 NF945T3KYbr2dkLX7mCJrv7oCbijYqRDHaaGyMnJAsNhPak4th2ei+E7Fx/hS4KXN17u 9Bfr/UD9Ljtn0WCNc8MIlqC0XMbkiSx2HxBediZuEJLik+RtWAcjsSIaacEN3TjxETqM 5Pjlfvj/l/d2CcCrQqXYRj0uiAIO378u913DdfIfKVZaYqz5sFVbHUQWYDkVgVc44bxA 955YSQk32VnaKwoPsd81yupWYX4H7s0Ycddn8ref6yXZUkWdwAZdb2fzYlvDPWU1ucyO bV9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/De+hbEmJZRZ6r7uVfFxTcLTqZUJMY0uXYnWBmH2jqY=; b=pKQe20spHwyKwuwUQOe7CtSKMRDq7KH5MkF+Wvlykxg5WQEYRLCndRD8vPEpbMPrZY KJ0z9Jjkx5KZBllf9gVeQhruK32MrT0VSnSegCK4QGJUJ62W295sU0lmhaei34yFgTF+ zMNJoQj5crFbodNxsQzef1l5lHgBcVoCmSrrKOMyCqx4GjNDW1xUky7rrTp7ZZDOEmhj lgoWA24qAj7AeqdD3hCv3QW1Z0HPLC8mYJLByTI010mYHrM7G3DTR67aiJWb50asj6kG TV40K4pyox/sByaJw4yHTxMK6mMLQ46k9Ywtevaz2ELOZnr/TgvJQr7W0wqkhQFO8ITQ vljg== X-Gm-Message-State: AOAM531WVvbcWU4OjN5O99HPaVfmhQ1iZE1CMz7JaFua/+esu4RjXrJ0 CC3iW8BAp+QGl/mdq3c1bLi4fsoga3AUAg== X-Google-Smtp-Source: ABdhPJywvJvBG8K/pH/TB32oj8Wb9Zx5SLgjCuvw5NL08QMtDpkX72qoocsfu3ggRwCUPivhw60K4A== X-Received: by 2002:a17:902:7294:b029:12d:2434:6d26 with SMTP id d20-20020a1709027294b029012d24346d26mr1359556pll.59.1629173903805; Mon, 16 Aug 2021 21:18:23 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:18:23 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 5/6] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Date: Tue, 17 Aug 2021 09:45:39 +0530 Message-Id: <20210817041548.1276-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211829_099564_48C4771D X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Power off the PHY by putting it into reset mode. Cc: Martin Blumenstingl Acked-by: Martin Blumenstingl Signed-off-by: Anand Moon --- v2 - None --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 03c061dd5f0d..2aad45c55494 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -219,6 +219,10 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); + /* power off the PHY by putting it into reset mode */ + regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, + REG_CTRL_POWER_ON_RESET); + return 0; } From patchwork Tue Aug 17 04:15:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 12440427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA50FC4338F for ; Tue, 17 Aug 2021 04:19:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D4B960F22 for ; Tue, 17 Aug 2021 04:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D4B960F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=guFmyfI/UkQVU59fTNlG4ALF/AqJ7kl4Q36GdygutW8=; b=fsVY4nfR25riwz EVovn+M3JHYrfUGpHcnESr9N+AjRHER4DXQ7xgDr1ATE/Qd/KBRWxDJNXVmxdd+hyxZPXk2WQ4Uel bAMBtG2IgCi8h57zfCEViSAbZPJAKx6CAKtl7ORS+9IUMcs6Y58tPcMLVKysQYm2V9YOTU+Jp5/Bl HlSwgVhf3hJOci+GiakZ5so3MzZSa6UCX3dq2DIrM+ik1EH9MhdMUz3Ydvl2fWp4fEsq7QG4KD0Af OgTxIZgYa91vrD/N0YTz84kLRnC5gFr/e5Q5ZF3iD9Cy/5YD0DAm4H0ROpzuAwAvJBko209el5kP5 snJHpiAfU+vg6J6AFiPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqZl-00160u-4m; Tue, 17 Aug 2021 04:19:45 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFqYf-0015Q3-FH; Tue, 17 Aug 2021 04:18:38 +0000 Received: by mail-pl1-x62e.google.com with SMTP id u15so7880132plg.13; Mon, 16 Aug 2021 21:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rvpv+8q3g4xCHMUozwIBpDBoqFRGyAKVfv9xddtyv5o=; b=ArRnDWoSagJFh4S5NLbf/Ola1AVbgrrsrTUdIAh/Fe7CUJ6va4b5YgnsxcVOfY16uP fjDXyZdxRvxHSlNJXWy3dzPAo/psaerexJAvkPeixdGHrWO3EmRtCM+lH5cYtLcHIltz zbsXmYg8TiK/IvYSdfRXsSIZ0qlKpgry0OP/9AAtp2v+BAUPNdORRZrVi/QIGVVtSQu7 s2hbIcvd9FsG2Mxi7mAqO45BLJUEh+Sp8uIzWUJ1u6uGX5uF+sevXdHKcuY8P0N41qVj Ctct6nIPCWvaGj79DInYH4tlD/ARfSQMtstiJRTwHEVkdSZAyPXPCqM3TLZCbTP3gH3+ LB8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rvpv+8q3g4xCHMUozwIBpDBoqFRGyAKVfv9xddtyv5o=; b=Xpgkq8nocxHd88kalMNFrYaRPCL6/h2SH0HGs1uaMHYd6QKdE1Ga8hy2nmGCNWtirz NbhFZ0IQA8avv0MKcepazuiR8UhQSaQWJ2i7X6WXpQXn42g+twZ36pC9Usligc+yBydK D91zWVzmiBZnti8lIksMP61/zvQRJrcQKvZ0yDRiSabJpJG3Cj0pOYONUMAmPisg0wR7 ofba+tkTZCCNCpmntGusKoLuvPzVoM+qzL0R+urFa6I3qk6iYl/dK7E/QKdKbP7nJPe+ 1HjAHEWH1oM8hQz6aIcAz+4cPxP4RZ3R7yNSHSPUbCDevJ0I8OAklBjIOjOej1aCvS1x 8xvg== X-Gm-Message-State: AOAM531g3/FR5SKBTGRWwBYU9X6XMR5nP0kv0x+7WZaCwmnuOQm0jbs8 ACtCXIdJfGCVckNo4m75LM9xPcU3HO4N6g== X-Google-Smtp-Source: ABdhPJyfFtCrZ2P3scFr8d1eXqGQaE49+b6pBgykLWEAqZG3Y0vHwldNwb59wz/fYDPbKVgezj55LQ== X-Received: by 2002:a05:6a00:cd0:b0:3e2:209e:4e30 with SMTP id b16-20020a056a000cd000b003e2209e4e30mr1630426pfv.59.1629173916369; Mon, 16 Aug 2021 21:18:36 -0700 (PDT) Received: from archl-on1.. ([103.51.72.143]) by smtp.gmail.com with ESMTPSA id g11sm705676pfo.166.2021.08.16.21.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 21:18:35 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Subject: [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Date: Tue, 17 Aug 2021 09:45:40 +0530 Message-Id: <20210817041548.1276-7-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com> References: <20210817041548.1276-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_211837_630425_A65BEB92 X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org devm_phy_create can return -EPROBE_DEFER if the vbus-supply is not ready yet. Silence this warning as the driver framework will re-attempt registering the PHY. Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Cc: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- None. --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 2aad45c55494..cf10bed40528 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops); if (IS_ERR(phy)) { - dev_err(&pdev->dev, "failed to create PHY\n"); - return PTR_ERR(phy); + return dev_err_probe(&pdev->dev, PTR_ERR(phy), + "failed to create PHY\n"); } phy_set_drvdata(phy, priv);