From patchwork Fri Dec 7 10:52:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Caione X-Patchwork-Id: 10717925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1256F1731 for ; Fri, 7 Dec 2018 10:53:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0006C2E057 for ; Fri, 7 Dec 2018 10:53:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E8A742E06A; Fri, 7 Dec 2018 10:53:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8520B2E057 for ; Fri, 7 Dec 2018 10:53:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JvIn5fd/fXkIGDhbQVaLo7drGVHHrOD6oYlRKoAItAY=; b=JouHczXyD8QWor YjoqdXxTQ0TrdIrZJPokWrPCnr2kgDl/3MlNcaC9g+Ug8NLgXAiR81GjVs9TaUHu72zbTE+JK2DjW dIGSmM9GYeuKFZyithSZF0cW3HakAtjXhFzD3Zkj3FV0J72tY/XlZlsa40kozwFC375QMyQtP7u9I 7pAWGJuZSCG2Dq+yBJxMXo1Syx3fAVbdFGg+y/liJPGbdR+sDi+jd2e/s4KB2t2PpIfUD0QCG8cTJ 8+lR9X1QDRX3jgoDZoNwq/PrvjshMOR5LH0RCbEY80Dd0qBXjwg2oMFYFrqgFCJamQPQbfjxXxz1+ Xa4Wq5sj6EohP54BywuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVDl5-0007ch-Tw; Fri, 07 Dec 2018 10:53:23 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVDkX-0006xz-Q1 for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 10:52:51 +0000 Received: by mail-wm1-x341.google.com with SMTP id r24so1053196wmh.0 for ; Fri, 07 Dec 2018 02:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8/vQo9Rx195PT21mlOBWdYcriHO5lvZbWlk7QCDAmXo=; b=CPEXXHMjRhhS39zsmYQRXgQ41ROFhA6OBSITXP3xZaSCAvZqjjRaXEUrF7KPSa2Cqj DBrWd1L/JBB/d/9XtURupDhApWy/f6SduIpc0Oo/KjExm6uGXbvSwz/ClJcm0Q3jSIDt GVVCiaKtVDaxEoqhxsqKhLRx4s53Yw6lp9tinN+GqJYV62HOcfxEPF+MRUO3MFckOyDp W4HoOgY0kGU5Kn+7xCfERETd2pix6ltluhU8ZB/VlhaoWajlAKPMAgfbaoGzDFNNBp4L 0N7hf9CnYdrprgavVI2fCSWAS7kY4XCKQFhFeScFvHRY2y9kwYj6ewK9dCMlMBRN6fw9 wqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8/vQo9Rx195PT21mlOBWdYcriHO5lvZbWlk7QCDAmXo=; b=YXM9JiKMkjFYwxwQyFZRuiA90ZrI0xO1ZFw+aUGiGZ1z7WkuMNUQZOVjWcYTunq2+h qUzY4dfWj6s5mJHUBG3GsCBuIq6/VOxSk4xJ/mqk/h5O0lKhN7YdtXM8ykXXAL/5M74Y OEXWgFQa6HV+/Vts5WJtqQLvemeOqaq+6AS04TTMH6Aa2i5HlnDwPMZqfczhgdfpZjoV yMHoltNqPI/rkioR5zhTXYSKMoIObI+CUnva+EqnmPkodVvcyjaIG+GJ4cOXQaj7aO0E a1VCcyc0cLbrPHAIvo7tUlYZ5R7zaG/SdqqQdyeIa2VzBlmr38D7N+eq9aJkzLOqAYpp q8GA== X-Gm-Message-State: AA+aEWb78ucX6cL6tUOVwnMe9KciWle0fcfQUOd4r8VBvU6/O7Y/ijUf Nbce4OIRraepTCRIqz7RcvGuNQ== X-Google-Smtp-Source: AFSGD/UGklAC1lTwzrN+f06JJI246eXUpGvGQHAgDX0oone1PcSvJx5IUVtIAAh9qnW3ork+ZM7cZQ== X-Received: by 2002:a1c:ce0e:: with SMTP id e14mr1891764wmg.53.1544179956883; Fri, 07 Dec 2018 02:52:36 -0800 (PST) Received: from xps.home ([2a00:23c4:f7a1:ce00:800d:14be:d1d:88c5]) by smtp.gmail.com with ESMTPSA id v187sm1234684wme.0.2018.12.07.02.52.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 02:52:35 -0800 (PST) From: Carlo Caione To: robh+dt@kernel.org, mark.rutland@arm.com, khilman@baylibre.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, martin.blumenstingl@googlemail.com, ingrassia@epigenesys.com Subject: [PATCH v2 1/2] arm64: dts: meson: Fix IRQ trigger type for macirq Date: Fri, 7 Dec 2018 10:52:30 +0000 Message-Id: <20181207105231.25593-2-ccaione@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181207105231.25593-1-ccaione@baylibre.com> References: <20181207105231.25593-1-ccaione@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_025249_843169_28E04C39 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlo Caione Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A long running stress test on a custom board shipping an AXG SoCs and a Realtek RTL8211F PHY revealed that after a few hours the connection speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time the 'macirq' (eth0) IRQ would stop being triggered at all and as consequence the GMAC IRQs never ACKed. After a painful investigation the problem seemed to be due to a wrong defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of EDGE_RISING. The change in the macirq IRQ type also solved another long standing issue affecting this SoC/PHY where EEE was causing the network connection to die after stressing it with iperf3 (even though much sooner). It's now possible to remove the 'eee-broken-1000t' quirk as well. Fixes: feb3cbea0946 ("ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage") Fixes: 6d28d577510f ("ARM64: dts: meson-axg: fix ethernet stability issue") Reviewed-by: Jerome Brunet Tested-by: Jerome Brunet Acked-by: Neil Armstrong Signed-off-by: Carlo Caione --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 1 - arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 - arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 1 - 5 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts index 18778ada7bd3..4d57363ac536 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts @@ -357,7 +357,6 @@ eth_phy0: ethernet-phy@0 { /* Realtek RTL8211F (0x001cc916) */ reg = <0>; - eee-broken-1000t; }; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index df017dbd2e57..b1a42e99cb67 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -143,7 +143,7 @@ compatible = "amlogic,meson-axg-dwmac", "snps,dwmac"; reg = <0x0 0xff3f0000 0x0 0x10000 0x0 0xff634540 0x0 0x8>; - interrupts = ; + interrupts = ; interrupt-names = "macirq"; clocks = <&clkc CLKID_ETH>, <&clkc CLKID_FCLK_DIV2>, diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi index f1e5cdbade5e..58e6bcaac1d8 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi @@ -462,7 +462,7 @@ compatible = "amlogic,meson-gx-dwmac", "amlogic,meson-gxbb-dwmac", "snps,dwmac"; reg = <0x0 0xc9410000 0x0 0x10000 0x0 0xc8834540 0x0 0x4>; - interrupts = ; + interrupts = ; interrupt-names = "macirq"; status = "disabled"; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 54954b314a45..f8d1cedbe600 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -143,7 +143,6 @@ interrupt-parent = <&gpio_intc>; /* MAC_INTR on GPIOZ_15 */ interrupts = <29 IRQ_TYPE_LEVEL_LOW>; - eee-broken-1000t; }; }; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi index 70325b273bd2..ec09bb5792b7 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi @@ -142,7 +142,6 @@ eth_phy0: ethernet-phy@0 { /* Realtek RTL8211F (0x001cc916) */ reg = <0>; - eee-broken-1000t; }; }; }; From patchwork Fri Dec 7 10:52:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Caione X-Patchwork-Id: 10717917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F37C713BF for ; Fri, 7 Dec 2018 10:53:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E19022E041 for ; Fri, 7 Dec 2018 10:53:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D525A2E05B; Fri, 7 Dec 2018 10:53:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 825842E041 for ; Fri, 7 Dec 2018 10:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xBUTOrHaGvlUxBZVrGwUvTPanXbtI3eSAICLrkRTByI=; b=EQH1xqGMP9pUDF gqnH70C+E9DmD9equMwHWCSmbpz7mEVrM+h4SLAmtIXAhi8dak/5QL1uDVn2HJM1K/3PanQ1An5mL yAHlnv1goZFYzytNCi49Iry2o0efZxtFr4dQQ3MlRHI/8zcbognToT29wHYgAhvWIs/xjSDrKcnUL UlYmw2i+9dD1tZc7pVnUgrwxqJwn3j5GiWi7jy8RhoeZGdXvSGz3CaAGzFs2UjVeRQs7YIIGdTlEu Lvg5DvglQWv97gSNCSAp8WWxWcOrVTij6rMf+iclMZ4tNv0QLoWOPJENPbaXePQLhN6XW68p/YFC+ um0PgmcIKZw+C8e9r6AA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVDki-00078W-0t; Fri, 07 Dec 2018 10:53:00 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVDkV-0006y2-PJ for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 10:52:49 +0000 Received: by mail-wr1-x441.google.com with SMTP id x10so3344394wrs.8 for ; Fri, 07 Dec 2018 02:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6va9uCpYQugXPSPBSUpN4XAYRxV90Vj9sDt46ZNv9ts=; b=m/xjIQul5bLIpHPVnJh8BrKkQ+u5UclD6qHu2ItZoXL74vA2ev5euMuA9dvp8QDUgl Aa+O4demh3SmZ3IgbvdMeFMUPlLR5wML1NiO+wz8e0T6DZ69OZCDYW64zInSRj1pY33e zf5UCVouqP6pA22G0j10AVN5fXzCOM0GBfmbG0AMuI9Rx1rwQGbxCACEWAnTgpjXpEdz jGg/e/r5ypO5ig+y9D6bPAEfbouvLYERqelvoF8wIMRp+SPmW6ldVQ1ydT0zsNrKn84P xGTFpIqG54vrILtJTzA/uUPFDFN8byflbhv9Qw1gAS2MrcI1r80c7CjlA2VWzLZqN3Vc 13xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6va9uCpYQugXPSPBSUpN4XAYRxV90Vj9sDt46ZNv9ts=; b=RJs6ZdaNB5l++mcg+puD7xT/tnvfbn4AliZ8l+edEiYdbab2+LfqKCDlNUxP+tLJYR +xJaDouwr9PFMuy6agONkRJ6q+Rt92WcgDbbe92HiDIutZwQdsIAsqL96vGoR5nvqBNM mHNG1FhIh44zGKVtUhHpbdNxLTF9M4SfCL/zV/ZjynNH9myweJIBWSRexR/ZbMn/FQ2p o2Gqf99QhLFzYATzHt1q5jTNJRr8T+FAMyxYbUZ2JfzbkhPhC4U7ljdeoU91s8NBaNGx Vp6YZz/euR09vu4laVOEWDdVY1Z5BlAXDk5kVvtKhWuolLP7301OfpEaQA7DA2QgejIZ /JrA== X-Gm-Message-State: AA+aEWYG26d/bGB+KuPafxdrqr+Ze/eGkpaQL2W+klsFDPGimDXcf+Ke W5Zpe5n/puTVnXqoX3EZVeQYZw== X-Google-Smtp-Source: AFSGD/W+6e8OTSkktO6mTygdCjZITLqRjnvxbt2LNkQV1c7hs+Xf5Z7xrMnV9GoZIVHHN7lYWQD+cA== X-Received: by 2002:adf:ce02:: with SMTP id p2mr1499958wrn.185.1544179957940; Fri, 07 Dec 2018 02:52:37 -0800 (PST) Received: from xps.home ([2a00:23c4:f7a1:ce00:800d:14be:d1d:88c5]) by smtp.gmail.com with ESMTPSA id v187sm1234684wme.0.2018.12.07.02.52.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 02:52:37 -0800 (PST) From: Carlo Caione To: robh+dt@kernel.org, mark.rutland@arm.com, khilman@baylibre.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, martin.blumenstingl@googlemail.com, ingrassia@epigenesys.com Subject: [PATCH v2 2/2] arm: dts: meson: Fix IRQ trigger type for macirq Date: Fri, 7 Dec 2018 10:52:31 +0000 Message-Id: <20181207105231.25593-3-ccaione@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181207105231.25593-1-ccaione@baylibre.com> References: <20181207105231.25593-1-ccaione@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_025247_878750_66FB61FA X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlo Caione Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A long running stress test on a custom board shipping an AXG SoCs and a Realtek RTL8211F PHY revealed that after a few hours the connection speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time the 'macirq' (eth0) IRQ would stop being triggered at all and as consequence the GMAC IRQs never ACKed. After a painful investigation the problem seemed to be due to a wrong defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of EDGE_RISING. The change in the macirq IRQ type also solved another long standing issue affecting this SoC/PHY where EEE was causing the network connection to die after stressing it with iperf3 (even though much sooner). It's now possible to remove the 'eee-broken-1000t' quirk as well. Fixes: 9c15795a4f96 ("ARM: dts: meson8b-odroidc1: ethernet support") Signed-off-by: Carlo Caione Reviewed-by: Martin Blumenstingl Tested-by: Martin Blumenstingl --- arch/arm/boot/dts/meson.dtsi | 2 +- arch/arm/boot/dts/meson8b-odroidc1.dts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi index 0d9faf1a51ea..a86b89086334 100644 --- a/arch/arm/boot/dts/meson.dtsi +++ b/arch/arm/boot/dts/meson.dtsi @@ -263,7 +263,7 @@ compatible = "amlogic,meson6-dwmac", "snps,dwmac"; reg = <0xc9410000 0x10000 0xc1108108 0x4>; - interrupts = ; + interrupts = ; interrupt-names = "macirq"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index 58669abda259..a951a6632d0c 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -221,7 +221,6 @@ /* Realtek RTL8211F (0x001cc916) */ eth_phy: ethernet-phy@0 { reg = <0>; - eee-broken-1000t; interrupt-parent = <&gpio_intc>; /* GPIOH_3 */ interrupts = <17 IRQ_TYPE_LEVEL_LOW>;