From patchwork Thu Aug 19 03:25:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 12446145 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F459C4320E for ; Thu, 19 Aug 2021 03:31:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1108561104 for ; Thu, 19 Aug 2021 03:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236615AbhHSDcT (ORCPT ); Wed, 18 Aug 2021 23:32:19 -0400 Received: from lpdvacalvio01.broadcom.com ([192.19.166.228]:51438 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236672AbhHSDcP (ORCPT ); Wed, 18 Aug 2021 23:32:15 -0400 Received: from dhcp-10-192-206-197.iig.avagotech.net.net (dhcp-10-123-156-118.dhcp.broadcom.net [10.123.156.118]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id BDB238281; Wed, 18 Aug 2021 20:25:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com BDB238281 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1629343559; bh=0k3EeimI0ew9ITFTZNxwUwsrZ6iHZFG5t8Xx/JwD79o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gtTgCqbcyBWLgWquAJpXsjm/kX12at5BLALT96dHmAgPsFE9v7HNTK4wCZcsNOY/l Izdpv4taJMmu16GGy3Lmy6NgZKcevGH6KwV1Vd9EhB5+8y+iDYGncttw7h5ACuUs8K lZxM81VB8/I7IzQ5nBi3BULlv6z7QRABw7z3HkFo= From: Selvin Xavier To: jgg@ziepe.ca, dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier Subject: [PATCH rdma-rc v2 1/3] RDMA/bnxt_re: Disable atomic support on VFs Date: Wed, 18 Aug 2021 20:25:51 -0700 Message-Id: <1629343553-5843-2-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> References: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Atomics is not currently supported for VFs. Enabling only for PFs. Fixes: 35f5ace5dea4 ("RDMA/bnxt_re: Enable global atomic ops if platform supports") Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index a8688a9..0b870be 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -129,7 +129,7 @@ static int bnxt_re_setup_chip_ctx(struct bnxt_re_dev *rdev, u8 wqe_mode) rdev->rcfw.res = &rdev->qplib_res; bnxt_re_set_drv_mode(rdev, wqe_mode); - if (bnxt_qplib_determine_atomics(en_dev->pdev)) + if (!BNXT_VF(bp) && bnxt_qplib_determine_atomics(en_dev->pdev)) ibdev_info(&rdev->ibdev, "platform doesn't support global atomics."); return 0; From patchwork Thu Aug 19 03:25:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 12446143 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B316C4338F for ; Thu, 19 Aug 2021 03:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44D356103A for ; Thu, 19 Aug 2021 03:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236576AbhHSDcT (ORCPT ); Wed, 18 Aug 2021 23:32:19 -0400 Received: from relay.smtp-ext.broadcom.com ([192.19.166.228]:51430 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236596AbhHSDcP (ORCPT ); Wed, 18 Aug 2021 23:32:15 -0400 Received: from dhcp-10-192-206-197.iig.avagotech.net.net (dhcp-10-123-156-118.dhcp.broadcom.net [10.123.156.118]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id AC549829E; Wed, 18 Aug 2021 20:25:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com AC549829E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1629343561; bh=MDUa583p1LyQlRKHFB/ppvO/e+RnChJuBpIZiy3FxzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pZe3Bi0slf1RsoCx0g5m/3WDbfKQ18GPNNnXe9HiZBM0Wy/zKPXy5vyaVQTJNPk4l WOjzwFzuboVBvZR3HIVh6NTApU7v97uGEnc+7t6ibuIz3PBfUFUu7l+pSKUYsDUN6h Y9AZJHN80lE7A/7ujPkjkfh0d+XCpR9mbrS7hAQA= From: Selvin Xavier To: jgg@ziepe.ca, dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Naresh Kumar PBS , Selvin Xavier Subject: [PATCH rdma-rc v2 2/3] RDMA/bnxt_re: Add missing spin lock initialization Date: Wed, 18 Aug 2021 20:25:52 -0700 Message-Id: <1629343553-5843-3-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> References: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Naresh Kumar PBS Add the missing initialization of srq lock. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Naresh Kumar PBS Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index 283b6b8..ea0054c 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1681,6 +1681,7 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, if (nq) nq->budget++; atomic_inc(&rdev->srq_count); + spin_lock_init(&srq->lock); return 0; From patchwork Thu Aug 19 03:25:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 12446141 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CD9C432BE for ; Thu, 19 Aug 2021 03:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07E986044F for ; Thu, 19 Aug 2021 03:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236658AbhHSDcS (ORCPT ); Wed, 18 Aug 2021 23:32:18 -0400 Received: from relay.smtp-ext.broadcom.com ([192.19.166.228]:51428 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbhHSDcP (ORCPT ); Wed, 18 Aug 2021 23:32:15 -0400 X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Aug 2021 23:32:15 EDT Received: from dhcp-10-192-206-197.iig.avagotech.net.net (dhcp-10-123-156-118.dhcp.broadcom.net [10.123.156.118]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id D8D8C2181E; Wed, 18 Aug 2021 20:26:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com D8D8C2181E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1629343563; bh=DwSY61xYq492Pv4BaUB7pMO5Me20+0qO76ocGtgwS94=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BMCiHXjFQwE1ip/RMZ+99kQBPpbNXH6eD3T0iQNKgptzEM8kH9aYexForL/enBRIx ntQb908FOjTMj8YQqqgX4qS6GUL8TDHvu7EWSBGfmEpDec5oVbnmu2lr9QK2yBLpBC DTzbefX+qn+XZiOk0cREl767Vc87hYuGHNptBwpk= From: Selvin Xavier To: jgg@ziepe.ca, dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier , Naresh Kumar PBS Subject: [PATCH rdma-rc v2 3/3] RDMA/bnxt_re: Fix query SRQ failure Date: Wed, 18 Aug 2021 20:25:53 -0700 Message-Id: <1629343553-5843-4-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> References: <1629343553-5843-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fill the missing parameters for the FW command while querying SRQ. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Naresh Kumar PBS Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index d4d4959..312bf25 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -713,6 +713,8 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res, sbuf = bnxt_qplib_rcfw_alloc_sbuf(rcfw, sizeof(*sb)); if (!sbuf) return -ENOMEM; + req.resp_size = sizeof(*sb) / BNXT_QPLIB_CMDQE_UNITS; + req.srq_cid = cpu_to_le32(srq->id); sb = sbuf->sb; rc = bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, (void *)sbuf, 0);