From patchwork Fri Dec 7 14:28:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 10718315 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 89E711731 for ; Fri, 7 Dec 2018 14:29:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76F922DD44 for ; Fri, 7 Dec 2018 14:29:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 62F832E294; Fri, 7 Dec 2018 14:29:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFF612DD44 for ; Fri, 7 Dec 2018 14:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+kIarU8sjMQQTkVCis/tV9jZRdcDOHCEHN+PjlFHvog=; b=HMBDYv3p76hT+N r/dK+2XqTTDLK7WxyWc9hUGQ8zWz0pAWSK8fPiWDNp59ROTJstuFyH8/gOjLpyjNPbMfiJsfyalZa fYNyph5qqpsPLR+YDU/HgmoKdpGxs0JK0WFTSlFWOpFRE2GvhQE9PwlqpioLVb12ysDEPrLwpkNMl 5QelBSj3nTTxRzr9kOHKpoNwtjIVkJjMsJis09TuKBU3nBImmtZHaDPlrjqhNiYX1G3gt6+fokzIx Ixp8HrdfEtCbi18IEGHbrTvEasbMJqY28RsCJCAC7KUg7Skv3QKZvN+URWEdCjyO8Vh28wuiFYbBa 3peuqFh+pu0F85aG1ibw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVH8C-0007hy-IV; Fri, 07 Dec 2018 14:29:28 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVH7z-0007Vg-28 for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 14:29:16 +0000 Received: by mail-lf1-x142.google.com with SMTP id u18so3150248lff.10 for ; Fri, 07 Dec 2018 06:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S+OENI6YtzSczLSuymPnFLAriTDDg6DPhxH59mLlxng=; b=Wx9N47JXA0kxNsiHKrumv040W7czuEfj/tQSCfblQxXVckW73b2Z5wN2DcD7Ig9y63 0JwoRZDcFjcV3E+42WvSntm3HZnYAzYsMMJyoCe1oy9ALzbJraLdfH75MohITf8jcXZm +4EGkgFxEOedNHjlSM033SO1Dw+tVZrTdONNCchri5jahpXrn4ZHNs1cjA6txoCVyKFk PENspGs45go8eoOtO1zQFKVZKk6Zucc9YeYtmqgtzp8VN6nKVjGkKrIuwBRHKyt0P5rN NJcIWpu8tJn45jmpe1YL8ggeJGbHF5HfvLwjvKWKLgTKRMzyV1hawSpRtDcHS9xr8f4X 3kJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S+OENI6YtzSczLSuymPnFLAriTDDg6DPhxH59mLlxng=; b=Cs2miu6S5e3pnIoqtvQnYh1MqPF/ATKDlousct2I9IZItlflO2YkdgmjDZK92+QlHk 1/tUpBdqeg79+8xwRpvKpY3glG6nX3t1lDXNEFI5SbJSx0FwDdMcf9iX/2EGAVtL62i0 gVbtKySCktiRnvQjkzRZWQEgzAaeuWBxAeZsGw3si0hhpTHvrviKwA61zoOqZogH9y0s DsJuWeyd7XjMdWd4HKW3MP+CB0DNGy8er7ohlbnBlpQh6Lu37cE+4/LhSx5pcw7wQIyJ I7K8nssJFcqqALeSSyKH0KdEo5ZtHjw5LYsS56PN09YhFTkSvLMe2NdBks2vn/PU21/+ 4dig== X-Gm-Message-State: AA+aEWbWAJ6p2ea9n8wOH6w2qgKxWmeqFvFrHptIU6JBRqGzopdh0Znm 0J/R2y/MvJCSZyXtH1ikeqmurr/mgao= X-Google-Smtp-Source: AFSGD/Xel2TAfxU/X85KmS2yoOaa1eMH70+7GtbBT3zSR22gSbGsDe46di7TQVf6SYoJPVUlKA0YMw== X-Received: by 2002:a19:280f:: with SMTP id o15mr1461603lfo.0.1544192943060; Fri, 07 Dec 2018 06:29:03 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:74d5:51ba:2673:f3f4]) by smtp.googlemail.com with ESMTPSA id v64sm630504lfa.48.2018.12.07.06.29.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 06:29:02 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: nick@shmanahar.org Subject: [PATCH v4 1/3] Input: atmel_mxt_ts: Add support for optional regulators Date: Fri, 7 Dec 2018 15:28:55 +0100 Message-Id: <20181207142857.15818-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> References: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_062915_107341_59B3E393 X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds optional regulators, which can be used to power up touchscreen. After enabling regulators, we need to wait 150msec. This value is taken from official driver. It was tested on Samsung Galaxy i9000 (based on Samsung S5PV210 SOC). Signed-off-by: Paweł Chmiel --- Changes from v3: - Fix checkpatch issues - Drop sentence punctuation from subject of one of patches Changes from v2: - Move code enabling regulators into separate method, to make code more readable. Changes from v1: - Enable regulators only if reset_gpio is present. - Switch from devm_regulator_get_optional to devm_regulator_get --- drivers/input/touchscreen/atmel_mxt_ts.c | 65 +++++++++++++++++++++--- 1 file changed, 59 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d3aacd534e9c..1dc8ad0da5af 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -194,10 +195,10 @@ enum t100_type { /* Delay times */ #define MXT_BACKUP_TIME 50 /* msec */ -#define MXT_RESET_GPIO_TIME 20 /* msec */ #define MXT_RESET_INVALID_CHG 100 /* msec */ #define MXT_RESET_TIME 200 /* msec */ #define MXT_RESET_TIMEOUT 3000 /* msec */ +#define MXT_REGULATOR_DELAY 150 /* msec */ #define MXT_CRC_TIMEOUT 1000 /* msec */ #define MXT_FW_RESET_TIME 3000 /* msec */ #define MXT_FW_CHG_TIMEOUT 300 /* msec */ @@ -323,6 +324,8 @@ struct mxt_data { struct t7_config t7_cfg; struct mxt_dbg dbg; struct gpio_desc *reset_gpio; + struct regulator *vdd_reg; + struct regulator *avdd_reg; /* Cached parameters from object table */ u16 T5_address; @@ -3038,6 +3041,38 @@ static const struct dmi_system_id chromebook_T9_suspend_dmi[] = { { } }; +static int mxt_regulator_enable(struct mxt_data *data) +{ + int error; + + if (data->reset_gpio) { + error = regulator_enable(data->vdd_reg); + if (error) { + dev_err(&data->client->dev, + "Failed to enable vdd regulator: %d\n", error); + return error; + } + + error = regulator_enable(data->avdd_reg); + if (error) { + dev_err(&data->client->dev, + "Failed to enable avdd regulator: %d\n", error); + return error; + } + + /* + * According to maXTouch power sequencing specification, + * RESET line must be kept low until some time + * after regulators come up to voltage + */ + msleep(MXT_REGULATOR_DELAY); + gpiod_set_value(data->reset_gpio, 1); + msleep(MXT_RESET_INVALID_CHG); + } + + return 0; +} + static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct mxt_data *data; @@ -3098,6 +3133,22 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) return error; } + data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); + if (IS_ERR(data->vdd_reg)) { + error = PTR_ERR(data->vdd_reg); + dev_err(&client->dev, "Failed to get vdd regulator: %d\n", + error); + return error; + } + + data->avdd_reg = devm_regulator_get(&client->dev, "avdd"); + if (IS_ERR(data->avdd_reg)) { + error = PTR_ERR(data->avdd_reg); + dev_err(&client->dev, "Failed to get avdd regulator: %d\n", + error); + return error; + } + error = devm_request_threaded_irq(&client->dev, client->irq, NULL, mxt_interrupt, IRQF_ONESHOT, client->name, data); @@ -3108,11 +3159,9 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) disable_irq(client->irq); - if (data->reset_gpio) { - msleep(MXT_RESET_GPIO_TIME); - gpiod_set_value(data->reset_gpio, 1); - msleep(MXT_RESET_INVALID_CHG); - } + error = mxt_regulator_enable(data); + if (error) + return error; error = mxt_initialize(data); if (error) @@ -3138,6 +3187,10 @@ static int mxt_remove(struct i2c_client *client) struct mxt_data *data = i2c_get_clientdata(client); disable_irq(data->irq); + if (data->reset_gpio) { + regulator_disable(data->avdd_reg); + regulator_disable(data->vdd_reg); + } sysfs_remove_group(&client->dev.kobj, &mxt_attr_group); mxt_free_input_device(data); mxt_free_object_table(data); From patchwork Fri Dec 7 14:28:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 10718317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6B821731 for ; Fri, 7 Dec 2018 14:29:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5F912DD44 for ; Fri, 7 Dec 2018 14:29:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C40542E294; Fri, 7 Dec 2018 14:29:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 78F642DD44 for ; Fri, 7 Dec 2018 14:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tTGt/FfIRYHY2bYXQXlsZ2X7WEAhc91eZO/pacersWU=; b=L6wKXPi73NEv/0 qv4yTu7zzuFLx3c1+bjcCzT9Y02brpFDKCDYqVxn6+iEOyedtuw/CbBJRdw3grN8yy5vP7u4mIcOg lcnpOEXBBEqp9Lsdv0QB4CPUL1YKIEhOHJky6q2ZU5VJUDo9f4Ba5kYFwlEYKF4rJYS9DSmivpdxb IDHLtuDAaCKfIOLXaRNmqgoMbHt+P/Uexlrm9eJWQdHDWpW+Mpqv5lZdhJjPqqnAqSMt9egYEj2O+ uDWLDT/29ipbkXeofrJKmM2c48pgkZPYGbK/hM2I7CU1tWcjbbflAGGYWc9wzHSARcZK8epBpFzF8 +7gRUs2ETeAOzZ92eNuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVH8P-0007v1-DP; Fri, 07 Dec 2018 14:29:41 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVH80-0007Vj-Dm for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 14:29:17 +0000 Received: by mail-lj1-x244.google.com with SMTP id k19-v6so3691238lji.11 for ; Fri, 07 Dec 2018 06:29:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vWNAi8KA5a8AOePm/F4rK7ibKNtgPheT1xDfWNYRieY=; b=e11A58l1OICddwBkd3QPB4OcLgtsliFd4zjJy+N9bQGigToT/1BMutBRd+QtlEq0pO 5LILs7A2Lq1IguK022EApnKfxclTwl6Lk0siOrwEnjOvMPWwhwnJMb7K4znBRl9PMqjY 7iFelOBgQN4qdgQ/Ccn71jD9m5ARPDAyzAvvTuwyZJdkdOqe4qqG2KbuO7F0zu4UqMCq Lbkf79c1fmzl0DIr3/R25r1Z4JJQvquvrsGcs29lV26z6fLl7+MasKIYjRGOeXXScP7k N2bKdnFvRiRdLSBowMW92NXuKlUeaLSqP30c9FPFmpiBbJ9DI5T9b7crQLPV/KH7geN0 ZxbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vWNAi8KA5a8AOePm/F4rK7ibKNtgPheT1xDfWNYRieY=; b=lrSci2010WCaiUYKj1G/2gPiwSgfiCg4fS4O8fjgIwwGiv5wGToUaz/YPRbO71ZdhV bYGQPsJHPwx8AuWY3vjU12GTQyDmcqevIbqoHerETCZfq8KqxkKMMuBtocZUrfOIrbTp SYKCdNXlK6Mo1NTbRHTSXhMjguCGGKePTO/J0wYIh39+Si8fz7Z3obtA+tDPBrjsQTpl EkBKuJ0JSumlaNGF7ghB8he4DJVI6CM42wSvTNIXkh01jB1TiFEJqF85evp5lWCww4JT 93dSVD/ycdtKWb9u8cydEYqsCkOgab3Mt/zAImOjo8IiIMFzA2SIupkKI2NcXFGMn65Y nPQA== X-Gm-Message-State: AA+aEWaI4Tw6D9R0/tHXNJF6uX7+wjjz2JHMndsGigkKqzvp8Ojr4HX6 xe2tMb+wCf0CtuzoSdmBwq0= X-Google-Smtp-Source: AFSGD/Up/wbof3FtQRCE3rUT1ZzDsRe88dk6wQP8OjxkQVHawaLT5xP91x8lz8V2gRHiotkgE7dz3g== X-Received: by 2002:a2e:994:: with SMTP id 142-v6mr1316978ljj.120.1544192944605; Fri, 07 Dec 2018 06:29:04 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:74d5:51ba:2673:f3f4]) by smtp.googlemail.com with ESMTPSA id v64sm630504lfa.48.2018.12.07.06.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 06:29:04 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: nick@shmanahar.org Subject: [PATCH v4 2/3] Input: atmel_mxt_ts: Wait for device be ready for communication Date: Fri, 7 Dec 2018 15:28:56 +0100 Message-Id: <20181207142857.15818-3-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> References: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_062916_460425_894B6573 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP According to documentation, device isn't ready for communication, until firmware asserts the CHG line. Add missing wait for this. Signed-off-by: Paweł Chmiel --- Changes from v3: - Fix checkpatch issues --- drivers/input/touchscreen/atmel_mxt_ts.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 1dc8ad0da5af..3f956d07d09e 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -202,6 +202,7 @@ enum t100_type { #define MXT_CRC_TIMEOUT 1000 /* msec */ #define MXT_FW_RESET_TIME 3000 /* msec */ #define MXT_FW_CHG_TIMEOUT 300 /* msec */ +#define MXT_POWERON_DELAY 150 /* msec */ /* Command to unlock bootloader */ #define MXT_UNLOCK_CMD_MSB 0xaa @@ -3068,6 +3069,16 @@ static int mxt_regulator_enable(struct mxt_data *data) msleep(MXT_REGULATOR_DELAY); gpiod_set_value(data->reset_gpio, 1); msleep(MXT_RESET_INVALID_CHG); + +retry_wait: + reinit_completion(&data->bl_completion); + data->in_bootloader = true; + error = mxt_wait_for_completion(data, &data->bl_completion, + MXT_POWERON_DELAY); + if (error == -EINTR) + goto retry_wait; + + data->in_bootloader = false; } return 0; From patchwork Fri Dec 7 14:28:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 10718323 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6B34109C for ; Fri, 7 Dec 2018 14:41:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C53A02E294 for ; Fri, 7 Dec 2018 14:41:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B95592E484; Fri, 7 Dec 2018 14:41:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 585172E323 for ; Fri, 7 Dec 2018 14:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vk/0v38ub7BW/laUWrkGZfffltDq94dC7NSuXPeQE78=; b=NoEDI13oqzY0Vu bYTY3KXLdVkYFQR229M3Zu9/mvVgmt0IjKp2z2ZP6uAVQsO/Q43Xfrec/kOkzCkMbATtCMbh8yWMw CmHU47lLOo3LFDu03ezIcEZhoRqIF+8o831J19+rh6t0VVm+7PdTKplksOtmmFRadWJ7mOAQhqUwD 5n8Geyrvf/QyvpgTi9UovpYH7s4FHaKNMrmfCt4SE7v9Bz5J1m0daVPPivEI2eeR2PlW646Mz+uah Tu08u8m8tSG86w8OMQGlqc9k0Wco6kBYqGKbhlFtvtkma7/lRbmKBEBH1bInYb/TxVB0Idgq5BLOu Oh5X9v6qCVQy213AZnTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVHJQ-0005mX-6x; Fri, 07 Dec 2018 14:41:04 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVH81-0007Vm-T5 for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 14:29:21 +0000 Received: by mail-lf1-x143.google.com with SMTP id b20so3135866lfa.12 for ; Fri, 07 Dec 2018 06:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XFPTtMJpSFiF4PFAqSj6g1FCx0iqQrUaJq/0mQ1Us/I=; b=rnRExS/ioqXRd7pl9X9/WxnSDOkSz5BlvCsll1C0iOnrGjkL+YxDK5AG/ixFIJwLnj uBHkR/0kUmi2Vs3Gm3RSwug2RKF3WqLC0Z7P+4IJk4FsG4C+wD+M22uk3m9+G6fBWPjN y0v/Pmc+6RX9W7VLoifWD1QgiUtol9TfYdYDwd2d8gfrGngaWdq+6KEzhDbvEKCrkJZs jsOty8TBA9RGkBI0wEGUMB/zie8GdzJQWbpWSUP3UWXtVA2IEO0CrfGjKrmYxQokmk1E 6xsSukU69ObfUN02s9DCMgGqfi9FKRY7YtAp8JUvw9TWjb+aNzazjNFGGQOIwlWxG7MV IoWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XFPTtMJpSFiF4PFAqSj6g1FCx0iqQrUaJq/0mQ1Us/I=; b=KJEUDM/JZF2CxMPwrEuGxPO1V858DjGtBwF1SRgin23cEU2NVZnBb6jS18xjx81QoX P9XVyX80b19KGz66eT+cX0AhmHLNMTwd5lzlZKNZ7uXaBD9oxS6J2ib/dPALoreEhoGr TBoBfmDy9BYyImExPxxane+qyJJWuAvwYDg3EWZf28CBJiJyH+7aWJUdOCtn/DrNvB+Q HdUjb7hKHj4nm65AuK9znfn6ntXdcOzNyB0VoHd/dyJwNmxFHKbkeP5FRpUMqUeeunkC RsgDI/jb2fb7WnaSNRAUSfaSkWjrBWQSHMGYBMmZLnoqxJiLo3fsBowxPV8PvgIh8FiH Dtqw== X-Gm-Message-State: AA+aEWbpDslISk7cwZiVUNtD/OnXUyIDwGt+8VkLLLQRJyvUEyf/lGsr 79GuuSZUT+6gEUsNJAWXRoE= X-Google-Smtp-Source: AFSGD/UJGLWQZxgX4zc/qOv5w0brAukTjLL/vMZ7TccXHJhOgYWzodEmqX/Piod2kwFhkAi+/CaztQ== X-Received: by 2002:a19:1d0d:: with SMTP id d13mr1430771lfd.74.1544192945963; Fri, 07 Dec 2018 06:29:05 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:74d5:51ba:2673:f3f4]) by smtp.googlemail.com with ESMTPSA id v64sm630504lfa.48.2018.12.07.06.29.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 06:29:05 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: nick@shmanahar.org Subject: [PATCH v4 3/3] Input: atmel_mxt_ts: Document optional voltage regulators Date: Fri, 7 Dec 2018 15:28:57 +0100 Message-Id: <20181207142857.15818-4-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> References: <20181207142857.15818-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_062918_196429_65E8CAF1 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Document new optional voltage regulators, which can be used to power down/up touchscreen. Signed-off-by: Paweł Chmiel Reviewed-by: Rob Herring --- Changes from v1: - Added reviewed-by --- .../devicetree/bindings/input/atmel,maxtouch.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt index c88919480d37..17930ecadad3 100644 --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt @@ -31,6 +31,12 @@ Optional properties for main touchpad device: - reset-gpios: GPIO specifier for the touchscreen's reset pin (active low) +- avdd-supply: Analog power supply. It powers up the analog channel block + of the controller to detect the touches. + +- vdd-supply: Digital power supply. It powers up the digital block + of the controller to enable i2c communication. + Example: touch@4b { @@ -38,4 +44,6 @@ Example: reg = <0x4b>; interrupt-parent = <&gpio>; interrupts = ; + avdd-supply = <&atsp_reg>; + vdd-supply = <&tsp_reg>; };